From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 18 12:07:38 2019 Received: (at submit) by debbugs.gnu.org; 18 Jul 2019 16:07:38 +0000 Received: from localhost ([127.0.0.1]:54564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho8wT-0006zy-Ju for submit@debbugs.gnu.org; Thu, 18 Jul 2019 12:07:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:55725) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho8P5-00061z-Rc for submit@debbugs.gnu.org; Thu, 18 Jul 2019 11:33:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49407) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ho8P4-0006rU-Ns for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 11:33:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ho8P3-0007mE-Os for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 11:33:06 -0400 Received: from wnew2-smtp.messagingengine.com ([64.147.123.27]:35643) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ho8P3-0007lT-AY for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 11:33:05 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id DCDD73F9 for ; Thu, 18 Jul 2019 11:33:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 18 Jul 2019 11:33:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jackc.me; h=from :to:subject:date:message-id:mime-version:content-type; s=fm1; bh=xy9ISsuJjaOY+bnZ7srrEwIFl3ypGAgmEw4b0Knj+tY=; b=F+Pep4x8lKPT nr8Nhuwy383zMbTxtBhiNfUo6xDNvmMsEYMrxEgRxJb035gE5XOakpIRv7ZJgiT8 9KLveAKzIbcQZu+9ZRhXHX2WPiobqG0M/Gb+sEj6JGw0EcX53iWOOSshadoqNZZg aWI3b8RVC6LwPbn0s/sQVXfaF2h5Vb2dfXK1azNXLAM7aYYNUt5pEdKyMKTebmaB YiLFhS5h07h2aDau+y17N7lYMngM1knylf7DhZaf9P99d8ulEsIrZqyaBGJgmSts fhaDr4Yn/epP9dfHU8Bc4EJPrkMXyljvuv/Q1zh59pJpIL842+OsMuWVbyGdtyaL zR+Rtw1m/Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=xy9ISsuJjaOY+bnZ7srrEwIFl3ypG AgmEw4b0Knj+tY=; b=Q0e2xUUJbwpIniuYRZgE9nhSdMg7b5ulm24cjby83SSQj FbUrccGVzqo4PrOiFnoi5noyf2TSIEVQKamnzBGzBWrrIJcEqIDdpwSf4grkqzAn 3akSqdslW0/kP4fYT+xx0w6pKeqPOkfGnQeAxHf14LqbcvynJ2/mGn9CGwJpAGks 7tQ0c8SXt8sk3RloMZiix5JbhjJBuLUVDnyra7Fn+A1pJJrN5RPTWMEofbCDRjX3 AZNozPTC0dLl+pOpNPzJigyn4suxPYMEJiIcOsh3Pzu9fFjLD+ibJG/hdUrGSCzc A5tzvVRUQsuXIHdpsy8gcAXpWcsif4dNvMTphM7Tg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrieehgdelvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfgfhvffufffkgggtsehmtderredtre dtnecuhfhrohhmpeflrggtkhcuvehouhhghhhlihhnuceojhgrtghksehjrggtkhgtrdhm vgeqnecukfhppeduleelrddukeekrdduleegrdefleenucfrrghrrghmpehmrghilhhfrh homhepjhgrtghksehjrggtkhgtrdhmvgenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from Jacks-MacBook-Pro.local (199-188-194-39.public.monkeybrains.net [199.188.194.39]) by mail.messagingengine.com (Postfix) with ESMTPA id 393C480068 for ; Thu, 18 Jul 2019 11:33:02 -0400 (EDT) User-agent: mu4e 1.2.0; emacs 26.2 From: Jack Coughlin To: bug-gnu-emacs@gnu.org Subject: [PATCH] [Calc] Fix saving user-defined compositions Date: Thu, 18 Jul 2019 08:32:48 -0700 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 64.147.123.27 X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 18 Jul 2019 12:07:36 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain When saving a user-defined formula by specifying its ~z-~ key, or the ~M-x~ command name, its compositions are not saved correctly. The attached patch fixes this behavior. --- notes on the code change --- ~func~ is the calcFunc- symbol representing the formula. ~cmd~ is either the calc- symbol representing the command, or, if we are saving just the formula, the calcFunc- symbol. We always want to associate the composition forms to the calcFunc- version. Observe for example that two lines below, this is the symbol that we pull them from to save. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-bug-when-saving-user-defined-commands-with-compo.patch Content-Description: patch >From c65e573fbdff716b91d3a93cb4b79a8ee506adc1 Mon Sep 17 00:00:00 2001 From: Jack Coughlin Date: Thu, 18 Jul 2019 08:16:50 -0700 Subject: [PATCH] Fix bug when saving user-defined commands with compositions This fixes a bug where saving user-defined formulas with compositions would fail to save the compositions when the user specified their formula by its command name or key. --- lisp/calc/calc-prog.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/calc/calc-prog.el b/lisp/calc/calc-prog.el index ba8efd43b8..01b39478c9 100644 --- a/lisp/calc/calc-prog.el +++ b/lisp/calc/calc-prog.el @@ -1097,7 +1097,7 @@ Redefine the corresponding command." (or func (setq func (and cmd (symbolp cmd) (fboundp cmd) cmd))) (if (get func 'math-compose-forms) (let ((pt (point))) - (insert "(put '" (symbol-name cmd) + (insert "(put '" (symbol-name func) " 'math-compose-forms '" (prin1-to-string (get func 'math-compose-forms)) ")\n") -- 2.14.3 (Apple Git-98) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 18 12:16:31 2019 Received: (at control) by debbugs.gnu.org; 18 Jul 2019 16:16:31 +0000 Received: from localhost ([127.0.0.1]:54579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho955-0007G1-BB for submit@debbugs.gnu.org; Thu, 18 Jul 2019 12:16:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho953-0007Fp-Oc for control@debbugs.gnu.org; Thu, 18 Jul 2019 12:16:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59720) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ho94y-0007UK-Li for control@debbugs.gnu.org; Thu, 18 Jul 2019 12:16:24 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ho94y-0003eY-AZ for control@debbugs.gnu.org; Thu, 18 Jul 2019 12:16:24 -0400 Subject: control message for bug 36719 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Thu, 18 Jul 2019 12:16:24 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) forcemerge 36720 36719 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 12 21:50:26 2019 Received: (at 36720) by debbugs.gnu.org; 13 Sep 2019 01:50:26 +0000 Received: from localhost ([127.0.0.1]:44224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i8ajC-0006WF-8y for submit@debbugs.gnu.org; Thu, 12 Sep 2019 21:50:26 -0400 Received: from mail-io1-f48.google.com ([209.85.166.48]:39354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i8ajA-0006Vx-OV; Thu, 12 Sep 2019 21:50:25 -0400 Received: by mail-io1-f48.google.com with SMTP id a1so1402864ioc.6; Thu, 12 Sep 2019 18:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/ekXi4kBe/jaYTN722MYMOe7L8t/j64mmIBNe5fI6ew=; b=fC9V4Ong8v6LJbjz4A3voyk9O+WcNlUcdSUsbuoiA5E8IGcZoqAFjuSj3IsQ4E+2ib jwHQ/tNPs4fQLTJU7FssrjP9FpWv1TXeI4yZbp+VEHVBy3oJPwllZHpVb1u9DZ4qsjzQ dW7MgSs4JTaiRsCoKdvvQcPiLspHEMWeZUsp4hPTjOB+ba0oQaAy1YdaiETRR3Otid8d isCjK4opkMlDkf849IYSUKP9Tz2yJ10vG0O6zoLR6rPvYauE55ziOXHwfhCyBL6I2zCz gvQK48rXKA8qarXG/MnOJVt6wio662PR9I/5lFZz+BynJawK+tMXtvoQieSFGnmrUZzu EIBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/ekXi4kBe/jaYTN722MYMOe7L8t/j64mmIBNe5fI6ew=; b=YcKOnpM+hpeXo7v5FMaOvjHWEkWMWFsujUJymc8Vda19rYcCWMHN33toLNLV7ibwUL SN7XmkqgWj9nLZAK8OAooZniFOfAauAI78GjsFGkCYANZPCUMT/rMvpGNLXkJlAWJxjy tyY2Jr+GuPCFgqtvem14nHpHeTvU3dkWAR0bak2sqCLsTk0FP0PVZmt7rEb2s6jlCrYe ZKBbWBw5CzSQBMeVDjQgNxpJLl5pgHbkuC+PvPGAAmiBUcCG4WyMtyDpSVgs8wI3rCUJ zs5a5T90FqBaHaC+lp2CsSeIz1rkjI6z/tvrVvVjYoyzferiwJfvw7rCmbZ9JWI1G56s Kprw== X-Gm-Message-State: APjAAAVblyRrmZGrojb4qTDVAgWA/MBpMIGx1a34kCA9eH4kagI2y+bU ziEw5sfXmv38SKUcGSMpt1r6f67b X-Google-Smtp-Source: APXvYqwErxBplX7s57IoQYlEk+0xFcWk3b+R/DboR3kAgBBhq1aTNh6ABbmJ2Uh3kMKDJF6r66Tjsg== X-Received: by 2002:a6b:f319:: with SMTP id m25mr2602232ioh.33.1568339419001; Thu, 12 Sep 2019 18:50:19 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id c4sm20872388ioa.76.2019.09.12.18.50.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Sep 2019 18:50:18 -0700 (PDT) From: Noam Postavsky To: Jack Coughlin Subject: Re: bug#36720: [PATCH] [Calc] Fix saving user-defined compositions References: Date: Thu, 12 Sep 2019 21:50:17 -0400 In-Reply-To: (Jack Coughlin's message of "Thu, 18 Jul 2019 08:32:48 -0700") Message-ID: <87pnk59d7q.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36720 Cc: 36720@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 36720 fixed close 36720 27.1 quit Jack Coughlin writes: > When saving a user-defined formula by specifying its ~z-~ key, or the > ~M-x~ command name, its compositions are not saved correctly. The > attached patch fixes this behavior. Thanks, pushed to master. a4c471c984 2019-09-12T20:25:30-04:00 "Fix saving user-defined calc commands with compositions (Bug#36720)" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=a4c471c98474a249948793aad386e4efc64a1c96 From unknown Mon Jun 23 02:22:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 11 Oct 2019 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator