GNU bug report logs - #36709
Likely bug in scm_port_poll

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#36709: closed (Likely bug in scm_port_poll)
Date: Mon, 18 Nov 2019 14:18:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 18 Nov 2019 15:17:29 +0100
with message-id <87k17xi806.fsf <at> gnu.org>
and subject line Re: bug#36709: Likely bug in scm_port_poll
has caused the debbugs.gnu.org bug report #36709,
regarding Likely bug in scm_port_poll
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
36709: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36709
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mark H Weaver <mhw <at> netris.org>
To: bug-guile <at> gnu.org
Subject: Likely bug in scm_port_poll
Date: Wed, 17 Jul 2019 15:25:15 -0400

I sent the following message about a month ago, and now am forwarding to
bug-guile so that we do not forget about it.

       Mark


From: Mark H Weaver <mhw <at> netris.org>
Subject: Likely bug in scm_port_poll
Date: Tue, 18 Jun 2019 00:40:27 -0400
Message-ID: <87a7ef1p61.fsf <at> netris.org>
Cc: guile-devel <at> gnu.org
To: Andy Wingo <wingo <at> pobox.com>

Hi Andy,

If you'd be willing to take a quick look at this, I'd be grateful.
Probably a bug, but I feel uneasy that I might be overlooking something.

scm_port_poll contains the following code:

  if (scm_i_string_contains_char (events, 'r'))
    c_events |= POLLIN;
  if (scm_i_string_contains_char (events, '!'))
    c_events |= POLLPRI;
  if (scm_i_string_contains_char (events, 'w'))
    c_events |= POLLIN;

That second POLLIN should be POLLOUT, right?

      Thanks,
        Mark

https://git.savannah.gnu.org/cgit/guile.git/tree/libguile/ports.c?h=stable-2.2&id=420c2632bb1f48e492a035c1d216f209734f45e6#n1423

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Mark H Weaver <mhw <at> netris.org>
Cc: 36709-done <at> debbugs.gnu.org
Subject: Re: bug#36709: Likely bug in scm_port_poll
Date: Mon, 18 Nov 2019 15:17:29 +0100

Hi Mark,

Mark H Weaver <mhw <at> netris.org> skribis:

> If you'd be willing to take a quick look at this, I'd be grateful.
> Probably a bug, but I feel uneasy that I might be overlooking something.
>
> scm_port_poll contains the following code:
>
>   if (scm_i_string_contains_char (events, 'r'))
>     c_events |= POLLIN;
>   if (scm_i_string_contains_char (events, '!'))
>     c_events |= POLLPRI;
>   if (scm_i_string_contains_char (events, 'w'))
>     c_events |= POLLIN;
>
> That second POLLIN should be POLLOUT, right?

I agree.  Clearly it must be a typo, so I’ve pushed the fix as
659526d33b2db1b0924b2769b6a0b824709860cc.

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.