GNU bug report logs - #36709
Likely bug in scm_port_poll

Previous Next

Package: guile;

Reported by: Mark H Weaver <mhw <at> netris.org>

Date: Wed, 17 Jul 2019 19:28:04 UTC

Severity: normal

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #10 received at 36709-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Mark H Weaver <mhw <at> netris.org>
Cc: 36709-done <at> debbugs.gnu.org
Subject: Re: bug#36709: Likely bug in scm_port_poll
Date: Mon, 18 Nov 2019 15:17:29 +0100

Hi Mark,

Mark H Weaver <mhw <at> netris.org> skribis:

> If you'd be willing to take a quick look at this, I'd be grateful.
> Probably a bug, but I feel uneasy that I might be overlooking something.
>
> scm_port_poll contains the following code:
>
>   if (scm_i_string_contains_char (events, 'r'))
>     c_events |= POLLIN;
>   if (scm_i_string_contains_char (events, '!'))
>     c_events |= POLLPRI;
>   if (scm_i_string_contains_char (events, 'w'))
>     c_events |= POLLIN;
>
> That second POLLIN should be POLLOUT, right?

I agree.  Clearly it must be a typo, so I’ve pushed the fix as
659526d33b2db1b0924b2769b6a0b824709860cc.

Thanks!

Ludo’.
This bug report was last modified 5 years and 184 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.