GNU bug report logs - #36707
[PATCH] Signal user-error on duplicate package refresh

Previous Next

Full log

Message #20 received at 36707 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: "Basil L. Contovounesios" <contovob <at> tcd.ie>, 36707 <at> debbugs.gnu.org
Subject: Re: bug#36707: [PATCH] Signal user-error on duplicate package refresh
Date: Sun, 18 Aug 2019 20:18:05 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> Noam Postavsky <npostavs <at> gmail.com> writes:
>
> > "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
> >
> > > Stefan Kangas <stefan <at> marxist.se> writes:
> > >
> > >> In the "*Packages*" buffer (M-x package-list-packages), if I hit "r" many times
> > >> it will try to initiate more refreshes even if the first one has not finished
> > >> yet.  This is unnecessary and potentially confusing.
> > >>
> > >> This patch makes it check if there is already an refresh in progress and signal
> > >> a user-error if there is one.
> > >
> > > Would it not be possible/better to discard the existing refresh and
> > > start a new one, instead of signalling an error?  This would help
> > > e.g. when a refresh hangs for whatever reason.
> >
> > Not sure if it's better, supposing the user is hitting "r" repeatedly,
> > that just interrupts the pending refreshes, preventing any progress.  I
> > would expect hanging to be cancelled by a timeout anyway.
>
> I agree with Noam that a timeout would make more sense.  Not sure if
> it already exists or if that's a separate issue.

Are there any other objections to the patch?  Otherwise, I'll go ahead
and push it in a few days.

Thanks,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.