From unknown Fri Jun 13 13:24:11 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#36707 <36707@debbugs.gnu.org> To: bug#36707 <36707@debbugs.gnu.org> Subject: Status: [PATCH] Signal user-error on duplicate package refresh Reply-To: bug#36707 <36707@debbugs.gnu.org> Date: Fri, 13 Jun 2025 20:24:11 +0000 retitle 36707 [PATCH] Signal user-error on duplicate package refresh reassign 36707 emacs submitter 36707 Stefan Kangas severity 36707 minor tag 36707 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 17 14:02:46 2019 Received: (at submit) by debbugs.gnu.org; 17 Jul 2019 18:02:46 +0000 Received: from localhost ([127.0.0.1]:52952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnoGK-00036L-Sf for submit@debbugs.gnu.org; Wed, 17 Jul 2019 14:02:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:55328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnoGJ-00036E-BP for submit@debbugs.gnu.org; Wed, 17 Jul 2019 14:02:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49021) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnoGI-0002qS-HQ for bug-gnu-emacs@gnu.org; Wed, 17 Jul 2019 14:02:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnoGG-0000JZ-IT for bug-gnu-emacs@gnu.org; Wed, 17 Jul 2019 14:02:42 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:34497) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hnoGF-0000I4-1t for bug-gnu-emacs@gnu.org; Wed, 17 Jul 2019 14:02:40 -0400 Received: by mail-wr1-f54.google.com with SMTP id 31so25851843wrm.1 for ; Wed, 17 Jul 2019 11:02:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=noesBgEFx2IgxNeLSx3LPP0TjTM8DxB6pByNN5Mly5Y=; b=IJcLB0FMd3QGy8jnrLugpNeUYBVbg0HN72HvL/uWtnzayuiC4qm1+ZYtSDOby+R1HG nFysUYGT0vdhjNc3izl81xcvCcaZYvUaYtikqgzsWgA+yilv+4ycl2tWcR/fBfRZmIQt eJq49OTZ9Y5ZyDEnVK3d6XmJnHS+WhbHwwaKtIaKo7mv8L2qbuLOpg5EcG+3Dsfb7gx6 qmtt7b7qA/cJJsifrpfEUrIjaM9tcb4Qx/BUO0LG2tLeLJCrFZniO2lwF+swXi1bOZig +gDTyQ0dBKh1QiBIytDEJyGtHKSR9cCDuPSuDVOJHeQNd6Cr0dRuG45DxIWh6EXV0KR0 ca7w== X-Gm-Message-State: APjAAAVId3l+lDpBBTkUmhabWEHdXmT0OpNgLWXRf9RegteN11jMWZuc AmZdF43qKAzfyaJXZg0WbqlDeHMnDZDeWCol6UXWz3Hu X-Google-Smtp-Source: APXvYqxm0lVF4A44ifpntbaY1xS6hHosziv0T5jZXKDNA8epUtfLEdaHGAlEIseYcMi5YbI8pO/0G1mkasHLgncffKc= X-Received: by 2002:adf:eb49:: with SMTP id u9mr39819851wrn.215.1563386556830; Wed, 17 Jul 2019 11:02:36 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Wed, 17 Jul 2019 20:02:25 +0200 Message-ID: Subject: [PATCH] Signal user-error on duplicate package refresh To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.54 X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) In the "*Packages*" buffer (M-x package-list-packages), if I hit "r" many times it will try to initiate more refreshes even if the first one has not finished yet. This is unnecessary and potentially confusing. This patch makes it check if there is already an refresh in progress and signal a user-error if there is one. (I'll send the patch in a separate message once this is assigned a bug number.) Thanks, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 17 14:10:32 2019 Received: (at 36707) by debbugs.gnu.org; 17 Jul 2019 18:10:32 +0000 Received: from localhost ([127.0.0.1]:52965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnoNr-0003IG-VA for submit@debbugs.gnu.org; Wed, 17 Jul 2019 14:10:32 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:42993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnoNp-0003Hn-Sw for 36707@debbugs.gnu.org; Wed, 17 Jul 2019 14:10:30 -0400 Received: by mail-wr1-f52.google.com with SMTP id x1so10831545wrr.9 for <36707@debbugs.gnu.org>; Wed, 17 Jul 2019 11:10:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=rvMl8oRfsHqkWG5a8nN7PPHM+okmELJsCr1DG9F/tRM=; b=ZiK4DGINTA5chauPokpeILzQPKKS2RbxcDV345fMAzTFzkPbYOQL0uSVnrSM2VuDNw WdzqOpsCugUNcGTcc1zueCdK9uZee98twR/BO1ICCzvoMICAoBH6p2GrKCZW67OzrUD2 GQH5msmQhLhMilyFDcxVIDqrTgu6KTv5XLzmnMbfWyL5lX2VvN7EXtP94CCjeOJVX24P jAFh+uXPJj3KWGVu+frCBCM6rPnYE5jzSMsx9HPi9p1jW93+GwMB+HPpq/Rmgds9zZtk XZgOszPuoFR/wVsCQRWS6YqHO2TjzPCeBC+b/9xoUKZOwWDjDyVIwH33euk0KtZvLalJ DWFA== X-Gm-Message-State: APjAAAVfKu7dLD+35ubZplIpVTI0v8JKiPde4cI6l/2WuQG1RSPjNWxn xR/ChHiKFUhq7Go9+3bX6g/JcjY3NUFLrnjUt/IbGg== X-Google-Smtp-Source: APXvYqzFATWnIn2c2sX9+VH/YwB6ihI16G1cm91aSQZPfM5DvEzCIzgjSQxuWskjnhdvmR4XW2s5NKoUOwMHoJnGHKA= X-Received: by 2002:adf:e541:: with SMTP id z1mr41192514wrm.48.1563387023753; Wed, 17 Jul 2019 11:10:23 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Stefan Kangas Date: Wed, 17 Jul 2019 20:10:12 +0200 Message-ID: Subject: Re: bug#36707: [PATCH] Signal user-error on duplicate package refresh To: 36707@debbugs.gnu.org Content-Type: multipart/mixed; boundary="00000000000032aabd058de46816" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 36707 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --00000000000032aabd058de46816 Content-Type: text/plain; charset="UTF-8" Stefan Kangas writes: > (I'll send the patch in a separate message once this is assigned a bug > number.) Patch attached. Thanks, Stefan Kangas --00000000000032aabd058de46816 Content-Type: application/octet-stream; name="0001-Signal-a-user-error-on-duplicate-package-refresh.patch" Content-Disposition: attachment; filename="0001-Signal-a-user-error-on-duplicate-package-refresh.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jy7k7oat0 RnJvbSBhN2JhNDRiN2ViNzgwNjdhODRlMDk4MDBlZGRhNzVlOTU1ZTYyNmRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBXZWQsIDE3IEp1bCAyMDE5IDE5OjU1OjA4ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g U2lnbmFsIGEgdXNlci1lcnJvciBvbiBkdXBsaWNhdGUgcGFja2FnZSByZWZyZXNoCgoqIGxpc3Av ZW1hY3MtbGlzcC9wYWNrYWdlLmVsIChwYWNrYWdlLW1lbnUtcmVmcmVzaCk6IFNpZ25hbCBhCnVz ZXItZXJyb3IgaWYgdGhlcmUgaXMgYWxyZWFkeSBhIHJlZnJlc2ggcnVubmluZyBpbiB0aGUgYmFj a2dyb3VuZC4KRG9jIGZpeC4gIChCdWcjMzY3MDcpCi0tLQogbGlzcC9lbWFjcy1saXNwL3BhY2th Z2UuZWwgfCA5ICsrKysrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMyBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2VtYWNzLWxpc3AvcGFja2FnZS5lbCBiL2xp c3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsCmluZGV4IDlhMzUwYWFkYWMuLmQ0NjIwN2EzMjggMTAw NjQ0Ci0tLSBhL2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsCisrKyBiL2xpc3AvZW1hY3MtbGlz cC9wYWNrYWdlLmVsCkBAIC0zMDQyLDEyICszMDQyLDE1IEBAIHBhY2thZ2UtbWVudS0tb2xkLWFy Y2hpdmUtY29udGVudHMKICAgImBwYWNrYWdlLWFyY2hpdmUtY29udGVudHMnIGJlZm9yZSB0aGUg bGF0ZXN0IHJlZnJlc2guIikKIAogKGRlZnVuIHBhY2thZ2UtbWVudS1yZWZyZXNoICgpCi0gICJE b3dubG9hZCB0aGUgRW1hY3MgTGlzcCBwYWNrYWdlIGFyY2hpdmUuCi1UaGlzIGZldGNoZXMgdGhl IGNvbnRlbnRzIG9mIGVhY2ggYXJjaGl2ZSBzcGVjaWZpZWQgaW4KLWBwYWNrYWdlLWFyY2hpdmVz JywgYW5kIHRoZW4gcmVmcmVzaGVzIHRoZSBwYWNrYWdlIG1lbnUuIgorICAiSW4gUGFja2FnZSBN ZW51LCBkb3dubG9hZCB0aGUgRW1hY3MgTGlzcCBwYWNrYWdlIGFyY2hpdmUuCitGZXRjaCB0aGUg Y29udGVudHMgb2YgZWFjaCBhcmNoaXZlIHNwZWNpZmllZCBpbgorYHBhY2thZ2UtYXJjaGl2ZXMn LCBhbmQgdGhlbiByZWZyZXNoIHRoZSBwYWNrYWdlIG1lbnUuICBTaWduYWwgYQordXNlci1lcnJv ciBpZiB0aGVyZSBpcyBhbHJlYWR5IGEgcmVmcmVzaCBydW5uaW5nIGFzeW5jaHJvbm91c2x5LiIK ICAgKGludGVyYWN0aXZlKQogICAodW5sZXNzIChkZXJpdmVkLW1vZGUtcCAncGFja2FnZS1tZW51 LW1vZGUpCiAgICAgKHVzZXItZXJyb3IgIlRoZSBjdXJyZW50IGJ1ZmZlciBpcyBub3QgYSBQYWNr YWdlIE1lbnUiKSkKKyAgKHdoZW4gKGFuZCBwYWNrYWdlLW1lbnUtYXN5bmMgcGFja2FnZS0tZG93 bmxvYWRzLWluLXByb2dyZXNzKQorICAgICh1c2VyLWVycm9yICJQYWNrYWdlIHJlZnJlc2ggaXMg YWxyZWFkeSBpbiBwcm9ncmVzcywgcGxlYXNlIHdhaXQuLi4iKSkKICAgKHNldHEgcGFja2FnZS1t ZW51LS1vbGQtYXJjaGl2ZS1jb250ZW50cyBwYWNrYWdlLWFyY2hpdmUtY29udGVudHMpCiAgIChz ZXRxIHBhY2thZ2UtbWVudS0tbmV3LXBhY2thZ2UtbGlzdCBuaWwpCiAgIChwYWNrYWdlLXJlZnJl c2gtY29udGVudHMgcGFja2FnZS1tZW51LWFzeW5jKSkKLS0gCjIuMjIuMAoK --00000000000032aabd058de46816-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 18 18:13:47 2019 Received: (at 36707) by debbugs.gnu.org; 18 Jul 2019 22:13:47 +0000 Received: from localhost ([127.0.0.1]:54733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hoEeg-0001vw-94 for submit@debbugs.gnu.org; Thu, 18 Jul 2019 18:13:47 -0400 Received: from [209.85.221.65] (port=34741 helo=mail-wr1-f65.google.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hoEeT-0001vO-Jf for 36707@debbugs.gnu.org; Thu, 18 Jul 2019 18:13:36 -0400 Received: by mail-wr1-f65.google.com with SMTP id 31so30312845wrm.1 for <36707@debbugs.gnu.org>; Thu, 18 Jul 2019 15:13:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=rK+qofECYbslUx1Q77gYmQu/AemP8jNQF1eWsjsRf8A=; b=hehLLAV959MAzUkgM2Kugir/ZjFDD59NyuthtQhD81mUFH0LlWI8/397OGXmuSJV6r eUWTopJ+s617fKOxFV8AgbOkNhWBY4+xkO7qmFYNmgtCTKfGWV28kPs1qYWkfKUbrLhS Px6EWG2IsGLchowwqw/EA8yGkWujVPz/U97LLtgdIXVjQ8CzBvg2Dm6ZYDC5ohdLVlW8 uBWcXSray+NXNYCutmXabr+AmYpJ0VaGREqT5mI1hP0yRvYT36ECGSL9Dh1F24fD20eM LU9xqloKzyN4ZHuiMP9cDLPs6a+aEeMjKeK2CJ8z9Mh9rAB11V/IKlx2hmVWHmDjWYzQ IDoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=rK+qofECYbslUx1Q77gYmQu/AemP8jNQF1eWsjsRf8A=; b=qJA/1ub1AjNRj98LuXLnTc1i8YttPoSXKe87rmVyCdSgVJXeRvb+6TKyICtT42S6NL w8J6cZBhGRZfgTjcfkx5TNX/E4rwnvia/LW3S7MJanflHSKFJPtdhR4WY620h/EBVxfQ pewBqtNw0yqMDfwpJE4JsNzViYNdeHbctj1pQ/W22E7yw8UNQjYVGzTT6KSnfjyzJDYv 7IZY1fhBrFNTTu3pdy1OqUrYzQMPloo2NGjhslseZErIXtRGtd+XWChJUYKgHwnXN8GZ LggkjR2Nh0vmY1B8G2zUpU82SpwM9AJfEHDITWcAVv0KxhA1knTM3WoQKUurDTONfxnW cvfA== X-Gm-Message-State: APjAAAU/l1Z9KR638p7506bGNCkuthND+IiUUUic5tRlivlXSHSkhrXY 0lcYL1OVWTJIsJGsWdM6KznJyP8aQxs= X-Google-Smtp-Source: APXvYqy0UJo1wO2EtO8/Z8lTbifqapyTmFYhD23LDQNj8/SFuIzc5gDfVoRz4yaHqnm61FQPoQBukg== X-Received: by 2002:a5d:618d:: with SMTP id j13mr51032881wru.195.1563484498727; Thu, 18 Jul 2019 14:14:58 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id k9sm20337821wmi.33.2019.07.18.14.14.57 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 18 Jul 2019 14:14:58 -0700 (PDT) From: "Basil L. Contovounesios" To: Stefan Kangas Subject: Re: bug#36707: [PATCH] Signal user-error on duplicate package refresh References: Date: Thu, 18 Jul 2019 22:14:55 +0100 In-Reply-To: (Stefan Kangas's message of "Wed, 17 Jul 2019 20:02:25 +0200") Message-ID: <874l3j11v4.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Stefan Kangas writes: > In the "*Packages*" buffer (M-x package-list-packages), if I hit "r" many times > it will try to initiate more refreshes even if the first one has not finished > yet. This is unnecessary and potenti [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.65 listed in list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 T_SPF_HELO_TEMPERROR SPF: test of HELO record failed (temperror) 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS 0.0 PDS_HP_HELO_NORDNS High profile HELO with no sender rDNS X-Debbugs-Envelope-To: 36707 Cc: 36707@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Stefan Kangas writes: > In the "*Packages*" buffer (M-x package-list-packages), if I hit "r" many times > it will try to initiate more refreshes even if the first one has not finished > yet. This is unnecessary and potentially confusing. > > This patch makes it check if there is already an refresh in progress and signal > a user-error if there is one. Would it not be possible/better to discard the existing refresh and start a new one, instead of signalling an error? This would help e.g. when a refresh hangs for whatever reason. Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 08 20:16:25 2019 Received: (at 36707) by debbugs.gnu.org; 9 Aug 2019 00:16:25 +0000 Received: from localhost ([127.0.0.1]:41918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hvsZy-0000tO-7P for submit@debbugs.gnu.org; Thu, 08 Aug 2019 20:16:25 -0400 Received: from mail-ot1-f45.google.com ([209.85.210.45]:34898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hvsZw-0000nb-BR for 36707@debbugs.gnu.org; Thu, 08 Aug 2019 20:16:20 -0400 Received: by mail-ot1-f45.google.com with SMTP id j19so49334422otq.2 for <36707@debbugs.gnu.org>; Thu, 08 Aug 2019 17:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=mDUGP9CkhnL8Rj4j7+KscAZxTuh7N2bfbvmGGcCV6WE=; b=o3o+0b0gL9fp9KccJd/6TM3LEwstW9Uxue0PALzP8QAUOIaFtxh24Y5tJ/Qtv7iEVe s2fG0eQW8gAKd8QUI/FU3ZtggLcrz46rxvbZIoFdMQwpZvUd1GXT6bVEgTdCegKFCsoH /x4TfoDag97rfUrWN+bP2nxE/IM/xUrauInDBIEQIGCcU5OjoJz8qJuhBAcfdsTSGXDC W8Qyg5MuK19XqOisXcqVrl3phM8/InG2USVwnugitn76akEOwFW5KHdOVETPFwjl8bZ9 OerVAmrEzThZ780qG8u2toRmWsP5w26h+KSQ7jTrcgM+v/0YQ4+t0/XggbsLgmGY9vuP BdBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=mDUGP9CkhnL8Rj4j7+KscAZxTuh7N2bfbvmGGcCV6WE=; b=eVKfx8eTqMwFcBgddTjXS3ecE4IQ7H4F4n+Tmy3t2+gsFWKXGQ9HSN0Y8d5elgLZXO HtG8xe1ONcAdluc7Wo/Yev6/Q1QZjX2NyBd2mmBuA5u7sdfGpoTX1QEeA/iFW7Xe3CJ7 9Yk8NXNjlGbgKawk9KbLkuNKcENhwavQ40d4eG+ldcE2r6UPrKraieC5cFFb+tzCaBWK /DK1Z7x01MLMgNur+FR6nU/tS54qhsLGJb6gnIDLRj+Dj+uLcFqT8DN3bZak7ZuU8HX4 BK0r6JytrTYR3Q0wezI2N26CXKGKVQVOvA4MQ/61VF8z/rVtn4OZWM6oZ476KS6u3QJo QkYw== X-Gm-Message-State: APjAAAUQF74iAoapBsjYTwuPHYYrGO5tRtD8XWcWnMalu7HO1hIQvogY X9u2AF1bCYVnQ0ECggjPwpsPmCGr X-Google-Smtp-Source: APXvYqxH1CTe6oEMjKiGYv9yLg/+l5AV0xD7Z1XwuYiWGYtBSpiEc3DOOPBgZhcfJV4yUnb5sx0mew== X-Received: by 2002:a6b:ed01:: with SMTP id n1mr18380076iog.255.1565309774612; Thu, 08 Aug 2019 17:16:14 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id p63sm93207186iof.45.2019.08.08.17.16.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Aug 2019 17:16:14 -0700 (PDT) From: Noam Postavsky To: "Basil L. Contovounesios" Subject: Re: bug#36707: [PATCH] Signal user-error on duplicate package refresh References: <874l3j11v4.fsf@tcd.ie> Date: Thu, 08 Aug 2019 20:16:13 -0400 In-Reply-To: <874l3j11v4.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 18 Jul 2019 22:14:55 +0100") Message-ID: <87lfw3qjle.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36707 Cc: 36707@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Basil L. Contovounesios" writes: > Stefan Kangas writes: > >> In the "*Packages*" buffer (M-x package-list-packages), if I hit "r" many times >> it will try to initiate more refreshes even if the first one has not finished >> yet. This is unnecessary and potentially confusing. >> >> This patch makes it check if there is already an refresh in progress and signal >> a user-error if there is one. > > Would it not be possible/better to discard the existing refresh and > start a new one, instead of signalling an error? This would help > e.g. when a refresh hangs for whatever reason. Not sure if it's better, supposing the user is hitting "r" repeatedly, that just interrupts the pending refreshes, preventing any progress. I would expect hanging to be cancelled by a timeout anyway. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 11 20:35:50 2019 Received: (at 36707) by debbugs.gnu.org; 12 Aug 2019 00:35:51 +0000 Received: from localhost ([127.0.0.1]:45930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hwyJS-0002Gu-Jj for submit@debbugs.gnu.org; Sun, 11 Aug 2019 20:35:50 -0400 Received: from mail-pf1-f180.google.com ([209.85.210.180]:44844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hwyJN-0002GB-Dn for 36707@debbugs.gnu.org; Sun, 11 Aug 2019 20:35:47 -0400 Received: by mail-pf1-f180.google.com with SMTP id t16so48833908pfe.11 for <36707@debbugs.gnu.org>; Sun, 11 Aug 2019 17:35:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uonQlQYnwWP3mhSaOCh1uPK3u1g0tXPG9H6DFN2Xcfw=; b=TnLLEjCTfrEIaj5DGj/ghCPEaMts9PXHky0rZ6Hg698AcR3pRWiCvNEgP+a6G2CVK6 TlL0Iu3uHicOVajcbv71G+yg5zWid5+UOTpPBUIci7nqt8BM77bi4hgAkysv/NN/Bx93 i5QYzCcJVMOBHoPgamjGFhlFwv179D9i/8QupIe83a5EuRxq4v9ONOnI4ctN3u8uzOHZ ut1NMoct4qonYPuVrTjywvEIs9BPeOhJEWq5/cb+I7AnPP8+jZptVzegm1dtlEATcRJ+ XQKU0OO34NiKBksP9xIiY+2qsyLBMD4yODorbIcgpHrHNaMXrsecRW94OoEM6p10Z0YS IjOw== X-Gm-Message-State: APjAAAVLrFWOR82OLkU+xVNuZBvx0PhqdLi+pa2M6xxiMpGpQU+up+7y 7IgX9JzePdF2bpdrxz2jDjaqTtxAcd8Xzl7YZI4= X-Google-Smtp-Source: APXvYqy3hyQ7G4IdD+VHxPCw1t86CCzJuQM3IkRHEJ6bfCEWsB+8N6YrnDmBQwbkfTzBgvu4pCmMX92ejrrqUOuNTZ0= X-Received: by 2002:a63:5f01:: with SMTP id t1mr2107757pgb.200.1565570139702; Sun, 11 Aug 2019 17:35:39 -0700 (PDT) MIME-Version: 1.0 References: <874l3j11v4.fsf@tcd.ie> <87lfw3qjle.fsf@gmail.com> In-Reply-To: <87lfw3qjle.fsf@gmail.com> From: Stefan Kangas Date: Mon, 12 Aug 2019 02:35:28 +0200 Message-ID: Subject: Re: bug#36707: [PATCH] Signal user-error on duplicate package refresh To: Noam Postavsky Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 36707 Cc: "Basil L. Contovounesios" , 36707@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Noam Postavsky writes: > "Basil L. Contovounesios" writes: > > > Stefan Kangas writes: > > > >> In the "*Packages*" buffer (M-x package-list-packages), if I hit "r" many times > >> it will try to initiate more refreshes even if the first one has not finished > >> yet. This is unnecessary and potentially confusing. > >> > >> This patch makes it check if there is already an refresh in progress and signal > >> a user-error if there is one. > > > > Would it not be possible/better to discard the existing refresh and > > start a new one, instead of signalling an error? This would help > > e.g. when a refresh hangs for whatever reason. > > Not sure if it's better, supposing the user is hitting "r" repeatedly, > that just interrupts the pending refreshes, preventing any progress. I > would expect hanging to be cancelled by a timeout anyway. I agree with Noam that a timeout would make more sense. Not sure if it already exists or if that's a separate issue. Thanks, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 18 14:18:25 2019 Received: (at 36707) by debbugs.gnu.org; 18 Aug 2019 18:18:25 +0000 Received: from localhost ([127.0.0.1]:58635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzPl2-0007Lq-VC for submit@debbugs.gnu.org; Sun, 18 Aug 2019 14:18:25 -0400 Received: from mail-pg1-f178.google.com ([209.85.215.178]:45346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzPl0-0007LX-Ue for 36707@debbugs.gnu.org; Sun, 18 Aug 2019 14:18:23 -0400 Received: by mail-pg1-f178.google.com with SMTP id o13so5555137pgp.12 for <36707@debbugs.gnu.org>; Sun, 18 Aug 2019 11:18:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F4ev9ZyhRvEHRNsaW1EvD1/LBfKk4ZO5samETPf0BPw=; b=RR0HGkIei8kNlj8uScjhWUGGZ3yTJDrHaGzhEac+3dZ+NTujdnuT7fKZXIUWj5i3fX NV2Jpplkk00swhyjFjlcZZJCrEmvg6j0rODQxs7HeJQFpJNPXuyeU8KrznMl7OwDGe1j 2gZSQbw22+CHp0vx80EmHckl3mq8cyA9BWcacdF1zvdvR5OFAYytafnC0nW4Zsyfy6Pk m2wsfAyOKZoXuWF7hw5dwspjljPYNqzjLVoExS2A4kdBKN3RmtlxvikTb167/NqkV2FR drWBQBeKhDjojbSbdZLgeWXM98WIT/PplVTjOPkf2eRv7gPL0VUCjxBzKd7ryN+5q8/H 8zJQ== X-Gm-Message-State: APjAAAXiGXtPjZnqPWJ7WT4uMo45U8GmZxtdW8t6kuGcRPdVpTcHZYmz YqZ4b69qC3uiJVLC+9W+AjmFA5UQEcPxHVDGcyI= X-Google-Smtp-Source: APXvYqxrFvzzPhTUdLB+4/1jqgKCbC+RzM3qB5TQ7HloeDPpxvrb94wICoYEh6EqA0JWFebCu073Nq4rKOtBMANbX3c= X-Received: by 2002:a63:5f01:: with SMTP id t1mr15216735pgb.200.1566152297235; Sun, 18 Aug 2019 11:18:17 -0700 (PDT) MIME-Version: 1.0 References: <874l3j11v4.fsf@tcd.ie> <87lfw3qjle.fsf@gmail.com> In-Reply-To: From: Stefan Kangas Date: Sun, 18 Aug 2019 20:18:05 +0200 Message-ID: Subject: Re: bug#36707: [PATCH] Signal user-error on duplicate package refresh To: Noam Postavsky Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 36707 Cc: "Basil L. Contovounesios" , 36707@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Stefan Kangas writes: > Noam Postavsky writes: > > > "Basil L. Contovounesios" writes: > > > > > Stefan Kangas writes: > > > > > >> In the "*Packages*" buffer (M-x package-list-packages), if I hit "r" many times > > >> it will try to initiate more refreshes even if the first one has not finished > > >> yet. This is unnecessary and potentially confusing. > > >> > > >> This patch makes it check if there is already an refresh in progress and signal > > >> a user-error if there is one. > > > > > > Would it not be possible/better to discard the existing refresh and > > > start a new one, instead of signalling an error? This would help > > > e.g. when a refresh hangs for whatever reason. > > > > Not sure if it's better, supposing the user is hitting "r" repeatedly, > > that just interrupts the pending refreshes, preventing any progress. I > > would expect hanging to be cancelled by a timeout anyway. > > I agree with Noam that a timeout would make more sense. Not sure if > it already exists or if that's a separate issue. Are there any other objections to the patch? Otherwise, I'll go ahead and push it in a few days. Thanks, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 22 13:04:49 2019 Received: (at 36707) by debbugs.gnu.org; 22 Aug 2019 17:04:49 +0000 Received: from localhost ([127.0.0.1]:38294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0qW0-00028e-MM for submit@debbugs.gnu.org; Thu, 22 Aug 2019 13:04:48 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:34882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0qVy-00028J-HN for 36707@debbugs.gnu.org; Thu, 22 Aug 2019 13:04:47 -0400 Received: by mail-pl1-f196.google.com with SMTP id gn20so3815754plb.2 for <36707@debbugs.gnu.org>; Thu, 22 Aug 2019 10:04:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yiVNK+1t5a6HYwEJ81I9BGj99xR/L6VirG66d/Me82k=; b=QSX2l1twmlOYzN31VVeCJy0JE9TvhNnqXvlHvzXUz8Ujes/G+iyktAFPKcew3AJXEF O2Oi1y8xLp2Pwgqll9cVlR62irr+/JNy6cBMgBzFiW1XlKhDPhBuycfQDv82heuDOsRJ GaMgVOK2LEYOteUXkDnqe/qWIndv38Gtdb4Ny3L3BW7jKvSVBgLCWcaqU0coVrQJIbg4 CA85sPXuX51F2+cpqehhKWY0INeDfiBcWg/Ond2iOlJUy15Qk+6v2H7/xuA2UNabqmAp b0xObBLppxHwTAxHzs4oWiLhB+89TXUEThE8SAGwxKUAqr1q4fgJmQLOIZa2EreBeg2R W2fA== X-Gm-Message-State: APjAAAXr7L4De0yn0w+f0CaAL8o3b9OxKLLhPLMR3WwseJYX7ttsqGpY RH5Iblj9iE3trtsd7dU9dUtpK7wmFdv6N267mbQ= X-Google-Smtp-Source: APXvYqyfM99c1N8xBsga/TPrMkwiQblr9fUmFuuWMN3XFna9/EB9BH5dcf3GfBLbw2X+Q9K4bSskrdw19azzzskjViU= X-Received: by 2002:a17:902:d70a:: with SMTP id w10mr38288691ply.251.1566493480740; Thu, 22 Aug 2019 10:04:40 -0700 (PDT) MIME-Version: 1.0 References: <874l3j11v4.fsf@tcd.ie> <87lfw3qjle.fsf@gmail.com> In-Reply-To: From: Stefan Kangas Date: Thu, 22 Aug 2019 19:04:30 +0200 Message-ID: Subject: Re: bug#36707: [PATCH] Signal user-error on duplicate package refresh To: Noam Postavsky Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 36707 Cc: "Basil L. Contovounesios" , 36707@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) close 36707 27.1 quit Stefan Kangas writes: > Are there any other objections to the patch? Otherwise, I'll go ahead > and push it in a few days. I've now pushed this as commit a6d87ea045. Closing the report. Thanks, Stefan Kangas From unknown Fri Jun 13 13:24:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 20 Sep 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator