GNU bug report logs - #3670
[Orgmode] 23.0.94; [PATCH] org-store-link broken within kbd macros

Previous Next

Full log

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Carsten Dominik <carsten.dominik <at> gmail.com>
To: Andreas Seltenreich <seltenreich <at> gmx.de>
Cc: emacs-pretest-bug <at> gnu.org, emacs-orgmode <at> gnu.org
Subject: Re: [Orgmode] 23.0.94; [PATCH] org-store-link broken within kbd macros
Date: Wed, 24 Jun 2009 14:17:59 +0200

This looks to me as if it was a bug in keyboard macro execution,
which should call functions interactively.

- Carsten

On Jun 17, 2009, at 1:15 PM, Andreas Seltenreich wrote:

>> Your bug report will be posted to the emacs-pretest-bug <at> gnu.org  
>> mailing list.
>
>> Please describe exactly what actions triggered the bug
>> and the precise symptoms of the bug:
>
> org-store-link works fine when recording a keyboard macro but it is a
> NOP when executing it.  The following change appears to fix it.
>
> regards,
> andreas
>
>> In GNU Emacs 23.0.94.1 (x86_64-unknown-linux-gnu)
>> of 2009-05-28 on tengen
>
> --8<---------------cut here---------------start------------->8---
> *** org.el.~1.48.~	2009-02-20 10:02:49.000000000 +0100
> --- org.el	2009-06-17 12:55:15.000000000 +0200
> ***************
> *** 6594,6600 ****
>  	  desc (or desc cpltxt))
>      (if (equal desc "NONE") (setq desc nil))
>
> !     (if (and (interactive-p) link)
>  	(progn
>  	  (setq org-stored-links
>  		(cons (list link desc) org-stored-links))
> --- 6594,6600 ----
>  	  desc (or desc cpltxt))
>      (if (equal desc "NONE") (setq desc nil))
>
> !     (if (and (or (interactive-p) executing-kbd-macro) link)
>  	(progn
>  	  (setq org-stored-links
>  		(cons (list link desc) org-stored-links))
> --8<---------------cut here---------------end--------------->8---
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode <at> gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.