GNU bug report logs - #36680
27.0.50; undo-tree visualizer flickering with display-buffer-reuse-frames -> t

Previous Next

Full log

Message #23 received at 36680 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 36680 <at> debbugs.gnu.org
Subject: Re: bug#36680: 27.0.50; undo-tree visualizer flickering with
 display-buffer-reuse-frames -> t
Date: Fri, 19 Jul 2019 10:16:07 +0200

>> You probably should have used an 'inhibit-switch-frame' ALIST entry
>> then.
>
> Where would you suggest to do that, as a user, without changing code?
> Potentially any arbitrary buffer can be affected.

It's not trivial, unfortunately.  As a user, one has to identify the
calling undo-tree function.

>> OK.  Then please, try the attached patch.
>
> Yes, good, that's what I want - thanks.

I pushed the change now.

> I hope no existing code relies
> on the old behavior.  But I think it's an improvement, also in other
> situations.

Strictly speaking, the change should be in 'get-buffer-window-list' to
possibly pick a window before the selected one on the selected frame.
But I can't really change the semantics of that.

>> Note that when there's no suitable window on the selected frame you
>> will still get the annoying behavior.
>
> In this case it's not trivial what could be done better.  Let's say that
> this is not part of my report.

OK.  If you see no further problems, please close this bug.

Thanks, martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.