GNU bug report logs - #36672
27.0.50; NS build: Creating child frame leads to empty space

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alan Third <alan <at> idiocy.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#36672: closed (27.0.50; NS build: Creating child frame leads
 to empty space)
Date: Thu, 12 Mar 2020 23:28:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 13 Mar 2020 00:27:09 +0100 (CET)
with message-id <20200312232706.GA84518 <at> breton.holly.idiocy.org>
and subject line Re: bug#36672: 27.0.50; NS build: Creating child frame leads to empty space
has caused the debbugs.gnu.org bug report #36672,
regarding 27.0.50; NS build: Creating child frame leads to empty space
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
36672: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36672
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; NS build: Creating child frame leads to empty space
Date: Mon, 15 Jul 2019 20:38:31 +0300

[Message part 3 (text/plain, inline)]

Assume there are only one space - Desktop
1. emacs -Q
2. M-x toggle-frame-fullscreen
   Now there are two spaces - Desktop and *scratch*
3. eval (make-frame `((parent-frame . ,(window-frame))))
   Now there are three spaces:
   - Desktop
   - Empty space named *scratch* with emacs menu
   - *scratch* with emacs frames but without menu

Although attached patch solves this problem for me these cases still not
handled right way:

1. Removing parent-frame property leaves the frame is same space:

(let ((new-frame (make-frame `((parent-frame . ,(window-frame))))))
  (modify-frame-parameters new-frame `((parent-frame . nil))))

Maybe child frame must go fullscreen if ex-parent frame is in
fullscreen.

2. Setting parent frame after frame creation:

(let ((frame (window-frame))
      (new-frame (make-frame)))
  (modify-frame-parameters new-frame `((parent-frame . ,frame))))

Thanks!

In GNU Emacs 27.0.50 (build 1, x86_64-apple-darwin18.6.0, NS
appkit-1671.50 Version 10.14.5 (Build 18F132))
Windowing system distributor 'Apple', version 10.3.1671
System Description:  Mac OS X 10.14.5

[ns-emacs-spaces.patch (application/octet-stream, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Alan Third <alan <at> idiocy.org>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Cc: 36672-done <at> debbugs.gnu.org
Subject: Re: bug#36672: 27.0.50; NS build: Creating child frame leads to
 empty space
Date: Fri, 13 Mar 2020 00:27:09 +0100 (CET)

On Tue, Mar 10, 2020 at 10:42:11AM +0200, Andrii Kolomoiets wrote:
> Please see attached patch. Log message is also provided.

This all looks good to me. Pushed to master as
bbc48b263485c26c6823eabdbbd7e9af62178e34.

Thank you!

-- 
Alan Third

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.