GNU bug report logs - #36658
[PATCH] gnu: Add emacs-zerodark-theme.

Previous Next

Full log

Message #8 received at 36658 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Giacomo Leidi <goodoldpaul <at> autistici.org>
Cc: 36658 <at> debbugs.gnu.org
Subject: Re: [bug#36658] [PATCH] gnu: Add emacs-zerodark-theme.
Date: Wed, 17 Jul 2019 15:35:14 +0200

Hello,

Giacomo Leidi <goodoldpaul <at> autistici.org> skribis:

> * gnu/packages/emacs-xyz.scm (emacs-zerodark-theme): New variable.

Thanks for this patch!  Below are a couple of suggestions.

> +(define-public emacs-zerodark-theme
> +  (package
> +  (name "emacs-zerodark-theme")
     ^
The indentation is off here (you can do M-q to fix it if you use
paredit).

> +  (version "20190528.923")
> +  (source
> +    (origin
> +      (method url-fetch)
> +      (uri (string-append
> +             "https://melpa.org/packages/zerodark-theme-"
> +             version
> +             ".el"))

This URL is unstable: the file will be modified in place regularly.
Consequently, could you instead use the upstream Git repository URL
along with the ‘git-fetch’ method?

> +  (synopsis
> +    "A dark, medium contrast theme for Emacs")
        ^
Please remove “A”, as suggested by ‘guix lint’.

> +  (description
> +    "A dark theme inspired from One Dark and Niflheim.

Please write a full sentence (info "(guix) Synopses and Descriptions").

> +An optional mode-line format can be enabled with 'zerodark-setup-modeline-format'.")
                                                    ^
Please use @code as suggested by ‘guix lint’.

Could you send an updated patch?

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.