GNU bug report logs - #36644
Git log search

Previous Next

Full log

View this message in rfc822 format

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Juri Linkov <juri <at> linkov.net>
Cc: Robert Pluim <rpluim <at> gmail.com>, "36644 <at> debbugs.gnu.org" <36644 <at> debbugs.gnu.org>
Subject: bug#36644: Git log search
Date: Wed, 24 Jul 2019 18:10:35 +0300

On 19.07.2019 1:32, Juri Linkov wrote:
>> We can't really use this approach. VC is a high level abstraction,
>> so we try to define the semantics well.
> 
> I tend to agree with Robert.  A string have to be passed to the backend as is.
> It seems such situations when these strings should be compatible between
> different backends (such as running the same command on one backend,
> and then repeating the same search on another backend by retrieving
> a previous argument from the history via M-p) are very rare.

I might agree with you from the practical standpoint, but vc-log-search 
needs a docstring that actually describes what the function is going to 
do. Including info on how PATTERN is going to be interpreted.

E.g. whether "foo.txt" will only match literally, or whether "." can be 
substituted by any character.

And if PATTERN is a regexp, what kind of regexp it's going to be 
interepreted as: basic RE, extended RE, Emacs RE, or Perl RE (probably 
not the last one anyway).

I suppose we can choose one of these and say e.g. that pattern is 
interpreted as an extended regular expression, except for some backends 
that don't support that. I wonder how we're going to convey the latter 
to the user.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.