From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jul 2019 22:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 36644@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15630570912025 (code B ref -1); Sat, 13 Jul 2019 22:32:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jul 2019 22:31:31 +0000 Received: from localhost ([127.0.0.1]:43546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmQYE-0000Wb-Vq for submit@debbugs.gnu.org; Sat, 13 Jul 2019 18:31:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:41011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmQYE-0000WU-96 for submit@debbugs.gnu.org; Sat, 13 Jul 2019 18:31:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36243) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmQYD-0008TX-7V for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 18:31:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,RCVD_IN_DNSWL_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmQYB-0005Ae-VH for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 18:31:29 -0400 Received: from cheetah.birch.relay.mailchannels.net ([23.83.209.34]:53928) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hmQYB-000593-JD for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 18:31:27 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 49E5F20878 for ; Sat, 13 Jul 2019 22:31:24 +0000 (UTC) Received: from pdx1-sub0-mail-a37.g.dreamhost.com (100-96-4-184.trex.outbound.svc.cluster.local [100.96.4.184]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id C2F81206D2 for ; Sat, 13 Jul 2019 22:31:23 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a37.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Sat, 13 Jul 2019 22:31:24 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Madly-Stupid: 03eab0fb130363e0_1563057084063_2193332523 X-MC-Loop-Signature: 1563057084062:2556578661 X-MC-Ingress-Time: 1563057084062 Received: from pdx1-sub0-mail-a37.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a37.g.dreamhost.com (Postfix) with ESMTP id 85C31803F2 for ; Sat, 13 Jul 2019 15:31:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:date:message-id:mime-version:content-type; s= linkov.net; bh=l0noHOFfyMnRa0m5vBOzN7PlknA=; b=tgxXiKKMEmuYjKXfc NkzP6HxSta1Sebfacn8Cil5Dsp2sbavvdbU9C9vjOQwrHqUl1J4jUZxVc8YCTXVW mciGEQ8fqvGDy2jzOd7BdWmTjw43dOs2mn/f+HiIuA3BD6jdC6aR/+VGBXHX9wj1 mdV37UfsP2jdOLmR8ud2RqG9Hk= Received: from mail.jurta.org (m91-129-103-134.cust.tele2.ee [91.129.103.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a37.g.dreamhost.com (Postfix) with ESMTPSA id 508B0803FB for ; Sat, 13 Jul 2019 15:31:16 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a37 From: Juri Linkov Organization: LINKOV.NET Date: Sun, 14 Jul 2019 01:27:15 +0300 Message-ID: <874l3p4lks.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrheefgdeflecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufhofffkfgggtgesmhdtreertdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrddufeegnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtfedrudefgedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 23.83.209.34 X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain It would be very useful to have the command to grep git logs, for instance, to search commits by bug numbers in format "bug#36789" and many other such use cases: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-log-search.patch diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index eb6d6d331f..d39af516a9 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -337,6 +337,10 @@ ;; Insert in BUFFER the revision log for the changes that will be ;; received when performing a pull operation from REMOTE-LOCATION. ;; +;; - log-search (pattern) +;; +;; Search for PATTERN in the revision log. +;; ;; - log-view-mode () ;; ;; Mode to use for the output of print-log. This defaults to @@ -2526,6 +2530,16 @@ vc-log-outgoing (vc-incoming-outgoing-internal backend (or remote-location "") "*vc-outgoing*" 'log-outgoing))) +;;;###autoload +(defun vc-log-search (pattern) + "Search a log of changes for PATTERN." + (interactive (list (read-regexp "Log search pattern: "))) + (let ((backend (vc-deduce-backend))) + (unless backend + (error "Buffer is not version controlled")) + (vc-incoming-outgoing-internal backend pattern + "*vc-search*" 'log-search))) + ;;;###autoload (defun vc-log-mergebase (_files rev1 rev2) "Show a log of changes between the merge base of REV1 and REV2 revisions. diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index 8b82856332..d1d6a7408e 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1073,6 +1075,13 @@ vc-git-log-incoming "@{upstream}" remote-location)))) +(defun vc-git-log-search (buffer pattern) + (vc-setup-buffer buffer) + (vc-git-command + buffer 'async nil + "log" + "--no-color" "-i" (format "--grep=%s" pattern))) + (defun vc-git-mergebase (rev1 &optional rev2) (unless rev2 (setq rev2 "HEAD")) (string-trim-right (vc-git--run-command-string nil "merge-base" rev1 rev2))) @@ -1089,7 +1100,7 @@ vc-git-log-view-mode (set (make-local-variable 'log-view-file-re) regexp-unmatchable) (set (make-local-variable 'log-view-per-file-logs) nil) (set (make-local-variable 'log-view-message-re) - (if (not (eq vc-log-view-type 'long)) + (if (not (memq vc-log-view-type '(long log-search))) (cadr vc-git-root-log-format) "^commit *\\([0-9a-z]+\\)")) ;; Allow expanding short log entries. @@ -1098,7 +1109,7 @@ vc-git-log-view-mode (set (make-local-variable 'log-view-expanded-log-entry-function) 'vc-git-expanded-log-entry)) (set (make-local-variable 'log-view-font-lock-keywords) - (if (not (eq vc-log-view-type 'long)) + (if (not (memq vc-log-view-type '(long log-search))) (list (cons (nth 1 vc-git-root-log-format) (nth 2 vc-git-root-log-format))) (append --=-=-=-- From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Jul 2019 15:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov , 36644@debbugs.gnu.org Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156320313414480 (code B ref 36644); Mon, 15 Jul 2019 15:06:01 +0000 Received: (at 36644) by debbugs.gnu.org; 15 Jul 2019 15:05:34 +0000 Received: from localhost ([127.0.0.1]:48728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hn2Xk-0003lS-B2 for submit@debbugs.gnu.org; Mon, 15 Jul 2019 11:05:34 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:40204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hn2Xh-0003lC-8Y for 36644@debbugs.gnu.org; Mon, 15 Jul 2019 11:05:30 -0400 Received: by mail-wm1-f44.google.com with SMTP id v19so15586822wmj.5 for <36644@debbugs.gnu.org>; Mon, 15 Jul 2019 08:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=363X5eRw2migw/pMShX2qOEA1rAtWxrGuUJUMyLiwOM=; b=b8lRyK/av1BgHh8XhvS4xe6NDwAsEqhcFEI/9KMhHN3qH9jgjK7eX/r676SXxEva3o 4X3MsbWrYkwWjtMs3FWnrj8ogGGnMlG38Fa7O1kCzEtMVK+Bw1ybmuH2Uo9d9zr+fT+z PVR3feAaggKFmwvePENo1lMJqomJHoNM7nxeeRGGWLt98NPBzpqpXEL3NwvNOc7k1lJX 4jIBO6JDWcQCVaEKAc0YKCZLuoA9WmQG2cZS3crt32ryw0EwCSc7a4sxSMtvBEKWWkfL uXqXznuoHRSJJNc6m3EGktNPSdTcwFqiQ6fQjsi5VyrHonUvGj4C2dIz8Lj8+iTXNhtP G99w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=363X5eRw2migw/pMShX2qOEA1rAtWxrGuUJUMyLiwOM=; b=acN0F26L2KZMHg97BqRpihWUt6QRnzZoHIM4qoOtZqvgYsAwSaHfLNWG9YbrfVoDlk YErVw5NsPxHPMI99+IZik+qOuBRZsGbKWYztSlX9AccrfHNsT9Al3DWdothhErdS9xIc HOsD0YtLacjP71Nmg/MYT/6Jn6h13O0nfYWHjQ0XiErpui3tyIr+h4ojWbgXpTdiRkSQ idPjX/GIrT618YOGEJWdQVedGe4nFl8Gk0zHcZLKr46yXV+LtlhXz4+rppR9ZVL734Xa xqb7eR8Afu7HBEpd3HjeMuJOREv9KUDMbxmgnKq7kbWzyh/X3lXR0lRpSZlsctkVLckO EViw== X-Gm-Message-State: APjAAAUmD2x2UxrQsntOi0lWrPt1YZ0+4Dt5OhRhR5fdZ8DAXN0uyut8 M5frn5EXhlzKcFLp0EfJDds3cov5 X-Google-Smtp-Source: APXvYqz6QGeS0XKg7YBb/kg420K3SPYGSLJOoiCafyRPNITY2O216RKQ4NaTH4Xi8G43phsdOt3neg== X-Received: by 2002:a1c:6c14:: with SMTP id h20mr20470162wmc.168.1563203122954; Mon, 15 Jul 2019 08:05:22 -0700 (PDT) Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id c1sm35082877wrh.1.2019.07.15.08.05.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jul 2019 08:05:21 -0700 (PDT) References: <874l3p4lks.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Mon, 15 Jul 2019 18:05:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <874l3p4lks.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Hi Juri, On 14.07.2019 1:27, Juri Linkov wrote: > It would be very useful to have the command to grep git logs, > for instance, to search commits by bug numbers in format "bug#36789" > and many other such use cases: I like the idea. > +;; - log-search (pattern) > +;; > +;; Search for PATTERN in the revision log. Is pattern a regexp or a verbatim string? That should be documented. Git supports regexps, but maybe we should look at what other backends can support as well. I wonder if the format of the output should be specified as well. E.g. by saying that it's the same as for print-log, long version. > +(defun vc-git-log-search (buffer pattern) > + (vc-setup-buffer buffer) > + (vc-git-command > + buffer 'async nil > + "log" > + "--no-color" "-i" (format "--grep=%s" pattern))) Should this use shell-quote-argument? From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Jul 2019 22:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 36644@debbugs.gnu.org Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156322974426156 (code B ref 36644); Mon, 15 Jul 2019 22:30:03 +0000 Received: (at 36644) by debbugs.gnu.org; 15 Jul 2019 22:29:04 +0000 Received: from localhost ([127.0.0.1]:49340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hn9Sy-0006nn-0b for submit@debbugs.gnu.org; Mon, 15 Jul 2019 18:29:04 -0400 Received: from azure.elm.relay.mailchannels.net ([23.83.212.7]:23631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hn9Sw-0006nN-CJ for 36644@debbugs.gnu.org; Mon, 15 Jul 2019 18:29:02 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id F1A2A2C1F20; Mon, 15 Jul 2019 22:29:00 +0000 (UTC) Received: from pdx1-sub0-mail-a55.g.dreamhost.com (100-96-92-226.trex.outbound.svc.cluster.local [100.96.92.226]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 57C002C05C7; Mon, 15 Jul 2019 22:29:00 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a55.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Mon, 15 Jul 2019 22:29:00 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Tangy-Cooing: 1839b18250a965e0_1563229740763_2715469889 X-MC-Loop-Signature: 1563229740763:27364718 X-MC-Ingress-Time: 1563229740762 Received: from pdx1-sub0-mail-a55.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a55.g.dreamhost.com (Postfix) with ESMTP id F0CF47FE4C; Mon, 15 Jul 2019 15:28:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=q4x/M+yfocrzrWuifo6InKIBUHE=; b= rotjT+f6l77jcHmDBcSk0dHWVGknV4tbY7oxweM+TTfbY9SZu3sb69zYe5HTcn66 qTb9PNRm1KRhVt4y1CsckpYtAUFbQsUwmiSs24Jdw9F1aBrCP3bov6uKPRiQrYN6 88iVYYWI6xKXJxGqEEgu0XIGynPDunhiNADq/dcamHI= Received: from mail.jurta.org (m91-129-103-134.cust.tele2.ee [91.129.103.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a55.g.dreamhost.com (Postfix) with ESMTPSA id 761077FE50; Mon, 15 Jul 2019 15:28:52 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a55 From: Juri Linkov Organization: LINKOV.NET References: <874l3p4lks.fsf@mail.linkov.net> Date: Tue, 16 Jul 2019 01:27:40 +0300 In-Reply-To: (Dmitry Gutov's message of "Mon, 15 Jul 2019 18:05:20 +0300") Message-ID: <87blxvj5lv.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrheelgddtkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtfedrudefgeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdefrddufeegpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> It would be very useful to have the command to grep git logs, >> for instance, to search commits by bug numbers in format "bug#36789" >> and many other such use cases: > > I like the idea. Thanks for the review. Installed to master after fixing according to your comments. >> +;; - log-search (pattern) >> +;; >> +;; Search for PATTERN in the revision log. > > Is pattern a regexp or a verbatim string? That should be documented. Fixed to use string. > Git supports regexps, but maybe we should look at what other backends > can support as well. It seems the most compatible type is string. > I wonder if the format of the output should be specified as well. > E.g. by saying that it's the same as for print-log, long version. Fixed by saying it's long version. Should it support short format as well? >> +(defun vc-git-log-search (buffer pattern) >> + (vc-setup-buffer buffer) >> + (vc-git-command >> + buffer 'async nil >> + "log" >> + "--no-color" "-i" (format "--grep=%s" pattern))) > > Should this use shell-quote-argument? Fixed to use shell-quote-argument. Should it have a key binding? For example, `vc-log-incoming' is bound to `C-x v I', `vc-log-outgoing' is bound to key `C-x v O', so logically `vc-log-search' would be bound to `C-x v s', but unfortunately it's already taken by `vc-create-tag'. From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Jul 2019 14:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 36644@debbugs.gnu.org Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.15632871508537 (code B ref 36644); Tue, 16 Jul 2019 14:26:02 +0000 Received: (at 36644) by debbugs.gnu.org; 16 Jul 2019 14:25:50 +0000 Received: from localhost ([127.0.0.1]:50949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnOOs-0002Dd-FM for submit@debbugs.gnu.org; Tue, 16 Jul 2019 10:25:50 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:38015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnOOq-0002DK-2r for 36644@debbugs.gnu.org; Tue, 16 Jul 2019 10:25:48 -0400 Received: by mail-wr1-f47.google.com with SMTP id g17so21198128wrr.5 for <36644@debbugs.gnu.org>; Tue, 16 Jul 2019 07:25:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DWMW/w5hpPeXRYxYvGJaAX44mUetuocd3MHYAVLJSJ4=; b=rumER4ofi39SPoeON+EcyP6/DpwgXA2OBcjpXAmXqN0Bcxyb8CzXPL5OivawYt/m0s +16F+nJ7GcUw540PcDtrEVoD2PXn1/Sj7QeGjZ7GzsCQGfpgXQdeQWelsOUz5U5b2sxJ P69Sq0B30MM+JMBuuVerc0RNLup3UEIu9/IuAPYG0gXocAEZ8XysRWM8M71kvmvZ5Rg/ X3csKk4JQss23WnoSs+BWyXD0oauRHEBTNNBuTUI7utv91IGhSH9pEXyL58EaQ1YHD8v K0Ief8yfUiHmccs0qbGc5K8xcO+cuN8Xzv3vslvni4zb9vci9q/8MDlXTVFHmiAMylfo kBYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DWMW/w5hpPeXRYxYvGJaAX44mUetuocd3MHYAVLJSJ4=; b=qqLI7Dgw7knGzkM64t35ZCOIPlG7wmi6+G/Rk+39129pBxtBu/A8nWwsmhpfX/W7PR iWKT02n2e+uWsy7Vbkl+HseSctEKwYBVS1H/fySvDbvmO/iDgPEPCtuEoqOAYsDNIxrC AJYQEJ4vMAW2pAzrnxpVwRy0B/I5aapxRMrgKX0W6bSTJ30wpVpOkzA4japa8ss/VPp+ fjuwgHt7O+3nKRnZ2RC5a/e4f51YJ/kGB5i+HltfjDEd+DwvWAioAGa6GETM1ZYRMcl3 O7nRnXso69Vr63lbPQXGzlxBedM8WiG/uH7xvZFbdr1bx3aC8UhIOzLFSs+tEgQ6JWqH F0Uw== X-Gm-Message-State: APjAAAVrxkQDSKGBKFaMH7h0CLhFH5Ivbjd5Ppd9QyGg0TI356d3gE0T WXM8FDG4gUGx5fyfOp1Uq7eiRLHe X-Google-Smtp-Source: APXvYqwubet5xYDJIiHRgLBW3s1eOrmRWjvyRQIbG1cHgS5f0MiQtojPZ46vYm3TvJtsxvYmcKcWMw== X-Received: by 2002:a5d:56c7:: with SMTP id m7mr36733519wrw.64.1563287141946; Tue, 16 Jul 2019 07:25:41 -0700 (PDT) Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id n9sm37477157wrp.54.2019.07.16.07.25.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jul 2019 07:25:41 -0700 (PDT) References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> Date: Tue, 16 Jul 2019 17:25:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <87blxvj5lv.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 16.07.2019 1:27, Juri Linkov wrote: > Thanks for the review. Installed to master after fixing > according to your comments. Thanks. >>> +;; - log-search (pattern) >>> +;; >>> +;; Search for PATTERN in the revision log. >> >> Is pattern a regexp or a verbatim string? That should be documented. > > Fixed to use string. Since --grep expects a regexp, shouldn't PATTERN be passed through regexp-quote as well? Though it expects Emacs regexps, so it doesn't quote parens or pipes. >> Git supports regexps, but maybe we should look at what other backends >> can support as well. > > It seems the most compatible type is string. OK, if that is your conclusion. >> I wonder if the format of the output should be specified as well. >> E.g. by saying that it's the same as for print-log, long version. > > Fixed by saying it's long version. > > Should it support short format as well? I don't know. How would it be used? > Should it have a key binding? > > For example, `vc-log-incoming' is bound to `C-x v I', > `vc-log-outgoing' is bound to key `C-x v O', so logically > `vc-log-search' would be bound to `C-x v s', but unfortunately > it's already taken by `vc-create-tag'. 'C-x v S', then? From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Jul 2019 14:45:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 36644@debbugs.gnu.org, Juri Linkov Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156328829510549 (code B ref 36644); Tue, 16 Jul 2019 14:45:03 +0000 Received: (at 36644) by debbugs.gnu.org; 16 Jul 2019 14:44:55 +0000 Received: from localhost ([127.0.0.1]:50972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnOhL-0002k4-05 for submit@debbugs.gnu.org; Tue, 16 Jul 2019 10:44:55 -0400 Received: from mx2.suse.de ([195.135.220.15]:55428 helo=mx1.suse.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnOhI-0002jq-4E for 36644@debbugs.gnu.org; Tue, 16 Jul 2019 10:44:53 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6E01EB174; Tue, 16 Jul 2019 14:44:04 +0000 (UTC) From: Andreas Schwab References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> X-Yow: NOW, I'm taking the NEXT FLIGHT to ACAPULCO so I can write POEMS about BROKEN GUITAR STRINGS and sensuous PRE-TEENS!! Date: Tue, 16 Jul 2019 16:44:03 +0200 In-Reply-To: <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> (Dmitry Gutov's message of "Tue, 16 Jul 2019 17:25:39 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Jul 16 2019, Dmitry Gutov wrote: > On 16.07.2019 1:27, Juri Linkov wrote: > >> Thanks for the review. Installed to master after fixing >> according to your comments. > > Thanks. > >>>> +;; - log-search (pattern) >>>> +;; >>>> +;; Search for PATTERN in the revision log. >>> >>> Is pattern a regexp or a verbatim string? That should be documented. >> >> Fixed to use string. > > Since --grep expects a regexp, shouldn't PATTERN be passed through > regexp-quote as well? You can use --fixed-strings. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Jul 2019 15:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 36644@debbugs.gnu.org, Juri Linkov Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156328970512810 (code B ref 36644); Tue, 16 Jul 2019 15:09:02 +0000 Received: (at 36644) by debbugs.gnu.org; 16 Jul 2019 15:08:25 +0000 Received: from localhost ([127.0.0.1]:50981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnP44-0003KY-GO for submit@debbugs.gnu.org; Tue, 16 Jul 2019 11:08:24 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:32862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnP40-0003KH-6e for 36644@debbugs.gnu.org; Tue, 16 Jul 2019 11:08:22 -0400 Received: by mail-wm1-f51.google.com with SMTP id h19so16978013wme.0 for <36644@debbugs.gnu.org>; Tue, 16 Jul 2019 08:08:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version; bh=HeFtcZA1fCZEoRATTzq8jy3HUeOmXH2wnpvnn7xMiNY=; b=tvU29N6VlokJ9UMrdz27+yAj3+RGmg3IKg8rTHGasC+sQNSbzk3b9dkGduxkH6EUyV RLDx4a1fbXIYi7hKqh9TvWbrsFD4lg8bshcQ1rLGcIE8QKZmVFFaTC3W1KyhpsFfybbS PgdtxUK0ll0GqQe9tjpprv1khDe67aoM8JWAli1NH3Z/4z92CTtffU9TCu5ODKQQRbmg kL0cIa1S8l1B+9OKfNc98cKGru6Cm9/NZGe/nXJw3sHPxFhFFYUrXP4UkxbfYDiZj4Ef F0eSWxhhnHscW2+Ywko96kCnog18wo8F5RGBRaBr0XWgLU8P4pLSrTqv1MBOIdEDFaxE 3tlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=HeFtcZA1fCZEoRATTzq8jy3HUeOmXH2wnpvnn7xMiNY=; b=B/+y8lM/W1zzrTFN3OgdHgXAghe1iigroEoJiqgjIeAplwdBzaPacT24boMtAoRu+O clFIFZgeocEisiZQljAg6R/1K8+NtmaXxXZr5A1W0GA8EmIrOBhRFyTL2DiN+LBU2r6M Gh7rlpznIwPymvnyfR3BDgDhnIEMet8IsM/qPu+U4fipXljXJv3hFXmGOZYCqu+ONLwn 9hVMX7d1NDm133NWpHrou+3IWD6c65We6MT04iBtOAschJkKSjiZKSybWlf2wN4/eejt S5z7S0kpBspHFwr5zUWU52OXd9oFX2cL37IV0Jt14I5rvnpC1+Budfe1R4IuzWvsHaoO +scg== X-Gm-Message-State: APjAAAVsSFk/+z9+mlpPzuwxSACJUsIkfe5deT3p4498n/4jVVygRzbM Wb8yMJAXZGW19eWpMT1TUawCJGSb X-Google-Smtp-Source: APXvYqzYn+7XNqR5LYRQHrjRjtH9EaaatCL7CM0z/O2SV0/NE2GVPmkbBfWODLwOf2ERwsgrWXlZvg== X-Received: by 2002:a05:600c:230c:: with SMTP id 12mr30280006wmo.166.1563289693633; Tue, 16 Jul 2019 08:08:13 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id v5sm21404516wre.50.2019.07.16.08.08.11 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 16 Jul 2019 08:08:11 -0700 (PDT) From: Robert Pluim References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Tue, 16 Jul 2019 17:08:11 +0200 In-Reply-To: <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> (Dmitry Gutov's message of "Tue, 16 Jul 2019 17:25:39 +0300") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 16 Jul 2019 17:25:39 +0300, Dmitry Gutov said: >>> Git supports regexps, but maybe we should look at what other backends >>> can support as well. >> >> It seems the most compatible type is string. Dmitry> OK, if that is your conclusion. If the most compatible type is string, surely emacs should do no regexp-quoting or anything else on the argument, but just pass it verbatim to the backend search command. That way you could do eg Bug.*0 to get all log entries with a bug reference ending in 0. Robert From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Jul 2019 20:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 36644@debbugs.gnu.org Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156330889525392 (code B ref 36644); Tue, 16 Jul 2019 20:29:02 +0000 Received: (at 36644) by debbugs.gnu.org; 16 Jul 2019 20:28:15 +0000 Received: from localhost ([127.0.0.1]:51219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnU3a-0006bU-Mf for submit@debbugs.gnu.org; Tue, 16 Jul 2019 16:28:14 -0400 Received: from bonobo.birch.relay.mailchannels.net ([23.83.209.22]:19435) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnU3X-0006b4-9s for 36644@debbugs.gnu.org; Tue, 16 Jul 2019 16:28:11 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 1721E8C089F; Tue, 16 Jul 2019 20:28:10 +0000 (UTC) Received: from pdx1-sub0-mail-a6.g.dreamhost.com (100-96-1-113.trex.outbound.svc.cluster.local [100.96.1.113]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 8DF358C2545; Tue, 16 Jul 2019 20:28:09 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a6.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Tue, 16 Jul 2019 20:28:09 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Sponge-Zesty: 1deb99d3782fc62f_1563308889895_2443496174 X-MC-Loop-Signature: 1563308889895:3267189229 X-MC-Ingress-Time: 1563308889895 Received: from pdx1-sub0-mail-a6.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTP id 7BF56803B9; Tue, 16 Jul 2019 13:28:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=V/4PaUFVFCW/9iIDNerA4lMe3+U=; b= da2mHHzBDKTwdyj5xDKbKcePyd6jPpOXj/LPC+y3ihMdafzsjA0roXUqvf8tTzB6 2v2eGJrWn0jlaCcEZ5TaaGZTg1FTlFNKAjGNlQcFw3fHhjuhHKkHE42FZyxcgzLR qX8KCV7W/AyixRM6mLzh6M9TpSSE9quLrNPt49l1tvw= Received: from mail.jurta.org (m91-129-103-134.cust.tele2.ee [91.129.103.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTPSA id 6FAAA803B3; Tue, 16 Jul 2019 13:28:05 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a6 From: Juri Linkov Organization: LINKOV.NET References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> Date: Tue, 16 Jul 2019 23:15:32 +0300 In-Reply-To: <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> (Dmitry Gutov's message of "Tue, 16 Jul 2019 17:25:39 +0300") Message-ID: <87tvbliw37.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddriedtgdduheegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrddufeegnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtfedrudefgedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegughhuthhovheshigrnhguvgigrdhruhenucevlhhushhtvghrufhiiigvpedu X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> Is pattern a regexp or a verbatim string? That should be documented. >> >> Fixed to use string. > > Since --grep expects a regexp, shouldn't PATTERN be passed through > regexp-quote as well? Though it expects Emacs regexps, so it doesn't quote > parens or pipes. Should this still be used when the need is to pass regexps to the backend search command verbatim? >>> Git supports regexps, but maybe we should look at what other backends >>> can support as well. >> >> It seems the most compatible type is string. > > OK, if that is your conclusion. I'm still not sure. Regexps are more useful. >>> I wonder if the format of the output should be specified as well. >>> E.g. by saying that it's the same as for print-log, long version. >> >> Fixed by saying it's long version. >> >> Should it support short format as well? > > I don't know. How would it be used? Short format displays one line per entry and allows expanding after pressing RET. OTOH, when using long format we could highlight all matches in log entries that will be immediately visible after the command finishes (like in vc-git-grep output buffers). However, when allowed to use regexp patterns, I don't know how to highlight matches in git-log output buffer using Emacs regexps when pattern uses e.g. Perl-compatible regexp allowed in git-log. >> Should it have a key binding? >> >> For example, `vc-log-incoming' is bound to `C-x v I', >> `vc-log-outgoing' is bound to key `C-x v O', so logically >> `vc-log-search' would be bound to `C-x v s', but unfortunately >> it's already taken by `vc-create-tag'. > > 'C-x v S', then? This is good mnemonic keybinding. The only doubt when adding a new keybinding is to think if it could be more useful as a prefix key. Maybe in this case upper-case shifted 'S' is not good as a prefix key. Otherwise such prefix key could accommodate other vc search related commands like grep vc files, etc. From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Jul 2019 20:29:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 36644@debbugs.gnu.org Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156330890525429 (code B ref 36644); Tue, 16 Jul 2019 20:29:03 +0000 Received: (at 36644) by debbugs.gnu.org; 16 Jul 2019 20:28:25 +0000 Received: from localhost ([127.0.0.1]:51222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnU3l-0006c5-1t for submit@debbugs.gnu.org; Tue, 16 Jul 2019 16:28:25 -0400 Received: from azure.elm.relay.mailchannels.net ([23.83.212.7]:64954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnU3h-0006bt-NO for 36644@debbugs.gnu.org; Tue, 16 Jul 2019 16:28:22 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 9C1B35E21AD; Tue, 16 Jul 2019 20:28:20 +0000 (UTC) Received: from pdx1-sub0-mail-a6.g.dreamhost.com (100-96-38-48.trex.outbound.svc.cluster.local [100.96.38.48]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 1EA3E5E22A5; Tue, 16 Jul 2019 20:28:20 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a6.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Tue, 16 Jul 2019 20:28:20 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Bubble-Industry: 6e1b76d91c8bb861_1563308900382_1414003303 X-MC-Loop-Signature: 1563308900382:3200982811 X-MC-Ingress-Time: 1563308900382 Received: from pdx1-sub0-mail-a6.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTP id 602A2803D7; Tue, 16 Jul 2019 13:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=d0Di5Of7gJ2epTCijkCRvaCzSMY=; b= Kqj7o2v31rdbgm9YOnqYi7BWiLpd/FFiaXCg/kxRWtrJnlGMabqRyTKfelPSR6a3 WIyB9x3n2M9o29EDxBiPK8eFUuwMBHysck/IS8zfKJHAbnO8fBsi+Jr8cwxlLRhh 52L7OhcHFmdxckb1If5QTuLpgiW+SCVzGPMIX11jJAc= Received: from mail.jurta.org (m91-129-103-134.cust.tele2.ee [91.129.103.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTPSA id 31AA1803B3; Tue, 16 Jul 2019 13:28:12 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a6 From: Juri Linkov Organization: LINKOV.NET References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> Date: Tue, 16 Jul 2019 23:20:42 +0300 In-Reply-To: (Robert Pluim's message of "Tue, 16 Jul 2019 17:08:11 +0200") Message-ID: <87blxtivul.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddriedtgdduheegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrddufeegnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtfedrudefgedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegughhuthhovheshigrnhguvgigrdhruhenucevlhhushhtvghrufhiiigvpedv X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > >>> Git supports regexps, but maybe we should look at what other backends > >>> can support as well. > >> > >> It seems the most compatible type is string. > > Dmitry> OK, if that is your conclusion. > > If the most compatible type is string, surely emacs should do no > regexp-quoting or anything else on the argument, but just pass it > verbatim to the backend search command. That way you could do eg > > Bug.*0 > > to get all log entries with a bug reference ending in 0. Currently when using shell-quote-argument it doesn't allow using such regexps as Bug.*0. So I guess we need to remove shell-quote-argument and also to not use regexp-quote. From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Jul 2019 22:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 36644@debbugs.gnu.org, Dmitry Gutov Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.15633163218685 (code B ref 36644); Tue, 16 Jul 2019 22:32:02 +0000 Received: (at 36644) by debbugs.gnu.org; 16 Jul 2019 22:32:01 +0000 Received: from localhost ([127.0.0.1]:51278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnVzN-0002G0-G8 for submit@debbugs.gnu.org; Tue, 16 Jul 2019 18:32:01 -0400 Received: from mail-io1-f51.google.com ([209.85.166.51]:32799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnVzM-0002Fm-Fq for 36644@debbugs.gnu.org; Tue, 16 Jul 2019 18:32:01 -0400 Received: by mail-io1-f51.google.com with SMTP id z3so42675394iog.0 for <36644@debbugs.gnu.org>; Tue, 16 Jul 2019 15:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Zp53+oEUGk5qWjqf1VfCwrKjGaLJzZakfZxE3TaTnPk=; b=U//gIJ1dWB+P+CPWvfb4+JY6okOdkMQ4tdnyoxZE0znlA8p2Ir/4u8G8ts5ukw2D6x tRkM48maRbCxKrF7uZjoC66+ezQPlIuXs3RTPkjOR+u/pqk1BRR9tsVJc8FlOz5XNXEY aUlGNHAr9UgBVK89W0DC5rkya589D/3bJxXHJ4XmIHk9yManvzRoe0Bsgj8vc+YbcUk8 BruRSnYhhF1Mf3zHmGdcPdW7Z9P3A/HcDcbZeptX9P9h8VH74Um1xObbJicIj1IjGnbp DhGc8NU6aVXPsMg69BtksEFXQIPboT9EE2r1WMfMez2hYNnH0bIdTds4wZVqOPS5ZeXA nc/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Zp53+oEUGk5qWjqf1VfCwrKjGaLJzZakfZxE3TaTnPk=; b=p+7YB8giLhE5UsCIpOnYWRu1Gl4ZWs2jtUaJzPlDiK0uQj0d4b4ZTyifrRUKNif8bi /s4gcLVtXL4DL2H6Z/Ms+CAEz6ln9VN0ceMSZIfOR8V99MVplH1YMrEbdUswa79Stsha bSgLtVu7lFwlOoN0jIZwg5OEVQLGKKNTl4NvEiUgZioe0KpCDbO78KdoHpsc2klk8yKA sd5gEW6N7RydUgjFdaE9/NLz6b5rhiy8iAv0lYHkifKxQQAyCpS2RMw0GiHjlH8jc3sT YwLDSqpxLI6YXQ96MbriylIr7lNhUHfECq6Mel0MURovOpzXUB76JfZX7PsxF6yFGnDa rd6A== X-Gm-Message-State: APjAAAXQPujPBOEZhBMyXxix3bysMohQ1d2eAtESoaCy5oT6ev3qqGQS O2a50USOh5w02JnAdVQFrqKalRMk X-Google-Smtp-Source: APXvYqzG+VrQ+VdLdbeX3nuHvUDH2bMNTgdR0YtkpDiXV0J8d1VCpGrhzcLDd/b0XKkygGcK7mFRjg== X-Received: by 2002:a02:1607:: with SMTP id a7mr36499633jaa.123.1563316314580; Tue, 16 Jul 2019 15:31:54 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id l5sm41559347ioq.83.2019.07.16.15.31.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Jul 2019 15:31:53 -0700 (PDT) From: Noam Postavsky References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87blxtivul.fsf@mail.linkov.net> Date: Tue, 16 Jul 2019 18:31:52 -0400 In-Reply-To: <87blxtivul.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 16 Jul 2019 23:20:42 +0300") Message-ID: <87o91tzk4n.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: >> Bug.*0 >> >> to get all log entries with a bug reference ending in 0. > > Currently when using shell-quote-argument it doesn't allow > using such regexps as Bug.*0. So I guess we need to remove > shell-quote-argument and also to not use regexp-quote. I think shell-quote-argument is a mistake regardless, vc-git-command doesn't call a shell, so there is no need for shell-quote-argument. From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jul 2019 15:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 36644@debbugs.gnu.org Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156346208416233 (code B ref 36644); Thu, 18 Jul 2019 15:02:02 +0000 Received: (at 36644) by debbugs.gnu.org; 18 Jul 2019 15:01:24 +0000 Received: from localhost ([127.0.0.1]:54503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho7uN-0004DR-N5 for submit@debbugs.gnu.org; Thu, 18 Jul 2019 11:01:24 -0400 Received: from mail-wm1-f54.google.com ([209.85.128.54]:52922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho7uL-000478-8a for 36644@debbugs.gnu.org; Thu, 18 Jul 2019 11:01:21 -0400 Received: by mail-wm1-f54.google.com with SMTP id s3so25931172wms.2 for <36644@debbugs.gnu.org>; Thu, 18 Jul 2019 08:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yMpAgN6K0C8wtpYH7flpbp/51X8QoY5sjJA17DojgcY=; b=PIkUiBaZsxfE0hkcJH/wcHtXcib4DAKHYb1syuAXaYQibp/iE9Opq1O72pJAVIEx8b r63KZ6KpQSHdtNpHkrEcG3D1yZ5mxxJZIGYZWz5UUiG6W8Y9wePAG04x9DZ4XPHidqG0 IT4bNTWfUvyPMFGUjmWXkxiJOy5ObgabqCaWoK/tXDnnx7O1QoFPD43wTyF/HRdWNvbD xgQTgoUEXyrckH3GvHdqtyog0AI0FCvAneAT75V+6wLcIFO0GC85DslADEkYf3oCGPe2 z9rTm/KPG7QdcWgropK4JD31tqnoZTQEW1uVutZ65mJ8f4fm9SBFVzcETvDgZUCsF52s iNQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yMpAgN6K0C8wtpYH7flpbp/51X8QoY5sjJA17DojgcY=; b=ETfV+6J9BumPYqx1jTy+6N3Y84XP+PLlMoecziwogxE0VuVbIIWsy9SuXosz4mal0u rMFIu6SYE3Ti7Iil06luvdoW7hjIoLBiUGE7PicV+XeuIpx0wB1gHM1fA8jXIa7idE/I 8zS7R0YsgP4h248vmoS3hMLEwidMgfN4eLyfNDN9sx2K6jQjhqTxh40hnKfL7bZAbVm9 J8tfBO1JjHQfofwYbF1ALmmrvQ+Of+87iBNlqHwAL9cOE2nCHtOY7r6mZnmJ9cuTGc9s qIfbUIJ2eHhw7pxF0LnCEZODXEeyq+s995HXPONLc8Vwba9FQsle25XMVH7djZpmR7p6 ImIw== X-Gm-Message-State: APjAAAXUr/IvxSp1SG8L+7KpAtGuQx1jSEZmvFFzPAeXoynP8JFZSzqZ KgePUoBqo7cQE6pGSW6mmShtronseZg= X-Google-Smtp-Source: APXvYqzVIzqS8sxWAKN/RKRUcCdhfqnFdwKdWBEy3I21ZGdzd8GZ0aPVHHE1yHggnoHqku9Fg4Vy6A== X-Received: by 2002:a7b:c202:: with SMTP id x2mr41478511wmi.49.1563462074749; Thu, 18 Jul 2019 08:01:14 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id r5sm30309461wmh.35.2019.07.18.08.01.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jul 2019 08:01:13 -0700 (PDT) References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Thu, 18 Jul 2019 18:01:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <87tvbliw37.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 16.07.2019 23:15, Juri Linkov wrote: > Should this still be used when the need is to pass regexps to the backend > search command verbatim? What do you mean, "the need"? If it's a verbatim string, we should escape characters that have special meaning in regexps (or do like Andreas suggested and pass --fixed-string to 'git log'). If it's a regexp, we should document it as such. >>>> Git supports regexps, but maybe we should look at what other backends >>>> can support as well. >>> >>> It seems the most compatible type is string. >> >> OK, if that is your conclusion. > > I'm still not sure. Regexps are more useful. That is true. If Hg or Bzr support regexp search as well, we might want to choose it to be a regexp. And kind of give up on the rest (unsupported, etc). >>>> I wonder if the format of the output should be specified as well. >>>> E.g. by saying that it's the same as for print-log, long version. >>> >>> Fixed by saying it's long version. >>> >>> Should it support short format as well? >> >> I don't know. How would it be used? > > Short format displays one line per entry and allows expanding > after pressing RET. That would be a different command, or...? Anyway, the idea sounds nice. > However, when allowed to use regexp patterns, I don't know how to > highlight matches in git-log output buffer using Emacs regexps > when pattern uses e.g. Perl-compatible regexp allowed in git-log. Maybe we shouldn't allow Perl extensions. Or, IDK, give up on highlighting in that particular case. >>> Should it have a key binding? >>> >>> For example, `vc-log-incoming' is bound to `C-x v I', >>> `vc-log-outgoing' is bound to key `C-x v O', so logically >>> `vc-log-search' would be bound to `C-x v s', but unfortunately >>> it's already taken by `vc-create-tag'. >> >> 'C-x v S', then? > > This is good mnemonic keybinding. The only doubt when adding a new > keybinding is to think if it could be more useful as a prefix key. > Maybe in this case upper-case shifted 'S' is not good as a prefix key. > Otherwise such prefix key could accommodate other vc search related > commands like grep vc files, etc. FWIW, I prefer commands to have shorter bindings, when possible. Using prefix keys too much tends to conflict with that. From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jul 2019 15:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 36644@debbugs.gnu.org, Juri Linkov Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156346278321074 (code B ref 36644); Thu, 18 Jul 2019 15:14:01 +0000 Received: (at 36644) by debbugs.gnu.org; 18 Jul 2019 15:13:03 +0000 Received: from localhost ([127.0.0.1]:54516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho85f-0005Tq-8R for submit@debbugs.gnu.org; Thu, 18 Jul 2019 11:13:03 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:39743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho85a-0005TF-6C for 36644@debbugs.gnu.org; Thu, 18 Jul 2019 11:13:01 -0400 Received: by mail-wm1-f42.google.com with SMTP id u25so15723193wmc.4 for <36644@debbugs.gnu.org>; Thu, 18 Jul 2019 08:12:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=GI4kn+R9hGtXXnTqrPtLjBDPMy/D2cnX1+RimcsDn+M=; b=sdLL7K4cPKtiwscSgAZI8GzRbHlfokGsWOVYLKVsTM2AlmUm+c7XhxWjPi9NUO7rDo Gvn78maiIontL+UAeYiWZ3BE6HN4OQI54Hsz6WZx5S3+0Plz+S8Lk/BTm0L4VK+ujDnt 20z45xuzB6eR2o48d7vQS9W7WpX1PQdoH/vPclK2IqXla2jaVJLkBEaRolMAem+NcCsh ZPgcJVPfsq3TibHZ9lajtMhxm4fK43f1WvlSNkd5J+xaRzyGPanz+Gyt6O+jJ1RIN65f HSgLD7qMDC/nWzVqUPL1MRi2k0stvv/a5AIoAGc4Pm7Dqi9+1AF1VxL0qtW8MVIM4YZz lVPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=GI4kn+R9hGtXXnTqrPtLjBDPMy/D2cnX1+RimcsDn+M=; b=rY5bXSaN0/e5KHH3FjUL+d10LbizQw2XYnI4dulg4h0dRH4NTReuDnMWI9hIp1+6jf Pql63oXAIGoTNKOPVGkQS1OQTWNCmEdSS5DcA/aYbWV17tUrwBCzMl9vM32lrOq7WPxs GcgLj1WxaYqOLyFGH0FOHEnfeathn2B+xGnfAyf3w6dwNKzZKU1i2D4OB05KPp6EWG8u k2k+xp3kO2SqzPRM61wQtM6Uikh3ueabiVfiqoL66LhX7KCmJk1VdIBCM/04JGzFW9o4 vCMY84lt6ExEPPXIOr7rKY3IPofOIvtQGsEuJSdfu+qOqVMlhbPbRyhH5NJd3pTDgEti yyaQ== X-Gm-Message-State: APjAAAXJj9249QE82yHGBf51y9Q4rewgxP6Kexqx/n5vEUcHk4NKV5Ce iNWMFw6xEwl8xgzmk4Zm+G0vQg4w X-Google-Smtp-Source: APXvYqyR9B6TLHsO38cofBuwD6bw6EAAmcTtsXwt8woSYDHw5x+5906iS9XuFbXy2IX439wv+Enzbg== X-Received: by 2002:a7b:cd09:: with SMTP id f9mr40608638wmj.64.1563462771748; Thu, 18 Jul 2019 08:12:51 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id f192sm33458169wmg.30.2019.07.18.08.12.45 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 18 Jul 2019 08:12:45 -0700 (PDT) From: Robert Pluim References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Thu, 18 Jul 2019 17:12:45 +0200 In-Reply-To: (Dmitry Gutov's message of "Thu, 18 Jul 2019 18:01:12 +0300") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 18 Jul 2019 18:01:12 +0300, Dmitry Gutov s= aid: Dmitry> On 16.07.2019 23:15, Juri Linkov wrote: >> Should this still be used when the need is to pass regexps to the ba= ckend >> search command verbatim? Dmitry> What do you mean, "the need"? If it's a verbatim string, we sho= uld Dmitry> escape characters that have special meaning in regexps (or do l= ike Dmitry> Andreas suggested and pass --fixed-string to 'git log'). If it'= s a Dmitry> regexp, we should document it as such. 'verbatim' to me means that emacs should not touch it. If the backend command such as git chooses to interpret that string as a regexp, that=CA=BCs up to the command. If emacs starts escaping characters in the string or using --fixed-string, then we limit the functionality to *only* fixed strings. Robert From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jul 2019 18:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: "36644@debbugs.gnu.org" <36644@debbugs.gnu.org>, Juri Linkov Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156347298114569 (code B ref 36644); Thu, 18 Jul 2019 18:03:02 +0000 Received: (at 36644) by debbugs.gnu.org; 18 Jul 2019 18:03:01 +0000 Received: from localhost ([127.0.0.1]:54642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hoAk9-0003mu-3x for submit@debbugs.gnu.org; Thu, 18 Jul 2019 14:03:01 -0400 Received: from forward500o.mail.yandex.net ([37.140.190.195]:43971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hoAk5-0003mT-6b for 36644@debbugs.gnu.org; Thu, 18 Jul 2019 14:02:59 -0400 Received: from mxback10o.mail.yandex.net (mxback10o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::24]) by forward500o.mail.yandex.net (Yandex) with ESMTP id D85F960438; Thu, 18 Jul 2019 21:02:49 +0300 (MSK) Received: from localhost (localhost [::1]) by mxback10o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id YWJkj6j6Af-2mRCtLeF; Thu, 18 Jul 2019 21:02:49 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1563472969; bh=foWZb5kfgkaMCvRt7muJgTNBvdJbKdTWNeZUuY1XwNg=; h=Message-Id:Cc:Subject:In-Reply-To:Date:References:To:From; b=taE5pPG6SL3UCJtse2hNe59VVOKLlZ5dVVZgXDwjCjcqnfUAl0/4+b1jZ3Kv7dLvm NGZExZXoJU9Bg6QWTT4Jj3vEFNuXGptBGN56ImBwVFV3G1kBwXLIe5dEH3Ck7M+8bT e/IpqILYOHo4m4PX79zWiSHDkOk0fLdKzc+jCMuo= Authentication-Results: mxback10o.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by myt6-1dca55ddeee8.qloud-c.yandex.net with HTTP; Thu, 18 Jul 2019 21:02:48 +0300 From: Dmitry Gutov In-Reply-To: References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Thu, 18 Jul 2019 21:02:48 +0300 Message-Id: <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> Content-Transfer-Encoding: base64 Content-Type: text/html; charset=utf-8 X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) V2UgY2FuJ3QgcmVhbGx5IHVzZSB0aGlzIGFwcHJvYWNoLiBWQyBpcyBhIGhpZ2ggbGV2ZWwgYWJz dHJhY3Rpb24sIHNvIHdlIHRyeSB0byBkZWZpbmUgdGhlIHNlbWFudGljcyB3ZWxsLjxiciAvPjxi ciAvPjE4OjEyLCBKdWx5IDE4LCAyMDE5LCBSb2JlcnQgUGx1aW0gJmx0O3JwbHVpbUBnbWFpbC5j b20mZ3Q7OjxiciAvPjxibG9ja3F1b3RlIGNsYXNzPSJiNGZkNWNmMmVjOTJiYzY4Y2I4OTg3MDBi YjgxMzU1ZndtaS1xdW90ZSI+PGJsb2NrcXVvdGUgY2xhc3M9ImI0ZmQ1Y2YyZWM5MmJjNjhjYjg5 ODcwMGJiODEzNTVmd21pLXF1b3RlIj48YmxvY2txdW90ZSBjbGFzcz0iYjRmZDVjZjJlYzkyYmM2 OGNiODk4NzAwYmI4MTM1NWZ3bWktcXVvdGUiPjxibG9ja3F1b3RlIGNsYXNzPSJiNGZkNWNmMmVj OTJiYzY4Y2I4OTg3MDBiYjgxMzU1ZndtaS1xdW90ZSI+PGJsb2NrcXVvdGUgY2xhc3M9ImI0ZmQ1 Y2YyZWM5MmJjNjhjYjg5ODcwMGJiODEzNTVmd21pLXF1b3RlIj48YmxvY2txdW90ZSBjbGFzcz0i YjRmZDVjZjJlYzkyYmM2OGNiODk4NzAwYmI4MTM1NWZ3bWktcXVvdGUiPsKgT24gVGh1LCAxOCBK dWwgMjAxOSAxODowMToxMiArMDMwMCwgRG1pdHJ5IEd1dG92ICZsdDs8YSBocmVmPSJtYWlsdG86 ZGd1dG92QHlhbmRleC5ydSI+ZGd1dG92QHlhbmRleC5ydTwvYT4mZ3Q7IHNhaWQ6PGJyIC8+PC9i bG9ja3F1b3RlPjwvYmxvY2txdW90ZT48L2Jsb2NrcXVvdGU+PC9ibG9ja3F1b3RlPjwvYmxvY2tx dW90ZT48cD48YnIgLz7CoMKgwqDCoERtaXRyeSZndDsgT24gMTYuMDcuMjAxOSAyMzoxNSwgSnVy aSBMaW5rb3Ygd3JvdGU6PGJyIC8+wqDCoMKgwqAmZ3Q7Jmd0OyBTaG91bGQgdGhpcyBzdGlsbCBi ZSB1c2VkIHdoZW4gdGhlIG5lZWQgaXMgdG8gcGFzcyByZWdleHBzIHRvIHRoZSBiYWNrZW5kPGJy IC8+wqDCoMKgwqAmZ3Q7Jmd0OyBzZWFyY2ggY29tbWFuZCB2ZXJiYXRpbT88YnIgLz48YnIgLz7C oMKgwqDCoERtaXRyeSZndDsgV2hhdCBkbyB5b3UgbWVhbiwgInRoZSBuZWVkIj8gSWYgaXQncyBh IHZlcmJhdGltIHN0cmluZywgd2Ugc2hvdWxkPGJyIC8+wqDCoMKgwqBEbWl0cnkmZ3Q7IGVzY2Fw ZSBjaGFyYWN0ZXJzIHRoYXQgaGF2ZSBzcGVjaWFsIG1lYW5pbmcgaW4gcmVnZXhwcyAob3IgZG8g bGlrZTxiciAvPsKgwqDCoMKgRG1pdHJ5Jmd0OyBBbmRyZWFzIHN1Z2dlc3RlZCBhbmQgcGFzcyAt LWZpeGVkLXN0cmluZyB0byAnZ2l0IGxvZycpLiBJZiBpdCdzIGE8YnIgLz7CoMKgwqDCoERtaXRy eSZndDsgcmVnZXhwLCB3ZSBzaG91bGQgZG9jdW1lbnQgaXQgYXMgc3VjaC48YnIgLz48YnIgLz4n dmVyYmF0aW0nIHRvIG1lIG1lYW5zIHRoYXQgZW1hY3Mgc2hvdWxkIG5vdCB0b3VjaCBpdC4gSWYg dGhlIGJhY2tlbmQ8YnIgLz5jb21tYW5kIHN1Y2ggYXMgZ2l0IGNob29zZXMgdG8gaW50ZXJwcmV0 IHRoYXQgc3RyaW5nIGFzIGEgcmVnZXhwLDxiciAvPnRoYXTKvHMgdXAgdG8gdGhlIGNvbW1hbmQu IElmIGVtYWNzIHN0YXJ0cyBlc2NhcGluZyBjaGFyYWN0ZXJzIGluIHRoZTxiciAvPnN0cmluZyBv ciB1c2luZyAtLWZpeGVkLXN0cmluZywgdGhlbiB3ZSBsaW1pdCB0aGUgZnVuY3Rpb25hbGl0eSB0 bzxiciAvPipvbmx5KiBmaXhlZCBzdHJpbmdzLjxiciAvPjxiciAvPlJvYmVydDxiciAvPjwvcD48 L2Jsb2NrcXVvdGU+PGJyIC8+PGJyIC8+LS0gRG1pdHJ5IEd1dG92 From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jul 2019 18:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: "36644@debbugs.gnu.org" <36644@debbugs.gnu.org>, Juri Linkov Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156347350815496 (code B ref 36644); Thu, 18 Jul 2019 18:12:01 +0000 Received: (at 36644) by debbugs.gnu.org; 18 Jul 2019 18:11:48 +0000 Received: from localhost ([127.0.0.1]:54651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hoAse-00041q-Aa for submit@debbugs.gnu.org; Thu, 18 Jul 2019 14:11:48 -0400 Received: from mail-wm1-f54.google.com ([209.85.128.54]:54388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hoAsb-00041a-Qa for 36644@debbugs.gnu.org; Thu, 18 Jul 2019 14:11:46 -0400 Received: by mail-wm1-f54.google.com with SMTP id p74so26465571wme.4 for <36644@debbugs.gnu.org>; Thu, 18 Jul 2019 11:11:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=6z9Z0ep2S1J0YxNk1sNAqnrZskJrlAy8bnA2spvDE3s=; b=tNneYmqpIUFWoxm7FJN9Ckugm+nxX6qg2/TvAY4bx9nLm/19NJCgqy2gUQPWEeXwr/ aOI+/thkMUfMkmJ8u9sJTmfbNFhFwORUSN5B04EkaDxrWhj9T1emuELbNW107XVuxxUT lbnNIrB8t5r8m+y4Kojr1pGRIyeITK7kO7WGqUwD6TZkT+SInRG8Oux3yPzk1YBSH94v MYkiOrBFSaDanIWvRQROOLNa6TelBCe0ymOuS9Q7nN/svJ8pG/hhGX0QLxRNgKJq1LIu p2M/0A3RxdRO/Yt2XDEa2tYkPuxITFHuBVI+KxK+HCnGV7ISb8I7tPLAbvLiTIrSj5op JOQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=6z9Z0ep2S1J0YxNk1sNAqnrZskJrlAy8bnA2spvDE3s=; b=CuewZlUO6lHalXohlUMLuJEm2Ziz9LcIzzP8Qjrxk1+GvvxbnjwegGMUwGe/1hs7n6 K7s3yYnaoVJfjnMBal7Nh3dCFWk0hwNGfVAHkoa8B8sHqp80s+PYIa1vLyIlvUwCLm5+ z/YbWr/Pg7ZozhSv+1q1arYrzDrCyPC9/6rZ+IOv1TTRCT4SaXR3l6fKGph3/gDxwQ7y VOhhx7cw83gp93U/73iPXhnQwaRACcNtmAfkzfF2PgbZCGlDo//U/bcmBO15iH3MVDv3 7pgNVAn23pu4IGqWZDP/lORaO7a3AB7Hpn4oiGxjH2LCooXhEHtgU1dZTe7rqw5TZGID qWoA== X-Gm-Message-State: APjAAAVCPiYlxOwsMOjn0OW9FbbYNnktjX6BkVQVMCo/eX+93wZT4dNG JQ170YWsu4KuA/6QqRi0Hzk= X-Google-Smtp-Source: APXvYqw1848+GPd2PnYOcRA72hoBVQF25V1DCS4bXOAweHdeAJrsTl5mr+DDhaIRHYIrSX0qnEtdlA== X-Received: by 2002:a05:600c:1008:: with SMTP id c8mr43950564wmc.133.1563473499926; Thu, 18 Jul 2019 11:11:39 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:654d:cd3a:755a:ad29]) by smtp.gmail.com with ESMTPSA id 4sm62460305wro.78.2019.07.18.11.11.38 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 18 Jul 2019 11:11:39 -0700 (PDT) From: Robert Pluim References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Thu, 18 Jul 2019 20:11:38 +0200 In-Reply-To: <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> (Dmitry Gutov's message of "Thu, 18 Jul 2019 21:02:48 +0300") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 18 Jul 2019 21:02:48 +0300, Dmitry Gutov s= aid: Dmitry> We can't really use this approach. VC is a high level Dmitry> abstraction, so we try to define the semantics well. What's wrong with the semantics of 'this string is passed to the backend as-is'? I=CA=BCm really struggling to understand where the motivation is coming from to escape characters in the search string, given that each backend can have completely different regexp support. Robert From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jul 2019 22:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Robert Pluim , "36644@debbugs.gnu.org" <36644@debbugs.gnu.org> Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.15634894039749 (code B ref 36644); Thu, 18 Jul 2019 22:37:02 +0000 Received: (at 36644) by debbugs.gnu.org; 18 Jul 2019 22:36:43 +0000 Received: from localhost ([127.0.0.1]:54777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hoF11-0002XA-91 for submit@debbugs.gnu.org; Thu, 18 Jul 2019 18:36:43 -0400 Received: from beige.elm.relay.mailchannels.net ([23.83.212.16]:64981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hoF0y-0002X0-Sb for 36644@debbugs.gnu.org; Thu, 18 Jul 2019 18:36:41 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id BA24B2C2607; Thu, 18 Jul 2019 22:36:39 +0000 (UTC) Received: from pdx1-sub0-mail-a40.g.dreamhost.com (100-96-83-224.trex.outbound.svc.cluster.local [100.96.83.224]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 4858D2C2667; Thu, 18 Jul 2019 22:36:39 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a40.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Thu, 18 Jul 2019 22:36:39 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Vacuous-Spill: 4e66d97140cdea6e_1563489399564_3476837884 X-MC-Loop-Signature: 1563489399564:168654381 X-MC-Ingress-Time: 1563489399564 Received: from pdx1-sub0-mail-a40.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a40.g.dreamhost.com (Postfix) with ESMTP id 1FB2E84089; Thu, 18 Jul 2019 15:36:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=mhxfZcKvXgM1yRniq+1GY8KUHqk=; b= x5t3IXOmc5nUpRkVrjHZlGGpfxs3DXo33W3JhuNSUokaqpPxOYyGXkXVceNqgFoa 6a7JmYOQkz8efIqBv9/TMklzzp/AUvytdUU/5PUNFXe4OV4CdoI5AMju0oN6lAx1 AiBTn5XdfAZ+nRK4KPua3D5B0xeoTtzHcsq8kVUZBmM= Received: from mail.jurta.org (m91-129-110-135.cust.tele2.ee [91.129.110.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a40.g.dreamhost.com (Postfix) with ESMTPSA id 5972C84080; Thu, 18 Jul 2019 15:36:30 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a40 From: Juri Linkov Organization: LINKOV.NET References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> Date: Fri, 19 Jul 2019 01:32:12 +0300 In-Reply-To: <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> (Dmitry Gutov's message of "Thu, 18 Jul 2019 21:02:48 +0300") Message-ID: <87lfwvrpur.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrieeigddufecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddutddrudefheenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdduuddtrddufeehpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > We can't really use this approach. VC is a high level abstraction, > so we try to define the semantics well. I tend to agree with Robert. A string have to be passed to the backend as is. It seems such situations when these strings should be compatible between different backends (such as running the same command on one backend, and then repeating the same search on another backend by retrieving a previous argument from the history via M-p) are very rare. From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jul 2019 22:37:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Noam Postavsky Cc: 36644@debbugs.gnu.org, Dmitry Gutov Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.15634894109769 (code B ref 36644); Thu, 18 Jul 2019 22:37:03 +0000 Received: (at 36644) by debbugs.gnu.org; 18 Jul 2019 22:36:50 +0000 Received: from localhost ([127.0.0.1]:54780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hoF17-0002XU-Iz for submit@debbugs.gnu.org; Thu, 18 Jul 2019 18:36:50 -0400 Received: from fossa.birch.relay.mailchannels.net ([23.83.209.62]:27370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hoF15-0002XM-Uv for 36644@debbugs.gnu.org; Thu, 18 Jul 2019 18:36:48 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id C2A3F20A83; Thu, 18 Jul 2019 22:36:46 +0000 (UTC) Received: from pdx1-sub0-mail-a40.g.dreamhost.com (100-96-14-124.trex.outbound.svc.cluster.local [100.96.14.124]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 3B5752167F; Thu, 18 Jul 2019 22:36:46 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a40.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Thu, 18 Jul 2019 22:36:46 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Shoe-Lonely: 6302ca5b1ddcd3aa_1563489406520_3048343895 X-MC-Loop-Signature: 1563489406520:1467703970 X-MC-Ingress-Time: 1563489406519 Received: from pdx1-sub0-mail-a40.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a40.g.dreamhost.com (Postfix) with ESMTP id E0AD784080; Thu, 18 Jul 2019 15:36:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=P2vbc+oLKbUeiY9cNrdifyWdIsg=; b= q+SiWrkutD6n7W6ANB/liisA5qRjkAKikZnJeu3WNGar1GHCfYCJSPdTgVRlIHLz b2WNiODAk4bmMOBYHYZV+yN2U3HbyPx6HqPdep05XPxDIIBhYXCzGKgwYSV7rQH8 G65BHR+oh2346OI8lfahduNeNIUW/8bwhxlkRNeKD34= Received: from mail.jurta.org (m91-129-110-135.cust.tele2.ee [91.129.110.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a40.g.dreamhost.com (Postfix) with ESMTPSA id A9DE784082; Thu, 18 Jul 2019 15:36:38 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a40 From: Juri Linkov Organization: LINKOV.NET References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87blxtivul.fsf@mail.linkov.net> <87o91tzk4n.fsf@gmail.com> Date: Fri, 19 Jul 2019 01:35:53 +0300 In-Reply-To: <87o91tzk4n.fsf@gmail.com> (Noam Postavsky's message of "Tue, 16 Jul 2019 18:31:52 -0400") Message-ID: <878ssvnf7a.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrieeigddufecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddutddrudefheenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdduuddtrddufeehpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepnhhpohhsthgrvhhssehgmhgrihhlrdgtohhmnecuvehluhhsthgvrhfuihiivgepud X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> Bug.*0 >>> >>> to get all log entries with a bug reference ending in 0. >> >> Currently when using shell-quote-argument it doesn't allow >> using such regexps as Bug.*0. So I guess we need to remove >> shell-quote-argument and also to not use regexp-quote. > > I think shell-quote-argument is a mistake regardless, vc-git-command > doesn't call a shell, so there is no need for shell-quote-argument. Right, shell-quote-argument should be removed in any case, fixed. From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jul 2019 14:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Noam Postavsky , Juri Linkov Cc: 36644@debbugs.gnu.org Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156398025630585 (code B ref 36644); Wed, 24 Jul 2019 14:58:02 +0000 Received: (at 36644) by debbugs.gnu.org; 24 Jul 2019 14:57:36 +0000 Received: from localhost ([127.0.0.1]:37862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqIi0-0007xE-Fn for submit@debbugs.gnu.org; Wed, 24 Jul 2019 10:57:36 -0400 Received: from mail-wm1-f47.google.com ([209.85.128.47]:50316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqIhu-0007wy-Vu for 36644@debbugs.gnu.org; Wed, 24 Jul 2019 10:57:31 -0400 Received: by mail-wm1-f47.google.com with SMTP id v15so42156526wml.0 for <36644@debbugs.gnu.org>; Wed, 24 Jul 2019 07:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Mj0JQBxYy8Qz4YwYXyq+k1bgox2Xdq0j/63UHRiE93w=; b=N0VHyk776RRxKNpvqCqY2si9SR6VFo2M9tdvfKzFIH7FP6WZOkeUU2iw5ITL5ksZJI avRP6UNyprkUGM63C/gBzFtKQS1Rs542bh4lSa+Ar025k+ikJYTXEuTMgtdolczdoX5S HqAFlvjqwzNBgx7rmcMeBIFapU1eLDO8wrfOcDm7xm3bEEQdQPERHmZ4YYHfNEdUOE0y vR2/i8Ag5AksTwPFn/nFUkqe6zRjHVmko5hp4907+E5EnIwRCe2t2iy2e6v3BEq5LKpO MvsT9k85sqPG50TSzVIPjpS4KRdeDwfP3O8rUQ6CXrhdHNmd6m+AYcf23Tw31cReFD3L c24Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Mj0JQBxYy8Qz4YwYXyq+k1bgox2Xdq0j/63UHRiE93w=; b=iu1niLozmSDGW9z6dDV7M87hpwv686sFMIfkVrnhG01wCUHaOMZ2TE2jU1u1AHAQSj MYqIhDUcS25NLiwo90sprlSJM6bXowu0mYnrsUQXGUXrSfIhNCJ2iyhpNMxA070vq+Nv OL8uaHOV9firHxsBqAUVFrNVo00NYWZUntU9B8rfQl8bOZPtb3MfuL0bRRmSgmrSoMIs 1G8WBrNYku9lzb/ujtJSFYKA4aqUXiS/ZIjs/0+3UH6NHl08FnBOI53oWI8INwH74ZEb snT7mrRnbJikS36de9MgVcO/6MYQAECTAL2uQLSEcBHpTEmvcmRo+psMTJi9Qa71OQCY Q8uQ== X-Gm-Message-State: APjAAAXThOM6iDhEg5BVh9Eny+0gsVX09eA8KMAM3P8i9MJzRLMe4ao6 7pyFmjzNiX9G7kj6s+/240doFz35d5SzAw== X-Google-Smtp-Source: APXvYqxpFoUha8e813uECU4jXWCdtsLcm/snRfPaXMLxiSI4CP2fpfRjt0qCsEhuII3IxT9LVTwUkA== X-Received: by 2002:a05:600c:2111:: with SMTP id u17mr54440501wml.64.1563980244731; Wed, 24 Jul 2019 07:57:24 -0700 (PDT) Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id 4sm109157866wro.78.2019.07.24.07.57.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jul 2019 07:57:23 -0700 (PDT) References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87blxtivul.fsf@mail.linkov.net> <87o91tzk4n.fsf@gmail.com> From: Dmitry Gutov Message-ID: Date: Wed, 24 Jul 2019 17:57:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <87o91tzk4n.fsf@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 17.07.2019 1:31, Noam Postavsky wrote: > I think shell-quote-argument is a mistake regardless, vc-git-command > doesn't call a shell, so there is no need for shell-quote-argument. Right, that is true. Sorry, I got confused by code constructing the "full command" value (which intersperses the flags with spaces). From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jul 2019 15:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: Robert Pluim , "36644@debbugs.gnu.org" <36644@debbugs.gnu.org> Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156398104632224 (code B ref 36644); Wed, 24 Jul 2019 15:11:01 +0000 Received: (at 36644) by debbugs.gnu.org; 24 Jul 2019 15:10:46 +0000 Received: from localhost ([127.0.0.1]:37878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqIuk-0008Ne-G4 for submit@debbugs.gnu.org; Wed, 24 Jul 2019 11:10:46 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:41017) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqIuh-0008NL-VV for 36644@debbugs.gnu.org; Wed, 24 Jul 2019 11:10:44 -0400 Received: by mail-wr1-f44.google.com with SMTP id c2so44183955wrm.8 for <36644@debbugs.gnu.org>; Wed, 24 Jul 2019 08:10:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VelJaHnyixbKQvwid4JMU+IyQJbbhTUtYAg70qDF3pI=; b=NspPGfw/9HPQ2OMZTLSpjK24c5gObiYn1U6SXi4VSHMnuVMF+02fqyrmYdKWLX/2xy 9fzfPc3a1CCiyxEHzYHVwHwT7JCq6jpAPtvaPn2C0dXsxpFx0T7DqQCoCE9eTXmnaC/M uUOKe06ugj9idfT4V2WnYW/RG94FzwV6zqIyp6WMMfg2G4CzWJrxcUf2KI+gAMovuNcz pZ2zTONHedO59HQ6CakEqJqonoHutfbEWKISsW4e7HHVrYUuB2/Y23Bs5X7ig9HoAfbt fQ4XKtZZ8QP7fftzsBPG4+tY/lTXl+IRsCCjEGgP+vvVbvxng2xYgPrpUSw7Y0fVMScM GwnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VelJaHnyixbKQvwid4JMU+IyQJbbhTUtYAg70qDF3pI=; b=eG6jjZbBCiYwrXEiqLvSlrf7Fy+kblJRSUrf+MORk6+f4cWhphZ3H8iz5kgv/WGhoX v5cJC8GvG7ohEPO7Q6CMoFU8nrRkNNKzn2FhIfa+57LKjoLDz7nQespVE45rxTeXQw7b IgwYqTMDy/h0Cv2iW4Msg6goLQBC0C+cMS1iMkIzpKzck3kyafzDk6tsoOEv9p7nhzgh CrUsG+4d8xaAeuGzmsQ2RQFC4XXSAgp5LtEv/JH4SEu2QC50oX498EH52ybBE90VS5Mf jCwPhSY0LRinAMpoi1GD5sdRXvyEAszhRnFmp8hHUH1NAEwN9kMOcm7+uIkgBs9olpqN fYlg== X-Gm-Message-State: APjAAAWUJhaQVryke6cb6Ay2ZhF5n7Ecs0hj1Qq1RmauEHODADHzn+X3 BpEbrTRZWtqAwSjkvf1D5T9CeVV8h8t6cA== X-Google-Smtp-Source: APXvYqyFbYdW3T8ga95ps1vTNko8bhQl/djA8Crw+ve4MpbyzGZSc7iAJWj8gAYuhZowZtJTyJm8Xg== X-Received: by 2002:a5d:6389:: with SMTP id p9mr61314947wru.297.1563981037917; Wed, 24 Jul 2019 08:10:37 -0700 (PDT) Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id r15sm48822325wrj.68.2019.07.24.08.10.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jul 2019 08:10:36 -0700 (PDT) References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> Date: Wed, 24 Jul 2019 18:10:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <87lfwvrpur.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 19.07.2019 1:32, Juri Linkov wrote: >> We can't really use this approach. VC is a high level abstraction, >> so we try to define the semantics well. > > I tend to agree with Robert. A string have to be passed to the backend as is. > It seems such situations when these strings should be compatible between > different backends (such as running the same command on one backend, > and then repeating the same search on another backend by retrieving > a previous argument from the history via M-p) are very rare. I might agree with you from the practical standpoint, but vc-log-search needs a docstring that actually describes what the function is going to do. Including info on how PATTERN is going to be interpreted. E.g. whether "foo.txt" will only match literally, or whether "." can be substituted by any character. And if PATTERN is a regexp, what kind of regexp it's going to be interepreted as: basic RE, extended RE, Emacs RE, or Perl RE (probably not the last one anyway). I suppose we can choose one of these and say e.g. that pattern is interpreted as an extended regular expression, except for some backends that don't support that. I wonder how we're going to convey the latter to the user. From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jul 2019 15:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: "36644@debbugs.gnu.org" <36644@debbugs.gnu.org>, Juri Linkov Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.15639832173584 (code B ref 36644); Wed, 24 Jul 2019 15:47:01 +0000 Received: (at 36644) by debbugs.gnu.org; 24 Jul 2019 15:46:57 +0000 Received: from localhost ([127.0.0.1]:37896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqJTl-0000vk-4c for submit@debbugs.gnu.org; Wed, 24 Jul 2019 11:46:57 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:44587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqJTi-0000vV-SD for 36644@debbugs.gnu.org; Wed, 24 Jul 2019 11:46:55 -0400 Received: by mail-wr1-f45.google.com with SMTP id p17so47500961wrf.11 for <36644@debbugs.gnu.org>; Wed, 24 Jul 2019 08:46:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=8Jzg03w3yyOSsy8IHQRVTYqykKlkTOXCxRPGTne5THY=; b=CCG3wGONwHvZnMJA5EkhV9O9RWTVWRqzaYm5HersYxzofsBhaFIwI+0UwQhDy0OXjD KQ77//3bdOM7UjRkEwcx6/lcF7ZrSRF9fme11IUflDfxytS5oxXFDbw6CFCobcSWMNOJ 0nHup1Jik3I+DZ1/+KTfHD5GV8t7733qXwK/hwetrz7OhzuA8UQD81ycCy8p456jzeXE WSkAed19k477E0ncCZ8oKNWKcMkG3HK00tXn5m9oW1T+R245z0V3O1hww3YbFfcR9VWi 6UCHFzu/yuBbuKDwnOsUd2SbzaI9peUBWSwqfphzQtHFJabb/zXBSo6V0mD7COyNY0S0 JIEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=8Jzg03w3yyOSsy8IHQRVTYqykKlkTOXCxRPGTne5THY=; b=NwzoMB50CgIjHi0p9nuEpDyRZ8TVTh7mb+VYcvItZBcGUxrUMvFMU7rHqsecd03V8o 8auEHxZbNx3foMGpCydKieCl7m39MemoIzzJcmZgfP1OXRzPryk10s8Z7bPkyHNYo9n0 mh1J1S5TtkmLvEhI2QNHRjUiebUKzK5VAN47xCFoTAVZA8ZxrlosMzAlsvg+ZMFmk5gg fpQU60dYWr349KhPGCmxSU/l/pbPG+Va418mEwTZZiICbapkcox8hLBGlU7hyb1mr7M5 a3PWkmM2+yqNvgE4eXvFGA7/+/Lr+C+PmXsMm3WhWIiOBY3OZeIZEBBNzWPeQJzx5xgg ztcQ== X-Gm-Message-State: APjAAAVkqguyJh+2v8edC1xvG0R2QCKV0UTWq8UYf47PjRarPgD9XoOD QTsScj2JI7UTBhCBTMKGV8TLajoK X-Google-Smtp-Source: APXvYqyTgoYtGRiOB3GHQkaTmACGiIqqSDdUiy1/gnNToqhYo00IdbHo1GMAoEBzqJXtMULmc4sNhA== X-Received: by 2002:adf:f3cc:: with SMTP id g12mr51567406wrp.149.1563983208375; Wed, 24 Jul 2019 08:46:48 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id v15sm45607763wrt.25.2019.07.24.08.46.46 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 24 Jul 2019 08:46:46 -0700 (PDT) From: Robert Pluim References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> Date: Wed, 24 Jul 2019 17:46:46 +0200 In-Reply-To: <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> (Dmitry Gutov's message of "Wed, 24 Jul 2019 18:10:35 +0300") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 24 Jul 2019 18:10:35 +0300, Dmitry Gutov s= aid: Dmitry> On 19.07.2019 1:32, Juri Linkov wrote: >>> We can't really use this approach. VC is a high level abstraction, >>> so we try to define the semantics well. >>=20 >> I tend to agree with Robert. A string have to be passed to the back= end as is. >> It seems such situations when these strings should be compatible bet= ween >> different backends (such as running the same command on one backend, >> and then repeating the same search on another backend by retrieving >> a previous argument from the history via M-p) are very rare. Dmitry> I might agree with you from the practical standpoint, but Dmitry> vc-log-search needs a docstring that actually describes what the Dmitry> function is going to do. Including info on how PATTERN is going= to be Dmitry> interpreted. If it were implemented as 'backend show me all the logs and then emacs will search through them' then that would be required, but it=CA=BCs not, it=CA=BCs implemented as 'backend show me the logs which match STRING' Dmitry> E.g. whether "foo.txt" will only match literally, or whether ".= " can Dmitry> be substituted by any character. That will depend on the backend Dmitry> And if PATTERN is a regexp, what kind of regexp it's going to be Dmitry> interepreted as: basic RE, extended RE, Emacs RE, or Perl RE (p= robably Dmitry> not the last one anyway). As will this Dmitry> I suppose we can choose one of these and say e.g. that pattern = is Dmitry> interpreted as an extended regular expression, except for some Dmitry> backends that don't support that. I wonder how we're going to c= onvey Dmitry> the latter to the user. It=CA=BCs not a pattern. It=CA=BCs a string that is passed as-is to the bac= kend, which is free to interpret it as it wishes. From my viewpoint, we can just say "Search for STRING, which is passed unsullied to the backend's log search command. Consult the documentation for your backend to understand the matching method it uses to search for STRING." or similar. Robert From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jul 2019 15:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: Eli Zaretskii , "36644@debbugs.gnu.org" <36644@debbugs.gnu.org>, Juri Linkov Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.15639835914217 (code B ref 36644); Wed, 24 Jul 2019 15:54:01 +0000 Received: (at 36644) by debbugs.gnu.org; 24 Jul 2019 15:53:11 +0000 Received: from localhost ([127.0.0.1]:37900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqJZm-00015x-WE for submit@debbugs.gnu.org; Wed, 24 Jul 2019 11:53:11 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:39905) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqJZm-00015j-0X for 36644@debbugs.gnu.org; Wed, 24 Jul 2019 11:53:10 -0400 Received: by mail-wr1-f47.google.com with SMTP id x4so47512381wrt.6 for <36644@debbugs.gnu.org>; Wed, 24 Jul 2019 08:53:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uTihQN2zpYQVNMM8pywnF+oXA+lkvmUHPNiaMhpsPw8=; b=TurY8k6ALPL8iM8i5ezvUgoaJ/hXh1LCLtK+CKHnQ6Pe08SFRo+XuQsE3zdn6+sRRh 3/FfDrGdB8v+K5t3NNwDP2qknJV/RK+GdvdjwE+yJQWZ6K3zra73tX8R0KvS/XpMVksy 6z9zh6nJ1T4oMXqJwEd8ZIX+T8Um67xW75CDKDJFuQGi6nkgvtXZu0E4OePvJBUnkedK /RiSSnJygW9k40WbJM3q291HhBdj0rLYPcyYTY3AAJyA2cbC+FsLhcZ+Xz6ewohdXpZx jx6exi8/lLWeqCN//xYPlFOct143jRtiVqucBH49Vv3uCpZufYoPZeZAvqCHmrAHxlN6 P4CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uTihQN2zpYQVNMM8pywnF+oXA+lkvmUHPNiaMhpsPw8=; b=myKB7OwhAg2q92J1daxcD0FY+1VQX7fDN1HiTkzYjyNQTowDmR4X1jl0jy06kODX6H /DcFkb00dyqye9vQPx34QQ0hj+zprxel70NL9ItSLytygKbC0AwGFEtPgOdpi6iZqVaw i6zYeDCdlF4IW6wf5sMqLSUP6iXvNjloQenqA5h+T0OyAbrgSveKHaZxbh6oU2wTFZ7U 2nXPPD10U4wrLdWI/EJHrJuzLOEpcBHYOnfA8DoZP7uVLhMNN8PPxb57yz2cO9T2QqaD IUOZnASWRXo6iljgaY0r35wMvoknWGIQG+5KiXGFc+07oUL0M94TD4wtxMx/D1OC0IGc 4ERg== X-Gm-Message-State: APjAAAXS9l1yS4eiXXQPr20UB+bjVT1jRJ/zjETfBEntCpZ8uCMoYPrr 1G9vBdotfFlQDLpJoemD7r8= X-Google-Smtp-Source: APXvYqzbAvXcU0MRxmD19ofCyuEIo43/UUNsVWzYQEvb2WUV5+H2i+hF5lJAnCUm69DS+i1n2IyWmg== X-Received: by 2002:adf:afe2:: with SMTP id y34mr86552882wrd.250.1563983583981; Wed, 24 Jul 2019 08:53:03 -0700 (PDT) Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id x24sm45247167wmh.5.2019.07.24.08.53.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jul 2019 08:53:03 -0700 (PDT) References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> From: Dmitry Gutov Message-ID: <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> Date: Wed, 24 Jul 2019 18:53:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 24.07.2019 18:46, Robert Pluim wrote: >>>>>> On Wed, 24 Jul 2019 18:10:35 +0300, Dmitry Gutov said: > > Dmitry> On 19.07.2019 1:32, Juri Linkov wrote: > >>> We can't really use this approach. VC is a high level abstraction, > >>> so we try to define the semantics well. > >> > >> I tend to agree with Robert. A string have to be passed to the backend as is. > >> It seems such situations when these strings should be compatible between > >> different backends (such as running the same command on one backend, > >> and then repeating the same search on another backend by retrieving > >> a previous argument from the history via M-p) are very rare. > > Dmitry> I might agree with you from the practical standpoint, but > Dmitry> vc-log-search needs a docstring that actually describes what the > Dmitry> function is going to do. Including info on how PATTERN is going to be > Dmitry> interpreted. > > If it were implemented as 'backend show me all the logs and then emacs > will search through them' then that would be required, but itʼs not, > itʼs implemented as 'backend show me the logs which match STRING' Again, it's about documentation and about commands doing things in a way that the user can anticipate. > Dmitry> E.g. whether "foo.txt" will only match literally, or whether "." can > Dmitry> be substituted by any character. > > That will depend on the backend > > Dmitry> And if PATTERN is a regexp, what kind of regexp it's going to be > Dmitry> interepreted as: basic RE, extended RE, Emacs RE, or Perl RE (probably > Dmitry> not the last one anyway). > > As will this > > Dmitry> I suppose we can choose one of these and say e.g. that pattern is > Dmitry> interpreted as an extended regular expression, except for some > Dmitry> backends that don't support that. I wonder how we're going to convey > Dmitry> the latter to the user. > > Itʼs not a pattern. Itʼs a string that is passed as-is to the backend, > which is free to interpret it as it wishes. From my viewpoint, we can > just say > > "Search for STRING, which is passed unsullied to the backend's log > search command. Consult the documentation for your backend to > understand the matching method it uses to search for STRING." IME this doesn't match the way we try to document commands in Emacs, but I wouldn't want to spend much time arguing about this. Eli, could you weigh in in this discussion? Would you say Robert's proposal is acceptable? From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jul 2019 16:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: rpluim@gmail.com, 36644@debbugs.gnu.org, juri@linkov.net Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.15639848356342 (code B ref 36644); Wed, 24 Jul 2019 16:14:01 +0000 Received: (at 36644) by debbugs.gnu.org; 24 Jul 2019 16:13:55 +0000 Received: from localhost ([127.0.0.1]:37909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqJtr-0001eD-9Q for submit@debbugs.gnu.org; Wed, 24 Jul 2019 12:13:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqJtp-0001dw-KC for 36644@debbugs.gnu.org; Wed, 24 Jul 2019 12:13:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hqJtk-0000rY-4m; Wed, 24 Jul 2019 12:13:48 -0400 Received: from [176.228.60.248] (port=4651 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hqJtj-0007b3-FR; Wed, 24 Jul 2019 12:13:47 -0400 Date: Wed, 24 Jul 2019 19:13:37 +0300 Message-Id: <83v9vro1fy.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> (message from Dmitry Gutov on Wed, 24 Jul 2019 18:53:01 +0300) References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: "36644@debbugs.gnu.org" <36644@debbugs.gnu.org>, > Juri Linkov , Eli Zaretskii > From: Dmitry Gutov > Date: Wed, 24 Jul 2019 18:53:01 +0300 > > > Itʼs not a pattern. Itʼs a string that is passed as-is to the backend, > > which is free to interpret it as it wishes. From my viewpoint, we can > > just say > > > > "Search for STRING, which is passed unsullied to the backend's log > > search command. Consult the documentation for your backend to > > understand the matching method it uses to search for STRING." > > IME this doesn't match the way we try to document commands in Emacs, but > I wouldn't want to spend much time arguing about this. > > Eli, could you weigh in in this discussion? Would you say Robert's > proposal is acceptable? Yes, I think on balance it's acceptable. I also see your point: it would be nice to be able to document the semantics of PATTERN in a backend-independent way. But I think this is next to impossible in this case, both because of significant differences in the backend capabilities (e.g., bzr doesn't have the equivalent of Git's --fixed-strings, AFAICT), and because some backend allow great flexibility in interpreting PATTERN, under control of optional switches passed to the backend. the only way to make this backend-independent is to do the search in Emacs Lisp, which I think will slow down the command too much. So I think we should treat this as we do in "M-x grep": leave the semantics of PATTERN backend-dependent, and rely on the user to quote some characters in it as needed. Admittedly, 'grep' is lower-level than 'vc-log-search', but at least we have a precedent. Note that I still think we should use PATTERN, not STRING in the doc string, because a literal string here is more an exception than a rule. But we should say that the exact semantics of PATTERN is backend-dependent, and perhaps describe how a couple of the more popular backends interpret it. From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jul 2019 16:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Eli Zaretskii , "36644@debbugs.gnu.org" <36644@debbugs.gnu.org>, Juri Linkov Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.15639848426387 (code B ref 36644); Wed, 24 Jul 2019 16:15:02 +0000 Received: (at 36644) by debbugs.gnu.org; 24 Jul 2019 16:14:02 +0000 Received: from localhost ([127.0.0.1]:37912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqJtx-0001eq-R7 for submit@debbugs.gnu.org; Wed, 24 Jul 2019 12:14:02 -0400 Received: from mail-wr1-f53.google.com ([209.85.221.53]:40153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqJtw-0001eE-LY for 36644@debbugs.gnu.org; Wed, 24 Jul 2019 12:14:01 -0400 Received: by mail-wr1-f53.google.com with SMTP id r1so47611870wrl.7 for <36644@debbugs.gnu.org>; Wed, 24 Jul 2019 09:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=HMO4r034cG97WXFK+1PpOIDx1c00MYjfLDtWM+VEle4=; b=FA9YfpRinm1e24wdFMkBcuFgZhFkUL44RZ7IHlc+aNtCzjqrUlQtG92d1I9MsR7S6Y qAbho63zTFaapZBR6ciNhNOT6fwOwRmdPV4i+FfrivIUPbmYpiF2khc0piB5ktRl2He6 EhnwSBN8j7my4k5hUobW1XWjrVWztzCQj6y8L07iCs0MHfEzAJ4yreFw2PZc0PPocZiq fd+b0Pp8+SIofa4TZyljRugmd5CK/02d4afNC8EX4S/LrDb1x7IlLVpxO/+DW2pt3ITU 7lMtmjECH35QG4OKK3iqTeP/L0sC3svljwLiF97voeRjGRM8XnHaRAvAN6x6cx6ajtIs qmJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=HMO4r034cG97WXFK+1PpOIDx1c00MYjfLDtWM+VEle4=; b=GalxLuy0W12uYpY4bwVre6q3UVIWIyd3nckCWa/qqWmeTLYAHCyGOi/aX91E2Xa7cV zXsYRlsvV8BrV0BRbTAhhDbW6AzI1G6WRF6yufoFZhn6Dc/oSyWWWkQ2QAtUeFOJ86AQ QSBVdfNsrKP+b+agHY+Qx7VeKseUD8DVd3sJGFaMOXA53ge3tS+vxjDQmmEX8uu0K2KV 2f8ILwBe7YYSGtWAMtsOVxql8uKmI0d/VPtrdMSjMsY8O/dDekQwrBBj5vksl7uVz6X4 M803n5w5ciIOy1CUZaP+jAg02GBFu6lcAK3/fdbxtYo+84H03FDyT4C2wp0mQ41D8hKq x2PA== X-Gm-Message-State: APjAAAWv5qzRCs+Sse1IipWGwFXmO1tvNrb+drwJNneS86c9euKG5S6X O2HO+Gbw5vOwYap7WuWp8dM= X-Google-Smtp-Source: APXvYqznAWsk9wGRPJqbppfN4nh67o9PrNyvdbFqec7ok+uUb1OcLB4gF0PS7w2o1YQUSJDbfRwp1A== X-Received: by 2002:a5d:4e50:: with SMTP id r16mr83555786wrt.227.1563984834782; Wed, 24 Jul 2019 09:13:54 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id z1sm49589497wrv.90.2019.07.24.09.13.53 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 24 Jul 2019 09:13:54 -0700 (PDT) From: Robert Pluim References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> Date: Wed, 24 Jul 2019 18:13:53 +0200 In-Reply-To: <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> (Dmitry Gutov's message of "Wed, 24 Jul 2019 18:53:01 +0300") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 24 Jul 2019 18:53:01 +0300, Dmitry Gutov s= aid: >> It=CA=BCs not a pattern. It=CA=BCs a string that is passed as-is to = the backend, >> which is free to interpret it as it wishes. From my viewpoint, we can >> just say >>=20 >> "Search for STRING, which is passed unsullied to the backend's log >> search command. Consult the documentation for your backend to >> understand the matching method it uses to search for STRING." Dmitry> IME this doesn't match the way we try to document commands in E= macs, Dmitry> but I wouldn't want to spend much time arguing about this. Dmitry> Eli, could you weigh in in this discussion? Would you say Rober= t's Dmitry> proposal is acceptable? Going back to Juri's original proposal: +;;;###autoload +(defun vc-log-search (pattern) + "Search a log of changes for PATTERN." + (interactive (list (read-regexp "Log search pattern: "))) + (let ((backend (vc-deduce-backend))) + (unless backend + (error "Buffer is not version controlled")) + (vc-incoming-outgoing-internal backend pattern + "*vc-search*" 'log-search))) + How about: "Search a log of changes for PATTERN. How PATTERN is interpreted will depend on how each individual backend's log search command is implemented, as some can only match fixed strings, some have regular expression support, etc." Robert From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jul 2019 17:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: juri@linkov.net, 36644@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156398791612040 (code B ref 36644); Wed, 24 Jul 2019 17:06:01 +0000 Received: (at 36644) by debbugs.gnu.org; 24 Jul 2019 17:05:16 +0000 Received: from localhost ([127.0.0.1]:37943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqKhY-000388-BI for submit@debbugs.gnu.org; Wed, 24 Jul 2019 13:05:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34343) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqKhW-00037c-HX for 36644@debbugs.gnu.org; Wed, 24 Jul 2019 13:05:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54980) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hqKhQ-0006cz-OM; Wed, 24 Jul 2019 13:05:08 -0400 Received: from [176.228.60.248] (port=3785 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hqKhP-0005u6-PH; Wed, 24 Jul 2019 13:05:08 -0400 Date: Wed, 24 Jul 2019 20:04:58 +0300 Message-Id: <83tvbbnz2d.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Robert Pluim on Wed, 24 Jul 2019 18:13:53 +0200) References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: Eli Zaretskii , "36644\@debbugs.gnu.org" > <36644@debbugs.gnu.org>, Juri Linkov > Date: Wed, 24 Jul 2019 18:13:53 +0200 > > "Search a log of changes for PATTERN. > > How PATTERN is interpreted will depend on how each individual > backend's log search command is implemented, as some can only match > fixed strings, some have regular expression support, etc." I think this should also mention that most backends will interpret PATTERN as a regular expression. Something like this: "Search the log of changes for PATTERN. PATTERN is usually interpreted as a regular expression. However, its exact semantics is up to the backend's log search command; some can only match fixed strings." From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jul 2019 23:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Robert Pluim , 36644@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156401067410589 (code B ref 36644); Wed, 24 Jul 2019 23:25:01 +0000 Received: (at 36644) by debbugs.gnu.org; 24 Jul 2019 23:24:34 +0000 Received: from localhost ([127.0.0.1]:38187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqQcc-0002kj-GB for submit@debbugs.gnu.org; Wed, 24 Jul 2019 19:24:34 -0400 Received: from azure.elm.relay.mailchannels.net ([23.83.212.7]:60953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqQca-0002kb-SW for 36644@debbugs.gnu.org; Wed, 24 Jul 2019 19:24:33 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id B19AA3405EF; Wed, 24 Jul 2019 23:24:31 +0000 (UTC) Received: from pdx1-sub0-mail-a70.g.dreamhost.com (100-96-14-124.trex.outbound.svc.cluster.local [100.96.14.124]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 567C634116B; Wed, 24 Jul 2019 23:24:30 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a70.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Wed, 24 Jul 2019 23:24:31 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Keen-Eyes: 10f270a1411281fb_1564010671164_2631625744 X-MC-Loop-Signature: 1564010671164:301653859 X-MC-Ingress-Time: 1564010671164 Received: from pdx1-sub0-mail-a70.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a70.g.dreamhost.com (Postfix) with ESMTP id 5104590289; Wed, 24 Jul 2019 16:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=KfqGOmknw3AYdSPggAJFdIIhebc=; b= iVE9h3TC6nz8bTuQH+aSTsR6qVoXXmOyY2CR9StAZV6m/fWBNFdG+Y36mORRq6Kn M2Pljc/RVEyEwvPrUhIqXGWmR73nUJMtN1LkNddqs5nj+3hA7o2fDz5IDJoOQdT8 odWisotOtxgEX/JKBCOJQ4pP9wM8JN7HDQId+Pb94dM= Received: from mail.jurta.org (m91-129-103-76.cust.tele2.ee [91.129.103.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a70.g.dreamhost.com (Postfix) with ESMTPSA id 70D4E901BA; Wed, 24 Jul 2019 16:24:21 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a70 From: Juri Linkov Organization: LINKOV.NET References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> <83tvbbnz2d.fsf@gnu.org> Date: Thu, 25 Jul 2019 02:22:07 +0300 In-Reply-To: <83tvbbnz2d.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 24 Jul 2019 20:04:58 +0300") Message-ID: <87a7d33tnk.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> "Search a log of changes for PATTERN. >> >> How PATTERN is interpreted will depend on how each individual >> backend's log search command is implemented, as some can only match >> fixed strings, some have regular expression support, etc." > > I think this should also mention that most backends will interpret > PATTERN as a regular expression. Something like this: > > "Search the log of changes for PATTERN. > > PATTERN is usually interpreted as a regular expression. However, its > exact semantics is up to the backend's log search command; some can > only match fixed strings." So I fixed this accordingly. From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jul 2019 12:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: rpluim@gmail.com, 36644@debbugs.gnu.org, juri@linkov.net Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156405822610891 (code B ref 36644); Thu, 25 Jul 2019 12:38:02 +0000 Received: (at 36644) by debbugs.gnu.org; 25 Jul 2019 12:37:06 +0000 Received: from localhost ([127.0.0.1]:38484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqcza-0002pb-HO for submit@debbugs.gnu.org; Thu, 25 Jul 2019 08:37:06 -0400 Received: from mail-wm1-f45.google.com ([209.85.128.45]:37614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqczY-0002p6-OK for 36644@debbugs.gnu.org; Thu, 25 Jul 2019 08:37:05 -0400 Received: by mail-wm1-f45.google.com with SMTP id f17so44581134wme.2 for <36644@debbugs.gnu.org>; Thu, 25 Jul 2019 05:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YZ545B+KmQPWHzQn8SCct0CSePoPGT3qAlMSga/x1Is=; b=vO4bNS7TrETmW5nKixQBFEww/64bDADi9jXQTjiVr2QGhUE3aPWI3dMGSPHkjjTBZP gbv81/XfdFCB647ceS8W1lj+qs9BHMEG5K7anQs6SDPdd/itiwAVANtMqPFhxG6gQFYh 11NEeNxqOu11Yqdg4DpqWdlJbgiKOrMYm8s674vamyqonYqtwUOCzikcBhxqXb+l2D+4 CQ7GPthRndwEQJ9FHHwrvvW84iKGZN20kuHI66EiPXg2F7r0mOlATXzSNXQdUmH7+pol aWX6RtpZMxvmnx0sVGtuI6A2HFm1jy9spIHRLPoQ3eqVtU1/5HAeYU4d/4b7fNh1ZQbw UcrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YZ545B+KmQPWHzQn8SCct0CSePoPGT3qAlMSga/x1Is=; b=N+ZoqJ5FdKJ9/ItQda9nM87aP6ys5Xk5EoMokW+4WdjXTqGps4IeP7K1ltAHt7p8EC 0HZdQFAVHY4vzlSfDYEva0stpnMzhXxU4TZFU8cgTcSF1OwrcJA7IAXyBq9NDyElDXga BWIeY3N8kiP1PkNhtllbaiVSkDJb2wjgmerNYZUViJvP6UMV5GBZDbQUZQcZRpgXqAwe 4+w4c+8luKkhZNJi7vLZYunkcOxFsQKh4WxgNd2buKVMoxoUaRp4uiHps6usWc0HKFUX sgWV9kcZxoZAJ86D9wAql8WnGPvy+6B/+YM0HMKtZHXTkND76l7egrcKKr9f4zC5HWfO IBXQ== X-Gm-Message-State: APjAAAViSx0inWDyao7x+L4JsWaiOrV1HI+FeZ43L1Lcpu+wRepdTJAW VArbS3Kl3IQ8XIp0Za+RMa0= X-Google-Smtp-Source: APXvYqzZFjrk5GNqQA2hCznXw2qsa7ospZVfj48IaseRXiEcGfzcl+UjcTDCG7QhrXthkgkI4p7lwA== X-Received: by 2002:a7b:ce95:: with SMTP id q21mr81046024wmj.65.1564058218806; Thu, 25 Jul 2019 05:36:58 -0700 (PDT) Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id w14sm38939712wrk.44.2019.07.25.05.36.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2019 05:36:57 -0700 (PDT) References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> <83v9vro1fy.fsf@gnu.org> From: Dmitry Gutov Message-ID: <3126d32c-fbe5-771e-c89f-d3e898e811c8@yandex.ru> Date: Thu, 25 Jul 2019 15:36:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <83v9vro1fy.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 24.07.2019 19:13, Eli Zaretskii wrote: >> Eli, could you weigh in in this discussion? Would you say Robert's >> proposal is acceptable? > > Yes, I think on balance it's acceptable. OK, thank you. > I also see your point: it would be nice to be able to document the > semantics of PATTERN in a backend-independent way. But I think this > is next to impossible in this case, both because of significant > differences in the backend capabilities (e.g., bzr doesn't have the > equivalent of Git's --fixed-strings, AFAICT), and because some backend > allow great flexibility in interpreting PATTERN, under control of > optional switches passed to the backend. The other option is to standardize on basic or extended regexp, and simply give up for backends that can't support that. Git supports all kinds of regexps. 'hg grep' uses Perl-compatible ones (meaning extended regexps are supported, at least). I'm not sure which regular expressions are expected by 'bzr log -match', but if it doesn't support the extended ones, *shrug*. As for the older VCS-es, some probably don't support search at all. And we've lived without such support for decades, so supporting them can't be too important. Anyway, if people disagree, I'm not going to press the issue. > So I think we should treat this as we do in "M-x grep": leave the > semantics of PATTERN backend-dependent, and rely on the user to quote > some characters in it as needed. Admittedly, 'grep' is lower-level > than 'vc-log-search', but at least we have a precedent. The difference is, 'M-x grep' doesn't use different backends. Although I'd be happy to see that capability. > Note that I still think we should use PATTERN, not STRING in the doc > string, because a literal string here is more an exception than a > rule. But we should say that the exact semantics of PATTERN is > backend-dependent, and perhaps describe how a couple of the more > popular backends interpret it. Makes sense. From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jul 2019 12:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov , Eli Zaretskii Cc: Robert Pluim , 36644@debbugs.gnu.org Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156405870911629 (code B ref 36644); Thu, 25 Jul 2019 12:46:01 +0000 Received: (at 36644) by debbugs.gnu.org; 25 Jul 2019 12:45:09 +0000 Received: from localhost ([127.0.0.1]:38498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqd7N-00031V-Ai for submit@debbugs.gnu.org; Thu, 25 Jul 2019 08:45:09 -0400 Received: from mail-wm1-f48.google.com ([209.85.128.48]:40208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqd7L-00030w-Md for 36644@debbugs.gnu.org; Thu, 25 Jul 2019 08:45:08 -0400 Received: by mail-wm1-f48.google.com with SMTP id v19so44652473wmj.5 for <36644@debbugs.gnu.org>; Thu, 25 Jul 2019 05:45:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qSMZUa0/b5bii9CsmvZwy5g7ADesKRoKmFgjG27aoRw=; b=ZKwNaxWfQoYzz1kxj6ZwXviMaSOjjH2rTgVTL4Mq778TA34IpXIBiXv0BC46sM3a6F i1nVDtKjXI04i+jJOXp2yEjOuvhx7KaIoG+hsAcRKV8q3/0CitAwVwnTbmzdeqf+HRi6 hrNb+cAuP/N642TlGksfabujOhb5Pz32U87wypAhl0k3SKQjyBaOkJl7NF9uywRlje3g YQ1CLQNOB21XVyukeExg1FYzzAOY7zAXCK6iO8/t88hL0oFMDTDUG+aCthl/jH9M8uyo q7rq4trsgPyxuMSLXwr5IDOYeFMGw+Udg+aiWr5taKI9BkswNo4xLJsHvcwEoDycZ42T MXLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qSMZUa0/b5bii9CsmvZwy5g7ADesKRoKmFgjG27aoRw=; b=HKrw9xDqsEGQjO2cTP5XjY9MAL43sBYbUl/W0sIyjUQDCFHH1PICg5WkPkfTrwcoCz rlIwvstNVIoFheX0Q8eb9o3A6qnZ6hXtn4ooHCd4IQ9Bff9ShdlqU+n9N3ADjQ2Z6Dis JbpVcSaBxz+My3fRSABvQd4Au/IJnAMhWmM4iv+yjzTCVcv3aCXGD/7Ibf2ZdiYkvL/1 XWUvURwydq0HJZjcJnFhPrqyghP9oygVQzvHg+sw0eRvMDlwg0lHrGXdQdnN9bisI8Sn 60CD3xk9ASIot4ncrcWLTFeBYIpTVvHyMTy5n9ZEnW2p+v8zm0C0qPOpL1FQbSCIwNjw 6W3A== X-Gm-Message-State: APjAAAU9UqBDej9bHyrJM05OWwYC3qWg61H57XJYLI6lGXPCJQ1zZQpP VdVAupbs7zUvKP60kz/bIiiBccJV8WQ= X-Google-Smtp-Source: APXvYqwd5u+9kiuqhv0qrWvN+RXvtUwe33/q8/g/yKA1oyLf3ixN9QYW9pCsOcECjIlSA6litA0DbA== X-Received: by 2002:a1c:e710:: with SMTP id e16mr82059570wmh.38.1564058701488; Thu, 25 Jul 2019 05:45:01 -0700 (PDT) Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id w7sm58019515wrn.11.2019.07.25.05.44.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2019 05:45:00 -0700 (PDT) References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> <83tvbbnz2d.fsf@gnu.org> <87a7d33tnk.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Thu, 25 Jul 2019 15:44:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <87a7d33tnk.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 25.07.2019 2:22, Juri Linkov wrote: > So I fixed this accordingly. Thank you. Two points: - Are you sure we want to use the basic regexps here? Thinking back to my experience when I just started using Emacs, I really was only aware of two kinds: extended regexps (because most programming languages use this syntax nowadays) and Emacs regexps. So I figure extended regexps might be the more user-friendly option. - I wonder how tabs got inside the new function's definition, considering the value of indent-tabs-mode we have in .dir-locals. From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jul 2019 13:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: rpluim@gmail.com, 36644@debbugs.gnu.org, juri@linkov.net Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156406013414050 (code B ref 36644); Thu, 25 Jul 2019 13:09:02 +0000 Received: (at 36644) by debbugs.gnu.org; 25 Jul 2019 13:08:54 +0000 Received: from localhost ([127.0.0.1]:38560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqdUM-0003eX-8D for submit@debbugs.gnu.org; Thu, 25 Jul 2019 09:08:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqdUJ-0003eK-Sq for 36644@debbugs.gnu.org; Thu, 25 Jul 2019 09:08:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43590) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hqdUD-0006IS-Ot; Thu, 25 Jul 2019 09:08:45 -0400 Received: from [176.228.60.248] (port=1305 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hqdUD-0005TP-4K; Thu, 25 Jul 2019 09:08:45 -0400 Date: Thu, 25 Jul 2019 16:08:37 +0300 Message-Id: <83h87antwq.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <3126d32c-fbe5-771e-c89f-d3e898e811c8@yandex.ru> (message from Dmitry Gutov on Thu, 25 Jul 2019 15:36:54 +0300) References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> <83v9vro1fy.fsf@gnu.org> <3126d32c-fbe5-771e-c89f-d3e898e811c8@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: rpluim@gmail.com, 36644@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > Date: Thu, 25 Jul 2019 15:36:54 +0300 > > > I also see your point: it would be nice to be able to document the > > semantics of PATTERN in a backend-independent way. But I think this > > is next to impossible in this case, both because of significant > > differences in the backend capabilities (e.g., bzr doesn't have the > > equivalent of Git's --fixed-strings, AFAICT), and because some backend > > allow great flexibility in interpreting PATTERN, under control of > > optional switches passed to the backend. > > The other option is to standardize on basic or extended regexp, and > simply give up for backends that can't support that. We could simply say "regular expression" and leave the details unspecified. But I think Juri said that fixed strings was the lowest common denominator, which is why I proposed a slightly more vague doc string. Juri, which backends don't support regular expressions? And Robert, why did you insist on saying STRING? > Git supports all kinds of regexps. 'hg grep' uses Perl-compatible ones > (meaning extended regexps are supported, at least). I'm not sure which > regular expressions are expected by 'bzr log -match', but if it doesn't > support the extended ones, *shrug*. I didn't dig deep enough, but since bzr is written in Python, I'd bet it supports whatever Python supports natively. > Anyway, if people disagree, I'm not going to press the issue. If all the backends either support regular expressions or don't support this feature at all, then we had better mentioned regular expressions in the doc string. > > So I think we should treat this as we do in "M-x grep": leave the > > semantics of PATTERN backend-dependent, and rely on the user to quote > > some characters in it as needed. Admittedly, 'grep' is lower-level > > than 'vc-log-search', but at least we have a precedent. > > The difference is, 'M-x grep' doesn't use different backends. It actually leaves that to the user: you can invoke any program you want. E.g., I invoke 'fgrep' this way very frequently. From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jul 2019 13:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: rpluim@gmail.com, 36644@debbugs.gnu.org, juri@linkov.net Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156406082615179 (code B ref 36644); Thu, 25 Jul 2019 13:21:01 +0000 Received: (at 36644) by debbugs.gnu.org; 25 Jul 2019 13:20:26 +0000 Received: from localhost ([127.0.0.1]:38582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqdfW-0003wl-FV for submit@debbugs.gnu.org; Thu, 25 Jul 2019 09:20:26 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:53362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqdfU-0003wY-Gh for 36644@debbugs.gnu.org; Thu, 25 Jul 2019 09:20:25 -0400 Received: by mail-wm1-f52.google.com with SMTP id x15so44991622wmj.3 for <36644@debbugs.gnu.org>; Thu, 25 Jul 2019 06:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YKtYvPcnpkCvvnYoMyo4AFH75NU+raAaKefo6ZccwP0=; b=eelgoeAcn11XEbiqEf64LyyS6IXWKebmQKiQTQ07ZFWddJQGoWm6YKyAruSJyabZU3 rSs+QqGuf0meilqZmQbN2RP5Lb1P4GfURw3pvHAWF9mL/NOBNwca7nzmu5d6fD+fIhcF wiDr5XLOixOEaSExeqxSsgLot8tG5G6eggoPLjRxjZFVnAJhLMzM6NOdIEk1QnW2miI+ Ek6vvzbFPD/X/9BB89x92yyUPkkRB8IuBp5I4dgm/zz01LYo7ZzlPkq9oNHPP4rkWiYF zG4RD007SIZiZkE1Q6On0OWLZhpXtolBJyOPGe14aIQTALLtQxFVhIycnVPixTuVZXf0 jp5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YKtYvPcnpkCvvnYoMyo4AFH75NU+raAaKefo6ZccwP0=; b=gqYe7BPVtc4Wus3Pw0L0qAGIRnYYsYQpfI3ZOjHZoYb4AAAMXpndz1WEvX/Xj5ENV5 n3eMMJY4ozIPa37lPwwQ2SrSTs169mlVAAjSiY9ldIf8v+JxPiX63bbvN8kgtV7+Dl0O jx7edwxCaVf/UjTS4INUUtI114O6x1+87/QvJCTFX6MQXcXf8ALUlYTjuaODrEpo+9cO SRByU7uuA+6BX9HEMdERHXwJLC7xqqn3q+JrMzjl2gYhdkAnWXSZFWxTASPbnAhtPQVv 4SKNcu0twb6h3OyQbcNMWMwONSNtqOwZnEQ/C7WFcXIPNc6qRunSNnWQVNqkZJa3QtJr x/vQ== X-Gm-Message-State: APjAAAXigSTJ72gfwKSz12cnGpbHcGlTjp6s5Hmb1DKmKYUTlG846P+I Qm+3JqkExFYW587Yf5Y/3jM= X-Google-Smtp-Source: APXvYqzlM8KSw9UjAOt83tdcmsc80ZNRxGITKldSp3Uo05Oq0FNWwHXy3VcF1GiheeZ8EhVQQKcOiQ== X-Received: by 2002:a7b:c5c2:: with SMTP id n2mr77904757wmk.92.1564060818617; Thu, 25 Jul 2019 06:20:18 -0700 (PDT) Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id t3sm39480483wmi.6.2019.07.25.06.20.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2019 06:20:17 -0700 (PDT) References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> <83v9vro1fy.fsf@gnu.org> <3126d32c-fbe5-771e-c89f-d3e898e811c8@yandex.ru> <83h87antwq.fsf@gnu.org> From: Dmitry Gutov Message-ID: <4392405a-44c3-802d-cb13-08ad8f4f2593@yandex.ru> Date: Thu, 25 Jul 2019 16:20:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <83h87antwq.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 25.07.2019 16:08, Eli Zaretskii wrote: > It actually leaves that to the user: you can invoke any program you > want. E.g., I invoke 'fgrep' this way very frequently. That's true, but I was thinking more along the lines of using e.g. Ag for 'M-x grep' if the user customizes some variable in a particular way. The "invoke any program" workflow is good and all, but it's much easier to describe in the docstring, so it's not the issue. From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jul 2019 13:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: juri@linkov.net, 36644@debbugs.gnu.org, Dmitry Gutov Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156406183616834 (code B ref 36644); Thu, 25 Jul 2019 13:38:02 +0000 Received: (at 36644) by debbugs.gnu.org; 25 Jul 2019 13:37:16 +0000 Received: from localhost ([127.0.0.1]:38608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqdvn-0004NS-Ig for submit@debbugs.gnu.org; Thu, 25 Jul 2019 09:37:15 -0400 Received: from mail-ed1-f42.google.com ([209.85.208.42]:44763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqdvl-0004NF-NE for 36644@debbugs.gnu.org; Thu, 25 Jul 2019 09:37:14 -0400 Received: by mail-ed1-f42.google.com with SMTP id k8so50239464edr.11 for <36644@debbugs.gnu.org>; Thu, 25 Jul 2019 06:37:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=X5HIQdBGGz6bTCykLJNTK6jARt9iOo1ZNLxWnWaOraw=; b=Mfp2iY711AuN/zea+rxgcWi6m7IvBl+eqtb4bg5n0kDc5LN6ua+Gv/1hWzeqeMRc+E CQNpCNa2WWJuTNPKFsHDzw9oF058G2Ms1yk0KJ6U31hGrQYQaZxu5v8fNYUqQ9bRi2hG +6kRBjUShtmQojSIQBbd9CiUTfrZulPZjlheVPDYdeaxYpcek6CchVYZEoJW+/yq6o/x 1Qz4jTD7JloxEGhJ9BafXqshA0ig1xEUvLfDXZU/+QTK5E+NFWIlvKMIT+/bykn7qwyA e1l4SighO3iKOC2a6Qdm4NWu4784LFPfuhRwgRqCC68gCZrF1O61fH/FxHqCI6R8MNAe SZ6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=X5HIQdBGGz6bTCykLJNTK6jARt9iOo1ZNLxWnWaOraw=; b=tyf1j1w3qL0y3eHF1vK6hlF66Z91PooNZA+nuClXFiXQF90z5lhcLLrSkoZdpiRyq6 qsdWongMp3mh9kIDBPbF3ygVQTvh35FSLquRYH+x6rSbROdnQ6k3JPiNVE6GmhKYE/Wj 0qJAa9ZXTh5UNyOdTRQn0NSM9PuTGxEZskJsCYLKzhnjSDXlo03W/CGPO/PAEh9Z2YQ7 JSbQp+Y1z7hIam/Uh905vDkgOezbgYa1KhGDqVOsHXTUwoM1hLgDTzd8JzCVXwpBTwVz ahgoTQBpb26S96IGoqzyEVi45fyZF3/pRprQ5PZD4dJkWKmOVJdR2Q1DA+w347E05swr m3MQ== X-Gm-Message-State: APjAAAXXRwDOqr6GJI6YR7h7K1T54W/EMurKodGT2kG+z/ZoWq1bqtir wWSasyHWk/fUV+7Quburnvk= X-Google-Smtp-Source: APXvYqym36xE1EwaOuXiqqgdaXVbWyqhC2rmnMO966wF9mZPOkxfdGXBmdSqwUu0+uK9Fv0KN3pugQ== X-Received: by 2002:a17:906:6c16:: with SMTP id j22mr68237663ejr.307.1564061827728; Thu, 25 Jul 2019 06:37:07 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id g21sm13790426edj.50.2019.07.25.06.37.06 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 25 Jul 2019 06:37:06 -0700 (PDT) From: Robert Pluim References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> <83v9vro1fy.fsf@gnu.org> <3126d32c-fbe5-771e-c89f-d3e898e811c8@yandex.ru> <83h87antwq.fsf@gnu.org> Date: Thu, 25 Jul 2019 15:37:05 +0200 In-Reply-To: <83h87antwq.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 25 Jul 2019 16:08:37 +0300") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 25 Jul 2019 16:08:37 +0300, Eli Zaretskii said: >> Cc: rpluim@gmail.com, 36644@debbugs.gnu.org, juri@linkov.net >> From: Dmitry Gutov >> Date: Thu, 25 Jul 2019 15:36:54 +0300 >>=20 >> > I also see your point: it would be nice to be able to document the >> > semantics of PATTERN in a backend-independent way. But I think th= is >> > is next to impossible in this case, both because of significant >> > differences in the backend capabilities (e.g., bzr doesn't have the >> > equivalent of Git's --fixed-strings, AFAICT), and because some bac= kend >> > allow great flexibility in interpreting PATTERN, under control of >> > optional switches passed to the backend. >>=20 >> The other option is to standardize on basic or extended regexp, and= =20 >> simply give up for backends that can't support that. Eli> We could simply say "regular expression" and leave the details Eli> unspecified. But I think Juri said that fixed strings was the low= est Eli> common denominator, which is why I proposed a slightly more vague = doc Eli> string. Juri, which backends don't support regular expressions? = And Eli> Robert, why did you insist on saying STRING? I don=CA=BCt think I did, we can say PATTERN. The thing I=CA=BCm insistent = about is not doing anything to that argument, since its meaning will be understood only by the backend. >> Git supports all kinds of regexps. 'hg grep' uses Perl-compatible on= es=20 >> (meaning extended regexps are supported, at least). I'm not sure whi= ch=20 >> regular expressions are expected by 'bzr log -match', but if it does= n't=20 >> support the extended ones, *shrug*. Eli> I didn't dig deep enough, but since bzr is written in Python, I'd = bet Eli> it supports whatever Python supports natively. >> Anyway, if people disagree, I'm not going to press the issue. Eli> If all the backends either support regular expressions or don't Eli> support this feature at all, then we had better mentioned regular Eli> expressions in the doc string. Yes, although the regular expression types they support may be different. Robert From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jul 2019 19:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Eli Zaretskii , 36644@debbugs.gnu.org, Robert Pluim Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.15640816042863 (code B ref 36644); Thu, 25 Jul 2019 19:07:02 +0000 Received: (at 36644) by debbugs.gnu.org; 25 Jul 2019 19:06:44 +0000 Received: from localhost ([127.0.0.1]:40449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqj4e-0000k7-2P for submit@debbugs.gnu.org; Thu, 25 Jul 2019 15:06:44 -0400 Received: from brown.elm.relay.mailchannels.net ([23.83.212.23]:28934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqj4b-0000jy-OY for 36644@debbugs.gnu.org; Thu, 25 Jul 2019 15:06:42 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id B21D21425AD; Thu, 25 Jul 2019 19:06:40 +0000 (UTC) Received: from pdx1-sub0-mail-a43.g.dreamhost.com (100-96-38-48.trex.outbound.svc.cluster.local [100.96.38.48]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 190AB141E17; Thu, 25 Jul 2019 19:06:40 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a43.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Thu, 25 Jul 2019 19:06:40 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Hysterical-Robust: 3b1cdcd2442a6abe_1564081600542_1715165300 X-MC-Loop-Signature: 1564081600542:886973004 X-MC-Ingress-Time: 1564081600541 Received: from pdx1-sub0-mail-a43.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a43.g.dreamhost.com (Postfix) with ESMTP id 35CC77F5CE; Thu, 25 Jul 2019 12:06:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=6SeSevX0yJsxJHNrIdPTiQZQ8jk=; b= yVQ3YrGFkHgP/Duo69ETLmTu/O2HFpEZ2VOXSmJ65+BVZckITfk97OK9sNYsByLJ 5lUFviQOlSD9iAgFvWyNb1sbtGHjMjPoJPx+ZYYBpj832hb/77p3NX9MXtFBqttL 3hWGEv/YZX4GyqKfAIg5WVaUCli5DYKU6iLUBCPwwAk= Received: from mail.jurta.org (m91-129-103-76.cust.tele2.ee [91.129.103.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a43.g.dreamhost.com (Postfix) with ESMTPSA id 9A4107F122; Thu, 25 Jul 2019 12:06:33 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a43 From: Juri Linkov Organization: LINKOV.NET References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> <83tvbbnz2d.fsf@gnu.org> <87a7d33tnk.fsf@mail.linkov.net> Date: Thu, 25 Jul 2019 21:50:35 +0300 In-Reply-To: (Dmitry Gutov's message of "Thu, 25 Jul 2019 15:44:58 +0300") Message-ID: <87lfwm6jcs.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrkedvgddufedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrdejieenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdefrdejiedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegughhuthhovheshigrnhguvgigrdhruhenucevlhhushhtvghrufhiiigvpedu X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > - Are you sure we want to use the basic regexps here? Thinking back to my > experience when I just started using Emacs, I really was only aware of two > kinds: extended regexps (because most programming languages use this syntax > nowadays) and Emacs regexps. So I figure extended regexps might be the more > user-friendly option. The default version of regular expression syntax is a basic regular expression in both git-log and grep. And as Eli has pointed out to grep as a precedent, most users are accustomed to basic regexps by default while grepping files or git logs. > - I wonder how tabs got inside the new function's definition, > considering the value of indent-tabs-mode we have in .dir-locals. Sorry, I had a mode with a rule to use indent-tabs-mode when the file already uses TABs: (defun indent-tabs-mode-maybe () (if (save-excursion (goto-char (point-min)) ;; If there are at least 10 lines with a leading TAB, use TABs. (re-search-forward "^\t" (+ (point) 100000) t 10)) (set (make-local-variable 'indent-tabs-mode) t))) (add-hook 'find-file-hook 'indent-tabs-mode-maybe) I'll disable it. From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jul 2019 19:07:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Eli Zaretskii , 36644@debbugs.gnu.org, rpluim@gmail.com Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.15640816112888 (code B ref 36644); Thu, 25 Jul 2019 19:07:04 +0000 Received: (at 36644) by debbugs.gnu.org; 25 Jul 2019 19:06:51 +0000 Received: from localhost ([127.0.0.1]:40452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqj4l-0000kV-CZ for submit@debbugs.gnu.org; Thu, 25 Jul 2019 15:06:51 -0400 Received: from anteater.elm.relay.mailchannels.net ([23.83.212.3]:44421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqj4j-0000kN-F2 for 36644@debbugs.gnu.org; Thu, 25 Jul 2019 15:06:49 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 82D2E5E1CC4; Thu, 25 Jul 2019 19:06:48 +0000 (UTC) Received: from pdx1-sub0-mail-a43.g.dreamhost.com (100-96-83-224.trex.outbound.svc.cluster.local [100.96.83.224]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 14EAF5E1E12; Thu, 25 Jul 2019 19:06:48 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a43.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Thu, 25 Jul 2019 19:06:48 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Exultant-Illegal: 122ea05c6ee2d6ce_1564081608364_2066345656 X-MC-Loop-Signature: 1564081608363:1216141653 X-MC-Ingress-Time: 1564081608363 Received: from pdx1-sub0-mail-a43.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a43.g.dreamhost.com (Postfix) with ESMTP id C896C7F122; Thu, 25 Jul 2019 12:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=RvTWPO/84Ixlj6BqxV7t2OWnHCc=; b= FENJ8ZsVaOo/fNZ/pnjbi07joujGVa9WIQL3Z5xv5smxNTbvWOPYSU+P4b4QlUco LXCb92tt2pSHJfBG6+k81+NYsmsBKFM7lFgGmfOKg5/VgjovNwhcWHsVThB6ltJN Ybl3lBzsQB1C3D3Gqg7vOtvQ3g6rwrtzYj+EmqbOpx0= Received: from mail.jurta.org (m91-129-103-76.cust.tele2.ee [91.129.103.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a43.g.dreamhost.com (Postfix) with ESMTPSA id DBCA57FD5C; Thu, 25 Jul 2019 12:06:39 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a43 From: Juri Linkov Organization: LINKOV.NET References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> <83v9vro1fy.fsf@gnu.org> <3126d32c-fbe5-771e-c89f-d3e898e811c8@yandex.ru> Date: Thu, 25 Jul 2019 21:55:27 +0300 In-Reply-To: <3126d32c-fbe5-771e-c89f-d3e898e811c8@yandex.ru> (Dmitry Gutov's message of "Thu, 25 Jul 2019 15:36:54 +0300") Message-ID: <877e866j1d.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrkedvgddufedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrdejieenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdefrdejiedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegughhuthhovheshigrnhguvgigrdhruhenucevlhhushhtvghrufhiiigvpedv X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> So I think we should treat this as we do in "M-x grep": leave the >> semantics of PATTERN backend-dependent, and rely on the user to quote >> some characters in it as needed. Admittedly, 'grep' is lower-level >> than 'vc-log-search', but at least we have a precedent. > > The difference is, 'M-x grep' doesn't use different backends. Although I'd > be happy to see that capability. grep backends can be switched implicitly by installing OS packages like 'agrep', 'pcregrep', 'ripgrep', etc. From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jul 2019 19:07:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: rpluim@gmail.com, 36644@debbugs.gnu.org, Dmitry Gutov Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.15640816192912 (code B ref 36644); Thu, 25 Jul 2019 19:07:05 +0000 Received: (at 36644) by debbugs.gnu.org; 25 Jul 2019 19:06:59 +0000 Received: from localhost ([127.0.0.1]:40455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqj4s-0000ku-MN for submit@debbugs.gnu.org; Thu, 25 Jul 2019 15:06:58 -0400 Received: from aye.elm.relay.mailchannels.net ([23.83.212.6]:27301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqj4q-0000kh-T5 for 36644@debbugs.gnu.org; Thu, 25 Jul 2019 15:06:57 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 12B601424E4; Thu, 25 Jul 2019 19:06:56 +0000 (UTC) Received: from pdx1-sub0-mail-a43.g.dreamhost.com (100-96-92-226.trex.outbound.svc.cluster.local [100.96.92.226]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 997FF142428; Thu, 25 Jul 2019 19:06:55 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a43.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Thu, 25 Jul 2019 19:06:56 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Reaction-Well-Made: 009e43163a413ee4_1564081615918_4078820600 X-MC-Loop-Signature: 1564081615918:4195602006 X-MC-Ingress-Time: 1564081615918 Received: from pdx1-sub0-mail-a43.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a43.g.dreamhost.com (Postfix) with ESMTP id 565D37FD5C; Thu, 25 Jul 2019 12:06:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=rQMUoE3qgc8dG5w51ikX2Wg6HLE=; b= xAVE6Sllfi31vbNKmP4g5t8i7qJ3ku/G9LGYXHGWnetiPvaRscrm+3FimYPbzzu1 lwqfxMoc2TGszFn0EN6ZuUCVpxksdJB9xKVC0JbOF9/FYoHuEHkJl8XDPSHMy7Ef vM7U76bxv428wlUzAj4G69DqhyYSo8lGu6zxXVl56o0= Received: from mail.jurta.org (m91-129-103-76.cust.tele2.ee [91.129.103.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a43.g.dreamhost.com (Postfix) with ESMTPSA id 8A1A77F5CE; Thu, 25 Jul 2019 12:06:46 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a43 From: Juri Linkov Organization: LINKOV.NET References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> <83v9vro1fy.fsf@gnu.org> <3126d32c-fbe5-771e-c89f-d3e898e811c8@yandex.ru> <83h87antwq.fsf@gnu.org> Date: Thu, 25 Jul 2019 22:00:36 +0300 In-Reply-To: <83h87antwq.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 25 Jul 2019 16:08:37 +0300") Message-ID: <87pnly548b.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrkedvgddufedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrdejieenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdefrdejiedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegvlhhiiiesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpeef X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> > I also see your point: it would be nice to be able to document the >> > semantics of PATTERN in a backend-independent way. But I think this >> > is next to impossible in this case, both because of significant >> > differences in the backend capabilities (e.g., bzr doesn't have the >> > equivalent of Git's --fixed-strings, AFAICT), and because some backend >> > allow great flexibility in interpreting PATTERN, under control of >> > optional switches passed to the backend. >> >> The other option is to standardize on basic or extended regexp, and >> simply give up for backends that can't support that. > > We could simply say "regular expression" and leave the details > unspecified. But I think Juri said that fixed strings was the lowest > common denominator, which is why I proposed a slightly more vague doc > string. Juri, which backends don't support regular expressions? The documentation of 'git-log' uses the term 'pattern' for a good reason since it covers all possible values: basic-regexp, extended-regexp, perl-regexp, fixed-strings. From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jul 2019 19:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: Robert Pluim , 36644@debbugs.gnu.org Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.15640823794380 (code B ref 36644); Thu, 25 Jul 2019 19:20:02 +0000 Received: (at 36644) by debbugs.gnu.org; 25 Jul 2019 19:19:39 +0000 Received: from localhost ([127.0.0.1]:40462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqjH8-00018a-Rh for submit@debbugs.gnu.org; Thu, 25 Jul 2019 15:19:39 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:38770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqjH6-00018K-O7 for 36644@debbugs.gnu.org; Thu, 25 Jul 2019 15:19:37 -0400 Received: by mail-wr1-f45.google.com with SMTP id g17so51937519wrr.5 for <36644@debbugs.gnu.org>; Thu, 25 Jul 2019 12:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=l7gWRs0bS00MQOye4Orrht08EHVVFW28rpzBLqoHOa0=; b=LI7NeZyy5GgYNXTMJAbVZBDNZRf1Jx1kGeCkx4LHdu0TZpN9yjnozh4aEYnoY9x0iw S6OtMsicSRKuuFxIKQ0iS/WdsSN6U41E7v2rsotM0u137MuFKygYWPBA1J5FdjFMsCAr WxOx/6Y21N8W9SYN/KuHEst0nFXaP7LxCDMzcM/1R3iI86iJUxI72lFET52WH3Vv5XeP MmDX1NJRN529LpiI8XGsRfZVSSrk32a1e8vTO5kaDUpdd7jbS48qKN+f+PKtrIronhu9 bJK17JwuGnLts6IaNaDpHL9/tXLHzecwON5deATpYoua8TPm2a3Ru+LRuMINFXwjZ/QX 4lWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=l7gWRs0bS00MQOye4Orrht08EHVVFW28rpzBLqoHOa0=; b=Y7U/ybvSv8tsE7HSbw4Cj6dC4TfaIKZ0lwdMmFLu+jJPvh/HYflkVQmA+yG1XqaQjW G4/vn5aaNph9pJ/8bP9iz//kq1WXnZ5+ZKoGvtO6DYGAs8C/yF5pnGJfFkAf+/XqSoT9 CYsv8g40/Bs09Wi+J+34iXKcX9CokiWQ7Vuzi1c/zxGMmHkICUE1iUNGct+fjodYSjkn V8DtFF5qp4aw9M9hkHI7tuEeUASkkesBBFs1OI1fvBqo5Lx6C8tVqEAT8TfhWf8Ne1sm jX3ELlAqxBoiVq0a3ahI3D5Hk0H3VSTHb+3PcXhZ12ZOAd24gYP0/9k8BE6pWCwbTaoP 3gIA== X-Gm-Message-State: APjAAAWRCckD5ySdqAJ+uMDHr9pCYctBiQDvX0e7LW12XT6bPM5qYjut 5zHAFBGCtMdRhYi4LnaXwuQ= X-Google-Smtp-Source: APXvYqwjzm38PM5jRGZGBYdvvZOypdN+Guo5gXvYD5d8FrrZJAhXbrjuesx0aQplTe52SGXyJ8zOIA== X-Received: by 2002:adf:f3c1:: with SMTP id g1mr6963650wrp.203.1564082370824; Thu, 25 Jul 2019 12:19:30 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id c30sm89592185wrb.15.2019.07.25.12.19.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2019 12:19:29 -0700 (PDT) References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> <83tvbbnz2d.fsf@gnu.org> <87a7d33tnk.fsf@mail.linkov.net> <87lfwm6jcs.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <63241d29-efdd-4cfa-7bef-abf7f36c3e5f@yandex.ru> Date: Thu, 25 Jul 2019 22:19:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <87lfwm6jcs.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 25.07.2019 21:50, Juri Linkov wrote: > The default version of regular expression syntax is > a basic regular expression in both git-log and grep. > And as Eli has pointed out to grep as a precedent, > most users are accustomed to basic regexps by default > while grepping files or git logs. There's also the thing that other backends might not support basic regexps. Anyway, up to you. > I'll disable it. Thank you. From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jul 2019 21:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: rpluim@gmail.com, 36644@debbugs.gnu.org Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.15640899997660 (code B ref 36644); Thu, 25 Jul 2019 21:27:01 +0000 Received: (at 36644) by debbugs.gnu.org; 25 Jul 2019 21:26:39 +0000 Received: from localhost ([127.0.0.1]:40528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqlG3-0001zT-1h for submit@debbugs.gnu.org; Thu, 25 Jul 2019 17:26:39 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:53076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqlG1-0001zG-2P for 36644@debbugs.gnu.org; Thu, 25 Jul 2019 17:26:37 -0400 Received: by mail-wm1-f41.google.com with SMTP id s3so46191304wms.2 for <36644@debbugs.gnu.org>; Thu, 25 Jul 2019 14:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+boRFbHOT25iAFNNEYTgoJIT763XszUIv29jXBgjQi4=; b=gN5zv31cDPpKAeDS542OAB59ClJzpaR6ri8h7P+RY3Yh+vQ8NLI4igTcqVSt0GTvMU sGmH4kBTOuN8WY66ynUuYnZ9WBKkXEhrx/BOls6x4t0R5sdu4pkVvrvVBwJvKDHY1bXr ocrIxvvfWmz4w5gbtVCUN/skydf6aFPV5lmODa69aWlYulakmY6ZYSbst2RSKFKtT89x 5ayaXQ2UqSMKaqHneZIwlRp0e/2+ejYDrvzBraVjLaUAVFoKeHAwnaGd0VkSuPoL9YRa By5Ul92yoN2cFLkNTnqBPBbjYhfHw+Vh3G+kFE3ENHE6kspdxRn23xbWamfUOw9qZ3NJ iLow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+boRFbHOT25iAFNNEYTgoJIT763XszUIv29jXBgjQi4=; b=jb94BGa23mu3MpKnvNOOsw6yddlNB9oqLYmXdSeyu6GKrwQNxf2Pis+jcU/v+eAW2K xfoJVB8NbPYnskOiCIx9CNTUQ0HcYkzyvHrod30gdyCB876DmRpb+rO8yDG/kw0h4aHY s7kVbdQ9oj1zFAypiFnoQhg9tVaAWMdZu23vmIda7Sjrkcab/Dc2adjfqvWo5tfmCViY 1Moyra7FZyTG97pbXQa4khJcoyex+r/uO4+O1CMurzm3FeZUgHHs2J7LJg51otMUq8yg gr8zGEBYnWiocgSzZloahY0opENsEHDMyqM8V/gDYhh7p/BOwopkWhI25jySEqoFgJlg dOrQ== X-Gm-Message-State: APjAAAUZtF6z/cE1eqJz6ZWsxFI19+I852bwpEu3odfaLMvvtAIk3Imv DQf2At58tY65kNxEQJxA81Y= X-Google-Smtp-Source: APXvYqzjR/kBr65ISWpHnt3wQLTZqQ/Wg6ISsmairyr+v/drcqQL6e8+oMPBPg7eRPuxmKI/oah10g== X-Received: by 2002:a1c:9e4d:: with SMTP id h74mr85339247wme.9.1564089991195; Thu, 25 Jul 2019 14:26:31 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id b186sm37509821wmb.3.2019.07.25.14.26.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2019 14:26:29 -0700 (PDT) References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> <83v9vro1fy.fsf@gnu.org> <3126d32c-fbe5-771e-c89f-d3e898e811c8@yandex.ru> <877e866j1d.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Fri, 26 Jul 2019 00:26:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <877e866j1d.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 25.07.2019 21:55, Juri Linkov wrote: > grep backends can be switched implicitly by installing OS packages > like 'agrep', 'pcregrep', 'ripgrep', etc. Do you mean to say that such packages make 'grep' a symbolic link, or similar? Because it doesn't look like 'ripgrep' does that. From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jul 2019 21:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: rpluim@gmail.com, 36644@debbugs.gnu.org Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156409166310118 (code B ref 36644); Thu, 25 Jul 2019 21:55:01 +0000 Received: (at 36644) by debbugs.gnu.org; 25 Jul 2019 21:54:23 +0000 Received: from localhost ([127.0.0.1]:40538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqlgs-0002d8-Ll for submit@debbugs.gnu.org; Thu, 25 Jul 2019 17:54:22 -0400 Received: from bongo.elm.relay.mailchannels.net ([23.83.212.21]:5656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqlgp-0002cy-Mw for 36644@debbugs.gnu.org; Thu, 25 Jul 2019 17:54:20 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 7A9396A2A12; Thu, 25 Jul 2019 21:54:18 +0000 (UTC) Received: from pdx1-sub0-mail-a10.g.dreamhost.com (100-96-35-167.trex.outbound.svc.cluster.local [100.96.35.167]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id CB88A6A2ABF; Thu, 25 Jul 2019 21:54:17 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a10.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Thu, 25 Jul 2019 21:54:18 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Absorbed-Keen: 3539402f3282afc5_1564091658104_706278601 X-MC-Loop-Signature: 1564091658104:3475279194 X-MC-Ingress-Time: 1564091658103 Received: from pdx1-sub0-mail-a10.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a10.g.dreamhost.com (Postfix) with ESMTP id 7E45F7EFB8; Thu, 25 Jul 2019 14:54:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=Yg2vDaZHCjVo1/VKFoRHV7/TT6w=; b= uY/8r/b+7X+m1PpTiqSyZ0brvMQ3PCvx1fAFRVQyUA+BDyeNfY0vuRgRvmrHhaHd crs7KWUNrorKAEfhOexsD/Ssla1r82iNqQ2taWmV3Ib5UmqHGDrMiyg90tTA1ecZ uOYAz2NoIQHfu6YkIei8JlBorPb3FpBvxrn5G9CL3kE= Received: from mail.jurta.org (m91-129-103-76.cust.tele2.ee [91.129.103.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a10.g.dreamhost.com (Postfix) with ESMTPSA id 9D0BE82E56; Thu, 25 Jul 2019 14:54:09 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a10 From: Juri Linkov Organization: LINKOV.NET References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> <83v9vro1fy.fsf@gnu.org> <3126d32c-fbe5-771e-c89f-d3e898e811c8@yandex.ru> <877e866j1d.fsf@mail.linkov.net> Date: Fri, 26 Jul 2019 00:38:57 +0300 In-Reply-To: (Dmitry Gutov's message of "Fri, 26 Jul 2019 00:26:27 +0300") Message-ID: <87lfwl23au.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrkeefgddtvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtfedrjeeinecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtfedrjeeipdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> grep backends can be switched implicitly by installing OS packages >> like 'agrep', 'pcregrep', 'ripgrep', etc. > > Do you mean to say that such packages make 'grep' a symbolic link, or > similar? Because it doesn't look like 'ripgrep' does that. Yep, something like this, either by package managers, or by users themselves creating an alias, etc. From unknown Fri Sep 19 23:03:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36644: Git log search Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jul 2019 22:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 36644@debbugs.gnu.org Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.15644402631543 (code B ref 36644); Mon, 29 Jul 2019 22:45:02 +0000 Received: (at 36644) by debbugs.gnu.org; 29 Jul 2019 22:44:23 +0000 Received: from localhost ([127.0.0.1]:49290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsENT-0000On-Ki for submit@debbugs.gnu.org; Mon, 29 Jul 2019 18:44:23 -0400 Received: from brown.elm.relay.mailchannels.net ([23.83.212.23]:55133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsENR-0000OY-H1; Mon, 29 Jul 2019 18:44:22 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 10F8B2C1C1A; Mon, 29 Jul 2019 22:44:20 +0000 (UTC) Received: from pdx1-sub0-mail-a43.g.dreamhost.com (100-96-89-15.trex.outbound.svc.cluster.local [100.96.89.15]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 5FB932C1363; Mon, 29 Jul 2019 22:44:19 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a43.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.5); Mon, 29 Jul 2019 22:44:19 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Turn-Print: 0fdec7d646091df4_1564440259673_1042966119 X-MC-Loop-Signature: 1564440259673:1886793949 X-MC-Ingress-Time: 1564440259673 Received: from pdx1-sub0-mail-a43.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a43.g.dreamhost.com (Postfix) with ESMTP id 28E21830B9; Mon, 29 Jul 2019 15:44:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=6REv+GBoU7MCt5Vv/7Dt5rxnHZg=; b= MKB5TPGyLFIAYhTzzAyOqNyssDW3OKH3RSGYDxYqE/Uqh1+6L0bye4o08E8MyIQ5 gQyin0r4NfIsRJ88eTIp35N+N5EE9fAzO9SWsz4ZvaD2GTwrT37r7HJzLgaEcsdm R8giVWCh9hA0mmfyKzPrghMJxKljmkarBuZCOW51mjY= Received: from mail.jurta.org (m91-129-103-76.cust.tele2.ee [91.129.103.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a43.g.dreamhost.com (Postfix) with ESMTPSA id 7BB218301E; Mon, 29 Jul 2019 15:44:11 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a43 From: Juri Linkov Organization: LINKOV.NET References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> <83tvbbnz2d.fsf@gnu.org> <87a7d33tnk.fsf@mail.linkov.net> Date: Tue, 30 Jul 2019 01:38:20 +0300 In-Reply-To: <87a7d33tnk.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 25 Jul 2019 02:22:07 +0300") Message-ID: <87imrko7ij.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrledvgddufecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrdejieenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdefrdejiedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopeefieeigeegseguvggssghughhsrdhgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 36644 + fixed close 36644 27.0.50 quit > So I fixed this accordingly. I'm closing this now. Regarding a key binding, I'm not sure how often this command will be used. Only depending on this measurement, we could decide later whether this command needs a shorter key sequence or not.