GNU bug report logs - #36641
[PATCH] gnu: python-gst: Fix build failure.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#36641: closed ([PATCH] gnu: python-gst: Fix build failure.)
Date: Sun, 14 Jul 2019 08:12:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 14 Jul 2019 09:11:36 +0100
with message-id <87tvbp3uiv.fsf <at> cbaines.net>
and subject line Re: [bug#36641] [PATCH] gnu: python-gst: Fix build failure.
has caused the debbugs.gnu.org bug report #36641,
regarding [PATCH] gnu: python-gst: Fix build failure.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
36641: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36641
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: python-gst: Fix build failure.
Date: Sat, 13 Jul 2019 23:00:59 +0100

Building python-gst fails with:

  Unbound variable: python-version

Therefore, add python-build-system to #:modules so that it's imported, and
give it a prefix to avoid clashing with the gnu-build-system.

Also, simplify the code by using the site-packages function from the
python-build-system module.

* gnu/packages/gstreamer.scm (python-gst)[arguments]: Rework to fix build
failure.
---
 gnu/packages/gstreamer.scm | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index b0f0b032b3..efb9a6f796 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -431,17 +431,14 @@ compression formats through the use of the libav library.")
                 "0f1d9rvy2qxlymmfzyknnfr5rz1vx69jv17gp7wnamc5s6p7mp2m"))))
     (build-system gnu-build-system)
     (arguments
-     ;; XXX: Factorize python-sitedir with python-build-system.
-     `(#:imported-modules (,@%gnu-build-system-modules
+     `(#:modules ((guix build gnu-build-system)
+                  ((guix build python-build-system) #:prefix python:))
+       #:imported-modules (,@%gnu-build-system-modules
                            (guix build python-build-system))
        #:configure-flags
-       (let* ((python (assoc-ref %build-inputs "python"))
-              (python-version (python-version python))
-              (python-sitedir (string-append
-                               "lib/python" python-version "/site-packages")))
-         (list (string-append
-                "--with-pygi-overrides-dir=" %output "/" python-sitedir
-                "/gi/overrides")))))
+       (list (string-append
+              "--with-pygi-overrides-dir=" %output "/"
+              (python:site-packages %build-inputs %outputs) "/gi/overrides"))))
     (native-inputs
      `(("pkg-config" ,pkg-config)
        ("python" ,python)))
-- 
2.22.0

[Message part 3 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 36641-done <at> debbugs.gnu.org
Subject: Re: [bug#36641] [PATCH] gnu: python-gst: Fix build failure.
Date: Sun, 14 Jul 2019 09:11:36 +0100

[Message part 4 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Christopher Baines <mail <at> cbaines.net> writes:
>
>> Building python-gst fails with:
>>
>>   Unbound variable: python-version
>>
>> Therefore, add python-build-system to #:modules so that it's imported, and
>> give it a prefix to avoid clashing with the gnu-build-system.
>>
>> Also, simplify the code by using the site-packages function from the
>> python-build-system module.
>>
>> * gnu/packages/gstreamer.scm (python-gst)[arguments]: Rework to fix build
>> failure.
>> ---
>>  gnu/packages/gstreamer.scm | 15 ++++++---------
>>  1 file changed, 6 insertions(+), 9 deletions(-)
>>
>> diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
>> index b0f0b032b3..efb9a6f796 100644
>> --- a/gnu/packages/gstreamer.scm
>> +++ b/gnu/packages/gstreamer.scm
>> @@ -431,17 +431,14 @@ compression formats through the use of the libav library.")
>>                  "0f1d9rvy2qxlymmfzyknnfr5rz1vx69jv17gp7wnamc5s6p7mp2m"))))
>>      (build-system gnu-build-system)
>>      (arguments
>> -     ;; XXX: Factorize python-sitedir with python-build-system.
>> -     `(#:imported-modules (,@%gnu-build-system-modules
>> +     `(#:modules ((guix build gnu-build-system)
>> +                  ((guix build python-build-system) #:prefix python:))
>> +       #:imported-modules (,@%gnu-build-system-modules
>>                             (guix build python-build-system))
>>         #:configure-flags
>> -       (let* ((python (assoc-ref %build-inputs "python"))
>> -              (python-version (python-version python))
>> -              (python-sitedir (string-append
>> -                               "lib/python" python-version "/site-packages")))
>> -         (list (string-append
>> -                "--with-pygi-overrides-dir=" %output "/" python-sitedir
>> -                "/gi/overrides")))))
>> +       (list (string-append
>> +              "--with-pygi-overrides-dir=" %output "/"
>
> Nitpicking, but since we're refactoring, could you also change %output
> to the less magical (assoc-ref %outputs "out")?

Actually, turns out that most of the stuff there was
redundant. python:site-packages did more than I was expecting, so I've
removed the use of %output entirely.

>> +              (python:site-packages %build-inputs %outputs) "/gi/overrides"))))
>
> Neat!  LGTM.

Great, I've pushed this now.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.