GNU bug report logs - #36603
[PATCH] Simplify calling convention of describe_map

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Thu, 11 Jul 2019 17:35:02 UTC

Severity: normal

Tags: patch

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

Full log


Message #22 received at 36603-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 36603-done <at> debbugs.gnu.org
Subject: Re: bug#36603: [PATCH] Simplify calling convention of describe_map
Date: Mon, 11 Nov 2019 19:44:29 +0100
Stefan Kangas <stefan <at> marxist.se> writes:

>> Actually, maybe the patch is wrong (i.e., over-simplifying), because it
>> has describe_map start with a fresh seen pointer each time; but the
>> current code passes the same pointer to each describe_map call in a
>> loop.
>
> Thanks for that feedback.  I'll take another look and get back to you.

I think your analysis is correct Noam, and I'm working on a different
approach here, although this project is has been put on the
back-burner for now.  I'll get back into it once I can finish up some
other things first.

Thanks for taking the time to review this.  Closing this bug report.

Best regards,
Stefan Kangas




This bug report was last modified 5 years and 192 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.