GNU bug report logs - #36603
[PATCH] Simplify calling convention of describe_map

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefan <at> marxist.se>
Subject: bug#36603: closed (Re: bug#36603: [PATCH] Simplify calling
 convention of describe_map)
Date: Mon, 11 Nov 2019 18:45:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#36603: [PATCH] Simplify calling convention of describe_map

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 36603 <at> debbugs.gnu.org.

-- 
36603: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36603
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Kangas <stefan <at> marxist.se>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 36603-done <at> debbugs.gnu.org
Subject: Re: bug#36603: [PATCH] Simplify calling convention of describe_map
Date: Mon, 11 Nov 2019 19:44:29 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

>> Actually, maybe the patch is wrong (i.e., over-simplifying), because it
>> has describe_map start with a fresh seen pointer each time; but the
>> current code passes the same pointer to each describe_map call in a
>> loop.
>
> Thanks for that feedback.  I'll take another look and get back to you.

I think your analysis is correct Noam, and I'm working on a different
approach here, although this project is has been put on the
back-burner for now.  I'll get back into it once I can finish up some
other things first.

Thanks for taking the time to review this.  Closing this bug report.

Best regards,
Stefan Kangas

[Message part 3 (message/rfc822, inline)]

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Simplify calling convention of describe_map
Date: Thu, 11 Jul 2019 19:34:22 +0200

This patch simplifies the calling convention of describe_map in
keymap.c.

The immediate motivation is to simplify a set of patches that I'm
preparing for Bug#8951 to rewrite substitute-command-keys in Lisp.
But I think this makes sense in any case.

(I'll send the patch in a separate message once this is assigned a bug
number.)

Thanks,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.