GNU bug report logs - #36603
[PATCH] Simplify calling convention of describe_map

Previous Next

Full log

View this message in rfc822 format

From: Stefan Kangas <stefan <at> marxist.se>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 36603 <at> debbugs.gnu.org
Subject: bug#36603: [PATCH] Simplify calling convention of describe_map
Date: Tue, 20 Aug 2019 18:02:56 +0200

Noam Postavsky <npostavs <at> gmail.com> writes:
>
> Noam Postavsky <npostavs <at> gmail.com> writes:
>
> > Stefan Kangas <stefan <at> marxist.se> writes:
> >
> >> +  Lisp_Object seen_orig = Qnil;
> >> +  Lisp_Object *seen = &seen_orig;
> >
> > Do we really need the seen_orig variable?  It looks like there is no
> > reason for having seen as a pointer at all, but maybe I'm missing
> > something.
>
> Actually, maybe the patch is wrong (i.e., over-simplifying), because it
> has describe_map start with a fresh seen pointer each time; but the
> current code passes the same pointer to each describe_map call in a
> loop.

Thanks for that feedback.  I'll take another look and get back to you.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.