From unknown Sat Jun 21 12:33:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36603: [PATCH] Simplify calling convention of describe_map Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jul 2019 17:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36603 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 36603@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.156286648120378 (code B ref -1); Thu, 11 Jul 2019 17:35:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Jul 2019 17:34:41 +0000 Received: from localhost ([127.0.0.1]:38566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlcxt-0005Ib-5W for submit@debbugs.gnu.org; Thu, 11 Jul 2019 13:34:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:53666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlcxq-0005IR-U7 for submit@debbugs.gnu.org; Thu, 11 Jul 2019 13:34:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35886) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlcxp-0005sY-GY for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 13:34:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlcxn-0006st-JK for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 13:34:36 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:38253) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hlcxn-0006s6-1w for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 13:34:35 -0400 Received: by mail-wm1-f44.google.com with SMTP id s15so6479182wmj.3 for ; Thu, 11 Jul 2019 10:34:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=cpTSKKrqvaKBeplBHt/px0xI2XWCVvVgtsfy/d6cKEM=; b=GM1PMAjOT1BAGxDneQ48DneQaKiw5g0OX+2pfAoCJnBJTyJ/T/O2wm2QY0wEJdZ1Az IzhKuh6W9KlqwMtPR+Wv8TxP2lDVOskuqtldsK6aPl45VQk7ezBTvg3nNAqpuZHkMIqC 0jgr9Zm+2ZRTPGnNhIv7liStma52eHUAG7Do0RBxlNCGm0HzHXfJl/6pfMqD2nCQZSrk 8L00ahtWbQG6KabHtG4GMSIYSVl+OXIfbad0aj9r7oK8fkax85GIgY4Cviu5LKyBdZBp 23jLhCF6cxn5VV8RHsT9hofi6Y0HgHsfWdZAFltwdTL+WKMVwmPCLIkNExNlMGs3eSlY g3Bw== X-Gm-Message-State: APjAAAUHIbAC+w3Ms5y/DdVc9UbthcYUWTd5OdCWDOdS+CpvnR7q3M2L fwq+bZtz8NcnTKclGBX037gNr450/lyLVyAZKUkl1LYA X-Google-Smtp-Source: APXvYqwpwlhMTpeFuBO2VHVa8RtB/OPOJmgRU1Lq84eJFcz+sRPB5aGyPVaLex33FPiGr5SFQi2wlku1w4R3iyNRVhk= X-Received: by 2002:a1c:f515:: with SMTP id t21mr5423718wmh.39.1562866473543; Thu, 11 Jul 2019 10:34:33 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Thu, 11 Jul 2019 19:34:22 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.128.44 X-Spam-Score: -0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) This patch simplifies the calling convention of describe_map in keymap.c. The immediate motivation is to simplify a set of patches that I'm preparing for Bug#8951 to rewrite substitute-command-keys in Lisp. But I think this makes sense in any case. (I'll send the patch in a separate message once this is assigned a bug number.) Thanks, Stefan Kangas From unknown Sat Jun 21 12:33:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36603: [PATCH] Simplify calling convention of describe_map Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jul 2019 17:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36603 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 36603@debbugs.gnu.org Received: via spool by 36603-submit@debbugs.gnu.org id=B36603.156286668520736 (code B ref 36603); Thu, 11 Jul 2019 17:39:02 +0000 Received: (at 36603) by debbugs.gnu.org; 11 Jul 2019 17:38:05 +0000 Received: from localhost ([127.0.0.1]:38571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hld1B-0005OL-20 for submit@debbugs.gnu.org; Thu, 11 Jul 2019 13:38:05 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:44446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hld19-0005No-6p for 36603@debbugs.gnu.org; Thu, 11 Jul 2019 13:38:03 -0400 Received: by mail-wr1-f51.google.com with SMTP id p17so7175597wrf.11 for <36603@debbugs.gnu.org>; Thu, 11 Jul 2019 10:38:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=KBIdrLHYaO368yBiWz7+1oWC1XkjAQ4i8Rn8Bv7sYsU=; b=DidA0IK02eFv1qKYFbagr6FbgUhnm2aOqT7yPabwgpc7dqfCjaWoPk7yqPB3zSSYQc K51ElVgzqg9q81U40KWEHcncL/3+w8yj5WmW0zbiYR0HkzL0frDAuryiaxYb0b9l43l8 RFplD2tDzhd8qPDkPhBJ8SYSw++CkP0JpO6kMsnF5+kJ+KaNh3G/d9UZBmjJIEUiiq8p dfE8pwmArPZeUAygqbc980qhqhvDUzhwOKtyXyjz9hWOE5KmWEYCr8HE/hr/ABXTxI6d 07V1sX0ycMg9FjDUiENPfpm/MrS9tfmtZ/1GIJgJ7dB/FX3IFW9Ay8YW1PKD+o6Pa0lc Z1Hg== X-Gm-Message-State: APjAAAU+/xUI2pMn5M6pWV8V2n1SLzevkUaEI3TCwn34bzTGwhNJEA69 d6yXRJsqSEYh91TyLb/rwGjjDOKi3YxOB40Q8A70V4RP X-Google-Smtp-Source: APXvYqxGhhvPSD9qSoX7MZhBry3QnJ93xYO5lkQolVD69YUIA7zwHQtTDnySyjgBhDXAzQNgvWxvuwE1UZwOHmor/Gk= X-Received: by 2002:adf:f904:: with SMTP id b4mr6548284wrr.291.1562866675884; Thu, 11 Jul 2019 10:37:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Stefan Kangas Date: Thu, 11 Jul 2019 19:37:44 +0200 Message-ID: Content-Type: multipart/mixed; boundary="0000000000000c455d058d6b417d" X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Stefan Kangas writes: > (I'll send the patch in a separate message once this is assigned a bug > number.) Patch attached. Thanks, Stefan Kangas Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: marxist.se] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.51 listed in list.dnswl.org] 1.3 PDS_NO_HELO_DNS High profile HELO but no A record 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.8 (/) --0000000000000c455d058d6b417d Content-Type: text/plain; charset="UTF-8" Stefan Kangas writes: > (I'll send the patch in a separate message once this is assigned a bug > number.) Patch attached. Thanks, Stefan Kangas --0000000000000c455d058d6b417d Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Simplify-calling-convention-of-describe_map-Bug-3660.patch" Content-Disposition: attachment; filename="0001-Simplify-calling-convention-of-describe_map-Bug-3660.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxyyg6sg0 RnJvbSA1ZTM1YTQzN2NiM2Q2NTkxOWI4YTU0N2U0MjFlNjliMzE5MmM3NWY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUaHUsIDExIEp1bCAyMDE5IDE5OjE4OjEyICswMjAwClN1YmplY3Q6IFtQQVRDSF0g U2ltcGxpZnkgY2FsbGluZyBjb252ZW50aW9uIG9mIGRlc2NyaWJlX21hcCAoQnVnIzM2NjAzKQoK KiBzcmMva2V5bWFwLmMgKGRlc2NyaWJlX21hcCk6IFNpbXBsaWZ5IGNhbGxpbmcgY29udmVudGlv bi4KKGRlc2NyaWJlX21hcF90cmVlKTogVXNlIG5ldyBjb252ZW50aW9uLgotLS0KIHNyYy9rZXlt YXAuYyB8IDI0ICsrKysrKysrKysrKy0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDEyIGlu c2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9rZXltYXAuYyBi L3NyYy9rZXltYXAuYwppbmRleCBmYzA0YzU2NWExLi4zOGJlNzNiYWQ4IDEwMDY0NAotLS0gYS9z cmMva2V5bWFwLmMKKysrIGIvc3JjL2tleW1hcC5jCkBAIC04OSwxMSArODksOCBAQAogc3RhdGlj IExpc3BfT2JqZWN0IHN0b3JlX2luX2tleW1hcCAoTGlzcF9PYmplY3QsIExpc3BfT2JqZWN0LCBM aXNwX09iamVjdCk7CiAKIHN0YXRpYyBMaXNwX09iamVjdCBkZWZpbmVfYXNfcHJlZml4IChMaXNw X09iamVjdCwgTGlzcF9PYmplY3QpOwotc3RhdGljIHZvaWQgZGVzY3JpYmVfY29tbWFuZCAoTGlz cF9PYmplY3QsIExpc3BfT2JqZWN0KTsKLXN0YXRpYyB2b2lkIGRlc2NyaWJlX3RyYW5zbGF0aW9u IChMaXNwX09iamVjdCwgTGlzcF9PYmplY3QpOwogc3RhdGljIHZvaWQgZGVzY3JpYmVfbWFwIChM aXNwX09iamVjdCwgTGlzcF9PYmplY3QsCi0gICAgICAgICAgICAgICAgICAgICAgICAgIHZvaWQg KCopIChMaXNwX09iamVjdCwgTGlzcF9PYmplY3QpLAotCQkJICBib29sLCBMaXNwX09iamVjdCwg TGlzcF9PYmplY3QgKiwgYm9vbCwgYm9vbCk7CisJCQkgIGJvb2wsIGJvb2wsIExpc3BfT2JqZWN0 LCBib29sLCBib29sKTsKIHN0YXRpYyB2b2lkIGRlc2NyaWJlX3ZlY3RvciAoTGlzcF9PYmplY3Qs IExpc3BfT2JqZWN0LCBMaXNwX09iamVjdCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg dm9pZCAoKikgKExpc3BfT2JqZWN0LCBMaXNwX09iamVjdCksIGJvb2wsCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIExpc3BfT2JqZWN0LCBMaXNwX09iamVjdCwgYm9vbCwgYm9vbCk7CkBA IC0yOTI0LDcgKzI5MjEsNyBAQCBkZXNjcmliZV9tYXBfdHJlZSAoTGlzcF9PYmplY3Qgc3RhcnRt YXAsIGJvb2wgcGFydGlhbCwgTGlzcF9PYmplY3Qgc2hhZG93LAogCQkgICBMaXNwX09iamVjdCBw cmVmaXgsIGNvbnN0IGNoYXIgKnRpdGxlLCBib29sIG5vbWVudSwKIAkJICAgYm9vbCB0cmFuc2ws IGJvb2wgYWx3YXlzX3RpdGxlLCBib29sIG1lbnRpb25fc2hhZG93KQogewotICBMaXNwX09iamVj dCBtYXBzLCBvcmlnX21hcHMsIHNlZW4sIHN1Yl9zaGFkb3dzOworICBMaXNwX09iamVjdCBtYXBz LCBvcmlnX21hcHMsIHN1Yl9zaGFkb3dzOwogICBib29sIHNvbWV0aGluZyA9IDA7CiAgIGNvbnN0 IGNoYXIgKmtleV9oZWFkaW5nCiAgICAgPSAiXApAQCAtMjkzMiw3ICsyOTI5LDYgQEAgZGVzY3Jp YmVfbWFwX3RyZWUgKExpc3BfT2JqZWN0IHN0YXJ0bWFwLCBib29sIHBhcnRpYWwsIExpc3BfT2Jq ZWN0IHNoYWRvdywKIC0tLSAgICAgICAgICAgICAtLS0tLS0tXG4iOwogCiAgIG9yaWdfbWFwcyA9 IG1hcHMgPSBGYWNjZXNzaWJsZV9rZXltYXBzIChzdGFydG1hcCwgcHJlZml4KTsKLSAgc2VlbiA9 IFFuaWw7CiAgIHN1Yl9zaGFkb3dzID0gUW5pbDsKIAogICBpZiAobm9tZW51KQpAQCAtMjk5OSw5 ICsyOTk1LDggQEAgZGVzY3JpYmVfbWFwX3RyZWUgKExpc3BfT2JqZWN0IHN0YXJ0bWFwLCBib29s IHBhcnRpYWwsIExpc3BfT2JqZWN0IHNoYWRvdywKIAkgICAgc3ViX3NoYWRvd3MgPSBGY29ucyAo WENEUiAoWENBUiAodGFpbCkpLCBzdWJfc2hhZG93cyk7CiAJfQogCi0gICAgICBkZXNjcmliZV9t YXAgKEZjZHIgKGVsdCksIGVsdF9wcmVmaXgsCi0JCSAgICB0cmFuc2wgPyBkZXNjcmliZV90cmFu c2xhdGlvbiA6IGRlc2NyaWJlX2NvbW1hbmQsCi0JCSAgICBwYXJ0aWFsLCBzdWJfc2hhZG93cywg JnNlZW4sIG5vbWVudSwgbWVudGlvbl9zaGFkb3cpOworICAgICAgZGVzY3JpYmVfbWFwIChGY2Ry IChlbHQpLCBlbHRfcHJlZml4LCBwYXJ0aWFsLCB0cmFuc2wsCisJCSAgICBzdWJfc2hhZG93cywg bm9tZW51LCBtZW50aW9uX3NoYWRvdyk7CiAKICAgICBza2lwOiA7CiAgICAgfQpAQCAtMzExMiw5 ICszMTA3LDggQEAgZGVzY3JpYmVfbWFwX2NvbXBhcmUgKGNvbnN0IHZvaWQgKmFhLCBjb25zdCB2 b2lkICpiYikKIAogc3RhdGljIHZvaWQKIGRlc2NyaWJlX21hcCAoTGlzcF9PYmplY3QgbWFwLCBM aXNwX09iamVjdCBwcmVmaXgsCi0JICAgICAgdm9pZCAoKmVsdF9kZXNjcmliZXIpIChMaXNwX09i amVjdCwgTGlzcF9PYmplY3QpLAotCSAgICAgIGJvb2wgcGFydGlhbCwgTGlzcF9PYmplY3Qgc2hh ZG93LAotCSAgICAgIExpc3BfT2JqZWN0ICpzZWVuLCBib29sIG5vbWVudSwgYm9vbCBtZW50aW9u X3NoYWRvdykKKwkgICAgICBib29sIHRyYW5zbCwgYm9vbCBwYXJ0aWFsLCBMaXNwX09iamVjdCBz aGFkb3csCisJICAgICAgYm9vbCBub21lbnUsIGJvb2wgbWVudGlvbl9zaGFkb3cpCiB7CiAgIExp c3BfT2JqZWN0IHRhaWwsIGRlZmluaXRpb24sIGV2ZW50OwogICBMaXNwX09iamVjdCB0ZW07CkBA IC0zMTIyLDYgKzMxMTYsMTIgQEAgZGVzY3JpYmVfbWFwIChMaXNwX09iamVjdCBtYXAsIExpc3Bf T2JqZWN0IHByZWZpeCwKICAgTGlzcF9PYmplY3Qga2x1ZGdlOwogICBib29sIGZpcnN0ID0gMTsK IAorICBMaXNwX09iamVjdCBzZWVuX29yaWcgPSBRbmlsOworICBMaXNwX09iamVjdCAqc2VlbiA9 ICZzZWVuX29yaWc7CisKKyAgdm9pZCAoKmVsdF9kZXNjcmliZXIpIChMaXNwX09iamVjdCwgTGlz cF9PYmplY3QpID0KKyAgICB0cmFuc2wgPyBkZXNjcmliZV90cmFuc2xhdGlvbiA6IGRlc2NyaWJl X2NvbW1hbmQ7CisKICAgLyogVGhlc2UgYWNjdW11bGF0ZSB0aGUgdmFsdWVzIGZyb20gc3BhcnNl IGtleW1hcCBiaW5kaW5ncywKICAgICAgc28gd2UgY2FuIHNvcnQgdGhlbSBhbmQgaGFuZGxlIHRo ZW0gaW4gb3JkZXIuICAqLwogICBwdHJkaWZmX3QgbGVuZ3RoX25lZWRlZCA9IDA7Ci0tIAoyLjEx LjAKCg== --0000000000000c455d058d6b417d-- From unknown Sat Jun 21 12:33:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36603: [PATCH] Simplify calling convention of describe_map Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Aug 2019 15:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36603 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 36603@debbugs.gnu.org Received: via spool by 36603-submit@debbugs.gnu.org id=B36603.1566315179966 (code B ref 36603); Tue, 20 Aug 2019 15:33:02 +0000 Received: (at 36603) by debbugs.gnu.org; 20 Aug 2019 15:32:59 +0000 Received: from localhost ([127.0.0.1]:33597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0683-0000FW-4V for submit@debbugs.gnu.org; Tue, 20 Aug 2019 11:32:59 -0400 Received: from mail-io1-f54.google.com ([209.85.166.54]:33580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0681-0000FK-Co for 36603@debbugs.gnu.org; Tue, 20 Aug 2019 11:32:57 -0400 Received: by mail-io1-f54.google.com with SMTP id z3so13065566iog.0 for <36603@debbugs.gnu.org>; Tue, 20 Aug 2019 08:32:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XYLfR3FKLHf/0K6GpCP7XcddP4NbQRPXv6Tw7liurGg=; b=K5bEBcSe/Ace9AXPGOLkyvnyj2zJ/UlczJHhBnF3bG+3DpwfwoekUGuNZGOgUlZGxD gkyljtEb2e8p/DMF/jd64wfkTm/QbxsJnYWaQrsIuERyH2SDPrQZGE5VHB+IC0PiEEx2 wJQCoGZ16FPVLebhIuPrGIqd4eKyeDUUM8ts1DXuBObrZtrIMClcYjvt8JFpJkWBkXaB YCtonnN3XPy2MfgOujVVbh2LEaCFoScDC0IhWf6IEolKTQ4SS5rPBQteWuyi9MX3kX/g 52OnPc6/TaOZ4pTg9kqUTkF+E+K5FhKV9lbujLZCHAAOz2blHFHKx9KLsYxDvL13sKPB S5lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XYLfR3FKLHf/0K6GpCP7XcddP4NbQRPXv6Tw7liurGg=; b=qVbsMZDYCAQjHvGsLlpmAyDNyOvUWpIoqh0zhdORWif2xJbdNiqlVoIDVrNZry0KrU /1tZF73CvxLpwGJT5k62q++rZb1D+10UM3Hd04CYKD5cD2PjOWzr7TAoed3daCfS69cf 0AevsR4pw1nOUDekc+PKuwwCS8PH2ZR9COCGqXpo0YFtV1mcQU74EiZT5xUi4ZtrAuBr ImtvCh9FVP+8xSSBNWleu42qyacYCkZbekm9N7Io4up4DPSOhvQkg1W4n9zCCQCzKRNy DoQpseKz0IDzPzsZZVJ6cQcfKWV0PXx0QH/OX7qicnVm41J7rI6lBilyJgP1C5d/8UQ/ jwqA== X-Gm-Message-State: APjAAAVEUx4ra9AmLtvcMDk5sXN5iMcGS34E7z6gLe9hW0VBjcpvq+e2 rx2Ki+NU7hzgGUYSKHhzulsdFtIX X-Google-Smtp-Source: APXvYqxV0WjZ0F6YkxWs/kDJA1BP4U0YNxk2CgRJfikyUiChTEdYv5/DFw/6DYrwj5/djKEKsEG2eg== X-Received: by 2002:a6b:4107:: with SMTP id n7mr2418029ioa.12.1566315171505; Tue, 20 Aug 2019 08:32:51 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id q22sm13439541ioj.56.2019.08.20.08.32.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Aug 2019 08:32:50 -0700 (PDT) From: Noam Postavsky References: Date: Tue, 20 Aug 2019 11:32:52 -0400 In-Reply-To: (Stefan Kangas's message of "Thu, 11 Jul 2019 19:37:44 +0200") Message-ID: <85pnkzkg2j.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > + Lisp_Object seen_orig = Qnil; > + Lisp_Object *seen = &seen_orig; Do we really need the seen_orig variable? It looks like there is no reason for having seen as a pointer at all, but maybe I'm missing something. From unknown Sat Jun 21 12:33:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36603: [PATCH] Simplify calling convention of describe_map Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Aug 2019 16:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36603 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 36603@debbugs.gnu.org Received: via spool by 36603-submit@debbugs.gnu.org id=B36603.15663168434060 (code B ref 36603); Tue, 20 Aug 2019 16:01:02 +0000 Received: (at 36603) by debbugs.gnu.org; 20 Aug 2019 16:00:43 +0000 Received: from localhost ([127.0.0.1]:33686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i06Ys-00013Q-Pp for submit@debbugs.gnu.org; Tue, 20 Aug 2019 12:00:43 -0400 Received: from mail-io1-f42.google.com ([209.85.166.42]:37705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i06Yr-00013E-Dx for 36603@debbugs.gnu.org; Tue, 20 Aug 2019 12:00:41 -0400 Received: by mail-io1-f42.google.com with SMTP id q22so13251861iog.4 for <36603@debbugs.gnu.org>; Tue, 20 Aug 2019 09:00:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=yzuZujw2xxZbC6x0WO9HIE2GaqCYYf4sIQVSP/z+Zjo=; b=orE0sr15EQ3BOrCkdNsEqpFuZZ0wrDcLgDpL3T+szXLgMRV1KrYPTTVEgzxS3+F7Ht G/OztXixMZtX+xZexs5LlY6IgSrG0eeyS1V5ppPSoVCq+6FYImfrVLx2tM8px3gjSK0n UBHXAtYGw4E3pYM6LbnYJAL4Yj9oUdPX3KhRdOHo6eI/8WsztH+nLQVtrAcVimOMNAg3 2S48aqFjv1zOqZ86lv2aVKyMFZg1prCGXD7R/aJGAPH6xr+u2hXfM+JopUj9Bd4b8Up1 fqK7DXRTSLP2VgBYluF1fEUAVWOo2PcKuoiE6p/fKM4RE/zrnEI9ZLw5jILjaGOYPtfJ ztvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=yzuZujw2xxZbC6x0WO9HIE2GaqCYYf4sIQVSP/z+Zjo=; b=Z8xczebOhYR90zUl61/agA9WQen1BBQ0msN+NybXrP91FU2alG21ilOSw8EMtGOrnZ sMK+CC8vUubTxrLFrfviJ08Q17UD8EO6XZ8KDIpKFNuJ1draZyjYkbZxbQlz9iD3Mz8n tGBqd1xRaa0NIP3FaPJivm4Z5L0sZyfvNzuJbBFSsvfdVKh7rR/xS2Al3KQ2O7gT4rjN 4WgqbyUxJSk1jofzp3W05TVHa/GyRK4W42CwEY5RfmTZWsorlYcVydUobpnxO9E9LHxh JpBRRiH5PvNVDNizFvqvQqpsdoFzwVlv2DtTImlP3wP43b1QAx2h6GGXoK+a7VNFEXkl raWw== X-Gm-Message-State: APjAAAXH9jpAzwBCHgzBb76GJhjVhvw1YZUDUXTxA7Nj93MOHJOrvAE+ nAy5sfwjWdgT5EZagYM5kN/MQL6P X-Google-Smtp-Source: APXvYqy66rCxSMTUbP2tewgttz+FTzwzXNvAeRTHSZadCv9u6LcgKf7Hi5MjN8JLT4ze7brmchYh9g== X-Received: by 2002:a6b:5b02:: with SMTP id v2mr23118386ioh.293.1566316835557; Tue, 20 Aug 2019 09:00:35 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id j1sm12958710iop.14.2019.08.20.09.00.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Aug 2019 09:00:34 -0700 (PDT) From: Noam Postavsky References: <85pnkzkg2j.fsf@gmail.com> Date: Tue, 20 Aug 2019 12:00:35 -0400 In-Reply-To: <85pnkzkg2j.fsf@gmail.com> (Noam Postavsky's message of "Tue, 20 Aug 2019 11:32:52 -0400") Message-ID: <85mug3kesc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noam Postavsky writes: > Stefan Kangas writes: > >> + Lisp_Object seen_orig = Qnil; >> + Lisp_Object *seen = &seen_orig; > > Do we really need the seen_orig variable? It looks like there is no > reason for having seen as a pointer at all, but maybe I'm missing > something. Actually, maybe the patch is wrong (i.e., over-simplifying), because it has describe_map start with a fresh seen pointer each time; but the current code passes the same pointer to each describe_map call in a loop. From unknown Sat Jun 21 12:33:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36603: [PATCH] Simplify calling convention of describe_map Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Aug 2019 16:04:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36603 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: 36603@debbugs.gnu.org Received: via spool by 36603-submit@debbugs.gnu.org id=B36603.15663169964334 (code B ref 36603); Tue, 20 Aug 2019 16:04:03 +0000 Received: (at 36603) by debbugs.gnu.org; 20 Aug 2019 16:03:16 +0000 Received: from localhost ([127.0.0.1]:33695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i06bL-00017q-VX for submit@debbugs.gnu.org; Tue, 20 Aug 2019 12:03:16 -0400 Received: from mail-pf1-f176.google.com ([209.85.210.176]:39667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i06bK-00017d-59 for 36603@debbugs.gnu.org; Tue, 20 Aug 2019 12:03:14 -0400 Received: by mail-pf1-f176.google.com with SMTP id f17so3645953pfn.6 for <36603@debbugs.gnu.org>; Tue, 20 Aug 2019 09:03:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EKfIR+3awi03wM2U8MjDkf6cZSEcDHBBt7UyeMrBYqI=; b=MuqxiRprxx6qQi2BVUMTNiMnUu60ccDEmhw1H8+9kstQqkxGriK8hLuWxFCm0uGbRE LNFnE2QLSH/GPEK1Q7loQLDQsCeXIrwVj7t3XzFvuY4sjRh/nYwV8cxx6tVf5QvKcnhs DvC0Y8zcEntUj+Q2MX65uhaQFB+uB9NlyBX31rHS9RLACkZd7n9RflA/SbSV6sLIpj1q g/Uf7zHy60N65S0yA3CjkoLU2HmouvOeAnjyUzJzmDGraEbj7qRWRxgskCMOVzlAQ6NH KBIiHd+dnJxUy7Wv78vaDDgShb2KIf8RSEAyGEmz/rURezIRKODPhOUL0nG8aw4M+NsU /mXQ== X-Gm-Message-State: APjAAAUXFvbHTQS+AK0aUJ+FXq6RcqwfgD+tAbkvg4UWyMJmnwhsD3J4 KMF1NTxvmop+kILxZb8/crhnfy/n/zq5SX2gVq0= X-Google-Smtp-Source: APXvYqw7iHSQJ23ryYPaxWtXUnc6ef9RrfVvBsBNo8WDZjH5v9nGJ2ukrY5/JX8YugTtBPyA9jIP6lJFQqmFO5X+9SM= X-Received: by 2002:aa7:9552:: with SMTP id w18mr30238356pfq.107.1566316988323; Tue, 20 Aug 2019 09:03:08 -0700 (PDT) MIME-Version: 1.0 References: <85pnkzkg2j.fsf@gmail.com> <85mug3kesc.fsf@gmail.com> In-Reply-To: <85mug3kesc.fsf@gmail.com> From: Stefan Kangas Date: Tue, 20 Aug 2019 18:02:56 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Noam Postavsky writes: > > Noam Postavsky writes: > > > Stefan Kangas writes: > > > >> + Lisp_Object seen_orig = Qnil; > >> + Lisp_Object *seen = &seen_orig; > > > > Do we really need the seen_orig variable? It looks like there is no > > reason for having seen as a pointer at all, but maybe I'm missing > > something. > > Actually, maybe the patch is wrong (i.e., over-simplifying), because it > has describe_map start with a fresh seen pointer each time; but the > current code passes the same pointer to each describe_map call in a > loop. Thanks for that feedback. I'll take another look and get back to you. Best regards, Stefan Kangas From unknown Sat Jun 21 12:33:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Stefan Kangas Subject: bug#36603: closed (Re: bug#36603: [PATCH] Simplify calling convention of describe_map) Message-ID: References: <877e46p81e.fsf@marxist.se> X-Gnu-PR-Message: they-closed 36603 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 36603@debbugs.gnu.org Date: Mon, 11 Nov 2019 18:45:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1573497902-23146-1" This is a multi-part message in MIME format... ------------=_1573497902-23146-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #36603: [PATCH] Simplify calling convention of describe_map which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 36603@debbugs.gnu.org. --=20 36603: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D36603 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1573497902-23146-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 36603-done) by debbugs.gnu.org; 11 Nov 2019 18:44:39 +0000 Received: from localhost ([127.0.0.1]:55975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iUEg3-00060W-B5 for submit@debbugs.gnu.org; Mon, 11 Nov 2019 13:44:39 -0500 Received: from host.gofardesign.uk ([208.79.239.190]:50955) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iUEg2-00060K-2s for 36603-done@debbugs.gnu.org; Mon, 11 Nov 2019 13:44:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GdzhFOV6nRldTqFH28eWCKRDpfJGT8W0/OkZE38u7y4=; b=f+OADVoq7YJEz7qLFciwYrnKmY HGjCPJa/77UvhBvc6gQkg8VwrbgZIuvxWfoou3NOlxg6Pn5Ms5ToiJonHhFdielFpUEzgEv7XpqTn i535uOWJmPYIFwwoOIqWP2YHq6PB63Uc3IdMSB7nrVwxoe7BaDDIUlNgYLaOKMa+De3Q=; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:53640 helo=localhost) by host.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iUEfv-0003CF-OG; Mon, 11 Nov 2019 12:44:32 -0600 From: Stefan Kangas To: Noam Postavsky Subject: Re: bug#36603: [PATCH] Simplify calling convention of describe_map In-Reply-To: (Stefan Kangas's message of "Tue, 20 Aug 2019 18:02:56 +0200") References: <85pnkzkg2j.fsf@gmail.com> <85mug3kesc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Mon, 11 Nov 2019 19:44:29 +0100 Message-ID: <877e46p81e.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: host.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: host.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 36603-done Cc: 36603-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: >> Actually, maybe the patch is wrong (i.e., over-simplifying), because it >> has describe_map start with a fresh seen pointer each time; but the >> current code passes the same pointer to each describe_map call in a >> loop. > > Thanks for that feedback. I'll take another look and get back to you. I think your analysis is correct Noam, and I'm working on a different approach here, although this project is has been put on the back-burner for now. I'll get back into it once I can finish up some other things first. Thanks for taking the time to review this. Closing this bug report. Best regards, Stefan Kangas ------------=_1573497902-23146-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Jul 2019 17:34:41 +0000 Received: from localhost ([127.0.0.1]:38566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlcxt-0005Ib-5W for submit@debbugs.gnu.org; Thu, 11 Jul 2019 13:34:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:53666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlcxq-0005IR-U7 for submit@debbugs.gnu.org; Thu, 11 Jul 2019 13:34:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35886) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlcxp-0005sY-GY for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 13:34:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlcxn-0006st-JK for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 13:34:36 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:38253) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hlcxn-0006s6-1w for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 13:34:35 -0400 Received: by mail-wm1-f44.google.com with SMTP id s15so6479182wmj.3 for ; Thu, 11 Jul 2019 10:34:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=cpTSKKrqvaKBeplBHt/px0xI2XWCVvVgtsfy/d6cKEM=; b=GM1PMAjOT1BAGxDneQ48DneQaKiw5g0OX+2pfAoCJnBJTyJ/T/O2wm2QY0wEJdZ1Az IzhKuh6W9KlqwMtPR+Wv8TxP2lDVOskuqtldsK6aPl45VQk7ezBTvg3nNAqpuZHkMIqC 0jgr9Zm+2ZRTPGnNhIv7liStma52eHUAG7Do0RBxlNCGm0HzHXfJl/6pfMqD2nCQZSrk 8L00ahtWbQG6KabHtG4GMSIYSVl+OXIfbad0aj9r7oK8fkax85GIgY4Cviu5LKyBdZBp 23jLhCF6cxn5VV8RHsT9hofi6Y0HgHsfWdZAFltwdTL+WKMVwmPCLIkNExNlMGs3eSlY g3Bw== X-Gm-Message-State: APjAAAUHIbAC+w3Ms5y/DdVc9UbthcYUWTd5OdCWDOdS+CpvnR7q3M2L fwq+bZtz8NcnTKclGBX037gNr450/lyLVyAZKUkl1LYA X-Google-Smtp-Source: APXvYqwpwlhMTpeFuBO2VHVa8RtB/OPOJmgRU1Lq84eJFcz+sRPB5aGyPVaLex33FPiGr5SFQi2wlku1w4R3iyNRVhk= X-Received: by 2002:a1c:f515:: with SMTP id t21mr5423718wmh.39.1562866473543; Thu, 11 Jul 2019 10:34:33 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Thu, 11 Jul 2019 19:34:22 +0200 Message-ID: Subject: [PATCH] Simplify calling convention of describe_map To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.128.44 X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) This patch simplifies the calling convention of describe_map in keymap.c. The immediate motivation is to simplify a set of patches that I'm preparing for Bug#8951 to rewrite substitute-command-keys in Lisp. But I think this makes sense in any case. (I'll send the patch in a separate message once this is assigned a bug number.) Thanks, Stefan Kangas ------------=_1573497902-23146-1--