GNU bug report logs - #36602
[PATCH] Add node-build-system.

Previous Next

Package: guix-patches;

Reported by: Julien Lepiller <julien <at> lepiller.eu>

Date: Thu, 11 Jul 2019 16:48:01 UTC

Severity: normal

Tags: patch

Done: Julien Lepiller <julien <at> lepiller.eu>

Bug is archived. No further changes may be made.

Full log

Message #25 received at 36602-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 36602-done <at> debbugs.gnu.org
Subject: Re: [bug#36602] [PATCH] Add node-build-system.
Date: Sun, 14 Jul 2019 12:34:53 +0200

Le Sat, 13 Jul 2019 23:30:12 +0200,
Jelle Licht <jlicht <at> fsfe.org> a écrit :

> Julien Lepiller <julien <at> lepiller.eu> writes:
> 
> > [...]
> > +(define* (install #:key outputs inputs #:allow-other-keys)
> > +  "Install the node module to the output store item. MODULENAME
> > defines +under which name the module will be installed, GLOBAL?
> > determines whether this +is an npm global install."  
> 
> `global?' is no longer , so it could probably be removed from the
> docstring as well. LGTM otherwise :-).

I've reworked that docstring and pushed as
09a1f92f61d1ab11d2cf9f7a0983f4fc9f436f57, thank you!
This bug report was last modified 5 years and 312 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.