GNU bug report logs - #36602
[PATCH] Add node-build-system.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Julien Lepiller <julien <at> lepiller.eu>
Subject: bug#36602: closed (Re: [bug#36602] [PATCH] Add node-build-system.)
Date: Sun, 14 Jul 2019 10:36:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#36602: [PATCH] Add node-build-system.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 36602 <at> debbugs.gnu.org.

-- 
36602: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36602
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Julien Lepiller <julien <at> lepiller.eu>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 36602-done <at> debbugs.gnu.org
Subject: Re: [bug#36602] [PATCH] Add node-build-system.
Date: Sun, 14 Jul 2019 12:34:53 +0200

Le Sat, 13 Jul 2019 23:30:12 +0200,
Jelle Licht <jlicht <at> fsfe.org> a écrit :

> Julien Lepiller <julien <at> lepiller.eu> writes:
> 
> > [...]
> > +(define* (install #:key outputs inputs #:allow-other-keys)
> > +  "Install the node module to the output store item. MODULENAME
> > defines +under which name the module will be installed, GLOBAL?
> > determines whether this +is an npm global install."  
> 
> `global?' is no longer , so it could probably be removed from the
> docstring as well. LGTM otherwise :-).

I've reworked that docstring and pushed as
09a1f92f61d1ab11d2cf9f7a0983f4fc9f436f57, thank you!

[Message part 3 (message/rfc822, inline)]

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add node-build-system.
Date: Thu, 11 Jul 2019 18:46:53 +0200

[Message part 4 (text/plain, inline)]

Hi Guix!

This patch adds a node-build-system. I wasn't sure if it was ready yet,
but I think, since I didn't change it in the last months, that it might
actually be :)

The patch was initially made by Jelle Licht, and I improved a bit on
it. Note that packages built with this build system will embed symlinks
to their dependencies, but not devDependencies (build-only
dependencies) according to the information in the metadata. Each
package is installed in lib/node_modules/package-name and symlinks are
added to lib/node_modules/package-name/node_modules. This allows us to
use only inputs instead of propagated inputs. Executables are installed
in bin according to metadata, and they should work even if called
directly from their store path.

[0001-build-Add-node-build-system.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.