GNU bug report logs - #36598
26.1; (error "‘/tmp/emacs1000’ is not a safe directory because it is a symlink")

Previous Next

Full log

Message #38 received at 36598 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: larsi <at> gnus.org, 36598 <at> debbugs.gnu.org, mah <at> everybody.org,
 phillip.lord <at> russet.org.uk
Subject: Re: bug#36598: 26.1;
 (error "‘/tmp/emacs1000’ is not a safe
 directory because it is a symlink")
Date: Thu, 18 Jul 2019 09:27:20 +0300

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Date: Mon, 15 Jul 2019 09:04:22 -0400
> Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 36598 <at> debbugs.gnu.org,
>  mah <at> everybody.org
> 
> >> Commit b663c837249 (in May) which says "Cosmetic changes" is the one
> >> that introduced this code?
> >>
> >>     (let ((olddir (or (getenv "TMPDIR") "/tmp")))
> >>       (when (and (equal dir (format "%s/emacs" (getenv
> >> "XDG_RUNTIME_DIR")))
> >>                  (file-writable-p olddir))
> >>         (let ((link (format "%s/emacs%d" olddir (user-uid))))
> >>           (unless (file-directory-p link)
> >>             ;; We're using the new location, so try and setup a symlink
> >> from
> >>             ;; the old location, in case we want to use an
> >> old emacsclient.
> >>             ;; FIXME: Check that it's safe to use!
> >>             (make-symbolic-link dir link t)))))
> >>
> >> And instead of making things work with an old emacsclient, it breaks the
> >> Emacs 26 emacsclient?
> >
> > Nearly. I think it breaks emacs-26 not the emacsclient. I haven't check the
> > emacsclient code, but I guess Stefan was
> > aiming for the situation when someone is using (say) emacsclient-26 with
> > emacs-27.
> 
> Indeed (it's Debian/s /usr/bin/emacsclient accessing my hand-built
> Emacs-27 server).
> 
> >> Stefan, was this checked in by mistake?
> 
> Definitely,

If this mistake adversely affects the release branch, please revert
that commit.  We will have RC1 soon.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.