GNU bug report logs - #36597
27.0.50; rehash hash tables eagerly in pdumper

Previous Next

Full log

Message #73 received at 36597-done <at> debbugs.gnu.org (full text, mbox):

From: Pip Cet <pipcet <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: larsi <at> gnus.org, Paul Eggert <eggert <at> cs.ucla.edu>,
 36597-done <at> debbugs.gnu.org
Subject: Re: bug#36597: 27.0.50; rehash hash tables eagerly in pdumper
Date: Tue, 11 Aug 2020 15:59:12 +0000

[Message part 1 (text/plain, inline)]

On Tue, Aug 11, 2020 at 2:52 PM Eli Zaretskii <eliz <at> gnu.org> wrote:
>   pdumper.c: In function 'hash_table_thaw':
>   pdumper.c:2667:30: error: conversion from 'EMACS_INT' {aka 'long long int'} to 'ptrdiff_t' {aka 'int'} may change value [-Werror=conversion]
>    2667 |   h->hash = make_nil_vector (XFIXNUM (h->hash));
>         |                              ^~~~~~~~~~~~~~~~~
>   cc1.exe: some warnings being treated as errors

I suggest going back to Fmake_vector (h->hash, Qnil), as in the
attached patch. It's shorter, and it actually compiles.

[0001-Fix-wide-int-compilation-issue-in-pdumper.c.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.