GNU bug report logs - #36597
27.0.50; rehash hash tables eagerly in pdumper

Previous Next

Package: emacs;

Reported by: Pip Cet <pipcet <at> gmail.com>

Date: Thu, 11 Jul 2019 14:07:02 UTC

Severity: normal

Tags: patch

Found in version 27.0.50

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


Message #41 received at 36597 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Pip Cet <pipcet <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 36597 <at> debbugs.gnu.org
Subject: Re: bug#36597: 27.0.50; rehash hash tables eagerly in pdumper
Date: Sat, 20 Jul 2019 23:32:03 -0700
Pip Cet wrote:
> I don't see anything in there that
> would drastically affect performance or memory footprint.

The drastic change to the memory footprint occurs because the old code 
incorrectly computed the length of the hash table's vectors, and over-allocated 
them in some cases. The over-allocation factor could get worse with each hash 
table resize, following a Fibonacci-like sequence. I think this was a bug I 
introduced in 2011-07-21T17:41:20!eggert <at> cs.ucla.edu.




This bug report was last modified 4 years and 284 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.