GNU bug report logs - #36597
27.0.50; rehash hash tables eagerly in pdumper

Previous Next

Full log

Message #35 received at 36597 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Pip Cet <pipcet <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 36597 <at> debbugs.gnu.org
Subject: Re: bug#36597: 27.0.50; rehash hash tables eagerly in pdumper
Date: Sat, 20 Jul 2019 20:18:04 -0700

[Message part 1 (text/plain, inline)]

Pip Cet wrote:
> I'm currently playing around with redefining hash tables not to have
> internal freelists. That makes the hash table code a lot simpler
> overall, but some of that simplicity would be lost trying to support
> lazy hash table rehashing.

While looking into this I discovered unlikely bugs in Emacs's hash table code 
and GC that can make Emacs dump core, along with some other unlikely hash-table 
bugs that can cause Emacs to report memory exhaustion when there should be 
plenty of memory. I installed the attached patches to fix these problems and to 
refactor to make this code easier to understand (at least for me :-). These 
patches will probably affect performance analysis.

[0001-Fix-hash-table-overallocation-etc.patch (text/x-patch, attachment)]

[0002-Rename-pure-to-purecopy.patch (text/x-patch, attachment)]

[0003-Simplify-maybe_gc-implementation.patch (text/x-patch, attachment)]

[0004-Inhibit-GC-after-inhibit_garbage_collection.patch (text/x-patch, attachment)]

[0005-Simplify-hashfn-cmpfn-calling-convention.patch (text/x-patch, attachment)]

[0006-Fix-crash-if-user-test-munges-hash-table.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.