GNU bug report logs - #36591
26.2; Term's pager seems broken

Previous Next

Full log

Message #11 received at 36591 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: abliss <at> gmail.com, 36591 <at> debbugs.gnu.org
Subject: Re: bug#36591: 26.2; Term's pager seems broken
Date: Tue, 23 Jul 2019 20:40:41 +0300

> From: Noam Postavsky <npostavs <at> gmail.com>
> Date: Tue, 23 Jul 2019 09:53:37 -0400
> Cc: 36591 <at> debbugs.gnu.org
> 
> Adam Bliss <abliss <at> gmail.com> writes:
> 
> > I hope that this is helpful in tracking down the bug.
> 
> Thanks for doing this, it was very helpful.  That commit looks like a
> pretty innocent refactoring, but it actually reverses the sense of the
> EQ (p->filter, Qt) check, because the pset_filter call is moved earlier.
> 
> So the bug can be fixed by adding a single '!'.  Eli, any chance of
> having this fix in the release branch?

I don't think I understand why the change fixes the bug, sorry.  Can
you tell in more detail?  Also, the same function is called in another
place, so what will this change do to that other caller?

And how come we lived with this bug for 3 years without having noticed
it?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.