From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 09 00:22:25 2019 Received: (at submit) by debbugs.gnu.org; 9 Jul 2019 04:22:25 +0000 Received: from localhost ([127.0.0.1]:60186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkhdz-0005tK-Ni for submit@debbugs.gnu.org; Tue, 09 Jul 2019 00:22:24 -0400 Received: from lists.gnu.org ([209.51.188.17]:39872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkhdw-0005tC-TA for submit@debbugs.gnu.org; Tue, 09 Jul 2019 00:22:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37951) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkhdv-00073C-Bk for guix-patches@gnu.org; Tue, 09 Jul 2019 00:22:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkhdt-0001OO-SQ for guix-patches@gnu.org; Tue, 09 Jul 2019 00:22:15 -0400 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]:36750) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hkhdt-0001Ne-B7 for guix-patches@gnu.org; Tue, 09 Jul 2019 00:22:13 -0400 Received: by mail-pf1-x432.google.com with SMTP id r7so8634788pfl.3 for ; Mon, 08 Jul 2019 21:22:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version; bh=RGuSwQnWJuwjIHBYdOkbeNumPNUMVGPqARei/VLtMt0=; b=vC3PttKtsAdzATy1GUkm9+m7uM9Fg+g0lELUGazsrV3u7/6oiLkbt28ovXQFQvVkwK vjO5eiWo0aJ9wlYPu0lq7igVpZx3eZb/hhpn8JwB1sapeJ2f/Nl86uVBOw9oe1WkrOss B5xSjh8G+cnRasZwDqhpzOIcvf0C9mYpgAukLzYEwXO3jem56PW0skCbcIpRXdRsJS0q tJNjVnDrslqkMm91HSojjeh8QZaiEN0gHwAe8rd0eiKVgxhhfa2Q0nLI1b93/qcwIDKc MBCSv/HCOdASuKNjweoQZUSS4kKmc5EPtT2Ncbb6VKLKo9K6zXTl330KY0DBvuiWkq/A VO2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version; bh=RGuSwQnWJuwjIHBYdOkbeNumPNUMVGPqARei/VLtMt0=; b=RSt500SJNUGKpc3sBMeZh5pHk52I9ogE/x7rw8JPk3JL/8dnlIGsVXCWbGQNZql+1q Tv6wiWgQcDn3kBQiVtYeRx5LyLJWKsndOpaPPcuXiaZBLG3E9fY5/ybgqcQ67DMWYeuH 4xtnYnajUOVvhkYQzdfWAA8Dwasa5Dz0wc7t1CDrh8Z83UoDeSF0DocznyD7gEyntFmo x2rYc5tkObSgt4LHbp6LKQqIgmcpa1CVba9+OXCJMnlw0QJTKFV3u1e/UyL+Ii738rdq 0sjKIp6+DPoePLf6LohII4LD6huoIUo+sbGMPNLnpNOCy4czj2LCMMDy/9gvfZcWf4Jm CNYw== X-Gm-Message-State: APjAAAUjEsQ83suhUDbsiNnqorlKyV7oX8OX4sm+BqU2EEM1j3Cx8L5r 3563eqgF2us8/xfRn47clLiPYClA X-Google-Smtp-Source: APXvYqzdFys2eJrfXsJCp6vpeJasjDngPB9n6UO9rbHe/9cgknd5CjxwkcCddmoY5vRYux0NBmeInw== X-Received: by 2002:a17:90a:208d:: with SMTP id f13mr29383659pjg.68.1562646131748; Mon, 08 Jul 2019 21:22:11 -0700 (PDT) Received: from localhost ([199.68.53.171]) by smtp.gmail.com with ESMTPSA id s11sm19483942pgv.13.2019.07.08.21.22.10 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 08 Jul 2019 21:22:10 -0700 (PDT) Date: Mon, 8 Jul 2019 22:22:08 -0600 From: Jesse Gibbons To: guix-patches@gnu.org Subject: [PATCH] add rednotebook Message-ID: <20190708222208.71c9d614@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/TEpKi2cHUMqGuf.NPAIvvbs" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::432 X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --MP_/TEpKi2cHUMqGuf.NPAIvvbs Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Patch is attached. As explained in the comment I had to correct a few problems: 1. Tests always fail, but (in my experience) the final application is stable. 2. rednotebook uses the GI_TYPELIB_PATH and LD_LIBRARY_PATH to find webkitgtk. Furthermore: - The commit message was killed/yanked from commit 072e986ec808690db991e018d6ceee868b5b5f4a and adjusted. - I made gnu/packages/journal.scm to add other similar journal/diary applications. Because I do not like naming sources for the only package defined within, especially when the package is simple, I recommend moving the jrnl package definition to it. Say the word and I will produce the patch to do this. Perhaps we should discuss the idea of organizing packages by function on the devel mailing list? - I also plan to define a package for other journal applications (like those listed between rednotebook and jrnl at and any other recommendations). Knowing I am likely to err, I expect you (whoever reviews this patch) to point out everything you don't like so I can fix it before you approve and commit to savannah ;) Thanks, -Jesse --MP_/TEpKi2cHUMqGuf.NPAIvvbs Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=0001-gnu-Add-rednotebook.patch =46rom 0d93f764f3eefd248966bd3efaddc3e4c09b3cf6 Mon Sep 17 00:00:00 2001 From: Jesse Gibbons Date: Mon, 8 Jul 2019 21:31:31 -0600 Subject: [PATCH] gnu: Add rednotebook * gnu/packages/journal.scm: New file. * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. --- gnu/local.mk | 1 + gnu/packages/journal.scm | 84 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 85 insertions(+) create mode 100644 gnu/packages/journal.scm diff --git a/gnu/local.mk b/gnu/local.mk index 7dcac4f2bc..97f8d76e0a 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -263,6 +263,7 @@ GNU_SYSTEM_MODULES =3D \ %D%/packages/jemalloc.scm \ %D%/packages/jrnl.scm \ %D%/packages/jose.scm \ + %D%/packages/journal.scm \ %D%/packages/julia.scm \ %D%/packages/kawa.scm \ %D%/packages/kde.scm \ diff --git a/gnu/packages/journal.scm b/gnu/packages/journal.scm new file mode 100644 index 0000000000..53fab9e591 --- /dev/null +++ b/gnu/packages/journal.scm @@ -0,0 +1,84 @@ +n;;; GNU Guix --- Functional package management for GNU +;;; Copyright =C2=A9 2019 Jesse Gibbons +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + +(define-module (gnu packages journal) + #:use-module (guix packages) + #:use-module (guix download) + #:use-module (guix build-system python) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (gnu packages python) + #:use-module (gnu packages glib) + #:use-module (gnu packages gtk) + #:use-module (gnu packages webkit) + #:use-module (gnu packages python-xyz)) +(define-public rednotebook + (package + (name "rednotebook") + (version "2.11.1") + (source + (origin + (method url-fetch) + (uri (string-append + "https://github.com/jendrikseipp/rednotebook/archive/v" + version + ".tar.gz")) + (sha256 + (base32 + "15n1ziypfj3lzpvhha7r637zrb259l9yrcsvkic9cg5mndiaivs3")))) + (build-system python-build-system) + (arguments + ;;Tests fail to find the "_" function. + ;;It should be defined in rednotebook/info.py if '_' is not a member = of 'builtins'. + ;;It is either not defined or not exported during the check phase. + ;;The program does not have this problem after it is installed. + ;;TODO: Fix tests. + `(#:tests? #f + #:imported-modules ((guix build glib-or-gtk-build-system) + ,@%python-build-system-modules) + #:modules ((ice-9 match) + (guix build python-build-system) + ((guix build glib-or-gtk-build-system) #:prefix glib-or-= gtk:) + (guix build utils)) + #:phases + (modify-phases %standard-phases + ;;Make sure rednotebook can find the typelibs and webkitgtk share= d libraries. + (add-before 'wrap 'wrap-with-library-paths + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out")) + (gi-typelib-path (getenv "GI_TYPELIB_PATH")) + (webkitgtk-path (string-append + (assoc-ref inputs "webkitgtk") + "/lib"))) + (wrap-program (string-append out "/bin/rednotebook") + `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)) + `("LD_LIBRARY_PATH" ":" prefix (,webkitgtk-path))) + #t)))))) + (inputs + `(("python" ,python-3) + ("python-pygobject" ,python-pygobject) + ("gtk+" ,gtk+) + ("gtksourceview" ,gtksourceview-3) + ("webkitgtk" ,webkitgtk) + ("python-pyyaml" ,python-pyyaml))) + (home-page "https://www.rednotebook.app") + (synopsis "journal") + (description + "RedNotebook is a modern desktop journal. It lets you format, tag and= search +your entries. You can also add pictures, links and customizable templates,= spell +check your notes, and export to plain text, HTML, Latex or PDF.") + (license license:gpl2+))) --=20 2.22.0 --MP_/TEpKi2cHUMqGuf.NPAIvvbs-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 26 05:03:54 2019 Received: (at 36559) by debbugs.gnu.org; 26 Aug 2019 09:03:54 +0000 Received: from localhost ([127.0.0.1]:45589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2Aun-0005B1-Sl for submit@debbugs.gnu.org; Mon, 26 Aug 2019 05:03:54 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:51449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2Auk-0005Al-QS for 36559@debbugs.gnu.org; Mon, 26 Aug 2019 05:03:52 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 22C272000D; Mon, 26 Aug 2019 09:03:46 +0000 (UTC) From: Nicolas Goaziou To: Jesse Gibbons Subject: Re: [bug#36559] [PATCH] add rednotebook References: <20190708222208.71c9d614@gmail.com> Date: Mon, 26 Aug 2019 11:03:45 +0200 In-Reply-To: <20190708222208.71c9d614@gmail.com> (Jesse Gibbons's message of "Mon, 8 Jul 2019 22:22:08 -0600") Message-ID: <871rx8xpqm.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 36559 Cc: 36559@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Jesse Gibbons writes: > Patch is attached. It looks like this patch felt through the cracks. Do not hesitate to send a friendly ping after one or two weeks if no one responds. > As explained in the comment I had to correct a few problems: > 1. Tests always fail, but (in my experience) the final application is > stable. > 2. rednotebook uses the GI_TYPELIB_PATH and LD_LIBRARY_PATH to find > webkitgtk. > - I made gnu/packages/journal.scm to add other similar journal/diary > applications. Because I do not like naming sources for the only > package defined within, especially when the package is simple, I > recommend moving the jrnl package definition to it. Say the word and > I will produce the patch to do this. It sounds good. > Perhaps we should discuss the idea of organizing packages by function > on the devel mailing list? Feel free to start a discussion about it. > - I also plan to define a package for other journal applications > (like those listed between rednotebook and jrnl at > and > any other recommendations). Great! > Knowing I am likely to err, I expect you (whoever reviews this patch) Some comments follow. > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "https://github.com/jendrikseipp/rednotebook/archive/v" > + version > + ".tar.gz")) We do not use Github releases, because they are not stable. You should use `git-fetch` here: (method git-fetch) (uri (git-reference (url "https://github.com/jendrikseipp/rednotebook.git") (commit (string-append "v" version)))) (file-name (git-file-name name version)) with an appropriate hash. > + (sha256 > + (base32 > + "15n1ziypfj3lzpvhha7r637zrb259l9yrcsvkic9cg5mndiaivs3")))) > + (build-system python-build-system) > + (arguments > + ;;Tests fail to find the "_" function. > + ;;It should be defined in rednotebook/info.py if '_' is not a member of 'builtins'. > + ;;It is either not defined or not exported during the check phase. > + ;;The program does not have this problem after it is installed. > + ;;TODO: Fix tests. Nitpick: missing space between ";;" and "Make". > + `(#:tests? #f > + #:imported-modules ((guix build glib-or-gtk-build-system) > + ,@%python-build-system-modules) > + #:modules ((ice-9 match) > + (guix build python-build-system) > + ((guix build glib-or-gtk-build-system) #:prefix glib-or-gtk:) > + (guix build utils)) > + #:phases > + (modify-phases %standard-phases > + ;;Make sure rednotebook can find the typelibs and webkitgtk shared libraries. Ditto. > + (add-before 'wrap 'wrap-with-library-paths > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out")) > + (gi-typelib-path (getenv "GI_TYPELIB_PATH")) > + (webkitgtk-path (string-append > + (assoc-ref inputs "webkitgtk") > + "/lib"))) > + (wrap-program (string-append out "/bin/rednotebook") > + `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)) > + `("LD_LIBRARY_PATH" ":" prefix (,webkitgtk-path))) > + #t)))))) > + (inputs > + `(("python" ,python-3) I don't think this input is necessary. `python-build-system' should provide it already, shouldn't it? > + ("gtk+" ,gtk+) Nitpick: spurious spaces. > + ("gtksourceview" ,gtksourceview-3) > + ("webkitgtk" ,webkitgtk) > + ("python-pyyaml" ,python-pyyaml))) > + (home-page "https://www.rednotebook.app") > + (synopsis "journal") What about this one, borrowed to Debian: "Daily journal with calendar, templates and keyword searching" > + (description > + "RedNotebook is a modern desktop journal. It lets you format, tag and search > +your entries. You can also add pictures, links and customizable templates, spell > +check your notes, and export to plain text, HTML, Latex or PDF.") You need two spaces after full stops in Texinfo. Also, would it make sense to package pyenchant and add it as a dependency? It's not a blocker though. Could you send an updated patch? Thank you! Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 28 22:42:33 2019 Received: (at 36559) by debbugs.gnu.org; 29 Aug 2019 02:42:33 +0000 Received: from localhost ([127.0.0.1]:51460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i3AOK-0005Ic-Qq for submit@debbugs.gnu.org; Wed, 28 Aug 2019 22:42:33 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:38033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i3AOF-0005IC-WD for 36559@debbugs.gnu.org; Wed, 28 Aug 2019 22:42:26 -0400 Received: by mail-pf1-f194.google.com with SMTP id o70so1027845pfg.5 for <36559@debbugs.gnu.org>; Wed, 28 Aug 2019 19:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:in-reply-to:references:date :mime-version; bh=Zihqf8P0hzD6GY9ztYnnc6yfkKUx1+juob7VKoOZ4/s=; b=gnFiix1BCa7lxTYs+VKLELHLnWVle5/ChjRg+tf13+XWzNzTRd3XgVNXavYJ6V5gy3 5VpJnQSlYCSaxAkgMC4FVV2V4e+R3pDe5ChdPiGk6y7FWKyfct5zz4x1dHdwnaDYjrIC kNmCDcz5tfxaUitrhioeOe/fS6QBIrWvZIKAOr+xPfChcMxZVdYd7ZMxglnRqxlpTIkc mF9pSl+XPRS1o4+OM/vVgLGFRwhYP1/46u5svicUO0buhiTCrKGI5NE01EAEdlMrWkCX GURfGmAr38fkGvBTVSQfwIhQURSxLSo5CjO0YIgcgT9pQJFCJFB1wua9sGBiw+s+g9Uy Mr2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:in-reply-to :references:date:mime-version; bh=Zihqf8P0hzD6GY9ztYnnc6yfkKUx1+juob7VKoOZ4/s=; b=GSBKwyS8yJpL4XyNLkUyZT/0HsrUVibcg5u2pigM0+tG+r7ER66a8FQYtmy+lIHoPe B7QqAYT1h5JAFlPUu+vIOSjYbTaX4+a03dogy6MdetkMcOBpnLrtNcH0r3qzEtf5iVqi x0oUUK2REi3rFv/UblU2sf6f9MT3c4b/uvInpGtDBibWkHoWINdRy53kQ3wbNJYl3lZH qU3r/DpQEpaplz83UjvgwGBranjgh0pnk6VXxJqWzFsnmU9186N83LtdDK2w+mGv39sd 6Jx+e6iuRuS6NE7QkwP0NFHyDk3+fDdh6R7WfN3jf5djBjsun01N9BAUvnfsfdLihYY7 UuFw== X-Gm-Message-State: APjAAAV9rNsVo7Tx8w6SsBW/gIBM0R+ZIgOZZtd52uRipSvVq5WhsGil ZsS20ddKaRQeaNZwPPOBwg9v3ctflqk= X-Google-Smtp-Source: APXvYqznWLdThN6MuLDHyoFYunZZrHlG0mlKqLFbLQupVAeqBg+4EiGq3xYMvycEie5lnkxOj5IAMA== X-Received: by 2002:a17:90a:9a90:: with SMTP id e16mr7604864pjp.71.1567046537982; Wed, 28 Aug 2019 19:42:17 -0700 (PDT) Received: from piranhaplant.local ([199.68.53.171]) by smtp.googlemail.com with ESMTPSA id d3sm473184pjz.31.2019.08.28.19.42.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 19:42:16 -0700 (PDT) Message-ID: Subject: Re: [bug#36559] [PATCH] add rednotebook From: Jesse Gibbons To: Nicolas Goaziou In-Reply-To: <871rx8xpqm.fsf@nicolasgoaziou.fr> References: <20190708222208.71c9d614@gmail.com> <871rx8xpqm.fsf@nicolasgoaziou.fr> Content-Type: multipart/mixed; boundary="=-dr62VRhYLJVkAobjopGH" Date: Wed, 28 Aug 2019 20:42:15 -0600 Mime-Version: 1.0 X-Mailer: Evolution 3.28.1 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 36559 Cc: 36559@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-dr62VRhYLJVkAobjopGH Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Mon, 2019-08-26 at 11:03 +0200, Nicolas Goaziou wrote: > Hello, > > Jesse Gibbons writes: > > > Patch is attached. > > It looks like this patch felt through the cracks. Do not hesitate to > send a friendly ping after one or two weeks if no one responds. > > > As explained in the comment I had to correct a few problems: > > 1. Tests always fail, but (in my experience) the final application > > is > > stable. > > 2. rednotebook uses the GI_TYPELIB_PATH and LD_LIBRARY_PATH to > > find > > webkitgtk. > > - I made gnu/packages/journal.scm to add other similar > > journal/diary > > applications. Because I do not like naming sources for the only > > package defined within, especially when the package is simple, I > > recommend moving the jrnl package definition to it. Say the word > > and > > I will produce the patch to do this. > > It sounds good. > > > Perhaps we should discuss the idea of organizing packages by > > function > > on the devel mailing list? > > Feel free to start a discussion about it. I had the discussion soon after I sent the patch. Ricardo convinced me there is at least one good reason for having sources declaring a single package. See https://lists.gnu.org/archive/html/guix-devel/2019-07/msg00240.html for the explanation and the thread. I should have sent a new patch when I decided to rename journal.scm to rednotebook.scm. My mistake. > > > - I also plan to define a package for other journal applications > > (like those listed between rednotebook and jrnl at > > > > and > > any other recommendations). > > Great! > > > Knowing I am likely to err, I expect you (whoever reviews this > > patch) > > Some comments follow. > > > + (source > > + (origin > > + (method url-fetch) > > + (uri (string-append > > + "https://github.com/jendrikseipp/rednotebook/archive/ > > v" > > + version > > + ".tar.gz")) > > We do not use Github releases, because they are not stable. You > should > use `git-fetch` here: > > (method git-fetch) > (uri (git-reference > (url "https://github.com/jendrikseipp/rednotebook.git") > (commit (string-append "v" version)))) > (file-name (git-file-name name version)) > > with an appropriate hash. > fixed. > > + (sha256 > > + (base32 > > + "15n1ziypfj3lzpvhha7r637zrb259l9yrcsvkic9cg5mndiaivs3"))) > > ) > > + (build-system python-build-system) > > + (arguments > > + ;;Tests fail to find the "_" function. > > + ;;It should be defined in rednotebook/info.py if '_' is not a > > member of 'builtins'. > > + ;;It is either not defined or not exported during the check > > phase. > > + ;;The program does not have this problem after it is > > installed. > > + ;;TODO: Fix tests. > > Nitpick: missing space between ";;" and "Make". > > > + `(#:tests? #f > > + #:imported-modules ((guix build glib-or-gtk-build-system) > > + ,@%python-build-system-modules) > > + #:modules ((ice-9 match) > > + (guix build python-build-system) > > + ((guix build glib-or-gtk-build-system) #:prefix > > glib-or-gtk:) > > + (guix build utils)) > > + #:phases > > + (modify-phases %standard-phases > > + ;;Make sure rednotebook can find the typelibs and > > webkitgtk shared libraries. > > Ditto. > both fixed. > > + (add-before 'wrap 'wrap-with-library-paths > > + (lambda* (#:key inputs outputs #:allow-other-keys) > > + (let ((out (assoc-ref outputs "out")) > > + (gi-typelib-path (getenv "GI_TYPELIB_PATH")) > > + (webkitgtk-path (string-append > > + (assoc-ref inputs "webkitgtk") > > + "/lib"))) > > + (wrap-program (string-append out > > "/bin/rednotebook") > > + `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib- > > path)) > > + `("LD_LIBRARY_PATH" ":" prefix (,webkitgtk- > > path))) > > + #t)))))) > > + (inputs > > + `(("python" ,python-3) > > I don't think this input is necessary. `python-build-system' should > provide it already, shouldn't it? fixed > > > + ("gtk+" ,gtk+) > > Nitpick: spurious spaces. fixed > > > > + ("webkitgtk" ,webkitgtk) > > + ("python-pyyaml" ,python-pyyaml))) > > + (home-page "https://www.rednotebook.app") > > + (synopsis "journal") > > What about this one, borrowed to Debian: > > "Daily journal with calendar, templates and keyword searching" good idea > > > + (description > > + "RedNotebook is a modern desktop journal. It lets you format, > > tag and search > > +your entries. You can also add pictures, links and customizable > > templates, spell > > +check your notes, and export to plain text, HTML, Latex or PDF.") > > You need two spaces after full stops in Texinfo. > fixed > Also, would it make sense to package pyenchant and add it as > a dependency? It's not a blocker though. Added this in a TODO. I also made a list of packages that should be added. It looks like there are four python modules in the rednotebook/external directory that should be packaged externally if possible. > > Could you send an updated patch? attached > > Thank you! > > Regards, > -- -Jesse --=-dr62VRhYLJVkAobjopGH Content-Disposition: attachment; filename="0001-gnu-Add-rednotebook.patch" Content-Type: text/x-patch; name="0001-gnu-Add-rednotebook.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBhNTk2N2JkYmQxNTk4NzQzOGYxNThmMWFlOWJhYzJkYzVhNDRjNjQ1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZXNzZSBHaWJib25zIDxqZ2liYm9uczIzNTcrZ3VpeEBnbWFp bC5jb20+CkRhdGU6IFdlZCwgMjggQXVnIDIwMTkgMjA6MzU6MjkgLTA2MDAKU3ViamVjdDogW1BB VENIXSBnbnU6IEFkZCByZWRub3RlYm9vay4KCiAgICAqIGdudS9wYWNrYWdlL3JlZG5vdGVib29r LnNjbTogTmV3IGZpbGUuCiAgICAqIGdudS9sb2NhbC5tazogQWRkIGl0LgogICAgKiBnbnUvcGFj a2FnZXMvcmVkbm90ZWJvb2suc2NtIChyZWRub3RlYm9vayk6IE5ldyB2YXJpYWJsZS4KLS0tCiBn bnUvbG9jYWwubWsgICAgICAgICAgICAgICAgIHwgIDEgKwogZ251L3BhY2thZ2VzL3JlZG5vdGVi b29rLnNjbSB8IDkwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMiBmaWxl cyBjaGFuZ2VkLCA5MSBpbnNlcnRpb25zKCspCiBjcmVhdGUgbW9kZSAxMDA2NDQgZ251L3BhY2th Z2VzL3JlZG5vdGVib29rLnNjbQoKZGlmZiAtLWdpdCBhL2dudS9sb2NhbC5tayBiL2dudS9sb2Nh bC5tawppbmRleCA3OTc5MzZkMmZkLi4yYzAyYjg1MTBhIDEwMDY0NAotLS0gYS9nbnUvbG9jYWwu bWsKKysrIGIvZ251L2xvY2FsLm1rCkBAIC00MTMsNiArNDEzLDcgQEAgR05VX1NZU1RFTV9NT0RV TEVTID0JCQkJXAogICAlRCUvcGFja2FnZXMvcmRmLnNjbQkJCQlcCiAgICVEJS9wYWNrYWdlcy9y ZTJjLnNjbQkJCQlcCiAgICVEJS9wYWNrYWdlcy9yZWFkbGluZS5zY20JCQlcCisgICVEJS9wYWNr YWdlcy9yZWRub3RlYm9vay5zY20JCQlcCiAgICVEJS9wYWNrYWdlcy9yZWdleC5zY20JCQkJXAog ICAlRCUvcGFja2FnZXMvcm9ib3RpY3Muc2NtCQkJXAogICAlRCUvcGFja2FnZXMvcnJkdG9vbC5z Y20JCQlcCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvcmVkbm90ZWJvb2suc2NtIGIvZ251L3Bh Y2thZ2VzL3JlZG5vdGVib29rLnNjbQpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwLi42MGEyMmE3ZjFmCi0tLSAvZGV2L251bGwKKysrIGIvZ251L3BhY2thZ2VzL3JlZG5vdGVi b29rLnNjbQpAQCAtMCwwICsxLDkwIEBACis7OzsgR05VIEd1aXggLS0tIEZ1bmN0aW9uYWwgcGFj a2FnZSBtYW5hZ2VtZW50IGZvciBHTlUKKzs7OyBDb3B5cmlnaHQgwqkgMjAxOSBKZXNzZSBHaWJi b25zIDxqZ2liYm9uczIzNTcrZ3VpeEBnbWFpbC5jb20+Cis7OzsKKzs7OyBUaGlzIGZpbGUgaXMg cGFydCBvZiBHTlUgR3VpeC4KKzs7OworOzs7IEdOVSBHdWl4IGlzIGZyZWUgc29mdHdhcmU7IHlv dSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkgaXQKKzs7OyB1bmRlciB0aGUgdGVy bXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQorOzs7 IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhlIExp Y2Vuc2UsIG9yIChhdAorOzs7IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KKzs7Owor Ozs7IEdOVSBHdWl4IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1 c2VmdWwsIGJ1dAorOzs7IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGlt cGxpZWQgd2FycmFudHkgb2YKKzs7OyBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQ QVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlCis7OzsgR05VIEdlbmVyYWwgUHVibGljIExpY2Vu c2UgZm9yIG1vcmUgZGV0YWlscy4KKzs7OworOzs7IFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBh IGNvcHkgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCis7OzsgYWxvbmcgd2l0aCBH TlUgR3VpeC4gIElmIG5vdCwgc2VlIDxodHRwOi8vd3d3LmdudS5vcmcvbGljZW5zZXMvPi4KKwor KGRlZmluZS1tb2R1bGUgKGdudSBwYWNrYWdlcyByZWRub3RlYm9vaykKKyAgIzp1c2UtbW9kdWxl IChndWl4IHBhY2thZ2VzKQorICAjOnVzZS1tb2R1bGUgKGd1aXggZ2l0LWRvd25sb2FkKQorICAj OnVzZS1tb2R1bGUgKGd1aXggYnVpbGQtc3lzdGVtIHB5dGhvbikKKyAgIzp1c2UtbW9kdWxlICgo Z3VpeCBsaWNlbnNlcykgIzpwcmVmaXggbGljZW5zZTopCisgICM6dXNlLW1vZHVsZSAoZ251IHBh Y2thZ2VzIHB5dGhvbikKKyAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgZ2xpYikKKyAgIzp1 c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgZ3RrKQorICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdl cyB3ZWJraXQpCisgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHB5dGhvbi14eXopKQorKGRl ZmluZS1wdWJsaWMgcmVkbm90ZWJvb2sKKyAgKHBhY2thZ2UKKyAgICAobmFtZSAicmVkbm90ZWJv b2siKQorICAgICh2ZXJzaW9uICIyLjExLjEiKQorICAgIChzb3VyY2UKKyAgICAgKG9yaWdpbgor ICAgICAgIChtZXRob2QgZ2l0LWZldGNoKQorICAgICAgICh1cmkgKGdpdC1yZWZlcmVuY2UKKyAg ICAgICAgICAgICAodXJsICJodHRwczovL2dpdGh1Yi5jb20vamVuZHJpa3NlaXBwL3JlZG5vdGVi b29rLmdpdCIpCisgICAgICAgICAgICAgKGNvbW1pdCAoc3RyaW5nLWFwcGVuZCAidiIgdmVyc2lv bikpKSkKKyAgICAgICAoZmlsZS1uYW1lIChnaXQtZmlsZS1uYW1lIG5hbWUgdmVyc2lvbikpCisg ICAgICAgKHNoYTI1NgorICAgICAgICAoYmFzZTMyICIwNGM3YTB3Z21kbDg4djkzODZ5MTA1MmMz OGFqYmtyeWl3aHFwczVseDM0ZDRnN3I2aG0xIikpKSkKKyAgICAoYnVpbGQtc3lzdGVtIHB5dGhv bi1idWlsZC1zeXN0ZW0pCisgICAgKGFyZ3VtZW50cworICAgICA7OyBUZXN0cyBmYWlsIHRvIGZp bmQgdGhlICJfIiBmdW5jdGlvbi4KKyAgICAgOzsgSXQgc2hvdWxkIGJlIGRlZmluZWQgaW4gcmVk bm90ZWJvb2svaW5mby5weSBpZiAnXycgaXMgbm90IGEgbWVtYmVyIG9mCisgICAgIDs7ICdidWls dGlucycuIEl0IGlzIGVpdGhlciBub3QgZGVmaW5lZCBvciBub3QgZXhwb3J0ZWQgZHVyaW5nIHRo ZSBjaGVjaworICAgICA7OyBwaGFzZS4gVGhlIHByb2dyYW0gZG9lcyBub3QgaGF2ZSB0aGlzIHBy b2JsZW0gYWZ0ZXIgaXQgaXMgaW5zdGFsbGVkLgorICAgICA7OyBUT0RPOiBGaXggdGVzdHMuCisg ICAgIGAoIzp0ZXN0cz8gI2YKKyAgICAgICAjOmltcG9ydGVkLW1vZHVsZXMgKChndWl4IGJ1aWxk IGdsaWItb3ItZ3RrLWJ1aWxkLXN5c3RlbSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICxA JXB5dGhvbi1idWlsZC1zeXN0ZW0tbW9kdWxlcykKKyAgICAgICAjOm1vZHVsZXMgKChpY2UtOSBt YXRjaCkKKyAgICAgICAgICAgICAgICAgIChndWl4IGJ1aWxkIHB5dGhvbi1idWlsZC1zeXN0ZW0p CisgICAgICAgICAgICAgICAgICAoKGd1aXggYnVpbGQgZ2xpYi1vci1ndGstYnVpbGQtc3lzdGVt KSAjOnByZWZpeCBnbGliLW9yLWd0azopCisgICAgICAgICAgICAgICAgICAoZ3VpeCBidWlsZCB1 dGlscykpCisgICAgICAgIzpwaGFzZXMKKyAgICAgICAobW9kaWZ5LXBoYXNlcyAlc3RhbmRhcmQt cGhhc2VzCisgICAgICAgICA7OyBNYWtlIHN1cmUgcmVkbm90ZWJvb2sgY2FuIGZpbmQgdGhlIHR5 cGVsaWJzIGFuZCB3ZWJraXRndGsgc2hhcmVkCisgICAgICAgICA7OyBsaWJyYXJpZXMuCisgICAg ICAgICAoYWRkLWJlZm9yZSAnd3JhcCAnd3JhcC13aXRoLWxpYnJhcnktcGF0aHMKKyAgICAgICAg ICAgKGxhbWJkYSogKCM6a2V5IGlucHV0cyBvdXRwdXRzICM6YWxsb3ctb3RoZXIta2V5cykKKyAg ICAgICAgICAgICAobGV0ICgob3V0IChhc3NvYy1yZWYgb3V0cHV0cyAib3V0IikpCisgICAgICAg ICAgICAgICAgICAgKGdpLXR5cGVsaWItcGF0aCAoZ2V0ZW52ICJHSV9UWVBFTElCX1BBVEgiKSkK KyAgICAgICAgICAgICAgICAgICAod2Via2l0Z3RrLXBhdGggKHN0cmluZy1hcHBlbmQKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChhc3NvYy1yZWYgaW5wdXRzICJ3ZWJraXRn dGsiKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIi9saWIiKSkpCisgICAg ICAgICAgICAgICAod3JhcC1wcm9ncmFtIChzdHJpbmctYXBwZW5kIG91dCAiL2Jpbi9yZWRub3Rl Ym9vayIpCisgICAgICAgICAgICAgICAgIGAoIkdJX1RZUEVMSUJfUEFUSCIgIjoiIHByZWZpeCAo LGdpLXR5cGVsaWItcGF0aCkpCisgICAgICAgICAgICAgICAgIGAoIkxEX0xJQlJBUllfUEFUSCIg IjoiIHByZWZpeCAoLHdlYmtpdGd0ay1wYXRoKSkpCisgICAgICAgICAgICAgICAjdCkpKSkpKQor ICAgIChpbnB1dHMKKyAgICAgYCgoImd0aysiICxndGsrKQorICAgICAgICgiZ3Rrc291cmNldmll dyIgLGd0a3NvdXJjZXZpZXctMykKKyAgICAgICAoInB5dGhvbi1weXlhbWwiICxweXRob24tcHl5 YW1sKQorICAgICAgICgicHl0aG9uLXB5Z29iamVjdCIgLHB5dGhvbi1weWdvYmplY3QpCisgICAg ICAgKCJ3ZWJraXRndGsiICx3ZWJraXRndGspKSkKKyAgICA7OyBUT0RPOiBwYWNrYWdlIHRoZSBm b2xsb3dpbmcgIGZvciBweXRob24zIChpZiBwb3NzaWJsZSksIGFkZCB0aGVtIGFzCisgICAgOzsg ZGVwZW5kZW5jaWVzLCBhbmQgcmVtb3ZlIHRoZW0gZnJvbSByZWRub3RlYm9vayBzb3VyY2U6Cisg ICAgOzsgcHlndGtzcGVsbGNoZWNrLCBlbGliLmludGwsIG1zZ2ZtdCwgdHh0MnRhZ3MKKyAgICA7 OyBUT0RPOiBwYWNrYWdlIGFuZCBhZGQgcHllbmNoYW50IGZvciBweXRob24zIGFuZCBhZGQgaXQg YXMgYSBkZXBlbmRlbmN5LgorICAgIChob21lLXBhZ2UgImh0dHBzOi8vd3d3LnJlZG5vdGVib29r LmFwcCIpCisgICAgKHN5bm9wc2lzICJEYWlseSBqb3VybmFsIHdpdGggY2FsZW5kYXIsIHRlbXBs YXRlcyBhbmQga2V5d29yZCBzZWFyY2hpbmciKQorICAgIChkZXNjcmlwdGlvbgorICAgICAiUmVk Tm90ZWJvb2sgaXMgYSBtb2Rlcm4gZGVza3RvcCBqb3VybmFsLiAgSXQgbGV0cyB5b3UgZm9ybWF0 LCB0YWcgYW5kCitzZWFyY2ggeW91ciBlbnRyaWVzLiAgWW91IGNhbiBhbHNvIGFkZCBwaWN0dXJl cywgbGlua3MgYW5kIGN1c3RvbWl6YWJsZQordGVtcGxhdGVzLCBzcGVsbCBjaGVjayB5b3VyIG5v dGVzLCBhbmQgZXhwb3J0IHRvIHBsYWluIHRleHQsIEhUTUwsIExhdGV4IG9yCitQREYuIikKKyAg ICAobGljZW5zZSAobGlzdCBsaWNlbnNlOmdwbDIrICAgICA7IHJlZG5vdGVib29rLCB0eHQydGFn cworICAgICAgICAgICAgICAgICAgIGxpY2Vuc2U6bGdwbDMrICAgIDsgZWxpYi5pbnRsCisgICAg ICAgICAgICAgICAgICAgbGljZW5zZTpncGwzKykpKSkgOyBweWd0a3NwZWxsY2hlY2sKLS0gCjIu MjMuMAoK --=-dr62VRhYLJVkAobjopGH-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 29 13:18:24 2019 Received: (at 36559-done) by debbugs.gnu.org; 29 Aug 2019 17:18:24 +0000 Received: from localhost ([127.0.0.1]:52872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i3O40-0006wp-0w for submit@debbugs.gnu.org; Thu, 29 Aug 2019 13:18:24 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:54165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i3O3x-0006wc-Tt for 36559-done@debbugs.gnu.org; Thu, 29 Aug 2019 13:18:22 -0400 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay12.mail.gandi.net (Postfix) with ESMTPSA id B4454200007; Thu, 29 Aug 2019 17:18:19 +0000 (UTC) From: Nicolas Goaziou To: Jesse Gibbons Subject: Re: [bug#36559] [PATCH] add rednotebook References: <20190708222208.71c9d614@gmail.com> <871rx8xpqm.fsf@nicolasgoaziou.fr> Date: Thu, 29 Aug 2019 19:18:18 +0200 In-Reply-To: (Jesse Gibbons's message of "Wed, 28 Aug 2019 20:42:15 -0600") Message-ID: <874l1zx545.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 36559-done Cc: 36559-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Jesse Gibbons writes: > From a5967bdbd15987438f158f1ae9bac2dc5a44c645 Mon Sep 17 00:00:00 2001 > From: Jesse Gibbons > Date: Wed, 28 Aug 2019 20:35:29 -0600 > Subject: [PATCH] gnu: Add rednotebook. > > * gnu/package/rednotebook.scm: New file. > * gnu/local.mk: Add it. > * gnu/packages/rednotebook.scm (rednotebook): New variable. Applied. Thank you! Regards, -- Nicolas Goaziou From unknown Sat Aug 16 12:45:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 Sep 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator