GNU bug report logs - #36555
[PATCH 0/2] Refactor out common behavior for system reconfiguration.

Previous Next

Full log

View this message in rfc822 format

From: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 36555 <at> debbugs.gnu.org
Subject: [bug#36555] [PATCH v5 2/3] guix system: Reimplement 'reconfigure'.
Date: Tue, 23 Jul 2019 20:06:44 -0400

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Note that on current master this should be:
>
>   (built-derivations (lowered-gexp-inputs lowered))
>

Ah, thank you. My feature branch is out of date again.

> My last grief for this patch series is exception handling above: it’s
> not good to report “failed to install bootloader” whatever the problem
> is. :-)
>
> Could we somehow move exception handling at the call sites? I know
> that monadic style makes it harder.

Whoops! It would definitely not be good to report "failed to install
bootloader" for unrelated issues. I'll look into moving the handling
into the call sites. Perhaps I can make a more general version of
'with-shepherd-error-handling'?

> The rest looks great, and congrats for being the first one to
> reconfigure with it! :-)

Heh, thanks! It was pretty exhilarating watching the output go by. I
didn't even do a system back-up beforehand because I was that confident
in it.

Regards,
Jakob

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.