From unknown Tue Jun 17 01:43:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36544: 'set-paths' should exclude 'source' from consideration Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 07 Jul 2019 23:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36544 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 36544@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.156254200519820 (code B ref -1); Sun, 07 Jul 2019 23:27:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Jul 2019 23:26:45 +0000 Received: from localhost ([127.0.0.1]:57556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkGYP-00059b-Ez for submit@debbugs.gnu.org; Sun, 07 Jul 2019 19:26:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:41711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkGYN-00059U-TT for submit@debbugs.gnu.org; Sun, 07 Jul 2019 19:26:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37834) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkGYM-0006oO-Oa for bug-guix@gnu.org; Sun, 07 Jul 2019 19:26:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkGYL-0001eb-L4 for bug-guix@gnu.org; Sun, 07 Jul 2019 19:26:42 -0400 Received: from world.peace.net ([64.112.178.59]:53214) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hkGYL-0001e6-Hm for bug-guix@gnu.org; Sun, 07 Jul 2019 19:26:41 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkGYJ-0006Oo-PP; Sun, 07 Jul 2019 19:26:39 -0400 From: Mark H Weaver Date: Sun, 07 Jul 2019 19:26:12 -0400 Message-ID: <871rz1a0kr.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 64.112.178.59 X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The 'set-paths' phase in (guix build gnu-build-system) currently includes 'source' in the set of candidates for inclusion in the search-path variables. First of all, I think it's undesirable to include subdirectories of the source directory in these search paths. However, if you think it's desirable, there's another problem: it's fragile. It depends on: (1) whether the source is a tarball or an unpacked checkout, and (2) whether the subdirectories specified in the search-paths (e.g. 'include') are within the top source directory. Currently, if you change the 'source' field of a package from a tarball to an (unpacked) VCS checkout, there *might* be additional components added to the environment variables, depending on the source tree layout. For example, this causes our 'linux-libre' package to fail to build if you substitute its 'source' field for a git checkout, as Chris Webber discovered here: https://lists.gnu.org/archive/html/help-guix/2019-07/msg00058.html https://lists.gnu.org/archive/html/help-guix/2019-07/msg00062.html Also, if any package depends on the current behavior, it will break if its 'source' is changed from a VCS checkout to a release tarball. To avoid this unexpected sensitivity on the source origin method, I suggest that we explicitly exclude 'source' from consideration within the 'set-paths' phase. What do you think? Also, does anyone know of other procedures that do something similiar? Thanks, Mark From unknown Tue Jun 17 01:43:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36544: 'set-paths' should exclude 'source' from consideration In-Reply-To: <871rz1a0kr.fsf@netris.org> Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 11 Jul 2019 21:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36544 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mark H Weaver Cc: 36544@debbugs.gnu.org Received: via spool by 36544-submit@debbugs.gnu.org id=B36544.1562880305695 (code B ref 36544); Thu, 11 Jul 2019 21:26:02 +0000 Received: (at 36544) by debbugs.gnu.org; 11 Jul 2019 21:25:05 +0000 Received: from localhost ([127.0.0.1]:38926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlgYr-0000B9-2N for submit@debbugs.gnu.org; Thu, 11 Jul 2019 17:25:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlgYo-0000AZ-VA for 36544@debbugs.gnu.org; Thu, 11 Jul 2019 17:25:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hlgYj-0004aU-K7; Thu, 11 Jul 2019 17:24:57 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=51590 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hlgYj-0004WJ-3a; Thu, 11 Jul 2019 17:24:57 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <871rz1a0kr.fsf@netris.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 23 Messidor an 227 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 11 Jul 2019 23:24:55 +0200 Message-ID: <87sgrcnu1k.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Mark H Weaver skribis: > The 'set-paths' phase in (guix build gnu-build-system) currently > includes 'source' in the set of candidates for inclusion in the > search-path variables. Oh, that was certainly not intended. > First of all, I think it's undesirable to include subdirectories of the > source directory in these search paths. However, if you think it's > desirable, there's another problem: it's fragile. It depends on: > > (1) whether the source is a tarball or an unpacked checkout, and > (2) whether the subdirectories specified in the search-paths > (e.g. 'include') are within the top source directory. > > Currently, if you change the 'source' field of a package from a tarball > to an (unpacked) VCS checkout, there *might* be additional components > added to the environment variables, depending on the source tree layout. > > For example, this causes our 'linux-libre' package to fail to build if > you substitute its 'source' field for a git checkout, as Chris Webber > discovered here: > > https://lists.gnu.org/archive/html/help-guix/2019-07/msg00058.html > https://lists.gnu.org/archive/html/help-guix/2019-07/msg00062.html > > Also, if any package depends on the current behavior, it will break if > its 'source' is changed from a VCS checkout to a release tarball. Indeed, that=E2=80=99s terrible. I suppose we were just lucky not to hit s= uch issues before! > To avoid this unexpected sensitivity on the source origin method, I > suggest that we explicitly exclude 'source' from consideration within > the 'set-paths' phase. What do you think? I agree. We should do that in the next =E2=80=98core-updates=E2=80=99. Ludo=E2=80=99. From unknown Tue Jun 17 01:43:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36544: 'set-paths' should exclude 'source' from consideration References: <871rz1a0kr.fsf@netris.org> In-Reply-To: <871rz1a0kr.fsf@netris.org> Resent-From: Aiko Kyle Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 01 Jun 2020 04:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36544 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 36544@debbugs.gnu.org Received: via spool by 36544-submit@debbugs.gnu.org id=B36544.15909870918172 (code B ref 36544); Mon, 01 Jun 2020 04:52:02 +0000 Received: (at 36544) by debbugs.gnu.org; 1 Jun 2020 04:51:31 +0000 Received: from localhost ([127.0.0.1]:34286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfcQ7-00027k-MT for submit@debbugs.gnu.org; Mon, 01 Jun 2020 00:51:31 -0400 Received: from mail-ot1-f48.google.com ([209.85.210.48]:45383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfcQ6-00027S-AF for 36544@debbugs.gnu.org; Mon, 01 Jun 2020 00:51:30 -0400 Received: by mail-ot1-f48.google.com with SMTP id m2so5039239otr.12 for <36544@debbugs.gnu.org>; Sun, 31 May 2020 21:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=aMqzilsBRb3F6IH0bad8PVReDUYTmJHWnGoVlIcR6vA=; b=Pn91HRAK8E1TiJrn/PNEGXfaAOuwVTYv8zctbafI8UKMMQOv/OM0LXICASoOkEs5Cq hyYqdsZvuba9vGDYdYy1uuk4P3zdpaUSLo59d3pB+nl492Hs4FfIw1GmDuVxY2upEXWn e4ggd9D16rIcBkCMiRZV0Y+6ElRYpWsr9MphdNx4efhtINVkHER9lajaUmiMpzZ8sJiA 3EcN7zSd3B6dyaSxpq/TRy03rWIS8jwKPgbL9IDOA9eKUxNTPR0ksaQKIBhLiutvsabz rWSOZQe9dJe7tA+2f+NDacJov4o4wKYkZ+NRCRbhdvJdD7XJAa2LOYpUmfgxwGxFzfb5 edfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version:content-transfer-encoding; bh=aMqzilsBRb3F6IH0bad8PVReDUYTmJHWnGoVlIcR6vA=; b=U76JL5fctQVWkp4bBiJRdHn5HczgCcpRN8R9UItsRIYMnAIbzStdGsV2HPPCkPgL/o eoAOFw5KpZyFhv79VPC6m4SoBoj4kxJrqqGcwShl53vu/KELXnN1su/LV1jU923+PXDD TQcARmCrKuefhUCtZAjqJ6slPw6yScmvJ7EIA/mugXlVtbnZ4jTufQMjlD8y3aJSVPxH gawChY9zsJZ3UTCyQ94TWvE4jx7rUfSNWmJdM00nk/psPJmJTyjUX4E/n3Br0eue/474 TZ1ZhCE+phWB7zitu3Yt9p9QspmV6O/nzk+dK5nuwyY5zFr596/SFP42aDRqZfzJ7Qc1 Mdew== X-Gm-Message-State: AOAM533ASrET5v6/uRDMcpl2iwyQeohVn+JjPxFl7pqXTYsrwgApanYP RNWpFuRyVrap3VDDTQTI00y2XdyCSGo= X-Google-Smtp-Source: ABdhPJybIIavLoyBimox05ZjGAmqxTrlL6pnFsIAkoKXg0LKRPH8jORSlEFGZTOiqzyDjPJhx+Vz8Q== X-Received: by 2002:a05:6830:1d69:: with SMTP id l9mr16512890oti.127.1590987084297; Sun, 31 May 2020 21:51:24 -0700 (PDT) Received: from lore ([2601:281:8080:45f0:f9f7:6f9e:7313:8779]) by smtp.gmail.com with ESMTPSA id l9sm2653444oot.2.2020.05.31.21.51.23 for <36544@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 May 2020 21:51:23 -0700 (PDT) User-agent: mu4e 1.4.5; emacs 28.0.50 From: Aiko Kyle Date: Sun, 31 May 2020 22:51:22 -0600 Message-ID: <86sgffmlrp.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > To avoid this unexpected sensitivity on the source origin=20 > > method, I > > suggest that we explicitly exclude 'source' from consideration=20 > > within > > the 'set-paths' phase. What do you think? >=20 > I agree. We should do that in the next =E2=80=98core-updates=E2=80=99. I recently ran into this bug myself and was surprised that there=20 would be a difference between building from a tarball and a git=20 checkout. It seems the fix should be fairly straight forward so=20 are there any plans to implement it? Thanks, Aiko From unknown Tue Jun 17 01:43:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36544: 'set-paths' should exclude 'source' from consideration Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 13 Dec 2020 19:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36544 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Mark H Weaver , 36544@debbugs.gnu.org Received: via spool by 36544-submit@debbugs.gnu.org id=B36544.160788786330227 (code B ref 36544); Sun, 13 Dec 2020 19:32:02 +0000 Received: (at 36544) by debbugs.gnu.org; 13 Dec 2020 19:31:03 +0000 Received: from localhost ([127.0.0.1]:50294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koX5C-0007rS-LJ for submit@debbugs.gnu.org; Sun, 13 Dec 2020 14:31:02 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:42947) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koX5B-0007qf-7B for 36544@debbugs.gnu.org; Sun, 13 Dec 2020 14:31:01 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 377365C0040; Sun, 13 Dec 2020 14:30:55 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 13 Dec 2020 14:30:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=mesmtp; bh=3lhy/y+fqoaVRJQiuQyjpuN1QwnpErqWiX6Mchvg5SM=; b=lRVSJQ5fyNDg LAVNDjU3p12U3sHXqhsgs1wVEfiJTj9TG+SDWndip02oY4re0OOXxhCwUIklA7i4 QjUVPjVGK9rlWABbCi9q47IpVib2jEawrvEzSjJSibfr76Xf4D4yDLQZT+1byfnv OTk5OmeXee9VKgIeH4VR9zCZi+zOPdU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=3lhy/y+fqoaVRJQiuQyjpuN1QwnpErqWiX6Mchvg5 SM=; b=PpAQeyzfKAXkcoU50ldXq7o9sbuJuKBjYGwA70v2OPrQfMVHw+pV99b4m Y/h/xto6/81ZyFP3bEKk7Y6yq6tkPZJA06Y7rSvZ+LKy0TaPiOEobdx2JamamNwX XWi+70A3hU3mqRDGJOabNcv7Z2GkxlQ8d0m8OAKKk5O8oTQ2w7W3oIMEDQLqa0Dw N/t5/W8rU8TYhfWklDCAj79ojO9l7jadwSWtnHmGSYEBDRaoMNZKx2WECRCCP3WQ 6LnAYhNpBMX4+XA/pw/pObZeFFRuart+ET8dtQorHvFAmTyG6fWLwxyplI1B3aKv /T7ki7P8UyVY9bj6ccio67cLRomtA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudekiedguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggugfgjsehtkeertddttdejnecuhfhrohhmpefnvgho ucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrg htthgvrhhnpeegjeeggeehtddugfffuddtvdfffeffjeekffffveffheegvddvuedtffek jeejjeenucfkphepjeefrddugedurdduvdejrddugeeinecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghm vg X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id 591BE240057; Sun, 13 Dec 2020 14:30:54 -0500 (EST) Date: Sun, 13 Dec 2020 14:30:51 -0500 From: Leo Famulari Message-ID: References: <871rz1a0kr.fsf@netris.org> <87sgrcnu1k.fsf@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87sgrcnu1k.fsf@inria.fr> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, Jul 11, 2019 at 11:24:55PM +0200, Ludovic Courtès wrote: > > To avoid this unexpected sensitivity on the source origin method, I > > suggest that we explicitly exclude 'source' from consideration within > > the 'set-paths' phase. What do you think? > > I agree. We should do that in the next ‘core-updates’. Now is a good time to make this change. From unknown Tue Jun 17 01:43:28 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Mark H Weaver Subject: bug#36544: closed (Re: bug#36544: 'set-paths' should exclude 'source' from consideration) Message-ID: References: <87o8ixa488.fsf@gnu.org> <871rz1a0kr.fsf@netris.org> X-Gnu-PR-Message: they-closed 36544 X-Gnu-PR-Package: guix Reply-To: 36544@debbugs.gnu.org Date: Sun, 13 Dec 2020 19:37:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1607888221-31916-1" This is a multi-part message in MIME format... ------------=_1607888221-31916-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #36544: 'set-paths' should exclude 'source' from consideration which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 36544@debbugs.gnu.org. --=20 36544: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D36544 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1607888221-31916-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 36544-done) by debbugs.gnu.org; 13 Dec 2020 19:36:02 +0000 Received: from localhost ([127.0.0.1]:50302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koXA2-0008EP-Ga for submit@debbugs.gnu.org; Sun, 13 Dec 2020 14:36:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koXA0-0008Db-LM for 36544-done@debbugs.gnu.org; Sun, 13 Dec 2020 14:36:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40692) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koX9v-0006Nv-1H; Sun, 13 Dec 2020 14:35:55 -0500 Received: from host-37-191-236-253.lynet.no ([37.191.236.253]:32886 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1koX9u-0003Ol-1d; Sun, 13 Dec 2020 14:35:54 -0500 From: Marius Bakke To: Leo Famulari , Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#36544: 'set-paths' should exclude 'source' from consideration In-Reply-To: References: <871rz1a0kr.fsf@netris.org> <87sgrcnu1k.fsf@inria.fr> Date: Sun, 13 Dec 2020 20:35:51 +0100 Message-ID: <87o8ixa488.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36544-done Cc: 36544-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Leo Famulari skriver: > On Thu, Jul 11, 2019 at 11:24:55PM +0200, Ludovic Court=C3=A8s wrote: >> > To avoid this unexpected sensitivity on the source origin method, I >> > suggest that we explicitly exclude 'source' from consideration within >> > the 'set-paths' phase. What do you think? >>=20 >> I agree. We should do that in the next =E2=80=98core-updates=E2=80=99. > > Now is a good time to make this change. This was fixed in 968f541c36c28c413f696558505f902d0a133d58. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFDBAEBCgAtFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl/WbRcPHG1hcml1c0Bn bnUub3JnAAoJEKKgbfKjOlT6OKYH/RmztXspSopD2+rHncR6UEj1mQlyKOSeA4hJ 3ajZL8A1bwjOo/J/8Uk7V5f7JxbvB6ZeKnhPuCi/IuA167By+KPc0+46O7as0XtD Bv10YwjIgXVAnsIwX87cxFmT+4I5qBKlsic+2x/C2H5GszG8IqErq494Rl2pisOk RjDUdPnvYaV0s5wyc+hV6zqo497ANyFPNMp+ZKGgSgNSqDHbcvZ4ZcBC260xr1xw BWgCYt054utKf2b+b5AGYLoq7d88LpcsHLmlh8wJQmYEdwNR45yEaF4OLiuc5vwi r1KO5ZQwIxbRvI0veAf0ohkNVT93Xyp4CuPxV6p/kbfc0K6v64U= =fD3f -----END PGP SIGNATURE----- --=-=-=-- ------------=_1607888221-31916-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Jul 2019 23:26:45 +0000 Received: from localhost ([127.0.0.1]:57556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkGYP-00059b-Ez for submit@debbugs.gnu.org; Sun, 07 Jul 2019 19:26:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:41711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkGYN-00059U-TT for submit@debbugs.gnu.org; Sun, 07 Jul 2019 19:26:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37834) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkGYM-0006oO-Oa for bug-guix@gnu.org; Sun, 07 Jul 2019 19:26:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkGYL-0001eb-L4 for bug-guix@gnu.org; Sun, 07 Jul 2019 19:26:42 -0400 Received: from world.peace.net ([64.112.178.59]:53214) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hkGYL-0001e6-Hm for bug-guix@gnu.org; Sun, 07 Jul 2019 19:26:41 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkGYJ-0006Oo-PP; Sun, 07 Jul 2019 19:26:39 -0400 From: Mark H Weaver To: bug-guix@gnu.org Subject: 'set-paths' should exclude 'source' from consideration Date: Sun, 07 Jul 2019 19:26:12 -0400 Message-ID: <871rz1a0kr.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 64.112.178.59 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The 'set-paths' phase in (guix build gnu-build-system) currently includes 'source' in the set of candidates for inclusion in the search-path variables. First of all, I think it's undesirable to include subdirectories of the source directory in these search paths. However, if you think it's desirable, there's another problem: it's fragile. It depends on: (1) whether the source is a tarball or an unpacked checkout, and (2) whether the subdirectories specified in the search-paths (e.g. 'include') are within the top source directory. Currently, if you change the 'source' field of a package from a tarball to an (unpacked) VCS checkout, there *might* be additional components added to the environment variables, depending on the source tree layout. For example, this causes our 'linux-libre' package to fail to build if you substitute its 'source' field for a git checkout, as Chris Webber discovered here: https://lists.gnu.org/archive/html/help-guix/2019-07/msg00058.html https://lists.gnu.org/archive/html/help-guix/2019-07/msg00062.html Also, if any package depends on the current behavior, it will break if its 'source' is changed from a VCS checkout to a release tarball. To avoid this unexpected sensitivity on the source origin method, I suggest that we explicitly exclude 'source' from consideration within the 'set-paths' phase. What do you think? Also, does anyone know of other procedures that do something similiar? Thanks, Mark ------------=_1607888221-31916-1--