GNU bug report logs - #36543
[PATCH] gnu: wireservice: New wireservice-package macro.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Pierre Langlois <pierre.langlois <at> gmx.com>
Subject: bug#36543: closed (Re: [bug#36543] [PATCH] gnu: wireservice: New
 wireservice-package macro.)
Date: Mon, 08 Jul 2019 10:58:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#36543: [PATCH] gnu: wireservice: New wireservice-package macro.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 36543 <at> debbugs.gnu.org.

-- 
36543: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36543
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Pierre Langlois <pierre.langlois <at> gmx.com>
Cc: 36543-done <at> debbugs.gnu.org
Subject: Re: [bug#36543] [PATCH] gnu: wireservice: New wireservice-package
 macro.
Date: Mon, 08 Jul 2019 12:57:28 +0200

Hello,

Pierre Langlois <pierre.langlois <at> gmx.com> skribis:

> Here's a new 'wireservice-package' macro that factors the packages that
> used to inherit for a base package with '#f fields. The main change is
> that native-inputs are no longer common, I toyed with a more complicated
> macro that would allow extending them but in the end I think the simpler
> the better!
>
> WDYT?

I think it looks good this way!

There’s a bit of code bloat because the macro expands the ‘arguments’
field for every package, but it doesn’t matter much here (it’d be more
of a problem if we had 100s of packages all duplicating that field.)

> Thanks for the suggestion! I need to learn me some more macro magic,
> it's fun :-).

Yup!  :-)

> From cf7559db69dd1d829e620c6b31e253a2d8911eff Mon Sep 17 00:00:00 2001
> From: Pierre Langlois <pierre.langlois <at> gmx.com>
> Date: Sun, 7 Jul 2019 16:02:26 +0100
> Subject: [PATCH] gnu: wireservice: New wireservice-package macro.
>
> Replace the parent 'base-package' variable with a 'wireservice-package' macro
> that includes all common package fields.
>
> * gnu/packages/wireservice.scm (base-package): Delete.
> (wireservice-package): New macro.
> (python-leather, python-agate, python-agate-sql, python-agate-dbf,
> python-agate-excel): Use wireservice-package.

Applied, thanks for the quick followup!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Pierre Langlois <pierre.langlois <at> gmx.com>
To: Guix-patches <guix-patches <at> gnu.org>
Cc: Pierre Langlois <pierre.langlois <at> gmx.com>,
 Ludovic Courtès <ludo <at> gnu.org>
Subject: [PATCH] gnu: wireservice: New wireservice-package macro.
Date: Sun, 07 Jul 2019 22:02:47 +0100

[Message part 4 (text/plain, inline)]

Hi Guix, Ludo,

Here's a new 'wireservice-package' macro that factors the packages that
used to inherit for a base package with '#f fields. The main change is
that native-inputs are no longer common, I toyed with a more complicated
macro that would allow extending them but in the end I think the simpler
the better!

WDYT?

Thanks for the suggestion! I need to learn me some more macro magic,
it's fun :-).

Pierre

[0001-gnu-wireservice-New-wireservice-package-macro.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.