GNU bug report logs - #36537
[PATCH] discovery: Handle edge case in scheme-files when looking at symlinks.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#36537: closed ([PATCH] discovery: Handle edge case in
 scheme-files when looking at symlinks.)
Date: Mon, 08 Jul 2019 16:57:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 08 Jul 2019 17:56:26 +0100
with message-id <87a7doa2it.fsf <at> cbaines.net>
and subject line Re: [bug#36537] [PATCH] discovery: Handle edge case in scheme-files when looking at symlinks.
has caused the debbugs.gnu.org bug report #36537,
regarding [PATCH] discovery: Handle edge case in scheme-files when looking at symlinks.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
36537: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36537
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] discovery: Handle edge case in scheme-files when looking at
 symlinks.
Date: Sun,  7 Jul 2019 12:21:02 +0100

Previously, this code would cause crashes in Guix (running guix package -s for
example) which could be experienced when Emacs creates temporary files in the
gnu/packages/patches directory when a patch file has been edited, but not
saved.

* guix/discovery.scm (scheme-files): Add else clause to cond used when
handling symlinks.
---
 guix/discovery.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/guix/discovery.scm b/guix/discovery.scm
index 5bb494941b..86f20ec344 100644
--- a/guix/discovery.scm
+++ b/guix/discovery.scm
@@ -78,7 +78,9 @@ DIRECTORY is not accessible."
                                  ((= stat:type 'directory)
                                   (append (scheme-files absolute)
                                           result))
-                                 (_ result)))))
+                                 (_ result)))
+                              (else
+                               result)))
                        (else
                         result))))))
               '()
-- 
2.22.0

[Message part 3 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 36537-done <at> debbugs.gnu.org
Subject: Re: [bug#36537] [PATCH] discovery: Handle edge case in scheme-files
 when looking at symlinks.
Date: Mon, 08 Jul 2019 17:56:26 +0100

[Message part 4 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi Chris,
>
> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> Previously, this code would cause crashes in Guix (running guix package -s for
>> example) which could be experienced when Emacs creates temporary files in the
>> gnu/packages/patches directory when a patch file has been edited, but not
>> saved.
>>
>> * guix/discovery.scm (scheme-files): Add else clause to cond used when
>> handling symlinks.
>
> Good catch, LGTM!

Great, I've pushed this now :)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.