Subject: bug#36537: closed (Re: [bug#36537] [PATCH] discovery: Handle edge case in scheme-files when looking at symlinks.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 08 Jul 2019 16:57:02 +0000

Your bug report

#36537: [PATCH] discovery: Handle edge case in scheme-files when looking at symlinks.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
36537: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36537
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#36537] [PATCH] discovery: Handle edge case in scheme-files when looking at symlinks.
From: Christopher Baines <[email-masked]>
To: Ludovic Courtès <[email-masked]>
Cc: [email-masked]
Date: Mon, 08 Jul 2019 17:56:26 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Ludovic Courtès <[email-masked]> writes:

> Hi Chris,
>
> Christopher Baines <[email-masked]> skribis:
>
>> Previously, this code would cause crashes in Guix (running guix package -s for
>> example) which could be experienced when Emacs creates temporary files in the
>> gnu/packages/patches directory when a patch file has been edited, but not
>> saved.
>>
>> * guix/discovery.scm (scheme-files): Add else clause to cond used when
>> handling symlinks.
>
> Good catch, LGTM!

Great, I've pushed this now :)

Subject: [PATCH] discovery: Handle edge case in scheme-files when looking at symlinks.
From: Christopher Baines <[email-masked]>
To: [email-masked]
Date: Sun, 7 Jul 2019 12:21:02 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Previously, this code would cause crashes in Guix (running guix package -s for
example) which could be experienced when Emacs creates temporary files in the
gnu/packages/patches directory when a patch file has been edited, but not
saved.

* guix/discovery.scm (scheme-files): Add else clause to cond used when
handling symlinks.
---
 guix/discovery.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/guix/discovery.scm b/guix/discovery.scm
index 5bb494941b..86f20ec344 100644
--- a/guix/discovery.scm
+++ b/guix/discovery.scm
@@ -78,7 +78,9 @@ DIRECTORY is not accessible."
                                  ((= stat:type 'directory)
                                   (append (scheme-files absolute)
                                           result))
-                                 (_ result)))))
+                                 (_ result)))
+                              (else
+                               result)))
                        (else
                         result))))))
               '()
-- 
2.22.0