From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 07 07:21:14 2019 Received: (at submit) by debbugs.gnu.org; 7 Jul 2019 11:21:14 +0000 Received: from localhost ([127.0.0.1]:56196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hk5EH-0005Qf-2e for submit@debbugs.gnu.org; Sun, 07 Jul 2019 07:21:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:41042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hk5EE-0005QT-1P for submit@debbugs.gnu.org; Sun, 07 Jul 2019 07:21:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44771) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hk5ED-0006KR-5D for guix-patches@gnu.org; Sun, 07 Jul 2019 07:21:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,UNPARSEABLE_RELAY autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hk5EC-0006rR-CM for guix-patches@gnu.org; Sun, 07 Jul 2019 07:21:09 -0400 Received: from mira.cbaines.net ([2a01:7e00::f03c:91ff:fe69:8da9]:55338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hk5EB-0006qI-Vb for guix-patches@gnu.org; Sun, 07 Jul 2019 07:21:08 -0400 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 79A6216545 for ; Sun, 7 Jul 2019 12:21:02 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 617cc76c for ; Sun, 7 Jul 2019 11:21:02 +0000 (UTC) From: Christopher Baines To: guix-patches@gnu.org Subject: [PATCH] discovery: Handle edge case in scheme-files when looking at symlinks. Date: Sun, 7 Jul 2019 12:21:02 +0100 Message-Id: <20190707112102.8908-1-mail@cbaines.net> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a01:7e00::f03c:91ff:fe69:8da9 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Previously, this code would cause crashes in Guix (running guix package -= s for example) which could be experienced when Emacs creates temporary files in= the gnu/packages/patches directory when a patch file has been edited, but not saved. * guix/discovery.scm (scheme-files): Add else clause to cond used when handling symlinks. --- guix/discovery.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/guix/discovery.scm b/guix/discovery.scm index 5bb494941b..86f20ec344 100644 --- a/guix/discovery.scm +++ b/guix/discovery.scm @@ -78,7 +78,9 @@ DIRECTORY is not accessible." ((=3D stat:type 'directory) (append (scheme-files absolute) result)) - (_ result))))) + (_ result))) + (else + result))) (else result)))))) '() --=20 2.22.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 08 07:00:08 2019 Received: (at 36537) by debbugs.gnu.org; 8 Jul 2019 11:00:08 +0000 Received: from localhost ([127.0.0.1]:57947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkRNP-00006Q-R4 for submit@debbugs.gnu.org; Mon, 08 Jul 2019 07:00:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkRNO-0008WO-9x for 36537@debbugs.gnu.org; Mon, 08 Jul 2019 07:00:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hkRNI-0006Uh-QL; Mon, 08 Jul 2019 07:00:00 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=39720 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hkRNI-0006B8-DB; Mon, 08 Jul 2019 07:00:00 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Christopher Baines Subject: Re: [bug#36537] [PATCH] discovery: Handle edge case in scheme-files when looking at symlinks. References: <20190707112102.8908-1-mail@cbaines.net> Date: Mon, 08 Jul 2019 12:59:59 +0200 In-Reply-To: <20190707112102.8908-1-mail@cbaines.net> (Christopher Baines's message of "Sun, 7 Jul 2019 12:21:02 +0100") Message-ID: <87a7doeqq8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36537 Cc: 36537@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Chris, Christopher Baines skribis: > Previously, this code would cause crashes in Guix (running guix package -= s for > example) which could be experienced when Emacs creates temporary files in= the > gnu/packages/patches directory when a patch file has been edited, but not > saved. > > * guix/discovery.scm (scheme-files): Add else clause to cond used when > handling symlinks. Good catch, LGTM! Thank you, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 08 12:56:31 2019 Received: (at 36537-done) by debbugs.gnu.org; 8 Jul 2019 16:56:31 +0000 Received: from localhost ([127.0.0.1]:59395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkWwJ-0003kO-AN for submit@debbugs.gnu.org; Mon, 08 Jul 2019 12:56:31 -0400 Received: from mira.cbaines.net ([212.71.252.8]:40608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkWwG-0003kB-Ju for 36537-done@debbugs.gnu.org; Mon, 08 Jul 2019 12:56:29 -0400 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id B3F20171D2; Mon, 8 Jul 2019 17:56:26 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 5c58f714; Mon, 8 Jul 2019 16:56:26 +0000 (UTC) References: <20190707112102.8908-1-mail@cbaines.net> <87a7doeqq8.fsf@gnu.org> User-agent: mu4e 1.2.0; emacs 26.2 From: Christopher Baines To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#36537] [PATCH] discovery: Handle edge case in scheme-files when looking at symlinks. In-reply-to: <87a7doeqq8.fsf@gnu.org> Date: Mon, 08 Jul 2019 17:56:26 +0100 Message-ID: <87a7doa2it.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 36537-done Cc: 36537-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi Chris, > > Christopher Baines skribis: > >> Previously, this code would cause crashes in Guix (running guix package = -s for >> example) which could be experienced when Emacs creates temporary files i= n the >> gnu/packages/patches directory when a patch file has been edited, but not >> saved. >> >> * guix/discovery.scm (scheme-files): Add else clause to cond used when >> handling symlinks. > > Good catch, LGTM! Great, I've pushed this now :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl0jdbpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfHhBAAogfkBqwL5CVozgXehUo2GNFwLEMm4ma/IqQ27FJ3E7u8l/ob6e0pGXih fB2+m4bH+CUtanGzekS0QMT5UQ43vBkskv3ZW2evV5NJiMoK6UkNayAnds4K844O w1D8BOi79mTeOpZH547qXPVQ/+kEBkfzMKU6Dk770vs2uFX+Uo1aO9eNAOKa6j7x Wf5LD1cdQZ7LUBQ1ysrNLXyAfIyjlRGO0RCQjnrzCjaEV5sEuItvZQwWGks4E11B PiRp7erzG34Ec+Cz13Gzsc77Ovh/MGkZHdPgt813JFnCFr2vM31LHV6GulvH4nGc Go6qtfGXZBMIXJPqfDc3rvsAXcqpuO1snk4liUqf4/grqQJmlEdGU6tXL9aTT0ju hgSKj9/bZEr+gAS/JnFy4EQKyB1lOKFjJF5p4jZyYXH1vqWQ4svdTtL89BF/Hl4K t25O91M9xQlIEXwk1qw0mLgmtFadUNI0hxCjwDWIN7VP6qCn7xdziPInqqhsu52C LkSDhvCjZ+6nA/JiQ8jSV+Vzk0uZDcu63BEds6JzNtpuNl86/7HAO55ClE2UsZcg T5nqtD2eBr/qG6z7HKOE61KZP/5nn980UhcEDWVoApjCMtRLBkgcVggfT+Cz5cdr HRhON/CW+zihKUB0dn62wWMBwuoStELBpViKuWyBGC9dtYkaVVc= =Fsvq -----END PGP SIGNATURE----- --=-=-=-- From unknown Thu Sep 11 15:11:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 06 Aug 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator