From unknown Sat Aug 16 16:19:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36501: 26.2; (elisp) `Defining Minor Modes' Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jul 2019 15:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36501 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 36501@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.156225440611185 (code B ref -1); Thu, 04 Jul 2019 15:34:01 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jul 2019 15:33:26 +0000 Received: from localhost ([127.0.0.1]:51737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hj3ji-0002uJ-AI for submit@debbugs.gnu.org; Thu, 04 Jul 2019 11:33:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:58265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hj3jg-0002uB-NZ for submit@debbugs.gnu.org; Thu, 04 Jul 2019 11:33:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39338) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hj3je-0004gQ-QG for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2019 11:33:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_MED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hj3ja-00034w-LG for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2019 11:33:20 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:47702) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hj3jW-0002w0-UR for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2019 11:33:16 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x64FT6T5084575 for ; Thu, 4 Jul 2019 15:33:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=ufWULZ6sYtE+FoZIjwD2418Hbj1DBAMjeVzJ8UhdclE=; b=iA5Y2p/PBRMj6Em9pUZOJ25sH6OqYZNrvAa49sREIsyFnL0xQLQuboCxZXPGmvque5Ju FmtNG/9Pcf/Zcj9Qk6+uGOb/dUr/4Y5fFxdCh6/6SrDAOZJHYXTPgzCGhV+wku+2FwAT jneaPPXBvK/FGSPqfYybSujO2PwX+fs16+6Q7Wip2di7ANX4fnpbbtlou/7X6DPQeac8 wTjG70ruW5+bljqV04TJ4SzmUCnaNrxZdUYa0+9fuCXPGi/4aeNXsqVrWe2lefDnSctc 15HpdXhS/BP6+giguubkQPPAiOTfhyp59uXYCyRNFgby9dYc16WQoWLKsyzxWcrrTqsU SQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2te61q7dv3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 04 Jul 2019 15:33:09 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x64FX1E1192447 for ; Thu, 4 Jul 2019 15:33:09 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 2th5qm3nvy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 04 Jul 2019 15:33:09 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x64FX8rv032127 for ; Thu, 4 Jul 2019 15:33:08 GMT MIME-Version: 1.0 Message-ID: <840640b2-bc37-4f56-b16e-0622321cb764@default> Date: Thu, 4 Jul 2019 08:33:07 -0700 (PDT) From: Drew Adams X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9307 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907040197 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9307 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907040196 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 156.151.31.85 X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The examples defining `hungry-mode', and their descriptions, don't seem completely correct. Unless a minor mode is declared to be global, which `hungry-mode' is not, I don't think it defines a user option. But this doc says: It puts the variable 'hungry-mode' into custom group 'hunger'. Does that happen? Even if I define a `hunger' group before evaluating those `define-minor-mode' sexps I don't see that `M-x customize-group' gets you to variable `hungry-mode'. But I didn't test much, e.g. with different `defgroup' definitions for group `hungry'. My guess is that (1) `:group 'hunger' should be removed from the examples and (2) the doc should not say that variable `hungry-mode' is put "into custom group `hunger'. It should not give the impression that var `hungry-mode' is a user option. --- I also think it's not so important to show two full examples for the buffer-local mode, and it might be good to show an example for a global mode - perhaps even two: (1) using `define-minor-mode' and (2) using `define-globalized-minor-mode'. In GNU Emacs 26.2 (build 1, x86_64-w64-mingw32) of 2019-04-13 Repository revision: fd1b34bfba8f3f6298df47c8e10b61530426f749 Windowing system distributor `Microsoft Corp.', version 10.0.17134 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3'' From unknown Sat Aug 16 16:19:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36501: 26.2; (elisp) `Defining Minor Modes' Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jul 2019 20:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36501 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Drew Adams Cc: 36501@debbugs.gnu.org Received: via spool by 36501-submit@debbugs.gnu.org id=B36501.156261790928145 (code B ref 36501); Mon, 08 Jul 2019 20:32:01 +0000 Received: (at 36501) by debbugs.gnu.org; 8 Jul 2019 20:31:49 +0000 Received: from localhost ([127.0.0.1]:59667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkaIf-0007Jt-Dt for submit@debbugs.gnu.org; Mon, 08 Jul 2019 16:31:49 -0400 Received: from quimby.gnus.org ([80.91.231.51]:33108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkaId-0007Jj-Oo for 36501@debbugs.gnu.org; Mon, 08 Jul 2019 16:31:48 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkaIY-0004yQ-3u; Mon, 08 Jul 2019 22:31:44 +0200 From: Lars Ingebrigtsen References: <840640b2-bc37-4f56-b16e-0622321cb764@default> Date: Mon, 08 Jul 2019 22:31:41 +0200 In-Reply-To: <840640b2-bc37-4f56-b16e-0622321cb764@default> (Drew Adams's message of "Thu, 4 Jul 2019 08:33:07 -0700 (PDT)") Message-ID: <87imsc2rpu.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Drew Adams writes: > But this doc says: > > It puts the variable 'hungry-mode' into custom group 'hunger'. > > Does that happen? Even if I define a `hunger' group before evaluating > those `define-minor-mode' sexps I do [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Drew Adams writes: > But this doc says: > > It puts the variable 'hungry-mode' into custom group 'hunger'. > > Does that happen? Even if I define a `hunger' group before evaluating > those `define-minor-mode' sexps I don't see that `M-x customize-group' > gets you to variable `hungry-mode'. But I didn't test much, e.g. with > different `defgroup' definitions for group `hungry'. I tested a bit, and I think you're right. > My guess is that (1) `:group 'hunger' should be removed from the > examples and (2) the doc should not say that variable `hungry-mode' > is put "into custom group `hunger'. It should not give the impression > that var `hungry-mode' is a user option. I've now done so. > I also think it's not so important to show two full examples for the > buffer-local mode, and it might be good to show an example for a global > mode - perhaps even two: (1) using `define-minor-mode' and (2) using > `define-globalized-minor-mode'. The two examples are demonstrations of the short, non-explicit form and the longer, explicit forms, so I think that's useful. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 08 16:31:52 2019 Received: (at control) by debbugs.gnu.org; 8 Jul 2019 20:31:53 +0000 Received: from localhost ([127.0.0.1]:59670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkaIi-0007KB-LT for submit@debbugs.gnu.org; Mon, 08 Jul 2019 16:31:52 -0400 Received: from quimby.gnus.org ([80.91.231.51]:33122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkaIg-0007K1-TX for control@debbugs.gnu.org; Mon, 08 Jul 2019 16:31:51 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkaIe-0004yX-BO for control@debbugs.gnu.org; Mon, 08 Jul 2019 22:31:50 +0200 Date: Mon, 08 Jul 2019 22:31:47 +0200 Message-Id: <87h87w2rpo.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #36501 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 36501 fixed close 36501 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 36501 fixed close 36501 27.1 quit