GNU bug report logs - #36485
[PATCH] Improve some menus with separators and better wording

Previous Next

Full log

Message #14 received at 36485 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 36485 <at> debbugs.gnu.org
Subject: Re: bug#36485: [PATCH] Improve some menus with separators and better
 wording
Date: Fri, 13 Sep 2019 20:57:24 +0200

tags 36485 + fixed
close 36485 27.1
close

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Stefan Kangas <stefan <at> marxist.se>
>> Date: Wed, 3 Jul 2019 09:17:42 +0200
>>
>> Just a small patch to add menu separators to some menus that are
>> missing them.
>
> What were the criteria for determining that a separator is missing in
> a particular place?
>
> Adding separators makes the menus longer, which could be a problem,
> especially on TTY frames with a small number of lines (like 24).  So
> we need to add them judiciously.

Thanks for reviewing the change.  Looking back at the suggestion, my
criteria were admittedly pretty ad hoc, and I had completely forgotten
about the menu on the console.

Taking another look now, I think the only important change here is a
typo which I fixed in commit 224534ab8d.

With that, I'm closing this bug report.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.