Subject: [bug#36477] [PATCH v3 45/48] system: vm: Add arm64 support.

From: Ludovic Courtès <[email-masked]>
Date: Wed, 04 Sep 2019 14:36:01 +0200

Mathieu Othacehe <[email-masked]> skribis:

> * gnu/build/vm.scm (load-in-linux-vm): Add target-arm64? argument and use it
> to pass correct arguments to qemu.
> * gnu/system/vm.scm (expression->derivation-in-linux-vm): Pass the new
> target-arm64? argument added above. Do not add ESP partition on all ARM
> targets. Do not pass grub-efi package to initialize-hard-disk on ARM targets.

[...]

> --- a/gnu/build/vm.scm
> +++ b/gnu/build/vm.scm
> @@ -82,6 +82,7 @@
>                             make-disk-image?
>                             single-file-output?
>                             target-arm32?
> +                           target-arm64?

Maybe we should just have a #:target parameter instead, WDYT?

[...]

> +                    (grub-efi #$@(if (target-arm?)
> +                                     '(#f)
> +                                     #~(#$grub-efi))))

Simply:  #$(and (not (target-arm?)) grub-efi).

Otherwise LGTM.

Ludo’.