Subject: Re: [bug#36477] [PATCH 09/31] gnu: http-parser: Fix cross-compilation.

From: Marius Bakke <[email-masked]>
Date: Mon, 08 Jul 2019 19:46:22 +0200

Mathieu Othacehe <[email-masked]> writes:

> * gnu/packages/web.scm (http-parser)[arguments]: Set CC and AR variables in
> Makefile in order to fix cross-compilation.

[...]

> @@ -5171,10 +5172,18 @@ into your tests.  It automatically starts up a HTTP server in a separate thread
>         #:make-flags
>         (list (string-append "PREFIX="
>                              (assoc-ref %outputs "out"))
> -             "CC=gcc" "library")
> +             "library")
>         #:phases
>         (modify-phases %standard-phases
> -         (delete 'configure))))
> +         (replace 'configure
> +           (lambda* (#:key target #:allow-other-keys)
> +             (when ,(%current-target-system)
> +               (substitute* (find-files "." "Makefile")
> +                 (("CC\\?=.*$")
> +                  (string-append "CC=" target "-gcc\n"))
> +                 (("AR\\?=.*$")
> +                  (string-append "AR=" target "-ar\n"))))
> +             #t)))))

I would prefer to splice in this phase instead of adding a noop phase to
the native build.  LGTM otherwise.

(so I guess CC=gcc was not needed for native builds?)