From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 02 10:07:14 2019 Received: (at submit) by debbugs.gnu.org; 2 Jul 2019 14:07:14 +0000 Received: from localhost ([127.0.0.1]:47601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiJRC-0006Dz-Bu for submit@debbugs.gnu.org; Tue, 02 Jul 2019 10:07:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:50978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiJR9-0006Dq-PA for submit@debbugs.gnu.org; Tue, 02 Jul 2019 10:07:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44058) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiJR7-0004HA-VG for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 10:07:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiJR6-0001z7-Lu for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 10:07:09 -0400 Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]:35990) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hiJR6-0001nL-At for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 10:07:08 -0400 Received: by mail-oi1-x234.google.com with SMTP id w7so13112836oic.3 for ; Tue, 02 Jul 2019 07:06:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=zybpU8dPLDJboHM5HcfzRJcIQX2h3rZ1i3VzVLLeImE=; b=ZzBA11q+6RTSIEEBZ0oRfJKxwb75bPaVQjQ/Db5cdJrQdOHSD3dACg39Pg7sUCS8CX Fj38js/AuT4XctMxO2XGFo+ssp1j/QdmgUC04GdmVJr2IvkCETNnyY0EjmDH4O8mD/M6 xHOcVHyHyMIo1kwG4ElTkeWjzweKyE3LTEUTHYO3X4U66Tjr1KFHyugP7V1FDwF8YByy 29qWHr57I/MZmlNzQQWH0q1P5PuNeGtTJLOtbVpnXslYp5y9fefeD8zfk8iQ42+7TeXj CH+Haknp8EJzXS1vvDPoaiJBuCuQwRJuYlr65p558JCcpyScz/crzsvLP4G3qxbdnSUD bmZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=zybpU8dPLDJboHM5HcfzRJcIQX2h3rZ1i3VzVLLeImE=; b=ikiWjEDy7ksEFVbB88NH4TqwdJSTPB8wbz7I+j+3FwHhrj7O8qs4TYLjoizuu/e104 0weX5MQSlqfs/tp3p+7hQJdC3xjl5XDhOQOp7xQnPAtNamYJl7R051PfLIflMyGlk5Ps yme/jp1WwHbHXS79/josBjHUfbdE9wLhc1wja8XZ8CL99Gicwb7lqN/XcBcp06z9lLPD zdPpsa+APY5pKCd8GfNBvcTUoFsh33xNaJWFqg0df/oqc46xzaopIS7Tm3P39ORkRT6V UXNVtSvBLgNDdJjP+Clzq52eXaJp2mdBhjNH4v1JCaHoK2WpQq2QjPHsJ+V4+rO/yWJr TFXQ== X-Gm-Message-State: APjAAAWT0n2ScaS3rb6lZQFix1P5Y0iDDVV4fm8JgeEiwr64o24amI16 umf4ZhrTnsnxhtO/5cI564MK+raeLs5fWTCNysG+aViZo7s= X-Google-Smtp-Source: APXvYqwtzqSvMzymIlhBwrrw0/jNuJOQEJ5Sre9c3Kff3ys40a+E522hKVFNqy4KvLJj7wD46UTGfqNOihR2q2gF/sw= X-Received: by 2002:aca:af0d:: with SMTP id y13mr3065386oie.171.1562076416509; Tue, 02 Jul 2019 07:06:56 -0700 (PDT) MIME-Version: 1.0 From: Nicholas Drozd Date: Tue, 2 Jul 2019 09:06:43 -0500 Message-ID: Subject: [PATCH] Handle 'abbr' and 'acronym' tags in shr.el To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000eb73ce058cb3417f" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::234 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000eb73ce058cb3417f Content-Type: text/plain; charset="UTF-8" I came across some `abbr` tags in the wild: check out the first paragraph of http://mindprod.com/jgloss/unmainobfuscation.html. EWW doesn't handle those, so here is a patch for that. My understanding is that there is also an `acronym` tag which has been deprecated in favor of `abbr`. I figured we might as well cover that one too just in case. I picked the `diary` face for abbreviations, but that choice didn't have a lot of thought put into it. Whoever commits can choose something else. Let's try to get this merged ASAP. --000000000000eb73ce058cb3417f Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Handle-abbr-and-acronym-tags-in-shr.el.patch" Content-Disposition: attachment; filename="0001-Handle-abbr-and-acronym-tags-in-shr.el.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxlvuegu0 RnJvbSBhNzIwNDczYWQxMDAxZDNhNzJmOWIzZjMxNTVmNTQ4ODcyNmNhYmRlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNrIERyb3pkIDxuaWNob2xhc2Ryb3pkQGdtYWlsLmNvbT4K RGF0ZTogTW9uLCAxIEp1bCAyMDE5IDIzOjQ2OjEwIC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gSGFu ZGxlICdhYmJyJyBhbmQgJ2Fjcm9ueW0nIHRhZ3MgaW4gc2hyLmVsCgoqIGxpc3AvbmV0L3Noci5l bDogQWRkICdhYmJyJyBhbmQgJ2Fjcm9ueW0nIHRhZyBoYW5kbGluZy4KKiBldGMvTkVXUzogQW5u b3VuY2UgY2hhbmdlIGluIHNociBiZWhhdnJpb3IuCi0tLQogZXRjL05FV1MgICAgICAgIHwgIDMg KysrCiBsaXNwL25ldC9zaHIuZWwgfCAxNSArKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdl ZCwgMTggaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5k ZXggYWJiZWNlMzc0YS4uNDY0ZGFlMjQ1NCAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRj L05FV1MKQEAgLTk4OSw2ICs5ODksOSBAQCBUaGlzIGF0dHJpYnV0ZSBpcyBtZWFudCB0byB0ZWxs IHNjcmVlbiByZWFkZXJzIHRvIGlnbm9yZSBhIHRhZy4KIC0tLQogKioqIFRoZSA8Y29kZSAuLi4+ IHRhZyBpcyBub3cgaGFuZGxlZC4KIAorLS0tCisqKiogVGhlIDxhYmJyIC4uLj4gYW5kIDxhY3Jv bnltIC4uLj4gdGFncyBhcmUgbm93IGhhbmRsZWQuCisKICoqIEh0bWxmb250aWZ5CiAKICoqKiBU aGUgZnVuY3Rpb25zICdoZnktY29sb3InLCAnaGZ5LWNvbG9yLXZhbHMnIGFuZApkaWZmIC0tZ2l0 IGEvbGlzcC9uZXQvc2hyLmVsIGIvbGlzcC9uZXQvc2hyLmVsCmluZGV4IDdmZGIzMjEyZDQuLjNh ZjNkYjYzN2EgMTAwNjQ0Ci0tLSBhL2xpc3AvbmV0L3Noci5lbAorKysgYi9saXNwL25ldC9zaHIu ZWwKQEAgLTE0NzAsNiArMTQ3MCwyMSBAQCBzaHItdGFnLWEKICAgICAod2hlbiB1cmwKICAgICAg IChzaHItdXJsaWZ5IChvciBzaHItc3RhcnQgc3RhcnQpIChzaHItZXhwYW5kLXVybCB1cmwpIHRp dGxlKSkpKQogCisoZGVmdW4gc2hyLXRhZy1hYmJyIChkb20pCisgIChsZXQgKCh0aXRsZSAoZG9t LWF0dHIgZG9tICd0aXRsZSkpCisJKHN0YXJ0IChwb2ludCkpKQorICAgIChzaHItZ2VuZXJpYyBk b20pCisgICAgKHNoci1hZGQtZm9udCBzdGFydCAocG9pbnQpICdkaWFyeSkKKyAgICAoYWRkLXRl eHQtcHJvcGVydGllcworICAgICBzdGFydCAocG9pbnQpCisgICAgIChsaXN0CisgICAgICAnaGVs cC1lY2hvIHRpdGxlCisgICAgICAnbW91c2UtZmFjZSAnaGlnaGxpZ2h0KSkpKQorCisoZGVmdW4g c2hyLXRhZy1hY3JvbnltIChkb20pCisgIDs7IGBhY3JvbnltJyBpcyBkZXByZWNhdGVkIGluIGZh dm9yIG9mIGBhYmJyJy4KKyAgKHNoci10YWctYWJiciBkb20pKQorCiAoZGVmdW4gc2hyLXRhZy1v YmplY3QgKGRvbSkKICAgKHVubGVzcyBzaHItaW5oaWJpdC1pbWFnZXMKICAgICAobGV0ICgoc3Rh cnQgKHBvaW50KSkKLS0gCjIuMTcuMQoK --000000000000eb73ce058cb3417f-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 02 14:26:14 2019 Received: (at 36475) by debbugs.gnu.org; 2 Jul 2019 18:26:15 +0000 Received: from localhost ([127.0.0.1]:47914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiNTq-0000md-NR for submit@debbugs.gnu.org; Tue, 02 Jul 2019 14:26:14 -0400 Received: from mout.gmx.net ([212.227.17.21]:40997) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiNTo-0000mO-TC for 36475@debbugs.gnu.org; Tue, 02 Jul 2019 14:26:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1562091965; bh=oRRO97LxLEyzYgjwKqUZsFXDRPJK8zG0QliQNc3756Y=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=ZpbG9oz89LVJB2hQp8qJjH2/EBbHQ3CICQL1XWk1DnmFgRpFnZWatHQo4yadajqNm WkA5YY8R30xkNbL9v7ish4LZLd/hu6XkNPNa46EgxGTY2mS6BVYudeLu44dIqPHvBN Smcgxb+K7iVVobzmbSELYaNTmtpjZb/Zg73bXDcw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.91.242.238]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LorB9-1iA2WE10At-00gtAf; Tue, 02 Jul 2019 20:26:05 +0200 From: Michael Albinus To: Nicholas Drozd Subject: Re: bug#36475: [PATCH] Handle 'abbr' and 'acronym' tags in shr.el References: Date: Tue, 02 Jul 2019 20:26:02 +0200 In-Reply-To: (Nicholas Drozd's message of "Tue, 2 Jul 2019 09:06:43 -0500") Message-ID: <87woh0l2dh.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:cgx4K36dyOqGuZjX6OePlu+gZhs7fzFogpMxnYeMFEpcC7TdHiA 4ON4TRjygytZRPkaa4So2ktKN0eDxCOUw/tSubvT67dC8rfami48PbnC4CoMND6eQPF/qFf +dfTv5hvkrwMQ8pujEyHsCLEBMgDJJcLdHxKqk29hAx4janPnaqgfXahI806nhN54qRpUU4 rPuwrqQ4o7MOGyg27Dkvg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:PYYKIe+Cnhw=:4nEN4iYFYSZXWSMFU8Co34 C+0RKAyRkns+SFUzVxoLeozIugR0fABVwRmOHfD3hhg9qaKMbV7rAwpDRHRr6V0TKsWrxygUp oaNd9PFA4Rgp5H0M57ifksR7tdox9+FiPPc25x6lF7QM8gIRch7Zl1zcMWlUQVYE7+gtWmx9q gp67TCzu/hkro8bF41w9hNr6wypdkwSZOYsytxsABbwt7k8tygdHIodOqP5sw+2lim00QVtT4 TnmOppm7TD7pRn3HvqKsGK6xLi3+0X3Sl7p+dZrfzH/6qlHV20rWeK9zqSZlarljcuFhQwSMY eBo3Q51Zg5jhLWKGxzc0uCFCzspRvjy46j4HGljshQTF4lzdJz+OeSXTfY4uf4iWbTxJsH7Nb QIyTVBQe0rd2VSVcYck8GfS8nQvJU1teXz7ANyv+NEBPfxNh2RfDz5gIrCj6nOZxhoTWf5y75 cF+fkIgpyTCVhBee4HRx6ZjZn1xgsykTc8Bxaht5Got6XZjTdiOqZpLEIi2EYjjgLDclYPtNP YV1whcoNGOPg0SgErrOQQX6kkyHd6n+MF7E7RMYVGBvD3yUdA+ct0WlXAefO29/Np7JcsiYCu qfBEHpR8uhb8pbRsfANl76UqqYMf5YIhZAmMyMMMWw4b6pCSjg2pPEyFrjl/BjtQZBQegg+7h IW9LuvzwPTTfnU6TDDka84jT9pFe3RjoGfk3BnR1U1osOEvZrOURR3ZpIqDwA5/cor+e7mjyN +4GP0BzwibXLkUD2DNxcWf5jBETf28b5Q5N22DqlrEEDXlSKbdOhzDb5EipDGuR7Rr2B+jBEK BqJWampZSxfFyHxemP5caprNwh9qi5K2a9+qj0nnA3o/RXuO8W2dMT4YnCJpLnTl6QRRFxlQG 8PktOzcTV2WVVST5qZvYslDai24fOa2XcnK3gsrvBJRsPb6in+K1deKiWasSoy7kqZhegc+4n vfFqRi4tpFoV36boWxkvfvQLPaSnGIjMjDqZRZqKqWRYnJvM1S28cX+61PR7eFpvnaLsmmIif Vq2qzb0q5M7IOXUfg/bKZn+uQpmPajaXtZ3AsgWRCNjNUN4la+FPkao8ZPsM9aMz5PDbp4U+4 R9vGb5ySKvpNetb3EAc4A/Hj2GTUD5/XSjf X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 36475 Cc: 36475@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Nicholas Drozd writes: > +(defun shr-tag-abbr (dom) > + (let ((title (dom-attr dom 'title)) > + (start (point))) > + (shr-generic dom) > + (shr-add-font start (point) 'diary) > + (add-text-properties > + start (point) > + (list > + 'help-echo title > + 'mouse-face 'highlight)))) > + > +(defun shr-tag-acronym (dom) > + ;; `acronym' is deprecated in favor of `abbr'. > + (shr-tag-abbr dom)) Couldn't this be a defalias? Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 02 19:11:25 2019 Received: (at 36475) by debbugs.gnu.org; 2 Jul 2019 23:11:25 +0000 Received: from localhost ([127.0.0.1]:48146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiRvp-0007oa-0f for submit@debbugs.gnu.org; Tue, 02 Jul 2019 19:11:25 -0400 Received: from mail-ot1-f51.google.com ([209.85.210.51]:37489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiRvm-0007oL-3W for 36475@debbugs.gnu.org; Tue, 02 Jul 2019 19:11:24 -0400 Received: by mail-ot1-f51.google.com with SMTP id s20so306103otp.4 for <36475@debbugs.gnu.org>; Tue, 02 Jul 2019 16:11:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NHxmLu6Bvd7pSkU+VhPwsaD6AmtIZdA22vOBuTFw2xE=; b=IGPCXgtWroVI1TG+OpCKxkNFPkbzQYqDQdz+0FWHaxl4meDUikH5W2ROCvIFCIlRg4 jmuT+P254/XBlzNRQkFt0GUFt2DAZu5E4Ek6kN/GH4mBBGbhaiBoKAT3nRPLO7w2DXwp wdKfeoQrHwwrY/JPGfcbi5tMoSL8fKmIP8vR0X+fl7P6/m9aKhP4XDkZI9tqztG+0OpE q94UvA3cBl2hVQZQl7m2PJxZJKN14p8nqtUzEZ03EHjZGNChtZyb7khOAqY/Rkw5v88m nzzD9rfqxftxd6y8dBuKgnAOwhxcrVxdQM75webhhv3iQFNR7v1qnvh24Muy8lArq0EH XXwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NHxmLu6Bvd7pSkU+VhPwsaD6AmtIZdA22vOBuTFw2xE=; b=HRf5eGrJxrMYlzGdsbcLiYRy/rwzwD6Usk/HD+UV2C2IVN7iJVgHpdxJ7qkh+PzAQY hpnMDB09SB2dlUg4CHiiX2tm9ZV+mmPI2e8oA2+QZkl8Or2NWnMKuQGKYbO3aFp6MrbS V1XC5dFevClIbXVC7/khCii/3fn+mWZwGhnvYJUhhofI7M8YzsRbVqvGz1xCWcMZ6xgD cJIRW7odSKAIv+qz+D5c8Mm1midBk/QkpSPXi4vB7zUOipx4Z2BTnoCjNkV9wVoPfzaI pVjLN/F2Dvu+ASxaJpqy43inh2DtauZrkckFfM44eT8ygWZKowT74ZgV/IktQ7sOIrGx vMBg== X-Gm-Message-State: APjAAAUkdJJ8PBc6+6swsHEiw6xZo2wouk0XQvoqBJLRh4y8dTMWSjzY s4Nw3Eu+jntOe5sehY2Hweaus/hg9GE8PDGonZY= X-Google-Smtp-Source: APXvYqwiuu+ZSJwNI0XpewSIaTujTgTLSm3gh0Reo2ATqrS+QBAoJAjS9nz36xiwQT8kAf54rhlHBCNQhNC7qCVaVt4= X-Received: by 2002:a9d:71c1:: with SMTP id z1mr19517081otj.131.1562109076125; Tue, 02 Jul 2019 16:11:16 -0700 (PDT) MIME-Version: 1.0 References: <87woh0l2dh.fsf@gmx.de> In-Reply-To: <87woh0l2dh.fsf@gmx.de> From: Nicholas Drozd Date: Tue, 2 Jul 2019 18:11:03 -0500 Message-ID: Subject: Re: bug#36475: [PATCH] Handle 'abbr' and 'acronym' tags in shr.el To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36475 Cc: 36475@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) It could be, but I don't know that much would be gained. While a defalias would be slightly terser, it would also stick out from the surrounding defuns. I don't have a strong opinion either way. Are there any non-style considerations? From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 03 02:42:38 2019 Received: (at 36475) by debbugs.gnu.org; 3 Jul 2019 06:42:38 +0000 Received: from localhost ([127.0.0.1]:48334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiYyU-0001qL-9I for submit@debbugs.gnu.org; Wed, 03 Jul 2019 02:42:38 -0400 Received: from mout.gmx.net ([212.227.15.19]:32825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiYyS-0001qA-U3 for 36475@debbugs.gnu.org; Wed, 03 Jul 2019 02:42:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1562136150; bh=O23Xu67FB+O6GrF5B8CSaoiodL9FebaBsjM2IODaOk8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=eHr0Sgx8laukYYg5U6hsTu1L0EoWlNLb9UagF7g7Sz0lKTZd/M9mBvTVZMy3Kr+/S HUCAcYKcybnCw8uIHHIcfpSwtQP8NOJmPpst8ohcWXF9foPkknfTmSl7ftgiMv3hPr vJ2ThnalygPIZknCrf2Oxs4yuaDwnrxQt+m7nN0c= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([217.70.140.33]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N6bfw-1ib7Cl3OZy-0185pR; Wed, 03 Jul 2019 08:42:29 +0200 From: Michael Albinus To: Nicholas Drozd Subject: Re: bug#36475: [PATCH] Handle 'abbr' and 'acronym' tags in shr.el In-Reply-To: (Nicholas Drozd's message of "Tue, 2 Jul 2019 18:11:03 -0500") References: <87woh0l2dh.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Wed, 03 Jul 2019 08:42:26 +0200 Message-ID: <875zoj1uwd.fsf@gmx.de> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:TcXyNCN0Bf/HDfauX/wxrqFdNLsUXmIDDRlNovtc8nU751nMUcH RbohYIg358V4A+SaGHsOPE4KrQZJQjDF9x6IuzsNP4K0LBQ2SziwLZSzmsJPA9jp1Terwo5 3wNf5vq1MwNfNiWHXLLnA8G32ZJQPPNaqPpt/dDQLRjPt+Amy2Seru2EhcZ59QfQRis6IvE M75BzdoLZVBeZ3xpFbALQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:U8V9K6tHZdo=:yS3qPUitthHNnzZKV9M5bz HRiw2BREoQM9rfWUsnvjvkpZi5FUhvIlMWOhno7anaimNzPn/Efu0VekxlxRwHUM4XIu0hrLG iipZaT2vRNNXmApS3ldxVMLL1Jy6bZOQmkw8kF/RK0FHNZu+Lic4ptDLvF2Sj95kQBNh3/Vsm aBOaEnBTVyacdcwGqt9wdkBWQnOpKdZJTeCIIEws1CaHLHk4jiPROTzro9f+ok2Dw6d7vjlTV mWSz1jr7es9b/LUywP3/t5NoXz2ZCYa2gVhT197GobmXfPR+mLGrP9u9uDwPAlY78d/aoZ6lm UAFIXr66RVnWffUyfNH/3g0N5pCjPuq4DcJH5mHxuZMf+/uuLH7+ZmXga+ULnVLhvYURPsM7J ddWSaxRcMjysUPVOdAyrY7KI103+5H0TcSCufrkAqEKsBO4GhlsT5MAE92+K9YhB4HtHJieIP sjXpOU/Hi9XwGA+8kJk3er2GJCQb4JAogt5ktjSrsgFzQRhYULphnXF9L406fhgFWp1/Z0eIv VdSfxZoZ92nKdyYtazLTBEozxcuPjCMmIe98sE+539Hl9Z4mwFBAzTK40e3Q1/mDqbfqK0gAB 4kyt6DwxsBgoilOe9Ntk126YwyZ4DLshnYXB4TH2Cfcuy9O7SzwFg31jadQyVTr/lA7TOLRHh oTS3HQYjt+1EhsFq2OeDdmUUFz1MtpB6TsW6dSZffKBwtM7e1F/06QCTORCDAGOwvt07YDcRX 04QOdCmtpxX7gl6SRXRNQAD50Py4eJ0u/bJORKCPS5/6rckAElY4/Dg/2X25njlf2uW2iS5dw ihwD3/HLtS7RZkp4TgFDkoVa5UMR0apgzB8PEBljIRv+Wu0OETGK0PFjqomw37pPBy02OMahJ h0bDUhM6q7doCaEjFkzt3TrhcERBwmqfKf5n8TN41dV2A5/V8HMOsoyXGSRGvd6eBb2S13hak gIP0Keu/fyIggS4+i0yR65kWaU8PctQZ3rVMF2XoHffittfIp5DysEw+OJ97OsxhcoDj/J9w4 ZMyo9fEmW8hlzfoYpnXpeawnYvcyoBDLX80FIBp30G34kMJfYaSMOsK3NexY9iJONt494izxm lR0E0jafm4jkLfgwOFr2BAx5m7KLLEeKXWJ X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36475 Cc: 36475@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Nicholas Drozd writes: Hi Nicholas, > It could be, but I don't know that much would be gained. While a > defalias would be slightly terser, it would also stick out from the > surrounding defuns. I don't have a strong opinion either way. Are > there any non-style considerations? I have no strong opinion either, but using a defalias seems to me the better choice. Maybe I'm biased due to the work on Tramp, where a large part of the job is keeping backward compatibility with older Emacsen. That's why I have a preference to defalias, whenever possible. It needs less maintainership attention. But it is your decision, of course. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 03 16:17:46 2019 Received: (at 36475) by debbugs.gnu.org; 3 Jul 2019 20:17:46 +0000 Received: from localhost ([127.0.0.1]:50134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hilhJ-0000vA-Mm for submit@debbugs.gnu.org; Wed, 03 Jul 2019 16:17:45 -0400 Received: from mail-ot1-f52.google.com ([209.85.210.52]:33012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hilhH-0000uu-1H for 36475@debbugs.gnu.org; Wed, 03 Jul 2019 16:17:44 -0400 Received: by mail-ot1-f52.google.com with SMTP id q20so3748140otl.0 for <36475@debbugs.gnu.org>; Wed, 03 Jul 2019 13:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MpLQ13IbJvuvC5nkwbFNG2ZCo8/U5msIEpujdH3mluE=; b=fVD/67Xmi72GSH4GZ6ExQNLNf97myP6oFoQCtya4IiQWjlyqBweUqKqQemnX9w9Jqt 8JpVhzVBnjTkgvQPHsHqLlb5qRHNq3joOQFkPIdtGOsYqhKf1hgdmOOhpIDegKSuVbzJ hW3SmTcf5MF3xTWz439Q+dfMwQFcEaQap4bjE1s68uzIRjeOTavzrs6XPwKhr9HAgSEI HKy+FAspHCLQaeAj8MVaZDPOwFtx6ozTr1d4OX4FCz4QHlaAOqcXARwZLuErdaCWwUvo eVmTXXH6BO/FQZBdwjcYuyBkzn+iAL+pQOV0SZbK2V/8iEFzNUJrvq9OTgXiJKZNCyT8 xNHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MpLQ13IbJvuvC5nkwbFNG2ZCo8/U5msIEpujdH3mluE=; b=PLxrLf2Hx5Y9Cb/uT5xjtbmKVl00DfknNJflPMpcNdlLd2VrIrs077b3ijW3A7dEN6 f88hhMew8Y0UVz4YiBNIkQsVnAAwULGJsEiRADjmQIk4Jo6vkCiTgmFmUOaBAGcZVKxn f8ErwjcUZQt5S0c5ei7XxQjo5IHEnOGB1QqD9xarxumRNQv6zGObSLsLLpYmrkH0fQbv A3iC9bBFaMFfXfrgSrsosphaKpJt8UQMGJgY6lVZta3xrBpnuKf4zWvy49DqA3BiKEY7 v4wz2GSl2IZ/ifJwZqfy86ovu2rp4Y+FcUyOR0z0PKBDlMvFkJfyvDaG3C433N4XUWUM qpww== X-Gm-Message-State: APjAAAX3hHg7RykXpG1panAOb6qJYYT2wh8tyCYk1w6JIFkYAIxxoyi6 QvTU02Go2WhNRJnB/PUEX69RbFYLdKaE2kZWYj4= X-Google-Smtp-Source: APXvYqwu9Edome234tEpUYOf8fN6kVfBVVgoF6BItyBm6qWBlJCVcFV73+dL4mNBuofF4FUzVgquPpCGmI2Qp4VzJSQ= X-Received: by 2002:a9d:624b:: with SMTP id i11mr32729790otk.23.1562185056917; Wed, 03 Jul 2019 13:17:36 -0700 (PDT) MIME-Version: 1.0 References: <87woh0l2dh.fsf@gmx.de> <875zoj1uwd.fsf@gmx.de> In-Reply-To: <875zoj1uwd.fsf@gmx.de> From: Nicholas Drozd Date: Wed, 3 Jul 2019 15:17:24 -0500 Message-ID: Subject: Re: bug#36475: [PATCH] Handle 'abbr' and 'acronym' tags in shr.el To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36475 Cc: 36475@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Let's leave it as a defun for now then, and anyone who objects can change it later (probably without any consequence). shr-tag-tt does the same thing, deferring to shr-tag-code, so shr-tag-tt and shr-tag-acronym can be changed together. On Wed, Jul 3, 2019 at 1:42 AM Michael Albinus wrote: > > Nicholas Drozd writes: > > Hi Nicholas, > > > It could be, but I don't know that much would be gained. While a > > defalias would be slightly terser, it would also stick out from the > > surrounding defuns. I don't have a strong opinion either way. Are > > there any non-style considerations? > > I have no strong opinion either, but using a defalias seems to me the > better choice. Maybe I'm biased due to the work on Tramp, where a large > part of the job is keeping backward compatibility with older > Emacsen. That's why I have a preference to defalias, whenever > possible. It needs less maintainership attention. > > But it is your decision, of course. > > Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 04 15:40:29 2019 Received: (at 36475) by debbugs.gnu.org; 4 Jul 2019 19:40:29 +0000 Received: from localhost ([127.0.0.1]:51940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hj7am-000543-La for submit@debbugs.gnu.org; Thu, 04 Jul 2019 15:40:29 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:44633) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hj7aj-00053g-SG for 36475@debbugs.gnu.org; Thu, 04 Jul 2019 15:40:26 -0400 Received: by mail-ed1-f66.google.com with SMTP id k8so6239245edr.11 for <36475@debbugs.gnu.org>; Thu, 04 Jul 2019 12:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=MaqG+ZWll8fpHMPJW2faW/QQ/78mtGiGf7uGSggBIXk=; b=comQUQvmP+kaC5KRs//L+y0M+IrSq55H0hF0iHHOCqzK+420n7V4+zoUUNiEfI0HQ8 RlzZc2te0njvYGXRp5mCcPAk8KLZT1ycgc0c83vLOZcXbs3wPu0rST6+61bOOo5Ckqsz vplr1bNYPuLksqvZ6Lrg/lAiLBk/VzmcboxpvK7zWFwIT+TLU9wkaPPInNiuSBIq/QZt qwi6NgkZEjT5fr1IHBMwQTFkoiF5uuuYyNMDWoXpnrOMMSapBWTyZOIHpiEUb5Xm1dhv EBEErLM4slRHoKTe9r6GMHgSoYrq5P53FjQtEe4Ca1ooH2UjJP4adYhqQHttLG6O0G5V YG2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=MaqG+ZWll8fpHMPJW2faW/QQ/78mtGiGf7uGSggBIXk=; b=fK2rmjbke2Fl3LkFkbtslAW3a060E92w2fPA9uSj9hjZBANhj6Euhez08fZLwyI1Ej gzE0dVmkzYU6mQWlt38s0+kIlRjt1UycsstH2R9oPfyruepn5/Kk0ZLi8htuDJPESnFy Xz6uHJqK6FOkRAtz7/QSY/MqtsT63X6/vXkmUR61nEgK8vplk5l1Lsb2E0iZ9vOVz+/c e3YhpoQVElIY1DGN4Bu5N5jcH8NCrm4Hzw6CZlsZ7YtO5lowANFP6fv4K6/VnNWN5Z7R PrhhjBgIZ2TlPbxyKGmvrsegKw/4faepG93zr60uUArTjMXgk6lJMlnkfZz6K9DZN/l9 8gzw== X-Gm-Message-State: APjAAAXjQvWyJg93I7MU4OPm8U54e6EokIPzqD6d3D/HptVsNtw9QBIj b/X7jTqyPYsvpcIj19G748o96Q== X-Google-Smtp-Source: APXvYqzhai0DF95f846t2I4DB3FUTV/bcMmlgWKnn3a1+6xwfGEJ0m2xFhAeIvPrSdfX87AEamcHmA== X-Received: by 2002:a17:906:2191:: with SMTP id 17mr40929741eju.157.1562269219815; Thu, 04 Jul 2019 12:40:19 -0700 (PDT) Received: from localhost ([86.43.118.33]) by smtp.gmail.com with ESMTPSA id k8sm167670edr.31.2019.07.04.12.40.18 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 04 Jul 2019 12:40:18 -0700 (PDT) From: "Basil L. Contovounesios" To: Nicholas Drozd Subject: Re: bug#36475: [PATCH] Handle 'abbr' and 'acronym' tags in shr.el References: Date: Thu, 04 Jul 2019 20:40:12 +0100 In-Reply-To: (Nicholas Drozd's message of "Tue, 2 Jul 2019 09:06:43 -0500") Message-ID: <87y31dtwpv.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36475 Cc: Lars Ingebrigtsen , 36475@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 36475 wishlist quit Nicholas Drozd writes: > I came across some `abbr` tags in the wild: check out the first > paragraph of http://mindprod.com/jgloss/unmainobfuscation.html. EWW > doesn't handle those, so here is a patch for that. > > My understanding is that there is also an `acronym` tag which has been > deprecated in favor of `abbr`. I figured we might as well cover that > one too just in case. +1. > I picked the `diary` face for abbreviations, but that choice didn't > have a lot of thought put into it. Whoever commits can choose > something else. Indeed I don't think the 'diary' face is a very good fit. Not only is it undefined unless calendar.el is loaded, but it also has a quite jarring red/yellow foreground by default, and bears no relation to abbreviations. The major browsers use a dotted underline, and text in Emacs that has a 'help-echo' property is usually fontified with a face inheriting from 'link' (outside of the mode line, images, and buttons, of course). So my suggestion is to provide a new face inheriting from either 'shr-link', 'link', or 'underline'. Personally, I would also add ':underline (:style wave)', as it reminds me of the dotted underline in external browsers: (defface shr-abbreviation '((t :inherit underline :underline (:style wave))) "Face for elements.") Thoughts? Lars? > Let's try to get this merged ASAP. > > From a720473ad1001d3a72f9b3f3155f5488726cabde Mon Sep 17 00:00:00 2001 > From: Nick Drozd > Date: Mon, 1 Jul 2019 23:46:10 -0500 > Subject: [PATCH] Handle 'abbr' and 'acronym' tags in shr.el > > * lisp/net/shr.el: Add 'abbr' and 'acronym' tag handling. Nit: I think this should list the new functions, as per usual: * lisp/net/shr.el (shr-tag-abbr, shr-tag-acronym): New functions handling 'abbr' and 'acronym' tags, respectively. > * etc/NEWS: Announce change in shr behavrior. > --- > etc/NEWS | 3 +++ > lisp/net/shr.el | 15 +++++++++++++++ > 2 files changed, 18 insertions(+) > > diff --git a/etc/NEWS b/etc/NEWS > index abbece374a..464dae2454 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -989,6 +989,9 @@ This attribute is meant to tell screen readers to ignore a tag. > --- > *** The tag is now handled. > > +--- > +*** The and tags are now handled. > + I suggest announcing all new tags (i.e. including ) in a single NEWS entry. > ** Htmlfontify > > *** The functions 'hfy-color', 'hfy-color-vals' and > diff --git a/lisp/net/shr.el b/lisp/net/shr.el > index 7fdb3212d4..3af3db637a 100644 > --- a/lisp/net/shr.el > +++ b/lisp/net/shr.el > @@ -1470,6 +1470,21 @@ shr-tag-a > (when url > (shr-urlify (or shr-start start) (shr-expand-url url) title)))) > > +(defun shr-tag-abbr (dom) > + (let ((title (dom-attr dom 'title)) > + (start (point))) > + (shr-generic dom) > + (shr-add-font start (point) 'diary) > + (add-text-properties > + start (point) > + (list > + 'help-echo title > + 'mouse-face 'highlight)))) According to Mozilla[1], the 'title' attribute is optional, so perhaps we should avoid this fontification if the attribute is missing, which is what Firefox and Chromium seem do. [1]: https://developer.mozilla.org/en/docs/Web/HTML/Element/abbr Apart from these minor comments, LGTM. Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 09:03:44 2019 Received: (at 36475) by debbugs.gnu.org; 5 Jul 2019 13:03:44 +0000 Received: from localhost ([127.0.0.1]:52500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjNsO-0000XS-K1 for submit@debbugs.gnu.org; Fri, 05 Jul 2019 09:03:44 -0400 Received: from quimby.gnus.org ([80.91.231.51]:33142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjNsN-0000XK-7o for 36475@debbugs.gnu.org; Fri, 05 Jul 2019 09:03:43 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hjNsK-0007u6-09; Fri, 05 Jul 2019 15:03:42 +0200 From: Lars Ingebrigtsen To: "Basil L. Contovounesios" Subject: Re: bug#36475: [PATCH] Handle 'abbr' and 'acronym' tags in shr.el References: <87y31dtwpv.fsf@tcd.ie> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAIVBMVEUKDUgAAEsAAU36+ARM S0QAAE+ujyb//wAAAE3+/wjWxRnUA99JAAACNklEQVQ4jbXSQYvaQBQA4FFCK3sypYUcNegiPW3J krA5RXc6LZ5scMCjNdPZklMhxYAnIwbmuNBTb7aRCPmVfZNJXN312gdxzHy+vPG9oLvfL+JO7iE3 DHkRhnkRFnkBEeSw8jxDFtxk6nLlIr/LFTnx5fg/YOP7SxAxRMgFsD0ti6ML4IXPa8CVY0xevSge R3NdbzOtcJ7DTjeSZH4Vu+HhHIYSWnCgaE+yMzAEhKwRjbpPhOI9wEysA7hZDYVOnOOpvhoyJyFw 4BshfO1Qw6NQscZ8NBOztPdQwU9xGjSl00MFZXXRKj/TNKUTLVAwKLe+1yl0yr0HCUuMMSQtyu0+ pXQSu0HZK9nc4WZnqEcBFE5UQ/xD36knAfhZwfERkoYhjColiG9JDR/anxORrKEJAFpomzX8WUPG ZtQsy/sdTwGMdGG2NRKuVvNm3/fpxlSwul/x0FKpt32fUrOC5cmIIsZMUz4qsyzr1/lUbW8c5UiH QBrhYXauSDdUD990tNPJSpADlDHYdE8M6QPoJ4ULNPXNznG0bzH2MJ4ATBBu+NTUnAoYY5xxMsWe 6Gqe1zSvasCYzxmZcjaDsX4hDB1UjX4HaTAqzJmcN30f79XLoMtWz6A++ihPAbB4rUBK2Wz5ewnf PlVgXGPUkLtlRs9ZKGjo7SAuxgxpLeG/o+nE2akaNibQcCdys127t+/TrfO3ehMdq27qOHTng21c w9Mk4C8vzW18o8CCW5tzaLvMXBrXFfwDmRTVdnC3Ri4AAAAASUVORK5CYII= Date: Fri, 05 Jul 2019 15:03:39 +0200 In-Reply-To: <87y31dtwpv.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 04 Jul 2019 20:40:12 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "Basil L. Contovounesios" writes: > (defface shr-abbreviation > '((t :inherit underline :underline (:style wave))) > "Face for elements.") > > Thoughts? Lars? Sounds good. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36475 Cc: 36475@debbugs.gnu.org, Nicholas Drozd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Basil L. Contovounesios" writes: > (defface shr-abbreviation > '((t :inherit underline :underline (:style wave))) > "Face for elements.") > > Thoughts? Lars? Sounds good. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 12:36:25 2019 Received: (at 36475) by debbugs.gnu.org; 5 Jul 2019 16:36:25 +0000 Received: from localhost ([127.0.0.1]:53650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjRCC-0008QH-PP for submit@debbugs.gnu.org; Fri, 05 Jul 2019 12:36:25 -0400 Received: from mail-oi1-f174.google.com ([209.85.167.174]:37735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjRCA-0008Q2-SN for 36475@debbugs.gnu.org; Fri, 05 Jul 2019 12:36:23 -0400 Received: by mail-oi1-f174.google.com with SMTP id t76so7554820oih.4 for <36475@debbugs.gnu.org>; Fri, 05 Jul 2019 09:36:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2Pl3ws+pSakuYAOftnq6h6DSQ1aeuPJkSejTa0MW15c=; b=Q2izJrx3V08wwAmXNGmKuKNGELihkpEU+XosK/cFlKv6t0+VKRCmcJi4Dh28YVvsb/ ipQeGeVZ1+izrxlb2HLrKVNIGbdVZivZXBoIX6XhR7p5G3Xp6aAZvFKChHdZSAGfCea7 QPINjzUcKoY6yq6Ila6AWbZE2C9LFBJ6pVPfVa7fXe/5WdZV3WSxq7Q4SNh/O7hEvp1b En6c+Rk7OanQoeIK3In4m4QVL/jovmx3upfb/BRuc3/eSJ3oOBBDyhGPqGoIVycPfMAA nx5HTDTkSBeARCEcVPp2nAPgYL69g6aBLnmAuw80MsCbq0N0/WuY8cc/wSx0BDP17LDh Y0dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2Pl3ws+pSakuYAOftnq6h6DSQ1aeuPJkSejTa0MW15c=; b=L1+jvM8gJAa9259kcVVKmXoMywzzaYSuA5qAxmXv1Hn3vHIHfwt/gtE5m2fzqs8n0R asDF+JOjYBv8AYLw383a8PGJa0XdiAD2JDHfUeSWVIg4DBIeee6SioeEPasiEAYqCHxH WhyLuhNmo4GH9c1pvKzxIgzA2+17tV93CJkP8XoOmF7k2tSwT/JtNI/a/zLUW6BtwYMz Uu1LAveSZI4IForD0a59mZeXSplppy0C6RuJMV5DjV7nJvoj5+ft1FS4+/Z/UjdZuljs Kmi/774yy/MX4jNbfM7+gvRDBxR34q8tgtRjuzEPQoIIDqK1SHWrhncV/l1ymIFqtbzr h9rQ== X-Gm-Message-State: APjAAAV4eUbCPO67r8+izBM/kscbTE0273o08yp8mlLYaFx/Pa4y8k2s /kwCZxx61SSFu3Yvij23pMynRFuUgxEWvt0x49o= X-Google-Smtp-Source: APXvYqzxnXBxeh8p4y213+8AJ79HVTi14C3IMiXHbQF+mBjwGTp/JQk1ZspZfbD6RSC4rNKwOxBRA4drYWxV2PgK4sA= X-Received: by 2002:aca:ad54:: with SMTP id w81mr2670321oie.86.1562344576720; Fri, 05 Jul 2019 09:36:16 -0700 (PDT) MIME-Version: 1.0 References: <87y31dtwpv.fsf@tcd.ie> In-Reply-To: <87y31dtwpv.fsf@tcd.ie> From: Nicholas Drozd Date: Fri, 5 Jul 2019 12:36:04 -0400 Message-ID: Subject: Re: bug#36475: [PATCH] Handle 'abbr' and 'acronym' tags in shr.el To: "Basil L. Contovounesios" Content-Type: multipart/mixed; boundary="000000000000834154058cf1b1e0" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36475 Cc: Lars Ingebrigtsen , 36475@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000834154058cf1b1e0 Content-Type: text/plain; charset="UTF-8" Thanks for the comments, Basil. Attached is a revised patch that covers everything AFAICT. --000000000000834154058cf1b1e0 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Handle-abbr-and-acronym-tags-in-shr.el.patch" Content-Disposition: attachment; filename="0001-Handle-abbr-and-acronym-tags-in-shr.el.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxqbff720 RnJvbSAwNWNjMTQ2NDFmYTdmMTkzZWJjZGI2NTQ4YzAzZTI5M2I0NTExZDQ3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNrIERyb3pkIDxuaWNob2xhc2Ryb3pkQGdtYWlsLmNvbT4K RGF0ZTogTW9uLCAxIEp1bCAyMDE5IDIzOjQ2OjEwIC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gSGFu ZGxlICdhYmJyJyBhbmQgJ2Fjcm9ueW0nIHRhZ3MgaW4gc2hyLmVsCgoqIGxpc3AvbmV0L3Noci5l bCAoc2hyLXRhZy1hYmJyLCBzaHItdGFnLWFjcm9ueW0pOiBOZXcgZnVuY3Rpb25zCmhhbmRsaW5n ICdhYmJyJyBhbmQgJ2Fjcm9ueW0nIHRhZ3MsIHJlc3BlY3RpdmVseS4KKiBldGMvTkVXUzogQW5u b3VuY2UgY2hhbmdlIGluIHNociBiZWhhdnJpb3IuCi0tLQogZXRjL05FV1MgICAgICAgIHwgIDIg Ky0KIGxpc3AvbmV0L3Noci5lbCB8IDIxICsrKysrKysrKysrKysrKysrKysrKwogMiBmaWxlcyBj aGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZXRj L05FV1MgYi9ldGMvTkVXUwppbmRleCBhYmJlY2UzNzRhLi44NTJiNmU0OTQ4IDEwMDY0NAotLS0g YS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtOTg3LDcgKzk4Nyw3IEBAIFRoaXMgYXR0cmli dXRlIGlzIG1lYW50IHRvIHRlbGwgc2NyZWVuIHJlYWRlcnMgdG8gaWdub3JlIGEgdGFnLgogKioq ICdzaHItdGFnLW9sJyBub3cgcmVzcGVjdHMgdGhlIG9yZGVyZWQgbGlzdCAnc3RhcnQnIGF0dHJp YnV0ZS4KIAogLS0tCi0qKiogVGhlIDxjb2RlIC4uLj4gdGFnIGlzIG5vdyBoYW5kbGVkLgorKioq IFRoZSBmb2xsb3dpbmcgdGFncyBhcmUgbm93IGhhbmRsZWQ6IDxjb2RlPiwgPGFiYnI+LCBhbmQg PGFjcm9ueW0+LgogCiAqKiBIdG1sZm9udGlmeQogCmRpZmYgLS1naXQgYS9saXNwL25ldC9zaHIu ZWwgYi9saXNwL25ldC9zaHIuZWwKaW5kZXggN2ZkYjMyMTJkNC4uOTg5N2U1OWUxZSAxMDA2NDQK LS0tIGEvbGlzcC9uZXQvc2hyLmVsCisrKyBiL2xpc3AvbmV0L3Noci5lbApAQCAtMTU5LDYgKzE1 OSwxMiBAQCBzaHItc2VsZWN0ZWQtbGluawogICA6dmVyc2lvbiAiMjcuMSIKICAgOmdyb3VwICdz aHIpCiAKKyhkZWZmYWNlIHNoci1hYmJyZXZpYXRpb24KKyAgJygodCA6aW5oZXJpdCB1bmRlcmxp bmUgOnVuZGVybGluZSAoOnN0eWxlIHdhdmUpKSkKKyAgIkZhY2UgZm9yIDxhYmJyPiBlbGVtZW50 cy4iCisgIDp2ZXJzaW9uICIyNy4xIgorICA6Z3JvdXAgJ3NocikKKwogKGRlZnZhciBzaHItaW5o aWJpdC1pbWFnZXMgbmlsCiAgICJJZiBub24tbmlsLCBpbmhpYml0IGxvYWRpbmcgaW1hZ2VzLiIp CiAKQEAgLTE0NzAsNiArMTQ3NiwyMSBAQCBzaHItdGFnLWEKICAgICAod2hlbiB1cmwKICAgICAg IChzaHItdXJsaWZ5IChvciBzaHItc3RhcnQgc3RhcnQpIChzaHItZXhwYW5kLXVybCB1cmwpIHRp dGxlKSkpKQogCisoZGVmdW4gc2hyLXRhZy1hYmJyIChkb20pCisgICh3aGVuLWxldCogKCh0aXRs ZSAoZG9tLWF0dHIgZG9tICd0aXRsZSkpCisJICAgICAgKHN0YXJ0IChwb2ludCkpKQorICAgIChz aHItZ2VuZXJpYyBkb20pCisgICAgKHNoci1hZGQtZm9udCBzdGFydCAocG9pbnQpICdzaHItYWJi cmV2aWF0aW9uKQorICAgIChhZGQtdGV4dC1wcm9wZXJ0aWVzCisgICAgIHN0YXJ0IChwb2ludCkK KyAgICAgKGxpc3QKKyAgICAgICdoZWxwLWVjaG8gdGl0bGUKKyAgICAgICdtb3VzZS1mYWNlICdo aWdobGlnaHQpKSkpCisKKyhkZWZ1biBzaHItdGFnLWFjcm9ueW0gKGRvbSkKKyAgOzsgYGFjcm9u eW0nIGlzIGRlcHJlY2F0ZWQgaW4gZmF2b3Igb2YgYGFiYnInLgorICAoc2hyLXRhZy1hYmJyIGRv bSkpCisKIChkZWZ1biBzaHItdGFnLW9iamVjdCAoZG9tKQogICAodW5sZXNzIHNoci1pbmhpYml0 LWltYWdlcwogICAgIChsZXQgKChzdGFydCAocG9pbnQpKQotLSAKMi4xNy4xCgo= --000000000000834154058cf1b1e0-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 06 08:03:06 2019 Received: (at 36475) by debbugs.gnu.org; 6 Jul 2019 12:03:07 +0000 Received: from localhost ([127.0.0.1]:54318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjjPE-0002Yv-QD for submit@debbugs.gnu.org; Sat, 06 Jul 2019 08:03:05 -0400 Received: from quimby.gnus.org ([80.91.231.51]:51432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjjPD-0002Yn-CX for 36475@debbugs.gnu.org; Sat, 06 Jul 2019 08:03:03 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hjjP8-0004Hy-Me; Sat, 06 Jul 2019 14:03:01 +0200 From: Lars Ingebrigtsen To: Nicholas Drozd Subject: Re: bug#36475: [PATCH] Handle 'abbr' and 'acronym' tags in shr.el References: <87y31dtwpv.fsf@tcd.ie> Date: Sat, 06 Jul 2019 14:02:58 +0200 In-Reply-To: (Nicholas Drozd's message of "Fri, 5 Jul 2019 12:36:04 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Nicholas Drozd writes: > Thanks for the comments, Basil. Attached is a revised patch that > covers everything AFAICT. Looks good; I've now applied this to trunk. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36475 Cc: "Basil L. Contovounesios" , 36475@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Nicholas Drozd writes: > Thanks for the comments, Basil. Attached is a revised patch that > covers everything AFAICT. Looks good; I've now applied this to trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 06 08:03:12 2019 Received: (at control) by debbugs.gnu.org; 6 Jul 2019 12:03:12 +0000 Received: from localhost ([127.0.0.1]:54321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjjPL-0002ZH-VZ for submit@debbugs.gnu.org; Sat, 06 Jul 2019 08:03:12 -0400 Received: from quimby.gnus.org ([80.91.231.51]:51448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjjPK-0002Z9-Oy for control@debbugs.gnu.org; Sat, 06 Jul 2019 08:03:11 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hjjPI-0004I9-7q for control@debbugs.gnu.org; Sat, 06 Jul 2019 14:03:10 +0200 Date: Sat, 06 Jul 2019 14:03:07 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #36475 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 36475 fixed close 36475 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 36475 fixed close 36475 27.1 quit From unknown Sat Jun 14 19:45:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 04 Aug 2019 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator