GNU bug report logs - #36467
[PATCH 00/12] gnu: Add some Common Lisp libraries

Previous Next

Full log

Message #50 received at 36467 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Ludovic Courtès <ludo <at> gnu.org>, Guillaume Le Vaillant
 <glv <at> posteo.net>
Cc: Andy Patterson <ajpatter <at> uwaterloo.ca>,
 Katherine Cox-Buday <cox.katherine.e <at> gmail.com>, 36467 <at> debbugs.gnu.org
Subject: Re: [bug#36467] [PATCH v2] gnu: Add some Common Lisp libraries
Date: Mon, 16 Sep 2019 10:55:48 +0200

[Message part 1 (text/plain, inline)]

Hi Guillaume,

thanks for the big patchset, looking very good overall!

A few general nits:

- You didn't define any "ecl-" package.  Could you define them for all the
  packages (unless they are known to be broken with ECL)?
  I know some packages lack the ecl- definition, this should be fixed :p

- 6 commit messages lack a period on the first line.
  If you use Emacs, you might find this yasnippet useful:
  guix/etc/snippets/text-mode/guix-commit-message-add-package

fprog:
  - Description should start with a capital, or here maybe with @code{fprog}.

cambl:
  - is spelled in all-caps ("CAMBL") according to the README.

cl-containers:
  - synopsis: "Container library ..."

  - I'm realizing the sbcl-lift does not have the right version number, which
    should be (git-version "1.7.1" ...).  Can you update this?

bst:
  - 1.1 is out ;)

cl-octet-streams:
  - Description should start with a capital, or here maybe with @code{cl-octet-streams}.

cl-lzlib
  - License seems to be GPL-3, not GPL-3+, but since this is your library, the
    decision is all yours ;)

Thanks a lot for this great contribution to "Common Lisp on Guix" :)

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.