GNU bug report logs - #3645
23.0.95; bookmark-jump(-other-window) inconsistencies

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: "Drew Adams" <drew.adams <at> oracle.com>
Subject: bug#3645 closed by Karl Fogel <kfogel <at> red-bean.com> (Fix
 "bookmark-jump(-other-window) inconsistencies")
Date: Fri, 09 Oct 2009 06:05:07 +0000

[Message part 1 (text/plain, inline)]

This is an automatic notification regarding your bug report
which was filed against the emacs package:

#3645: 23.0.95; bookmark-jump(-other-window) inconsistencies

It has been closed by Karl Fogel <kfogel <at> red-bean.com>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Karl Fogel <kfogel <at> red-bean.com> by
replying to this email.


-- 
3645: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3645
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Karl Fogel <kfogel <at> red-bean.com>
To: 3645-close <at> debbugs.gnu.org
Subject: Fix "bookmark-jump(-other-window) inconsistencies"
Date: Fri, 09 Oct 2009 01:56:32 -0400

fixed
--

Thanks for the report.  Fix committed:

  $ cvs ci -F msg lisp/bookmark.el lisp/ChangeLog
  /sources/emacs/emacs/lisp/bookmark.el,v  <--  lisp/bookmark.el
  new revision: 1.132; previous revision: 1.131
  /sources/emacs/emacs/lisp/ChangeLog,v  <--  lisp/ChangeLog
  new revision: 1.16392; previous revision: 1.16391
  Mailing notification to emacs-diffs <at> gnu.org... sent.
  $ 

[Message part 3 (message/rfc822, inline)]

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <emacs-pretest-bug <at> gnu.org>
Subject: 23.0.95; bookmark-jump(-other-window) inconsistencies
Date: Sun, 21 Jun 2009 16:19:02 -0700

bookmark-jump and bookmark-jump-other-window should differ only in the
window they use. But their behaviors are quite different now.  One of
them is wrong.  My guess is that bookmark-jump-other-window never got
updated when some changes were made to bookmark-jump (but it could be
the other way around).
 
bookmark-jump raises an error if the arg is nil;
bookmark-jump-other-window is a no-op in that case.
 
bookmark-jump-other-window treats pre-Emacs 22 bookmarks differently;
bookmark-jump does not.
 
[FWIW - It is unfortunate that bookmark.el has undergone extensive
changes since Emacs 22.  It is barely recognizable now, and it is
quite messy to provide 3rd-party code that works with multiple Emacs
versions.]
 

In GNU Emacs 23.0.95.1 (i386-mingw-nt5.1.2600)
 of 2009-06-19 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'
 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.