From unknown Thu Aug 14 22:19:35 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3645: 23.0.95; bookmark-jump(-other-window) inconsistencies Reply-To: "Drew Adams" , 3645@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 21 Jun 2009 23:25:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 3645 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12456263599397 (code B ref -1); Sun, 21 Jun 2009 23:25:05 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 21 Jun 2009 23:19:19 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.8 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5LNJDJg009377 for ; Sun, 21 Jun 2009 16:19:14 -0700 Received: from mx10.gnu.org ([199.232.76.166]:39769) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MIWJc-00017R-JH for emacs-pretest-bug@gnu.org; Sun, 21 Jun 2009 19:19:12 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MIWJZ-0000k8-SL for emacs-pretest-bug@gnu.org; Sun, 21 Jun 2009 19:19:12 -0400 Received: from rcsinet11.oracle.com ([148.87.113.123]:38038 helo=rgminet11.oracle.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MIWJZ-0000jQ-GH for emacs-pretest-bug@gnu.org; Sun, 21 Jun 2009 19:19:09 -0400 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rgminet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n5LNKCnq008501 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 21 Jun 2009 23:20:14 GMT Received: from abhmt010.oracle.com (abhmt010.oracle.com [141.146.116.19]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n5LNKRGR019167 for ; Sun, 21 Jun 2009 23:20:28 GMT Received: from dradamslap1 (/24.5.177.54) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 21 Jun 2009 16:19:02 -0700 From: "Drew Adams" To: Date: Sun, 21 Jun 2009 16:19:02 -0700 Message-ID: <4D3529570A4C4AFCBFF378475AEAA129@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Acnyxqmmc1UmWCtjRlSaeby45tG1xw== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt010.oracle.com [141.146.116.19] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090207.4A3EBFE6.00FC:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) bookmark-jump and bookmark-jump-other-window should differ only in the window they use. But their behaviors are quite different now. One of them is wrong. My guess is that bookmark-jump-other-window never got updated when some changes were made to bookmark-jump (but it could be the other way around). bookmark-jump raises an error if the arg is nil; bookmark-jump-other-window is a no-op in that case. bookmark-jump-other-window treats pre-Emacs 22 bookmarks differently; bookmark-jump does not. [FWIW - It is unfortunate that bookmark.el has undergone extensive changes since Emacs 22. It is barely recognizable now, and it is quite messy to provide 3rd-party code that works with multiple Emacs versions.] In GNU Emacs 23.0.95.1 (i386-mingw-nt5.1.2600) of 2009-06-19 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)' From unknown Thu Aug 14 22:19:35 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: "Drew Adams" Subject: bug#3645 closed by Karl Fogel (Fix "bookmark-jump(-other-window) inconsistencies") Message-ID: References: <87iqepaz5b.fsf@red-bean.com> <4D3529570A4C4AFCBFF378475AEAA129@us.oracle.com> X-Emacs-PR-Message: they-closed 3645 X-Emacs-PR-Package: emacs Reply-To: 3645@debbugs.gnu.org Date: Fri, 09 Oct 2009 06:05:07 +0000 Content-Type: multipart/mixed; boundary="----------=_1255068307-14183-1" This is a multi-part message in MIME format... ------------=_1255068307-14183-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #3645: 23.0.95; bookmark-jump(-other-window) inconsistencies It has been closed by Karl Fogel . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Karl Fogel by replying to this email. --=20 3645: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D3645 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1255068307-14183-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 3645-close) by emacsbugs.donarmstrong.com; 9 Oct 2009 05:56:35 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sanpietro.red-bean.com (Debian-exim@sanpietro.red-bean.com [66.146.206.141]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n995uX2j013224 for <3645-close@emacsbugs.donarmstrong.com>; Thu, 8 Oct 2009 22:56:34 -0700 Received: from localhost ([127.0.0.1]:36854 helo=floss ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.69) (envelope-from ) id 1Mw8Sv-0004ej-9r for 3645-close@emacsbugs.donarmstrong.com; Fri, 09 Oct 2009 00:56:33 -0500 From: Karl Fogel To: 3645-close@debbugs.gnu.org Subject: Fix "bookmark-jump(-other-window) inconsistencies" Reply-To: Karl Fogel Date: Fri, 09 Oct 2009 01:56:32 -0400 Message-ID: <87iqepaz5b.fsf@red-bean.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii fixed -- Thanks for the report. Fix committed: $ cvs ci -F msg lisp/bookmark.el lisp/ChangeLog /sources/emacs/emacs/lisp/bookmark.el,v <-- lisp/bookmark.el new revision: 1.132; previous revision: 1.131 /sources/emacs/emacs/lisp/ChangeLog,v <-- lisp/ChangeLog new revision: 1.16392; previous revision: 1.16391 Mailing notification to emacs-diffs@gnu.org... sent. $ ------------=_1255068307-14183-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 21 Jun 2009 23:19:19 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.8 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5LNJDJg009377 for ; Sun, 21 Jun 2009 16:19:14 -0700 Received: from mx10.gnu.org ([199.232.76.166]:39769) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MIWJc-00017R-JH for emacs-pretest-bug@gnu.org; Sun, 21 Jun 2009 19:19:12 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MIWJZ-0000k8-SL for emacs-pretest-bug@gnu.org; Sun, 21 Jun 2009 19:19:12 -0400 Received: from rcsinet11.oracle.com ([148.87.113.123]:38038 helo=rgminet11.oracle.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MIWJZ-0000jQ-GH for emacs-pretest-bug@gnu.org; Sun, 21 Jun 2009 19:19:09 -0400 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rgminet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n5LNKCnq008501 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 21 Jun 2009 23:20:14 GMT Received: from abhmt010.oracle.com (abhmt010.oracle.com [141.146.116.19]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n5LNKRGR019167 for ; Sun, 21 Jun 2009 23:20:28 GMT Received: from dradamslap1 (/24.5.177.54) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 21 Jun 2009 16:19:02 -0700 From: "Drew Adams" To: Subject: 23.0.95; bookmark-jump(-other-window) inconsistencies Date: Sun, 21 Jun 2009 16:19:02 -0700 Message-ID: <4D3529570A4C4AFCBFF378475AEAA129@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Acnyxqmmc1UmWCtjRlSaeby45tG1xw== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt010.oracle.com [141.146.116.19] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090207.4A3EBFE6.00FC:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) bookmark-jump and bookmark-jump-other-window should differ only in the window they use. But their behaviors are quite different now. One of them is wrong. My guess is that bookmark-jump-other-window never got updated when some changes were made to bookmark-jump (but it could be the other way around). bookmark-jump raises an error if the arg is nil; bookmark-jump-other-window is a no-op in that case. bookmark-jump-other-window treats pre-Emacs 22 bookmarks differently; bookmark-jump does not. [FWIW - It is unfortunate that bookmark.el has undergone extensive changes since Emacs 22. It is barely recognizable now, and it is quite messy to provide 3rd-party code that works with multiple Emacs versions.] In GNU Emacs 23.0.95.1 (i386-mingw-nt5.1.2600) of 2009-06-19 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)' ------------=_1255068307-14183-1--