From unknown Sun Jun 22 17:14:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36448: 26.2; doc string of `highlight-lines-matching-regexp' Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jun 2019 20:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36448 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 36448@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.156192722222539 (code B ref -1); Sun, 30 Jun 2019 20:41:01 +0000 Received: (at submit) by debbugs.gnu.org; 30 Jun 2019 20:40:22 +0000 Received: from localhost ([127.0.0.1]:47340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhgcY-0005rT-9c for submit@debbugs.gnu.org; Sun, 30 Jun 2019 16:40:22 -0400 Received: from lists.gnu.org ([209.51.188.17]:59992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhgcV-0005rK-7s for submit@debbugs.gnu.org; Sun, 30 Jun 2019 16:40:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34805) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhgcT-0007Ay-Sz for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 16:40:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_MED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhgcS-0005D2-OU for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 16:40:17 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:57146) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hhgcR-0005AI-De for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 16:40:16 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5UKdOYO078687 for ; Sun, 30 Jun 2019 20:40:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=wmyX7TUgpDiFRF/ETBAPJ8KEEx8YqIGwpyUREe4IMLI=; b=zSHdkVSuyziXpgSvJju6WIkTL/vCeC72FKIq+cUXG++c5EDcjkN44mrArIMGvIW3hrD5 yGT7Bhodywdzwr3mMAyxzfap6rStHkiKzR2SaRVdvH3ZnjJtuhmMWeDiFNrQ1X50g2ex m9FMUrgHToj6nHaNzbqeAOx+jiwc+kRmoQZg98n6a+SrlIluNfl2m+LLkWYUD5uPwcLm 3duwwaEq2/Q2BgMFvZ3zKncJtGF1Qmam0PefIyXSMgMpXeE6+xEZnbkxVRXrDwL69nUx u4MqPaJFXCLOORQpMqxn/7ffKAMgyFWwRlRO2pyejXorvnyUumJ2ZttWzK3kZQqJFZ5c ow== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 2te61dtes4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 30 Jun 2019 20:40:12 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5UKcG5V195447 for ; Sun, 30 Jun 2019 20:40:11 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2tebbhvx0m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 30 Jun 2019 20:40:11 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x5UKeBmu003984 for ; Sun, 30 Jun 2019 20:40:11 GMT MIME-Version: 1.0 Message-ID: <44e129fa-f290-4376-af26-adbe5837fa22@default> Date: Sun, 30 Jun 2019 13:40:10 -0700 (PDT) From: Drew Adams X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9304 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906300266 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9304 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906300266 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 156.151.31.86 X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This part of the doc string is not so good: Set face of all lines containing a match of REGEXP to FACE. That's not what happens - "set" is the wrong verb here (face attributes are set, but not the displayed face as a whole). For example, if `font-lock-mode' is enabled and the command highlights a line that contains text already highlighted by font-lock (e.g. with a face foreground attribute) then the `highlight-lines-matching-regexp' highlighting adds its face to the `face' spec for that already highlighted text. It does not replace face attributes that are already set there. The doc string should just say something similar to what (elisp) `Highlight Interactively' says: Highlight entire lines containing a match for REGEXP, using face FACE ('highlight-lines-matching-regexp'). Highlighting "using" FACE is less definitive (more vague) than "setting" the face to FACE. If the doc string wants to go into more detail then it can say that FACE is _added_ to faces already present, or that its attributes are added merged with those already present. In GNU Emacs 26.2 (build 1, x86_64-w64-mingw32) of 2019-04-13 Repository revision: fd1b34bfba8f3f6298df47c8e10b61530426f749 Windowing system distributor `Microsoft Corp.', version 10.0.17134 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3'' From unknown Sun Jun 22 17:14:28 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Drew Adams Subject: bug#36448: closed (Re: bug#36448: 26.2; doc string of `highlight-lines-matching-regexp') Message-ID: References: <83tvc3b7kh.fsf@gnu.org> <44e129fa-f290-4376-af26-adbe5837fa22@default> X-Gnu-PR-Message: they-closed 36448 X-Gnu-PR-Package: emacs Reply-To: 36448@debbugs.gnu.org Date: Wed, 03 Jul 2019 12:57:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1562158622-26356-1" This is a multi-part message in MIME format... ------------=_1562158622-26356-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #36448: 26.2; doc string of `highlight-lines-matching-regexp' which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 36448@debbugs.gnu.org. --=20 36448: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D36448 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1562158622-26356-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 36448-done) by debbugs.gnu.org; 3 Jul 2019 12:56:42 +0000 Received: from localhost ([127.0.0.1]:48539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hieoT-0006qI-MQ for submit@debbugs.gnu.org; Wed, 03 Jul 2019 08:56:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hieoQ-0006q4-1O for 36448-done@debbugs.gnu.org; Wed, 03 Jul 2019 08:56:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hieoI-0001TK-4N; Wed, 03 Jul 2019 08:56:30 -0400 Received: from [176.228.60.248] (port=1061 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hieoE-0003qz-L3; Wed, 03 Jul 2019 08:56:29 -0400 Date: Wed, 03 Jul 2019 15:56:14 +0300 Message-Id: <83tvc3b7kh.fsf@gnu.org> From: Eli Zaretskii To: Drew Adams In-reply-to: <44e129fa-f290-4376-af26-adbe5837fa22@default> (message from Drew Adams on Sun, 30 Jun 2019 13:40:10 -0700 (PDT)) Subject: Re: bug#36448: 26.2; doc string of `highlight-lines-matching-regexp' References: <44e129fa-f290-4376-af26-adbe5837fa22@default> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36448-done Cc: 36448-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 30 Jun 2019 13:40:10 -0700 (PDT) > From: Drew Adams > > This part of the doc string is not so good: > > Set face of all lines containing a match of REGEXP to FACE. > > That's not what happens - "set" is the wrong verb here (face attributes > are set, but not the displayed face as a whole). Thanks, fixed. ------------=_1562158622-26356-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 30 Jun 2019 20:40:22 +0000 Received: from localhost ([127.0.0.1]:47340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhgcY-0005rT-9c for submit@debbugs.gnu.org; Sun, 30 Jun 2019 16:40:22 -0400 Received: from lists.gnu.org ([209.51.188.17]:59992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhgcV-0005rK-7s for submit@debbugs.gnu.org; Sun, 30 Jun 2019 16:40:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34805) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhgcT-0007Ay-Sz for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 16:40:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_MED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhgcS-0005D2-OU for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 16:40:17 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:57146) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hhgcR-0005AI-De for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 16:40:16 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5UKdOYO078687 for ; Sun, 30 Jun 2019 20:40:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=wmyX7TUgpDiFRF/ETBAPJ8KEEx8YqIGwpyUREe4IMLI=; b=zSHdkVSuyziXpgSvJju6WIkTL/vCeC72FKIq+cUXG++c5EDcjkN44mrArIMGvIW3hrD5 yGT7Bhodywdzwr3mMAyxzfap6rStHkiKzR2SaRVdvH3ZnjJtuhmMWeDiFNrQ1X50g2ex m9FMUrgHToj6nHaNzbqeAOx+jiwc+kRmoQZg98n6a+SrlIluNfl2m+LLkWYUD5uPwcLm 3duwwaEq2/Q2BgMFvZ3zKncJtGF1Qmam0PefIyXSMgMpXeE6+xEZnbkxVRXrDwL69nUx u4MqPaJFXCLOORQpMqxn/7ffKAMgyFWwRlRO2pyejXorvnyUumJ2ZttWzK3kZQqJFZ5c ow== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 2te61dtes4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 30 Jun 2019 20:40:12 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5UKcG5V195447 for ; Sun, 30 Jun 2019 20:40:11 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2tebbhvx0m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 30 Jun 2019 20:40:11 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x5UKeBmu003984 for ; Sun, 30 Jun 2019 20:40:11 GMT MIME-Version: 1.0 Message-ID: <44e129fa-f290-4376-af26-adbe5837fa22@default> Date: Sun, 30 Jun 2019 13:40:10 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 26.2; doc string of `highlight-lines-matching-regexp' X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9304 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906300266 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9304 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906300266 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 156.151.31.86 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This part of the doc string is not so good: Set face of all lines containing a match of REGEXP to FACE. That's not what happens - "set" is the wrong verb here (face attributes are set, but not the displayed face as a whole). For example, if `font-lock-mode' is enabled and the command highlights a line that contains text already highlighted by font-lock (e.g. with a face foreground attribute) then the `highlight-lines-matching-regexp' highlighting adds its face to the `face' spec for that already highlighted text. It does not replace face attributes that are already set there. The doc string should just say something similar to what (elisp) `Highlight Interactively' says: Highlight entire lines containing a match for REGEXP, using face FACE ('highlight-lines-matching-regexp'). Highlighting "using" FACE is less definitive (more vague) than "setting" the face to FACE. If the doc string wants to go into more detail then it can say that FACE is _added_ to faces already present, or that its attributes are added merged with those already present. In GNU Emacs 26.2 (build 1, x86_64-w64-mingw32) of 2019-04-13 Repository revision: fd1b34bfba8f3f6298df47c8e10b61530426f749 Windowing system distributor `Microsoft Corp.', version 10.0.17134 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3'' ------------=_1562158622-26356-1--