From unknown Sun Jun 22 11:39:25 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#36447 <36447@debbugs.gnu.org> To: bug#36447 <36447@debbugs.gnu.org> Subject: Status: 27.0.50; New "Unknown keyword" errors Reply-To: bug#36447 <36447@debbugs.gnu.org> Date: Sun, 22 Jun 2025 18:39:25 +0000 retitle 36447 27.0.50; New "Unknown keyword" errors reassign 36447 emacs submitter 36447 Michael Heerdegen severity 36447 normal tag 36447 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 14:23:47 2019 Received: (at submit) by debbugs.gnu.org; 30 Jun 2019 18:23:47 +0000 Received: from localhost ([127.0.0.1]:47276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hheUN-000645-1B for submit@debbugs.gnu.org; Sun, 30 Jun 2019 14:23:47 -0400 Received: from lists.gnu.org ([209.51.188.17]:57909) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hheUK-00063x-Kk for submit@debbugs.gnu.org; Sun, 30 Jun 2019 14:23:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38731) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hheUI-0007Lh-A6 for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 14:23:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hheUG-00088p-0E for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 14:23:42 -0400 Received: from mout.web.de ([212.227.15.14]:43387) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hheUF-00085x-Hr for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 14:23:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1561919014; bh=UilpFe5epyPDNgadIo99SVCTrkqssKsSnRS00a4/yos=; h=X-UI-Sender-Class:From:To:Subject:Date; b=G+idrl1KgGDCCoslhpchlkwKLFJiO1yu+H2vVWfu5G9twnz8HSzNrTqqrHwnvm8lL Q96hLqSlzz2G4Q/9y2Kcms0IkXk+6HPZ/FfTH3a8VY+yTjFYTBAjvolulltZjJfq3D AOgXPGSYgF1JaEbanHh6pfD7ob8Sumwy1f8YPfcw= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([94.218.184.73]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LoYFm-1iAdSB3ueY-00gVie; Sun, 30 Jun 2019 20:23:34 +0200 From: Michael Heerdegen To: bug-gnu-emacs@gnu.org Subject: 27.0.50; New "Unknown keyword" errors Date: Sun, 30 Jun 2019 20:23:33 +0200 Message-ID: <875zon7x0a.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:x7syaY2bJoKd09OzPowhVbCnqGJ3ituiim8j2oLRx8doH06BfG+ UcbVQ+Oa158aMALwtFzjfNER/8BoAl1JK2q5tGrEbwWKF44rkccXkp6NdGMBf5j4xCTGFec heKtr4MK/mBkGLncd2yw2WfS5Ai+lxzezeWmcp4w1yuBZmxLuovD2sKuj0s4r2oKwCNLzUE VrSMWLsE7WrKmO6DFoe4g== X-UI-Out-Filterresults: notjunk:1;V03:K0:EpYfFB01PFo=:trEPUycshbs3gnRveW/v1W 07i+3Gb0N7XFnZUWHolwQgnyqlzaCgs4Vd3BnyLlu9Ns6EEesmoMYbSSjepzSTnIm+l4Ugw7f u+3yl6ZKf4OYiZsa4jePQ0XZDm3j5Qaxyo90t4BQfS247z/lp5lDjSaQQu1BLwrwn/Kt/2c/3 n8NALDZaGpJ2/G5RLErLzmBCNjstCGUA/1Mq+yuXqUS+srqCzUcWv5UfaEKRrdEqpEJg5+wdX sCGuxPI70H38+xm6rCXIxo0NPC0nB+hKjcLUoJQBviAEK9h+gYmfWJOsyF/MOl/ZkRYkeFuGb S+jTXiRe4D3MPojZJbk/j5wDrSgMXXAI2sENTqCoAJopdwSELn9sqqijkHJdgPin3QOd6Exg9 JJ1cDO1yHTbyQUe2AlxqBtSMtGEWA+F/rGAHIF7v51Hx4tDjl9aKz/w+Nm3VVpPgKDIDlOnGi 3gTqw3ETFLt0xVmdj4ou7gJEZPx5w3VN3EcLRjc3YfMb/tsTBjmNT1wGmLdxVZF3vG/wBsgCm yJsD8sTNPGHSvLgaGoM4hEhfGnbgBgCLAX2YCtgnzMOprdqAMTaRXPzeR3d3TJO+EADZ57xTY 7RLWkQJz0AXO9Dy2NEmhhZkC9EnpABMQWn1FfiksRq7IG1m5N0+uyHK6dYfP+CI5/MLh/f9CX hLYILqxxxmfU/3ocNML+/qIMo4fWBR1cssHSafHPNUiegoFQPZCmsP5BIddrVbrAeOvLfN5yL Vjme0bseB3f2L4z53W/2oAMn+4oV4dnSFmm/BR2BefwnlkdbJvBCx6XMkD1u4YcWLKoJqdqwr YUfKwsyYB1cXwQ6eswG777Jg/LsHX4+09zWylLknwYbC7Nki1aSAWmc5knNQ+BHeBbK9IFxQ5 AoyHkxHUR4nE62rtgslMkRQyeF5hOg8l5K5T1fRgsMfqWycnVUD8szE+uQbcvbt8aC5ij3jhQ ng20znb884js+VQ4F1uS2ITZsrbjagK/PJZUVYXvmcVLRPjDNL9f7CT4FkJNRJ6UBhWn/JP0O XTkb5p071rIwmMFTK3JFygViJPsoZQO2vvQp1m9jk9n3/XCZfO71Mioxtye/qwL349bRlY7er 8FE2l/3l94k0VXAFdY8p5wFfbeo8QeDyBxP X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.14 X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hi, I've just rebuilt Emacs from master and am getting "Unknown keyword" errors all the time. Magit broken, Gnus broken, I even got an error after typing M-x report-emacs-bug. This wasn't the case with a build from yesterday. Here is a backtrace after trying to reinstall Magit: Debugger entered--Lisp error: (error "Unknown keyword :link") signal(error ("Unknown keyword :link")) error("Unknown keyword %s" :link) custom-handle-keyword(ido :link (emacs-commentary-link :tag "Commentary" = "ido.el") custom-group) custom-declare-group(ido nil "Switch between files using substrings." :gr= oup extensions :group convenience :version "22.1" :link (emacs-commentary-l= ink :tag "Commentary" "ido.el") :link (emacs-library-link :tag "Lisp File" = "ido.el") :link (custom-manual "(ido) Top") :link (info-link "(ido) Customi= zation")) byte-code("\300\301\302\303\304\305\304\306\307\310\311\312\311\313\311\3= 14\311\315&\21\210\316\317\320\321\322DD\323\324\325\326\327\330\301\311\33= 1\332\333\334\335\304\301&\21\210\316\336\320\321..." [custom-declare-group= ido nil "Switch between files using substrings." :group extensions conveni= ence :version "22.1" :link (emacs-commentary-link :tag "Commentary" "ido.el= ") (emacs-library-link :tag "Lisp File" "ido.el") (custom-manual "(ido) Top= ") (info-link "(ido) Customization") custom-declare-variable ido-mode funca= ll function #f(compiled-function () #) "Determines= for which buffer/file Ido should be ena..." :set #f(compiled-function (sym= bol value) #) :initialize custom-initialize-defaul= t :require (emacs-commentary-link "ido.el") :set-after (ido-save-directory-= list-file ido-unc-hosts) :type (choice (const :tag "Turn on only buffer" bu= ffer) (const :tag "Turn on only file" file) (const :tag "Turn on both buffe= r and file" both) (const :tag "Switch off all" nil)) ido-case-fold #f(compi= led-function () #) "Non-nil if searching of buffer= and file names shou..." boolean ido-ignore-buffers #f(compiled-function ()= #) "List of regexps or functions matching buffer = names..." (repeat (choice regexp function)) ido-ignore-files #f(compiled-fu= nction () #) "List of regexps or functions matchin= g file names t..." (repeat (choice regexp function)) ido-ignore-extensions = #f(compiled-function () #) "Non-nil means ignore f= iles in `completion-ignored-..." ido-show-dot-for-dired #f(compiled-functio= n () #) "Non-nil means to always put . as the firs= t item in..." ido-file-extensions-order #f(compiled-function () #) ...] 18) require(ido) (progn (require 'ido)) eval((progn (require 'ido)) t) #f(compiled-function (&rest body) "Like `progn', but evaluates the body a= t compile time if you're compiling.\nThus, the result of the body appears t= o the compiler as a quoted\nconstant. In interpreted code, this is entirel= y equivalent to\n`progn', except that the value of the expression may be (b= ut is\nnot necessarily) computed at load time if eager macro expansion\nis = enabled." #)((require 'ido)) (eval-when-compile (require 'ido)) eval-buffer(# nil "/home/micha/.emacs.d/elpa/magit-201906= 30.1329/magi..." nil t) ; Reading at buffer position 1737 load-with-code-conversion("/home/micha/.emacs.d/elpa/magit-20190630.1329/= magi..." "/home/micha/.emacs.d/elpa/magit-20190630.1329/magi..." nil t) load("/home/micha/.emacs.d/elpa/magit-20190630.1329/magi..." nil t) #f(compiled-function (feature) #)("/home/micha/.= emacs.d/elpa/magit-20190630.1329/magi...") mapc(#f(compiled-function (feature) #) ("/home/m= icha/.emacs.d/elpa/magit-20190630.1329/magi..." "/home/micha/.emacs.d/elpa/= magit-20190630.1329/magi..." "/home/micha/.emacs.d/elpa/magit-20190630.1329= /magi..." "/home/micha/.emacs.d/elpa/magit-20190630.1329/magi..." "/home/mi= cha/.emacs.d/elpa/magit-20190630.1329/magi..." "/home/micha/.emacs.d/elpa/m= agit-20190630.1329/magi..." "/home/micha/.emacs.d/elpa/magit-20190630.1329/= magi..." "/home/micha/.emacs.d/elpa/magit-20190630.1329/magi..." "/home/mic= ha/.emacs.d/elpa/magit-20190630.1329/magi..." "/home/micha/.emacs.d/elpa/ma= git-20190630.1329/magi..." "/home/micha/.emacs.d/elpa/magit-20190630.1329/m= agi..." "/home/micha/.emacs.d/elpa/magit-20190630.1329/magi..." "/home/mich= a/.emacs.d/elpa/magit-20190630.1329/magi..." "/home/micha/.emacs.d/elpa/mag= it-20190630.1329/magi..." "/home/micha/.emacs.d/elpa/magit-20190630.1329/ma= gi..." "/home/micha/.emacs.d/elpa/magit-20190630.1329/magi..." "/home/micha= /.emacs.d/elpa/magit-20190630.1329/magi..." "/home/micha/.emacs.d/elpa/magi= t-20190630.1329/magi..." "/home/micha/.emacs.d/elpa/magit-20190630.1329/mag= i..." "/home/micha/.emacs.d/elpa/magit-20190630.1329/magi..." "/home/micha/= .emacs.d/elpa/magit-20190630.1329/magi..." "/home/micha/.emacs.d/elpa/magit= -20190630.1329/magi..." "/home/micha/.emacs.d/elpa/magit-20190630.1329/magi= ..." "/home/micha/.emacs.d/elpa/magit-20190630.1329/magi..." "/home/micha/.= emacs.d/elpa/magit-20190630.1329/magi..." "/home/micha/.emacs.d/elpa/magit-= 20190630.1329/magi..." "/home/micha/.emacs.d/elpa/magit-20190630.1329/magi.= .." "/home/micha/.emacs.d/elpa/magit-20190630.1329/magi..." "/home/micha/.e= macs.d/elpa/magit-20190630.1329/magi..." "/home/micha/.emacs.d/elpa/magit-2= 0190630.1329/magi..." "/home/micha/.emacs.d/elpa/magit-20190630.1329/magi..= ." "/home/micha/.emacs.d/elpa/magit-20190630.1329/magi..." "/home/micha/.em= acs.d/elpa/magit-20190630.1329/magi..." "/home/micha/.emacs.d/elpa/magit-20= 190630.1329/magi..." "/home/micha/.emacs.d/elpa/magit-20190630.1329/magi...= " "/home/micha/.emacs.d/elpa/magit-20190630.1329/magi..." "/home/micha/.ema= cs.d/elpa/magit-20190630.1329/magi..." "/home/micha/.emacs.d/elpa/magit-201= 90630.1329/magi...")) package--load-files-for-activation(#s(package-desc :name magit :version (= 20190630 1329) :summary "A Git porcelain inside Emacs." :reqs ((emacs (25 1= )) (async (20180527)) (dash (20180910)) (git-commit (20181104)) (transient = (20190528)) (with-editor (20181103))) :kind nil :archive nil :dir "/home/mi= cha/.emacs.d/elpa/magit-20190630.1329" :extras ((:keywords "git" "tools" "v= c")) :signed nil) :reload) package-activate-1(#s(package-desc :name magit :version (20190630 1329) := summary "A Git porcelain inside Emacs." :reqs ((emacs (25 1)) (async (20180= 527)) (dash (20180910)) (git-commit (20181104)) (transient (20190528)) (wit= h-editor (20181103))) :kind nil :archive nil :dir "/home/micha/.emacs.d/elp= a/magit-20190630.1329" :extras ((:keywords "git" "tools" "vc")) :signed nil= ) :reload :deps) package-unpack(#s(package-desc :name magit :version (20190630 1329) :summ= ary "A Git porcelain inside Emacs." :reqs ((emacs (25 1)) (async (20180527)= ) (dash (20180910)) (git-commit (20181104)) (transient (20190528)) (with-ed= itor (20181103))) :kind tar :archive "melpa" :dir nil :extras ((:commit . "= 23267cf33a7b690b27dc6760af8ab7f0886239ce") (:keywords "git" "tools" "vc")) = :signed nil)) #f(compiled-function (&optional good-sigs) #)(ni= l) #f(compiled-function () #)() package--with-response-buffer-1("http://melpa.org/packages/" #f(compiled-= function () #) :file "magit-20190630.1329.tar.sig"= :async nil :error-function #f(compiled-function () #) :noerror t) package--check-signature("http://melpa.org/packages/" "magit-20190630.132= 9.tar" "magit-20190630.1329/\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\= 0\0\0\0\0\0\0..." nil #f(compiled-function (&optional good-sigs) #)) #f(compiled-function () #)() package--with-response-buffer-1("http://melpa.org/packages/" #f(compiled-= function () #) :file "magit-20190630.1329.tar" :as= ync nil :error-function #f(compiled-function () #)= :noerror nil) package-install-from-archive(#s(package-desc :name magit :version (201906= 30 1329) :summary "A Git porcelain inside Emacs." :reqs ((emacs (25 1)) (as= ync (20180527)) (dash (20180910)) (git-commit (20181104)) (transient (20190= 528)) (with-editor (20181103))) :kind tar :archive "melpa" :dir nil :extras= ((:commit . "23267cf33a7b690b27dc6760af8ab7f0886239ce") (:keywords "git" "= tools" "vc")) :signed nil)) mapc(package-install-from-archive (#s(package-desc :name magit :version (= 20190630 1329) :summary "A Git porcelain inside Emacs." :reqs ((emacs (25 1= )) (async (20180527)) (dash (20180910)) (git-commit (20181104)) (transient = (20190528)) (with-editor (20181103))) :kind tar :archive "melpa" :dir nil := extras ((:commit . "23267cf33a7b690b27dc6760af8ab7f0886239ce") (:keywords "= git" "tools" "vc")) :signed nil))) package-download-transaction((#s(package-desc :name magit :version (20190= 630 1329) :summary "A Git porcelain inside Emacs." :reqs ((emacs (25 1)) (a= sync (20180527)) (dash (20180910)) (git-commit (20181104)) (transient (2019= 0528)) (with-editor (20181103))) :kind tar :archive "melpa" :dir nil :extra= s ((:commit . "23267cf33a7b690b27dc6760af8ab7f0886239ce") (:keywords "git" = "tools" "vc")) :signed nil))) package-install(#s(package-desc :name magit :version (20190630 1329) :sum= mary "A Git porcelain inside Emacs." :reqs ((emacs (25 1)) (async (20180527= )) (dash (20180910)) (git-commit (20181104)) (transient (20190528)) (with-e= ditor (20181103))) :kind tar :archive "melpa" :dir nil :extras ((:commit . = "23267cf33a7b690b27dc6760af8ab7f0886239ce") (:keywords "git" "tools" "vc"))= :signed nil) dont-select) package-menu--perform-transaction((#s(package-desc :name magit :version (= 20190630 1329) :summary "A Git porcelain inside Emacs." :reqs ((emacs (25 1= )) (async (20180527)) (dash (20180910)) (git-commit (20181104)) (transient = (20190528)) (with-editor (20181103))) :kind tar :archive "melpa" :dir nil := extras ((:commit . "23267cf33a7b690b27dc6760af8ab7f0886239ce") (:keywords "= git" "tools" "vc")) :signed nil)) nil) package-menu-execute() Here is one after M-x report-emacs-bug: Debugger entered--Lisp error: (error "Unknown keyword :link") signal(error ("Unknown keyword :link")) error("Unknown keyword %s" :link) custom-handle-keyword(gnus-cite :link (custom-manual "(gnus)Article Highl= ighting") custom-group) custom-declare-group(gnus-cite nil "Citation." :prefix "gnus-cite-" :link= (custom-manual "(gnus)Article Highlighting") :group gnus-article) byte-code("\300\301!\210\300\302!\210\300\303!\210\300\304!\210\305\306\3= 07\310\311\312\313\314\315\316&\11\210\317\320\321\322\315\306\323\324&\7\2= 10\317\325\326\327\315\306\323\324&\7..." [require gnus gnus-range gnus-art= message custom-declare-group gnus-cite nil "Citation." :prefix "gnus-cite-= " :link (custom-manual "(gnus)Article Highlighting") :group gnus-article cu= stom-declare-variable gnus-cited-opened-text-button-line-format "%(%{[-]%}%= )\n" "Format of opened cited text buttons." :type string gnus-cited-closed-= text-button-line-format "%(%{[+]%}%)\n" "Format of closed cited text button= s." gnus-cited-lines-visible "The number of lines of hidden cited text to r= emain..." (choice (const :tag "none" nil) integer (cons :tag "Top and Botto= m" integer integer)) gnus-cite-parse-max-size 25000 "Maximum article size (= in bytes) where parsing cita..." (choice (const :tag "all" nil) integer) gn= us-cite-max-prefix 20 "Maximum possible length for a citation prefix." inte= ger gnus-supercite-regexp (concat "^\\(" message-cite-prefix-regexp "\\)? *= " ">>>>> +\"\\([^\"\n]+\\)\" +=3D=3D") "Regexp matching normal Supercite at= tribution lines..." regexp gnus-supercite-secondary-regexp "^.*\"\\([^\"\n]= +\\)\" +=3D=3D" "Regexp matching mangled Supercite attribution line..." gnu= s-cite-minimum-match-count 2 "Minimum number of identical prefixes before w= e bel..." gnus-cite-attribution-prefix "In article\\|in <\\|On \\(Mon\\|Tue= \\|Wed\\|Thu\\|Fri\\|Sa..." "Regexp matching the beginning of an attributio= n li..." gnus-cite-attribution-suffix "\\(\\(wrote\\|writes\\|said\\|says\\= |>\\)\\(:\\|\\.\\.\\.\\)\\|-..." ...] 10) gnus-message-citation-mode(1) #f(compiled-function () #)() gnus-msg-mail("bug-gnu-emacs@gnu.org" "27.0.50; Testbug" nil nil nil nil = nil nil) compose-mail("bug-gnu-emacs@gnu.org" "27.0.50; Testbug") report-emacs-bug("Testbug") and here one after displaying an article in Gnus (RET in summary): Debugger entered--Lisp error: (error "Unknown keyword :link") signal(error ("Unknown keyword :link")) error("Unknown keyword %s" :link) custom-handle-keyword(gnus-cite :link (custom-manual "(gnus)Article Highl= ighting") custom-group) custom-declare-group(gnus-cite nil "Citation." :prefix "gnus-cite-" :link= (custom-manual "(gnus)Article Highlighting") :group gnus-article) byte-code("\300\301!\210\300\302!\210\300\303!\210\300\304!\210\305\306\3= 07\310\311\312\313\314\315\316&\11\210\317\320\321\322\315\306\323\324&\7\2= 10\317\325\326\327\315\306\323\324&\7..." [require gnus gnus-range gnus-art= message custom-declare-group gnus-cite nil "Citation." :prefix "gnus-cite-= " :link (custom-manual "(gnus)Article Highlighting") :group gnus-article cu= stom-declare-variable gnus-cited-opened-text-button-line-format "%(%{[-]%}%= )\n" "Format of opened cited text buttons." :type string gnus-cited-closed-= text-button-line-format "%(%{[+]%}%)\n" "Format of closed cited text button= s." gnus-cited-lines-visible "The number of lines of hidden cited text to r= emain..." (choice (const :tag "none" nil) integer (cons :tag "Top and Botto= m" integer integer)) gnus-cite-parse-max-size 25000 "Maximum article size (= in bytes) where parsing cita..." (choice (const :tag "all" nil) integer) gn= us-cite-max-prefix 20 "Maximum possible length for a citation prefix." inte= ger gnus-supercite-regexp (concat "^\\(" message-cite-prefix-regexp "\\)? *= " ">>>>> +\"\\([^\"\n]+\\)\" +=3D=3D") "Regexp matching normal Supercite at= tribution lines..." regexp gnus-supercite-secondary-regexp "^.*\"\\([^\"\n]= +\\)\" +=3D=3D" "Regexp matching mangled Supercite attribution line..." gnu= s-cite-minimum-match-count 2 "Minimum number of identical prefixes before w= e bel..." gnus-cite-attribution-prefix "In article\\|in <\\|On \\(Mon\\|Tue= \\|Wed\\|Thu\\|Fri\\|Sa..." "Regexp matching the beginning of an attributio= n li..." gnus-cite-attribution-suffix "\\(\\(wrote\\|writes\\|said\\|says\\= |>\\)\\(:\\|\\.\\.\\.\\)\\|-..." ...] 10) gnus-article-fill-cited-long-lines() gnus-treat-article(nil 1 1 "text/plain") gnus-display-mime() gnus-article-prepare-display() gnus-article-prepare(107571 nil) gnus-summary-display-article(107571 nil) gnus-summary-select-article(nil nil pseudo) gnus-summary-scroll-up(1) funcall-interactively(gnus-summary-scroll-up 1) This is all with my setup. Anyone feeling guilty? TIA, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 14:43:54 2019 Received: (at 36447) by debbugs.gnu.org; 30 Jun 2019 18:43:54 +0000 Received: from localhost ([127.0.0.1]:47292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhenq-0006YH-2E for submit@debbugs.gnu.org; Sun, 30 Jun 2019 14:43:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhenn-0006Y4-VG for 36447@debbugs.gnu.org; Sun, 30 Jun 2019 14:43:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37295) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hheni-0007Bh-F9; Sun, 30 Jun 2019 14:43:46 -0400 Received: from [176.228.60.248] (port=2396 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hheng-0005Ee-H2; Sun, 30 Jun 2019 14:43:46 -0400 Date: Sun, 30 Jun 2019 21:43:30 +0300 Message-Id: <8336jqgbhp.fsf@gnu.org> From: Eli Zaretskii To: Michael Heerdegen In-reply-to: <875zon7x0a.fsf@web.de> (message from Michael Heerdegen on Sun, 30 Jun 2019 20:23:33 +0200) Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36447 Cc: 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Heerdegen > Date: Sun, 30 Jun 2019 20:23:33 +0200 > > I've just rebuilt Emacs from master and am getting "Unknown keyword" > errors all the time. Magit broken, Gnus broken, I even got an error > after typing M-x report-emacs-bug. This wasn't the case with a build > from yesterday. > > Here is a backtrace after trying to reinstall Magit: > > Debugger entered--Lisp error: (error "Unknown keyword :link") > signal(error ("Unknown keyword :link")) > error("Unknown keyword %s" :link) > custom-handle-keyword(ido :link (emacs-commentary-link :tag "Commentary" "ido.el") custom-group) d8aba87a0d5ef84dfedf4c6a73884fa6dc455b24? From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 17:44:26 2019 Received: (at 36447) by debbugs.gnu.org; 30 Jun 2019 21:44:26 +0000 Received: from localhost ([127.0.0.1]:47409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhhcX-00016M-PB for submit@debbugs.gnu.org; Sun, 30 Jun 2019 17:44:25 -0400 Received: from mout.web.de ([212.227.15.3]:39129) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhhcV-000169-M4 for 36447@debbugs.gnu.org; Sun, 30 Jun 2019 17:44:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1561931050; bh=EyXJfYv10azPmTvajPuux1cRtrrMifQ5AFdRGbu00O0=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=G4y4n5LVhrIL4XzQ45ZZnjstLXCFpTlthLDg4c9EIemodV1B0zzSE+ZAvk8RgdpJC UFK8WAiQHtvrdUlghKpXsitvr0GOG6AvAw7MW5agbwfPHFWeWk8/tLxSA10PiXX5OG qjS96ayuNqDMgTsx4M69Yfhek6T/CVng8zUhPGCI= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([94.218.184.73]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Mgwee-1huzJR3dBY-00M2tN; Sun, 30 Jun 2019 23:44:09 +0200 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> Date: Sun, 30 Jun 2019 23:44:01 +0200 In-Reply-To: <8336jqgbhp.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 30 Jun 2019 21:43:30 +0300") Message-ID: <87h886eoke.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:fljzadzWug+nbMoim/tKoOyVx+arJqm27wF6gI/QcypB5i26HIX wz+7VZg7tdT5XqK38CY3H+ig1BWDxs9hzFmV9WaZrcI9L88lpfn3t8lyME87r3d5wNpoSNx fMyc9GXxONs6clAiSylY9ghJmBl9cU8gMxcriv2MWWM8Z3p994WSAnWIph/BhDClw92vfZc CWX2yfQ3HetG8qtIarEkA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ucepleCC+JE=:oklA3CS6PWIrS6kfARli/W Xc/KqxkVhut1uvgCoJDhQp5cX95tRDAwAmJZOmByM/zxrBXGGTkToWWYYkikx185noqDet+jG 30Nha6MDm9TkpTGXS2KHQu7wRhDmwMA8cOa/R9O3vzpwdfiUnGfPPUEvaAj1Mgx5lhWMfTcG1 jn68KJnXzST7GuEuEPkc5uR62/1L3VZ1VXsbEnCHPIJuJNMoIbP/adhytYFnrQS2PYiFjrCsj ElOsCGs0IkN+xgzHblsh9bDAEPNKzRIQhEV60PpZtPltKl7++Gtb6Wm08A8dMrK96Y9MvdXZq CpbNu93iVJF51mNRBWGuY5Ghw2YA11e6rSrMY4CGr7SDta0kctgxt/0Xq51P8J3sTum7MCyZw znlTWlOm6q6ArBS0SJBRuLhHywtRiut2YkNY1aexqLcpQqzZDjrzEk9X8+CkFLmVMb994ikEO V6KwyxGZtYtplMf6sssDC6G0hwawTdD+gTUJL2UNf1BuQu3WuCUqj5TUzETxG0EBXrXaKDl7t 7ESftE8lAq4s++nXXpp2WA8nokGEOgONislzJMo3b6L6iyu4qoVMmorcYLz638rh6MmpwYmF6 c0GA1OaksuENINzi9pgZ09JfoxWDmfkkdB1Iagx6ya6WJ/b6ss29OgabcjF0NklA3Xjsc6YMt iqcydZCz3d3fxAG8RyeL09t5J0vNg/tMmjXJeqNHO1pDfYZeNF6HzqAlscOSRo1fOGvmC3u8O HSv3Jm8JSc6C8aVAP7PSyUDQmLhTTUbqN85hHdF4J7zzF1FeUpIzJiUizCGvP+5pRMU8d0QzP O/zUUZG9DmYa1BlnNmddNu1x8UVu6b1vFspyJ7os3xy4hd9BqE6E3vQPE8DUlwc+6KRAg/uLw I3gIFxnahw9k78oKmcT7K4kppwFfcrTkOu5ARx34WBdGXCg1q/DsR08wPXTOhO2F2oDoB4gfe IDdt/lFYclnbCBhfNCiAV9NtIGoCcH1Rx0dUn8+v0RWk3a63vfbM4UCUbASbHtJaJC+dDLxaQ QXaJZQMZ0PnswY0Bc4xwZkdpI2qJS+iXt9cIT3LUf5ReUNoe+1R2HtiBk5UlyW1crgizrVaYV /rQPWComN0WWbix2aLpYJgfHp2uh6OkPgC6 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > > Here is a backtrace after trying to reinstall Magit: > > > > Debugger entered--Lisp error: (error "Unknown keyword :link") > > signal(error ("Unknown keyword :link")) > > error("Unknown keyword %s" :link) > > custom-handle-keyword(ido :link (emacs-commentary-link :tag > > "Commentary" "ido.el") custom-group) > > d8aba87a0d5ef84dfedf4c6a73884fa6dc455b24? Yes, seems so. Reverting that commit and make bootstrap have fixed it for me. The bad thing is that only newly compiled files are concerned, and AFAIK make bootstrap is necessary to get rid of those. So it seems anyone who uses this commit and has compiled stuff since then has now broken elc's. Also probably for stuff installed with the package manager etc. Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 01 08:25:22 2019 Received: (at 36447) by debbugs.gnu.org; 1 Jul 2019 12:25:22 +0000 Received: from localhost ([127.0.0.1]:47735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhvN4-0002k1-IV for submit@debbugs.gnu.org; Mon, 01 Jul 2019 08:25:22 -0400 Received: from mail-io1-f47.google.com ([209.85.166.47]:33863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhvN3-0002jm-17 for 36447@debbugs.gnu.org; Mon, 01 Jul 2019 08:25:21 -0400 Received: by mail-io1-f47.google.com with SMTP id k8so28399549iot.1 for <36447@debbugs.gnu.org>; Mon, 01 Jul 2019 05:25:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=OdB8iw6CiRrCQmWkcTwMjaUNY4A8zQI8I6CFh8AsjMY=; b=LJu/VBMEC6f3radLlRjKuJwaohmx8Wtw12SRU5JVTIRE7ECWbUhdnfhgQBoCnhx9DT wRLS4TDkwCW9cJ7cm2LhzeI67F4aAxLsQe0JHGje47uVokKCe40q9BzrlvdxBm17v1sf qYX3JL7DM+dTk9zPDeB+jCPuAtO8uLNX2GeiAAUpKq3QEO6IjRoLC8LNWnX4URg2MG0J RXrHcchoF8y4O80gKkO/3HTUf1p0Buac1hLni8fm3O+zyVeEb7Q8vMAa/6/zRKKpIx4h ZNYqLP7MQsB09gwu7MfunS6BxyrDSjkDLxjm+rbQzy2FoaCP+tmnxPAu5OGRrHjVAUDR /IKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=OdB8iw6CiRrCQmWkcTwMjaUNY4A8zQI8I6CFh8AsjMY=; b=YKdgwdtVzpbgJa+W1w6q8v/QSgExpVjXaEGbUUncqrjh0X5vf5exmDDmm5CsPZfwzt uVy6aCmL36RDFHZkIB8Wlu4hfyavb3/TEFzrFPYtAv11ALLrXO1Q80D7xZxv+FtryLdi OyNlvXOq9TZWlRvm6cWAoFbeTSfxpuvmXJR3wL25AG/21D5NwuWbbBS9BjX80WXgEIsH roT0TDqJJmyE/IbFfoig6xxV8SU4wD2u3HEQ6lB/r/OI+GSYW/sPxJ7QegSsFHN4P+ca nfC0XzhEzIrrA4CqtPeKoRl+0hLUKZdiaNptubBpin2r3OJ1UNtagAJPL4Iife/0uzKm hn9g== X-Gm-Message-State: APjAAAVzPsGfzIWGzy7TUC+t6fc0XiaktaaGsgyPcllNFR/L5MYeO+9V tP8mtNKOPmmCgyH7yr51rwzMpQZP X-Google-Smtp-Source: APXvYqw+USDmFF4tkZcEB/ie3AOtHjS/lSJcGl29tYqxo2scs3/rRWVwvEVdBA050OGp4HFxxvgyVg== X-Received: by 2002:a6b:e608:: with SMTP id g8mr238849ioh.88.1561983915429; Mon, 01 Jul 2019 05:25:15 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id p10sm12181933iob.54.2019.07.01.05.25.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Jul 2019 05:25:14 -0700 (PDT) From: Noam Postavsky To: Michael Heerdegen Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> Date: Mon, 01 Jul 2019 08:25:14 -0400 In-Reply-To: <87h886eoke.fsf@web.de> (Michael Heerdegen's message of "Sun, 30 Jun 2019 23:44:01 +0200") Message-ID: <87d0iu54d1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: Eli Zaretskii , 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Heerdegen writes: > Eli Zaretskii writes: > >> > Here is a backtrace after trying to reinstall Magit: >> > >> > Debugger entered--Lisp error: (error "Unknown keyword :link") >> > signal(error ("Unknown keyword :link")) >> > error("Unknown keyword %s" :link) >> > custom-handle-keyword(ido :link (emacs-commentary-link :tag >> > "Commentary" "ido.el") custom-group) >> >> d8aba87a0d5ef84dfedf4c6a73884fa6dc455b24? > > Yes, seems so. Reverting that commit and make bootstrap have fixed it > for me. I tried deleting all .elc files *without* reverting that commit, and (custom-handle-keyword 'ido :link '(emacs-commentary-link :tag "Commentary" "ido.el") 'custom-group) does not give me an error. Is it possible that it was just the 'make bootstrap' which fixed things? From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 01 09:21:26 2019 Received: (at 36447) by debbugs.gnu.org; 1 Jul 2019 13:21:26 +0000 Received: from localhost ([127.0.0.1]:47774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhwFK-000482-Dq for submit@debbugs.gnu.org; Mon, 01 Jul 2019 09:21:26 -0400 Received: from mail-oi1-f181.google.com ([209.85.167.181]:36819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhwFG-00047m-R6 for 36447@debbugs.gnu.org; Mon, 01 Jul 2019 09:21:25 -0400 Received: by mail-oi1-f181.google.com with SMTP id w7so9911414oic.3 for <36447@debbugs.gnu.org>; Mon, 01 Jul 2019 06:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dA4Ftn3/WtyPazQVC4Z/OTumiMsUQOW67u7MGg1y97c=; b=Gp8AITuaKsO5Rbk2JFdw4RHFG0LrXyQWV8oZMuvIM3FegKOVvIIoW+6rrS58tX7Ybo sy2FvWpNZhz/0DvI4/4bJpzEOZ8yu/S6sDP3hKMQBYSXgnR8AIfvCcBmd8wo9v0hPcP8 uyZ2Bi4qT/7r4FJEVQXKqL7lj3M9MTwNsR3cs2ZAhiDBIJPK//NdUcM/c5A6ssPvOR+b ZSJx8uEvAD0eci73wfic29uoct9RfJ+XFWqcyONh4MS8DUbBB2KMuAyKJYwNCTvbp6RA wynteEEU+Ehc761Xr0gM4JpBhQDo0GmQt+XMkD3RIFSjjTMGCW9t7Tg6xihbDmJlPBf+ 8zwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dA4Ftn3/WtyPazQVC4Z/OTumiMsUQOW67u7MGg1y97c=; b=cyhxj7VjtptHYquKzhXybvZOBNyjRkkiB3O9Xe11t91CDgP2bEZCrd/LU0cnuYq6rH uLGG5lSMmY8oVrDvEtwE/dPz/YTdq5uWd/ialuUKDjgmaDoyKaUpwXHqXI/rm733AJCA lIyAR9Y8DgaPcEjOiY8LRg4+z9HWiPXCpD5O2XA8TegoN+jS9wMGYOh5E/VYd2kCk/SR Fgt/LwDsryM5cuB4/H78VUVV7NYtxg3mkwzbb4jkso0NkbJg+RKRCZBu0lrOyAlS5gWA HrqHPSmLE7R8XYM4IQU4s3ISDl+A+/FXrfHhL6mpOyw///qF9wg4H07QzHT5nNm7nNhc s9UQ== X-Gm-Message-State: APjAAAVZv5AAUjbsq0ZWQST0CYehsh9sMNhebGRP/lRO3O7pk4EFzvI5 5vMKiDmHZrHmRuNm/fP1Bm6N122+uCMCeH5JdnA= X-Google-Smtp-Source: APXvYqzwwHcWXgPSQ1tGCdswtJ3U4GAg/mtD5IF+Vfq9ZY4hClsSZxK86GmDbEsPGm52obKKiDNNDxj1kPHElgoaNiU= X-Received: by 2002:a05:6808:313:: with SMTP id i19mr6653297oie.30.1561987277206; Mon, 01 Jul 2019 06:21:17 -0700 (PDT) MIME-Version: 1.0 References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> In-Reply-To: <87d0iu54d1.fsf@gmail.com> From: Pip Cet Date: Mon, 1 Jul 2019 13:20:39 +0000 Message-ID: Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors To: Noam Postavsky Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: Michael Heerdegen , 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Jul 1, 2019 at 12:26 PM Noam Postavsky wrote: > does not give me an error. Is it possible that it was just the 'make > bootstrap' which fixed things? Just as a data point, I saw similar problems ("unknown keyword :group" errors) that went away after either of `make bootstrap' or re-evaluating custom.el (and installing non-compiled versions of it). So either something changed incompatibly about our bytecode, or some recent versions of emacs must have miscompiled custom.el. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 01 18:04:40 2019 Received: (at 36447) by debbugs.gnu.org; 1 Jul 2019 22:04:40 +0000 Received: from localhost ([127.0.0.1]:46218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hi4Pg-0001cD-De for submit@debbugs.gnu.org; Mon, 01 Jul 2019 18:04:40 -0400 Received: from mout.web.de ([217.72.192.78]:39463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hi4Pe-0001bz-CQ for 36447@debbugs.gnu.org; Mon, 01 Jul 2019 18:04:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1562018668; bh=9iR5q3vI4ZKjhVR/1ui2dPviB0quCkAMXzCMv0nY2RA=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=rmtwmXqYYWixjja8ovbu6iwN6EONf3H1NAH6ogyAiinFmXhFPCihRns6R9mMOPcmE qnqxt3kOsqyScndAFETPSK4TxbFgjjjn+5iqF8wNCuofLH/VHGBhM9AzUyLA9ORUFE 6j3W0Sj+ZOXOfSC0uGVNxI7vYmdJ4pD0xU0Wvm1g= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([92.208.85.143]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0Md4l4-1hzBYU3LCU-00IDib; Tue, 02 Jul 2019 00:04:28 +0200 From: Michael Heerdegen To: Noam Postavsky Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> Date: Tue, 02 Jul 2019 00:04:24 +0200 In-Reply-To: <87d0iu54d1.fsf@gmail.com> (Noam Postavsky's message of "Mon, 01 Jul 2019 08:25:14 -0400") Message-ID: <87k1d14djr.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:C83EtkmY3AgjWFHbAYWppxDWKP2QE9L2VNmp1fzwDFE/vv/B8Ra meChrvebesby6SFMSMEWWLjbfJ7UzQGFI59JqNZEj0bdjBpWDutSfo4j1FGNBlaH0tw9ix1 aZvpUom9oSEnaU6quwtj7Bl+Sr/069zRLToR4RBWucTPfvfGU4nE+yJXDtikVmtAG4Btupb qIG0Nlt2H3KZ0aXGRhcKw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:8LFIO2FTw10=:XyVlwSOLqVHlW49lFhERGn OAR7p+2iXx75EvajAG7p7jTUYc6z7jlDeOfmctppJEVvjmqymlawSVXYWMgypvGpRryafFAUb vUCPB1yvrosgTl36DxqvzotaQsKIZIpPPL4LtqwsCTJKVcz3KWo7GsXbvcEKhCY0tqSDfYooY 90B4J6jxO4axf6G1khRzPwuoTIbL/I8xEKiNKdxo1GloejUzCk/1vyuXzdTed1YAQFO/Ssf33 uEZZHhper8XwWsnOjMfIMqPDGoeGI5tKspddAGHmbC3GEEC8L2mzzYmFmebRw5Aggp5or+9Cm LAueJT3lqKr0RjHBNyUhRBpACPn4deFtWQQ2GjuvA7/MaSI/h5wtHsP1588tREAlLSZstghLi jpliLZ8PHIU6Sg4ALpsaRMxQECJlI1irhNszBswHtXZDp3Ns1ouJ8BQ+sStlyf7P1nYc57NTa mOS233LHE61p4KikxY90idFFFqVbzyRbQBEH4uF1HpmnwJpmaDHojY0s6q2sxZZIRVbgKuLR2 MCmumuOh35WvPvnBllljs48NOeG0JRFqMkTo0QArHlbGrRNog9fN5IbaMQ9gL6dCTDEurGj5K jhgFoKWKnWoLWbOHjLhJY7TBMNsEIZv81mb/ahi7oghxNKBK9SXzweQtcGvmMx/aHbBU5Pnkk VKpWtwFui4d+SCUY7eOb3FhLwldFDVNjdtJpgyR5IzHMI0lVa5Sb2LxqVVY5My+rUKvv2DJXx OBf9kkIZO/4i0Nfxr5zVrGVGAqxvxXcqc2kOTjBbfkx/RuhFxDRQXKqZ+FbiklmdscjIwifCQ pfC51oVeti1M5WHB6ZjTmLOikjTpd4AEICnifeJCX4AMYiouxZqY+e2BG+5TgK33Yr+mGRvR+ P8yDQw4GcfOn1f/XN2ps1a0OBJ50H7sPIE7ypo0pXS21wXA0ABIKK6ti6RpJ9BMuUyU2X2W34 HjSzWFPW8AiVBu2WZvkV1Ym3Qo8UN1x31SYhmSLuEbAPJFlIX4wXYHSSf9kidmBGq6VhX5Lij 5NQXKLjSvn3yUuSlPX2Z0kPBw+1lHGuubZN5AGZOIXwedirDJZKQwI18aWjcC5vnxes7w7nxT uIdazJQuITGdxGW7gHLKYo5miFoFN5y56Od X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 36447 Cc: 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Noam Postavsky writes: > Is it possible that it was just the 'make bootstrap' which fixed > things? Hmm - seems so, yes. I just made bootstrap with the commit included, and the problem is still gone. Strange thing, but seems there is nothing to fix. Thanks, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 01 21:59:30 2019 Received: (at 36447) by debbugs.gnu.org; 2 Jul 2019 01:59:30 +0000 Received: from localhost ([127.0.0.1]:46390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hi84w-0007Nn-0V for submit@debbugs.gnu.org; Mon, 01 Jul 2019 21:59:30 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:41849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hi84u-0007NY-H4 for 36447@debbugs.gnu.org; Mon, 01 Jul 2019 21:59:28 -0400 Received: by mail-wr1-f48.google.com with SMTP id c2so15830716wrm.8 for <36447@debbugs.gnu.org>; Mon, 01 Jul 2019 18:59:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mJ2XKE5Yl17si8CcyTYB7/dBSoT7Av16rT/imTIZkJk=; b=eWIzOY+66T81G89xNsmELutyma1N+y9v8Rk5v3JRHazqrXzwHMCUTqdaJ36uttHwao WqBKkGewZ5amYaHelK2v/JJ5igl9QwG4ouAQoARTfR4Tqt3uCMMEgwIkvETkq2/dyG9R AmguFoKTPvUDCXVT3h85pnuj3riOI+0l3G+0eA2yp796nYOBiujyyi32yJYjpDT4fhJz PM24Bd1F16LKZfxp70WbjPP6IVgmM4LttDwLaE2NK7cvcqXDPDVg00iYt7ktLM0V1YVI 4i3r1ShGCV5/DRlJzO8kMoiMVoDWpowWm6gmdnOh27NYotALWG+L4Uj9GWdwrPBV0apq hf3A== X-Gm-Message-State: APjAAAVjcgekmJACoSyxm7IV8RPOCdGucgAZYmZ5t0k2vrlTdp4JOSOx S7D9Vbr1ARFkCl7Lz2PIMNIWKvAyoQm0Dz0BWo8= X-Google-Smtp-Source: APXvYqz/QTVhY+KUelPEs5j+pams8oMtBZsBrrupdT+ICbauv0hD7Mm6rAoaq1Glz9MGFfdkvXtXksf7XESVUvNIpaE= X-Received: by 2002:a05:6000:1150:: with SMTP id d16mr4199459wrx.48.1562032762667; Mon, 01 Jul 2019 18:59:22 -0700 (PDT) MIME-Version: 1.0 References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> In-Reply-To: <87k1d14djr.fsf@web.de> From: Stefan Kangas Date: Tue, 2 Jul 2019 03:59:11 +0200 Message-ID: Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors To: Michael Heerdegen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 36447 Cc: Noam Postavsky , 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Michael Heerdegen writes: > > Noam Postavsky writes: > > > Is it possible that it was just the 'make bootstrap' which fixed > > things? > > Hmm - seems so, yes. I just made bootstrap with the commit included, > and the problem is still gone. Strange thing, but seems there is > nothing to fix. I saw this problem too, and can confirm that 'make bootstrap' fixed it for me as well. Thanks, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 02 09:30:47 2019 Received: (at 36447) by debbugs.gnu.org; 2 Jul 2019 13:30:47 +0000 Received: from localhost ([127.0.0.1]:46667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiIrv-00059L-Ig for submit@debbugs.gnu.org; Tue, 02 Jul 2019 09:30:47 -0400 Received: from mail-ot1-f51.google.com ([209.85.210.51]:47041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiIrt-000595-GV for 36447@debbugs.gnu.org; Tue, 02 Jul 2019 09:30:46 -0400 Received: by mail-ot1-f51.google.com with SMTP id z23so17120164ote.13 for <36447@debbugs.gnu.org>; Tue, 02 Jul 2019 06:30:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dEVRtusHf/Sc9fytrRi50BdAFBUX0wkZ8EMEPRGzR10=; b=UPdfwupXAyoXZzqDWAs6BCoGprXG3Yyi0yDGXH6Sdzu1sqhzfbcQTcrpLozvbGzE0L 2yQ13sXPVGymshbE1DXgpZbZj7EIsEFlfjGjoF9oOgY8/2N+W8f2ncWrA6+KQ+ViMQIc oarS6wRUETzK0X8HwtY0KcQlnx4e6pBKoCA9vbhSm1z18Z2Pb1vLL2bbWFaYO65hfzlw IRpvLNmt91drZGKUPa0FYsEV0Mk96wflSpfN9SuvYttCR+s5U4fr4a10d1XQfbLPUJQx 9PUGTJinKVFsig+dvOdiU3VWGbcQbjPOSFwbhFlX0ICMYFT199j5jNlbUEzvUmg5j/9J TxkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dEVRtusHf/Sc9fytrRi50BdAFBUX0wkZ8EMEPRGzR10=; b=k/x67a6JeJ7uNoIxB7B9AlYo9sDWDFtvnf8XmsywZaiap7PkvFAQRIYHaQ+Un2DXtG JxngnlaEULE4kdH0Osq6GGkR2bD45Y+RLyWPcd+eKTz9+iUePHDtBtIcRi1TAuqLJI/o dxFw/XJZFg//UzUjq+ftonlvvD8cJ1mt+6fJsuhn4L0Y9HAkMMg30Eiej7v3vzw5AY/8 fpAZiIHM85ptoAMT7/1Iw+DW+/4rM2BbDgxoBVyp1w7LKBjy1NcHIuv+V6UZ/qCzkubN XnJQeXBH3yWk4wp52VaJUIHyCtlLF80bZVF0RIiOE6IJZdOgcOlbPYY9OZat/UyLfQGM 1FFA== X-Gm-Message-State: APjAAAVLonFOWbIbSpdi7XFjF1wxf/XjJQg64eUXh0saj3djAIZ0jHrZ Pjo80/2dfLdwkXZOzjSsWjgY0yum5a6vD8BRR7o= X-Google-Smtp-Source: APXvYqxqzEOB8/zJ1Jd/aVrJ1QCwSJ7O2Vnc8h/eniwn9h5kaR301C8o2ALU8iZ5vzgoLMdF9oknHXgWnEyYTNauX1w= X-Received: by 2002:a9d:7284:: with SMTP id t4mr25870420otj.154.1562074239783; Tue, 02 Jul 2019 06:30:39 -0700 (PDT) MIME-Version: 1.0 References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> In-Reply-To: <87k1d14djr.fsf@web.de> From: Pip Cet Date: Tue, 2 Jul 2019 13:29:58 +0000 Message-ID: Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors To: Michael Heerdegen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: Noam Postavsky , 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Jul 2, 2019 at 1:32 AM Michael Heerdegen wrote: > Noam Postavsky writes: > > > Is it possible that it was just the 'make bootstrap' which fixed > > things? > > Hmm - seems so, yes. I just made bootstrap with the commit included, > and the problem is still gone. Strange thing, but seems there is > nothing to fix. I'm not sure I agree. Something went wrong somewhere, or we wouldn't have called byte code with what looks like an invalid hash table. Do you still have the emacs binary that failed? From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 02 10:17:51 2019 Received: (at 36447) by debbugs.gnu.org; 2 Jul 2019 14:17:51 +0000 Received: from localhost ([127.0.0.1]:47610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiJbT-0006T1-Gj for submit@debbugs.gnu.org; Tue, 02 Jul 2019 10:17:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiJbR-0006So-LX for 36447@debbugs.gnu.org; Tue, 02 Jul 2019 10:17:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49723) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hiJbM-00025B-0R; Tue, 02 Jul 2019 10:17:44 -0400 Received: from [176.228.60.248] (port=3660 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hiJbL-00051v-8p; Tue, 02 Jul 2019 10:17:43 -0400 Date: Tue, 02 Jul 2019 17:17:28 +0300 Message-Id: <83ftnoed1j.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: (message from Stefan Kangas on Tue, 2 Jul 2019 03:59:11 +0200) Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Tue, 2 Jul 2019 03:59:11 +0200 > Cc: Noam Postavsky , 36447@debbugs.gnu.org > > I saw this problem too, and can confirm that 'make bootstrap' fixed it > for me as well. Deleting all the *.elc files and saying "make" should have been enough. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 02 11:35:21 2019 Received: (at 36447) by debbugs.gnu.org; 2 Jul 2019 15:35:21 +0000 Received: from localhost ([127.0.0.1]:47694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiKoT-0008Mf-51 for submit@debbugs.gnu.org; Tue, 02 Jul 2019 11:35:21 -0400 Received: from mout.web.de ([212.227.17.12]:47693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiKoR-0008MM-4k for 36447@debbugs.gnu.org; Tue, 02 Jul 2019 11:35:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1562081710; bh=aoD3gvCxTQWh+CzeBiGjw65KtwuD05Yikz9FGA8w83w=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=VbPhnXEtTLXd5RZvJAWk7/gHuEXcINQH09hnvrrc+6Q8hvR46AGb4XfPUOaku1jtG AUDNOBdIOGHHJDphauYxjfdhauZbmM5KHmY5euKu7zKcodnll7iiEZwEglStqcGKVb 1gXxnL3dYiCtoyDOmMQjLGXWW4+aL54RK6N88ju4= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([88.66.71.116]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M9XM3-1hpAgr2ZZv-00D0V0; Tue, 02 Jul 2019 17:35:10 +0200 From: Michael Heerdegen To: Pip Cet Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> Date: Tue, 02 Jul 2019 17:35:09 +0200 In-Reply-To: (Pip Cet's message of "Tue, 2 Jul 2019 13:29:58 +0000") Message-ID: <87h884fo0i.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:h43FYZ2Pn++b+CAhbAKW0vPPK5DAw7RId+jpULmXtxuC8RuXt15 oYCIA3h18j5atV7S7aEHnYPZ3ZDCCcZ3EltUmoX9lrpXP7yhr3dhGyeyRNebQasdGIdB88D zzYS07tduko+idFNZDHT/TRAy+LDKgtEb8jjFKArLMgZ3JE4O+lk2FGOkx5Lxp0ONB1KIdK VgVTUy01yjSA3aNm3+Q2Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:z7/C2VZcXvY=:QaUnbPB6wmVhnNAo09viu+ rmiaSwE5eRWX5gxtM9CdvMyWXJ/hJAgbGsaR4cP6LvHkoZwpZQW9dS1n++lxeZpWwtIg55fQS 5BwnQO+BiJkOdx3doolovV6d/cyKuauH5co9NTciAFus5xlK2SBUFLBHXvqsHgQT8Jd4xQUki 4Ny3wjUT6D1kVgpC+f1lgb1iKCVBc5lMePkv05AqNaV25oQk2LqfDe2MC4kn5r5mihh7XuqqS J+hfr2yqbgy+djBQhEPbu9UZlgn3FQuWtJNvUBm0Dn8Jw7XZuTbaVzbPePr56WQgHvWj6kkUV wfHl2RyLYzlo+V/ApOHZDRqxHsCQgArKzcp8T+hcSasHIN+rqWmGXr8PqrYbZG4kiOBkckjKJ gYe7zQPW04hBtfHeNG/Ki6hImzcwnEJbK3vzFHGl8xhnq3MWUg7sBdAwgdYf+vyNj2VH/hDgd yw0O9RIqYfsyJ5vBs9y/1VqcXpBKNKADxU7a1rHnXvxOK8Y+iuRGVe+LmQ09yF9hwG4bk2ufX b5EXG2j0KwQIGgRt2FLV09Fg0e93KtUli2ucHlr74Gpy3chafClNwOL/Nem87CcewGXPVaZVJ NF4gQqZDMX0+kf8WuYCpif0we0GNsmzmB6u50DA+arqH0kkrZCekiF9EdZE8PnwUXUoah5Vn3 +Ak+hTgenIKO7eSLX5kAi9UmXM4E5OmC9RKPUiEDQoJAYKppceOdvHuA1V3qeEJXBnMnSxY4Y UHXm1f+0ARqDCsyAT2tbG6okTLmoG1ecD2EihBo+EOk/VXv87nosP3eqQeo5lfOr7UytM+fZL eGX6qrmO6ScsVND2LZa0amZ1qDhbGnHch9W/CSy5/Usx0EbKroPaevvHPNf9yS45JwI68uwIK 2xmaZhQvPaLUeRUDxBqFedtc0LpPq+aWFEPjCAGLYiyJYQJgriOIedxYG2+wmrxSZEvWr3Q+d B5DrccyqS0i8UyyT1Dwg7GwMpasjhLClgmH6nQ8eQIe41i8aGMP5Pr2L5jXZxXJ9ItQvtaM+m l5dRxG3fDFyE01Q7NR8KcmB90wvg2Nbs8O5dI+Dk2YexJftaavQbxKH3KSbF0foTRVnIgE+v+ ByblJbEOnsMXw94X24msaK/cFGbdAutQUvX X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 36447 Cc: Noam Postavsky , 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Pip Cet writes: > > Hmm - seems so, yes. I just made bootstrap with the commit > > included, and the problem is still gone. Strange thing, but seems > > there is nothing to fix. > > I'm not sure I agree. Something went wrong somewhere, or we wouldn't > have called byte code with what looks like an invalid hash table. Did you reply to the wrong thread - or - where is a connection to hash tables? > Do you still have the emacs binary that failed? No. BTW, looking at my backtrace again: Debugger entered--Lisp error: (error "Unknown keyword :link") signal(error ("Unknown keyword :link")) error("Unknown keyword %s" :link) custom-handle-keyword(gnus-cite :link (custom-manual "(gnus)Article Highlighting") custom-group) and at the definition of `custom-handle-keyword', I see that keyword -> :link must have failed this test: (eq keyword :link) as if there where two interned symbols :link. Quite strange. Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 02 12:20:34 2019 Received: (at 36447) by debbugs.gnu.org; 2 Jul 2019 16:20:34 +0000 Received: from localhost ([127.0.0.1]:47756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiLWD-0003BI-LD for submit@debbugs.gnu.org; Tue, 02 Jul 2019 12:20:33 -0400 Received: from mail-io1-f54.google.com ([209.85.166.54]:35484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiLW8-0003B2-J3 for 36447@debbugs.gnu.org; Tue, 02 Jul 2019 12:20:32 -0400 Received: by mail-io1-f54.google.com with SMTP id m24so38420326ioo.2 for <36447@debbugs.gnu.org>; Tue, 02 Jul 2019 09:20:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=NfTxK6XnUqB3gOk7kL90DfzpzED73mryYeigBHM0djY=; b=mxOOmSTGR2nQ4C/1ZxLnBKDG06sZn9uZN32BxX4WFvf+aWphz/R5KAcFrgV0LscXwa w350AF6+mMwIq5mUbCwfaWkTbSMVDnWls5w8LEH2NiyKKd/EgnLsTeNoo/nVo3onCMma I+QtJBHOeDfMcJcVURkJur7kLHjjKQ09DgbuH5JeZsyiCTRvxN0VOpXbUu/6HGPTCZcC NFsAg8kZmSdL0sPL0qrDUagGSo5M/7lMSn1W1Mvk/k3QSfvuZ9kLAt9qdKoGqHVplJhR 02lQXuDlDbb3do5aXaZp6fBSVa6B8FL326Le1861pXWcXV3bSYQyudJsnh5IyXbmGXRd /wcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=NfTxK6XnUqB3gOk7kL90DfzpzED73mryYeigBHM0djY=; b=W6i2tFHBjmtOOmJ5fD+SASK+zo1e/KnPZdMshSLBK+7srfXGs/3gauBSw1tpNfG0fl 3sLBat6BvSLw8iMfzdYlLsevRcFHVCXt85ajJ5537GhZmmfViPZF1Ov16dHLwfIaTrC/ iIO2ZB7x9tWZEn9g0jI3Pl5nLqzATs7Xt5S3M6vCvErctrMkqFYBMBv42MkhtfHxn9MW orkIkXwxShOhc1g9ZuuH+ohiFmpvMVTjAYleoQ9XqB8XMa7bWmQiPGGx7nuH+ncV+Udg 6maM42Vr4ALTjM2iniuvRBmR5G6xmdPYlFc0L02vgevDZ3LsSrnrM6/wL7M7pBea9gJ9 KSkg== X-Gm-Message-State: APjAAAXVGRUGd1PdVj1UTReB1WroHK3ko1/0oengMrq4yLkL4YtTp11s IEN+C+FKkFL+IgTSvnShcyUV4eqi X-Google-Smtp-Source: APXvYqyHWY5z/mHNpjaSaDBZBZTTXXir/hB4pZSUgdY+sBXrMUkD37P1AUShfQ2RZguUq+3rqVlTYg== X-Received: by 2002:a5d:9613:: with SMTP id w19mr138821iol.140.1562084422777; Tue, 02 Jul 2019 09:20:22 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id c23sm13055228iod.11.2019.07.02.09.20.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Jul 2019 09:20:22 -0700 (PDT) From: Noam Postavsky To: Michael Heerdegen Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> Date: Tue, 02 Jul 2019 12:20:22 -0400 In-Reply-To: <87h884fo0i.fsf@web.de> (Michael Heerdegen's message of "Tue, 02 Jul 2019 17:35:09 +0200") Message-ID: <85d0is5ry1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: 36447@debbugs.gnu.org, Pip Cet X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Heerdegen writes: > Pip Cet writes: > >> > Hmm - seems so, yes. I just made bootstrap with the commit >> > included, and the problem is still gone. Strange thing, but seems >> > there is nothing to fix. >> >> I'm not sure I agree. Something went wrong somewhere, or we wouldn't >> have called byte code with what looks like an invalid hash table. > > Did you reply to the wrong thread - or - where is a connection to hash > tables? The compiler translates repeated `eq' in a cond like that into a hash and jump. See byte-compile-cond-use-jump-table. >> Do you still have the emacs binary that failed? > > No. 'make bootstrap' deletes all the old binaries. > and at the definition of `custom-handle-keyword', I see that keyword -> > :link must have failed this test: > > (eq keyword :link) > > as if there where two interned symbols :link. Quite strange. Or the jump table compilation was messed up at some point (e.g., Bug#35770, but I think that one was too long ago to explain your more recent problems). There are other patches in Bug#36139 which affect this, but I can't see how any of them could have caused problems which disappear after bootstrap. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 02 18:51:44 2019 Received: (at 36447) by debbugs.gnu.org; 2 Jul 2019 22:51:45 +0000 Received: from localhost ([127.0.0.1]:48137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiRcm-0007KN-HV for submit@debbugs.gnu.org; Tue, 02 Jul 2019 18:51:44 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:38279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiRck-0007K9-Cz for 36447@debbugs.gnu.org; Tue, 02 Jul 2019 18:51:43 -0400 Received: by mail-ot1-f67.google.com with SMTP id d17so255867oth.5 for <36447@debbugs.gnu.org>; Tue, 02 Jul 2019 15:51:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1LNv6xei6ootckOZp6IeCdQ0hlg/nr4MyByY3oZix98=; b=f+WX7h0C5WsRNFKki/W0eQhuAELnGjJoZo66L6NEyU08NR9OMR4hKDg1J814rbbbZw +kd9m/mjs51iK64hZD2zkt05OEiXs1tme6FkYcKqUrC8UAblEeyaAWdOyCjqUVBw1H6r nNebQ0LrwEiM0e/vn3Fl1IxNtRlf6C3dhtYY0JMk9TgMTXfGYffE684BRS/SWts7sB92 kNWOFETJmZUJ/OKoM10Em6vNcTGbuX2nfHCYkTZoDAAD+DM4EwBp0ZN6gw9zNTPPyjJO G+vlwRxgudbyjvdDTekKl/VxxwxtejofyQDGojqLfGMQzcaHrR2vNimD54lYRDluaVRS tB/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1LNv6xei6ootckOZp6IeCdQ0hlg/nr4MyByY3oZix98=; b=DiTJTT/Pczx9WM9AG0Xq+cDUk0py3kMae78EzdANXaFWzgeeGHAHticbGxS87Lu2N0 9by9aO6BgNp0raTKKOEAjKAonsTtkh4CyKHNuNBgmaKcNOu/3c0um4YJFVQa0xZcS4OH BQtjQMd/jwXoeOxs5nwcL3/e5OQ6fxnVOUqieScFcPxi7eS70WGcMZ8APyNJArj3dqcV cnfoaKA5KgazzQVP/fGm9Ekd9RPB/hAk2SLZHw6bFU0Ys7MUqx3p4C+A4v+KxsotKE2r AYeGrNOkTrw1k2IoKW+Ach/IVXanNy3+mbBFMRFqh0GgwmTAxFV8A4HdajKKgXWWlsvX XTKw== X-Gm-Message-State: APjAAAXUGZZeQdQ6R361jrCGt+NZ45wbGdi2aAQcgi3LYzXCuzfD4yJR FeEvdI8wgjz2rnP15gSNowozelMzLbLj0vPCdxs= X-Google-Smtp-Source: APXvYqyx3eQ6MmY6lEKQNaVOd6zUOTwINZmjCenBqWR0eRzLfwJZUlaEDxgGhTFqH0aEBe42riBwWUNUuDMXigO2Xik= X-Received: by 2002:a9d:7352:: with SMTP id l18mr7528706otk.292.1562107896465; Tue, 02 Jul 2019 15:51:36 -0700 (PDT) MIME-Version: 1.0 References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> In-Reply-To: <85d0is5ry1.fsf@gmail.com> From: Pip Cet Date: Tue, 2 Jul 2019 22:50:54 +0000 Message-ID: Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors To: Noam Postavsky Content-Type: multipart/mixed; boundary="000000000000452e05058cba9622" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: Michael Heerdegen , 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000452e05058cba9622 Content-Type: text/plain; charset="UTF-8" On Tue, Jul 2, 2019 at 4:20 PM Noam Postavsky wrote: > Michael Heerdegen writes: > > Pip Cet writes: > >> > Hmm - seems so, yes. I just made bootstrap with the commit > >> > included, and the problem is still gone. Strange thing, but seems > >> > there is nothing to fix. > >> > >> I'm not sure I agree. Something went wrong somewhere, or we wouldn't > >> have called byte code with what looks like an invalid hash table. > > > > Did you reply to the wrong thread - or - where is a connection to hash > > tables? > > The compiler translates repeated `eq' in a cond like that into a hash > and jump. See byte-compile-cond-use-jump-table. I think I found the problem. It's a bit tricky. When we purecopy the hash tables emitted by the byte code compiler, Vpurify_flag is a hash table with predicate 'equal. That means the ->next vectors for different hash tables now might refer to the same pure vector. Rehashing such a hash table thus destroys another hash table's ->next vector, so it shouldn't happen. pdumper.c forces rehashing of many hash tables, including pure ones. The attached patch "fixes" things, at a high price. I'll try coming up with a proper fix soon if no one beats me to it. (To reproduce the problem, I added these lines to fn.c: DEFSYM (QCrehash_size, ":rehash-size"); DEFSYM (QCrehash_threshold, ":rehash-threshold"); DEFSYM (QCweakness, ":weakness"); + DEFSYM (QCgroup, ":group"); + DEFSYM (QCversion, ":version"); + DEFSYM (QCpackage_version, ":package-version"); + DEFSYM (QClink, ":link"); + DEFSYM (QCload, ":load"); + DEFSYM (QCtag, ":tag"); + DEFSYM (QCset_after, ":set-after"); DEFSYM (Qkey, "key"); DEFSYM (Qvalue, "value"); ) --000000000000452e05058cba9622 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-bug-36477.patch" Content-Disposition: attachment; filename="0001-Fix-bug-36477.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxmeo6un0 RnJvbSAyMGI2M2RjZTE2OTVjZmMyZGZhOTQ5NjFkMDNkYTg4YTRjY2VhZmZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBUdWUs IDIgSnVsIDIwMTkgMjI6NDg6MjMgKzAwMDAKU3ViamVjdDogW1BBVENIXSBGaXggYnVnIzM2NDc3 CgotLS0KIHNyYy9mbnMuYyB8IDUgKysrKysKIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMo KykKCmRpZmYgLS1naXQgYS9zcmMvZm5zLmMgYi9zcmMvZm5zLmMKaW5kZXggMmZjMDAwYTdmNC4u Mzc1YjdkMjg0MSAxMDA2NDQKLS0tIGEvc3JjL2Zucy5jCisrKyBiL3NyYy9mbnMuYwpAQCAtNDIy Myw2ICs0MjIzLDExIEBAIGhhc2hfdGFibGVfcmVoYXNoIChzdHJ1Y3QgTGlzcF9IYXNoX1RhYmxl ICpoKQogewogICBwdHJkaWZmX3Qgc2l6ZSA9IEhBU0hfVEFCTEVfU0laRSAoaCk7CiAKKyAgaC0+ bmV4dCA9IEZjb3B5X3NlcXVlbmNlIChoLT5uZXh0KTsKKyAgaC0+aW5kZXggPSBGY29weV9zZXF1 ZW5jZSAoaC0+aW5kZXgpOworICBoLT5oYXNoID0gRmNvcHlfc2VxdWVuY2UgKGgtPmhhc2gpOwor ICBoLT5rZXlfYW5kX3ZhbHVlID0gRmNvcHlfc2VxdWVuY2UgKGgtPmtleV9hbmRfdmFsdWUpOwor CiAgIC8qIFJlY29tcHV0ZSB0aGUgYWN0dWFsIGhhc2ggY29kZXMgZm9yIGVhY2ggZW50cnkgaW4g dGhlIHRhYmxlLgogICAgICBPcmRlciBpcyBzdGlsbCBpbnZhbGlkLiAgKi8KICAgZm9yIChwdHJk aWZmX3QgaSA9IDA7IGkgPCBzaXplOyArK2kpCi0tIAoyLjIwLjEKCg== --000000000000452e05058cba9622-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 03 07:58:42 2019 Received: (at 36447) by debbugs.gnu.org; 3 Jul 2019 11:58:42 +0000 Received: from localhost ([127.0.0.1]:48508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiduM-0005Vm-BU for submit@debbugs.gnu.org; Wed, 03 Jul 2019 07:58:42 -0400 Received: from mail-oi1-f176.google.com ([209.85.167.176]:40515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiduK-0005VZ-AT for 36447@debbugs.gnu.org; Wed, 03 Jul 2019 07:58:40 -0400 Received: by mail-oi1-f176.google.com with SMTP id w196so1812990oie.7 for <36447@debbugs.gnu.org>; Wed, 03 Jul 2019 04:58:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mywJ75uQhBXf9WTvlJVUD4FV0gR5TJbOb5Uwz61NVfc=; b=hkEE/Ot4nv2KujJ+1zJKAdIvVns23l+4N9bGT2dgc6HYDKal9z1D1QpyLWks4J7cOh 45g7QHEKxu+dl0JfXu4Y+E0zkpSzQwi4yiIfJ1H0z8a2sas9jUkRi+Ycv0YMcRl/8WdX Lh7EjRi0JXltrufJTYHb2fuKUfXzMZD4vBMSo6IYctkgC9e2zYh6pQMNGG/INxRXH8vb XLlVdTHpiN1TA8pl4sqIgynvOyMgO7rkXxbrm8efsYDZi06gWz8wzyQjXGOreknGRLfO qE8LEwabzFPNGDdBbQZekA/4yfvcnlB8iMGiTfALDHSv2hsvKq95+HosobZ0NZ8tYKil Efnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mywJ75uQhBXf9WTvlJVUD4FV0gR5TJbOb5Uwz61NVfc=; b=uDZecVLK4ptG2WGn8d4p1ufbbWiHT899qrvHfMksfNGdSfDSmq+r+KRNkR3exUCWxO pfHAgGBLLqyD4dn7lKD9IgNppiTySz6cqp46cn2c+txvIy9+o217RxTb6bKoUTzfLvrJ XhqwesX8y4xEtF3sqjReV+7frCLqQR5r/DqYt8p83SlWJBPxbHIaxXeFvA84eqL2vveq +VdVfKMbkZdYgDC73G1kRulQlPNuj28zHCmCWd0gV4lSWMb0/Tch3NtQ8c/X7G7jLO04 QoRGQSsizEl2hfe6MQbXhVeonSM5TTfSwmTRdNGX68YkPVlRbXaCqsRob9HMvoCFT3W5 58pg== X-Gm-Message-State: APjAAAUN9odoDlkuQrPnbgPQMGGmMUiFwzwgGy73htxWwSABOfCOHoaa HS49Y4pEjVjrlbhIPQDAdAzq6ZVSiRQVjxVZQEk= X-Google-Smtp-Source: APXvYqxti0ZQH9eZo3ysr02KcE5CQMI5AJHHwGOceWPKXvBKJv2mz6+RjfVKZ5tfnOqDYZ9zIPcNOc7zjarMWgvX/nY= X-Received: by 2002:aca:4790:: with SMTP id u138mr3263471oia.44.1562155114612; Wed, 03 Jul 2019 04:58:34 -0700 (PDT) MIME-Version: 1.0 References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> In-Reply-To: From: Pip Cet Date: Wed, 3 Jul 2019 11:57:52 +0000 Message-ID: Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors To: Noam Postavsky Content-Type: multipart/mixed; boundary="000000000000b0f333058cc59446" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: Michael Heerdegen , 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000b0f333058cc59446 Content-Type: text/plain; charset="UTF-8" On Tue, Jul 2, 2019 at 10:50 PM Pip Cet wrote: > > The compiler translates repeated `eq' in a cond like that into a hash > > and jump. See byte-compile-cond-use-jump-table. > > I think I found the problem. It's a bit tricky. I'm attaching a patch which modifies standard Emacs in what should be harmless ways, but demonstrates the bug. As far as I can tell, this is a serious issue that will pop up seemingly at random. We really should fix it. However, I thought hash_table_rehash was called more often than it actually is, so the fix should be simple: just copy-sequence a hash table's ->next, ->hash, and ->index vectors before rehashing. (->key_and_value isn't actually modified, so it's safe to share between (read-only) hash tables. What's happening is this: Purecopied hash tables share structure, particularly the ->next vector, with similar but different purecopied hash tables. Some purecopied hash tables dumped with pdumper are rehashed upon first access after loading the dump (in the example, this is the tables which map 'dummy-symbol to t), while others are not (the tables with just fixnums as keys). If a hash table is rehashed, it's ->next vector will change to reflect the changed hash (of 'dummy-symbol); however, the non-rehashed table that shares the ->next vector will be confused: its key_and_value array will stay the same, and valid, but the ->next vector will no longer match it. In practice, this means (gethash valid-key hash-table) will return nil even though the key is valid. While the attached patch appears to work, I would prefer simply dumping hash tables with nil values for ->next, ->hash, and ->index, and rebuilding the entire hash table upon first access. This would also allow us to switch to secure randomized hashes should the need arise. --000000000000b0f333058cc59446 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Test-bug-36447.patch" Content-Disposition: attachment; filename="0001-Test-bug-36447.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxn6ridi0 RnJvbSA4ZmU0NjRkYmIwMzBhNzIyY2ExNzNjNDQyOTA2NDgyZWYyMTBmNDZlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBXZWQs IDMgSnVsIDIwMTkgMTE6Mjc6NTAgKzAwMDAKU3ViamVjdDogW1BBVENIIDEvMl0gVGVzdCBidWcj MzY0NDcKCi0tLQogbGlzcC9jdXN0b20uZWwgfCAxMCArKysrKysrKysrCiBzcmMvcHVyZXNpemUu aCB8ICAyICstCiB0ZXN0LWN1c3RvbS5lbCB8IDEyICsrKysrKysrKysrKwogMyBmaWxlcyBjaGFu Z2VkLCAyMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQg dGVzdC1jdXN0b20uZWwKCmRpZmYgLS1naXQgYS9saXNwL2N1c3RvbS5lbCBiL2xpc3AvY3VzdG9t LmVsCmluZGV4IDczNjQ2MGZlYzcuLmM0OTMyMWI4MjkgMTAwNjQ0Ci0tLSBhL2xpc3AvY3VzdG9t LmVsCisrKyBiL2xpc3AvY3VzdG9tLmVsCkBAIC0zNSw2ICszNSwxNiBAQAogCiAocmVxdWlyZSAn d2lkZ2V0KQogCisoZGVmdmFyIGhhc2gtdGFibGVzIChtYWtlLXZlY3RvciAyNTYgbmlsKSkKKwor KGRvdGltZXMgKGkgMjU2KQorICAobGV0ICgoaHQgKG1ha2UtaGFzaC10YWJsZSA6cHVyZWNvcHkg dCA6c2l6ZSAyIDp0ZXN0ICdlcSkpKQorICAgICh3aGVuICg9ICglIGkgMykgMCkKKyAgICAgIChw dXRoYXNoICdkdW1teS1zeW1ib2wgdCBodCkpCisgICAgKGRvdGltZXMgKGogMTYpCisgICAgICAo cHV0aGFzaCAobG9nYW5kIGkgKGxzaCAxIGopKSB0IGh0KSkKKyAgICAoYXNldCBoYXNoLXRhYmxl cyBpIChwdXJlY29weSBodCkpKSkKKwogKGRlZnZhciBjdXN0b20tZGVmaW5lLWhvb2sgbmlsCiAg IDs7IEN1c3RvbWl6ZSBpbmZvcm1hdGlvbiBmb3IgdGhpcyBvcHRpb24gaXMgaW4gYGN1cy1lZGl0 LmVsJy4KICAgIkhvb2sgY2FsbGVkIGFmdGVyIGRlZmluaW5nIGVhY2ggY3VzdG9taXplIG9wdGlv bi4iKQpkaWZmIC0tZ2l0IGEvc3JjL3B1cmVzaXplLmggYi9zcmMvcHVyZXNpemUuaAppbmRleCBm NWZhZDhiNDJiLi5kMjllM2U4MGRmIDEwMDY0NAotLS0gYS9zcmMvcHVyZXNpemUuaAorKysgYi9z cmMvcHVyZXNpemUuaApAQCAtNDcsNyArNDcsNyBAQCAjZGVmaW5lIFNJVEVMT0FEX1BVUkVTSVpF X0VYVFJBIDAKICNlbmRpZgogCiAjaWZuZGVmIEJBU0VfUFVSRVNJWkUKLSNkZWZpbmUgQkFTRV9Q VVJFU0laRSAoMjAwMDAwMCArIFNZU1RFTV9QVVJFU0laRV9FWFRSQSArIFNJVEVMT0FEX1BVUkVT SVpFX0VYVFJBKQorI2RlZmluZSBCQVNFX1BVUkVTSVpFICg4MDAwMDAwMCArIFNZU1RFTV9QVVJF U0laRV9FWFRSQSArIFNJVEVMT0FEX1BVUkVTSVpFX0VYVFJBKQogI2VuZGlmCiAKIC8qIEluY3Jl YXNlIEJBU0VfUFVSRVNJWkUgYnkgYSByYXRpbyBkZXBlbmRpbmcgb24gdGhlIG1hY2hpbmUncyB3 b3JkIHNpemUuICAqLwpkaWZmIC0tZ2l0IGEvdGVzdC1jdXN0b20uZWwgYi90ZXN0LWN1c3RvbS5l bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwLi5iODcxZDMwY2ZhCi0tLSAv ZGV2L251bGwKKysrIGIvdGVzdC1jdXN0b20uZWwKQEAgLTAsMCArMSwxMiBAQAorKGRvdGltZXMg KGkgMjU2KQorICAobGV0ICgoaHQgKGFyZWYgaGFzaC10YWJsZXMgaSkpKQorICAgIChkb3RpbWVz IChqIDE2KQorICAgICAgKHVubGVzcyAoZXEgKC89IDAgKGxvZ2FuZCAobHNoIDEgaikgaSkpCisg ICAgICAgICAgICAgICAgICAoZ2V0aGFzaCAobHNoIDEgaikgaHQpKQorICAgICAgICAoZXJyb3Ig Imhhc2ggdGFibGUgY29ycnVwdGlvbiBhdCB0YWJsZSAlUywgYml0ICVTIiBpIGopKSkpKQorCiso YXJlZiBoYXNoLXRhYmxlcyAxNykKKzs7ICNzKGhhc2gtdGFibGUgc2l6ZSAzIHRlc3QgZXEgcmVo YXNoLXNpemUgMS41IHJlaGFzaC10aHJlc2hvbGQgMC44MTI1IHB1cmVjb3B5IHQgZGF0YSAoMSB0 IDAgdCAxNiB0KSkKKworKGdldGhhc2ggMSAoYXJlZiBoYXNoLXRhYmxlcyAxNykpCis7OyBuaWwK LS0gCjIuMjAuMQoK --000000000000b0f333058cc59446 Content-Type: text/x-patch; charset="US-ASCII"; name="0002-Don-t-alter-shared-structure-in-dumped-purecopied-ha.patch" Content-Disposition: attachment; filename="0002-Don-t-alter-shared-structure-in-dumped-purecopied-ha.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxn6rlog1 RnJvbSA3MDQxOWY2MzBmNjA5MTljODY0NWExMGFlZWY4ZDI5OWY1MDk4ZmY1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBXZWQs IDMgSnVsIDIwMTkgMTE6NDg6MjIgKzAwMDAKU3ViamVjdDogW1BBVENIIDIvMl0gRG9uJ3QgYWx0 ZXIgc2hhcmVkIHN0cnVjdHVyZSBpbiBkdW1wZWQgcHVyZWNvcGllZCBoYXNoCiB0YWJsZXMuCgoq IHNyYy9mbnMuYyAoaGFzaF90YWJsZV9yZWhhc2gpOiBNYWtlIHN1cmUgd2UncmUgb3BlcmF0aW5n IG9uCmZyZXNoIGNvcGllcyBvZiAtPm5leHQsIC0+aW5kZXgsIC0+aGFzaC4KLS0tCiBzcmMvZm5z LmMgfCA2ICsrKysrKwogMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdp dCBhL3NyYy9mbnMuYyBiL3NyYy9mbnMuYwppbmRleCAyZmMwMDBhN2Y0Li40NGQyZGU1MjNhIDEw MDY0NAotLS0gYS9zcmMvZm5zLmMKKysrIGIvc3JjL2Zucy5jCkBAIC00MjIzLDYgKzQyMjMsMTIg QEAgaGFzaF90YWJsZV9yZWhhc2ggKHN0cnVjdCBMaXNwX0hhc2hfVGFibGUgKmgpCiB7CiAgIHB0 cmRpZmZfdCBzaXplID0gSEFTSF9UQUJMRV9TSVpFIChoKTsKIAorICAvKiBUaGVzZSBzdHJ1Y3R1 cmVzIG1heSBoYXZlIGJlZW4gcHVyZWNvcGllZCBhbmQgc2hhcmVkCisgICAgIChidWcjMzY0NDcp LiAgKi8KKyAgaC0+bmV4dCA9IEZjb3B5X3NlcXVlbmNlIChoLT5uZXh0KTsKKyAgaC0+aW5kZXgg PSBGY29weV9zZXF1ZW5jZSAoaC0+aW5kZXgpOworICBoLT5oYXNoID0gRmNvcHlfc2VxdWVuY2Ug KGgtPmhhc2gpOworCiAgIC8qIFJlY29tcHV0ZSB0aGUgYWN0dWFsIGhhc2ggY29kZXMgZm9yIGVh Y2ggZW50cnkgaW4gdGhlIHRhYmxlLgogICAgICBPcmRlciBpcyBzdGlsbCBpbnZhbGlkLiAgKi8K ICAgZm9yIChwdHJkaWZmX3QgaSA9IDA7IGkgPCBzaXplOyArK2kpCi0tIAoyLjIwLjEKCg== --000000000000b0f333058cc59446-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 04 22:04:57 2019 Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 02:04:57 +0000 Received: from localhost ([127.0.0.1]:52187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjDar-0003gm-4q for submit@debbugs.gnu.org; Thu, 04 Jul 2019 22:04:57 -0400 Received: from mout.web.de ([212.227.15.3]:43225) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjDao-0003gT-Pk for 36447@debbugs.gnu.org; Thu, 04 Jul 2019 22:04:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1562292284; bh=zsU88XV/NM+wToCkRQ8tuZKY9RsaKBo2zUI/nS4SwGs=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=mkN82J9dJIMaA50rMg5U2oHv1HUzGsRDcDd1GR0nZwK52M7x3YKbvOmXAJ3OtJ7zL 7e4tFlZs/Eh/ZCfaWoHkAz+i8SQrKE9Ozqafiy7JY9e5jL7Rg2WKsb955bc9UH/UVS 1cJNrv0DJatauu0GR7Q6yS3DL61bVPCRr4oaQzII= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([88.66.71.116]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MeSYJ-1hsuZR42xj-00QB2z; Fri, 05 Jul 2019 03:59:39 +0200 From: Michael Heerdegen To: Pip Cet Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> Date: Fri, 05 Jul 2019 03:59:35 +0200 In-Reply-To: (Pip Cet's message of "Wed, 3 Jul 2019 11:57:52 +0000") Message-ID: <87lfxdgs1k.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:vDnvkSS2g8qXwviYkzkDuS1ZdRM+k5tFDB4p5lWu0k5mOi6OENS a85/zFZvc8q3a1EaqNdHPCMQm54Jx+UpY/G48LKqo49y4dObHk6ZXxP55svt1+5UMkc1XyP suFMjEX/sM78JrT1vua5tYwf1sxNRF1LSCIOpvye6H3jZ4ZyZTtFiHrbHGOGVoB9uySdRmh 7U9DboPPVNvADjjrdOpkQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:dv7tuZ3WDBI=:nVj6t1wkYSLyFl5Zr0tQ6K ZWSiOeQO93Y53U7XV8hXSu2p3X5MXDcXIzMQOTcDll0FGx5+Yl5SaWI3CE9zKoKH8dUyWUwXv jmh2R90ELV87x7J2A4rclkQNYQHYHM65d+MoA6XOgbqj6M1GOf70KPNcv4F4s6s8AbmfGp1Vi ecoajiQB/LOEt7CgUT/bzlNuA1n9JVuhBnc0OHn8p/ZwyYmhVmHh8tuQjYmdSTSj53KeA3cW+ cGImeKaPBvKB3UzmzxVU/91pIaOKjpbgiq/w1/JwLaC7LSWRqTHC/IJDuWG1JbXCj0ExpEGSQ gURE48iADKzslF626NuGceb0rpgguqjSBXFixe8tsIbRKw9efBzB0YUTskw8Rqg7q77H5lxHD fUj6RUugHITQzMfF61gO4QK0MJ8/ox3J+/EkJ+lS7Y1pER/h6JR1k+bYGhMxphfQNIb7kGB8+ LfDtkFJTrKN2YUwz1ulHhQDBkxOY/ZQztPvAJ+KJ5/WlTrptNWxsPHzIXaXiXjEuIbcCFnaqy a4deeg4NqI5ENh9Dq4XimVvr3jLd7MFe4Pu179Vh7i6ndom18m60voRq+WcA4yAtRqWepXkTi Gg/Jv2OC6BFGRWgGrZezXDIRbBjw66J1HPepRsAe+jVQY+C3dlMR9GJhpaSwzfiFtdGU/Gx2m 1cjpaOuLgvhOddwfdhHNebwP/6TMUsegErRolGQaLosa8T/kl4Mkg02I+kPKV/AC5n0S/QYM1 yZAay8VDrH9VC76rkYcNa9KKKZCfxqmodcW4va7M36iPf5mHQu4NMhzlMW6hh7Dk58McriOou DyolumdbJwtXrah76RwUsg+swg0YcU0k/T+B4czgWxViBe8SuNnxzJM3gbjn4Tj6WAw1gb9M5 FXujo5Gof0rNPTFJhR2xDWeNrWTl/Emmmd2snqD2ujtXDQcjmp9AnQFpYEDWANKn4bZY/ddg+ 3BqpJkfmaXqSqScv2t8sPrFq7IyS/iTWJrtP01dtswNsav6xmworcoKUB3FRed9c3hFEFTwGe 0R/aTDrO9t9LY3mcJ2LvPJYtgi8aXnqZI7D6dfiBJ2XvT2DL/hiolSlM9wYMvr2xEAm/UeJkV 99yUktLnO9/Kp1Hn9rL0XQF6b8v6gpMc8CX X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: Noam Postavsky , 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pip Cet writes: > As far as I can tell, this is a serious issue that will pop up > seemingly at random. We really should fix it. Yeah, it just happened again, when rebuilding a newer master version. And this time, cleaning and make bootstrap didn't fix it. I still use the broken build FWIW as it's not as broken as the last time. Anything I should do or try with it? Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 02:36:01 2019 Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 06:36:01 +0000 Received: from localhost ([127.0.0.1]:52255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjHp8-0001fl-QV for submit@debbugs.gnu.org; Fri, 05 Jul 2019 02:36:00 -0400 Received: from mail-ot1-f45.google.com ([209.85.210.45]:33252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjHp6-0001fX-9Z for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 02:35:57 -0400 Received: by mail-ot1-f45.google.com with SMTP id q20so8065618otl.0 for <36447@debbugs.gnu.org>; Thu, 04 Jul 2019 23:35:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WprKBNc0i70C6XIOHp1glJcnhXfRV8HwjEk4Hgpm7fc=; b=GXmX6rLZMxxQOlyUIYU6wOJyVkkfV6BpkioMCMAMmpKR1ofIv3us659/XA/OtBDf6/ ee3232efdyLBs1Pd9pmwmi1hNPUGapqcPgw0Ss1x7l8THERS0fTrik9W/BJEEYs0X4U5 KU4dEdulrANJkpKp6U4CnUj9EJCX11oM9A/UpNUCFT/jhTlF5uhNj2SgxUH0rjXeHbEF +aiGTXLRHvV6RV4kV+6bwT+oj1Z5kAXdMtO2GSwQFspOjlApHXA7wWcHRh3PGIHKVM43 uboiqAVSf4MDvBX0U7OhSb+8B6VYvjz+tGjDTrTfWA7vbCgk+ch5GyhBSNSFZO907AjF Gzhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WprKBNc0i70C6XIOHp1glJcnhXfRV8HwjEk4Hgpm7fc=; b=MFxGj+O+jL5gJoV+vXhOJ2sjy+Pww5Y40ySU0DYoU5EaTSHMiAPhO6MWMWT167L6Fl 4vSOMZIa4+LlX8hkPFPXtuFqN7+Or3KiuxxmVaZU4P/ECMcmAO9oJxCQ0k8h0CHZZWl3 +adPp5iMbFcPePkVu01cCe45QZLuOcW593mn0lfsHTjYZiV9WR/p9asuBWtZVOpQgKFV UHO8EPLXllgL5FL7YTx8mLlaED2Z2bU0FuXAEtQDzDQpOJLo4HwGE8FeB+H6R2L1brxu MMGpGazqPItGuIAoUQ6QoPluq7PrO8ZrnUJaXlvpHN1BvRhfaIWms4D6dWo+CUgqHonR +/rA== X-Gm-Message-State: APjAAAXzloW8PdZ6NRJfyXbws56pHBnBHfKt9fZ1UigHM+eKhSbidNnu RVCd0HydbMZ1f3jYs8b1Ar5NTBjA9JdFS5pNZdo= X-Google-Smtp-Source: APXvYqwuF/K+wtEfTO7tw4VUjGWFFInIncj/XKPhiM0Lifan8kgh/89IdyHpiDwOdBYQcPUI4Dl5vtk8xcw3gVRPxHU= X-Received: by 2002:a9d:2385:: with SMTP id t5mr757911otb.210.1562308550584; Thu, 04 Jul 2019 23:35:50 -0700 (PDT) MIME-Version: 1.0 References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> In-Reply-To: <87lfxdgs1k.fsf@web.de> From: Pip Cet Date: Fri, 5 Jul 2019 06:35:03 +0000 Message-ID: Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors To: Michael Heerdegen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 36447 Cc: Noam Postavsky , 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.1 (-) On Fri, Jul 5, 2019 at 1:59 AM Michael Heerdegen wrote: > > Pip Cet writes: > > > As far as I can tell, this is a serious issue that will pop up > > seemingly at random. We really should fix it. > > Yeah, it just happened again, when rebuilding a newer master version. > And this time, cleaning and make bootstrap didn't fix it. I still use > the broken build FWIW as it's not as broken as the last time. Is it still the same symptom, though? > Anything I should do or try with it? I'd like to verify it's indeed the bug I think it is. I think I could figure that out if I had access to your Emacs binaries (emacs and emacs.pdmp), but you can also debug things locally. Can you do the following? 1. Run in gdb, with ASLR disabled 2. Set a breakpoint in print_vectorlike ("b print_vectorlike") 3. evaluate, in Emacs, (aref (aref (symbol-function #'custom-handle-keyword) 2) 2) 4. wait for the breakpoint to be hit 5. in GDB, disable the breakpoint ("dis") 6. print and prettyprint the hash's next, hash, index, and key_and_value vectors by typing, in gdb p XHASH_TABLE(obj)->next pp XHASH_TABLE(obj)->next p XHASH_TABLE(obj)->hash pp XHASH_TABLE(obj)->hash p XHASH_TABLE(obj)->index pp XHASH_TABLE(obj)->index p XHASH_TABLE(obj)->key_and_value pp XHASH_TABLE(obj)->key_and_value (maybe you need to go up a stack frame or two so obj isn't optimized away). 7. Set a read/write breakpoint on the index table: rwatch -l *(long *)&XHASH_TABLE(obj)->index watch -l *(long *)XHASH_TABLE(obj)->index 8. Rerun emacs with gdb's "r" command, and find out where the watchpoint is hit. In particular, if I'm right, it's accessed from two different hash table objects. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 03:50:43 2019 Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 07:50:43 +0000 Received: from localhost ([127.0.0.1]:52286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjIzS-0003S9-TZ for submit@debbugs.gnu.org; Fri, 05 Jul 2019 03:50:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjIzR-0003Rx-Ng for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 03:50:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hjIzM-0004Yh-8I; Fri, 05 Jul 2019 03:50:36 -0400 Received: from [176.228.60.248] (port=3147 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hjIzK-00016B-56; Fri, 05 Jul 2019 03:50:35 -0400 Date: Fri, 05 Jul 2019 10:50:26 +0300 Message-Id: <83y31capj1.fsf@gnu.org> From: Eli Zaretskii To: Pip Cet In-reply-to: (message from Pip Cet on Fri, 5 Jul 2019 06:35:03 +0000) Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Pip Cet > Date: Fri, 5 Jul 2019 06:35:03 +0000 > Cc: Noam Postavsky , 36447@debbugs.gnu.org > > 7. Set a read/write breakpoint on the index table: > > rwatch -l *(long *)&XHASH_TABLE(obj)->index > watch -l *(long *)XHASH_TABLE(obj)->index I think this is the same as awatch -l *(long *)XHASH_TABLE(obj)->index From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 03:56:03 2019 Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 07:56:03 +0000 Received: from localhost ([127.0.0.1]:52292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjJ4d-0003aM-Jp for submit@debbugs.gnu.org; Fri, 05 Jul 2019 03:56:03 -0400 Received: from beige.elm.relay.mailchannels.net ([23.83.212.16]:41570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjJ4a-0003Zu-0a for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 03:56:01 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 631941A1C74; Fri, 5 Jul 2019 07:55:58 +0000 (UTC) Received: from hampton.hostforweb.net (100-96-14-11.trex.outbound.svc.cluster.local [100.96.14.11]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 64D631A1CAF; Fri, 5 Jul 2019 07:55:57 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from hampton.hostforweb.net ([TEMPUNAVAIL]. [172.245.115.217]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Fri, 05 Jul 2019 07:55:58 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Broad-Supply: 0cf7570f1fe9d8aa_1562313358034_4012017263 X-MC-Loop-Signature: 1562313358034:1624456509 X-MC-Ingress-Time: 1562313358034 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hjJ4P-009wgB-Ih; Fri, 05 Jul 2019 02:55:50 -0500 Date: Fri, 05 Jul 2019 16:55:46 +0900 Message-ID: From: Katsumi Yamaoka To: Pip Cet Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-cygwin) Cancel-Lock: sha1:ycjwqUP29mq7J5x6hzUltTsL1pw= MIME-Version: 1.0 Content-Type: text/plain; charset="iso-2022-jp" X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: Michael Heerdegen , Noam Postavsky , 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, 05 Jul 2019 06:35:03 +0000, Pip Cet wrote: > On Fri, Jul 5, 2019 at 1:59 AM Michael Heerdegen >> Yeah, it just happened again, when rebuilding a newer master version. >> And this time, cleaning and make bootstrap didn't fix it. I still use >> the broken build FWIW as it's not as broken as the last time. > Is it still the same symptom, though? Me too, but I can use the latest master as usual by adding (load "custom" nil t) to the beginning of the ~/.emacs file. [...] > Can you do the following? > 1. Run in gdb, with ASLR disabled [...] Unfortunately gdb on Cygwin will probably crash, so I'll wait for someone to fix it. Thanks. In GNU Emacs 27.0.50 (build 1, x86_64-pc-cygwin, GTK+ Version 3.22.28) of 2019-07-05 built on localhost Windowing system distributor 'The Cygwin/X Project', version 11.0.12004000 From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 04:12:52 2019 Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 08:12:52 +0000 Received: from localhost ([127.0.0.1]:52315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjJKu-00040C-D2 for submit@debbugs.gnu.org; Fri, 05 Jul 2019 04:12:52 -0400 Received: from mail-oi1-f176.google.com ([209.85.167.176]:35991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjJKs-0003zz-7m for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 04:12:50 -0400 Received: by mail-oi1-f176.google.com with SMTP id w7so6590404oic.3 for <36447@debbugs.gnu.org>; Fri, 05 Jul 2019 01:12:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s1zh9bfK5Eh+nBUk2jjex+95H2KX4EGsBNGCCYyjhww=; b=rNz6M4nlTRPPEoiCu5G5F278U80Rd29JoXGB0dipS5YZjuUmob60rOxQjZx17weO6R 6DzjdZK/2ypDkfgW7vSm5W8aitFl1be29tBXOrEWbTNeveBNa9Ee2Boyo1llhmH0Jr4y YU6SWIjZVc1q+DhwuE1ea+FtIjB9+pcOrze4DPMpe1Ejzq+IRWg5jrP8xDw+NfbSFMfi Qp3VX8yCYFFss8MvI4RAJTg6/4RZKKMC1syxOKCetelm/NgxLCHwANxoHc+JNaatEepH ia53SiNzA7kTxvSfdm0plqouX0Z6nyEApGOPFTj1BckRXn+cbh6KTzrPybez60PXABp/ ETLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s1zh9bfK5Eh+nBUk2jjex+95H2KX4EGsBNGCCYyjhww=; b=PKFUlGSyi9NgruN4bE+QmqNHI8B03kFObipoVjruEnz9u7fhxCVXUWFlwhv6AyHTQC rtQ8HsuOxb3bVUVTCRrSv2UgUZrhOct1Zlb5ySzr/NZB6Ng/lLH2ktZiNDsVqDSxXSOy sHoKznTiFDiqztRh6V+tYznQze8ZKX2V9KfLL38i8l6+PG/ROlSFuYW30MhJYS49rF/T Li9NbHQVU4kLBpAFYaXdXxTkD7Cv7QnUfxP24hjZ9GtrdLqUQDEce611iWpwPBTHqJBL 7SpU5gn04MaFPQ7Figti3oHJkrhRU8cYVZRvKbgF1ec5Pq0sDvHv7ocxhQRJWAXfchdG 20MA== X-Gm-Message-State: APjAAAVwb0H/QwRIAoKrLu4uIzU2Lo0ibB7uIB9ySpsqTRVm8xorPa8G rF4MYX3mKzW8QwzFZRj0MOR+adShUjdWXaS0uXw= X-Google-Smtp-Source: APXvYqymoYh/ZQ4NCujPKk+jpwwTk4KZlYSiOGek/3reB0rlA1iSo/h6cj3RifbqFhSSgNsiNRduthO4XXw92HaJYkE= X-Received: by 2002:aca:2303:: with SMTP id e3mr1200335oie.112.1562314364341; Fri, 05 Jul 2019 01:12:44 -0700 (PDT) MIME-Version: 1.0 References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> In-Reply-To: <83y31capj1.fsf@gnu.org> From: Pip Cet Date: Fri, 5 Jul 2019 08:12:07 +0000 Message-ID: Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Jul 5, 2019 at 7:50 AM Eli Zaretskii wrote: > > rwatch -l *(long *)&XHASH_TABLE(obj)->index > > watch -l *(long *)XHASH_TABLE(obj)->index > > I think this is the same as > > awatch -l *(long *)XHASH_TABLE(obj)->index Thanks for checking! What I actually meant was awatch -l *(long *)&XHASH_TABLE(obj)->index With revision 44f199648b0c986a0ac7608f4e9d803c619ae2d6, I can reproduce this problem locally, and I can confirm it's as I thought: y-or-no-p and custom-handle-keyword both generate 7-element hash tables. They share a ->next vector. Both try to rehash the hash table, and since there are non-builtin symbols in there, the new hash collision chains should differ, but can't, since they share a vector. I don't think we can sensibly add tests for this bug, but the fix I posted earlier still seems valid to me. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 04:25:52 2019 Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 08:25:52 +0000 Received: from localhost ([127.0.0.1]:52332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjJXT-0004K8-Uz for submit@debbugs.gnu.org; Fri, 05 Jul 2019 04:25:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjJXR-0004Ju-Ts for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 04:25:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hjJXM-0008N4-DT; Fri, 05 Jul 2019 04:25:44 -0400 Received: from [176.228.60.248] (port=1398 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hjJXI-0000xp-Gh; Fri, 05 Jul 2019 04:25:44 -0400 Date: Fri, 05 Jul 2019 11:25:33 +0300 Message-Id: <83tvc0anwi.fsf@gnu.org> From: Eli Zaretskii To: Pip Cet In-reply-to: (message from Pip Cet on Fri, 5 Jul 2019 08:12:07 +0000) Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Pip Cet > Date: Fri, 5 Jul 2019 08:12:07 +0000 > Cc: michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org > > On Fri, Jul 5, 2019 at 7:50 AM Eli Zaretskii wrote: > > > rwatch -l *(long *)&XHASH_TABLE(obj)->index > > > watch -l *(long *)XHASH_TABLE(obj)->index > > > > I think this is the same as > > > > awatch -l *(long *)XHASH_TABLE(obj)->index > > Thanks for checking! What I actually meant was > awatch -l *(long *)&XHASH_TABLE(obj)->index But then why do you need the rwatch as well? awatch breaks both on read accesses and on write accesses. > With revision 44f199648b0c986a0ac7608f4e9d803c619ae2d6, I can > reproduce this problem locally, and I can confirm it's as I thought: > > y-or-no-p and custom-handle-keyword both generate 7-element hash > tables. They share a ->next vector. Both try to rehash the hash table, > and since there are non-builtin symbols in there, the new hash > collision chains should differ, but can't, since they share a vector. > > I don't think we can sensibly add tests for this bug, but the fix I > posted earlier still seems valid to me. Sorry, I'm not tracking this part of the discussion, as it lost me long ago. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 04:37:45 2019 Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 08:37:45 +0000 Received: from localhost ([127.0.0.1]:52348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjJiy-0004di-SU for submit@debbugs.gnu.org; Fri, 05 Jul 2019 04:37:45 -0400 Received: from mail-oi1-f178.google.com ([209.85.167.178]:39491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjJiu-0004dQ-OG for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 04:37:43 -0400 Received: by mail-oi1-f178.google.com with SMTP id m202so6631564oig.6 for <36447@debbugs.gnu.org>; Fri, 05 Jul 2019 01:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t+I0X1RAwjppP9dmGwdnbIUbwAz9LEVmRtuvj6jNi5s=; b=jzzKSydcfoqM/DI58n7R35FrFWQSoGgC6ozAnj6fAG4bNc3/ot08XAuR0hC7GKiWKZ gEhidc/PsC3+B0EsdkWaC3EYJBSUogS2JI5oIbUXfKNtJGfR3DOhWHBYTfDH6fPfB42h dr9NIH71KsOsInx0ssSzbkYRZ2Kn43j3NKiwmcKvyuzhM7653Blg039ACvICm1Cke9kQ 4sL/U8m4TKHXRsZz7XK0ML0O/9zOM15KIYgy65BIK/g9Z8Fl9uq/vjh5Yr/K2eexFExc FnMDQS7o3BG/Cms2fbvKNb6g+Ixc67a1qncKYc9KPfW19nb/6UGMJrqof4LfuxAarV5e oAKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t+I0X1RAwjppP9dmGwdnbIUbwAz9LEVmRtuvj6jNi5s=; b=Go2Lrq6iUKcXA/CkdnwrCaAFgMyHmgxasQAje+GLRqAHJjZAuAlMD0hzVUmMJUguDd SYm4DhRMhN6P9YePJLmxbjQ7Xyi4Xf5Tj2Kc2iFTIhBMC4ihjApFCLzYL1Kb+a41/Rm6 18LAsbp14CMu5OytRWs15ypfUMrfKEa76LtKPOpPNmSmwTgc9Kk/XoWXFjEwvpXIOldP DNh55JDGfDv1jGBBaoPClTi4BapdNdWjfgwsHL99pQp4SOuaHhYVU8W1mUZ8fgv4c5b6 HEyCRKr/q5lUHAkCpiyrZW2VrZc6x9urQCfMovEInAT0DP2qqNuSE5d77gKZmiWixmd4 xMqg== X-Gm-Message-State: APjAAAUg8PToq1398RcCkI+LrqZIMTikCGPLQIzFpGRM8GorJZIOVYg0 wMfNO/hKCTxDHth5Sf+wAGCdNkxnRWaPo4alsek= X-Google-Smtp-Source: APXvYqy6NUXmGZyH4vyn7/F54y8DfYOWbfGFS0bqg35EKfwuGyKCnqNIrbgPFet67A+4hoMFf2CcBN7V8CuVyGU00uM= X-Received: by 2002:aca:aa93:: with SMTP id t141mr1368862oie.128.1562315854785; Fri, 05 Jul 2019 01:37:34 -0700 (PDT) MIME-Version: 1.0 References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> In-Reply-To: <83tvc0anwi.fsf@gnu.org> From: Pip Cet Date: Fri, 5 Jul 2019 08:36:57 +0000 Message-ID: Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.1 (-) On Fri, Jul 5, 2019 at 8:25 AM Eli Zaretskii wrote: > > From: Pip Cet > > Date: Fri, 5 Jul 2019 08:12:07 +0000 > > Cc: michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org > > > > On Fri, Jul 5, 2019 at 7:50 AM Eli Zaretskii wrote: > > > > rwatch -l *(long *)&XHASH_TABLE(obj)->index > > > > watch -l *(long *)XHASH_TABLE(obj)->index > > > > > > I think this is the same as > > > > > > awatch -l *(long *)XHASH_TABLE(obj)->index > > > > Thanks for checking! What I actually meant was > > awatch -l *(long *)&XHASH_TABLE(obj)->index > > But then why do you need the rwatch as well? awatch breaks both on > read accesses and on write accesses. I don't! Just the awatch is fine, thanks again for pointing it out. It's just that the argument needs a & or we're watching the wrong bit of memory. > > With revision 44f199648b0c986a0ac7608f4e9d803c619ae2d6, I can > > reproduce this problem locally, and I can confirm it's as I thought: > > > > y-or-no-p and custom-handle-keyword both generate 7-element hash > > tables. They share a ->next vector. Both try to rehash the hash table, > > and since there are non-builtin symbols in there, the new hash > > collision chains should differ, but can't, since they share a vector. I've since confirmed that this gdb session does not exhibit the bug: b hash_table_rehash Breakpoint 3 at 0x66bbb6: file fns.c, line 4224. (gdb) command 3 Type commands for breakpoint(s) 3, one per line. End with a line saying just "end". >p h->next = Fcopy_sequence(h->next) >c >end (gdb) r (this is on a CFLAGS="-O0 -g3 -ggdb" build, on GNU/Linux) > > I don't think we can sensibly add tests for this bug, but the fix I > > posted earlier still seems valid to me. > > Sorry, I'm not tracking this part of the discussion, as it lost me > long ago. What's the best way of getting this fixed? Current master is pretty unusable due to this bug, once you call `y-or-n-p' and `custom-handle-keyword', one of the two will stop working (unless you reload their bytecode files first, unsharing their collision chains). From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 04:41:44 2019 Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 08:41:45 +0000 Received: from localhost ([127.0.0.1]:52353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjJmq-0004k5-HJ for submit@debbugs.gnu.org; Fri, 05 Jul 2019 04:41:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjJmo-0004jt-Sx for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 04:41:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hjJmj-0005w4-9b; Fri, 05 Jul 2019 04:41:37 -0400 Received: from [176.228.60.248] (port=2367 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hjJmg-0007UN-AH; Fri, 05 Jul 2019 04:41:35 -0400 Date: Fri, 05 Jul 2019 11:41:26 +0300 Message-Id: <83r274an61.fsf@gnu.org> From: Eli Zaretskii To: Pip Cet In-reply-to: (message from Pip Cet on Fri, 5 Jul 2019 08:36:57 +0000) Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Pip Cet > Date: Fri, 5 Jul 2019 08:36:57 +0000 > Cc: michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org > > > > I don't think we can sensibly add tests for this bug, but the fix I > > > posted earlier still seems valid to me. > > > > Sorry, I'm not tracking this part of the discussion, as it lost me > > long ago. > > What's the best way of getting this fixed? Sorry, I don't think I know what "this bug" is about, and how is the issue with hash tables relevant. I think I understood everything until the point where the discussion quite unexpectedly switched to talking about hash tables, which is where I lost the thread of reasoning. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 05:10:01 2019 Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 09:10:01 +0000 Received: from localhost ([127.0.0.1]:52359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjKEC-0005P4-WD for submit@debbugs.gnu.org; Fri, 05 Jul 2019 05:10:01 -0400 Received: from mail-ot1-f46.google.com ([209.85.210.46]:33859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjKE8-0005On-0y for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 05:09:59 -0400 Received: by mail-ot1-f46.google.com with SMTP id n5so8423130otk.1 for <36447@debbugs.gnu.org>; Fri, 05 Jul 2019 02:09:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kpawt80bX5TqtKrLuo66qu6GZbuvilOUrQ7uoPHtcx0=; b=ku5RUe13y1uLQKC7kqvKPFlyizmtZcfsO8VG/oTUynlZRJEvMzy11yRWsyxktBpr04 O5GaQDDRDqAoDrlCmxBmzch+qOfW9+Exekvt6dGr071hOZkeQw3ZByvTatI32ea7ecDU nRokroBLu5OD7FPDz8VLgiN7zmgcO3rnwHAUtJTEj7DjjDlN8J1gyq1uVsQuB21aZNs/ B1syOVrmqmrtKIHR+qZuyCBi0YLbRkrG4GOzdRa9zHF4oWsB2Q1Gy2ZH/sl1YA9eSkJo X0XvnLIQhwFp/Jre3DbwFMsXGGj7uBggMqXCvf+4fFjsP/rB+zgoNGsdvU8wSIuksfX/ KBQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kpawt80bX5TqtKrLuo66qu6GZbuvilOUrQ7uoPHtcx0=; b=hWNwZK97pB9yetP853wKme9GGKI4Rdf+p8tT1+k2NBcsj70EL8nongbRC3oDowFHOk 19cbFTLGIOmZdI3CNH477xG2HsfGFokGoMXIODJy5A4ZMrvCTchWY5tkbqkYtqDx820L l/rN0yErnHpPOSUsmoCzg9kKqbuO+2tWuGP9HtE3H4XfK7x54ZN9uaJIXhhLx341G4lR N30nPK67x3nFjCRiIH9dY8cZOuHFyb4NWD1HNz4+2W3yHn65CmKl3lrj/HZXGEy0VttG Wne09nCXMJvO5QTWiz6rKynrAouXmyHhJWtK8s/PGz2SlalSbHE6zElbpw0WEyV4VyW8 5ptA== X-Gm-Message-State: APjAAAXYAhoqH0jNQsmOtITXKgiqOKDAAbhepgkD1uQQS3UbxqlPppW5 assDOjC7I6Atty++eh9H1puBJScgDryXAKtrMwQ= X-Google-Smtp-Source: APXvYqzjmRdznUcS7Yg2GzqDTLD2Kg020xDVP8MjXuYmyvEkMM3ZBS9WqqlwPmbkb26ahYK2ZE0DCgj+kAbxbQWAnIM= X-Received: by 2002:a9d:7284:: with SMTP id t4mr2169947otj.154.1562317790329; Fri, 05 Jul 2019 02:09:50 -0700 (PDT) MIME-Version: 1.0 References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> In-Reply-To: <83r274an61.fsf@gnu.org> From: Pip Cet Date: Fri, 5 Jul 2019 09:09:13 +0000 Message-ID: Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000ebb7d3058ceb7431" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000ebb7d3058ceb7431 Content-Type: text/plain; charset="UTF-8" On Fri, Jul 5, 2019 at 8:41 AM Eli Zaretskii wrote: > > > From: Pip Cet > > Date: Fri, 5 Jul 2019 08:36:57 +0000 > > Cc: michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org > > > > > > I don't think we can sensibly add tests for this bug, but the fix I > > > > posted earlier still seems valid to me. > > > > > > Sorry, I'm not tracking this part of the discussion, as it lost me > > > long ago. > > > > What's the best way of getting this fixed? > > Sorry, I don't think I know what "this bug" is about, The bug: Building emacs with "-O0 -g3 -ggdb" on current Linux will result in binaries that sometimes, depending on the precise compiler version used, will fail weirdly if you evaluate this emacs -Q recipe line by line: (custom-handle-keyword nil :group nil nil) (y-or-n-p "prompt") (custom-handle-keyword nil :group nil nil) The error produced will be "unknown keyword :group", which is nonsensical as :group is indeed a valid keyword. The analysis: It's not the byte code, which is fine and looks like this: byte code for custom-handle-keyword: doc: For customization option SYMBOL, handle KEYWORD with VALUE. ... args: (arg1 arg2 arg3 arg4) 0 varref purify-flag 1 goto-if-nil 1 4 constant purecopy 5 stack-ref 2 6 call 1 7 stack-set 2 9:1 stack-ref 2 10 constant 11 switch 12 goto 9 ... 52:9 constant error 53 constant "Unknown keyword %s" 54 stack-ref 4 55 call 2 56 return Note that the code uses a jump table, which is a hash table mapping keys to integers for the "switch" op. This is where hash tables come in. We can inspect the hash table `custom-handle-keyword' uses by evaluating (aref (aref (symbol-function #'custom-handle-keyword) 2) 2) The hash table prints fine. But investigating its C in-memory representation, we find that the hash collision chains, stored in the ->next vector, are corrupted. It turns out that this is because hash_table_rehash was called on a different hash table which had the same ->next vector, but different contents. That's the problem I fixed: for reasons explained below, we sometimes see two hash tables with the same ->next vector, then try to rehash both of them, obtaining different results. Last caller wins, first caller gets the corruption (each hash table is rehashed at most once). The reasons are this: when a hash table is purecopied, its ->next vector is purecopied, which merges it with another, similar, hash table's ->next vector if purify-flag is a (third) hash table. The vectors are compared using `equal', but the pure copies are actually `eq'. This worked fine with the old dumper, because we never modified pure storage. However, with the current pdumper code, we have to do that. The (disappointingly trivial) fix: call copy-sequence on h->next before rehashing the table. This will make h->next impure, which is good since we're going to modify it. While we're there, do the same for the other vectors used in the hash table representation, except for h->key_and_value, which we need not touch. > and how is the issue with hash tables relevant. The bytecode is executing incorrectly because it relies on a purecopied hash table, which is effectively part of the compiled function. The hash table has become corrupted. --000000000000ebb7d3058ceb7431 Content-Type: text/x-patch; charset="US-ASCII"; name="0002-Don-t-alter-shared-structure-in-dumped-purecopied-ha.patch" Content-Disposition: attachment; filename="0002-Don-t-alter-shared-structure-in-dumped-purecopied-ha.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxpvmcpm0 RnJvbSA3MDQxOWY2MzBmNjA5MTljODY0NWExMGFlZWY4ZDI5OWY1MDk4ZmY1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBXZWQs IDMgSnVsIDIwMTkgMTE6NDg6MjIgKzAwMDAKU3ViamVjdDogW1BBVENIIDIvMl0gRG9uJ3QgYWx0 ZXIgc2hhcmVkIHN0cnVjdHVyZSBpbiBkdW1wZWQgcHVyZWNvcGllZCBoYXNoCiB0YWJsZXMuCgoq IHNyYy9mbnMuYyAoaGFzaF90YWJsZV9yZWhhc2gpOiBNYWtlIHN1cmUgd2UncmUgb3BlcmF0aW5n IG9uCmZyZXNoIGNvcGllcyBvZiAtPm5leHQsIC0+aW5kZXgsIC0+aGFzaC4KLS0tCiBzcmMvZm5z LmMgfCA2ICsrKysrKwogMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdp dCBhL3NyYy9mbnMuYyBiL3NyYy9mbnMuYwppbmRleCAyZmMwMDBhN2Y0Li40NGQyZGU1MjNhIDEw MDY0NAotLS0gYS9zcmMvZm5zLmMKKysrIGIvc3JjL2Zucy5jCkBAIC00MjIzLDYgKzQyMjMsMTIg QEAgaGFzaF90YWJsZV9yZWhhc2ggKHN0cnVjdCBMaXNwX0hhc2hfVGFibGUgKmgpCiB7CiAgIHB0 cmRpZmZfdCBzaXplID0gSEFTSF9UQUJMRV9TSVpFIChoKTsKIAorICAvKiBUaGVzZSBzdHJ1Y3R1 cmVzIG1heSBoYXZlIGJlZW4gcHVyZWNvcGllZCBhbmQgc2hhcmVkCisgICAgIChidWcjMzY0NDcp LiAgKi8KKyAgaC0+bmV4dCA9IEZjb3B5X3NlcXVlbmNlIChoLT5uZXh0KTsKKyAgaC0+aW5kZXgg PSBGY29weV9zZXF1ZW5jZSAoaC0+aW5kZXgpOworICBoLT5oYXNoID0gRmNvcHlfc2VxdWVuY2Ug KGgtPmhhc2gpOworCiAgIC8qIFJlY29tcHV0ZSB0aGUgYWN0dWFsIGhhc2ggY29kZXMgZm9yIGVh Y2ggZW50cnkgaW4gdGhlIHRhYmxlLgogICAgICBPcmRlciBpcyBzdGlsbCBpbnZhbGlkLiAgKi8K ICAgZm9yIChwdHJkaWZmX3QgaSA9IDA7IGkgPCBzaXplOyArK2kpCi0tIAoyLjIwLjEKCg== --000000000000ebb7d3058ceb7431-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 08:24:08 2019 Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 12:24:08 +0000 Received: from localhost ([127.0.0.1]:52474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjNG4-000814-8P for submit@debbugs.gnu.org; Fri, 05 Jul 2019 08:24:08 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:40855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjNG2-00080g-Ok for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 08:24:07 -0400 Received: by mail-wr1-f50.google.com with SMTP id r1so3418059wrl.7 for <36447@debbugs.gnu.org>; Fri, 05 Jul 2019 05:24:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version; bh=DAQiGAiO0QnndePeIezj0Cs7Ah3HkXwryFPJsEQxpYE=; b=XYlbfbslsb4XYQ80sekcwioOjLsvyB0ipfAimUQQiJqbn5fwC3EiCN2tAJeSO3Bng0 URRSjJntMk0C2KLycFqy1GzJfFoGFJGZAiB85Ytf281o4B1TxzEA5/CSJ72+t1RY5gxA +U2NUPIyy/K/XlRY/wR/8uc2iMGqk7U1UTbHEm+Uf5ws8YL+FCJptozDjb/OTKUMpocT j48DXu5nCrTn/IVImR3Or2S7XMnHM+JZKQrm47ptEwQOoRd7UxLNMuWH20wqnJafKbIA QkYAo1JdOVF56YBDyw/dOEE0QviPolXbfbKH6LJxpbsCriigv7VInxXbqB86mfqJRTTh iawA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=DAQiGAiO0QnndePeIezj0Cs7Ah3HkXwryFPJsEQxpYE=; b=rKOtPZENUiGXpw43WxSrNjM953Q9oZ8hxhT96sLbIFdf1m4vlYM/xjHoyM0KCgy95E 1pW3MpPdIdYQ2kSSyyiLp0xSqNbWlAjVVHOVd/UF392ZeTcVKPAPd6XJA6z8Sl5tymeF nBnqfYQWHQ0natc5BrCaKQBckJO2ZWhQGGsWlT7vDaxQyZRPJUdRL9dnvRreMhW9LMci mwf2quKcWuaXNRNko7h6/WNDuHsWo7kXBBvUz6Rh7pFcMld32MyRxpXDWmbsE8d1s3Z7 19EOrGUMGt7wBXWmx/VypWU/cNWE1jHGOdudEgRRfva1XPhUmpMh/aITnDSavwd2DK4f bbxA== X-Gm-Message-State: APjAAAX+qF4RlSxo8Nk6YEVGuTG3FubSeA1XsqfyxxQrqrj668IyhhU6 5sZ4acXYre5RIfLon5A02dOIk109YD8= X-Google-Smtp-Source: APXvYqw7jgD5IJHfRcYdJaeFcMtmeV/tFLxYcu6f6xlkX/7/z0dCrjYjyJBmMcUT0KNnFzy/Yuklrg== X-Received: by 2002:a5d:5510:: with SMTP id b16mr3963090wrv.267.1562329440471; Fri, 05 Jul 2019 05:24:00 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id w14sm8100851wrt.51.2019.07.05.05.23.59 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 05 Jul 2019 05:23:59 -0700 (PDT) From: Robert Pluim To: Pip Cet Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> X-Debbugs-No-Ack: yes Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Fri, 05 Jul 2019 14:23:58 +0200 In-Reply-To: (Pip Cet's message of "Fri, 5 Jul 2019 09:09:13 +0000") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, Eli Zaretskii , npostavs@gmail.com, 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Fri, 5 Jul 2019 09:09:13 +0000, Pip Cet said: Pip> This worked fine with the old dumper, because we never modified pure Pip> storage. However, with the current pdumper code, we have to do that. I have to ask: why do we still have pure storage? I seem to remember XEmacs got rid of it at least a decade ago with no ill effects. Robert From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 08:33:31 2019 Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 12:33:31 +0000 Received: from localhost ([127.0.0.1]:52479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjNP9-0008Ez-88 for submit@debbugs.gnu.org; Fri, 05 Jul 2019 08:33:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjNP7-0008El-83 for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 08:33:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60440) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hjNP0-0001Wb-5m; Fri, 05 Jul 2019 08:33:22 -0400 Received: from [176.228.60.248] (port=4766 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hjNOx-0004YQ-E2; Fri, 05 Jul 2019 08:33:20 -0400 Date: Fri, 05 Jul 2019 15:33:10 +0300 Message-Id: <83pnmoacft.fsf@gnu.org> From: Eli Zaretskii To: Pip Cet , Stefan Monnier In-reply-to: (message from Pip Cet on Fri, 5 Jul 2019 09:09:13 +0000) Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Pip Cet > Date: Fri, 5 Jul 2019 09:09:13 +0000 > Cc: michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org > > > Sorry, I don't think I know what "this bug" is about, > > The bug: Thanks for the explanations. I'm CC'ing Stefan who knows much more about this than I do. > The reasons are this: when a hash table is purecopied, its ->next > vector is purecopied, which merges it with another, similar, hash > table's ->next vector if purify-flag is a (third) hash table. The > vectors are compared using `equal', but the pure copies are actually > `eq'. A naïve question: wouldn't the problem go away if we modified purecopy not to do the above, i.e. not to merge the next vector of a hash table with that of another? > The (disappointingly trivial) fix: > call copy-sequence on h->next before rehashing the table. Rehashing is not only done during dumping, right? So the fix you propose also makes rehashing slightly less efficient. Is that necessary, i.e. are you saying that the bug is in rehashing, not in purecopy? From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 09:42:28 2019 Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 13:42:29 +0000 Received: from localhost ([127.0.0.1]:52532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjOTs-0001Yq-EQ for submit@debbugs.gnu.org; Fri, 05 Jul 2019 09:42:28 -0400 Received: from mail-oi1-f173.google.com ([209.85.167.173]:42868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjOTq-0001YY-KH for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 09:42:26 -0400 Received: by mail-oi1-f173.google.com with SMTP id s184so7157019oie.9 for <36447@debbugs.gnu.org>; Fri, 05 Jul 2019 06:42:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=iADfrFIDixmxtzp9zIWh2oIZ4sC03WobTwGvFxcK9wo=; b=P4hIDH+LeC8RWtWIpTf4+8+kI+dgIIvC+JWXBBHiL6Zr/bfYsj67mNY+yw4EhpfwRv 2mnrynNzwR+8iISp8vGimLtjMDN1/yqW7DzTzJmh6QkLfQ8ZnqFIwTzm7/5ToSrbnr66 2OP6dBTxn1PilUS5NHMA0kic0/qbB2/jWGMm8xP/HeAsTLR0SPUB+OJ1oQdGdLUoiCUe 7dmanlapbfzBSk/lvNArFrnSsdFwdbcg1J4won1JSH7g6T2dOQJMEwQ20wu/vy4TNvvH o+0LYOaeWBMverIDuHma8kHNuPMDS7sRgDUF48FjMTw+oZvQ/6leRF1azqrhccfZ70s2 e5OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=iADfrFIDixmxtzp9zIWh2oIZ4sC03WobTwGvFxcK9wo=; b=lcfnR5uMaqvx2Uq/M4XpMEF6uvEIOyuJ8sMorYQXFnOFiuZ4fwQ/SIO+Ujx6vkaUOB YaSLeJyTQKGlOy1826AJng8DIohMV86sWaNrjzx5kC4rzHzbGLIfrBOaZa2toBqjtRjT HvsUaKAt/uqnRQX9M7zAdCoVAPoUgCDxGs1POUh4ZYrrv/CRR/MLcGuICVQErsxE3Buz N5cdEzKdK2NUQ7VSErtXUiHQ9wdkiXaDVYJv7iOlOb/eJxbbDBs5Q7VUXItbeAeI2RTF O/t+BdrGuGEEAzRX+SugrWttXpmeZ0UlhL7Gd3iRcgOmn9QVb5TiOnS6IdHlvFOAERb8 IMNw== X-Gm-Message-State: APjAAAXtYvvkiIDjrrvpJAxWZ6YPFQgFVPKk0aKSuEVtN68cwlXKnk2V Mg+vtGFyzfjIAyRzjga7jLdOxjTMF+Vy1fCrSE8= X-Google-Smtp-Source: APXvYqzyMmMuiGS3k4yD9CsW0OwdOO2fHOQHg/lfuJhsjslr8APrStDp2O+6jwBksyFojYu1Jgjo1CjZNL3Dk/rkbWI= X-Received: by 2002:aca:4790:: with SMTP id u138mr2178799oia.44.1562334139762; Fri, 05 Jul 2019 06:42:19 -0700 (PDT) MIME-Version: 1.0 References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> In-Reply-To: <83pnmoacft.fsf@gnu.org> From: Pip Cet Date: Fri, 5 Jul 2019 13:41:41 +0000 Message-ID: Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, 36447@debbugs.gnu.org, Stefan Monnier , npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Jul 5, 2019 at 12:33 PM Eli Zaretskii wrote: > Thanks for the explanations. I'm CC'ing Stefan who knows much more > about this than I do. Thank you. > > The reasons are this: when a hash table is purecopied, its ->next > > vector is purecopied, which merges it with another, similar, hash > > table's ->next vector if purify-flag is a (third) hash table. The > > vectors are compared using `equal', but the pure copies are actually > > `eq'. > > A na=C3=AFve question: wouldn't the problem go away if we modified pureco= py > not to do the above, i.e. not to merge the next vector of a hash table > with that of another? I thought about that, but it's a bit complicated: either we'd keep the ->next vector impure (and make a copy of it), or we would have to add a "don't hash-cons" argument to purecopy(), which kind of defeats the purpose. > > The (disappointingly trivial) fix: > > call copy-sequence on h->next before rehashing the table. > > Rehashing is not only done during dumping, right? As far as I can tell, it's only done when first accessing a dumped hash table, but I might be wrong. (In any case, it seems `hash-table-count' then returns a negative value for the hash table, which seems problematic to me.) > So the fix you > propose also makes rehashing slightly less efficient. Is that > necessary, i.e. are you saying that the bug is in rehashing, not in > purecopy? Again, I may be wrong, since we're using the sign of h->count to indicate whether a hash table needs rehashing and that's hard to grep for, but I think this only affects rehashing after dump, not rehashing when resizing a hash table. It's certainly not called very often, and not for very large hash tables. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 14:00:33 2019 Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 18:00:33 +0000 Received: from localhost ([127.0.0.1]:53685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjSVc-00027F-M8 for submit@debbugs.gnu.org; Fri, 05 Jul 2019 14:00:33 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:57352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjSVa-000270-Ov for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 14:00:31 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 4D45E4445DB; Fri, 5 Jul 2019 14:00:24 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C78194445D9; Fri, 5 Jul 2019 14:00:22 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1562349622; bh=CG7ybn7NVdjSpbz4rnVae8YNYSw0C4rMSxfGxZwAMn0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kgcaSaCMjEH3XnJziuZoWP4HHBdc2f1+G6AazmR5+lQ78hHoAiUJaEFd58TqnaqgI W4rMUhkB/jWKQmhTwnE+/RlvIiirUL8hwXi/NukRCnF0r8ozYhb6IaQfnDAoV/MLdS mwHKGCEP0VbTW2QXFXn+GLk+TpCWpsS82TzbMY2TJHcSAprZC0UuU8cvUIiRFC13dq qNRN1E5DA4OLYU0HHXAD76LS9xeu/XIKmS0PXeTM0dPWfdIqjtP+0yWd5vVFr+Y8lh M8DKjtBa0OwdzOQgHxfJQixn5nQFLJS1Qt3AIEVoqPQ6LszQIBVSsyRvP6J/PUnuuA hOIbba7mZ6yWw== Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9690C120130; Fri, 5 Jul 2019 14:00:22 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors Message-ID: References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> Date: Fri, 05 Jul 2019 14:00:22 -0400 In-Reply-To: <83pnmoacft.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 05 Jul 2019 15:33:10 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.356 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, npostavs@gmail.com, Pip Cet , 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > A na=EFve question: wouldn't the problem go away if we modified purecopy > not to do the above, i.e. not to merge the next vector of a hash table > with that of another? It might do the trick, yes (the patch below does that, for example, tho I think Pip's patch is a better approach). Note that it would mean we still modify data in the purespace, which ideally shouldn't happen. The problem fundamentally is that `purecopy` assumes that the argument passed to it will never again be modified (it doesn't have to be immutable before, but it should be afterwards) but if we rehash afterwards then we break this promise. >> The (disappointingly trivial) fix: >> call copy-sequence on h->next before rehashing the table. > Rehashing is not only done during dumping, right? The problem is not rehashing in general, but rehashing a purecopied hash-table. This should normally never be needed, since a purecopied hash-table should never be modified (no puthash/remhash should be applied to it), but sadly pdumper may need to recompute the hashes because objects's addresses may have changed between the dump and the reload. > So the fix you propose also makes rehashing slightly less efficient. In my patch I added a comment to explain that hash_table_rehash is not used in "normal" rehashing, but only in the rare case of rehashing on the first access to a preloaded hash-table, so the efficiency His patch looks good (probably better than mine). His patch can/should be made slightly more efficient by only doing the Fcopy_sequence on those hash-tables that are in purespace. Stefan diff --git a/src/fns.c b/src/fns.c index 2fc000a7f4..cc4fd7f2d7 100644 --- a/src/fns.c +++ b/src/fns.c @@ -4218,6 +4218,11 @@ maybe_resize_hash_table (struct Lisp_Hash_Table *h) } } =20 +/* Recompute the hashes (and hence also the "next" pointers). + Normally there's never a need to recompute hashes + This is done only on first-access to a hash-table loaded from + the "pdump", because the object's addresses may have changed, thus + affecting their hash. */ void hash_table_rehash (struct Lisp_Hash_Table *h) { diff --git a/src/alloc.c b/src/alloc.c index 64aaa8acdf..b0114a9459 100644 --- a/src/alloc.c +++ b/src/alloc.c @@ -5348,9 +5348,24 @@ purecopy_hash_table (struct Lisp_Hash_Table *table) =20 pure->header =3D table->header; pure->weak =3D purecopy (Qnil); + /* After reloading the pdumped data, objects may ehave changed location + in memory, so their hash may have changed. So the `hash`, `next`, and + `index` vectors are not immutable and can't safely be hash-cons'ed. = */ + if (HASH_TABLE_P (Vpurify_flag)) + { + Fremhash (table->hash, Vpurify_flag); + Fremhash (table->next, Vpurify_flag); + Fremhash (table->index, Vpurify_flag); + } pure->hash =3D purecopy (table->hash); pure->next =3D purecopy (table->next); pure->index =3D purecopy (table->index); + if (HASH_TABLE_P (Vpurify_flag)) + { + Fremhash (table->hash, Vpurify_flag); + Fremhash (table->next, Vpurify_flag); + Fremhash (table->index, Vpurify_flag); + } pure->count =3D table->count; pure->next_free =3D table->next_free; pure->pure =3D table->pure; From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 14:07:18 2019 Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 18:07:18 +0000 Received: from localhost ([127.0.0.1]:53702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjScA-0002J5-8K for submit@debbugs.gnu.org; Fri, 05 Jul 2019 14:07:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjSc8-0002Ir-Al for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 14:07:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hjSc2-00044Q-SB; Fri, 05 Jul 2019 14:07:10 -0400 Received: from [176.228.60.248] (port=1956 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hjSc1-0007sM-SL; Fri, 05 Jul 2019 14:07:10 -0400 Date: Fri, 05 Jul 2019 21:07:03 +0300 Message-Id: <83lfxc9wzc.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Fri, 05 Jul 2019 14:00:22 -0400) Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, npostavs@gmail.com, pipcet@gmail.com, 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Pip Cet , michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org > Date: Fri, 05 Jul 2019 14:00:22 -0400 > > The problem is not rehashing in general, but rehashing a purecopied > hash-table. This should normally never be needed, since a purecopied > hash-table should never be modified (no puthash/remhash should be > applied to it), but sadly pdumper may need to recompute the hashes > because objects's addresses may have changed between the dump and > the reload. Then perhaps pdumper should make a new object when it does that? > His patch can/should be made slightly more efficient by only doing the > Fcopy_sequence on those hash-tables that are in purespace. I cannot say I like tweaking the GP implementation for the benefit of what only the pdumper must do, it doesn't feel right. Problems caused by the pdumper should IMO be fixed in pdumper code. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 14:58:40 2019 Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 18:58:41 +0000 Received: from localhost ([127.0.0.1]:53748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjTPs-0003fc-EN for submit@debbugs.gnu.org; Fri, 05 Jul 2019 14:58:40 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:44759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjTPq-0003fN-Qd for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 14:58:39 -0400 Received: by mail-oi1-f194.google.com with SMTP id e189so7763829oib.11 for <36447@debbugs.gnu.org>; Fri, 05 Jul 2019 11:58:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=/D2UBDCf53RtAAZJqnZKuBk3aKmHhxyXaFDxdeZPIU8=; b=bEikPid3gltwn31CeCuene66OuRjTBfzNmsGMYOyz2rX6TfkOc+nDXSYgDDzl6wnzj 97/SwYY7puqOx73KvEioa/OeI2MgO3VIAc9ExqpfgS46ZkXvgPiN7LcrloMRRd+HqGp6 cUbTOPjcsi7XQctmzl4hrecObnTaXYAdWETKFBeKMgB65Ct2UJVE8i6oMjefG20/+Wi6 p2yoNo0b0/lA5uBkhR4bKfn066SzlN6aofXCiRViG+S5GeWlWWZ1w5XEDRPl07ageJIc 3+eTvC8USl0omEHSoKzpjIVTLHRj3muR4Eq3PdGlEK8+SQiB+SDGdebUcw1+mFnexwgt 5NXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/D2UBDCf53RtAAZJqnZKuBk3aKmHhxyXaFDxdeZPIU8=; b=cL2dLNGMzUxOeZsSNuK0OZkb3KIqCf0VDVmhHO10/0hROmF4EFcNl9O6/gVp9IeG9J ZXF4KVO5+Thk83Jw3AUclTaDQ/f+uFt52mUsuiDnF2xJzg9R0vZ/Ko7a/SvJJN2CSto+ /U1vP2M2SAbjudE7VOpL4nQQ1s0+1gDbdneuuJ8Svi4oGWQqLzBmb4F44rB/+dE0txY2 RsD6nPf2pNujm4mnZyjeCrgBV2zKN/HlWGW2JVtxIitdg6NQEt6GX89JGdGgO4xkm4Vw UYu13r+0Oj8v9ZUspohQvUIdJrF9tpo3hZJBXcGdHRt3yHCb2UmTWq32Q71LyGukfk7m btuA== X-Gm-Message-State: APjAAAXn1Iijb7IGOm3dX+1MWUMhSpHMUBzZmYTjhGKDQNx2b3YqWxad fySN22CtzoJ+H8EF5Veyc5oaZR+rbqi9GzxHkOo= X-Google-Smtp-Source: APXvYqx0OKW9N2N/4m02vLtIX3ceyQpAqf0XMOYTM980Qdmcrj8CZ1W+j7q6VqjuA3CE6cqXochK8ce35lXc0Mm7nhg= X-Received: by 2002:aca:aa93:: with SMTP id t141mr2844402oie.128.1562353113041; Fri, 05 Jul 2019 11:58:33 -0700 (PDT) MIME-Version: 1.0 References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> In-Reply-To: From: Pip Cet Date: Fri, 5 Jul 2019 18:57:56 +0000 Message-ID: Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors To: Stefan Monnier Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, Eli Zaretskii , npostavs@gmail.com, 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Jul 5, 2019 at 6:00 PM Stefan Monnier wr= ote: > > A na=C3=AFve question: wouldn't the problem go away if we modified pure= copy > > not to do the above, i.e. not to merge the next vector of a hash table > > with that of another? > > It might do the trick, yes (the patch below does that, for example, tho > I think Pip's patch is a better approach). > Note that it would mean we still modify data in the purespace, which > ideally shouldn't happen. > > The problem fundamentally is that `purecopy` assumes that the argument > passed to it will never again be modified (it doesn't have to be > immutable before, but it should be afterwards) but if we rehash > afterwards then we break this promise. Surely you mean you're allowed to modify the argument to purecopy, just not the return value of it? > His patch can/should be made slightly more efficient by only doing the > Fcopy_sequence on those hash-tables that are in purespace. How do we test for that? If I'm reading the pdumper code correctly, it'll put all "unstable" hash tables at the end of the dump, far away from the actually pure objects. I'm not sure how difficult it would be, but we could dump the ->index, ->next, ->hash vectors as Qnil (so not include the actual vectors in the dump), which would make the dump slightly smaller and give us a better test than h->count < 0: INLINE bool hash_rehash_needed_p (const struct Lisp_Hash_Table *h) { return NILP (h->index); } (I used h->index because it's in the same cache line as h->count). But that's hard to do without writing a shrink_hash_table function to be used before dumping. I think hash tables should be shrinkable, but that's beyond the scope of this bug. > diff --git a/src/fns.c b/src/fns.c > index 2fc000a7f4..cc4fd7f2d7 100644 > --- a/src/fns.c > +++ b/src/fns.c > @@ -4218,6 +4218,11 @@ maybe_resize_hash_table (struct Lisp_Hash_Table *h= ) > } > } > > +/* Recompute the hashes (and hence also the "next" pointers). And the "index" pointers, if we're listing all of them. > + Normally there's never a need to recompute hashes > + This is done only on first-access to a hash-table loaded from > + the "pdump", because the object's addresses may have changed, thus > + affecting their hash. */ > void > hash_table_rehash (struct Lisp_Hash_Table *h) > { > diff --git a/src/alloc.c b/src/alloc.c > index 64aaa8acdf..b0114a9459 100644 > --- a/src/alloc.c > +++ b/src/alloc.c > @@ -5348,9 +5348,24 @@ purecopy_hash_table (struct Lisp_Hash_Table *table= ) > > pure->header =3D table->header; > pure->weak =3D purecopy (Qnil); > + /* After reloading the pdumped data, objects may ehave changed locatio= n > + in memory, so their hash may have changed. So the `hash`, `next`, = and > + `index` vectors are not immutable and can't safely be hash-cons'ed.= */ > + if (HASH_TABLE_P (Vpurify_flag)) > + { > + Fremhash (table->hash, Vpurify_flag); > + Fremhash (table->next, Vpurify_flag); > + Fremhash (table->index, Vpurify_flag); > + } > pure->hash =3D purecopy (table->hash); > pure->next =3D purecopy (table->next); Slightly contrived problem here: if the single key in a single-entry EQ hash is -7, or an expression that happens to have hash value -1, pure->hash and pure->next would be EQ after these two lines, and updating the hash would corrupt the hash table... > pure->index =3D purecopy (table->index); Same for ->index and ->hash if both are equal to [0]. > + if (HASH_TABLE_P (Vpurify_flag)) > + { > + Fremhash (table->hash, Vpurify_flag); > + Fremhash (table->next, Vpurify_flag); > + Fremhash (table->index, Vpurify_flag); > + } From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 15:14:05 2019 Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 19:14:05 +0000 Received: from localhost ([127.0.0.1]:53781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjTen-00048w-7g for submit@debbugs.gnu.org; Fri, 05 Jul 2019 15:14:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjTeh-00048D-R7 for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 15:14:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hjTec-00008y-Fe; Fri, 05 Jul 2019 15:13:54 -0400 Received: from [176.228.60.248] (port=2026 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hjTeZ-0006SO-GI; Fri, 05 Jul 2019 15:13:53 -0400 Date: Fri, 05 Jul 2019 22:13:44 +0300 Message-Id: <83k1cw9tw7.fsf@gnu.org> From: Eli Zaretskii To: Pip Cet In-reply-to: (message from Pip Cet on Fri, 5 Jul 2019 18:57:56 +0000) Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, 36447@debbugs.gnu.org, monnier@iro.umontreal.ca, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Pip Cet > Date: Fri, 5 Jul 2019 18:57:56 +0000 > Cc: Eli Zaretskii , michael_heerdegen@web.de, npostavs@gmail.com, > 36447@debbugs.gnu.org > > > His patch can/should be made slightly more efficient by only doing the > > Fcopy_sequence on those hash-tables that are in purespace. > > How do we test for that? Can pdumper_object_p help? From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 16:16:46 2019 Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 20:16:46 +0000 Received: from localhost ([127.0.0.1]:53825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjUdR-00082R-Ob for submit@debbugs.gnu.org; Fri, 05 Jul 2019 16:16:45 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:26164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjUdP-00082E-MM for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 16:16:45 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3F5C84445E9; Fri, 5 Jul 2019 16:16:38 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 47D9C444450; Fri, 5 Jul 2019 16:16:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1562357797; bh=NhpPTy50sy1m0derF9wvGJoDrmzSeHkMAbY+tq53j/8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=XLRzujfZeDokODWgL5Y8jp/YSIxsGCSX5lMgcFKmajX0RnPNp2I7OucXo9vlKCIGM O8Ru966Hl32Z6DHnlMtghCpbPLX/anvuhmhPbNZ0oVe3IQTGCEb+6H7wHIIZ4YFTKq O0SCZB++ZyKnlzMf+F4YUNapwIzfc3lWNeD9lXi3akGdrejtsdWpaDEypS32CrZ1x/ bW84kfmIwk1t3PuB9G5S3JxHgVJEMUQGjwcuVi2vBnEc2Snmk+ulqplQ78db4i5fWG 8zAYE1faQB2ut6BpLFVumJ6t9jEzbfTwVux1goODnPoVlp5nN7OoMnUuQPLL0y/QzY nRSRQrhPDq09A== Received: from alfajor (76-10-138-228.dsl.teksavvy.com [76.10.138.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 75A35120B2F; Fri, 5 Jul 2019 16:16:36 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors Message-ID: References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> <83lfxc9wzc.fsf@gnu.org> Date: Fri, 05 Jul 2019 16:16:34 -0400 In-Reply-To: <83lfxc9wzc.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 05 Jul 2019 21:07:03 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.067 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, npostavs@gmail.com, pipcet@gmail.com, 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> His patch can/should be made slightly more efficient by only doing the >> Fcopy_sequence on those hash-tables that are in purespace. > > I cannot say I like tweaking the GP implementation for the benefit of > what only the pdumper must do, it doesn't feel right. Problems caused > by the pdumper should IMO be fixed in pdumper code. hash_table_rehash *is* pdumper code. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 16:21:57 2019 Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 20:21:57 +0000 Received: from localhost ([127.0.0.1]:53836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjUiS-0008BV-VS for submit@debbugs.gnu.org; Fri, 05 Jul 2019 16:21:57 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:31658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjUiR-0008B6-3S for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 16:21:55 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C4C5A81181; Fri, 5 Jul 2019 16:21:48 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 57C8D810B1; Fri, 5 Jul 2019 16:21:43 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1562358103; bh=0Yj4aF4cZlk/LPy4eTa4lkXSkGd2abxAwAh1xI4Dbts=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=QGTqTSKopnxIBi0TiHbokfTWyyMV3F5Zwbe+RFIbmWa8OLhlc0ihMqTrSaD0bMVsl SJbzl/4Vn5GkzhBp4s8vd86oS/HMQ/OsnTJYZJMuFBBpj9CnFsWfBfBGahQXbw3myq yXDpsicqjswn/Q1P6fzsIFluSN/twgR7FmAT+PjQ5XX/cJnTJHkVDpeKVSHJNbJ+8t 1Jsj8njpotCOhzjaXRdfAfDEnNzkQbusjjulJ4Zly8h1IYZx12fvnwjbIIrSbjFFEC wnOHog4KqUojoLJlk4a4eWqbyH2jf3EAzphw931UlFoFB6/bJ9k/c/FlDwnxmvDRj8 wQpDFqqDrQrtw== Received: from alfajor (76-10-138-228.dsl.teksavvy.com [76.10.138.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 013DC1201D0; Fri, 5 Jul 2019 16:21:42 -0400 (EDT) From: Stefan Monnier To: Pip Cet Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors Message-ID: References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> Date: Fri, 05 Jul 2019 16:21:41 -0400 In-Reply-To: (Pip Cet's message of "Fri, 5 Jul 2019 18:57:56 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.156 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, Eli Zaretskii , npostavs@gmail.com, 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> His patch can/should be made slightly more efficient by only doing the >> Fcopy_sequence on those hash-tables that are in purespace. > > How do we test for that? With PURE_P? > I'm not sure how difficult it would be, but we could dump the ->index, > ->next, ->hash vectors as Qnil (so not include the actual vectors in > the dump), which would make the dump slightly smaller and give us a > better test than h->count < 0: Except that it can't be done at the time of purecopy but only at the time we do the actual dump because the purecopied hashtable may be used in-between (which is also why count is kept positive by purecopy and is only made negative later). > Slightly contrived problem here: if the single key in a single-entry > EQ hash is -7, or an expression that happens to have hash value -1, > pure->hash and pure->next would be EQ after these two lines, and > updating the hash would corrupt the hash table... Indeed. As I said, I think your approach is better, I only included it for reference and for the comments I had added. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 17:53:27 2019 Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 21:53:27 +0000 Received: from localhost ([127.0.0.1]:53899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjW90-0004S1-Sl for submit@debbugs.gnu.org; Fri, 05 Jul 2019 17:53:27 -0400 Received: from mail-oi1-f177.google.com ([209.85.167.177]:39480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjW8y-0004Rp-Mt for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 17:53:25 -0400 Received: by mail-oi1-f177.google.com with SMTP id m202so8105802oig.6 for <36447@debbugs.gnu.org>; Fri, 05 Jul 2019 14:53:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rc/FqMbaB6Nz5RdC9YTH7rGzByWFmqyf/8aACfxasss=; b=LPqQlcHIkgWbbn6Jr54cCC2UDv4my2Ezspdb25mG+Elk3xfQMTaeFRHcj8FWfaqP+T gIYG01ntf1oy55TDUStWSX74PHuRHMvmgyPzcjPnVMDN1TWttadylDWauIhECQVJpj5U +9M3Uu14X3I+T5bIrrHl600t311/6P6mc2Xjgw9pGqIuPL+sqZ6/rBFjdGSt58gmqhXi +xyotD4QjJoOp39PP9fXHo/qHLEumavbOb/3AK8mUsCKHBknX10ndCCBwP3fI6GArNXj a8WlEs4dDLAVrSsB0ccoZ5hhKPFFr0SnkL7mypJlX73Xlzwa5ePR1qEd5ftNSwiG8iei ZhYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rc/FqMbaB6Nz5RdC9YTH7rGzByWFmqyf/8aACfxasss=; b=uenQZKxfiI/Gp7LxTD98pmQs+eFTKeBp/xeTJUr9479VDPmRTfluQlC8nVbh5IAPsn SWbd4G35N6YLcs5GNZuXmOLyAxU1eaEUIJ95m+P97Mu90P6gx2RplZoZQQ0hMbD+4j1g fNQjO3j8y0xCWGy9dU+b2VZGI7PJLbB7ERkiQrsbRrMmQ1wkrqNS5iUscXq4vYtchfme M+W6elgfJkGNGcuor1l9MMu3xDKQwUeTT78XIEWKr4lG2kJllTmYEKjT76q2R1rsn+wx yogP3pz/yW4/3w5UvFGpIWgTUlRoTlKrgFFV5rwdPgrK7qY4Ee5rgvAWHBNKXg20yBUb 5H5w== X-Gm-Message-State: APjAAAXbJjW/driaJUSmi8NKwo/HszvVOw5A0E40LCKNHeTOFfHs3McR s/UH8lwpvFJfW2Aq1oSJK3gx6cRI7o4IvZCcSQY= X-Google-Smtp-Source: APXvYqwWJVFH/MQJb9lcEItPcUSGt7chAxIVb7aQi8IleVyxONYL3FZw7IdZBfGQlvliXHWV2LhmL6fnVrybXm/5fZY= X-Received: by 2002:aca:4790:: with SMTP id u138mr3373668oia.44.1562363599064; Fri, 05 Jul 2019 14:53:19 -0700 (PDT) MIME-Version: 1.0 References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> In-Reply-To: From: Pip Cet Date: Fri, 5 Jul 2019 21:52:41 +0000 Message-ID: Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors To: Stefan Monnier Content-Type: multipart/mixed; boundary="000000000000553536058cf61f3f" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, Eli Zaretskii , npostavs@gmail.com, 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000553536058cf61f3f Content-Type: text/plain; charset="UTF-8" On Fri, Jul 5, 2019 at 8:21 PM Stefan Monnier wrote: > >> His patch can/should be made slightly more efficient by only doing the > >> Fcopy_sequence on those hash-tables that are in purespace. > > > > How do we test for that? > > With PURE_P? That only works before we dump, I think? > > I'm not sure how difficult it would be, but we could dump the ->index, > > ->next, ->hash vectors as Qnil (so not include the actual vectors in > > the dump), which would make the dump slightly smaller and give us a > > better test than h->count < 0: > > Except that it can't be done at the time of purecopy but only at the > time we do the actual dump because the purecopied hashtable may be used > in-between (which is also why count is kept positive by purecopy and is > only made negative later). Indeed. I'm attaching a proof of concept that we can simply freeze the hash tables when dumping and thaw them when loading a dump, which includes rehashing. Do you happen to know why it wasn't done that way? I quite enjoyed removing all the scattered hash_rehash_if_needed()s. --000000000000553536058cf61f3f Content-Type: text/x-patch; charset="US-ASCII"; name="0001-rehash-hash-tables-eagerly-after-loading-the-pdumper.patch" Content-Disposition: attachment; filename="0001-rehash-hash-tables-eagerly-after-loading-the-pdumper.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxqmvvnu0 RnJvbSA4M2Y5MTViMzJmYWYzMmU5OGNjZDgwNjE3OWUzNzlhMTNiNzY2MThkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBGcmks IDUgSnVsIDIwMTkgMjE6NTA6NDQgKzAwMDAKU3ViamVjdDogW1BBVENIXSByZWhhc2ggaGFzaCB0 YWJsZXMgZWFnZXJseSBhZnRlciBsb2FkaW5nIHRoZSBwZHVtcGVyIGR1bXAuCgotLS0KIHNyYy9i eXRlY29kZS5jICB8ICAgMSAtCiBzcmMvY29tcG9zaXRlLmMgfCAgIDEgLQogc3JjL2VtYWNzLmMg ICAgIHwgICAxICsKIHNyYy9mbnMuYyAgICAgICB8ICAyNyArKystLS0tLS0tCiBzcmMvbGlzcC5o ICAgICAgfCAgMTUgLS0tLS0tCiBzcmMvbWluaWJ1Zi5jICAgfCAgIDMgLS0KIHNyYy9wZHVtcGVy LmMgICB8IDEzMiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t LS0KIHNyYy9wZHVtcGVyLmggICB8ICAgMSArCiA4IGZpbGVzIGNoYW5nZWQsIDEwMiBpbnNlcnRp b25zKCspLCA3OSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYnl0ZWNvZGUuYyBiL3Ny Yy9ieXRlY29kZS5jCmluZGV4IDI5ZGZmNDRmMDAuLjljNzI0MjllMGMgMTAwNjQ0Ci0tLSBhL3Ny Yy9ieXRlY29kZS5jCisrKyBiL3NyYy9ieXRlY29kZS5jCkBAIC0xNDAyLDcgKzE0MDIsNiBAQCAj ZGVmaW5lIERFRklORShuYW1lLCB2YWx1ZSkgTEFCRUwgKG5hbWUpICwKICAgICAgICAgICAgIExp c3BfT2JqZWN0IHYxID0gUE9QOwogICAgICAgICAgICAgcHRyZGlmZl90IGk7CiAgICAgICAgICAg ICBzdHJ1Y3QgTGlzcF9IYXNoX1RhYmxlICpoID0gWEhBU0hfVEFCTEUgKGptcF90YWJsZSk7Ci0g ICAgICAgICAgICBoYXNoX3JlaGFzaF9pZl9uZWVkZWQgKGgpOwogCiAgICAgICAgICAgICAvKiBo LT5jb3VudCBpcyBhIGZhc3RlciBhcHByb3hpbWF0aW9uIGZvciBIQVNIX1RBQkxFX1NJWkUgKGgp CiAgICAgICAgICAgICAgICBoZXJlLiAqLwpkaWZmIC0tZ2l0IGEvc3JjL2NvbXBvc2l0ZS5jIGIv c3JjL2NvbXBvc2l0ZS5jCmluZGV4IDE4MzA2MmRlNDYuLjQ5YTI4NWNmZjAgMTAwNjQ0Ci0tLSBh L3NyYy9jb21wb3NpdGUuYworKysgYi9zcmMvY29tcG9zaXRlLmMKQEAgLTY1NCw3ICs2NTQsNiBA QCBnc3RyaW5nX2xvb2t1cF9jYWNoZSAoTGlzcF9PYmplY3QgaGVhZGVyKQogY29tcG9zaXRpb25f Z3N0cmluZ19wdXRfY2FjaGUgKExpc3BfT2JqZWN0IGdzdHJpbmcsIHB0cmRpZmZfdCBsZW4pCiB7 CiAgIHN0cnVjdCBMaXNwX0hhc2hfVGFibGUgKmggPSBYSEFTSF9UQUJMRSAoZ3N0cmluZ19oYXNo X3RhYmxlKTsKLSAgaGFzaF9yZWhhc2hfaWZfbmVlZGVkIChoKTsKICAgTGlzcF9PYmplY3QgaGVh ZGVyID0gTEdTVFJJTkdfSEVBREVSIChnc3RyaW5nKTsKICAgRU1BQ1NfVUlOVCBoYXNoID0gaC0+ dGVzdC5oYXNoZm4gKCZoLT50ZXN0LCBoZWFkZXIpOwogICBpZiAobGVuIDwgMCkKZGlmZiAtLWdp dCBhL3NyYy9lbWFjcy5jIGIvc3JjL2VtYWNzLmMKaW5kZXggMzJiYjU3ZTI3Mi4uYTU5NjlhOTZh MyAxMDA2NDQKLS0tIGEvc3JjL2VtYWNzLmMKKysrIGIvc3JjL2VtYWNzLmMKQEAgLTE1NzcsNiAr MTU3Nyw3IEBAIG1haW4gKGludCBhcmdjLCBjaGFyICoqYXJndikKICAgaWYgKCFpbml0aWFsaXpl ZCkKICAgICB7CiAgICAgICBpbml0X2FsbG9jX29uY2UgKCk7CisgICAgICBpbml0X3BkdW1wZXJf b25jZSAoKTsKICAgICAgIGluaXRfb2JhcnJheV9vbmNlICgpOwogICAgICAgaW5pdF9ldmFsX29u Y2UgKCk7CiAgICAgICBpbml0X2NoYXJzZXRfb25jZSAoKTsKZGlmZiAtLWdpdCBhL3NyYy9mbnMu YyBiL3NyYy9mbnMuYwppbmRleCAyZmMwMDBhN2Y0Li44YjYwMzExNjE0IDEwMDY0NAotLS0gYS9z cmMvZm5zLmMKKysrIGIvc3JjL2Zucy5jCkBAIC00MjE4LDYgKzQyMTgsOSBAQCBtYXliZV9yZXNp emVfaGFzaF90YWJsZSAoc3RydWN0IExpc3BfSGFzaF9UYWJsZSAqaCkKICAgICB9CiB9CiAKK2V4 dGVybiB2b2lkCitoYXNoX3RhYmxlX3JlaGFzaCAoc3RydWN0IExpc3BfSGFzaF9UYWJsZSAqaCk7 CisKIHZvaWQKIGhhc2hfdGFibGVfcmVoYXNoIChzdHJ1Y3QgTGlzcF9IYXNoX1RhYmxlICpoKQog ewpAQCAtNDIyNiwxMiArNDIyOSwxMSBAQCBoYXNoX3RhYmxlX3JlaGFzaCAoc3RydWN0IExpc3Bf SGFzaF9UYWJsZSAqaCkKICAgLyogUmVjb21wdXRlIHRoZSBhY3R1YWwgaGFzaCBjb2RlcyBmb3Ig ZWFjaCBlbnRyeSBpbiB0aGUgdGFibGUuCiAgICAgIE9yZGVyIGlzIHN0aWxsIGludmFsaWQuICAq LwogICBmb3IgKHB0cmRpZmZfdCBpID0gMDsgaSA8IHNpemU7ICsraSkKLSAgICBpZiAoIU5JTFAg KEhBU0hfSEFTSCAoaCwgaSkpKQotICAgICAgewotICAgICAgICBMaXNwX09iamVjdCBrZXkgPSBI QVNIX0tFWSAoaCwgaSk7Ci0gICAgICAgIEVNQUNTX1VJTlQgaGFzaF9jb2RlID0gaC0+dGVzdC5o YXNoZm4gKCZoLT50ZXN0LCBrZXkpOwotICAgICAgICBzZXRfaGFzaF9oYXNoX3Nsb3QgKGgsIGks IG1ha2VfZml4bnVtIChoYXNoX2NvZGUpKTsKLSAgICAgIH0KKyAgICB7CisgICAgICBMaXNwX09i amVjdCBrZXkgPSBIQVNIX0tFWSAoaCwgaSk7CisgICAgICBFTUFDU19VSU5UIGhhc2hfY29kZSA9 IGgtPnRlc3QuaGFzaGZuICgmaC0+dGVzdCwga2V5KTsKKyAgICAgIHNldF9oYXNoX2hhc2hfc2xv dCAoaCwgaSwgbWFrZV9maXhudW0gKGhhc2hfY29kZSkpOworICAgIH0KIAogICAvKiBSZXNldCB0 aGUgaW5kZXggc28gdGhhdCBhbnkgc2xvdCB3ZSBkb24ndCBmaWxsIGJlbG93IGlzIG1hcmtlZAog ICAgICBpbnZhbGlkLiAgKi8KQEAgLTQyNDcsMTMgKzQyNDksNiBAQCBoYXNoX3RhYmxlX3JlaGFz aCAoc3RydWN0IExpc3BfSGFzaF9UYWJsZSAqaCkKICAgICAgICAgc2V0X2hhc2hfaW5kZXhfc2xv dCAoaCwgc3RhcnRfb2ZfYnVja2V0LCBpKTsKICAgICAgICAgZWFzc2VydCAoSEFTSF9ORVhUICho LCBpKSAhPSBpKTsgLyogU3RvcCBsb29wcy4gICovCiAgICAgICB9Ci0KLSAgLyogRmluYWxseSwg bWFyayB0aGUgaGFzaCB0YWJsZSBhcyBoYXZpbmcgYSB2YWxpZCBoYXNoIG9yZGVyLgotICAgICBE byB0aGlzIGxhc3Qgc28gdGhhdCBpZiB3ZSdyZSBpbnRlcnJ1cHRlZCwgd2UgcmV0cnkgb24gbmV4 dAotICAgICBhY2Nlc3MuICovCi0gIGVhc3NlcnQgKGgtPmNvdW50IDwgMCk7Ci0gIGgtPmNvdW50 ID0gLWgtPmNvdW50OwotICBlYXNzZXJ0ICghaGFzaF9yZWhhc2hfbmVlZGVkX3AgKGgpKTsKIH0K IAogLyogTG9va3VwIEtFWSBpbiBoYXNoIHRhYmxlIEguICBJZiBIQVNIIGlzIG5vbi1udWxsLCBy ZXR1cm4gaW4gKkhBU0gKQEAgLTQyNjYsOCArNDI2MSw2IEBAIGhhc2hfbG9va3VwIChzdHJ1Y3Qg TGlzcF9IYXNoX1RhYmxlICpoLCBMaXNwX09iamVjdCBrZXksIEVNQUNTX1VJTlQgKmhhc2gpCiAg IEVNQUNTX1VJTlQgaGFzaF9jb2RlOwogICBwdHJkaWZmX3Qgc3RhcnRfb2ZfYnVja2V0LCBpOwog Ci0gIGhhc2hfcmVoYXNoX2lmX25lZWRlZCAoaCk7Ci0KICAgaGFzaF9jb2RlID0gaC0+dGVzdC5o YXNoZm4gKCZoLT50ZXN0LCBrZXkpOwogICBlYXNzZXJ0ICgoaGFzaF9jb2RlICYgfklOVE1BU0sp ID09IDApOwogICBpZiAoaGFzaCkKQEAgLTQyOTYsOCArNDI4OSw2IEBAIGhhc2hfcHV0IChzdHJ1 Y3QgTGlzcF9IYXNoX1RhYmxlICpoLCBMaXNwX09iamVjdCBrZXksIExpc3BfT2JqZWN0IHZhbHVl LAogewogICBwdHJkaWZmX3Qgc3RhcnRfb2ZfYnVja2V0LCBpOwogCi0gIGhhc2hfcmVoYXNoX2lm X25lZWRlZCAoaCk7Ci0KICAgZWFzc2VydCAoKGhhc2ggJiB+SU5UTUFTSykgPT0gMCk7CiAKICAg LyogSW5jcmVtZW50IGNvdW50IGFmdGVyIHJlc2l6aW5nIGJlY2F1c2UgcmVzaXppbmcgbWF5IGZh aWwuICAqLwpAQCAtNDMzMSw4ICs0MzIyLDYgQEAgaGFzaF9yZW1vdmVfZnJvbV90YWJsZSAoc3Ry dWN0IExpc3BfSGFzaF9UYWJsZSAqaCwgTGlzcF9PYmplY3Qga2V5KQogICBwdHJkaWZmX3Qgc3Rh cnRfb2ZfYnVja2V0ID0gaGFzaF9jb2RlICUgQVNJWkUgKGgtPmluZGV4KTsKICAgcHRyZGlmZl90 IHByZXYgPSAtMTsKIAotICBoYXNoX3JlaGFzaF9pZl9uZWVkZWQgKGgpOwotCiAgIGZvciAocHRy ZGlmZl90IGkgPSBIQVNIX0lOREVYIChoLCBzdGFydF9vZl9idWNrZXQpOwogICAgICAgIDAgPD0g aTsKICAgICAgICBpID0gSEFTSF9ORVhUIChoLCBpKSkKZGlmZiAtLWdpdCBhL3NyYy9saXNwLmgg Yi9zcmMvbGlzcC5oCmluZGV4IDFhMWQ4ZWU3ZTQuLjdiNzdkZDk3ZjUgMTAwNjQ0Ci0tLSBhL3Ny Yy9saXNwLmgKKysrIGIvc3JjL2xpc3AuaApAQCAtMjM3MCwyMSArMjM3MCw2IEBAIEhBU0hfVEFC TEVfU0laRSAoY29uc3Qgc3RydWN0IExpc3BfSGFzaF9UYWJsZSAqaCkKICAgcmV0dXJuIEFTSVpF IChoLT5uZXh0KTsKIH0KIAotdm9pZCBoYXNoX3RhYmxlX3JlaGFzaCAoc3RydWN0IExpc3BfSGFz aF9UYWJsZSAqaCk7Ci0KLUlOTElORSBib29sCi1oYXNoX3JlaGFzaF9uZWVkZWRfcCAoY29uc3Qg c3RydWN0IExpc3BfSGFzaF9UYWJsZSAqaCkKLXsKLSAgcmV0dXJuIGgtPmNvdW50IDwgMDsKLX0K LQotSU5MSU5FIHZvaWQKLWhhc2hfcmVoYXNoX2lmX25lZWRlZCAoc3RydWN0IExpc3BfSGFzaF9U YWJsZSAqaCkKLXsKLSAgaWYgKGhhc2hfcmVoYXNoX25lZWRlZF9wIChoKSkKLSAgICBoYXNoX3Rh YmxlX3JlaGFzaCAoaCk7Ci19Ci0KIC8qIERlZmF1bHQgc2l6ZSBmb3IgaGFzaCB0YWJsZXMgaWYg bm90IHNwZWNpZmllZC4gICovCiAKIGVudW0gREVGQVVMVF9IQVNIX1NJWkUgeyBERUZBVUxUX0hB U0hfU0laRSA9IDY1IH07CmRpZmYgLS1naXQgYS9zcmMvbWluaWJ1Zi5jIGIvc3JjL21pbmlidWYu YwppbmRleCBkOTMyZGJlOGUyLi5hNzc1ZDA0MzMyIDEwMDY0NAotLS0gYS9zcmMvbWluaWJ1Zi5j CisrKyBiL3NyYy9taW5pYnVmLmMKQEAgLTEyMDMsOSArMTIwMyw2IEBAIERFRlVOICgidHJ5LWNv bXBsZXRpb24iLCBGdHJ5X2NvbXBsZXRpb24sIFN0cnlfY29tcGxldGlvbiwgMiwgMywgMCwKICAg ICAgIGJ1Y2tldCA9IEFSRUYgKGNvbGxlY3Rpb24sIGlkeCk7CiAgICAgfQogCi0gIGlmIChIQVNI X1RBQkxFX1AgKGNvbGxlY3Rpb24pKQotICAgIGhhc2hfcmVoYXNoX2lmX25lZWRlZCAoWEhBU0hf VEFCTEUgKGNvbGxlY3Rpb24pKTsKLQogICB3aGlsZSAoMSkKICAgICB7CiAgICAgICAvKiBHZXQg dGhlIG5leHQgZWxlbWVudCBvZiB0aGUgYWxpc3QsIG9iYXJyYXksIG9yIGhhc2gtdGFibGUuICAq LwpkaWZmIC0tZ2l0IGEvc3JjL3BkdW1wZXIuYyBiL3NyYy9wZHVtcGVyLmMKaW5kZXggYzAwZjhh MGFmNS4uYTM0ODBiNGIxNSAxMDA2NDQKLS0tIGEvc3JjL3BkdW1wZXIuYworKysgYi9zcmMvcGR1 bXBlci5jCkBAIC0zOTIsNiArMzkyLDggQEAgZHVtcF9maW5nZXJwcmludCAoY29uc3QgY2hhciAq bGFiZWwsIHVuc2lnbmVkIGNoYXIgY29uc3QgKnhmaW5nZXJwcmludCkKICAgICAgVGhlIHN0YXJ0 IG9mIHRoZSBjb2xkIHJlZ2lvbiBpcyBhbHdheXMgYWxpZ25lZCBvbiBhIHBhZ2UKICAgICAgYm91 bmRhcnkuICAqLwogICBkdW1wX29mZiBjb2xkX3N0YXJ0OworCisgIGR1bXBfb2ZmIGhhc2hfbGlz dDsKIH07CiAKIC8qIERvdWJsZS1lbmRlZCBzaW5nbHkgbGlua2VkIGxpc3QuICAqLwpAQCAtNTQ5 LDYgKzU1MSw4IEBAIGR1bXBfZmluZ2VycHJpbnQgKGNvbnN0IGNoYXIgKmxhYmVsLCB1bnNpZ25l ZCBjaGFyIGNvbnN0ICp4ZmluZ2VycHJpbnQpCiAgICAgIGhlYXAgb2JqZWN0cy4gICovCiAgIExp c3BfT2JqZWN0IGJpZ251bV9kYXRhOwogCisgIExpc3BfT2JqZWN0IGhhc2hfdGFibGVzOworCiAg IHVuc2lnbmVkIG51bWJlcl9ob3RfcmVsb2NhdGlvbnM7CiAgIHVuc2lnbmVkIG51bWJlcl9kaXNj YXJkYWJsZV9yZWxvY2F0aW9uczsKIH07CkBAIC0yNjQ3LDQyICsyNjUxLDYxIEBAIGR1bXBfaGFz aF90YWJsZV9zdGFibGVfcCAoY29uc3Qgc3RydWN0IExpc3BfSGFzaF9UYWJsZSAqaGFzaCkKIAog LyogUmV0dXJuIGEgbGlzdCBvZiAoS0VZIC4gVkFMVUUpIHBhaXJzIGluIHRoZSBnaXZlbiBoYXNo IHRhYmxlLiAgKi8KIHN0YXRpYyBMaXNwX09iamVjdAotaGFzaF90YWJsZV9jb250ZW50cyAoTGlz cF9PYmplY3QgdGFibGUpCitoYXNoX3RhYmxlX2NvbnRlbnRzIChzdHJ1Y3QgTGlzcF9IYXNoX1Rh YmxlICpoKQogewogICBMaXNwX09iamVjdCBjb250ZW50cyA9IFFuaWw7Ci0gIHN0cnVjdCBMaXNw X0hhc2hfVGFibGUgKmggPSBYSEFTSF9UQUJMRSAodGFibGUpOwogICBmb3IgKHB0cmRpZmZfdCBp ID0gMDsgaSA8IEhBU0hfVEFCTEVfU0laRSAoaCk7ICsraSkKICAgICBpZiAoIU5JTFAgKEhBU0hf SEFTSCAoaCwgaSkpKQotICAgICAgZHVtcF9wdXNoICgmY29udGVudHMsIEZjb25zIChIQVNIX0tF WSAoaCwgaSksIEhBU0hfVkFMVUUgKGgsIGkpKSk7CisgICAgICB7CisJZHVtcF9wdXNoICgmY29u dGVudHMsIEhBU0hfS0VZIChoLCBpKSk7CisJZHVtcF9wdXNoICgmY29udGVudHMsIEhBU0hfVkFM VUUgKGgsIGkpKTsKKyAgICAgIH0KICAgcmV0dXJuIEZucmV2ZXJzZSAoY29udGVudHMpOwogfQog Ci0vKiBDb3B5IHRoZSBnaXZlbiBoYXNoIHRhYmxlLCByZWhhc2ggaXQsIGFuZCBtYWtlIHN1cmUg dGhhdCB3ZSBjYW4KLSAgIGxvb2sgdXAgYWxsIHRoZSB2YWx1ZXMgaW4gdGhlIG9yaWdpbmFsLiAg Ki8KK3N0YXRpYyBkdW1wX29mZgorZHVtcF9oYXNoX3RhYmxlX2xpc3QgKHN0cnVjdCBkdW1wX2Nv bnRleHQgKmN0eCkKK3sKKyAgaWYgKENPTlNQIChjdHgtPmhhc2hfdGFibGVzKSkKKyAgICByZXR1 cm4gZHVtcF9vYmplY3QgKGN0eCwgY3R4LT5oYXNoX3RhYmxlcyk7CisgIGVsc2UKKyAgICByZXR1 cm4gMDsKK30KKwogc3RhdGljIHZvaWQKLWNoZWNrX2hhc2hfdGFibGVfcmVoYXNoIChMaXNwX09i amVjdCB0YWJsZV9vcmlnKQotewotICBoYXNoX3JlaGFzaF9pZl9uZWVkZWQgKFhIQVNIX1RBQkxF ICh0YWJsZV9vcmlnKSk7Ci0gIExpc3BfT2JqZWN0IHRhYmxlX3JlaGFzaGVkID0gRmNvcHlfaGFz aF90YWJsZSAodGFibGVfb3JpZyk7Ci0gIGVhc3NlcnQgKFhIQVNIX1RBQkxFICh0YWJsZV9yZWhh c2hlZCktPmNvdW50ID49IDApOwotICBYSEFTSF9UQUJMRSAodGFibGVfcmVoYXNoZWQpLT5jb3Vu dCAqPSAtMTsKLSAgZWFzc2VydCAoWEhBU0hfVEFCTEUgKHRhYmxlX3JlaGFzaGVkKS0+Y291bnQg PD0gMCk7Ci0gIGhhc2hfcmVoYXNoX2lmX25lZWRlZCAoWEhBU0hfVEFCTEUgKHRhYmxlX3JlaGFz aGVkKSk7Ci0gIGVhc3NlcnQgKFhIQVNIX1RBQkxFICh0YWJsZV9yZWhhc2hlZCktPmNvdW50ID49 IDApOwotICBMaXNwX09iamVjdCBleHBlY3RlZF9jb250ZW50cyA9IGhhc2hfdGFibGVfY29udGVu dHMgKHRhYmxlX29yaWcpOwotICB3aGlsZSAoIU5JTFAgKGV4cGVjdGVkX2NvbnRlbnRzKSkKK2hh c2hfdGFibGVfZnJlZXplIChzdHJ1Y3QgTGlzcF9IYXNoX1RhYmxlICpoKQoreworICBpZiAoaC0+ Y291bnQgPiAwKQorICAgIGgtPmNvdW50ID0gLWgtPmNvdW50OworICBoLT5rZXlfYW5kX3ZhbHVl ID0gaGFzaF90YWJsZV9jb250ZW50cyAoaCk7CisgIHB0cmRpZmZfdCBua2V5cyA9IFhGSVhOQVQg KEZsZW5ndGggKGgtPmtleV9hbmRfdmFsdWUpKSAvIDI7CisgIGlmIChua2V5cyA9PSAwKQorICAg IG5rZXlzID0gMTsKKyAgaC0+aW5kZXggPSBoLT5uZXh0ID0gaC0+aGFzaCA9IG1ha2VfZml4bnVt IChua2V5cyk7CisgIGgtPmNvdW50ID0gbmtleXM7Cit9CisKKy8qIERlZmluZWQgaW4gZm5zLmMu ICAqLworZXh0ZXJuIHZvaWQgaGFzaF90YWJsZV9yZWhhc2ggKHN0cnVjdCBMaXNwX0hhc2hfVGFi bGUgKmgpOworCitzdGF0aWMgdm9pZAoraGFzaF90YWJsZV90aGF3IChzdHJ1Y3QgTGlzcF9IYXNo X1RhYmxlICpoKQoreworICBMaXNwX09iamVjdCBjb3VudCA9IGgtPmluZGV4OworICBoLT5pbmRl eCA9IEZtYWtlX3ZlY3RvciAoaC0+aW5kZXgsIG1ha2VfZml4bnVtICgtMSkpOworICBoLT5oYXNo ID0gRm1ha2VfdmVjdG9yIChoLT5oYXNoLCBRbmlsKTsKKyAgaC0+bmV4dCA9IEZtYWtlX3ZlY3Rv ciAoaC0+bmV4dCwgbWFrZV9maXhudW0gKC0xKSk7CisgIExpc3BfT2JqZWN0IGtleV9hbmRfdmFs dWUgPSBoLT5rZXlfYW5kX3ZhbHVlOworICBoLT5rZXlfYW5kX3ZhbHVlID0gRm1ha2VfdmVjdG9y IChtYWtlX2ZpeG51bSAoMiAqIFhGSVhOQVQgKGNvdW50KSksIFFuaWwpOworICBoLT5uZXh0X2Zy ZWUgPSAtMTsKKyAgcHRyZGlmZl90IGkgPSAwOworICB3aGlsZSAoQ09OU1AgKGtleV9hbmRfdmFs dWUpKQogICAgIHsKLSAgICAgIExpc3BfT2JqZWN0IGtleV92YWx1ZV9wYWlyID0gZHVtcF9wb3Ag KCZleHBlY3RlZF9jb250ZW50cyk7Ci0gICAgICBMaXNwX09iamVjdCBrZXkgPSBYQ0FSIChrZXlf dmFsdWVfcGFpcik7Ci0gICAgICBMaXNwX09iamVjdCBleHBlY3RlZF92YWx1ZSA9IFhDRFIgKGtl eV92YWx1ZV9wYWlyKTsKLSAgICAgIExpc3BfT2JqZWN0IGFyYml0cmFyeSA9IFFkdW1wX2VtYWNz X3BvcnRhYmxlX19zb3J0X3ByZWRpY2F0ZV9jb3BpZWQ7Ci0gICAgICBMaXNwX09iamVjdCBmb3Vu ZF92YWx1ZSA9IEZnZXRoYXNoIChrZXksIHRhYmxlX3JlaGFzaGVkLCBhcmJpdHJhcnkpOwotICAg ICAgZWFzc2VydCAoRVEgKGV4cGVjdGVkX3ZhbHVlLCBmb3VuZF92YWx1ZSkpOwotICAgICAgRnJl bWhhc2ggKGtleSwgdGFibGVfcmVoYXNoZWQpOworICAgICAgQVNFVCAoaC0+a2V5X2FuZF92YWx1 ZSwgaSsrLCBYQ0FSIChrZXlfYW5kX3ZhbHVlKSk7CisgICAgICBrZXlfYW5kX3ZhbHVlID0gWENE UiAoa2V5X2FuZF92YWx1ZSk7CiAgICAgfQogCi0gIGVhc3NlcnQgKEVRIChGaGFzaF90YWJsZV9j b3VudCAodGFibGVfcmVoYXNoZWQpLAotICAgICAgICAgICAgICAgbWFrZV9maXhudW0gKDApKSk7 CisgIGhhc2hfdGFibGVfcmVoYXNoIChoKTsKIH0KIAogc3RhdGljIGR1bXBfb2ZmCkBAIC0yNzA3 LDggKzI3MzAsNiBAQCBkdW1wX2hhc2hfdGFibGUgKHN0cnVjdCBkdW1wX2NvbnRleHQgKmN0eCwK ICAgICAgICAgewogCSAgZWFzc2VydCAob2Zmc2V0ID09IERVTVBfT0JKRUNUX09OX05PUk1BTF9R VUVVRQogCQkgICB8fCBvZmZzZXQgPT0gRFVNUF9PQkpFQ1RfTk9UX1NFRU4pOwotICAgICAgICAg IC8qIFdlIHN0aWxsIHdhbnQgdG8gZHVtcCB0aGUgYWN0dWFsIGtleXMgYW5kIHZhbHVlcyBub3cu ICAqLwotICAgICAgICAgIGR1bXBfZW5xdWV1ZV9vYmplY3QgKGN0eCwgaGFzaF9pbi0+a2V5X2Fu ZF92YWx1ZSwgV0VJR0hUX05PTkUpOwogICAgICAgICAgIC8qIFdlJ2xsIGdldCB0byB0aGUgcmVz dCBsYXRlci4gICovCiAgICAgICAgICAgb2Zmc2V0ID0gRFVNUF9PQkpFQ1RfT05fSEFTSF9UQUJM RV9RVUVVRTsKICAgICAgICAgICBkdW1wX3JlbWVtYmVyX29iamVjdCAoY3R4LCBvYmplY3QsIG9m ZnNldCk7CkBAIC0yNzE3LDIyICsyNzM4LDExIEBAIGR1bXBfaGFzaF90YWJsZSAoc3RydWN0IGR1 bXBfY29udGV4dCAqY3R4LAogICAgICAgcmV0dXJuIG9mZnNldDsKICAgICB9CiAKLSAgaWYgKFBE VU1QRVJfQ0hFQ0tfUkVIQVNISU5HKQotICAgIGNoZWNrX2hhc2hfdGFibGVfcmVoYXNoIChtYWtl X2xpc3BfcHRyICgodm9pZCAqKSBoYXNoX2luLCBMaXNwX1ZlY3Rvcmxpa2UpKTsKLQogICBzdHJ1 Y3QgTGlzcF9IYXNoX1RhYmxlIGhhc2hfbXVuZ2VkID0gKmhhc2hfaW47CiAgIHN0cnVjdCBMaXNw X0hhc2hfVGFibGUgKmhhc2ggPSAmaGFzaF9tdW5nZWQ7CiAKLSAgLyogUmVtZW1iZXIgdG8gcmVo YXNoIHRoaXMgaGFzaCB0YWJsZSBvbiBmaXJzdCBhY2Nlc3MuICBBZnRlciBhCi0gICAgIGR1bXAg cmVsb2FkLCB0aGUgaGFzaCB0YWJsZSB2YWx1ZXMgd2lsbCBoYXZlIGNoYW5nZWQsIHNvIHdlJ2xs Ci0gICAgIG5lZWQgdG8gcmVidWlsZCB0aGUgaW5kZXguCi0KLSAgICAgVE9ETzogZm9yIEVRIGFu ZCBFUUwgaGFzaCB0YWJsZXMsIGl0IHNob3VsZCBiZSBwb3NzaWJsZSB0byByZWhhc2gKLSAgICAg aGVyZSB1c2luZyB0aGUgcHJlZmVycmVkIGxvYWQgYWRkcmVzcyBvZiB0aGUgZHVtcCwgZWxpbWlu YXRpbmcKLSAgICAgdGhlIG5lZWQgdG8gcmVoYXNoLW9uLWFjY2VzcyBpZiB3ZSBjYW4gbG9hZCB0 aGUgZHVtcCB3aGVyZSB3ZQotICAgICB3YW50LiAgKi8KLSAgaWYgKGhhc2gtPmNvdW50ID4gMCAm JiAhaXNfc3RhYmxlKQotICAgIGhhc2gtPmNvdW50ID0gLWhhc2gtPmNvdW50OworICBoYXNoX3Rh YmxlX2ZyZWV6ZSAoaGFzaCk7CisgIGR1bXBfcHVzaCAoJmN0eC0+aGFzaF90YWJsZXMsIG9iamVj dCk7CiAKICAgU1RBUlRfRFVNUF9QVkVDIChjdHgsICZoYXNoLT5oZWFkZXIsIHN0cnVjdCBMaXNw X0hhc2hfVGFibGUsIG91dCk7CiAgIGR1bXBfcHNldWRvdmVjdG9yX2xpc3BfZmllbGRzIChjdHgs ICZvdXQtPmhlYWRlciwgJmhhc2gtPmhlYWRlcik7CkBAIC00MTQxLDYgKzQxNTEsMjAgQEAgREVG VU4gKCJkdW1wLWVtYWNzLXBvcnRhYmxlIiwKIAkgfHwgIU5JTFAgKGN0eC0+ZGVmZXJyZWRfaGFz aF90YWJsZXMpCiAJIHx8ICFOSUxQIChjdHgtPmRlZmVycmVkX3N5bWJvbHMpKTsKIAorICBjdHgt PmhlYWRlci5oYXNoX2xpc3QgPSBjdHgtPm9mZnNldDsKKyAgZHVtcF9wdXNoICgmY3R4LT5oYXNo X3RhYmxlcywgUW5pbCk7CisgIGR1bXBfaGFzaF90YWJsZV9saXN0IChjdHgpOworCisgIGRvCisg ICAgeworICAgICAgZHVtcF9kcmFpbl9kZWZlcnJlZF9oYXNoX3RhYmxlcyAoY3R4KTsKKyAgICAg IGR1bXBfZHJhaW5fZGVmZXJyZWRfc3ltYm9scyAoY3R4KTsKKyAgICAgIGR1bXBfZHJhaW5fbm9y bWFsX3F1ZXVlIChjdHgpOworICAgIH0KKyAgd2hpbGUgKCFkdW1wX3F1ZXVlX2VtcHR5X3AgKCZj dHgtPmR1bXBfcXVldWUpCisJIHx8ICFOSUxQIChjdHgtPmRlZmVycmVkX2hhc2hfdGFibGVzKQor CSB8fCAhTklMUCAoY3R4LT5kZWZlcnJlZF9zeW1ib2xzKSk7CisKICAgZHVtcF9zb3J0X2NvcGll ZF9vYmplY3RzIChjdHgpOwogCiAgIC8qIFdoaWxlIHdlIGNvcHkgYnVpbHQtaW4gc3ltYm9scyBp bnRvIHRoZSBFbWFjcyBpbWFnZSwgdGhlc2UKQEAgLTU0MjksNiArNTQ1MywxMyBAQCBwZHVtcGVy X2xvYWQgKGNvbnN0IGNoYXIgKmR1bXBfZmlsZW5hbWUpCiAgIGZvciAoaW50IGkgPSAwOyBpIDwg QVJSQVlFTFRTIChzZWN0aW9ucyk7ICsraSkKICAgICBkdW1wX21tYXBfcmVzZXQgKCZzZWN0aW9u c1tpXSk7CiAKKyAgaWYgKGhlYWRlci0+aGFzaF9saXN0KQorICAgIHsKKyAgICAgIExpc3BfT2Jq ZWN0IGhhc2hfdGFibGVzID0KKwkoKExpc3BfT2JqZWN0ICopKGR1bXBfYmFzZSArIGhlYWRlci0+ aGFzaF9saXN0KSlbMV07CisgICAgICBWcGR1bXBlcl9oYXNoX3RhYmxlcyA9IGhhc2hfdGFibGVz OworICAgIH0KKwogICAvKiBSdW4gdGhlIGZ1bmN0aW9ucyBFbWFjcyByZWdpc3RlcmVkIGZvciBk b2luZyBwb3N0LWR1bXAtbG9hZAogICAgICBpbml0aWFsaXphdGlvbi4gICovCiAgIGZvciAoaW50 IGkgPSAwOyBpIDwgbnJfZHVtcF9ob29rczsgKytpKQpAQCAtNTQ5OCwxMiArNTUyOSwzMyBAQCBE RUZVTiAoInBkdW1wZXItc3RhdHMiLCBGcGR1bXBlcl9zdGF0cywgU3BkdW1wZXJfc3RhdHMsIDAs IDAsIDAsCiAKICNlbmRpZiAvKiBIQVZFX1BEVU1QRVIgKi8KIAorCiAMCiAKK3N0YXRpYyB2b2lk IHRoYXdfaGFzaF90YWJsZXMgKHZvaWQpCit7CisgIExpc3BfT2JqZWN0IGhhc2hfdGFibGVzID0g VnBkdW1wZXJfaGFzaF90YWJsZXM7CisgIHdoaWxlIChDT05TUCAoaGFzaF90YWJsZXMpKQorICAg IHsKKyAgICAgIGhhc2hfdGFibGVfdGhhdyAoWEhBU0hfVEFCTEUgKFhDQVIgKGhhc2hfdGFibGVz KSkpOworICAgICAgaGFzaF90YWJsZXMgPSBYQ0RSIChoYXNoX3RhYmxlcyk7CisgICAgfQorfQor Cit2b2lkCitpbml0X3BkdW1wZXJfb25jZSAodm9pZCkKK3sKKyAgVnBkdW1wZXJfaGFzaF90YWJs ZXMgPSBRbmlsOworICBwZHVtcGVyX2RvX25vd19hbmRfYWZ0ZXJfbG9hZCAodGhhd19oYXNoX3Rh Ymxlcyk7Cit9CisKIHZvaWQKIHN5bXNfb2ZfcGR1bXBlciAodm9pZCkKIHsKICNpZmRlZiBIQVZF X1BEVU1QRVIKKyAgREVGVkFSX0xJU1AgKCJwZHVtcGVyLWhhc2gtdGFibGVzIiwgVnBkdW1wZXJf aGFzaF90YWJsZXMsCisJICAgICAgIGRvYzogLyogQSBsaXN0IG9mIGhhc2ggdGFibGVzIHRoYXQg bmVlZCB0byBiZSB0aGF3ZWQgYWZ0ZXIgbG9hZGluZyB0aGUgcGR1bXAuICAqLyk7CisgIFZwZHVt cGVyX2hhc2hfdGFibGVzID0gUW5pbDsKICAgZGVmc3ViciAoJlNkdW1wX2VtYWNzX3BvcnRhYmxl KTsKICAgZGVmc3ViciAoJlNkdW1wX2VtYWNzX3BvcnRhYmxlX19zb3J0X3ByZWRpY2F0ZSk7CiAg IGRlZnN1YnIgKCZTZHVtcF9lbWFjc19wb3J0YWJsZV9fc29ydF9wcmVkaWNhdGVfY29waWVkKTsK ZGlmZiAtLWdpdCBhL3NyYy9wZHVtcGVyLmggYi9zcmMvcGR1bXBlci5oCmluZGV4IGFiMmY0MjZj MWUuLmNmZWEwNmQzM2QgMTAwNjQ0Ci0tLSBhL3NyYy9wZHVtcGVyLmgKKysrIGIvc3JjL3BkdW1w ZXIuaApAQCAtMjQ4LDYgKzI0OCw3IEBAIHBkdW1wZXJfY2xlYXJfbWFya3MgKHZvaWQpCiAgICBm aWxlIHdhcyBsb2FkZWQuICAqLwogZXh0ZXJuIHZvaWQgcGR1bXBlcl9yZWNvcmRfd2QgKGNvbnN0 IGNoYXIgKik7CiAKK3ZvaWQgaW5pdF9wZHVtcGVyX29uY2UgKHZvaWQpOwogdm9pZCBzeW1zX29m X3BkdW1wZXIgKHZvaWQpOwogCiBJTkxJTkVfSEVBREVSX0VORAotLSAKMi4yMC4xCgo= --000000000000553536058cf61f3f-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 18:11:08 2019 Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 22:11:08 +0000 Received: from localhost ([127.0.0.1]:53907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjWQ7-0004wh-Tj for submit@debbugs.gnu.org; Fri, 05 Jul 2019 18:11:08 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:32039) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjWQ5-0004wC-N9 for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 18:11:06 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 632C11009BB; Fri, 5 Jul 2019 18:10:59 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A7A5810087A; Fri, 5 Jul 2019 18:10:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1562364657; bh=0gYfnQzHZeeovpAqR/GqDSwq860vN6UtOD0FW70e2GM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gZIVE9HBv2BsemC+l4Aa82O0T8syq5jbXLfJMyorfvsAzbY/PjqKZ23xGoP82on1s QvMpGgpw4wXt36WhksjWnbIH0hosM2HxVld2WilNpY23+0L0PrXfEus06x7dYid0xU MAPjhAUDs9lX5K5zg41qrYkuFcF9WHpNG0KdPR3+EDCEONm4BlxYoqwLv5edUVIDPm 0jF5bdN3xHX9XHAcs0Gz3BOH1oOnuIiLWAL/U4QzDDZ32ubxpUT8NAHNq1+GxyXTnD pGbR7YHZVS8fWU8Ca6zR1a9Hg4DoV+mM2IWTIrbVNzUAVeddWxjgC7REkgiAoiIIb0 6wMFG+gTDPFhA== Received: from alfajor (76-10-138-228.dsl.teksavvy.com [76.10.138.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 61BC712082B; Fri, 5 Jul 2019 18:10:57 -0400 (EDT) From: Stefan Monnier To: Pip Cet Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors Message-ID: References: <875zon7x0a.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> Date: Fri, 05 Jul 2019 18:10:56 -0400 In-Reply-To: (Pip Cet's message of "Fri, 5 Jul 2019 21:52:41 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.132 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, Eli Zaretskii , npostavs@gmail.com, 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> >> His patch can/should be made slightly more efficient by only doing the >> >> Fcopy_sequence on those hash-tables that are in purespace. >> > How do we test for that? >> With PURE_P? > That only works before we dump, I think? If so, it's new (probably introduced by the pdumper). > Indeed. I'm attaching a proof of concept that we can simply freeze the > hash tables when dumping and thaw them when loading a dump, which > includes rehashing. Do you happen to know why it wasn't done that way? I'd guess it was to shorten the startup time by doing this rehashing lazily. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 06 02:45:28 2019 Received: (at 36447) by debbugs.gnu.org; 6 Jul 2019 06:45:28 +0000 Received: from localhost ([127.0.0.1]:54137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjeRr-0000xT-VJ for submit@debbugs.gnu.org; Sat, 06 Jul 2019 02:45:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjeRp-0000xD-Ef for 36447@debbugs.gnu.org; Sat, 06 Jul 2019 02:45:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hjeRg-0004AY-3u; Sat, 06 Jul 2019 02:45:18 -0400 Received: from [176.228.60.248] (port=4363 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hjeRf-0002GX-FX; Sat, 06 Jul 2019 02:45:16 -0400 Date: Sat, 06 Jul 2019 09:45:10 +0300 Message-Id: <83bly7acg9.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Fri, 05 Jul 2019 18:10:56 -0400) Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, npostavs@gmail.com, pipcet@gmail.com, 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Eli Zaretskii , michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org > Date: Fri, 05 Jul 2019 18:10:56 -0400 > > > Indeed. I'm attaching a proof of concept that we can simply freeze the > > hash tables when dumping and thaw them when loading a dump, which > > includes rehashing. Do you happen to know why it wasn't done that way? > > I'd guess it was to shorten the startup time by doing this rehashing lazily. The function pdumper-stats with show the time it took to load Emacs, so the effect of this on the load time can be measured. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 06 11:08:55 2019 Received: (at 36447) by debbugs.gnu.org; 6 Jul 2019 15:08:55 +0000 Received: from localhost ([127.0.0.1]:55753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjmJ4-0007h2-DD for submit@debbugs.gnu.org; Sat, 06 Jul 2019 11:08:55 -0400 Received: from mail-oi1-f170.google.com ([209.85.167.170]:42467) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjmJ3-0007gn-12 for 36447@debbugs.gnu.org; Sat, 06 Jul 2019 11:08:53 -0400 Received: by mail-oi1-f170.google.com with SMTP id s184so9230804oie.9 for <36447@debbugs.gnu.org>; Sat, 06 Jul 2019 08:08:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=La61wYM4iHV/8JiBEA5u8WIeRDB6RITfs3wcUMSVnyM=; b=S0HCCEuGgaMk6a1QnaHvzt8CvPn+L2ui/lcOpvvHXUbDWF2Dr99ssKqVM66o97KajL MaRgQaP8+KCvUWbZ5F5RHnWYs53BJHVuotYJ4igMyRnZyV3xdT8y6ym/XzU8qUvSZxp9 F8akNmNm7sqUuJUYSaO3IwQOspRiF1ONh8fv+I8eeYrPRWCCtgswVL/6SS68wBRULi2p VP6gaQk5gqhfSG5np/vRia3VXpu+YHCI01BuNw7kYTb9Hx36ETfMPgl+DRSbvgWSy3Fm phK0sCF7lQ751b1o4hWR9nsl2Cyg9bI0bU2rzQ/SySwQkg7kbvRD9LZwS2Zu8P/wvgcP b+fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=La61wYM4iHV/8JiBEA5u8WIeRDB6RITfs3wcUMSVnyM=; b=ZgyitrDEuNvRMiUyMc5LtHcdbl6iZ40GNjCZy69AyN+MnExNDfJ7bwwVCKuGlZIPvV 7eY/tfK5d3ASVxGERLDkFX/k9L0EBqWSZfJdZ1borvkAWYdc+w7u8xskjBljmUPNLj6H Oym2/xNvg0zIlS5qAgIqsDLfRX5olPObU9dYpxFMHLRxeaxCRD9dUKEomot9ot+ZRGov A84M0ak/5dROBBt9Q1NmBpOtb0NaEBWVEJvBhX5P+Ml1eP8HUUdZZAoCVfuWELXvIobv MuctLBEj2jHsH3v8Xy/zQMgg1UMMyz45c+vX0BR35bt+yEnmTWlaxxtx/72OsZxG2IH0 UPyQ== X-Gm-Message-State: APjAAAVrXi2PaUfSQ37YnNq/vW9yHLKrfxwWC+lLtLugnodvjUR5otpx zMVSYnalOu0mnF1qMwJpBqYvpJXQDOlSafc7Rag= X-Google-Smtp-Source: APXvYqzqtj2vcgUA+Dt+/UuLWbc0FW+SWfwsyY9VQaCAYv8zBljACkmJLKzXj7d3QxQ6McVYrcw65r5bR7+lpeni6JQ= X-Received: by 2002:aca:4790:: with SMTP id u138mr5050499oia.44.1562425727398; Sat, 06 Jul 2019 08:08:47 -0700 (PDT) MIME-Version: 1.0 References: <875zon7x0a.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> <83bly7acg9.fsf@gnu.org> In-Reply-To: <83bly7acg9.fsf@gnu.org> From: Pip Cet Date: Sat, 6 Jul 2019 15:08:08 +0000 Message-ID: Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000785ab6058d049693" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, 36447@debbugs.gnu.org, Stefan Monnier , npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000785ab6058d049693 Content-Type: text/plain; charset="UTF-8" On Sat, Jul 6, 2019 at 6:45 AM Eli Zaretskii wrote: > > > Indeed. I'm attaching a proof of concept that we can simply freeze the > > > hash tables when dumping and thaw them when loading a dump, which > > > includes rehashing. Do you happen to know why it wasn't done that way? > > > > I'd guess it was to shorten the startup time by doing this rehashing lazily. > > The function pdumper-stats with show the time it took to load Emacs, > so the effect of this on the load time can be measured I'm measuring it directly, and it's more than I expected: about a millisecond, for 4,300 hash table entries. What we can't easily measure is how much the lazy rehashing code would slow us down anyway. For comparison, the entire time stored in pdumper-stats is 15 ms here. I don't think that's significant, because we'd probably end up rehashing most of the large hash tables anyway. We're saving some 250 KB of space in the pdmp image, which was previously used for redundant information. (I'm surprised it's that much, but I guess pdumper relocations are fairly large?) I'm attaching a revised patch, which uses vectors rather than consed lists for both the key_and_value vector, avoiding a copy in the common case where there is more than one hash table entry, and for the list of hash tables. It still contains debugging/timing code. charset.c currently assumes hash table entries will stay at the same index in Vcharset_hash_table. I think that works okay in practice, because we don't shrink or reorder hash tables, but it was still a bit of a nasty surprise. This concept appears to work: modify pdumper to special-case hash tables and freeze/thaw them properly. You probably shouldn't dump hash tables with complicated user-defined hash functions. Both PURE_P and pdumper_object_p fail to distinguish between tables that were pure or impure before being dumped. This also fixes the bug that (hash-table-count dumped-hash-table) will return a negative number if no previous access to the hash table has happened, but of course we can fix that directly... Of course, we're still modifying purecopied information. --000000000000785ab6058d049693 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Rehash-eagerly.patch" Content-Disposition: attachment; filename="0001-Rehash-eagerly.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxrntw3d0 ZGlmZiAtLWdpdCBhL3NyYy9ieXRlY29kZS5jIGIvc3JjL2J5dGVjb2RlLmMKaW5kZXggMjlkZmY0 NGYwMC4uOWM3MjQyOWUwYyAxMDA2NDQKLS0tIGEvc3JjL2J5dGVjb2RlLmMKKysrIGIvc3JjL2J5 dGVjb2RlLmMKQEAgLTE0MDIsNyArMTQwMiw2IEBAICNkZWZpbmUgREVGSU5FKG5hbWUsIHZhbHVl KSBMQUJFTCAobmFtZSkgLAogICAgICAgICAgICAgTGlzcF9PYmplY3QgdjEgPSBQT1A7CiAgICAg ICAgICAgICBwdHJkaWZmX3QgaTsKICAgICAgICAgICAgIHN0cnVjdCBMaXNwX0hhc2hfVGFibGUg KmggPSBYSEFTSF9UQUJMRSAoam1wX3RhYmxlKTsKLSAgICAgICAgICAgIGhhc2hfcmVoYXNoX2lm X25lZWRlZCAoaCk7CiAKICAgICAgICAgICAgIC8qIGgtPmNvdW50IGlzIGEgZmFzdGVyIGFwcHJv eGltYXRpb24gZm9yIEhBU0hfVEFCTEVfU0laRSAoaCkKICAgICAgICAgICAgICAgIGhlcmUuICov CmRpZmYgLS1naXQgYS9zcmMvY29tcG9zaXRlLmMgYi9zcmMvY29tcG9zaXRlLmMKaW5kZXggMTgz MDYyZGU0Ni4uNDlhMjg1Y2ZmMCAxMDA2NDQKLS0tIGEvc3JjL2NvbXBvc2l0ZS5jCisrKyBiL3Ny Yy9jb21wb3NpdGUuYwpAQCAtNjU0LDcgKzY1NCw2IEBAIGdzdHJpbmdfbG9va3VwX2NhY2hlIChM aXNwX09iamVjdCBoZWFkZXIpCiBjb21wb3NpdGlvbl9nc3RyaW5nX3B1dF9jYWNoZSAoTGlzcF9P YmplY3QgZ3N0cmluZywgcHRyZGlmZl90IGxlbikKIHsKICAgc3RydWN0IExpc3BfSGFzaF9UYWJs ZSAqaCA9IFhIQVNIX1RBQkxFIChnc3RyaW5nX2hhc2hfdGFibGUpOwotICBoYXNoX3JlaGFzaF9p Zl9uZWVkZWQgKGgpOwogICBMaXNwX09iamVjdCBoZWFkZXIgPSBMR1NUUklOR19IRUFERVIgKGdz dHJpbmcpOwogICBFTUFDU19VSU5UIGhhc2ggPSBoLT50ZXN0Lmhhc2hmbiAoJmgtPnRlc3QsIGhl YWRlcik7CiAgIGlmIChsZW4gPCAwKQpkaWZmIC0tZ2l0IGEvc3JjL2VtYWNzLmMgYi9zcmMvZW1h Y3MuYwppbmRleCAzMmJiNTdlMjcyLi5hNTk2OWE5NmEzIDEwMDY0NAotLS0gYS9zcmMvZW1hY3Mu YworKysgYi9zcmMvZW1hY3MuYwpAQCAtMTU3Nyw2ICsxNTc3LDcgQEAgbWFpbiAoaW50IGFyZ2Ms IGNoYXIgKiphcmd2KQogICBpZiAoIWluaXRpYWxpemVkKQogICAgIHsKICAgICAgIGluaXRfYWxs b2Nfb25jZSAoKTsKKyAgICAgIGluaXRfcGR1bXBlcl9vbmNlICgpOwogICAgICAgaW5pdF9vYmFy cmF5X29uY2UgKCk7CiAgICAgICBpbml0X2V2YWxfb25jZSAoKTsKICAgICAgIGluaXRfY2hhcnNl dF9vbmNlICgpOwpkaWZmIC0tZ2l0IGEvc3JjL2Zucy5jIGIvc3JjL2Zucy5jCmluZGV4IDJmYzAw MGE3ZjQuLjhiNjAzMTE2MTQgMTAwNjQ0Ci0tLSBhL3NyYy9mbnMuYworKysgYi9zcmMvZm5zLmMK QEAgLTQyMTgsNiArNDIxOCw5IEBAIG1heWJlX3Jlc2l6ZV9oYXNoX3RhYmxlIChzdHJ1Y3QgTGlz cF9IYXNoX1RhYmxlICpoKQogICAgIH0KIH0KIAorZXh0ZXJuIHZvaWQKK2hhc2hfdGFibGVfcmVo YXNoIChzdHJ1Y3QgTGlzcF9IYXNoX1RhYmxlICpoKTsKKwogdm9pZAogaGFzaF90YWJsZV9yZWhh c2ggKHN0cnVjdCBMaXNwX0hhc2hfVGFibGUgKmgpCiB7CkBAIC00MjI2LDEyICs0MjI5LDExIEBA IGhhc2hfdGFibGVfcmVoYXNoIChzdHJ1Y3QgTGlzcF9IYXNoX1RhYmxlICpoKQogICAvKiBSZWNv bXB1dGUgdGhlIGFjdHVhbCBoYXNoIGNvZGVzIGZvciBlYWNoIGVudHJ5IGluIHRoZSB0YWJsZS4K ICAgICAgT3JkZXIgaXMgc3RpbGwgaW52YWxpZC4gICovCiAgIGZvciAocHRyZGlmZl90IGkgPSAw OyBpIDwgc2l6ZTsgKytpKQotICAgIGlmICghTklMUCAoSEFTSF9IQVNIIChoLCBpKSkpCi0gICAg ICB7Ci0gICAgICAgIExpc3BfT2JqZWN0IGtleSA9IEhBU0hfS0VZIChoLCBpKTsKLSAgICAgICAg RU1BQ1NfVUlOVCBoYXNoX2NvZGUgPSBoLT50ZXN0Lmhhc2hmbiAoJmgtPnRlc3QsIGtleSk7Ci0g ICAgICAgIHNldF9oYXNoX2hhc2hfc2xvdCAoaCwgaSwgbWFrZV9maXhudW0gKGhhc2hfY29kZSkp OwotICAgICAgfQorICAgIHsKKyAgICAgIExpc3BfT2JqZWN0IGtleSA9IEhBU0hfS0VZIChoLCBp KTsKKyAgICAgIEVNQUNTX1VJTlQgaGFzaF9jb2RlID0gaC0+dGVzdC5oYXNoZm4gKCZoLT50ZXN0 LCBrZXkpOworICAgICAgc2V0X2hhc2hfaGFzaF9zbG90IChoLCBpLCBtYWtlX2ZpeG51bSAoaGFz aF9jb2RlKSk7CisgICAgfQogCiAgIC8qIFJlc2V0IHRoZSBpbmRleCBzbyB0aGF0IGFueSBzbG90 IHdlIGRvbid0IGZpbGwgYmVsb3cgaXMgbWFya2VkCiAgICAgIGludmFsaWQuICAqLwpAQCAtNDI0 NywxMyArNDI0OSw2IEBAIGhhc2hfdGFibGVfcmVoYXNoIChzdHJ1Y3QgTGlzcF9IYXNoX1RhYmxl ICpoKQogICAgICAgICBzZXRfaGFzaF9pbmRleF9zbG90IChoLCBzdGFydF9vZl9idWNrZXQsIGkp OwogICAgICAgICBlYXNzZXJ0IChIQVNIX05FWFQgKGgsIGkpICE9IGkpOyAvKiBTdG9wIGxvb3Bz LiAgKi8KICAgICAgIH0KLQotICAvKiBGaW5hbGx5LCBtYXJrIHRoZSBoYXNoIHRhYmxlIGFzIGhh dmluZyBhIHZhbGlkIGhhc2ggb3JkZXIuCi0gICAgIERvIHRoaXMgbGFzdCBzbyB0aGF0IGlmIHdl J3JlIGludGVycnVwdGVkLCB3ZSByZXRyeSBvbiBuZXh0Ci0gICAgIGFjY2Vzcy4gKi8KLSAgZWFz c2VydCAoaC0+Y291bnQgPCAwKTsKLSAgaC0+Y291bnQgPSAtaC0+Y291bnQ7Ci0gIGVhc3NlcnQg KCFoYXNoX3JlaGFzaF9uZWVkZWRfcCAoaCkpOwogfQogCiAvKiBMb29rdXAgS0VZIGluIGhhc2gg dGFibGUgSC4gIElmIEhBU0ggaXMgbm9uLW51bGwsIHJldHVybiBpbiAqSEFTSApAQCAtNDI2Niw4 ICs0MjYxLDYgQEAgaGFzaF9sb29rdXAgKHN0cnVjdCBMaXNwX0hhc2hfVGFibGUgKmgsIExpc3Bf T2JqZWN0IGtleSwgRU1BQ1NfVUlOVCAqaGFzaCkKICAgRU1BQ1NfVUlOVCBoYXNoX2NvZGU7CiAg IHB0cmRpZmZfdCBzdGFydF9vZl9idWNrZXQsIGk7CiAKLSAgaGFzaF9yZWhhc2hfaWZfbmVlZGVk IChoKTsKLQogICBoYXNoX2NvZGUgPSBoLT50ZXN0Lmhhc2hmbiAoJmgtPnRlc3QsIGtleSk7CiAg IGVhc3NlcnQgKChoYXNoX2NvZGUgJiB+SU5UTUFTSykgPT0gMCk7CiAgIGlmIChoYXNoKQpAQCAt NDI5Niw4ICs0Mjg5LDYgQEAgaGFzaF9wdXQgKHN0cnVjdCBMaXNwX0hhc2hfVGFibGUgKmgsIExp c3BfT2JqZWN0IGtleSwgTGlzcF9PYmplY3QgdmFsdWUsCiB7CiAgIHB0cmRpZmZfdCBzdGFydF9v Zl9idWNrZXQsIGk7CiAKLSAgaGFzaF9yZWhhc2hfaWZfbmVlZGVkIChoKTsKLQogICBlYXNzZXJ0 ICgoaGFzaCAmIH5JTlRNQVNLKSA9PSAwKTsKIAogICAvKiBJbmNyZW1lbnQgY291bnQgYWZ0ZXIg cmVzaXppbmcgYmVjYXVzZSByZXNpemluZyBtYXkgZmFpbC4gICovCkBAIC00MzMxLDggKzQzMjIs NiBAQCBoYXNoX3JlbW92ZV9mcm9tX3RhYmxlIChzdHJ1Y3QgTGlzcF9IYXNoX1RhYmxlICpoLCBM aXNwX09iamVjdCBrZXkpCiAgIHB0cmRpZmZfdCBzdGFydF9vZl9idWNrZXQgPSBoYXNoX2NvZGUg JSBBU0laRSAoaC0+aW5kZXgpOwogICBwdHJkaWZmX3QgcHJldiA9IC0xOwogCi0gIGhhc2hfcmVo YXNoX2lmX25lZWRlZCAoaCk7Ci0KICAgZm9yIChwdHJkaWZmX3QgaSA9IEhBU0hfSU5ERVggKGgs IHN0YXJ0X29mX2J1Y2tldCk7CiAgICAgICAgMCA8PSBpOwogICAgICAgIGkgPSBIQVNIX05FWFQg KGgsIGkpKQpkaWZmIC0tZ2l0IGEvc3JjL2xpc3AuaCBiL3NyYy9saXNwLmgKaW5kZXggMWExZDhl ZTdlNC4uN2I3N2RkOTdmNSAxMDA2NDQKLS0tIGEvc3JjL2xpc3AuaAorKysgYi9zcmMvbGlzcC5o CkBAIC0yMzcwLDIxICsyMzcwLDYgQEAgSEFTSF9UQUJMRV9TSVpFIChjb25zdCBzdHJ1Y3QgTGlz cF9IYXNoX1RhYmxlICpoKQogICByZXR1cm4gQVNJWkUgKGgtPm5leHQpOwogfQogCi12b2lkIGhh c2hfdGFibGVfcmVoYXNoIChzdHJ1Y3QgTGlzcF9IYXNoX1RhYmxlICpoKTsKLQotSU5MSU5FIGJv b2wKLWhhc2hfcmVoYXNoX25lZWRlZF9wIChjb25zdCBzdHJ1Y3QgTGlzcF9IYXNoX1RhYmxlICpo KQotewotICByZXR1cm4gaC0+Y291bnQgPCAwOwotfQotCi1JTkxJTkUgdm9pZAotaGFzaF9yZWhh c2hfaWZfbmVlZGVkIChzdHJ1Y3QgTGlzcF9IYXNoX1RhYmxlICpoKQotewotICBpZiAoaGFzaF9y ZWhhc2hfbmVlZGVkX3AgKGgpKQotICAgIGhhc2hfdGFibGVfcmVoYXNoIChoKTsKLX0KLQogLyog RGVmYXVsdCBzaXplIGZvciBoYXNoIHRhYmxlcyBpZiBub3Qgc3BlY2lmaWVkLiAgKi8KIAogZW51 bSBERUZBVUxUX0hBU0hfU0laRSB7IERFRkFVTFRfSEFTSF9TSVpFID0gNjUgfTsKZGlmZiAtLWdp dCBhL3NyYy9taW5pYnVmLmMgYi9zcmMvbWluaWJ1Zi5jCmluZGV4IGQ5MzJkYmU4ZTIuLmE3NzVk MDQzMzIgMTAwNjQ0Ci0tLSBhL3NyYy9taW5pYnVmLmMKKysrIGIvc3JjL21pbmlidWYuYwpAQCAt MTIwMyw5ICsxMjAzLDYgQEAgREVGVU4gKCJ0cnktY29tcGxldGlvbiIsIEZ0cnlfY29tcGxldGlv biwgU3RyeV9jb21wbGV0aW9uLCAyLCAzLCAwLAogICAgICAgYnVja2V0ID0gQVJFRiAoY29sbGVj dGlvbiwgaWR4KTsKICAgICB9CiAKLSAgaWYgKEhBU0hfVEFCTEVfUCAoY29sbGVjdGlvbikpCi0g ICAgaGFzaF9yZWhhc2hfaWZfbmVlZGVkIChYSEFTSF9UQUJMRSAoY29sbGVjdGlvbikpOwotCiAg IHdoaWxlICgxKQogICAgIHsKICAgICAgIC8qIEdldCB0aGUgbmV4dCBlbGVtZW50IG9mIHRoZSBh bGlzdCwgb2JhcnJheSwgb3IgaGFzaC10YWJsZS4gICovCmRpZmYgLS1naXQgYS9zcmMvcGR1bXBl ci5jIGIvc3JjL3BkdW1wZXIuYwppbmRleCBjMDBmOGEwYWY1Li41ZjA2MzVhYTRkIDEwMDY0NAot LS0gYS9zcmMvcGR1bXBlci5jCisrKyBiL3NyYy9wZHVtcGVyLmMKQEAgLTM5Miw2ICszOTIsOCBA QCBkdW1wX2ZpbmdlcnByaW50IChjb25zdCBjaGFyICpsYWJlbCwgdW5zaWduZWQgY2hhciBjb25z dCAqeGZpbmdlcnByaW50KQogICAgICBUaGUgc3RhcnQgb2YgdGhlIGNvbGQgcmVnaW9uIGlzIGFs d2F5cyBhbGlnbmVkIG9uIGEgcGFnZQogICAgICBib3VuZGFyeS4gICovCiAgIGR1bXBfb2ZmIGNv bGRfc3RhcnQ7CisKKyAgZHVtcF9vZmYgaGFzaF9saXN0OwogfTsKIAogLyogRG91YmxlLWVuZGVk IHNpbmdseSBsaW5rZWQgbGlzdC4gICovCkBAIC01NDksNiArNTUxLDggQEAgZHVtcF9maW5nZXJw cmludCAoY29uc3QgY2hhciAqbGFiZWwsIHVuc2lnbmVkIGNoYXIgY29uc3QgKnhmaW5nZXJwcmlu dCkKICAgICAgaGVhcCBvYmplY3RzLiAgKi8KICAgTGlzcF9PYmplY3QgYmlnbnVtX2RhdGE7CiAK KyAgTGlzcF9PYmplY3QgaGFzaF90YWJsZXM7CisKICAgdW5zaWduZWQgbnVtYmVyX2hvdF9yZWxv Y2F0aW9uczsKICAgdW5zaWduZWQgbnVtYmVyX2Rpc2NhcmRhYmxlX3JlbG9jYXRpb25zOwogfTsK QEAgLTI2NDcsNDIgKzI2NTEsNjUgQEAgZHVtcF9oYXNoX3RhYmxlX3N0YWJsZV9wIChjb25zdCBz dHJ1Y3QgTGlzcF9IYXNoX1RhYmxlICpoYXNoKQogCiAvKiBSZXR1cm4gYSBsaXN0IG9mIChLRVkg LiBWQUxVRSkgcGFpcnMgaW4gdGhlIGdpdmVuIGhhc2ggdGFibGUuICAqLwogc3RhdGljIExpc3Bf T2JqZWN0Ci1oYXNoX3RhYmxlX2NvbnRlbnRzIChMaXNwX09iamVjdCB0YWJsZSkKK2hhc2hfdGFi bGVfY29udGVudHMgKHN0cnVjdCBMaXNwX0hhc2hfVGFibGUgKmgpCiB7CiAgIExpc3BfT2JqZWN0 IGNvbnRlbnRzID0gUW5pbDsKLSAgc3RydWN0IExpc3BfSGFzaF9UYWJsZSAqaCA9IFhIQVNIX1RB QkxFICh0YWJsZSk7Ci0gIGZvciAocHRyZGlmZl90IGkgPSAwOyBpIDwgSEFTSF9UQUJMRV9TSVpF IChoKTsgKytpKQorICAvKiBNYWtlIHN1cmUga2V5X2FuZF92YWx1ZSBlbmRzIHVwIGluIHRoZSBz YW1lIG9yZGVyLCBjaGFyc2V0LmMKKyAgICAgcmVsaWVzIG9uIGl0IGJ5IGV4cGVjdGluZyBoYXNo IHRhYmxlIGluZGljZXMgdG8gc3RheSBjb25zdGFudAorICAgICBhY3Jvc3MgdGhlIGR1bXAuICAq LworICBmb3IgKHB0cmRpZmZfdCBpID0gSEFTSF9UQUJMRV9TSVpFIChoKSAtIDE7IGkgPj0gMDsg LS1pKQogICAgIGlmICghTklMUCAoSEFTSF9IQVNIIChoLCBpKSkpCi0gICAgICBkdW1wX3B1c2gg KCZjb250ZW50cywgRmNvbnMgKEhBU0hfS0VZIChoLCBpKSwgSEFTSF9WQUxVRSAoaCwgaSkpKTsK LSAgcmV0dXJuIEZucmV2ZXJzZSAoY29udGVudHMpOworICAgICAgeworCWR1bXBfcHVzaCAoJmNv bnRlbnRzLCBIQVNIX1ZBTFVFIChoLCBpKSk7CisJZHVtcF9wdXNoICgmY29udGVudHMsIEhBU0hf S0VZIChoLCBpKSk7CisgICAgICB9CisgIHJldHVybiBDQUxMTiAoRmFwcGx5LCBRdmVjdG9yLCBj b250ZW50cyk7Cit9CisKK3N0YXRpYyBkdW1wX29mZgorZHVtcF9oYXNoX3RhYmxlX2xpc3QgKHN0 cnVjdCBkdW1wX2NvbnRleHQgKmN0eCkKK3sKKyAgaWYgKENPTlNQIChjdHgtPmhhc2hfdGFibGVz KSkKKyAgICByZXR1cm4gZHVtcF9vYmplY3QgKGN0eCwgQ0FMTE4gKEZhcHBseSwgUXZlY3Rvciwg Y3R4LT5oYXNoX3RhYmxlcykpOworICBlbHNlCisgICAgcmV0dXJuIDA7Cit9CisKK3N0YXRpYyB2 b2lkCitoYXNoX3RhYmxlX2ZyZWV6ZSAoc3RydWN0IExpc3BfSGFzaF9UYWJsZSAqaCkKK3sKKyAg aC0+a2V5X2FuZF92YWx1ZSA9IGhhc2hfdGFibGVfY29udGVudHMgKGgpOworICBwdHJkaWZmX3Qg bmtleXMgPSBYRklYTkFUIChGbGVuZ3RoIChoLT5rZXlfYW5kX3ZhbHVlKSkgLyAyOworICBoLT5j b3VudCA9IG5rZXlzOworICBpZiAobmtleXMgPT0gMCkKKyAgICBua2V5cyA9IDE7CisgIGgtPmlu ZGV4ID0gaC0+bmV4dCA9IGgtPmhhc2ggPSBtYWtlX2ZpeG51bSAobmtleXMpOwogfQogCi0vKiBD b3B5IHRoZSBnaXZlbiBoYXNoIHRhYmxlLCByZWhhc2ggaXQsIGFuZCBtYWtlIHN1cmUgdGhhdCB3 ZSBjYW4KLSAgIGxvb2sgdXAgYWxsIHRoZSB2YWx1ZXMgaW4gdGhlIG9yaWdpbmFsLiAgKi8KKy8q IERlZmluZWQgaW4gZm5zLmMuICAqLworZXh0ZXJuIHZvaWQgaGFzaF90YWJsZV9yZWhhc2ggKHN0 cnVjdCBMaXNwX0hhc2hfVGFibGUgKmgpOworCiBzdGF0aWMgdm9pZAotY2hlY2tfaGFzaF90YWJs ZV9yZWhhc2ggKExpc3BfT2JqZWN0IHRhYmxlX29yaWcpCi17Ci0gIGhhc2hfcmVoYXNoX2lmX25l ZWRlZCAoWEhBU0hfVEFCTEUgKHRhYmxlX29yaWcpKTsKLSAgTGlzcF9PYmplY3QgdGFibGVfcmVo YXNoZWQgPSBGY29weV9oYXNoX3RhYmxlICh0YWJsZV9vcmlnKTsKLSAgZWFzc2VydCAoWEhBU0hf VEFCTEUgKHRhYmxlX3JlaGFzaGVkKS0+Y291bnQgPj0gMCk7Ci0gIFhIQVNIX1RBQkxFICh0YWJs ZV9yZWhhc2hlZCktPmNvdW50ICo9IC0xOwotICBlYXNzZXJ0IChYSEFTSF9UQUJMRSAodGFibGVf cmVoYXNoZWQpLT5jb3VudCA8PSAwKTsKLSAgaGFzaF9yZWhhc2hfaWZfbmVlZGVkIChYSEFTSF9U QUJMRSAodGFibGVfcmVoYXNoZWQpKTsKLSAgZWFzc2VydCAoWEhBU0hfVEFCTEUgKHRhYmxlX3Jl aGFzaGVkKS0+Y291bnQgPj0gMCk7Ci0gIExpc3BfT2JqZWN0IGV4cGVjdGVkX2NvbnRlbnRzID0g aGFzaF90YWJsZV9jb250ZW50cyAodGFibGVfb3JpZyk7Ci0gIHdoaWxlICghTklMUCAoZXhwZWN0 ZWRfY29udGVudHMpKQoraGFzaF90YWJsZV90aGF3IChzdHJ1Y3QgTGlzcF9IYXNoX1RhYmxlICpo KQoreworICBMaXNwX09iamVjdCBjb3VudCA9IGgtPmluZGV4OworICBoLT5pbmRleCA9IEZtYWtl X3ZlY3RvciAoaC0+aW5kZXgsIG1ha2VfZml4bnVtICgtMSkpOworICBoLT5oYXNoID0gRm1ha2Vf dmVjdG9yIChoLT5oYXNoLCBRbmlsKTsKKyAgaC0+bmV4dCA9IEZtYWtlX3ZlY3RvciAoaC0+bmV4 dCwgbWFrZV9maXhudW0gKC0xKSk7CisgIExpc3BfT2JqZWN0IGtleV9hbmRfdmFsdWUgPSBoLT5r ZXlfYW5kX3ZhbHVlOworICBoLT5uZXh0X2ZyZWUgPSAtMTsKKyAgaWYgKFhGSVhOQVQgKGNvdW50 KSA8PSAxKQogICAgIHsKLSAgICAgIExpc3BfT2JqZWN0IGtleV92YWx1ZV9wYWlyID0gZHVtcF9w b3AgKCZleHBlY3RlZF9jb250ZW50cyk7Ci0gICAgICBMaXNwX09iamVjdCBrZXkgPSBYQ0FSIChr ZXlfdmFsdWVfcGFpcik7Ci0gICAgICBMaXNwX09iamVjdCBleHBlY3RlZF92YWx1ZSA9IFhDRFIg KGtleV92YWx1ZV9wYWlyKTsKLSAgICAgIExpc3BfT2JqZWN0IGFyYml0cmFyeSA9IFFkdW1wX2Vt YWNzX3BvcnRhYmxlX19zb3J0X3ByZWRpY2F0ZV9jb3BpZWQ7Ci0gICAgICBMaXNwX09iamVjdCBm b3VuZF92YWx1ZSA9IEZnZXRoYXNoIChrZXksIHRhYmxlX3JlaGFzaGVkLCBhcmJpdHJhcnkpOwot ICAgICAgZWFzc2VydCAoRVEgKGV4cGVjdGVkX3ZhbHVlLCBmb3VuZF92YWx1ZSkpOwotICAgICAg RnJlbWhhc2ggKGtleSwgdGFibGVfcmVoYXNoZWQpOworICAgICAgaC0+a2V5X2FuZF92YWx1ZSA9 IEZtYWtlX3ZlY3RvciAobWFrZV9maXhudW0gKDIgKiBYRklYTkFUIChjb3VudCkpLCBRbmlsKTsK KyAgICAgIHB0cmRpZmZfdCBpID0gMDsKKyAgICAgIHdoaWxlIChpIDwgQVNJWkUgKGtleV9hbmRf dmFsdWUpKQorCXsKKwkgIEFTRVQgKGgtPmtleV9hbmRfdmFsdWUsIGksIEFSRUYgKGtleV9hbmRf dmFsdWUsIGkpKTsKKwkgIGkrKzsKKwl9CiAgICAgfQogCi0gIGVhc3NlcnQgKEVRIChGaGFzaF90 YWJsZV9jb3VudCAodGFibGVfcmVoYXNoZWQpLAotICAgICAgICAgICAgICAgbWFrZV9maXhudW0g KDApKSk7CisgIGhhc2hfdGFibGVfcmVoYXNoIChoKTsKIH0KIAogc3RhdGljIGR1bXBfb2ZmCkBA IC0yNzA3LDggKzI3MzQsNiBAQCBkdW1wX2hhc2hfdGFibGUgKHN0cnVjdCBkdW1wX2NvbnRleHQg KmN0eCwKICAgICAgICAgewogCSAgZWFzc2VydCAob2Zmc2V0ID09IERVTVBfT0JKRUNUX09OX05P Uk1BTF9RVUVVRQogCQkgICB8fCBvZmZzZXQgPT0gRFVNUF9PQkpFQ1RfTk9UX1NFRU4pOwotICAg ICAgICAgIC8qIFdlIHN0aWxsIHdhbnQgdG8gZHVtcCB0aGUgYWN0dWFsIGtleXMgYW5kIHZhbHVl cyBub3cuICAqLwotICAgICAgICAgIGR1bXBfZW5xdWV1ZV9vYmplY3QgKGN0eCwgaGFzaF9pbi0+ a2V5X2FuZF92YWx1ZSwgV0VJR0hUX05PTkUpOwogICAgICAgICAgIC8qIFdlJ2xsIGdldCB0byB0 aGUgcmVzdCBsYXRlci4gICovCiAgICAgICAgICAgb2Zmc2V0ID0gRFVNUF9PQkpFQ1RfT05fSEFT SF9UQUJMRV9RVUVVRTsKICAgICAgICAgICBkdW1wX3JlbWVtYmVyX29iamVjdCAoY3R4LCBvYmpl Y3QsIG9mZnNldCk7CkBAIC0yNzE3LDIyICsyNzQyLDExIEBAIGR1bXBfaGFzaF90YWJsZSAoc3Ry dWN0IGR1bXBfY29udGV4dCAqY3R4LAogICAgICAgcmV0dXJuIG9mZnNldDsKICAgICB9CiAKLSAg aWYgKFBEVU1QRVJfQ0hFQ0tfUkVIQVNISU5HKQotICAgIGNoZWNrX2hhc2hfdGFibGVfcmVoYXNo IChtYWtlX2xpc3BfcHRyICgodm9pZCAqKSBoYXNoX2luLCBMaXNwX1ZlY3Rvcmxpa2UpKTsKLQog ICBzdHJ1Y3QgTGlzcF9IYXNoX1RhYmxlIGhhc2hfbXVuZ2VkID0gKmhhc2hfaW47CiAgIHN0cnVj dCBMaXNwX0hhc2hfVGFibGUgKmhhc2ggPSAmaGFzaF9tdW5nZWQ7CiAKLSAgLyogUmVtZW1iZXIg dG8gcmVoYXNoIHRoaXMgaGFzaCB0YWJsZSBvbiBmaXJzdCBhY2Nlc3MuICBBZnRlciBhCi0gICAg IGR1bXAgcmVsb2FkLCB0aGUgaGFzaCB0YWJsZSB2YWx1ZXMgd2lsbCBoYXZlIGNoYW5nZWQsIHNv IHdlJ2xsCi0gICAgIG5lZWQgdG8gcmVidWlsZCB0aGUgaW5kZXguCi0KLSAgICAgVE9ETzogZm9y IEVRIGFuZCBFUUwgaGFzaCB0YWJsZXMsIGl0IHNob3VsZCBiZSBwb3NzaWJsZSB0byByZWhhc2gK LSAgICAgaGVyZSB1c2luZyB0aGUgcHJlZmVycmVkIGxvYWQgYWRkcmVzcyBvZiB0aGUgZHVtcCwg ZWxpbWluYXRpbmcKLSAgICAgdGhlIG5lZWQgdG8gcmVoYXNoLW9uLWFjY2VzcyBpZiB3ZSBjYW4g bG9hZCB0aGUgZHVtcCB3aGVyZSB3ZQotICAgICB3YW50LiAgKi8KLSAgaWYgKGhhc2gtPmNvdW50 ID4gMCAmJiAhaXNfc3RhYmxlKQotICAgIGhhc2gtPmNvdW50ID0gLWhhc2gtPmNvdW50OworICBo YXNoX3RhYmxlX2ZyZWV6ZSAoaGFzaCk7CisgIGR1bXBfcHVzaCAoJmN0eC0+aGFzaF90YWJsZXMs IG9iamVjdCk7CiAKICAgU1RBUlRfRFVNUF9QVkVDIChjdHgsICZoYXNoLT5oZWFkZXIsIHN0cnVj dCBMaXNwX0hhc2hfVGFibGUsIG91dCk7CiAgIGR1bXBfcHNldWRvdmVjdG9yX2xpc3BfZmllbGRz IChjdHgsICZvdXQtPmhlYWRlciwgJmhhc2gtPmhlYWRlcik7CkBAIC00MTQxLDYgKzQxNTUsMTkg QEAgREVGVU4gKCJkdW1wLWVtYWNzLXBvcnRhYmxlIiwKIAkgfHwgIU5JTFAgKGN0eC0+ZGVmZXJy ZWRfaGFzaF90YWJsZXMpCiAJIHx8ICFOSUxQIChjdHgtPmRlZmVycmVkX3N5bWJvbHMpKTsKIAor ICBjdHgtPmhlYWRlci5oYXNoX2xpc3QgPSBjdHgtPm9mZnNldDsKKyAgZHVtcF9oYXNoX3RhYmxl X2xpc3QgKGN0eCk7CisKKyAgZG8KKyAgICB7CisgICAgICBkdW1wX2RyYWluX2RlZmVycmVkX2hh c2hfdGFibGVzIChjdHgpOworICAgICAgZHVtcF9kcmFpbl9kZWZlcnJlZF9zeW1ib2xzIChjdHgp OworICAgICAgZHVtcF9kcmFpbl9ub3JtYWxfcXVldWUgKGN0eCk7CisgICAgfQorICB3aGlsZSAo IWR1bXBfcXVldWVfZW1wdHlfcCAoJmN0eC0+ZHVtcF9xdWV1ZSkKKwkgfHwgIU5JTFAgKGN0eC0+ ZGVmZXJyZWRfaGFzaF90YWJsZXMpCisJIHx8ICFOSUxQIChjdHgtPmRlZmVycmVkX3N5bWJvbHMp KTsKKwogICBkdW1wX3NvcnRfY29waWVkX29iamVjdHMgKGN0eCk7CiAKICAgLyogV2hpbGUgd2Ug Y29weSBidWlsdC1pbiBzeW1ib2xzIGludG8gdGhlIEVtYWNzIGltYWdlLCB0aGVzZQpAQCAtNTQy OSw2ICs1NDU2LDEzIEBAIHBkdW1wZXJfbG9hZCAoY29uc3QgY2hhciAqZHVtcF9maWxlbmFtZSkK ICAgZm9yIChpbnQgaSA9IDA7IGkgPCBBUlJBWUVMVFMgKHNlY3Rpb25zKTsgKytpKQogICAgIGR1 bXBfbW1hcF9yZXNldCAoJnNlY3Rpb25zW2ldKTsKIAorICBpZiAoaGVhZGVyLT5oYXNoX2xpc3Qp CisgICAgeworICAgICAgc3RydWN0IExpc3BfVmVjdG9yICpoYXNoX3RhYmxlcyA9CisJKChzdHJ1 Y3QgTGlzcF9WZWN0b3IgKikoZHVtcF9iYXNlICsgaGVhZGVyLT5oYXNoX2xpc3QpKTsKKyAgICAg IFhTRVRWRUNUT1IgKFZwZHVtcGVyX2hhc2hfdGFibGVzLCBoYXNoX3RhYmxlcyk7CisgICAgfQor CiAgIC8qIFJ1biB0aGUgZnVuY3Rpb25zIEVtYWNzIHJlZ2lzdGVyZWQgZm9yIGRvaW5nIHBvc3Qt ZHVtcC1sb2FkCiAgICAgIGluaXRpYWxpemF0aW9uLiAgKi8KICAgZm9yIChpbnQgaSA9IDA7IGkg PCBucl9kdW1wX2hvb2tzOyArK2kpCkBAIC01NTAwLDEwICs1NTM0LDQxIEBAIERFRlVOICgicGR1 bXBlci1zdGF0cyIsIEZwZHVtcGVyX3N0YXRzLCBTcGR1bXBlcl9zdGF0cywgMCwgMCwgMCwKIAog DAogCitzdGF0aWMgdm9pZCB0aGF3X2hhc2hfdGFibGVzICh2b2lkKQoreworICBjb25zdCBzdHJ1 Y3QgdGltZXNwZWMgc3RhcnRfdGltZSA9IGN1cnJlbnRfdGltZXNwZWMgKCk7CisgIExpc3BfT2Jq ZWN0IGhhc2hfdGFibGVzID0gVnBkdW1wZXJfaGFzaF90YWJsZXM7CisgIHB0cmRpZmZfdCB0b3Rh bF9zaXplID0gMDsKKyAgcHRyZGlmZl90IHRvdGFsX2NvdW50ID0gMDsKKyAgcHRyZGlmZl90IGkg PSAwOworICBpZiAoVkVDVE9SUCAoaGFzaF90YWJsZXMpKQorICAgIHdoaWxlIChpIDwgQVNJWkUg KGhhc2hfdGFibGVzKSkKKyAgICAgIHsKKwloYXNoX3RhYmxlX3RoYXcgKFhIQVNIX1RBQkxFIChB UkVGIChoYXNoX3RhYmxlcywgaSkpKTsKKwl0b3RhbF9zaXplICs9IFhGSVhOQVQgKEZsZW5ndGgg KFhIQVNIX1RBQkxFIChBUkVGIChoYXNoX3RhYmxlcywgaSkpLT5rZXlfYW5kX3ZhbHVlKSk7CisJ dG90YWxfY291bnQgKys7CisJaSsrOworICAgICAgfQorCisgIGNvbnN0IHN0cnVjdCB0aW1lc3Bl YyBlbmRfdGltZSA9IGN1cnJlbnRfdGltZXNwZWMgKCk7CisgIGZwcmludGYgKHN0ZGVyciwgIiVs ZCBoYXNoIHRhYmxlcywgJWxkIGtleS92YWx1ZXMgJWYgc1xuIiwKKwkgICB0b3RhbF9jb3VudCwg dG90YWxfc2l6ZSwgdGltZXNwZWN0b2QodGltZXNwZWNfc3ViIChlbmRfdGltZSwgc3RhcnRfdGlt ZSkpKTsKK30KKwordm9pZAoraW5pdF9wZHVtcGVyX29uY2UgKHZvaWQpCit7CisgIFZwZHVtcGVy X2hhc2hfdGFibGVzID0gUW5pbDsKKyAgcGR1bXBlcl9kb19ub3dfYW5kX2FmdGVyX2xvYWQgKHRo YXdfaGFzaF90YWJsZXMpOworfQorCiB2b2lkCiBzeW1zX29mX3BkdW1wZXIgKHZvaWQpCiB7CiAj aWZkZWYgSEFWRV9QRFVNUEVSCisgIERFRlZBUl9MSVNQICgicGR1bXBlci1oYXNoLXRhYmxlcyIs IFZwZHVtcGVyX2hhc2hfdGFibGVzLAorCSAgICAgICBkb2M6IC8qIEEgbGlzdCBvZiBoYXNoIHRh YmxlcyB0aGF0IG5lZWQgdG8gYmUgdGhhd2VkIGFmdGVyIGxvYWRpbmcgdGhlIHBkdW1wLiAgKi8p OworICBWcGR1bXBlcl9oYXNoX3RhYmxlcyA9IEZtYWtlX3ZlY3RvciAobWFrZV9maXhudW0gKDAp LCBRbmlsKTsKICAgZGVmc3ViciAoJlNkdW1wX2VtYWNzX3BvcnRhYmxlKTsKICAgZGVmc3ViciAo JlNkdW1wX2VtYWNzX3BvcnRhYmxlX19zb3J0X3ByZWRpY2F0ZSk7CiAgIGRlZnN1YnIgKCZTZHVt cF9lbWFjc19wb3J0YWJsZV9fc29ydF9wcmVkaWNhdGVfY29waWVkKTsKZGlmZiAtLWdpdCBhL3Ny Yy9wZHVtcGVyLmggYi9zcmMvcGR1bXBlci5oCmluZGV4IGFiMmY0MjZjMWUuLmNmZWEwNmQzM2Qg MTAwNjQ0Ci0tLSBhL3NyYy9wZHVtcGVyLmgKKysrIGIvc3JjL3BkdW1wZXIuaApAQCAtMjQ4LDYg KzI0OCw3IEBAIHBkdW1wZXJfY2xlYXJfbWFya3MgKHZvaWQpCiAgICBmaWxlIHdhcyBsb2FkZWQu ICAqLwogZXh0ZXJuIHZvaWQgcGR1bXBlcl9yZWNvcmRfd2QgKGNvbnN0IGNoYXIgKik7CiAKK3Zv aWQgaW5pdF9wZHVtcGVyX29uY2UgKHZvaWQpOwogdm9pZCBzeW1zX29mX3BkdW1wZXIgKHZvaWQp OwogCiBJTkxJTkVfSEVBREVSX0VORAo= --000000000000785ab6058d049693-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 06 11:32:43 2019 Received: (at 36447) by debbugs.gnu.org; 6 Jul 2019 15:32:44 +0000 Received: from localhost ([127.0.0.1]:55771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjmg7-0008Ix-N8 for submit@debbugs.gnu.org; Sat, 06 Jul 2019 11:32:43 -0400 Received: from mout.web.de ([212.227.15.3]:50149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjmg6-0008Ik-3O for 36447@debbugs.gnu.org; Sat, 06 Jul 2019 11:32:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1562427149; bh=yBbM0xWBCw1JoTBFWNU4VVwatJdTxXJC+2G5Z4/uiDo=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=b7oPxyHky7SE90YX1tEw8I8PcuyCETwShtwgeofGF4zRu5sd630h2i4PV3JjlVtpQ p2nf8+orTdpv/E6Lwc9uLR0yJhPTlyWtRxF8uUvyI+HyaNo61FNDqicwlm5cXUt5fs /cyZ4j9YT3nX1S/sel4UR/LiTElHVDNX2vhwUVgo= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([94.216.191.242]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Lu1Be-1iTK3e3ZMU-011SiS; Sat, 06 Jul 2019 17:32:28 +0200 From: Michael Heerdegen To: Pip Cet Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> Date: Sat, 06 Jul 2019 17:32:26 +0200 In-Reply-To: (Pip Cet's message of "Fri, 5 Jul 2019 21:52:41 +0000") Message-ID: <8736jjgovp.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:/XwNQKJpZ2MkV+t+NO6UZVPZpR/i7YSc3PeSn9A8T3gJ07Z2Ala iuP+SU9r1FO1nFwgf9Mo/FGegHfIeB51KgHh9Tw8/McSUXeelPLdbcc+P1Ez4OgeqHI1QVZ QFtXkhfAnCW4rd6bBNuwTQ08Xg3FoOPTDd3UavoqKrN57wsWfVc5K1DzWISrntCPc+uIR0h oDFEZSIuU4ExAQMS/zFRA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:typGPwBp3+k=:Ekb3JUNXUdS2u/mAT+9fS8 uDWmS95HaA+MucaGQsmBfHbpLr1gMY3tteR3YFHX/pdLLVU9R2Cm7cOSkNOBSbE/wEsdN2fAE 3pkFbb/9y6zBUV3/lzUz0/ppvmOUnwwu8UMCKam+kZ63S7Nw1VH3brIOUSlB4FrKB9doOlQkT 87EyDBstRP0i08ON9N1JisahO5tgX/biHEeUmQkhyOeh3NlyEV7GPvA1jqx5khXcF3jOPS+gw fqe3DQG8yGCDDWcB+lGWUjS/jwlJqZPrq8pAtmrOoKszWccASin1RpFaKg1hEQ08ei2PKzfQD gOHmjnqnxmOfXcsxlUzsjygOgfJCx34FPLuvOfdXH0xeHdCyg4Fyn9jbXaKFIHEc+PlU4NEpn d5/D107uIJzLTjuNSGqITxB27VHXNM0z3Xn4mGcjEnSNOhdu9iVJ7emwY0a04ihlxf7hgSu1u zmKp3/Q1T9tR0mFUgBU4Mb9STZJbNGtoqlkUggHcSAAkyMQ28X6XS9VXEw6ZGQk3Xcw4oeWdF waXLS3A7MvYajxB7roNMWWGNWBzLK+KHMvPnYtrop+TEDVNYFfwxEQR/NI1AKdpQhCPPYIdr9 0JtQCc0VIbegu3vZWAkvL1OnCp4ivdoUWDGUqbXhXbVh22++kGUmEUPI1GqqaB0vmmYpv1x4d GmkXf66PZvou7ywHuKsTT0vihR08TzMOQuk8B4VEPpGCkJ2DNV2zm73YZsYDvWbFu9iQxYwaN YBshsnKDQQoHhWZi8Nl18y+BpDc+iQcSvqugAtu+MSkqjCPSLrsxsyXaLRHXaESFWtZT0mHey G+Z1KLUgiz8LrmzLyhPd8lkDND3uVuxiTvR+7gEaXuU4QoBkFfwqrqeAAvMxgUq+4U+kLRGcA 2+psI5WArKj3T8a8GCYcPQfPAGY2HZBCJATBSQBV1IZ03PxFz442tjZD1L1Lj9YXR6i4iRW1r BGIAj6IeZI47GAz16i9+KoAK+jpwUTz8aAuDxGP8B2/y3Uowqb9d0XcVVGzWOlOxk+kScM/el U5cckYcWlYCvNrx9XWDPzQQ1nI7cjUA5WyOJhLWiG7gQ0SqP9SR8ZjvbMk/uScoj3OYUrEzsJ ZV5gNH+7v7cTjG2XVpWdjhpEkaxFFlWwbXG X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: 36447@debbugs.gnu.org, Stefan Monnier , npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pip Cet writes: > From 83f915b32faf32e98ccd806179e379a13b76618d Mon Sep 17 00:00:00 2001 > From: Pip Cet > Date: Fri, 5 Jul 2019 21:50:44 +0000 > Subject: [PATCH] rehash hash tables eagerly after loading the pdumper dump. Pip, since you can reproduce yourself now, I'll just try this patch in the meantime. Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 08 13:30:35 2019 Received: (at 36447) by debbugs.gnu.org; 8 Jul 2019 17:30:35 +0000 Received: from localhost ([127.0.0.1]:59426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkXTH-0004ni-FL for submit@debbugs.gnu.org; Mon, 08 Jul 2019 13:30:35 -0400 Received: from quimby.gnus.org ([80.91.231.51]:59116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkXTE-0004nX-1A for 36447@debbugs.gnu.org; Mon, 08 Jul 2019 13:30:34 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkXT8-0003iV-LK; Mon, 08 Jul 2019 19:30:29 +0200 From: Lars Ingebrigtsen To: Michael Heerdegen Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> <8736jjgovp.fsf@web.de> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAHlBMVEUAAAMeGi0AAAQGBhAD AwlaRlGUgGzSwZsCAgcBAQUQrQAvAAACZUlEQVQ4jWWTP2/bMBDFCbRDvVVIlXQMOsWjQQ3JGIgF qDEoKHcNUpMfwKi4NjAHcjNcDbxv23eilNjoATaM+/G9+0NatLKEUl1OURNlOuIri0e/25lnc2OG +mdKNJKm4+qU1uLVO+8G75z3e6JIMUXx8UR34mCts8Pgttb9opDhdBLdmtYi/Cg1mqbWEDxEus1H /BDBeoTzv73bp5hHjU+irhOvA3LeD35w+xxpzDqgh7ssDlV1VVWbK3x9TTFErTR1Ge2+DoO19tre uGGvY9S6bTAMih/s4G+4ZT/sIxSqbUK871C8f+6/Q3Hd716iUq1sZaO4q4Ozm6cN6mz7l6DbllfU yITizm/RFM++nxTTUIEVautmEDi/qSopWyVixLklSh7dN1qMGCdhsKhxAC7VFFKL3GW+Ayw1xmbO m+qqERBQSiCjhhMb1QZACkypI2AM7ARgEE+VFOyErWLkZhLUDCBhBc5npefKxvR2BwmDU0y5jLxh QW/tDHJKpdVSAcuGl4jsFeOFAF6VyCiuwjJbzecZPMFqTbQsqTLngMawgHoGKCKI5wizYALes4QV 9BDUAnqLJzlMIP/NOs5rLYIZ8CBsVZVeHb8/FBF4Yt2o3ofzCzgRdeMiMCXPXtNKomJg2Okc5HEC 9bvTokgUCujPwYm6FNv/QGmXDq0sV+QuQc4FmEuAZaHIdBcX4LRaf6NZstSYJr8ViE9BlluaBTw5 548it+X2ynm+jzlWh6qu7VsYuQBB4XG+P4OlN+oN3FNoN9P7NP09HseS//ACO7npGXwh/EWF/FNq fMZnFepK1hgL4B9gp5HpwLq33wAAAABJRU5ErkJggg== Date: Mon, 08 Jul 2019 19:30:26 +0200 In-Reply-To: <8736jjgovp.fsf@web.de> (Michael Heerdegen's message of "Sat, 06 Jul 2019 17:32:26 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: I'm still seeing this... but not after every recompilation. If I say "make bootstrap", then Emacs usually works. If I then recompile parts, I sometimes get a non-working Emacs. For instance, at the moment if I try to eval the following: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: Stefan Monnier , npostavs@gmail.com, Pip Cet , 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I'm still seeing this... but not after every recompilation. If I say "make bootstrap", then Emacs usually works. If I then recompile parts, I sometimes get a non-working Emacs. For instance, at the moment if I try to eval the following: (defgroup compilation nil "Run compiler as inferior of Emacs, parse error messages." :group 'tools :group 'processes) I get: Debugger entered--Lisp error: (error "Unknown keyword :group") signal(error ("Unknown keyword :group")) error("Unknown keyword %s" :group) custom-handle-keyword(compilation :group tools custom-group) custom-declare-group(compilation nil "Run compiler as inferior of Emacs, parse error mes..." :group tools :group processes) eval-region(1213 1336 t #f(compiled-function (ignore) #)) ; Reading at buffer position 1247 elisp--eval-defun() eval-defun(nil) funcall-interactively(eval-defun nil) call-interactively(eval-defun nil nil) command-execute(eval-defun) Perhaps the original change should be reverted until you've figured out how to fix this completely? It's very annoying. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 08 13:59:27 2019 Received: (at 36447) by debbugs.gnu.org; 8 Jul 2019 17:59:27 +0000 Received: from localhost ([127.0.0.1]:59510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkXvD-0005bj-1W for submit@debbugs.gnu.org; Mon, 08 Jul 2019 13:59:27 -0400 Received: from mail-ot1-f48.google.com ([209.85.210.48]:36475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkXvA-0005bU-Vu for 36447@debbugs.gnu.org; Mon, 08 Jul 2019 13:59:26 -0400 Received: by mail-ot1-f48.google.com with SMTP id r6so17122964oti.3 for <36447@debbugs.gnu.org>; Mon, 08 Jul 2019 10:59:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3/t7w3P0JQs7OFWDVa9S9j65UVggopdX07wrKDSyHWc=; b=spQY+isHw74+0FsC2y95iTGC2TEi8TuFPvc7tOjovNhFn+Fvq0Rek1Z0VRf4124S4S bG0FFxwtr6MOPReOxrb4ZRFijdNGaSmBU9mXLVoJFMe+/LQjDkp02QheEYqpgNYHEm8l dnae3BPPmkuO6RO7OknlFGPzT0xkvI4vF9xJmdKqFRGSFxFnvAlPJe/QbSfgwgBdJ+Ph LqfB9YDMWm04AE7d0e5yLSUEzpy1amPB2hds8Hctsp9TgEJ7uqP4LVeWXRZPhM+bvNkB C87J2yfat+eGuoDF73yy4dG1tcl0Wsv55PG059fW8NmE7ybUlYM9Hd9/dJEvIg9Yhr1u nypA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3/t7w3P0JQs7OFWDVa9S9j65UVggopdX07wrKDSyHWc=; b=bArocEo8l+tgagGc9FtSFCtcyDZ2Y+Q6+QufeuQYX/Cperg3Fm6SM6omWAh7aBRZyY CFYL7+FxNkUYGiBtBHaVhQejd21i+1dPv/SQMcJt4/FH3JpEo7OjY+X8hk1W9+uus6kJ w+lju0vLdC/YIybHsPIyH8m1jhsmuHIDxMt4GVfZSvRvB2BUPtEdMklGe+5BJiW7+eTG f1PdkjGAJ5RGpbXdrV0F6y0BTXxWxqShPOZtwjrsUXoKbGp4ZmlhwqW9R6OYH2J1gIou NJabvIw56VGEYA5arMkeLcr2N3X7hKmnu9B/dTme4kdplgFpPecCPCUl/FL/7H62oR3T C1mQ== X-Gm-Message-State: APjAAAV4DHL46PfsT72c8lh5z/PWSq1+3NLbZc1rt2WTnZ1/85Q19OWZ es8PZaELFh5LN8IhKvOMlIUAS69kHBgrnnHLGPg= X-Google-Smtp-Source: APXvYqzkig2/PK46v8wtV//620DVIEJ0DziI4OfOBHVqfiEVdz+vxVwktP4B6pFb26MSG88tDQyEOH30WdPfj39e+fQ= X-Received: by 2002:a9d:664c:: with SMTP id q12mr14404959otm.175.1562608759374; Mon, 08 Jul 2019 10:59:19 -0700 (PDT) MIME-Version: 1.0 References: <875zon7x0a.fsf@web.de> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> <8736jjgovp.fsf@web.de> In-Reply-To: From: Pip Cet Date: Mon, 8 Jul 2019 17:58:42 +0000 Message-ID: Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors To: Lars Ingebrigtsen Content-Type: multipart/mixed; boundary="00000000000006b779058d2f346c" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Mon, Jul 8, 2019 at 5:30 PM Lars Ingebrigtsen wrote: > I'm still seeing this... but not after every recompilation. If I say > "make bootstrap", then Emacs usually works. If I then recompile parts [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnus.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pipcet[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.210.48 listed in list.dnswl.org] 1.3 PDS_NO_HELO_DNS High profile HELO but no A record X-Debbugs-Envelope-To: 36447 Cc: Michael Heerdegen , npostavs@gmail.com, Stefan Monnier , 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) --00000000000006b779058d2f346c Content-Type: text/plain; charset="UTF-8" On Mon, Jul 8, 2019 at 5:30 PM Lars Ingebrigtsen wrote: > I'm still seeing this... but not after every recompilation. If I say > "make bootstrap", then Emacs usually works. If I then recompile parts, > I sometimes get a non-working Emacs. Are you on master? As far as I know, no fix has been applied there yet. Also, if I understand correctly, the bug depends on ASLR both at the time of dump and in the final Emacs image. Also also, can you please stash copies of the emacs binaries and emacs.pdmp that fail to work? I did something very silly and overwrote my compiler with a very slightly different version (after carefully backing up /usr/local/bin/gcc, too. Too bad that's just the driver program), and now can no longer reproduce the issue easily. > Perhaps the original change should be reverted until you've figured out > how to fix this completely? It's very annoying. It is. I think it's worth the risk to push my original fix (reattached to this message) now, but I don't have commit privileges so it's not my decision to make. Alternatively, we could simply disable purify-flag hash consing for now and everything should work, I think. But I don't think there's a clear candidate for "the original change". The bug's been with us for a while, possibly since pdumper was introduced, but it got significantly worse when the recent byte compilation changes were committed; however, those changes are actually okay. Is there anything I can do to help get this bug fixed on master? Thanks! --00000000000006b779058d2f346c Content-Type: text/x-patch; charset="US-ASCII"; name="0002-Don-t-alter-shared-structure-in-dumped-purecopied-ha.patch" Content-Disposition: attachment; filename="0002-Don-t-alter-shared-structure-in-dumped-purecopied-ha.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxuovnql0 RnJvbSA3MDQxOWY2MzBmNjA5MTljODY0NWExMGFlZWY4ZDI5OWY1MDk4ZmY1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBXZWQs IDMgSnVsIDIwMTkgMTE6NDg6MjIgKzAwMDAKU3ViamVjdDogW1BBVENIIDIvMl0gRG9uJ3QgYWx0 ZXIgc2hhcmVkIHN0cnVjdHVyZSBpbiBkdW1wZWQgcHVyZWNvcGllZCBoYXNoCiB0YWJsZXMuCgoq IHNyYy9mbnMuYyAoaGFzaF90YWJsZV9yZWhhc2gpOiBNYWtlIHN1cmUgd2UncmUgb3BlcmF0aW5n IG9uCmZyZXNoIGNvcGllcyBvZiAtPm5leHQsIC0+aW5kZXgsIC0+aGFzaC4KLS0tCiBzcmMvZm5z LmMgfCA2ICsrKysrKwogMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdp dCBhL3NyYy9mbnMuYyBiL3NyYy9mbnMuYwppbmRleCAyZmMwMDBhN2Y0Li40NGQyZGU1MjNhIDEw MDY0NAotLS0gYS9zcmMvZm5zLmMKKysrIGIvc3JjL2Zucy5jCkBAIC00MjIzLDYgKzQyMjMsMTIg QEAgaGFzaF90YWJsZV9yZWhhc2ggKHN0cnVjdCBMaXNwX0hhc2hfVGFibGUgKmgpCiB7CiAgIHB0 cmRpZmZfdCBzaXplID0gSEFTSF9UQUJMRV9TSVpFIChoKTsKIAorICAvKiBUaGVzZSBzdHJ1Y3R1 cmVzIG1heSBoYXZlIGJlZW4gcHVyZWNvcGllZCBhbmQgc2hhcmVkCisgICAgIChidWcjMzY0NDcp LiAgKi8KKyAgaC0+bmV4dCA9IEZjb3B5X3NlcXVlbmNlIChoLT5uZXh0KTsKKyAgaC0+aW5kZXgg PSBGY29weV9zZXF1ZW5jZSAoaC0+aW5kZXgpOworICBoLT5oYXNoID0gRmNvcHlfc2VxdWVuY2Ug KGgtPmhhc2gpOworCiAgIC8qIFJlY29tcHV0ZSB0aGUgYWN0dWFsIGhhc2ggY29kZXMgZm9yIGVh Y2ggZW50cnkgaW4gdGhlIHRhYmxlLgogICAgICBPcmRlciBpcyBzdGlsbCBpbnZhbGlkLiAgKi8K ICAgZm9yIChwdHJkaWZmX3QgaSA9IDA7IGkgPCBzaXplOyArK2kpCi0tIAoyLjIwLjEKCg== --00000000000006b779058d2f346c-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 08 18:18:12 2019 Received: (at 36447) by debbugs.gnu.org; 8 Jul 2019 22:18:12 +0000 Received: from localhost ([127.0.0.1]:59842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkbxb-0005wP-Qb for submit@debbugs.gnu.org; Mon, 08 Jul 2019 18:18:12 -0400 Received: from quimby.gnus.org ([80.91.231.51]:34608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkbxZ-0005wH-Pm for 36447@debbugs.gnu.org; Mon, 08 Jul 2019 18:18:10 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkbxS-0005ii-Ik; Tue, 09 Jul 2019 00:18:05 +0200 From: Lars Ingebrigtsen To: Pip Cet Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> <8736jjgovp.fsf@web.de> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEXw4sqykINZDASXcGD+ /OtyPB/SuK5HtkdZAAACfElEQVQ4jXWTsXLbMAyG4ZrVLEaq5oY5d7ZKyTN5wXFOlCgzWat4/0fo D8pxlxZ3uVD8APwAAVO00Q+ZmmLtsvHBW5FshsNGJTYi0gH+chc7SiZq8sY9bSngerTZPLhHhBIV n/vQE3OaEZ+p/HQvBu6dtdvlakgkjlYaa+2De4G7hYiJAwMkEeu9zV/ci9jB5qb0FoBDEEgg+283 iNRcW4tUjUWJNpPgj4MJxQ+y9Wmj4Zwg3XTjxjBoSRbTh40u5yBNQV16z0W0174tSNVRgUTJFQQE db63mWm8RH0G2cxOUK81LVKZmGxGwb0CaA+SszlElJsIlVsxCiigDmjEC9N2DI0dpAEIcCMS9MET 01XLRRc30CCXGAUck+TSWVaQWJ+TDPcK4A4vVo3EotPZ4siUS7Kd9ziZQAf+tr6t63REHaWNfvZv r0EjIs+L9+sUkUq647rO62vIFSAYgIUptc8r7KPBLPmZZ2SdJylMlxArSLdU8zr4KW1M1h7/RkSa 9WNqk6HRV7A+BQUOJ2gMANxUsDzp2z47rXadus6QPVfx5VFBPNXoaTgYaveq1h+aKq07yNFgfMfF wfEDLwSNau9GNcKxfnzXt0s3ENC5PXz9BHwH6Vw7rx9nTRVQhYJnbGIZjjcAAlAjDhajpBpxanGi gICTW94FK5pu4hWQgtW952Aoph3kCua9j4JUh+ZaFes9/VwXBYK9Emy7mv4Q5B5xZfK+VDA737mx Hv2ETaZo4v5Aznu332OCWIZktNwTZMDWz0dkneDVnXDrXGW1wUm3SadzWrSu2sMeMfEOdlPvG8DG 6jLcwWfI1NaI6O827//6iyj4h0n+D4D9AehP82BHjrQVAAAAAElFTkSuQmCC Date: Tue, 09 Jul 2019 00:18:02 +0200 In-Reply-To: (Pip Cet's message of "Mon, 8 Jul 2019 17:58:42 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Pip Cet writes: > Are you on master? Yup. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: Michael Heerdegen , npostavs@gmail.com, Stefan Monnier , 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pip Cet writes: > Are you on master? Yup. > Also also, can you please stash copies of the emacs binaries and > emacs.pdmp that fail to work? I did something very silly and overwrote > my compiler with a very slightly different version (after carefully > backing up /usr/local/bin/gcc, too. Too bad that's just the driver > program), and now can no longer reproduce the issue easily. OK; will do the next time it happens (but it's gone again now after yet another "make bootstrap")... > Is there anything I can do to help get this bug fixed on master? Thanks! The change is just the following? + /* These structures may have been purecopied and shared + (bug#36447). */ + h->next = Fcopy_sequence (h->next); + h->index = Fcopy_sequence (h->index); + h->hash = Fcopy_sequence (h->hash); I know nothing about this, but did anybody want to fix this in a different way, or did the discussion just peter our? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 08 18:23:38 2019 Received: (at 36447) by debbugs.gnu.org; 8 Jul 2019 22:23:38 +0000 Received: from localhost ([127.0.0.1]:59846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkc2s-00064Q-G8 for submit@debbugs.gnu.org; Mon, 08 Jul 2019 18:23:38 -0400 Received: from mout.web.de ([212.227.15.14]:55377) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkc2p-00064B-RV for 36447@debbugs.gnu.org; Mon, 08 Jul 2019 18:23:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1562624592; bh=54X8RtblGtwkUaghmARAyJf4a1qgNrnMRPH6CRwZyzc=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=lEaZbJXb0DvM+358u3tIatqBHbMiO15XEY4kFOkn8kpI8+BKSycBQBc9vJS44RdZ/ DC0g0J3wuq/yqmuPdNDl6q4pOrC/zcnjdFvq0XdVV9lyRuocLiVm1de+mlRQvK9PDH 14OzUHVJyIzzAsMSoTRzT4OdniEgv+Wmi3W4iApw= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([94.216.191.242]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Lfipe-1iGyvN3nP0-00pM0r; Tue, 09 Jul 2019 00:23:12 +0200 From: Michael Heerdegen To: Pip Cet Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> <8736jjgovp.fsf@web.de> Date: Tue, 09 Jul 2019 00:23:09 +0200 In-Reply-To: (Pip Cet's message of "Mon, 8 Jul 2019 17:58:42 +0000") Message-ID: <87lfx8w4he.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Ljz/blrFfnLVXSUC/Wjj3pcFfYxnk+Jd/2jV59SEBZC6ZgEkld0 JTfBEeNzwbK/lAdgCssSaHOUffwdJo65/xdqgoBseII/4XIHZpId/Uptd2qxl5GO3fMpRZH bK4vIGreQbfx1K5MmZO74S6Rl+P1GTo2jJsHEc7tZsNCChrKepJTyMQ2ZB1w3FKXzClCZOO 5LUoz60HHJSSkO+9nZVvw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:OqbzQSbDgG8=:JFnKJDmrBPSZecYU5T2VdE 91vXVD7lceLrjoxbPmI5zShRxcKFinYU9pTlEfjgtoUs96c+2ffYsoY1Jg2k4uhjlID5s1GKC Y/ha4Etpd+eUxI8SNUjsCA9I4vOrnYd2YYfC0dL0iPaImDT884nq78drNggzU5PmxvqiX7fPC jgXJoNOK6v0o7SQ3J3TEVw09aJIUNzduompnagwWvFBCjjztnGv+d48ape+MEKDebDJY3JUgP V+SvAnXp/j0d8LBBEf74150PnG+ne6kvO9dKuQMfYEAuapm4iAddfpQDegJeOquvLfTrLD+Y7 iARomtIQ/CO9jOk3eBlKZaQ/2rF73tNxjNuHA7+QreTf0uU+cdau3BcK/LpeVSPp6v2W+loQV O5ma5fxZuTHhrNXIeXplxd6sLkXDFf22tVQZaGa/TKWtvFOOVIm5XlR3Mid7z3/fzsjvwC3AB ey3CRDpE6JIoayR38NbNTBkFuxHNYVRg6KQYkZJX0qvgR5V0wCBJFCyhsPNXxaTXQrdqvZ2ml 3tib2zOGUF7tiD2dN372dmh1YMZiJB+SOmecZLxoPF3moXCrBGq5PDCzTsDjg1GHqAtazj1Pm appG7i0xUnLlg4yFOn2AjXJdnTHJ5PZ5koIgMPfWYOICeBtxS2jPDesto2iZ6sfCbv1ZukD2P uOW1bRiDTOlwITlGWdIrlsUITZ2QtKjgCsTim42iV49P+xhsBD6vu6sud4DUjz3lqqH4VBYMz 44RBNWB5iNriV9JFmKzxRXtVfvbaW5fEhJSmRVQ+/w5bVwnMg7a9IeEWMB3daMOaK73OWsk+Y 07KzBvC4mrbSEfAwIZaeGS5WTj7VyupxyDn1ovPkIXtQwRp4uIjbOUOU3S/3Gt1xiJPX3rl6J 84yDIRt80RIXxve/5Z2xGvtv5A/TfOmj05fKLe4UdBPhKsWWW19iI3BAjokjYkNZkHIbfZGAV 3qonwzdY40f0vyJy6+idhgO/FfqDyaCUtV9LAYvJCPP37KpDRv1ym3+/31EouKqfBxt6sa7xL 3I5JI3leeX8Svmq+AQWx7Qz4nlCt0LEtYt3cAI9U9xYkN4Cank1XPyWc44tIjTulg237kfI0R T/gzK7fugc8YmuxmGrW+NzbBBnkELtVumeT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: Lars Ingebrigtsen , 36447@debbugs.gnu.org, Stefan Monnier , npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pip Cet writes: > It is. I think it's worth the risk to push my original fix (reattached > to this message) now, but I don't have commit privileges so it's not > my decision to make. I have been using your latest fix version for some days now without any problems. Since your patch surely doesn't qualify as "tiny" (or whatever the correct wording is), I think you must sign the copyright papers first. You can also just get push access for the repository. Maybe others can assist, I can't even judge if your patch is appropriate (I don't speak C), I only tried it. Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 08 18:25:59 2019 Received: (at 36447) by debbugs.gnu.org; 8 Jul 2019 22:25:59 +0000 Received: from localhost ([127.0.0.1]:59850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkc58-00067o-Sd for submit@debbugs.gnu.org; Mon, 08 Jul 2019 18:25:59 -0400 Received: from mail-io1-f52.google.com ([209.85.166.52]:45324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkc57-00067c-85 for 36447@debbugs.gnu.org; Mon, 08 Jul 2019 18:25:57 -0400 Received: by mail-io1-f52.google.com with SMTP id g20so17789650ioc.12 for <36447@debbugs.gnu.org>; Mon, 08 Jul 2019 15:25:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=dwiHLhwQiehhqsNE4855+Dy+zWwkDGdl5cI52cLXC1A=; b=btJ/IW6BWZ61gWQm8rMppAnu6u64muDIoIteiIE4g5kfpG2+WEctHHoIfTqn8H5ve5 +8vW7JW3ymKDx7Su/zkaApw6SApD+yHAY+cLBWf5rRV/R/IaE6tNJPQwmzB6pS40zfVs 86Ci+jf+3AMQo4HEjYY6bN6/ZXXYUdVDEslA00MFMWfPsJb5RPVfxo1VE2KcRLjb6drd RbCMx7+RGq4GwxEVadOu+jT95+8Xlle7Ec2OmqZl9zpJJlgA5yvmq6Q71aeKV1FKZXnc uI1o1dU4MzqGTQPjZRoLbAMRTC6UxhL8a/hBinm8z1pVf88zCV3mVo4sarprIoQMhQr6 GS/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=dwiHLhwQiehhqsNE4855+Dy+zWwkDGdl5cI52cLXC1A=; b=h+xJQUuUJv8W2dJl2z7c1fokmStWgl7aX5Z/rW/qx7sQSJXRo4F+pNdDbeL/P1HOik 2ND8QqgWZxDrNop7Y7dH7lEWUd8PHRKs+Q/GItelJhQLtXfzPVvla4RMSwGEhSd2F0Wt GVWdDrAuS5u7NQ6ERyypv1rWIxzvdPgcf+BMDijDWujy1xd0iH0WVh8cP/54W2j3nFbp wECm1qakV/pMF4EWGptnT/fIID/BdCO4MuvlUcVsTT9uvENaVkAoTi9KuEH8TnFnAp6n ef6PbajQhwKxzmM5aWV5vGcPtPpqlcGOz8/8wtAcr3k8GmD9R6vfztbWc3jghdhD4xU4 AUgQ== X-Gm-Message-State: APjAAAWMijAOnNPEhoqyGR3OE97rg8lw55B6htOTsAorPAYSrGKtQ6Fp rCIlx02qYcO0eOxUItD2CDs/zVf/ X-Google-Smtp-Source: APXvYqwNm/t6KIk3zn62srQKXBi2ryOlT3YyWsnjCpX09E/KtUe+TCqEerfOMkqB40+P9b5go4tKkg== X-Received: by 2002:a6b:f607:: with SMTP id n7mr20333728ioh.263.1562624750224; Mon, 08 Jul 2019 15:25:50 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id z17sm27056223iol.73.2019.07.08.15.25.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Jul 2019 15:25:49 -0700 (PDT) From: Noam Postavsky To: Lars Ingebrigtsen Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> <8736jjgovp.fsf@web.de> Date: Mon, 08 Jul 2019 18:25:48 -0400 In-Reply-To: (Lars Ingebrigtsen's message of "Tue, 09 Jul 2019 00:18:02 +0200") Message-ID: <87muho2mfn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Lars Ingebrigtsen writes: > Pip Cet writes: > >> Are you on master? > > Yup. I've switched byte-compile-cond-use-jump-table to nil for now, so you shouldn't be hitting this anymore. Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnus.org] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.166.52 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (npostavs[at]gmail.com) 1.3 PDS_NO_HELO_DNS High profile HELO but no A record X-Debbugs-Envelope-To: 36447 Cc: Michael Heerdegen , Stefan Monnier , Pip Cet , 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Lars Ingebrigtsen writes: > Pip Cet writes: > >> Are you on master? > > Yup. I've switched byte-compile-cond-use-jump-table to nil for now, so you shouldn't be hitting this anymore. >> Also also, can you please stash copies of the emacs binaries and >> emacs.pdmp that fail to work? I did something very silly and overwrote >> my compiler with a very slightly different version (after carefully >> backing up /usr/local/bin/gcc, too. Too bad that's just the driver >> program), and now can no longer reproduce the issue easily. > > OK; will do the next time it happens (but it's gone again now after yet > another "make bootstrap")... > >> Is there anything I can do to help get this bug fixed on master? Thanks! > > The change is just the following? > > + /* These structures may have been purecopied and shared > + (bug#36447). */ > + h->next = Fcopy_sequence (h->next); > + h->index = Fcopy_sequence (h->index); > + h->hash = Fcopy_sequence (h->hash); > > I know nothing about this, but did anybody want to fix this in a > different way, or did the discussion just peter our? There were some suggestions about checking PURE_P or similar to see if the copy is really needed, but then apparently PURE_P doesn't work at all? I've been meaning to check that out, because it seems like there are still a few things which aren't making sense. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 08 19:22:58 2019 Received: (at 36447) by debbugs.gnu.org; 8 Jul 2019 23:22:58 +0000 Received: from localhost ([127.0.0.1]:59951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkcyH-0003Rv-P6 for submit@debbugs.gnu.org; Mon, 08 Jul 2019 19:22:58 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkcyF-0003Re-Dv for 36447@debbugs.gnu.org; Mon, 08 Jul 2019 19:22:56 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id BF4B380AC2; Mon, 8 Jul 2019 19:22:49 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 71BE180AB1; Mon, 8 Jul 2019 19:22:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1562628168; bh=/vZe+PHbQBog9JdIA9DywYmGTArXvznv9VNgsCfARrA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=mbhwsuhsE9pNb33yEdj6VPTelMriWV5L82OO9cOboceeBmwX5UHRFuio/clBE9AK6 gn0aXdmebNsR3DpvxZZN7F4WtwTUGXBpXYTq9JaRjrrmrtdadc45ZwjGpGk528EEkA DTE92sLE2eK31QfbJ6GlZsFEZsglu8NQCSyfKPjE353Gq9Z9vxgBKMO3N9Van0GVXg zFJNqgaF7wEqFZWkvEDzH7bfBLSkPezkZiTF6RTlIbe5SpYgpzT5ouAtlPj7YjMMVv J0gxtdRTnmymH5PwwyxvdZNCtGe3bJXXezW7oInd/dpSE8gajNp0w8IQKY06vFF4gN zH5eBw3oOwemA== Received: from alfajor (76-10-138-228.dsl.teksavvy.com [76.10.138.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2494312061D; Mon, 8 Jul 2019 19:22:48 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors Message-ID: References: <875zon7x0a.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> <8736jjgovp.fsf@web.de> Date: Mon, 08 Jul 2019 19:22:47 -0400 In-Reply-To: (Lars Ingebrigtsen's message of "Tue, 09 Jul 2019 00:18:02 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.117 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: Michael Heerdegen , npostavs@gmail.com, Pip Cet , 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > The change is just the following? > > + /* These structures may have been purecopied and shared > + (bug#36447). */ > + h->next = Fcopy_sequence (h->next); > + h->index = Fcopy_sequence (h->index); > + h->hash = Fcopy_sequence (h->hash); Yes. It may not be absolutely perfect, but it's simple enough and should do the trick. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 09 10:09:21 2019 Received: (at 36447) by debbugs.gnu.org; 9 Jul 2019 14:09:21 +0000 Received: from localhost ([127.0.0.1]:33575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkqo5-0003zN-JT for submit@debbugs.gnu.org; Tue, 09 Jul 2019 10:09:21 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:39842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkqo2-0003yX-Hx for 36447@debbugs.gnu.org; Tue, 09 Jul 2019 10:09:19 -0400 Received: by mail-oi1-f193.google.com with SMTP id m202so15453105oig.6 for <36447@debbugs.gnu.org>; Tue, 09 Jul 2019 07:09:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zhebQ9HujpzB3QZujAH+iVquElHvRgQzlslTG4zSqVo=; b=PZHUdN2i7jMmZqrqQK2LcbAVXcSkKIR1TqCWizgWG56FTwQ6etT24Ia/csa+WZlia5 UivgVxWsRVwk69Tve4t/8HeLK8RJbpbTzCEUuPU2j/7psSEnj19/c7K9DGBZ0VRr1bDi 5GSkgVi5HpigeOrl9yjUsZi4zePHJ8UvDavabwmN6YY8pubYbXiLgJSdm427zMlOK7D1 9CMY/LxI/Btlvq5dL75q1/Lez3zS7sBSi+6/DWeN+f582u71ONcGrYV4K1PM+b8kRto2 B1xpJO6/nqySIp3x8Ge+aFkv7kuPGATza/wa/dXCsK1wWx2g9/OdzrdX9fg46TrUJDlo AQjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zhebQ9HujpzB3QZujAH+iVquElHvRgQzlslTG4zSqVo=; b=G1h0sUb2XtzLaHIe5jovge7HQJSHHsBDlN0EGQEomtpdsrnWxuLd9vAXMt3qs6Wu+v 8Gus5cY8MHUfz/L2thjJOOdXMmLSM0k1+a5u3sxAXay5Jfzvi5vYcd1YJrja7WVGTlvP S4AcoVy2wPYgnRBmXvfMxNs38NMJ4wEonTxTcqDTLktBYi2Ryyncv3g8tEnNtvlC725W +y7u8t8SOg4IbXed84NcSqx3MtFh/KG7K+Qu8fqH53f50tBpYeVkMkBo5vR0W9MCdPdt P/KJV7l11zT1pZPDsHD8c7bpD/6vVSBFcsRwtvHbNRh0sbFiEho/VjdcwlIf0vZVSZWe BL9A== X-Gm-Message-State: APjAAAXzx5cEHSZQ9027iYv6zCLJvPkKt9I0u7PbTUar6EGXASOmzzSD JaXXaq1gXgTAqclyYEXZpi+5Zn2i7N3uVsBl91MtIwtk X-Google-Smtp-Source: APXvYqyF9I3qMUb1ZW1PXBB9h/UVN/9HTCW4VFVFroif/Hwn/CBOKjyCIDBjoToMu0voHA5jRHlqMsXtuB20w01xMn4= X-Received: by 2002:aca:aa93:: with SMTP id t141mr98134oie.128.1562680886869; Tue, 09 Jul 2019 07:01:26 -0700 (PDT) MIME-Version: 1.0 References: <875zon7x0a.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> <8736jjgovp.fsf@web.de> <87muho2mfn.fsf@gmail.com> In-Reply-To: <87muho2mfn.fsf@gmail.com> From: Pip Cet Date: Tue, 9 Jul 2019 14:00:50 +0000 Message-ID: Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors To: Noam Postavsky Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Mon, Jul 8, 2019 at 10:25 PM Noam Postavsky wrote: > I've switched byte-compile-cond-use-jump-table to nil for now, so you > shouldn't be hitting this anymore. Thanks. > > I know nothing about this, but did anybody want to fix this in a > > different way, or did the discussion just peter our? > > There were some suggestions about checking PURE_P or similar to see if [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pipcet[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.193 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.193 listed in wl.mailspike.net] 1.3 PDS_NO_HELO_DNS High profile HELO but no A record X-Debbugs-Envelope-To: 36447 Cc: Michael Heerdegen , Lars Ingebrigtsen , Stefan Monnier , 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) On Mon, Jul 8, 2019 at 10:25 PM Noam Postavsky wrote: > I've switched byte-compile-cond-use-jump-table to nil for now, so you > shouldn't be hitting this anymore. Thanks. > > I know nothing about this, but did anybody want to fix this in a > > different way, or did the discussion just peter our? > > There were some suggestions about checking PURE_P or similar to see if > the copy is really needed, but then apparently PURE_P doesn't work at > all? I've been meaning to check that out, because it seems like there > are still a few things which aren't making sense. It does seem like we've effectively given up pure space when we switched to pdumper. We still fill it and spend a lot of time making sure not to waste any, but it's then simply copied to the dump along with the rest of the dumped image. It's still kept around in the final executable, so we're wasting quite a bit of disk space on it... Most importantly, I think, the CHECK_IMPURE macro now does nothing (except waste a few cycles), and we can freely setcar what should be purecopied conses. (One thing we might do is introduce immutable conses, and use them for `read', pure space, and in a few other places). From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 09 11:43:37 2019 Received: (at 36447) by debbugs.gnu.org; 9 Jul 2019 15:43:37 +0000 Received: from localhost ([127.0.0.1]:33842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hksHH-0002j1-Nv for submit@debbugs.gnu.org; Tue, 09 Jul 2019 11:43:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37009) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hksHF-0002in-Np for 36447@debbugs.gnu.org; Tue, 09 Jul 2019 11:43:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53032) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hksHA-0002ui-Cx; Tue, 09 Jul 2019 11:43:28 -0400 Received: from [176.228.60.248] (port=2245 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hksH9-0004UV-1O; Tue, 09 Jul 2019 11:43:28 -0400 Date: Tue, 09 Jul 2019 18:43:12 +0300 Message-Id: <837e8r5i3z.fsf@gnu.org> From: Eli Zaretskii To: Michael Heerdegen In-reply-to: <87lfx8w4he.fsf@web.de> (message from Michael Heerdegen on Tue, 09 Jul 2019 00:23:09 +0200) Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> <8736jjgovp.fsf@web.de> <87lfx8w4he.fsf@web.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36447 Cc: larsi@gnus.org, monnier@iro.umontreal.ca, npostavs@gmail.com, pipcet@gmail.com, 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Heerdegen > Date: Tue, 09 Jul 2019 00:23:09 +0200 > Cc: Lars Ingebrigtsen , npostavs@gmail.com, > 36447@debbugs.gnu.org, Stefan Monnier > > Since your patch surely doesn't qualify as "tiny" (or whatever the > correct wording is), I think you must sign the copyright papers first. He did that already. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 09 16:16:11 2019 Received: (at 36447) by debbugs.gnu.org; 9 Jul 2019 20:16:11 +0000 Received: from localhost ([127.0.0.1]:34328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkwX5-0005oX-2P for submit@debbugs.gnu.org; Tue, 09 Jul 2019 16:16:11 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54389) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkwX2-0005ny-CU for 36447@debbugs.gnu.org; Tue, 09 Jul 2019 16:16:09 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 12C8B1008A7; Tue, 9 Jul 2019 16:16:02 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id EB93B100393; Tue, 9 Jul 2019 16:16:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1562703361; bh=26DO10aBUeZ9P02+/0NMCVKGMJ+5d7ZXYExHZ9Fz0ww=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=pXBHXLPZ/IBmImB2BxVT1CKk4EzA5JA6nYTWShi/19StfweO0F/6blV3wue9Dlx3l efSQpLYHeOYHDemD4KIJrDJFrpesSBJDmw3kN5eXVvZQDpASc2/vBW+MqpSvAPAfXu aIRc4rHue4K/ksELxD125NKWQ2fkHTcibp3z/t52sOh58xxgTpKsHlgOkzQL7weXVt SZgRb1V2wqt/mhV4rFos6oqtJMCMYwiP2H+UFzikp6A92GwU2DWes7BezboQJ+m2X7 w0/JrpH60tIF51S8VR6Y/x6HfpQKFicJqemaJhborCqbti0oqz9xe/qRHRAqL6AlJj Dl0qF0Zg0Xv8w== Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BC07F1202C2; Tue, 9 Jul 2019 16:16:00 -0400 (EDT) From: Stefan Monnier To: Pip Cet Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors Message-ID: References: <875zon7x0a.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> <8736jjgovp.fsf@web.de> Date: Tue, 09 Jul 2019 16:15:55 -0400 In-Reply-To: (Pip Cet's message of "Mon, 8 Jul 2019 17:58:42 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.355 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: Michael Heerdegen , Lars Ingebrigtsen , npostavs@gmail.com, 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Is there anything I can do to help get this bug fixed on master? Thanks! Pushed, thank you, Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 09 17:06:02 2019 Received: (at 36447) by debbugs.gnu.org; 9 Jul 2019 21:06:02 +0000 Received: from localhost ([127.0.0.1]:34381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkxJK-0000m4-6Y for submit@debbugs.gnu.org; Tue, 09 Jul 2019 17:06:02 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:37952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkxJI-0000lq-Bm for 36447@debbugs.gnu.org; Tue, 09 Jul 2019 17:06:00 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3758B100608; Tue, 9 Jul 2019 17:05:55 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D58811008A7; Tue, 9 Jul 2019 17:05:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1562706353; bh=G/bJHPWnF4Uci22XxoecoxMdR3TOW3ITzydL2bTjnMo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=cYAuGF3Vree8k+yPPhwy4cBhPZB+2hndGJGr2cDIXx2XCs4Wleq0xS+VU9Er5eTUL 54uGMLCtkk7bEUoPhHLtHDVKPZrmD0Eooy6cjRkwTf0ee3bGyFmmEK/QyDFJ+OC6oB uJgum1iIQxOZUCTsssmuvBDQ4iB2/8yuP8LWZ6j3qM8WJ6CciDeBgGX+IRToIeW+UJ QolAXABnI14zji7tWTfkI3NYJy9jtAI8225BOEXS94haiKsvF90I1GG2XPlSMpHmP1 CKxHWTIxouFGFp00vE7WtKZ8i45WSfsAojtv0MO3LMKeURA7f1w1TL88eDQPZ6A54S BPad2V6lfNa8A== Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B14D0120152; Tue, 9 Jul 2019 17:05:53 -0400 (EDT) From: Stefan Monnier To: Pip Cet Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors Message-ID: References: <875zon7x0a.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> <83bly7acg9.fsf@gnu.org> Date: Tue, 09 Jul 2019 17:05:53 -0400 In-Reply-To: (Pip Cet's message of "Sat, 6 Jul 2019 15:08:08 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.342 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, Eli Zaretskii , npostavs@gmail.com, 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I think we should get Daniel's opinion on this. Stefan > On Sat, Jul 6, 2019 at 6:45 AM Eli Zaretskii wrote: >> > > Indeed. I'm attaching a proof of concept that we can simply freeze the >> > > hash tables when dumping and thaw them when loading a dump, which >> > > includes rehashing. Do you happen to know why it wasn't done that way? >> > >> > I'd guess it was to shorten the startup time by doing this rehashing lazily. >> >> The function pdumper-stats with show the time it took to load Emacs, >> so the effect of this on the load time can be measured > > I'm measuring it directly, and it's more than I expected: about a > millisecond, for 4,300 hash table entries. What we can't easily > measure is how much the lazy rehashing code would slow us down anyway. > > For comparison, the entire time stored in pdumper-stats is 15 ms here. > > I don't think that's significant, because we'd probably end up > rehashing most of the large hash tables anyway. We're saving some 250 > KB of space in the pdmp image, which was previously used for redundant > information. (I'm surprised it's that much, but I guess pdumper > relocations are fairly large?) > > I'm attaching a revised patch, which uses vectors rather than consed > lists for both the key_and_value vector, avoiding a copy in the common > case where there is more than one hash table entry, and for the list > of hash tables. It still contains debugging/timing code. > > charset.c currently assumes hash table entries will stay at the same > index in Vcharset_hash_table. I think that works okay in practice, > because we don't shrink or reorder hash tables, but it was still a bit > of a nasty surprise. > > This concept appears to work: modify pdumper to special-case hash > tables and freeze/thaw them properly. You probably shouldn't dump hash > tables with complicated user-defined hash functions. > > Both PURE_P and pdumper_object_p fail to distinguish between tables > that were pure or impure before being dumped. > > This also fixes the bug that (hash-table-count dumped-hash-table) will > return a negative number if no previous access to the hash table has > happened, but of course we can fix that directly... > > Of course, we're still modifying purecopied information. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 09 22:38:25 2019 Received: (at 36447) by debbugs.gnu.org; 10 Jul 2019 02:38:25 +0000 Received: from localhost ([127.0.0.1]:34646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hl2Uz-0000wk-16 for submit@debbugs.gnu.org; Tue, 09 Jul 2019 22:38:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hl2Ux-0000wX-1k for 36447@debbugs.gnu.org; Tue, 09 Jul 2019 22:38:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hl2Uq-0001Je-5g; Tue, 09 Jul 2019 22:38:16 -0400 Received: from [176.228.60.248] (port=2571 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hl2Up-0008S3-Id; Tue, 09 Jul 2019 22:38:15 -0400 Date: Wed, 10 Jul 2019 05:38:01 +0300 Message-Id: <83ef2y4nsm.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier , Daniel Colascione In-reply-to: (message from Stefan Monnier on Tue, 09 Jul 2019 17:05:53 -0400) Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> <83bly7acg9.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, npostavs@gmail.com, pipcet@gmail.com, 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Eli Zaretskii , michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org > Date: Tue, 09 Jul 2019 17:05:53 -0400 > > I think we should get Daniel's opinion on this. Daniel, could you please comment on the issues discussed in this bug? > > On Sat, Jul 6, 2019 at 6:45 AM Eli Zaretskii wrote: > >> > > Indeed. I'm attaching a proof of concept that we can simply freeze the > >> > > hash tables when dumping and thaw them when loading a dump, which > >> > > includes rehashing. Do you happen to know why it wasn't done that way? > >> > > >> > I'd guess it was to shorten the startup time by doing this rehashing lazily. > >> > >> The function pdumper-stats with show the time it took to load Emacs, > >> so the effect of this on the load time can be measured > > > > I'm measuring it directly, and it's more than I expected: about a > > millisecond, for 4,300 hash table entries. What we can't easily > > measure is how much the lazy rehashing code would slow us down anyway. > > > > For comparison, the entire time stored in pdumper-stats is 15 ms here. > > > > I don't think that's significant, because we'd probably end up > > rehashing most of the large hash tables anyway. We're saving some 250 > > KB of space in the pdmp image, which was previously used for redundant > > information. (I'm surprised it's that much, but I guess pdumper > > relocations are fairly large?) > > > > I'm attaching a revised patch, which uses vectors rather than consed > > lists for both the key_and_value vector, avoiding a copy in the common > > case where there is more than one hash table entry, and for the list > > of hash tables. It still contains debugging/timing code. > > > > charset.c currently assumes hash table entries will stay at the same > > index in Vcharset_hash_table. I think that works okay in practice, > > because we don't shrink or reorder hash tables, but it was still a bit > > of a nasty surprise. > > > > This concept appears to work: modify pdumper to special-case hash > > tables and freeze/thaw them properly. You probably shouldn't dump hash > > tables with complicated user-defined hash functions. > > > > Both PURE_P and pdumper_object_p fail to distinguish between tables > > that were pure or impure before being dumped. > > > > This also fixes the bug that (hash-table-count dumped-hash-table) will > > return a negative number if no previous access to the hash table has > > happened, but of course we can fix that directly... > > > > Of course, we're still modifying purecopied information. > > From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 09 23:01:27 2019 Received: (at 36447) by debbugs.gnu.org; 10 Jul 2019 03:01:28 +0000 Received: from localhost ([127.0.0.1]:34662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hl2rH-0001te-Ju for submit@debbugs.gnu.org; Tue, 09 Jul 2019 23:01:27 -0400 Received: from dancol.org ([96.126.100.184]:54998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hl2rF-0001tT-As for 36447@debbugs.gnu.org; Tue, 09 Jul 2019 23:01:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From:Subject:Date:References:In-Reply-To:Message-ID; bh=6BXW5mQIRfbzWYYcpRj4qxXHYHIIu+FFC4fzz08/tC8=; b=pzIAImH4nBVCTZjYgCZD0c5Iea2yx2m+yvDJy04pApBcHSpHs5ofUWlkyYu15ISLH8D0dOEtOVrynZ5aVc1dAhoaIX9esCZ6vyIjr441IUG0FoFttHCwj9yx3XTi9AX5uAQHOQd/4lZfg9j08fw1fF5TVr/YYNYgocdxHnXvFQszADyO+9R1m96yNa20rAM1G0zkJ8JNRsyEALxmHS6R9vNHMBI7bQtkmOmN0zeHEC258aWN1C5FLmp2SwbSakJZJkB3zCmjr5TGQpW+Pqpboau21MmmZ4j98HsGgKvFY2b+riS9ZZ7+nywWuXW6hWW2xqzEFkgdNwUxZAe8JkS8Ig==; Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hl2r4-0006m9-AB; Tue, 09 Jul 2019 20:01:14 -0700 Received: from 127.0.0.1 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Tue, 9 Jul 2019 20:01:14 -0700 Message-ID: <7c22ff8d30102b8e4c2d2a766c0cf60b.squirrel@dancol.org> In-Reply-To: References: <875zon7x0a.fsf@web.de> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> <8736jjgovp.fsf@web.de> <87muho2mfn.fsf@gmail.com> Date: Tue, 9 Jul 2019 20:01:14 -0700 Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors From: "Daniel Colascione" To: "Pip Cet" User-Agent: SquirrelMail/1.4.23 [SVN] MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: Michael Heerdegen , 36447@debbugs.gnu.org, Lars Ingebrigtsen , Noam Postavsky , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Mon, Jul 8, 2019 at 10:25 PM Noam Postavsky wrote: >> I've switched byte-compile-cond-use-jump-table to nil for now, so you >> shouldn't be hitting this anymore. > > Thanks. > >> > I know nothing about this, but did anybody want to fix this in a >> > different way, or did the discussion just peter our? >> >> There were some suggestions about checking PURE_P or similar to see if >> the copy is really needed, but then apparently PURE_P doesn't work at >> all? I've been meaning to check that out, because it seems like there >> are still a few things which aren't making sense. > > It does seem like we've effectively given up pure space when we > switched to pdumper. We still fill it and spend a lot of time making > sure not to waste any, but it's then simply copied to the dump along > with the rest of the dumped image. We're at least combining identical objects, which is what this bug is about. > It's still kept around in the final > executable, so we're wasting quite a bit of disk space on it... At least the executable pure space isn't paged in. I prefer not to waste disk space, but wasting disk space without wasting memory is lower on my list of priorities than other things. > Most importantly, I think, the CHECK_IMPURE macro now does nothing > (except waste a few cycles), and we can freely setcar what should be > purecopied conses. > > (One thing we might do is introduce immutable conses, and use them for > `read', pure space, and in a few other places). We could use pureness information to relocate all the pure objects in the dump so that we're less likely to take COW faults on them during runtime. Right now, if a pure object and a regular object share a page in the dump and we modify the regular object, we copy the pure object uselessly. Note that we're not modifying these objects for GC, since we keep dump markbits separate from the dump image (as we really should be doing for the heap in general one day). From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 09 23:19:51 2019 Received: (at 36447) by debbugs.gnu.org; 10 Jul 2019 03:19:51 +0000 Received: from localhost ([127.0.0.1]:34678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hl394-0002gX-OZ for submit@debbugs.gnu.org; Tue, 09 Jul 2019 23:19:51 -0400 Received: from dancol.org ([96.126.100.184]:55234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hl392-0002gK-FG for 36447@debbugs.gnu.org; Tue, 09 Jul 2019 23:19:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From:Subject:Date:References:In-Reply-To:Message-ID; bh=kv5YhCxHywOGG44zp3JyKYp00aXF5xdoYQJEOCfrynU=; b=PQY+CDtWLTvSKEf/MZDIxi3wDKuN5XX9lVUmUiJenEBXJMKbN9hiU8+ZBm/FGJe0+U3kgJyLH1Udi28ejhKTzEEGsufTJaL3aIq53DnZ0iUW9RMUiJiF4SHCg84e81Vrj+oyihLaefIqntfUkBJ72Gjp9+qzt8M1peHwn6HvVtZ34BAK+l64OSN5i9CW2un0xCj8jV3/C22ekn5RuuS91crSF/v0ovN3Oi18omHtbz6zCnJ2jBiuKNZ5UWbrslk7PpMXDUk3h1jFNJnmVrIZQQHG0X1s3OqVC+AgRm8TWJaYQBWh7sGrInwytMMeiMP4P9NV9IG/d1dHJu05uOFf5Q==; Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hl38s-0006qF-Bh; Tue, 09 Jul 2019 20:19:38 -0700 Received: from 127.0.0.1 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Tue, 9 Jul 2019 20:19:38 -0700 Message-ID: <735465eebd8f96d3969d42e6f734f69e.squirrel@dancol.org> In-Reply-To: <83ef2y4nsm.fsf@gnu.org> References: <875zon7x0a.fsf@web.de> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> <83bly7acg9.fsf@gnu.org> <83ef2y4nsm.fsf@gnu.org> Date: Tue, 9 Jul 2019 20:19:38 -0700 Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors From: "Daniel Colascione" To: "Eli Zaretskii" User-Agent: SquirrelMail/1.4.23 [SVN] MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, npostavs@gmail.com, Stefan Monnier , pipcet@gmail.com, Daniel Colascione , 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> From: Stefan Monnier >> Cc: Eli Zaretskii , michael_heerdegen@web.de, >> npostavs@gmail.com, 36447@debbugs.gnu.org >> Date: Tue, 09 Jul 2019 17:05:53 -0400 >> >> I think we should get Daniel's opinion on this. > > Daniel, could you please comment on the issues discussed in this bug? Thanks for debugging this problem. It really is nasty. AIUI, the problem is that hash-consing the hash vectors might unify vectors that happen to have the same contents under one hashing scheme but different contents under a different hashing scheme, so when we rehash lazily, we correctly rehash one hash table and corrupt a different hash table's index array by side effect. There are two proposed solutions: 1) Copy the hash table internal vectors on rehash, and 2) "Freeze" hash tables by eliminating the index arrays and rebuilding them all eagerly on dump start. #1 works, but it's somewhat inefficient. #2 is a variant of #1, in a sense. Instead of copying the hash table vectors and mutating them, we rebuild them from scratch. I don't understand why we have to do that eagerly. #1 isn't as bad as you might think. The existing hash table rehashing stuff is inefficient anyway. Suppose we dump a hash table, load a dump, and access the hash table. Right now, we do the rehashing and take COW faults for the arrays we mutate. So far, so good. What happens if we grow the hash table past its load factor limit? We allocate new vectors and rehash into those, forgetting the old vectors. In the non-pdumper case, GC will collect those older vectors eventually. In the pdumper case, those COWed pages will stick around in memory forever, unused. I don't think it counts as a "leak", since the memory waste is bounded, but it's still memory waste. If we use approach #1, we don't mutate the hash table pages mapped from the dump. Besides, the amount of work we do is actually the same. In the COW-page case, the kernel allocates a new page, reads the dump bytes, and writes them to the new page. In the Fcopy_sequence case, *we* allocate a new vector, read the dump bytes, and write them into anonymous memory. It's the same work either way, except that if we copy, when we grow the hash table, we can actually free the original vectors. IMHO, the right approach is to check in #1 for now and switch to a #2-like approach once master is stable. Noticing that we don't actually have to store the hash table internal arrays in the dump is a good catch. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 10 11:01:44 2019 Received: (at 36447) by debbugs.gnu.org; 10 Jul 2019 15:01:45 +0000 Received: from localhost ([127.0.0.1]:36428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlE6K-0005nR-H0 for submit@debbugs.gnu.org; Wed, 10 Jul 2019 11:01:44 -0400 Received: from mail-oi1-f169.google.com ([209.85.167.169]:45811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlE6I-0005hU-Lu for 36447@debbugs.gnu.org; Wed, 10 Jul 2019 11:01:43 -0400 Received: by mail-oi1-f169.google.com with SMTP id m206so1843594oib.12 for <36447@debbugs.gnu.org>; Wed, 10 Jul 2019 08:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c/UsfGKxYPTqqsnBpCrzW1zzDSWwzPwD5C5iAZD6GmQ=; b=EciHRmvyXu3eGwMc1zO8uT62dauIduQgAU0CnwHvKchp6qRtTY4fwbGY9LCvVTCSPC QI/Q2qAQ50wUh5CSAwzpY8x5Tk2a7fkVit1voLGcFgQPJtaHev2OSthHVLZIPFpAM0O1 yS1s8EZ2lm2UFc/UCx2li2Tn2yFP5qKA01PJaSlOWHODaWo1Sm81w0MsZzP9nqUpIFJx /lxMlReYa8cJrjO6rTu1HdUgpjIHr2aJD0fWljhxJVgEUfqEeRV//+JwcOr0KKXQeSJO S7/iKQlCut9DHGy7WjjKLdJIOdwm0nTqVsGnsrR6i9OmDtTd+lJeG2GoGkb1f7sKtz+/ /uDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c/UsfGKxYPTqqsnBpCrzW1zzDSWwzPwD5C5iAZD6GmQ=; b=Wp4GEJYhMl6YW5EDjVPz6rEPpMCPjojaM8O1dHXtqZlSibzofObrKvB71AF2f721uk EgLob43Q9MtAO8XwtV278UiRGPCJmXl5ejHFi71LM98/BjA7kZMgatJHkuSqpzGB/IR+ zdm0rU6sAx34WTQUmAiHsGrW+jGvzfgM1JvGnpoMEZteHdtYydEZfhqAGh480EJvnCAc UdE+ORwHNa762Q5SuH8oe/9ueEvRUnS88C6OSG6kVdo+iKWFTl/UQYPQ0cYp8vS+JkHr F9PFRybLSUI4vo9WwCIWH41QHcTtOmBks2ULxW7169JL8zalZI0iinwTiH/DRw8o8OM4 rotA== X-Gm-Message-State: APjAAAWz72o1aaqDlrYMhML4pfoPiMG0mZ8APb92Is2zhtsxTS3iMxmo d5vCL82g+Y55oWCw5D+w7JZSxfkEw03z0ULAKKM= X-Google-Smtp-Source: APXvYqwL4Cf/1iK7gMGLDoq1a0Csyax/UabEBolXh0DXvWXp4aQlhl9fuuAIAsBVwbaBV+xs4fAZcE0YTy206JWBVPg= X-Received: by 2002:aca:aa93:: with SMTP id t141mr3604573oie.128.1562770896959; Wed, 10 Jul 2019 08:01:36 -0700 (PDT) MIME-Version: 1.0 References: <875zon7x0a.fsf@web.de> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> <83bly7acg9.fsf@gnu.org> <83ef2y4nsm.fsf@gnu.org> <735465eebd8f96d3969d42e6f734f69e.squirrel@dancol.org> In-Reply-To: <735465eebd8f96d3969d42e6f734f69e.squirrel@dancol.org> From: Pip Cet Date: Wed, 10 Jul 2019 15:01:01 +0000 Message-ID: Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors To: Daniel Colascione Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Wed, Jul 10, 2019 at 3:19 AM Daniel Colascione wrote: > Thanks for debugging this problem. It really is nasty. AIUI, the problem > is that hash-consing the hash vectors might unify vectors that h [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pipcet[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: dancol.org] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.169 listed in list.dnswl.org] 1.3 PDS_NO_HELO_DNS High profile HELO but no A record X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, 36447@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier , npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) On Wed, Jul 10, 2019 at 3:19 AM Daniel Colascione wrote: > Thanks for debugging this problem. It really is nasty. AIUI, the problem > is that hash-consing the hash vectors might unify vectors that happen to > have the same contents under one hashing scheme but different contents > under a different hashing scheme, so when we rehash lazily, we correctly > rehash one hash table and corrupt a different hash table's index array by > side effect. There are two proposed solutions: > > 1) Copy the hash table internal vectors on rehash, and > 2) "Freeze" hash tables by eliminating the index arrays and rebuilding > them all eagerly on dump start. That summary is correct, I think. > #1 works, but it's somewhat inefficient. > > #2 is a variant of #1, in a sense. Instead of copying the hash table > vectors and mutating them, we rebuild them from scratch. I don't > understand why we have to do that eagerly. I'm sorry if I suggested that we must do that. On the contrary, both options are entirely viable, though on balance I prefer the eager version. The lazy approach makes the code more complicated, slightly slower, and introduced what appears to me to be at least one bug (Fhash_table_count returns a negative integer if called with a non-rehashed hastable). The eager approach slows down startup by a fraction of a millisecond (it might be an entire millisecond if your Emacs session doesn't access any of the dumped hash tables at all, but since it does tend to do that, it'll be less in practice). > #1 isn't as bad as you might think. But it's not as good as "do #1 but only if PURE_P", which no longer works. > It's the same work either way, except that if we copy, when we grow the > hash table, we can actually free the original vectors. I'd like to restrict #1 to hash tables which are somehow immutable, either because they're pure or because we actually introduce immutable objects, so they'd never grow. Mutable hash tables must not share their index vectors anyway. > IMHO, the right approach is to check in #1 for now and switch to a #2-like > approach once master is stable. Noticing that we don't actually have to > store the hash table internal arrays in the dump is a good catch. I agree, but I think we should discuss the future of pure space, too. Maybe we should have a separate bug for that, though. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 10 13:16:56 2019 Received: (at 36447) by debbugs.gnu.org; 10 Jul 2019 17:16:56 +0000 Received: from localhost ([127.0.0.1]:36557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlGDA-0001Jm-DZ for submit@debbugs.gnu.org; Wed, 10 Jul 2019 13:16:56 -0400 Received: from dancol.org ([96.126.100.184]:38764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlGD7-0001Jd-Hz for 36447@debbugs.gnu.org; Wed, 10 Jul 2019 13:16:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From:Subject:Date:References:In-Reply-To:Message-ID; bh=UWeDf8ao0jx06h43A1MgoWZrAlzKvea9jBfOMspgF04=; b=OcbkQGlt4J3xDIp+Zhr9FL5gTVGEyKvWN0S17XdGaXelPss0NyyWRhZCBHSqKkI8PyCHRfWJeXr/XF7EYXTtumwkd3bhQ6BWAV/r4gxS1/xWDcd/N3n+6Jiz9ihI/dC7rJUFLUR2yQ9XVoOEosv7SBCEN20clriWR6ul30kdvPvyB9YHz9tYICAFlBhtccD7XW5KGFMw3cRRnvW0kcdVOkpS6RlpgtOmY8Owox2uv8pigDktDq8aL1Z6Dxx1E93BCCZLoaL/p5WsRU4axrNUxLezY8MHn0/VM7YLOpODckMaF+NV5M99p2BsxoKSBUWUIDzAVR1ZjN14t1tYUWgtlw==; Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlGCv-00020l-Sg; Wed, 10 Jul 2019 10:16:42 -0700 Received: from 127.0.0.1 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Wed, 10 Jul 2019 10:16:41 -0700 Message-ID: <533a60e1856bcddd6a4f7eea5602549e.squirrel@dancol.org> In-Reply-To: References: <875zon7x0a.fsf@web.de> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> <83bly7acg9.fsf@gnu.org> <83ef2y4nsm.fsf@gnu.org> <735465eebd8f96d3969d42e6f734f69e.squirrel@dancol.org> Date: Wed, 10 Jul 2019 10:16:41 -0700 Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors From: "Daniel Colascione" To: "Pip Cet" User-Agent: SquirrelMail/1.4.23 [SVN] MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, npostavs@gmail.com, Stefan Monnier , Eli Zaretskii , Daniel Colascione , 36447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Wed, Jul 10, 2019 at 3:19 AM Daniel Colascione > wrote: >> #1 works, but it's somewhat inefficient. >> >> #2 is a variant of #1, in a sense. Instead of copying the hash table >> vectors and mutating them, we rebuild them from scratch. I don't >> understand why we have to do that eagerly. > > I'm sorry if I suggested that we must do that. On the contrary, both > options are entirely viable, though on balance I prefer the eager > version. > > The lazy approach makes the code more complicated, I don't think doing it eagerly is a complexity win. The eager patch posted upthread is a wash. > slightly slower, No it doesn't. The hash table branch on negative count should be predicted correctly and involves a test against a cache line we're loading anyway. We can add explicit likely() and unlikely() annotations too. > and introduced what appears to me to be at least one bug > (Fhash_table_count returns a negative integer if called with a > non-rehashed hastable). That's a trivial oversight and not an inherent difficulty in the lazy approach. > The eager approach slows down startup by a fraction of a millisecond > (it might be an entire millisecond if your Emacs session doesn't > access any of the dumped hash tables at all, but since it does tend to > do that, it'll be less in practice). A millisecond here and a millisecond there and things end up costing real time. A lazy approach isn't any harder than an eager one and >> #1 isn't as bad as you might think. > > But it's not as good as "do #1 but only if PURE_P", which no longer works. > >> It's the same work either way, except that if we copy, when we grow the >> hash table, we can actually free the original vectors. > > I'd like to restrict #1 to hash tables which are somehow immutable, > either because they're pure or because we actually introduce immutable > objects, so they'd never grow. Mutable hash tables must not share > their index vectors anyway. Did you miss the part about avoiding copy-on-write faults? Those hash table vectors are going to be copied anyway, and we might as well do it ourselves instead of making the kernel do it. (unexec has the same inefficiency, BTW.) We should just do #1 for all hash tables. >> IMHO, the right approach is to check in #1 for now and switch to a >> #2-like >> approach once master is stable. Noticing that we don't actually have to >> store the hash table internal arrays in the dump is a good catch. > > I agree, but I think we should discuss the future of pure space, too. > Maybe we should have a separate bug for that, though. Sure. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 10 16:14:55 2019 Received: (at 36447) by debbugs.gnu.org; 10 Jul 2019 20:14:55 +0000 Received: from localhost ([127.0.0.1]:36670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlIzP-0006u8-AN for submit@debbugs.gnu.org; Wed, 10 Jul 2019 16:14:55 -0400 Received: from mail-oi1-f180.google.com ([209.85.167.180]:38469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlIzN-0006tr-W8 for 36447@debbugs.gnu.org; Wed, 10 Jul 2019 16:14:54 -0400 Received: by mail-oi1-f180.google.com with SMTP id v186so2662617oie.5 for <36447@debbugs.gnu.org>; Wed, 10 Jul 2019 13:14:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hKKjJljnAUO+wyeqRWKYurFqUJdH1EiE1jltu0i0VN8=; b=j0um6vlSz6ZtRUBsmOMRZiiKf911TDmJ1NYb+UKf0H5c5L0TeDdGbBKCf/THl3odM7 ddw0iulnVGRPSNK5vyUHfJt/H5jTWzHCkolr4DqwIoWIfgEpHW4H+0jI/DvJt4DL5Stb RmXflCEAm/v9IYtrSUe3f/Z74d4ainoH2cB2xeswabaX9/qWIk+LM6JXsm067b+zqgt5 0WPhdAbItz1qJJyRkJ67irCzHTRE0f8E4D3Q6xaDj/BRJ9jnkOzDwHqu1mCRvRGYaWD8 g6vtHrLqHSjc1dx26wD7kZuMAYottAM4EXm5BIy9Ecgkh1INGtvkO9iSLLDq28+dT9F9 bw4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hKKjJljnAUO+wyeqRWKYurFqUJdH1EiE1jltu0i0VN8=; b=USV/lOcQvWf6U5Ip+aa9ybuTNjaLi4VXX/HDNfb1qpJ83mGZfJ60BfC1MmX1In9mpQ 1TVdMTj4os6ddhyhGDspe7Rip3JdAWAuGYkGv9cl91JksQuVe4g7I1d0CBW+OdzgzqV7 fYzaKPxtRiwSDna/Oq7IEnHXNwRwVC73XwSSUvwET3OAOd9Z63J2r4mSey0kMpnfPA6N jN9Ilbm6ugo75hlZq01eu1GbJ5ateZMQd3sOpKwliy+Q0+lMPwGOXac2Ged3wnE1boWY zFmkzEqv1dvBWRM4xPWFPUIZgesRiDY3dQMVYkHqsDJVw6Ctch84qZmvkFIYY+Q7eU1C DUZA== X-Gm-Message-State: APjAAAULpj1Ql1IDN3dNjKwrBWgmhfz9z9t2Sz3hubfYeUTw0qvdyYZC UE/BnMqPqO1XH175m9udVuk9ZY1agCBSfzhQWQU= X-Google-Smtp-Source: APXvYqy8mkqrYZRU3A+KWxpqyWFPwPLsszX4OWaQJ6zZewylEMJ5thSJVgJM0WEGaMBjmJ3Nm3ib0tA/TsBZ7AWyV7s= X-Received: by 2002:a05:6808:313:: with SMTP id i19mr137248oie.30.1562789687977; Wed, 10 Jul 2019 13:14:47 -0700 (PDT) MIME-Version: 1.0 References: <875zon7x0a.fsf@web.de> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> <83bly7acg9.fsf@gnu.org> <83ef2y4nsm.fsf@gnu.org> <735465eebd8f96d3969d42e6f734f69e.squirrel@dancol.org> <533a60e1856bcddd6a4f7eea5602549e.squirrel@dancol.org> In-Reply-To: <533a60e1856bcddd6a4f7eea5602549e.squirrel@dancol.org> From: Pip Cet Date: Wed, 10 Jul 2019 20:14:11 +0000 Message-ID: Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors To: Daniel Colascione Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Wed, Jul 10, 2019 at 5:16 PM Daniel Colascione wrote: > We should just do #1 for all hash tables. I think that's what we're currently doing. We should close this bug and open new ones for tangential issues (pure space, Fhash_table_count, and whether lazy rehashing is a good idea), if and when some [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: dancol.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pipcet[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.180 listed in list.dnswl.org] 1.3 PDS_NO_HELO_DNS High profile HELO but no A record X-Debbugs-Envelope-To: 36447 Cc: michael_heerdegen@web.de, 36447@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier , npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) On Wed, Jul 10, 2019 at 5:16 PM Daniel Colascione wrote: > We should just do #1 for all hash tables. I think that's what we're currently doing. We should close this bug and open new ones for tangential issues (pure space, Fhash_table_count, and whether lazy rehashing is a good idea), if and when someone feels like discussing those issues. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 10:06:30 2019 Received: (at 36447) by debbugs.gnu.org; 14 Jul 2019 14:06:30 +0000 Received: from localhost ([127.0.0.1]:45543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmf92-0006Ao-MU for submit@debbugs.gnu.org; Sun, 14 Jul 2019 10:06:28 -0400 Received: from mail-io1-f53.google.com ([209.85.166.53]:36824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmf90-0006AW-BT; Sun, 14 Jul 2019 10:06:26 -0400 Received: by mail-io1-f53.google.com with SMTP id o9so30172223iom.3; Sun, 14 Jul 2019 07:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=VP5tKcek8YlZ+PY7UNX7tDDyTYGqXaMkGpPaOyQqM5I=; b=oSQDYqMxqHGgEqw/BSSqzrdM+gx6qp5Q/l08QOVo6gOvdIpFZhAg0X2nZIGhd6Loji N95gew63dFNK4jju+OwFXiqQ7m7TvZluYX9yiNGuM59CwgihRhA48g8IR5e4PRj0v0FO lRdrS0Oa1E/giNAXJqTfxZRn4dIlah9x2h5+BUU4w7DTHiwL2EvJscSgHeWgYqEmnG9P 3XWQpX6M+qyuqlgRzjXpyr4I1fD5PLeo0wuc/Rt5/BSSSaQH8Qx5eYug2BMPBOlDs72X aWttZBGyxMCGbvjU8hgniXzo5tZ1GMf9s6c/DF4wHF4v/ZaLrFSGyZh4lxwDv/Gif2Ze rFtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=VP5tKcek8YlZ+PY7UNX7tDDyTYGqXaMkGpPaOyQqM5I=; b=oTqNNzqMwwKFSnJpRM5FH8C3koBxUXJHSImHmoy0kzj3kGWG5Q2dJEjb5UvHzPWGbj eOIFues6mkc8gaNZghobqqgzJWALXN3cJVpWCv/T0SrrfDEwuMz5A0RDsUY43Pq4zPNY /1CViXTtOIhP/PRHvHDGjPvx61Y/UwvYLIBLGF27AQrAMWPumo/Hpr71tzaZ2pJqrBXe 4avaS+gh4woaIj/fKNGAv2aix6LzvNANABFSRdcsJrnC7hcI1RW2D/byc08dgGPGiAQh quX9u8FfB98L9j+H5UYpxYnQQxSzUvMie4NjwxY6b+5wKyeRRGpeSmZsm1FaWAbWQS5I xFrQ== X-Gm-Message-State: APjAAAX+8ebZ+qaGCwbUiiPYCfL5M3TsHmFtkUFg8IyCg3mYvwKWLXGL Jqjjw1ljE/I5MaWhozrvB2rtDt1B X-Google-Smtp-Source: APXvYqxK+y121DGyWdBJKfph1fZ/kUB9n1YfsYTRL9g9Yt+OvxhEOkDXnTXZwagDSWmCZ70y1rU8SA== X-Received: by 2002:a5d:8195:: with SMTP id u21mr18749531ion.260.1563113180735; Sun, 14 Jul 2019 07:06:20 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id n17sm12730077iog.63.2019.07.14.07.06.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 14 Jul 2019 07:06:19 -0700 (PDT) From: Noam Postavsky To: "Daniel Colascione" Subject: Re: bug#36447: 27.0.50; New "Unknown keyword" errors References: <875zon7x0a.fsf@web.de> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> <8736jjgovp.fsf@web.de> <87muho2mfn.fsf@gmail.com> <7c22ff8d30102b8e4c2d2a766c0cf60b.squirrel@dancol.org> Date: Sun, 14 Jul 2019 10:06:18 -0400 In-Reply-To: <7c22ff8d30102b8e4c2d2a766c0cf60b.squirrel@dancol.org> (Daniel Colascione's message of "Tue, 9 Jul 2019 20:01:14 -0700") Message-ID: <87ftn81zj9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36447 Cc: Michael Heerdegen , Lars Ingebrigtsen , 36447@debbugs.gnu.org, Pip Cet , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 36447 fixed close 36447 quit "Daniel Colascione" writes: >> It does seem like we've effectively given up pure space when we >> switched to pdumper. >> It's still kept around in the final >> executable, so we're wasting quite a bit of disk space on it... > > At least the executable pure space isn't paged in. I prefer not to waste > disk space, but wasting disk space without wasting memory is lower on my > list of priorities than other things. IMO, the main problem with the half-keeping of purespace is that it's confusing to people reading the code. At least some comments might be added? Anyway, closing the bug as the main problem has been resolved by now. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 10:39:24 2019 Received: (at control) by debbugs.gnu.org; 14 Jul 2019 14:39:24 +0000 Received: from localhost ([127.0.0.1]:45598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmfeu-0002sk-Jm for submit@debbugs.gnu.org; Sun, 14 Jul 2019 10:39:24 -0400 Received: from mail-io1-f47.google.com ([209.85.166.47]:34577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmfes-0002sG-Eu; Sun, 14 Jul 2019 10:39:22 -0400 Received: by mail-io1-f47.google.com with SMTP id k8so30254936iot.1; Sun, 14 Jul 2019 07:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/ARriLMDcME4mUlRk0ukxO4ZXl0D1ag1mMjqfAKHNEw=; b=RXkoU66SMAQSfnAB6K+UI0O0uWuzfHstyl+vlNgp505rf5w46f2IgE6Cy7jwCZbqbM x822R1Vy9ehWKPTWVIBeki1014l5IBtAs29kd7BnVUr59MNsg8gZw6sbdwiVKCUyD+0b /xD71weBRti8l0msL9X0oZ4hYn2jRVYIkD3gX/qjNO8ndwcXOar/dsF//zAaAjWolTtl yQwqCqpIrV5be37cZ2zIZbjw6OCtc9kzK73UowVF5IUrT2tbmTwrfZzlMmTjUm8fdQoc b0TVOdzs5Y9H+etSGN0HurJVw9oGPz6sv6LBOtdK8uONmKOc1CGEnHgoMXVCNi4hhr+v c4jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/ARriLMDcME4mUlRk0ukxO4ZXl0D1ag1mMjqfAKHNEw=; b=VCcEjg//lKR74iOw5J7hGA4XubTw2GofOS5KSKGjta47PCyBHspsyuR41nk6ERPpBF M5aRxbUpUIhupd/W3SO3/N4+o5q3PqH+qy8TJ/qbDRhcgx65qoygoATAloZJqnhabuuD IWr5+2b1bbD2ganS1/IU+OFf9uz/YAS5ip/dIzW4XGkTmH+Iot/rdI7Q7UHrNlWibZD4 +hJ7pkBkZrbsoitwUUwzax9qpCvbppI7RHy45mIY3zksxHL+fmnjdw+HVBPUPzuXxqso Z4d6b6GJXv3JrkR6MtntGiOVvIpi5WaWz1LO35PFM3M0qNtn8MS3b8CXA3TnnYPCAgnT GsVA== X-Gm-Message-State: APjAAAU6hUjjbhGCLZSUZsnwBcM9LypvOvcsCsqh23ppNfKUAT1ZGs5l 4VsS8fGSBBShX6L4BcPdhzGOB5LZ X-Google-Smtp-Source: APXvYqw25XRAlxclCOiDOphLgunrRqjvAr50DJNc0Xo7Im4iE9EbStKCn1QTQY+8R6+qSozs2WOjAQ== X-Received: by 2002:a6b:c98c:: with SMTP id z134mr19994480iof.276.1563115156523; Sun, 14 Jul 2019 07:39:16 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id j25sm18362674ioj.67.2019.07.14.07.39.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 14 Jul 2019 07:39:16 -0700 (PDT) From: Noam Postavsky To: Pip Cet Subject: Re: bug#36321: Error: Forgot to expand macro pcase--flip in (pcase--flip memql '(2 1) val) References: <87wohfp78l.fsf@igel.home> <87r27nuspb.fsf@gmail.com> <87o92rp12i.fsf@igel.home> <85h881eeez.fsf@gmail.com> Date: Sun, 14 Jul 2019 10:39:15 -0400 In-Reply-To: (Pip Cet's message of "Thu, 4 Jul 2019 21:00:27 +0000") Message-ID: <87a7dg1y0c.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: Andreas Schwab , 36321@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) forcemerge 36447 36321 quit Pip Cet writes: > On Thu, Jul 4, 2019 at 8:25 PM Noam Postavsky wrote: >> Andreas Schwab writes: >> > The error was introduced between >> > 8b379bbeca9b3765e2b1e948d9d9c90ab92ff4b6 and >> > 869cf5cbc0721bbe9e4df557f4ed3633fb13c05f >> >> I don't see anything plausible in that range. I wonder if this could be >> the same as Bug#36447. > > I rather suspect it is, too. Can we get our hands on an emacs binary > and an emacs.pdmp file from a failing build? By the timing of when this error popped up, I'm going to say it's most likely the same as 36447, so I'll go ahead and merge them. It should be fixed now, but if the error ever happens again, we'll know it's actually something else. From unknown Sun Jun 22 11:39:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 12 Aug 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator