From unknown Sun Jun 22 22:45:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36441: 26.2.90; Simplify dom-texts Resent-From: Xu Chunyang Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jun 2019 04:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36441 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 36441@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15618690544120 (code B ref -1); Sun, 30 Jun 2019 04:31:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 Jun 2019 04:30:54 +0000 Received: from localhost ([127.0.0.1]:45209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhRUM-000148-6S for submit@debbugs.gnu.org; Sun, 30 Jun 2019 00:30:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:55884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhRUK-00012C-7j for submit@debbugs.gnu.org; Sun, 30 Jun 2019 00:30:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53663) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhRUJ-0005Rs-3V for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 00:30:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhRUI-0003Vq-05 for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 00:30:51 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:47207) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hhRUF-0003HM-U7 for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 00:30:48 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id C485321C1C for ; Sun, 30 Jun 2019 00:30:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 30 Jun 2019 00:30:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xuchunyang.me; h=from:to:subject:date:message-id:mime-version:content-type; s= fm2; bh=op+7BD2cp3lTdzELi0OvcYvWuEo2xPT3N9NZ9Q5/LJ4=; b=aoY491Fr L4eAxXTYvzByqJRyqzqLHfpKLfUpNWEwMFu1bvhAwFfMFjeLIS0Hyq7XLoqV1JnS qL71apK7qHiaCu3fR4Y8vNdmp7UDUzllWdttu0oYR6siGgV3gQk6Rf/GqiRwjqtu RjWxkHx6Vpwd3+8I5MQTSox2c+aywr+5jY4TpzLiTI05WkjYxxMcsho2ah/ubg0c yZ8+c3ZRZFksHU1pHaMQR0WLiBXhO+wrrOJo7Yb48VUXueqm1EtpIZwIRZiFmDJH qakb6+6/ovDVzAhul1UVSatrFTX46cdNdTLdF5u2DknROq8B/soa/B+gplfhtfmM 5MV8Y3DF3vWWPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=op+7BD2cp3lTdzELi0OvcYvWuEo2x PT3N9NZ9Q5/LJ4=; b=RLU5h1FPmUfh2RR/UDxzPpTkQj6aLGKnsWrM6T0b4o/Ep I1vH6COyyoqrOfBRndMWZIzHDBUCJIMXjxrYgynIsxzY+omEdrZEnVsKSxBtezRm sL4GHBOSiPsnUgbkLcxFN1AQB/GYRub/bGm0EHSLurtrSzM33wm1Dx6zmffzZ7VY GtJgsLgJDWz0hK8yPCL+Y7KrrAqLgKZHhd+G6+7EWze+GckwtgyNSTjBa3LMa1cS 6fz+nA6NNa4vzTuygWANJGaJRGA7wIEeCK9yorIjB02l4dICNYNVcInwpT9tqyiE Hkf552GLyIdpPoF8TZLckFS9crSt+lSyvguVhWfxA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrvdefgdekfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufgffffkgggtsehttdertddtre dtnecuhfhrohhmpegiuhcuvehhuhhnhigrnhhguceomhgrihhlseiguhgthhhunhihrghn ghdrmhgvqeenucfkphepuddujedrleefrddvtdeirddufeefnecurfgrrhgrmhepmhgrih hlfhhrohhmpehmrghilhesgihutghhuhhnhigrnhhgrdhmvgenucevlhhushhtvghrufhi iigvpedt X-ME-Proxy: Received: from Chunyangs-MacBook-Air.local (unknown [117.93.206.133]) by mail.messagingengine.com (Postfix) with ESMTPA id 33DE180059 for ; Sun, 30 Jun 2019 00:30:24 -0400 (EDT) From: Xu Chunyang User-Agent: M-x report-emacs-bug Date: Sun, 30 Jun 2019 12:30:22 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.28 X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) In the dom-texts function (mapconcat 'identity (mapcar ...) ...) can be simplified (mapconcat ...) diff -u --label /Users/xcy/src/emacs-mac/lisp/dom.el --label \#\ /Users/xcy/src/emacs-mac/lisp/dom.el /var/folders/7f/s191h4q97p90374yw15ssrs00000gn/T/buffer-content-jql2ad --- /Users/xcy/src/emacs-mac/lisp/dom.el +++ # @@ -79,13 +79,11 @@ (defun dom-texts (node &optional separator) "Return all textual data under NODE concatenated with SEPARATOR in-between." (mapconcat - 'identity - (mapcar - (lambda (elem) - (if (stringp elem) - elem - (dom-texts elem separator))) - (dom-children node)) + (lambda (elem) + (if (stringp elem) + elem + (dom-texts elem separator))) + (dom-children node) (or separator " "))) (defun dom-child-by-tag (dom tag) Diff finished. Sun Jun 30 12:23:43 2019 From unknown Sun Jun 22 22:45:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36441: 26.2.90; Simplify dom-texts Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jul 2019 18:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36441 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Xu Chunyang Cc: 36441@debbugs.gnu.org Received: via spool by 36441-submit@debbugs.gnu.org id=B36441.156243862926825 (code B ref 36441); Sat, 06 Jul 2019 18:44:01 +0000 Received: (at 36441) by debbugs.gnu.org; 6 Jul 2019 18:43:49 +0000 Received: from localhost ([127.0.0.1]:55894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjpf3-0006yX-3k for submit@debbugs.gnu.org; Sat, 06 Jul 2019 14:43:49 -0400 Received: from mail-io1-f50.google.com ([209.85.166.50]:34979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjpf0-0006yC-Mg; Sat, 06 Jul 2019 14:43:47 -0400 Received: by mail-io1-f50.google.com with SMTP id m24so16510075ioo.2; Sat, 06 Jul 2019 11:43:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=DDtuDFIUzKZowZ9FAfnQczuLTN6pqQNtwwgJdVTmFb8=; b=JW8XVK0Ea3a2po2GiG7DMHA8LEcfaLWZqb/BjE0tneOnuCToTjqUFZzp4hGgdSadmx DOYsJxaiFdLc8QE54x9QQF8MnVoRSNeSKGgaI0CT8IWSl7JeGg4q04n1O5zlmBvcRSFt +IDLduQNwILfg6ip9WcRBJ6gSuo1nbPlsDDpN6Eyv22djdosnnxdoTZZ+GZ69ksL8hsW 0OpAht/8UyjPPOguJBtlZTEn1hWPiY9NpUClKsTno7YulEM3dl3/pyAWauugo8AGXD5d q31PMMtctOX+Qfkqq/wgkpiqtGNimebKBBIKSuJIrMNqIfmT9xOswIXHgNtuPwdLgnmW 5o0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=DDtuDFIUzKZowZ9FAfnQczuLTN6pqQNtwwgJdVTmFb8=; b=Gnaxpt5LRRVmv6RsjiCipSrkxENDlnDmwH5nlY4f7wuqsYPpj6JOAP3YWx8BJbu5MO Y5kmYtCxgp4hKFhBUbB9d035yF5NNEs1AgfjhwgAq78gFp+b2py1S+MqjTAsT+S4DKo0 neF4U0Ds+0yu+JvBnJjYkje+Mp4EaDFM/D7MVtBLGpmSIT1AOBSHZtswSyMg83mCWm9a SMBmV6j0UdKkNqKyNBjCaq6R88HX0UHbEzJJrUZZlvggUjpqvBv/GJaVFe6QV7QU9VKU b7vgLzivKM6TzEzFpXJRj6PSRTIw+KtL0S41fgfPu0GxiMw4syV7zCrSnP/YghWCqPnq N8Tg== X-Gm-Message-State: APjAAAUjuYCZukXwZVHDZvteKoGTbbyrGxQWbpT9TZc37dsF2i5dDas7 1fLR1AK3JlE+YkcIfoEaX1J0rmv0 X-Google-Smtp-Source: APXvYqzIelyl1cwM4fXfWGBscZoD+Ei1poS/gySuNt8eVgkcLAGPBpB8WXkl5ov+I3hHO6V5+p0pag== X-Received: by 2002:a02:77d4:: with SMTP id g203mr6234611jac.144.1562438620979; Sat, 06 Jul 2019 11:43:40 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id v10sm13756134iob.43.2019.07.06.11.43.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 06 Jul 2019 11:43:40 -0700 (PDT) From: Noam Postavsky References: Date: Sat, 06 Jul 2019 14:43:40 -0400 In-Reply-To: (Xu Chunyang's message of "Sun, 30 Jun 2019 12:30:22 +0800") Message-ID: <87ef333swz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 36441 minor tags 36441 fixed close 36441 27.1 quit Xu Chunyang writes: > In the dom-texts function > > (mapconcat 'identity (mapcar ...) ...) > > can be simplified > > (mapconcat ...) Right, applied on master. d07dd64fd0 2019-07-06T14:34:47-04:00 "* lisp/dom.el (dom-texts): Simplify (Bug#36441)." https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d07dd64fd0476e0346d2de65b965193703ae6e7a