Subject: bug#36429: closed (Re: [bug#36429] [PATCH] profiles: Adjust packages->manifest pattern for inferior packages.)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 03 Jul 2019 09:17:02 +0000

Your bug report

#36429: [PATCH] profiles: Adjust packages->manifest pattern for inferior packages.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
36429: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36429
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#36429] [PATCH] profiles: Adjust packages->manifest pattern for inferior packages.
From: Ludovic Courtès <[email-masked]>
To: Kyle Meyer <[email-masked]>
Cc: [email-masked]
Date: Wed, 03 Jul 2019 11:16:36 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello Kyle,

Kyle Meyer <[email-masked]> skribis:

> * guix/profiles.scm (packages->manifest): Add package? predicate to `(package
> output)' pattern to avoid incorrectly matching `(inferior-package output)',
> which should be handled by a later clause.

Good catch.  Applied, thanks!

Ludo’.

Subject: [PATCH] profiles: Adjust packages->manifest pattern for inferior packages.
From: Kyle Meyer <[email-masked]>
To: [email-masked]
Cc: Kyle Meyer <[email-masked]>
Date: Sat, 29 Jun 2019 01:50:15 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

* guix/profiles.scm (packages->manifest): Add package? predicate to `(package
output)' pattern to avoid incorrectly matching `(inferior-package output)',
which should be handled by a later clause.
---
 guix/profiles.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/guix/profiles.scm b/guix/profiles.scm
index dfc9ba1ca0..f5c863945c 100644
--- a/guix/profiles.scm
+++ b/guix/profiles.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2016 Chris Marusich <[email-masked]>
 ;;; Copyright © 2017 Huang Ying <[email-masked]>
 ;;; Copyright © 2017 Maxim Cournoyer <[email-masked]>
+;;; Copyright © 2019 Kyle Meyer <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -337,7 +338,7 @@ (define (packages->manifest packages)
 
   (manifest
    (map (match-lambda
-          ((package output)
+          (((? package? package) output)
            (package->manifest-entry package output))
           ((? package? package)
            (package->manifest-entry package))
-- 
2.22.0