GNU bug report logs - #36415
[PATCH] gnu: Add qlogo.

Previous Next

Full log

Message #20 received at 36415 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 36415 <at> debbugs.gnu.org
Subject: Re: [bug#36415] [PATCH] gnu: Add qlogo.
Date: Thu, 04 Jul 2019 22:10:04 +0530

[Message part 1 (text/plain, inline)]

> On Fri, Jun 28, 2019 at 01:33:57PM +0530, Arun Isaac wrote:
>> +         ;; The check phase rebuilds the source for tests. So, it needs to be
>> +         ;; run after the install phase has installed the outputs of the build
>> +         ;; phase.
>> +         (delete 'check)
>> +         (add-after 'install 'check
>> +           (lambda _
>> +             ;; Clean files created by the build phase.
>> +             (invoke "make" "clean")
>> +             ;; QLogo tries to create its "dribble file" in the home
>> +             ;; directory. So, set HOME.
>> +             (setenv "HOME" "/tmp")
>> +             ;; Build and run tests.
>> +             (invoke "qmake" "TestQLogo.pro")
>
> Doesn't this efectively just rebuild the binary we just built in the
> 'configure and 'build phases?

No. There are two qmake project files -- QLogo.pro and
TestQLogo.pro. QLogo.pro builds the "QLogo" executable and TestQLogo.pro
builds the "testqlogo" executable. "QLogo" is the actual qlogo
executable that we install. "testqlogo" simply runs the tests.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.