GNU bug report logs - #36415
[PATCH] gnu: Add qlogo.

Previous Next

Package: guix-patches;

Reported by: Arun Isaac <arunisaac <at> systemreboot.net>

Date: Fri, 28 Jun 2019 08:05:02 UTC

Severity: normal

Tags: patch

Done: Arun Isaac <arunisaac <at> systemreboot.net>

Bug is archived. No further changes may be made.

Full log


Message #11 received at 36415 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 36415 <at> debbugs.gnu.org
Subject: Re: [bug#36415] [PATCH] gnu: Add qlogo.
Date: Tue, 2 Jul 2019 10:21:32 +0300
[Message part 1 (text/plain, inline)]
On Fri, Jun 28, 2019 at 01:33:57PM +0530, Arun Isaac wrote:
> +         ;; The check phase rebuilds the source for tests. So, it needs to be
> +         ;; run after the install phase has installed the outputs of the build
> +         ;; phase.
> +         (delete 'check)
> +         (add-after 'install 'check
> +           (lambda _
> +             ;; Clean files created by the build phase.
> +             (invoke "make" "clean")
> +             ;; QLogo tries to create its "dribble file" in the home
> +             ;; directory. So, set HOME.
> +             (setenv "HOME" "/tmp")
> +             ;; Build and run tests.
> +             (invoke "qmake" "TestQLogo.pro")

Doesn't this efectively just rebuild the binary we just built in the
'configure and 'build phases?

> +             (invoke "make" "-j" (number->string (parallel-job-count)))
> +             (invoke "./testqlogo"))))))
> 

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 6 years and 19 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.