GNU bug report logs - #36404
[PATCH 0/6] Add 'guix deploy'.

Previous Next

Full log

Message #53 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
To: guix-patches <at> gnu.org
Cc: 36404 <at> debbugs.gnu.org, "Thompson, David" <dthompson2 <at> worcester.edu>
Subject: Re: [bug#36404] [PATCH 1/5] ssh: Add 'identity' keyword to
 'open-ssh-session'.
Date: Sat, 29 Jun 2019 10:42:40 -0400

Jakob L. Kreuze writes:

> * guix/ssh.scm (open-ssh-session): Add 'identity' keyword argument.
> ---
>  guix/ssh.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/guix/ssh.scm b/guix/ssh.scm
> index 9b9baf54ea..a2387564a4 100644
> --- a/guix/ssh.scm
> +++ b/guix/ssh.scm
> @@ -57,12 +57,13 @@
>  (define %compression
>    "zlib <at> openssh.com,zlib")
>  
> -(define* (open-ssh-session host #:key user port
> +(define* (open-ssh-session host #:key user port identity
>                             (compression %compression))
>    "Open an SSH session for HOST and return it.  When USER and PORT are #f, use
>  default values or whatever '~/.ssh/config' specifies; otherwise use them.
>  Throw an error on failure."

Looks good, but could you add to the docstring here explaining the new
identity keyword?

>    (let ((session (make-session #:user user
> +                               #:identity identity
>                                 #:host host
>                                 #:port port
>                                 #:timeout 10       ;seconds

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.