GNU bug report logs - #36404
[PATCH 0/6] Add 'guix deploy'.

Previous Next

Full log

View this message in rfc822 format

From: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
To: Kyle Meyer <kyle <at> kyleam.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 36404 <at> debbugs.gnu.org
Subject: [bug#36404] [PATCH 4/4] doc: Add section for 'guix deploy'.
Date: Tue, 02 Jul 2019 12:45:30 -0400

[Message part 1 (text/plain, inline)]

Hi Kyle,

Kyle Meyer <kyle <at> kyleam.com> writes:

> nitpick: Following the style used elsewhere in guix.texi, I think this
> "--" and the closing one below should be "---" with no surrounding
> spaces.

Yep, you're right. I cracked open the Texinfo manual and there indeed is
a difference in how the two are parsed: the former is treated as an en
dash while the latter is treated as an em dash. Thanks for pointing that
out!

> This last sentence doesn't quite parse for me.  Perhaps
>
>   A more complex deployment may involve, for example, starting virtual
>   machines through a VPS provider.  In such as case, a different
>   @var{environment} type would be used.
>
> ?

That's much clearer wording. I think I might use that verbatim. Also, I
should probably be using two spaces to end my sentences as you did there
:)

> Repeated "only".

Nice catch!

> Also, as a meta nit: It'd be helpful if you'd mark updated patch
> series with the iteration count (e.g., v3). You can do this with
> git-format-patch's --reroll-count option.

Oh awesome, I'll be sure to start using that.

Thanks for the comments and the kind words,
Jakob

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.