GNU bug report logs - #36403
27.0.50; Trivial image.c bugs

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: Alan Third <alan <at> idiocy.org>, 36403 <at> debbugs.gnu.org, Pip Cet <pipcet <at> gmail.com>
Subject: bug#36403: 27.0.50; Trivial image.c bugs
Date: Tue, 04 Oct 2022 16:06:28 +0200

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> Which means image-test-circular-specs signals:
>
>   (circular-list (:dummy . #0))
>
> So how important is it to support image specs with circular property
> values?  Should the test be marked :expected-result :failed?

Hm...  don't know.

> -     (setcdr circ1 circ1)
> -     (setcdr circ2 circ2)
> -     (and (equal (image-size spec1 t) (cons 1 1))
> -          (equal (image-size spec2 t) (cons 1 1))))))
> +    (setcdr circ1 circ1)
> +    (setcdr circ2 circ2)
> +    (should (equal (image-size spec1 t) '(1 . 1)))
> +    (should (equal (image-size spec2 t) '(1 . 1)))))

(cons 1 1) is not eq to (cons 1 1), but '(1 . 1) may or may not be eq to
'(1 . 1) (depending on whether compiled or phase of the moon), which may
be why that code is written that way?  But in this case, I can't see how
it would make a difference...

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.