From unknown Sun Jun 22 04:02:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36403: 27.0.50; Trivial image.c bugs Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2019 16:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 36403@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.156165293931792 (code B ref -1); Thu, 27 Jun 2019 16:29:01 +0000 Received: (at submit) by debbugs.gnu.org; 27 Jun 2019 16:28:59 +0000 Received: from localhost ([127.0.0.1]:39406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgXGd-0008Gi-0b for submit@debbugs.gnu.org; Thu, 27 Jun 2019 12:28:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:60884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgXGa-0008Ga-QT for submit@debbugs.gnu.org; Thu, 27 Jun 2019 12:28:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48510) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgXGY-0007Oc-JR for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 12:28:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgXGW-0004LF-Tm for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 12:28:54 -0400 Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]:38163) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hgXGV-0004D8-2I for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 12:28:52 -0400 Received: by mail-ot1-x335.google.com with SMTP id d17so2915561oth.5 for ; Thu, 27 Jun 2019 09:28:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=lCAhHDElJ3zXhFmPd8EtLp3sEtI5nFRi2+i9fGTCIyc=; b=AfSX3xEo6U1QW9fwls45w5zR0crWtFAcVjVYQ5qCCAopwKbdEiX/Ud5e/3hkJvKV6L 5Uy/7Kx3BSgKcPOXwRFq51GAX71AEFsjxnyIDoyAHXDf6x7AQ8N8rzRcXW8xbwacb+Sy D6BeTLR5YM9zfZ6G3gSO6Fut4PZ87Stf8QLRAZF6Zh5LrMPw4dbxjAncLQeeg8kg3tN+ /GNShgaU5UYDvMKOHU/w712YTvZ1pDFYtaWHOMeJzbvyVUV029/1Wl0r2M4Sv/LoUnTS wIP+jOQ1goQydmfdqunq38imqDjlCEGn1TJC4Lx8FtY3kkADa2b+fCIBYxkfFpnmulQO WpwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=lCAhHDElJ3zXhFmPd8EtLp3sEtI5nFRi2+i9fGTCIyc=; b=GO9kFM4sOF1sXqd+5BKTnMa0dW3po8FO67PvVjNKINKyq3OoUhC13mUPMWRKtvV2Nd 6qQeLyTnHEZukgTC7yFaIdW1k168KtzqEnY/Ha6ViUhEtF3lEQ4caOqkf5bNtaBNz8DJ 5aYKzx5aPu9/pc/jhGzv61GAnviK0g92PiRBGp4qhNE2bA8I+mVpaP92/vNz4izdrkRb WogBOFdsFt93V3evjYJ/Zb/sdFBHfWicea+BWRHFoXFpM9i6W1tzYWFWXl0LXT6yIPzr VzuVt1OZeqojKZyBvHKcqvdwFYeapCBgMbAnp2/RIRrg0JXqPR1qyzyMEIrUYq6a0nfO VLkQ== X-Gm-Message-State: APjAAAVp5pktp3L0V1QRX4nMwRFGat+n9gr2JkrXus1afZSG0jfBJO+o x64B1xbVlajdI3lBcTLutJSM/HOeJAadozaPFWPRqtvT3po= X-Google-Smtp-Source: APXvYqwQElH3Wu52IA4yiAYkHNmr9ClRbTfsNVwtQ7z7plP2n+Ej2Lu9EBc1OZi8yhxBLwQswJq7SUWB3q4fPu9PVFY= X-Received: by 2002:a9d:664c:: with SMTP id q12mr3799117otm.175.1561652922050; Thu, 27 Jun 2019 09:28:42 -0700 (PDT) MIME-Version: 1.0 From: Pip Cet Date: Thu, 27 Jun 2019 16:28:05 +0000 Message-ID: Content-Type: multipart/mixed; boundary="000000000000aef19a058c50a75e" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::335 X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000aef19a058c50a75e Content-Type: text/plain; charset="UTF-8" These are all in the category "Lisp code does something silly, the image code breaks". (let ((l `(image :type xbm :type xbm :height 1 :width 1 :data ,(bool-vector t)))) (insert-image l)) inserts an image. It should consider the spec erroneous. -- (let ((tail (cons :invalid nil))) (setcdr tail tail) (insert-image `(image :type xbm . ,tail))) causes an infinite loop. It should be considered invalid. -- (insert-image `(image :dummy :type :type xbm :height 1 :width 1 :data ,(bool-vector t))) produces an error. It should arguably behave the same as (insert-image `(image :dummy :dummy :type xbm :height 1 :width 1 :data ,(bool-vector t))) -- (let* ((circ1 (cons :dummy nil)) (circ2 (cons :dummy nil)) (spec1 `(image :type xbm :width 1 :height 1 :data ,(bool-vector 1) :ignored ,circ1)) (spec2 `(image :type xbm :width 1 :height 1 :data ,(bool-vector 1) :ignored ,circ2))) (setcdr circ1 circ1) (setcdr circ2 circ2) (insert-image spec1) (insert-image spec2)) livelocks emacs somehow. It should...I don't know. Abort because the spec is circular? Not compare specs using Fequal? -- (insert-image `(image :type postscript :pt-width 100 :pt-height 100 :ascent 0 :bounding-box (0 0 100 100) :file "dummy.ps" :loader ,(lambda (frame spec width height id colors) (setf (plist-get spec :ascent) -1)))) livelocks Emacs in the display code. It should automatically switch to the buffer called "image.c" and rewrite the code there not to call Lisp. -- These probably aren't worth fixing in their own right, but someone might think image.c is a good place to take plist handling code from... I think with the exception of the contrived last example, these are all easy to fix, but a bit harder to fix well. I've tried to do the former, for now, but I'd welcome any help for me to do the latter. --000000000000aef19a058c50a75e Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-minor-image-bugs.patch" Content-Disposition: attachment; filename="0001-Fix-minor-image-bugs.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxevnl2p0 RnJvbSBlZWYyMGUwMmQyNWExNmY3MWFkMDkwNDY0NGQ2ODQ1MGE2MTgxZmUyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBUaHUs IDI3IEp1biAyMDE5IDE2OjE5OjI1ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gRml4IG1pbm9yIGlt YWdlIGJ1Z3MuCgogICAgKiBzcmMvaW1hZ2UuYyAodmFsaWRfaW1hZ2VfcCk6IERvbid0IGNoZWNr IHZhbHVlIGVsZW1lbnRzIG9mIHRoZSBwbGlzdApmb3Iga2V5IGVxdWFsaXR5LgoocGFyc2VfaW1h Z2Vfc3BlYyk6IFVzZSBGT1JfRUFDSF9UQUlMX1NBRkUgdG8gYWJvcnQgZm9yIGNpcmN1bGFyCnN0 cnVjdHVyZXMuIEZpeCBvZmYtYnktb25lIGVycm9yLgooaW1hZ2Vfc3BlY192YWx1ZSk6IEhhbmRs ZSBjaXJjdWxhciBzdHJ1Y3R1cmVzLgooZXF1YWxfbGlzdHMpOiBJbnRyb2R1Y2U7IGNvbXBhcmVz IHR3byBsaXN0cycgZWxlbWVudHMgd2l0aCBgZXEnCihzZWFyY2hfaW1hZ2VfY2FjaGUpOiBEb24n dCBjYWxsIEZlcXVhbCBmcm9tIHJlZGlzcGxheSBjb2RlLgotLS0KIHNyYy9pbWFnZS5jIHwgNzMg KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0KIDEg ZmlsZSBjaGFuZ2VkLCA0OCBpbnNlcnRpb25zKCspLCAyNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9zcmMvaW1hZ2UuYyBiL3NyYy9pbWFnZS5jCmluZGV4IDdiNjQ4YzQ2YWUuLjg5YmEyYjlk MjkgMTAwNjQ0Ci0tLSBhL3NyYy9pbWFnZS5jCisrKyBiL3NyYy9pbWFnZS5jCkBAIC04MDAsMTcg KzgwMCwyMiBAQCB2YWxpZF9pbWFnZV9wIChMaXNwX09iamVjdCBvYmplY3QpCiAgICAgewogICAg ICAgTGlzcF9PYmplY3QgdGFpbCA9IFhDRFIgKG9iamVjdCk7CiAgICAgICBGT1JfRUFDSF9UQUlM X1NBRkUgKHRhaWwpCi0JaWYgKEVRIChYQ0FSICh0YWlsKSwgUUN0eXBlKSkKLQkgIHsKLQkgICAg dGFpbCA9IFhDRFIgKHRhaWwpOwotCSAgICBpZiAoQ09OU1AgKHRhaWwpKQotCSAgICAgIHsKLQkJ c3RydWN0IGltYWdlX3R5cGUgY29uc3QgKnR5cGUgPSBsb29rdXBfaW1hZ2VfdHlwZSAoWENBUiAo dGFpbCkpOwotCQlpZiAodHlwZSkKLQkJICByZXR1cm4gdHlwZS0+dmFsaWRfcCAob2JqZWN0KTsK LQkgICAgICB9Ci0JICAgIGJyZWFrOwotCSAgfQorCXsKKwkgIGlmIChFUSAoWENBUiAodGFpbCks IFFDdHlwZSkpCisJICAgIHsKKwkgICAgICB0YWlsID0gWENEUiAodGFpbCk7CisJICAgICAgaWYg KENPTlNQICh0YWlsKSkKKwkJeworCQkgIHN0cnVjdCBpbWFnZV90eXBlIGNvbnN0ICp0eXBlID0g bG9va3VwX2ltYWdlX3R5cGUgKFhDQVIgKHRhaWwpKTsKKwkJICBpZiAodHlwZSkKKwkJICAgIHJl dHVybiB0eXBlLT52YWxpZF9wIChvYmplY3QpOworCQl9CisJICAgICAgYnJlYWs7CisJICAgIH0K KwkgIHRhaWwgPSBYQ0RSICh0YWlsKTsKKwkgIGlmICghIENPTlNQICh0YWlsKSkKKwkgICAgcmV0 dXJuIGZhbHNlOworCX0KICAgICB9CiAKICAgcmV0dXJuIGZhbHNlOwpAQCAtODk3LDcgKzkwMiw3 IEBAIHBhcnNlX2ltYWdlX3NwZWMgKExpc3BfT2JqZWN0IHNwZWMsIHN0cnVjdCBpbWFnZV9rZXl3 b3JkICprZXl3b3JkcywKICAgICByZXR1cm4gMDsKIAogICBwbGlzdCA9IFhDRFIgKHNwZWMpOwot ICB3aGlsZSAoQ09OU1AgKHBsaXN0KSkKKyAgRk9SX0VBQ0hfVEFJTF9TQUZFIChwbGlzdCkKICAg ICB7CiAgICAgICBMaXNwX09iamVjdCBrZXksIHZhbHVlOwogCkBAIC05MTEsNyArOTE2LDYgQEAg cGFyc2VfaW1hZ2Vfc3BlYyAoTGlzcF9PYmplY3Qgc3BlYywgc3RydWN0IGltYWdlX2tleXdvcmQg KmtleXdvcmRzLAogICAgICAgaWYgKCFDT05TUCAocGxpc3QpKQogCXJldHVybiAwOwogICAgICAg dmFsdWUgPSBYQ0FSIChwbGlzdCk7Ci0gICAgICBwbGlzdCA9IFhDRFIgKHBsaXN0KTsKIAogICAg ICAgLyogRmluZCBrZXkgaW4gS0VZV09SRFMuICBFcnJvciBpZiBub3QgZm91bmQuICAqLwogICAg ICAgZm9yIChpID0gMDsgaSA8IG5rZXl3b3JkczsgKytpKQpAQCAtOTIxLDEwICs5MjUsMTAgQEAg cGFyc2VfaW1hZ2Vfc3BlYyAoTGlzcF9PYmplY3Qgc3BlYywgc3RydWN0IGltYWdlX2tleXdvcmQg KmtleXdvcmRzLAogICAgICAgaWYgKGkgPT0gbmtleXdvcmRzKQogCWNvbnRpbnVlOwogCi0gICAg ICAvKiBSZWNvcmQgdGhhdCB3ZSByZWNvZ25pemVkIHRoZSBrZXl3b3JkLiAgSWYgYSBrZXl3b3Jk cworICAgICAgLyogUmVjb3JkIHRoYXQgd2UgcmVjb2duaXplZCB0aGUga2V5d29yZC4gIElmIGEg a2V5d29yZAogCSB3YXMgZm91bmQgbW9yZSB0aGFuIG9uY2UsIGl0J3MgYW4gZXJyb3IuICAqLwog ICAgICAga2V5d29yZHNbaV0udmFsdWUgPSB2YWx1ZTsKLSAgICAgIGlmIChrZXl3b3Jkc1tpXS5j b3VudCA+IDEpCisgICAgICBpZiAoa2V5d29yZHNbaV0uY291bnQgPiAwKQogCXJldHVybiAwOwog ICAgICAgKytrZXl3b3Jkc1tpXS5jb3VudDsKIApAQCAtMTAwNiwxNCArMTAxMCwyMiBAQCBwYXJz ZV9pbWFnZV9zcGVjIChMaXNwX09iamVjdCBzcGVjLCBzdHJ1Y3QgaW1hZ2Vfa2V5d29yZCAqa2V5 d29yZHMsCiAKICAgICAgIGlmIChFUSAoa2V5LCBRQ3R5cGUpICYmICFFUSAodHlwZSwgdmFsdWUp KQogCXJldHVybiAwOwotICAgIH0KIAotICAvKiBDaGVjayB0aGF0IGFsbCBtYW5kYXRvcnkgZmll bGRzIGFyZSBwcmVzZW50LiAgKi8KLSAgZm9yIChpID0gMDsgaSA8IG5rZXl3b3JkczsgKytpKQot ICAgIGlmIChrZXl3b3Jkc1tpXS5tYW5kYXRvcnlfcCAmJiBrZXl3b3Jkc1tpXS5jb3VudCA9PSAw KQotICAgICAgcmV0dXJuIDA7CisgICAgICBpZiAoRVEgKFhDRFIgKHBsaXN0KSwgUW5pbCkpCisJ eworCSAgLyogQ2hlY2sgdGhhdCBhbGwgbWFuZGF0b3J5IGZpZWxkcyBhcmUgcHJlc2VudC4gICov CisJICBmb3IgKGkgPSAwOyBpIDwgbmtleXdvcmRzOyArK2kpCisJICAgIGlmIChrZXl3b3Jkc1tp XS5tYW5kYXRvcnlfcCAmJiBrZXl3b3Jkc1tpXS5jb3VudCA9PSAwKQorCSAgICAgIHJldHVybiAw OworCisJICByZXR1cm4gMTsKKwl9CisKKyAgICAgIGlmICghIENPTlNQIChwbGlzdCkpCisJcmV0 dXJuIDA7CisgICAgfQogCi0gIHJldHVybiBOSUxQIChwbGlzdCk7CisgIHJldHVybiAwOwogfQog CiAKQEAgLTEwMjgsOSArMTA0MCw4IEBAIGltYWdlX3NwZWNfdmFsdWUgKExpc3BfT2JqZWN0IHNw ZWMsIExpc3BfT2JqZWN0IGtleSwgYm9vbCAqZm91bmQpCiAKICAgZWFzc2VydCAodmFsaWRfaW1h Z2VfcCAoc3BlYykpOwogCi0gIGZvciAodGFpbCA9IFhDRFIgKHNwZWMpOwotICAgICAgIENPTlNQ ICh0YWlsKSAmJiBDT05TUCAoWENEUiAodGFpbCkpOwotICAgICAgIHRhaWwgPSBYQ0RSIChYQ0RS ICh0YWlsKSkpCisgIHRhaWwgPSBYQ0RSIChzcGVjKTsKKyAgRk9SX0VBQ0hfVEFJTF9TQUZFICh0 YWlsKQogICAgIHsKICAgICAgIGlmIChFUSAoWENBUiAodGFpbCksIGtleSkpCiAJewpAQCAtMTAz OCw2ICsxMDQ5LDkgQEAgaW1hZ2Vfc3BlY192YWx1ZSAoTGlzcF9PYmplY3Qgc3BlYywgTGlzcF9P YmplY3Qga2V5LCBib29sICpmb3VuZCkKIAkgICAgKmZvdW5kID0gMTsKIAkgIHJldHVybiBYQ0FS IChYQ0RSICh0YWlsKSk7CiAJfQorICAgICAgdGFpbCA9IFhDRFIgKHRhaWwpOworICAgICAgaWYg KCEgQ09OU1AgKHRhaWwpKQorCWJyZWFrOwogICAgIH0KIAogICBpZiAoZm91bmQpCkBAIC0xNTcy LDYgKzE1ODYsMTUgQEAgbWFrZV9pbWFnZV9jYWNoZSAodm9pZCkKICAgcmV0dXJuIGM7CiB9CiAK Ky8qIENvbXBhcmUgdHdvIChub24tY2lyY3VsYXIpIGxpc3RzLCBjb21wYXJpbmcgZWFjaCBlbGVt ZW50IHdpdGggYGVxJy4gKi8KK3N0YXRpYyBib29sCitlcXVhbF9saXN0cyAoTGlzcF9PYmplY3Qg YSwgTGlzcF9PYmplY3QgYikKK3sKKyAgd2hpbGUgKENPTlNQIChhKSAmJiBDT05TUCAoYikgJiYg RmVxIChYQ0FSIChhKSwgWENBUiAoYikpKQorICAgIGEgPSBYQ0RSIChhKSwgYiA9IFhDRFIgKGIp OworCisgIHJldHVybiBFUSAoYSwgYik7Cit9CiAKIC8qIEZpbmQgYW4gaW1hZ2UgbWF0Y2hpbmcg U1BFQyBpbiB0aGUgY2FjaGUsIGFuZCByZXR1cm4gaXQuICBJZiBubwogICAgaW1hZ2UgaXMgZm91 bmQsIHJldHVybiBOVUxMLiAgKi8KQEAgLTE1OTgsNyArMTYyMSw3IEBAIHNlYXJjaF9pbWFnZV9j YWNoZSAoc3RydWN0IGZyYW1lICpmLCBMaXNwX09iamVjdCBzcGVjLCBFTUFDU19VSU5UIGhhc2gp CiAKICAgZm9yIChpbWcgPSBjLT5idWNrZXRzW2ldOyBpbWc7IGltZyA9IGltZy0+bmV4dCkKICAg ICBpZiAoaW1nLT5oYXNoID09IGhhc2gKLQkmJiAhTklMUCAoRmVxdWFsIChpbWctPnNwZWMsIHNw ZWMpKQorCSYmICFlcXVhbF9saXN0cyAoaW1nLT5zcGVjLCBzcGVjKQogCSYmIGltZy0+ZnJhbWVf Zm9yZWdyb3VuZCA9PSBGUkFNRV9GT1JFR1JPVU5EX1BJWEVMIChmKQogCSYmIGltZy0+ZnJhbWVf YmFja2dyb3VuZCA9PSBGUkFNRV9CQUNLR1JPVU5EX1BJWEVMIChmKSkKICAgICAgIGJyZWFrOwot LSAKMi4yMC4xCgo= --000000000000aef19a058c50a75e-- From unknown Sun Jun 22 04:02:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36403: 27.0.50; Trivial image.c bugs Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2019 17:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Pip Cet Cc: 36403@debbugs.gnu.org Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.156165723615884 (code B ref 36403); Thu, 27 Jun 2019 17:41:01 +0000 Received: (at 36403) by debbugs.gnu.org; 27 Jun 2019 17:40:36 +0000 Received: from localhost ([127.0.0.1]:39522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgYNv-000488-UP for submit@debbugs.gnu.org; Thu, 27 Jun 2019 13:40:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgYNt-00047v-O1 for 36403@debbugs.gnu.org; Thu, 27 Jun 2019 13:40:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55447) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hgYNo-0000UX-J1; Thu, 27 Jun 2019 13:40:28 -0400 Received: from [176.228.60.248] (port=4058 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hgYNm-0008Bv-HV; Thu, 27 Jun 2019 13:40:28 -0400 Date: Thu, 27 Jun 2019 20:40:07 +0300 Message-Id: <83pnmzhqq0.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Pip Cet on Thu, 27 Jun 2019 16:28:05 +0000) References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Pip Cet > Date: Thu, 27 Jun 2019 16:28:05 +0000 > > I think with the exception of the contrived last example, these are > all easy to fix, but a bit harder to fix well. I've tried to do the > former, for now, but I'd welcome any help for me to do the latter. Thanks, but please also add tests which verify that these problems no longer happen after the fix. From unknown Sun Jun 22 04:02:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36403: 27.0.50; Trivial image.c bugs Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jun 2019 15:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 36403@debbugs.gnu.org Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.156173437631610 (code B ref 36403); Fri, 28 Jun 2019 15:07:01 +0000 Received: (at 36403) by debbugs.gnu.org; 28 Jun 2019 15:06:16 +0000 Received: from localhost ([127.0.0.1]:42801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgsS7-0008Dm-Ov for submit@debbugs.gnu.org; Fri, 28 Jun 2019 11:06:16 -0400 Received: from mail-oi1-f173.google.com ([209.85.167.173]:42084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgsS5-0008DU-6S for 36403@debbugs.gnu.org; Fri, 28 Jun 2019 11:06:13 -0400 Received: by mail-oi1-f173.google.com with SMTP id s184so4488048oie.9 for <36403@debbugs.gnu.org>; Fri, 28 Jun 2019 08:06:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zncsq2Q2A7E8lZtk2SgKIkg+kDu+dG1eWUySLVMOEeE=; b=WYzvvKWzhxkBjIrebyBaUbTG9VoHyjjCAY4WiE9QvryMXg3MCi36RUk49fqAywUiTc cSsK1wKOwgtgZlsQDpkYemd4GzM3ge7XyTVKAx0p00741MWHMT4sLSEfrq18AQbaF9aJ 0mionoIaCVffkqu9A99ePpcsc9xUDvtVPhMcEIsyQQGZe3gCOvAiwPOmxr/RTtbWB5Dx OgrQmoS5ks7fWJkOSQtOaHR5sLhe69XMw2L1PJSFV3uVYQeeqMeRXIv/lajaJcnHjB6q sVcoSPNRp2GZsB7sAs5tY8A+MumKutRr0Zet3ly7jZP3J8mD9mtJgQ8XqtHhT30VG4Sx tfMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zncsq2Q2A7E8lZtk2SgKIkg+kDu+dG1eWUySLVMOEeE=; b=WEueq1NBjd073FT8ZeO4uLykrLBp4arlZUtIJuKvIfS6zzPbeIa0e9o2flEgEthmOJ urayoMkSmmfk4akYl/3q6PLD6By7e/tlE3KwM9S+NgxB/EcWwb2TPZricAHosEV/wFog HfhubRmYsPAfaDa1+WCcxNTmXyi/Vrg7WG5ctGhNW9IZm2I0wvOV7qMQpc4fGZBY2Roo VC82bNeBV/3iH0WHIK8qmc0EzJL0rvi+H6nUWWK6iBQOESJpbI6Hjw+/FXGBNsydQZC7 PwU+JcjxwN11BIJ70ZiLtrguRdHOIy+3V/jVTSnMf7OVDHTgBtIFuX6eweOvbibSWTz+ g79Q== X-Gm-Message-State: APjAAAWuzQJOUWSAQJ6uqf+mgbugo3G8lZBrlSf+YZ5JuAQXRM4BNu+T PKKJy6/Qeu/YFHbnd3tVXrWt6k4Cwn/wGgxT49I= X-Google-Smtp-Source: APXvYqxvqVWs0q7s6Y0G/+G1o01zEV3Hqf9EQE58IZLGYAoCvkyTnOQ8ZuZMWGljjik1t3kEGkTmZX8bWqvmVt6HO9M= X-Received: by 2002:aca:2303:: with SMTP id e3mr1812917oie.112.1561734367444; Fri, 28 Jun 2019 08:06:07 -0700 (PDT) MIME-Version: 1.0 References: <83pnmzhqq0.fsf@gnu.org> In-Reply-To: <83pnmzhqq0.fsf@gnu.org> From: Pip Cet Date: Fri, 28 Jun 2019 15:05:30 +0000 Message-ID: Content-Type: multipart/mixed; boundary="00000000000034a0c7058c639eec" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000034a0c7058c639eec Content-Type: text/plain; charset="UTF-8" On Thu, Jun 27, 2019 at 5:40 PM Eli Zaretskii wrote: > > From: Pip Cet > > Date: Thu, 27 Jun 2019 16:28:05 +0000 > > > > I think with the exception of the contrived last example, these are > > all easy to fix, but a bit harder to fix well. I've tried to do the > > former, for now, but I'd welcome any help for me to do the latter. > > Thanks, but please also add tests which verify that these problems no > longer happen after the fix. Thanks for reminding me of that! I looked into that, and it seems there are no image tests so far. Attached patch has tests and fixes. --00000000000034a0c7058c639eec Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-minor-bugs-in-image.c.patch" Content-Disposition: attachment; filename="0001-Fix-minor-bugs-in-image.c.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxg8a6fc0 RnJvbSBhZWQ0Yjk2NWMzNGFmOTlhNDg0NzM3OTg1MjQzODJjNzZkNTc5NzhlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBGcmks IDI4IEp1biAyMDE5IDE0OjQ3OjU3ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gRml4IG1pbm9yIGJ1 Z3MgaW4gaW1hZ2UuYwoKKiB0ZXN0L3NyYy9pbWFnZS10ZXN0cy5lbCAoaW1hZ2UtdGVzdC1jaXJj dWxhci1zcGVjcyk6IE5ldyBmaWxlLgoKKiBzcmMvaW1hZ2UuYyAocGFyc2VfaW1hZ2Vfc3BlYyk6 IFJldHVybiBmYWlsdXJlIGZvciBjaXJjdWxhciBsaXN0cy4KKHZhbGlkX2ltYWdlX3ApOiBEb24n dCBsb29rIGF0IG9kZC1udW1iZXJlZCBsaXN0IGVsZW1lbnRzIGV4cGVjdGluZyB0bwpmaW5kIGEg cHJvcGVydHkgbmFtZS4KKGltYWdlX3NwZWNfdmFsdWUpOiBIYW5kbGUgY2lyY3VsYXIgbGlzdHMu CihlcXVhbF9saXN0cyk6IEludHJvZHVjZS4KKHNlYXJjaF9pbWFnZV9jYWNoZSk6IFVzZSBgZXF1 YWxfbGlzdHMnLgotLS0KIHNyYy9pbWFnZS5jICAgICAgICAgICAgIHwgNzAgKysrKysrKysrKysr KysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0KIHRlc3Qvc3JjL2ltYWdlLXRlc3RzLmVsIHwg NjUgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdl ZCwgMTExIGluc2VydGlvbnMoKyksIDI0IGRlbGV0aW9ucygtKQogY3JlYXRlIG1vZGUgMTAwNjQ0 IHRlc3Qvc3JjL2ltYWdlLXRlc3RzLmVsCgpkaWZmIC0tZ2l0IGEvc3JjL2ltYWdlLmMgYi9zcmMv aW1hZ2UuYwppbmRleCBmM2Q2NTA4ZjQ2Li4yZGU1NmZkZWVkIDEwMDY0NAotLS0gYS9zcmMvaW1h Z2UuYworKysgYi9zcmMvaW1hZ2UuYwpAQCAtODAwLDE3ICs4MDAsMjIgQEAgdmFsaWRfaW1hZ2Vf cCAoTGlzcF9PYmplY3Qgb2JqZWN0KQogICAgIHsKICAgICAgIExpc3BfT2JqZWN0IHRhaWwgPSBY Q0RSIChvYmplY3QpOwogICAgICAgRk9SX0VBQ0hfVEFJTF9TQUZFICh0YWlsKQotCWlmIChFUSAo WENBUiAodGFpbCksIFFDdHlwZSkpCi0JICB7Ci0JICAgIHRhaWwgPSBYQ0RSICh0YWlsKTsKLQkg ICAgaWYgKENPTlNQICh0YWlsKSkKLQkgICAgICB7Ci0JCXN0cnVjdCBpbWFnZV90eXBlIGNvbnN0 ICp0eXBlID0gbG9va3VwX2ltYWdlX3R5cGUgKFhDQVIgKHRhaWwpKTsKLQkJaWYgKHR5cGUpCi0J CSAgcmV0dXJuIHR5cGUtPnZhbGlkX3AgKG9iamVjdCk7Ci0JICAgICAgfQotCSAgICBicmVhazsK LQkgIH0KKwl7CisJICBpZiAoRVEgKFhDQVIgKHRhaWwpLCBRQ3R5cGUpKQorCSAgICB7CisJICAg ICAgdGFpbCA9IFhDRFIgKHRhaWwpOworCSAgICAgIGlmIChDT05TUCAodGFpbCkpCisJCXsKKwkJ ICBzdHJ1Y3QgaW1hZ2VfdHlwZSBjb25zdCAqdHlwZSA9IGxvb2t1cF9pbWFnZV90eXBlIChYQ0FS ICh0YWlsKSk7CisJCSAgaWYgKHR5cGUpCisJCSAgICByZXR1cm4gdHlwZS0+dmFsaWRfcCAob2Jq ZWN0KTsKKwkJfQorCSAgICAgIGJyZWFrOworCSAgICB9CisJICB0YWlsID0gWENEUiAodGFpbCk7 CisJICBpZiAoISBDT05TUCAodGFpbCkpCisJICAgIHJldHVybiBmYWxzZTsKKwl9CiAgICAgfQog CiAgIHJldHVybiBmYWxzZTsKQEAgLTg5Nyw3ICs5MDIsNyBAQCBwYXJzZV9pbWFnZV9zcGVjIChM aXNwX09iamVjdCBzcGVjLCBzdHJ1Y3QgaW1hZ2Vfa2V5d29yZCAqa2V5d29yZHMsCiAgICAgcmV0 dXJuIGZhbHNlOwogCiAgIHBsaXN0ID0gWENEUiAoc3BlYyk7Ci0gIHdoaWxlIChDT05TUCAocGxp c3QpKQorICBGT1JfRUFDSF9UQUlMX1NBRkUgKHBsaXN0KQogICAgIHsKICAgICAgIExpc3BfT2Jq ZWN0IGtleSwgdmFsdWU7CiAKQEAgLTkxMSw3ICs5MTYsNiBAQCBwYXJzZV9pbWFnZV9zcGVjIChM aXNwX09iamVjdCBzcGVjLCBzdHJ1Y3QgaW1hZ2Vfa2V5d29yZCAqa2V5d29yZHMsCiAgICAgICBp ZiAoIUNPTlNQIChwbGlzdCkpCiAJcmV0dXJuIGZhbHNlOwogICAgICAgdmFsdWUgPSBYQ0FSIChw bGlzdCk7Ci0gICAgICBwbGlzdCA9IFhDRFIgKHBsaXN0KTsKIAogICAgICAgLyogRmluZCBrZXkg aW4gS0VZV09SRFMuICBFcnJvciBpZiBub3QgZm91bmQuICAqLwogICAgICAgZm9yIChpID0gMDsg aSA8IG5rZXl3b3JkczsgKytpKQpAQCAtOTE5LDcgKzkyMyw3IEBAIHBhcnNlX2ltYWdlX3NwZWMg KExpc3BfT2JqZWN0IHNwZWMsIHN0cnVjdCBpbWFnZV9rZXl3b3JkICprZXl3b3JkcywKIAkgIGJy ZWFrOwogCiAgICAgICBpZiAoaSA9PSBua2V5d29yZHMpCi0JY29udGludWU7CisJZ290byBtYXli ZV9kb25lOwogCiAgICAgICAvKiBSZWNvcmQgdGhhdCB3ZSByZWNvZ25pemVkIHRoZSBrZXl3b3Jk LiAgSWYgYSBrZXl3b3JkCiAJIHdhcyBmb3VuZCBtb3JlIHRoYW4gb25jZSwgaXQncyBhbiBlcnJv ci4gICovCkBAIC0xMDA2LDE0ICsxMDEwLDIwIEBAIHBhcnNlX2ltYWdlX3NwZWMgKExpc3BfT2Jq ZWN0IHNwZWMsIHN0cnVjdCBpbWFnZV9rZXl3b3JkICprZXl3b3JkcywKIAogICAgICAgaWYgKEVR IChrZXksIFFDdHlwZSkgJiYgIUVRICh0eXBlLCB2YWx1ZSkpCiAJcmV0dXJuIGZhbHNlOwotICAg IH0KIAotICAvKiBDaGVjayB0aGF0IGFsbCBtYW5kYXRvcnkgZmllbGRzIGFyZSBwcmVzZW50LiAg Ki8KLSAgZm9yIChpID0gMDsgaSA8IG5rZXl3b3JkczsgKytpKQotICAgIGlmIChrZXl3b3Jkc1tp XS5jb3VudCA8IGtleXdvcmRzW2ldLm1hbmRhdG9yeV9wKQotICAgICAgcmV0dXJuIGZhbHNlOwor ICAgIG1heWJlX2RvbmU6CisgICAgICBpZiAoRVEgKFhDRFIgKHBsaXN0KSwgUW5pbCkpCisJewor CSAgLyogQ2hlY2sgdGhhdCBhbGwgbWFuZGF0b3J5IGZpZWxkcyBhcmUgcHJlc2VudC4gICovCisJ ICBmb3IgKGkgPSAwOyBpIDwgbmtleXdvcmRzOyArK2kpCisJICAgIGlmIChrZXl3b3Jkc1tpXS5t YW5kYXRvcnlfcCAmJiBrZXl3b3Jkc1tpXS5jb3VudCA9PSAwKQorCSAgICAgIHJldHVybiBmYWxz ZTsKKworCSAgcmV0dXJuIHRydWU7CisJfQorICAgIH0KIAotICByZXR1cm4gTklMUCAocGxpc3Qp OworICByZXR1cm4gZmFsc2U7CiB9CiAKIApAQCAtMTAyOCw5ICsxMDM4LDggQEAgaW1hZ2Vfc3Bl Y192YWx1ZSAoTGlzcF9PYmplY3Qgc3BlYywgTGlzcF9PYmplY3Qga2V5LCBib29sICpmb3VuZCkK IAogICBlYXNzZXJ0ICh2YWxpZF9pbWFnZV9wIChzcGVjKSk7CiAKLSAgZm9yICh0YWlsID0gWENE UiAoc3BlYyk7Ci0gICAgICAgQ09OU1AgKHRhaWwpICYmIENPTlNQIChYQ0RSICh0YWlsKSk7Ci0g ICAgICAgdGFpbCA9IFhDRFIgKFhDRFIgKHRhaWwpKSkKKyAgdGFpbCA9IFhDRFIgKHNwZWMpOwor ICBGT1JfRUFDSF9UQUlMX1NBRkUgKHRhaWwpCiAgICAgewogICAgICAgaWYgKEVRIChYQ0FSICh0 YWlsKSwga2V5KSkKIAl7CkBAIC0xMDM4LDYgKzEwNDcsOSBAQCBpbWFnZV9zcGVjX3ZhbHVlIChM aXNwX09iamVjdCBzcGVjLCBMaXNwX09iamVjdCBrZXksIGJvb2wgKmZvdW5kKQogCSAgICAqZm91 bmQgPSAxOwogCSAgcmV0dXJuIFhDQVIgKFhDRFIgKHRhaWwpKTsKIAl9CisgICAgICB0YWlsID0g WENEUiAodGFpbCk7CisgICAgICBpZiAoISBDT05TUCAodGFpbCkpCisJYnJlYWs7CiAgICAgfQog CiAgIGlmIChmb3VuZCkKQEAgLTE1NzIsNiArMTU4NCwxNiBAQCBtYWtlX2ltYWdlX2NhY2hlICh2 b2lkKQogICByZXR1cm4gYzsKIH0KIAorLyogQ29tcGFyZSB0d28gbGlzdHMgKG9uZSBvZiB3aGlj aCBtdXN0IGJlIHByb3BlciksIGNvbXBhcmluZyBlYWNoCisgICBlbGVtZW50IHdpdGggYGVxJy4g ICovCitzdGF0aWMgYm9vbAorZXF1YWxfbGlzdHMgKExpc3BfT2JqZWN0IGEsIExpc3BfT2JqZWN0 IGIpCit7CisgIHdoaWxlIChDT05TUCAoYSkgJiYgQ09OU1AgKGIpICYmIEVRIChYQ0FSIChhKSwg WENBUiAoYikpKQorICAgIGEgPSBYQ0RSIChhKSwgYiA9IFhDRFIgKGIpOworCisgIHJldHVybiBF USAoYSwgYik7Cit9CiAKIC8qIEZpbmQgYW4gaW1hZ2UgbWF0Y2hpbmcgU1BFQyBpbiB0aGUgY2Fj aGUsIGFuZCByZXR1cm4gaXQuICBJZiBubwogICAgaW1hZ2UgaXMgZm91bmQsIHJldHVybiBOVUxM LiAgKi8KQEAgLTE1OTgsNyArMTYyMCw3IEBAIHNlYXJjaF9pbWFnZV9jYWNoZSAoc3RydWN0IGZy YW1lICpmLCBMaXNwX09iamVjdCBzcGVjLCBFTUFDU19VSU5UIGhhc2gpCiAKICAgZm9yIChpbWcg PSBjLT5idWNrZXRzW2ldOyBpbWc7IGltZyA9IGltZy0+bmV4dCkKICAgICBpZiAoaW1nLT5oYXNo ID09IGhhc2gKLQkmJiAhTklMUCAoRmVxdWFsIChpbWctPnNwZWMsIHNwZWMpKQorCSYmICFlcXVh bF9saXN0cyAoaW1nLT5zcGVjLCBzcGVjKQogCSYmIGltZy0+ZnJhbWVfZm9yZWdyb3VuZCA9PSBG UkFNRV9GT1JFR1JPVU5EX1BJWEVMIChmKQogCSYmIGltZy0+ZnJhbWVfYmFja2dyb3VuZCA9PSBG UkFNRV9CQUNLR1JPVU5EX1BJWEVMIChmKSkKICAgICAgIGJyZWFrOwpkaWZmIC0tZ2l0IGEvdGVz dC9zcmMvaW1hZ2UtdGVzdHMuZWwgYi90ZXN0L3NyYy9pbWFnZS10ZXN0cy5lbApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwLi40MzI1MjM3ZGU5Ci0tLSAvZGV2L251bGwKKysr IGIvdGVzdC9zcmMvaW1hZ2UtdGVzdHMuZWwKQEAgLTAsMCArMSw2NSBAQAorOzs7IGltYWdlLXRl c3RzLmVsIC0tLSBUZXN0IHN1aXRlIGZvciBpbWFnZS1yZWxhdGVkIGZ1bmN0aW9ucy4KKworOzsg Q29weXJpZ2h0IChDKSAyMDE5IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLgorCis7OyBB dXRob3I6IFBpcCBDZXQgPHBpcGNldEBnbWFpbC5jb20+Cis7OyBLZXl3b3JkczogICAgICAgaW50 ZXJuYWwKKzs7IEh1bWFuLUtleXdvcmRzOiBpbnRlcm5hbAorCis7OyBUaGlzIGZpbGUgaXMgcGFy dCBvZiBHTlUgRW1hY3MuCisKKzs7IEdOVSBFbWFjcyBpcyBmcmVlIHNvZnR3YXJlOiB5b3UgY2Fu IHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5Cis7OyBpdCB1bmRlciB0aGUgdGVybXMgb2Yg dGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQorOzsgdGhlIEZy ZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgZWl0aGVyIHZlcnNpb24gMyBvZiB0aGUgTGljZW5zZSwg b3IKKzs7IChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisKKzs7IEdOVSBFbWFj cyBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAorOzsg YnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFu dHkgb2YKKzs7IE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVS UE9TRS4gIFNlZSB0aGUKKzs7IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRl dGFpbHMuCisKKzs7IFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBH ZW5lcmFsIFB1YmxpYyBMaWNlbnNlCis7OyBhbG9uZyB3aXRoIEdOVSBFbWFjcy4gIElmIG5vdCwg c2VlIDxodHRwczovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uCisKKzs7OyBDb21tZW50YXJ5Ogor Cis7OzsgQ29kZToKKworKHJlcXVpcmUgJ2VydCkKKworKGVydC1kZWZ0ZXN0IGltYWdlLXRlc3Qt ZHVwbGljYXRlLWtleXdvcmRzICgpCisgICJUZXN0IHRoYXQgZHVwbGljYXRlIGtleXdvcmRzIGlu IGFuIGltYWdlIHNwZWMgbGVhZCB0byByZWplY3Rpb24uIgorICAoc2hvdWxkLWVycm9yIChpbWFn ZS1zaXplIGAoaW1hZ2UgOnR5cGUgeGJtIDp0eXBlIHhibSA6d2lkdGggMSA6aGVpZ2h0IDEKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDpkYXRhICwoYm9vbC12ZWN0b3IgdCkp CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgdCkpKQorCisoZXJ0LWRlZnRlc3QgaW1hZ2Ut dGVzdC1jaXJjdWxhci1wbGlzdCAoKQorICAiVGVzdCB0aGF0IGEgY2lyY3VsYXIgaW1hZ2Ugc3Bl YyBpcyByZWplY3RlZC4iCisgIChzaG91bGQtZXJyb3IKKyAgIChsZXQgKChsIGAoaW1hZ2UgOnR5 cGUgeGJtIDp3aWR0aCAxIDpoZWlnaHQgMSA6ZGF0YSAsKGJvb2wtdmVjdG9yIHQpKSkpCisgICAg IChzZXRjZHIgKGxhc3QgbCkgJyMxPSg6aW52YWxpZCAuICMxIykpCisgICAgIChpbWFnZS1zaXpl IGwgdCkpKSkKKworKGVydC1kZWZ0ZXN0IGltYWdlLXRlc3QtOnR5cGUtcHJvcGVydHktdmFsdWUg KCkKKyAgIlRlc3QgdGhhdCA6dHlwZSBpcyBhbGxvd2VkIGFzIGEgcHJvcGVydHkgdmFsdWUgaW4g YW4gaW1hZ2Ugc3BlYy4iCisgIChzaG91bGQgKGVxdWFsIChpbWFnZS1zaXplIGAoaW1hZ2UgOmR1 bW15IDp0eXBlIDp0eXBlIHhibSA6d2lkdGggMSA6aGVpZ2h0IDEKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICA6ZGF0YSAsKGJvb2wtdmVjdG9yIHQpKQorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB0KQorICAgICAgICAgICAgICAgICAoY29ucyAxIDEpKSkp CisKKyhlcnQtZGVmdGVzdCBpbWFnZS10ZXN0LWNpcmN1bGFyLXNwZWNzICgpCisgICJUZXN0IHRo YXQgY2lyY3VsYXIgaW1hZ2Ugc3BlYyBwcm9wZXJ0eSB2YWx1ZXMgZG8gbm90IGNhdXNlIGluZmlu aXRlIHJlY3Vyc2lvbi4iCisgIChzaG91bGQKKyAgIChsZXQqICgoY2lyYzEgKGNvbnMgOmR1bW15 IG5pbCkpCisgICAgICAgICAgKGNpcmMyIChjb25zIDpkdW1teSBuaWwpKQorICAgICAgICAgIChz cGVjMSBgKGltYWdlIDp0eXBlIHhibSA6d2lkdGggMSA6aGVpZ2h0IDEKKyAgICAgICAgICAgICAg ICAgICAgICAgICA6ZGF0YSAsKGJvb2wtdmVjdG9yIDEpIDppZ25vcmVkICxjaXJjMSkpCisgICAg ICAgICAgKHNwZWMyIGAoaW1hZ2UgOnR5cGUgeGJtIDp3aWR0aCAxIDpoZWlnaHQgMQorICAgICAg ICAgICAgICAgICAgICAgICAgOmRhdGEgLChib29sLXZlY3RvciAxKSA6aWdub3JlZCAsY2lyYzIp KSkKKyAgICAgKHNldGNkciBjaXJjMSBjaXJjMSkKKyAgICAgKHNldGNkciBjaXJjMiBjaXJjMikK KyAgICAgKGFuZCAoZXF1YWwgKGltYWdlLXNpemUgc3BlYzEgdCkgKGNvbnMgMSAxKSkKKyAgICAg ICAgICAoZXF1YWwgKGltYWdlLXNpemUgc3BlYzIgdCkgKGNvbnMgMSAxKSkpKSkpCisKKyhwcm92 aWRlICdpbWFnZS10ZXN0cykKKzs7OyBpbWFnZS10ZXN0cy5lbCBlbmRzIGhlcmUuCi0tIAoyLjIw LjEKCg== --00000000000034a0c7058c639eec-- From unknown Sun Jun 22 04:02:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36403: 27.0.50; Trivial image.c bugs Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jun 2019 19:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Pip Cet Cc: 36403@debbugs.gnu.org Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.156175158931730 (code B ref 36403); Fri, 28 Jun 2019 19:54:01 +0000 Received: (at 36403) by debbugs.gnu.org; 28 Jun 2019 19:53:09 +0000 Received: from localhost ([127.0.0.1]:43057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgwvl-0008Fi-Da for submit@debbugs.gnu.org; Fri, 28 Jun 2019 15:53:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgwvj-0008FT-Ri for 36403@debbugs.gnu.org; Fri, 28 Jun 2019 15:53:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34252) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hgwve-0006Pi-LJ; Fri, 28 Jun 2019 15:53:02 -0400 Received: from [176.228.60.248] (port=4691 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hgwvd-0002Kj-IO; Fri, 28 Jun 2019 15:53:02 -0400 Date: Fri, 28 Jun 2019 22:52:50 +0300 Message-Id: <83h889h4h9.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Pip Cet on Fri, 28 Jun 2019 15:05:30 +0000) References: <83pnmzhqq0.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Pip Cet > Date: Fri, 28 Jun 2019 15:05:30 +0000 > Cc: 36403@debbugs.gnu.org > > > Thanks, but please also add tests which verify that these problems no > > longer happen after the fix. > > Thanks for reminding me of that! I looked into that, and it seems > there are no image tests so far. There are some in test/manual. they are there because they need to be run interactively. > Attached patch has tests and fixes. Thanks. Let's wait for a few days to let others comment. From unknown Sun Jun 22 04:02:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36403: 27.0.50; Trivial image.c bugs Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Jul 2019 02:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 36403@debbugs.gnu.org Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.15637641954738 (code B ref 36403); Mon, 22 Jul 2019 02:57:01 +0000 Received: (at 36403) by debbugs.gnu.org; 22 Jul 2019 02:56:35 +0000 Received: from localhost ([127.0.0.1]:59801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpOV9-0001EM-01 for submit@debbugs.gnu.org; Sun, 21 Jul 2019 22:56:35 -0400 Received: from mail-oi1-f170.google.com ([209.85.167.170]:35644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpOV6-0001E6-Re for 36403@debbugs.gnu.org; Sun, 21 Jul 2019 22:56:33 -0400 Received: by mail-oi1-f170.google.com with SMTP id a127so28483376oii.2 for <36403@debbugs.gnu.org>; Sun, 21 Jul 2019 19:56:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fEwHyoQsk+23zN8QTBJfztYcKKvep51+mxIdrBfju3M=; b=TtUlzyWvywgtuHMhWQ+UvAf808DolEOmcW4HDVPl7BL7BR47ovpNvBiuoUjUpF9T+3 qZD0ETiSeHa1/nOb1Zet0zhJ3nU1FYSy8YAphdlALjYVCekvC7yvqy9+FHQ4fgmh/cpP ZH0qm0kQNu8a0kBRHOq1Yg426reBj3ykvU7ZegeX01r6FrLguGTAi1szibdB6kWAZYaB YCltXoXPbJoxX0kd2MNIDXHWoFKChoBMuig1X0BDxORakT/5tUwQmzQxqqX4Y38xZb0j NIjIqUYQXUyfu0ZfMJrvLzsdBnRvywDFygFocqLRiuPtUivci3k65TrhxGCAgALGV1y0 NdOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fEwHyoQsk+23zN8QTBJfztYcKKvep51+mxIdrBfju3M=; b=OIdcYIM9jTa17nKuMday0T2zjXNvYrEvDxuCR+s4UiCo6+nFHmzb7XpFwvx/Tpexey 70QEKzVkFUfEIEIJ0Aw+DM+e8eP2PZwDcQv0esnZwOuFkEcMPYXL6WvgTAf+A6DZgZZ4 sa9oX7FvSsRyOam+EDYP1NkxHnzb+E4LLQAmCbSext9WzshTVXZxoquHAbALNRBBruZ3 U6pOZ5R1nPfCILu5r2iz8AFn/HsZjz7WiBZs6bBz5l+jCoQb+9mM4skSyyXAn4Kd0rMw 4slKgCt6eJIDYybBo01CTa6XGxno9mIsXCpxQBhJW6pEcXfYJsEi/P1fQjKu6CKWs9Zb 4YNw== X-Gm-Message-State: APjAAAX5wAcs9uFQGiugzXnwPeBzIv7m1/NYq2EZYHbLXPhQZJsbGWa3 eIQGKjMfs4o9Adk+DH4b3sm7KE9r2+AE1+tRQXLLsw== X-Google-Smtp-Source: APXvYqzIYU2DcV2ZfaA+RTEkRacxsquODfxciC9BcCN8f9ktmA/INbMwMfXPN6f2HgBtKEob4qX1uFuzfKXnO8BvmOY= X-Received: by 2002:aca:aa93:: with SMTP id t141mr32349848oie.128.1563764187166; Sun, 21 Jul 2019 19:56:27 -0700 (PDT) MIME-Version: 1.0 References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> In-Reply-To: <83h889h4h9.fsf@gnu.org> From: Pip Cet Date: Mon, 22 Jul 2019 02:55:50 +0000 Message-ID: Content-Type: multipart/mixed; boundary="000000000000e3a295058e3c38b5" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000e3a295058e3c38b5 Content-Type: text/plain; charset="UTF-8" On Fri, Jun 28, 2019 at 7:53 PM Eli Zaretskii wrote: > > Attached patch has tests and fixes. > > Thanks. Let's wait for a few days to let others comment. Rebased patch attached. --000000000000e3a295058e3c38b5 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-minor-bugs-in-image.c-bug-36403.patch" Content-Disposition: attachment; filename="0001-Fix-minor-bugs-in-image.c-bug-36403.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jydsoijd0 RnJvbSA2MWI1YjY0YzY2MDQ4MWQyMmE2Yjc5YmRlYzIxYjg4NDEzM2E3YzQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBGcmks IDI4IEp1biAyMDE5IDE0OjQ3OjU3ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gRml4IG1pbm9yIGJ1 Z3MgaW4gaW1hZ2UuYyAoYnVnIzM2NDAzKQoKKiB0ZXN0L3NyYy9pbWFnZS10ZXN0cy5lbCAoaW1h Z2UtdGVzdC1jaXJjdWxhci1zcGVjcyk6IE5ldyBmaWxlLgoqIHNyYy9pbWFnZS5jIChwYXJzZV9p bWFnZV9zcGVjKTogUmV0dXJuIGZhaWx1cmUgZm9yIGNpcmN1bGFyIGxpc3RzLgoodmFsaWRfaW1h Z2VfcCk6IERvbid0IGxvb2sgYXQgb2RkLW51bWJlcmVkIGxpc3QgZWxlbWVudHMgZXhwZWN0aW5n IHRvCmZpbmQgYSBwcm9wZXJ0eSBuYW1lLgooaW1hZ2Vfc3BlY192YWx1ZSk6IEhhbmRsZSBjaXJj dWxhciBsaXN0cy4KKGVxdWFsX2xpc3RzKTogSW50cm9kdWNlLgooc2VhcmNoX2ltYWdlX2NhY2hl KTogVXNlIGBlcXVhbF9saXN0cycuCi0tLQogc3JjL2ltYWdlLmMgICAgICAgICAgICAgfCA3MCAr KysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLQogdGVzdC9zcmMvaW1hZ2Ut dGVzdHMuZWwgfCA2NSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMiBm aWxlcyBjaGFuZ2VkLCAxMTEgaW5zZXJ0aW9ucygrKSwgMjQgZGVsZXRpb25zKC0pCiBjcmVhdGUg bW9kZSAxMDA2NDQgdGVzdC9zcmMvaW1hZ2UtdGVzdHMuZWwKCmRpZmYgLS1naXQgYS9zcmMvaW1h Z2UuYyBiL3NyYy9pbWFnZS5jCmluZGV4IDM1NWM4NDk0OTEuLmZiYzYzNmQ2NTEgMTAwNjQ0Ci0t LSBhL3NyYy9pbWFnZS5jCisrKyBiL3NyYy9pbWFnZS5jCkBAIC04MDAsMTcgKzgwMCwyMiBAQCB2 YWxpZF9pbWFnZV9wIChMaXNwX09iamVjdCBvYmplY3QpCiAgICAgewogICAgICAgTGlzcF9PYmpl Y3QgdGFpbCA9IFhDRFIgKG9iamVjdCk7CiAgICAgICBGT1JfRUFDSF9UQUlMX1NBRkUgKHRhaWwp Ci0JaWYgKEVRIChYQ0FSICh0YWlsKSwgUUN0eXBlKSkKLQkgIHsKLQkgICAgdGFpbCA9IFhDRFIg KHRhaWwpOwotCSAgICBpZiAoQ09OU1AgKHRhaWwpKQotCSAgICAgIHsKLQkJc3RydWN0IGltYWdl X3R5cGUgY29uc3QgKnR5cGUgPSBsb29rdXBfaW1hZ2VfdHlwZSAoWENBUiAodGFpbCkpOwotCQlp ZiAodHlwZSkKLQkJICByZXR1cm4gdHlwZS0+dmFsaWRfcCAob2JqZWN0KTsKLQkgICAgICB9Ci0J ICAgIGJyZWFrOwotCSAgfQorCXsKKwkgIGlmIChFUSAoWENBUiAodGFpbCksIFFDdHlwZSkpCisJ ICAgIHsKKwkgICAgICB0YWlsID0gWENEUiAodGFpbCk7CisJICAgICAgaWYgKENPTlNQICh0YWls KSkKKwkJeworCQkgIHN0cnVjdCBpbWFnZV90eXBlIGNvbnN0ICp0eXBlID0gbG9va3VwX2ltYWdl X3R5cGUgKFhDQVIgKHRhaWwpKTsKKwkJICBpZiAodHlwZSkKKwkJICAgIHJldHVybiB0eXBlLT52 YWxpZF9wIChvYmplY3QpOworCQl9CisJICAgICAgYnJlYWs7CisJICAgIH0KKwkgIHRhaWwgPSBY Q0RSICh0YWlsKTsKKwkgIGlmICghIENPTlNQICh0YWlsKSkKKwkgICAgcmV0dXJuIGZhbHNlOwor CX0KICAgICB9CiAKICAgcmV0dXJuIGZhbHNlOwpAQCAtODk3LDcgKzkwMiw3IEBAIHBhcnNlX2lt YWdlX3NwZWMgKExpc3BfT2JqZWN0IHNwZWMsIHN0cnVjdCBpbWFnZV9rZXl3b3JkICprZXl3b3Jk cywKICAgICByZXR1cm4gZmFsc2U7CiAKICAgcGxpc3QgPSBYQ0RSIChzcGVjKTsKLSAgd2hpbGUg KENPTlNQIChwbGlzdCkpCisgIEZPUl9FQUNIX1RBSUxfU0FGRSAocGxpc3QpCiAgICAgewogICAg ICAgTGlzcF9PYmplY3Qga2V5LCB2YWx1ZTsKIApAQCAtOTExLDcgKzkxNiw2IEBAIHBhcnNlX2lt YWdlX3NwZWMgKExpc3BfT2JqZWN0IHNwZWMsIHN0cnVjdCBpbWFnZV9rZXl3b3JkICprZXl3b3Jk cywKICAgICAgIGlmICghQ09OU1AgKHBsaXN0KSkKIAlyZXR1cm4gZmFsc2U7CiAgICAgICB2YWx1 ZSA9IFhDQVIgKHBsaXN0KTsKLSAgICAgIHBsaXN0ID0gWENEUiAocGxpc3QpOwogCiAgICAgICAv KiBGaW5kIGtleSBpbiBLRVlXT1JEUy4gIEVycm9yIGlmIG5vdCBmb3VuZC4gICovCiAgICAgICBm b3IgKGkgPSAwOyBpIDwgbmtleXdvcmRzOyArK2kpCkBAIC05MTksNyArOTIzLDcgQEAgcGFyc2Vf aW1hZ2Vfc3BlYyAoTGlzcF9PYmplY3Qgc3BlYywgc3RydWN0IGltYWdlX2tleXdvcmQgKmtleXdv cmRzLAogCSAgYnJlYWs7CiAKICAgICAgIGlmIChpID09IG5rZXl3b3JkcykKLQljb250aW51ZTsK Kwlnb3RvIG1heWJlX2RvbmU7CiAKICAgICAgIC8qIFJlY29yZCB0aGF0IHdlIHJlY29nbml6ZWQg dGhlIGtleXdvcmQuICBJZiBhIGtleXdvcmQKIAkgd2FzIGZvdW5kIG1vcmUgdGhhbiBvbmNlLCBp dCdzIGFuIGVycm9yLiAgKi8KQEAgLTEwMDYsMTQgKzEwMTAsMjAgQEAgcGFyc2VfaW1hZ2Vfc3Bl YyAoTGlzcF9PYmplY3Qgc3BlYywgc3RydWN0IGltYWdlX2tleXdvcmQgKmtleXdvcmRzLAogCiAg ICAgICBpZiAoRVEgKGtleSwgUUN0eXBlKSAmJiAhRVEgKHR5cGUsIHZhbHVlKSkKIAlyZXR1cm4g ZmFsc2U7Ci0gICAgfQogCi0gIC8qIENoZWNrIHRoYXQgYWxsIG1hbmRhdG9yeSBmaWVsZHMgYXJl IHByZXNlbnQuICAqLwotICBmb3IgKGkgPSAwOyBpIDwgbmtleXdvcmRzOyArK2kpCi0gICAgaWYg KGtleXdvcmRzW2ldLmNvdW50IDwga2V5d29yZHNbaV0ubWFuZGF0b3J5X3ApCi0gICAgICByZXR1 cm4gZmFsc2U7CisgICAgbWF5YmVfZG9uZToKKyAgICAgIGlmIChFUSAoWENEUiAocGxpc3QpLCBR bmlsKSkKKwl7CisJICAvKiBDaGVjayB0aGF0IGFsbCBtYW5kYXRvcnkgZmllbGRzIGFyZSBwcmVz ZW50LiAgKi8KKwkgIGZvciAoaSA9IDA7IGkgPCBua2V5d29yZHM7ICsraSkKKwkgICAgaWYgKGtl eXdvcmRzW2ldLm1hbmRhdG9yeV9wICYmIGtleXdvcmRzW2ldLmNvdW50ID09IDApCisJICAgICAg cmV0dXJuIGZhbHNlOworCisJICByZXR1cm4gdHJ1ZTsKKwl9CisgICAgfQogCi0gIHJldHVybiBO SUxQIChwbGlzdCk7CisgIHJldHVybiBmYWxzZTsKIH0KIAogCkBAIC0xMDI4LDkgKzEwMzgsOCBA QCBpbWFnZV9zcGVjX3ZhbHVlIChMaXNwX09iamVjdCBzcGVjLCBMaXNwX09iamVjdCBrZXksIGJv b2wgKmZvdW5kKQogCiAgIGVhc3NlcnQgKHZhbGlkX2ltYWdlX3AgKHNwZWMpKTsKIAotICBmb3Ig KHRhaWwgPSBYQ0RSIChzcGVjKTsKLSAgICAgICBDT05TUCAodGFpbCkgJiYgQ09OU1AgKFhDRFIg KHRhaWwpKTsKLSAgICAgICB0YWlsID0gWENEUiAoWENEUiAodGFpbCkpKQorICB0YWlsID0gWENE UiAoc3BlYyk7CisgIEZPUl9FQUNIX1RBSUxfU0FGRSAodGFpbCkKICAgICB7CiAgICAgICBpZiAo RVEgKFhDQVIgKHRhaWwpLCBrZXkpKQogCXsKQEAgLTEwMzgsNiArMTA0Nyw5IEBAIGltYWdlX3Nw ZWNfdmFsdWUgKExpc3BfT2JqZWN0IHNwZWMsIExpc3BfT2JqZWN0IGtleSwgYm9vbCAqZm91bmQp CiAJICAgICpmb3VuZCA9IDE7CiAJICByZXR1cm4gWENBUiAoWENEUiAodGFpbCkpOwogCX0KKyAg ICAgIHRhaWwgPSBYQ0RSICh0YWlsKTsKKyAgICAgIGlmICghIENPTlNQICh0YWlsKSkKKwlicmVh azsKICAgICB9CiAKICAgaWYgKGZvdW5kKQpAQCAtMTU3Miw2ICsxNTg0LDE2IEBAIG1ha2VfaW1h Z2VfY2FjaGUgKHZvaWQpCiAgIHJldHVybiBjOwogfQogCisvKiBDb21wYXJlIHR3byBsaXN0cyAo b25lIG9mIHdoaWNoIG11c3QgYmUgcHJvcGVyKSwgY29tcGFyaW5nIGVhY2gKKyAgIGVsZW1lbnQg d2l0aCBgZXEnLiAgKi8KK3N0YXRpYyBib29sCitlcXVhbF9saXN0cyAoTGlzcF9PYmplY3QgYSwg TGlzcF9PYmplY3QgYikKK3sKKyAgd2hpbGUgKENPTlNQIChhKSAmJiBDT05TUCAoYikgJiYgRVEg KFhDQVIgKGEpLCBYQ0FSIChiKSkpCisgICAgYSA9IFhDRFIgKGEpLCBiID0gWENEUiAoYik7CisK KyAgcmV0dXJuIEVRIChhLCBiKTsKK30KIAogLyogRmluZCBhbiBpbWFnZSBtYXRjaGluZyBTUEVD IGluIHRoZSBjYWNoZSwgYW5kIHJldHVybiBpdC4gIElmIG5vCiAgICBpbWFnZSBpcyBmb3VuZCwg cmV0dXJuIE5VTEwuICAqLwpAQCAtMTU5OCw3ICsxNjIwLDcgQEAgc2VhcmNoX2ltYWdlX2NhY2hl IChzdHJ1Y3QgZnJhbWUgKmYsIExpc3BfT2JqZWN0IHNwZWMsIEVNQUNTX1VJTlQgaGFzaCkKIAog ICBmb3IgKGltZyA9IGMtPmJ1Y2tldHNbaV07IGltZzsgaW1nID0gaW1nLT5uZXh0KQogICAgIGlm IChpbWctPmhhc2ggPT0gaGFzaAotCSYmICFOSUxQIChGZXF1YWwgKGltZy0+c3BlYywgc3BlYykp CisJJiYgIWVxdWFsX2xpc3RzIChpbWctPnNwZWMsIHNwZWMpCiAJJiYgaW1nLT5mcmFtZV9mb3Jl Z3JvdW5kID09IEZSQU1FX0ZPUkVHUk9VTkRfUElYRUwgKGYpCiAJJiYgaW1nLT5mcmFtZV9iYWNr Z3JvdW5kID09IEZSQU1FX0JBQ0tHUk9VTkRfUElYRUwgKGYpKQogICAgICAgYnJlYWs7CmRpZmYg LS1naXQgYS90ZXN0L3NyYy9pbWFnZS10ZXN0cy5lbCBiL3Rlc3Qvc3JjL2ltYWdlLXRlc3RzLmVs Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAuLjQzMjUyMzdkZTkKLS0tIC9k ZXYvbnVsbAorKysgYi90ZXN0L3NyYy9pbWFnZS10ZXN0cy5lbApAQCAtMCwwICsxLDY1IEBACis7 OzsgaW1hZ2UtdGVzdHMuZWwgLS0tIFRlc3Qgc3VpdGUgZm9yIGltYWdlLXJlbGF0ZWQgZnVuY3Rp b25zLgorCis7OyBDb3B5cmlnaHQgKEMpIDIwMTkgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJ bmMuCisKKzs7IEF1dGhvcjogUGlwIENldCA8cGlwY2V0QGdtYWlsLmNvbT4KKzs7IEtleXdvcmRz OiAgICAgICBpbnRlcm5hbAorOzsgSHVtYW4tS2V5d29yZHM6IGludGVybmFsCisKKzs7IFRoaXMg ZmlsZSBpcyBwYXJ0IG9mIEdOVSBFbWFjcy4KKworOzsgR05VIEVtYWNzIGlzIGZyZWUgc29mdHdh cmU6IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkKKzs7IGl0IHVuZGVyIHRo ZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5 Cis7OyB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBlaXRoZXIgdmVyc2lvbiAzIG9mIHRo ZSBMaWNlbnNlLCBvcgorOzsgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KKwor OzsgR05VIEVtYWNzIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1 c2VmdWwsCis7OyBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1w bGllZCB3YXJyYW50eSBvZgorOzsgTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFS VElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQorOzsgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2Ug Zm9yIG1vcmUgZGV0YWlscy4KKworOzsgWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBv ZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UKKzs7IGFsb25nIHdpdGggR05VIEVtYWNz LiAgSWYgbm90LCBzZWUgPGh0dHBzOi8vd3d3LmdudS5vcmcvbGljZW5zZXMvPi4KKworOzs7IENv bW1lbnRhcnk6CisKKzs7OyBDb2RlOgorCisocmVxdWlyZSAnZXJ0KQorCisoZXJ0LWRlZnRlc3Qg aW1hZ2UtdGVzdC1kdXBsaWNhdGUta2V5d29yZHMgKCkKKyAgIlRlc3QgdGhhdCBkdXBsaWNhdGUg a2V5d29yZHMgaW4gYW4gaW1hZ2Ugc3BlYyBsZWFkIHRvIHJlamVjdGlvbi4iCisgIChzaG91bGQt ZXJyb3IgKGltYWdlLXNpemUgYChpbWFnZSA6dHlwZSB4Ym0gOnR5cGUgeGJtIDp3aWR0aCAxIDpo ZWlnaHQgMQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOmRhdGEgLChib29s LXZlY3RvciB0KSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICB0KSkpCisKKyhlcnQtZGVm dGVzdCBpbWFnZS10ZXN0LWNpcmN1bGFyLXBsaXN0ICgpCisgICJUZXN0IHRoYXQgYSBjaXJjdWxh ciBpbWFnZSBzcGVjIGlzIHJlamVjdGVkLiIKKyAgKHNob3VsZC1lcnJvcgorICAgKGxldCAoKGwg YChpbWFnZSA6dHlwZSB4Ym0gOndpZHRoIDEgOmhlaWdodCAxIDpkYXRhICwoYm9vbC12ZWN0b3Ig dCkpKSkKKyAgICAgKHNldGNkciAobGFzdCBsKSAnIzE9KDppbnZhbGlkIC4gIzEjKSkKKyAgICAg KGltYWdlLXNpemUgbCB0KSkpKQorCisoZXJ0LWRlZnRlc3QgaW1hZ2UtdGVzdC06dHlwZS1wcm9w ZXJ0eS12YWx1ZSAoKQorICAiVGVzdCB0aGF0IDp0eXBlIGlzIGFsbG93ZWQgYXMgYSBwcm9wZXJ0 eSB2YWx1ZSBpbiBhbiBpbWFnZSBzcGVjLiIKKyAgKHNob3VsZCAoZXF1YWwgKGltYWdlLXNpemUg YChpbWFnZSA6ZHVtbXkgOnR5cGUgOnR5cGUgeGJtIDp3aWR0aCAxIDpoZWlnaHQgMQorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDpkYXRhICwoYm9vbC12ZWN0b3IgdCkp CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHQpCisgICAgICAgICAgICAgICAgIChj b25zIDEgMSkpKSkKKworKGVydC1kZWZ0ZXN0IGltYWdlLXRlc3QtY2lyY3VsYXItc3BlY3MgKCkK KyAgIlRlc3QgdGhhdCBjaXJjdWxhciBpbWFnZSBzcGVjIHByb3BlcnR5IHZhbHVlcyBkbyBub3Qg Y2F1c2UgaW5maW5pdGUgcmVjdXJzaW9uLiIKKyAgKHNob3VsZAorICAgKGxldCogKChjaXJjMSAo Y29ucyA6ZHVtbXkgbmlsKSkKKyAgICAgICAgICAoY2lyYzIgKGNvbnMgOmR1bW15IG5pbCkpCisg ICAgICAgICAgKHNwZWMxIGAoaW1hZ2UgOnR5cGUgeGJtIDp3aWR0aCAxIDpoZWlnaHQgMQorICAg ICAgICAgICAgICAgICAgICAgICAgIDpkYXRhICwoYm9vbC12ZWN0b3IgMSkgOmlnbm9yZWQgLGNp cmMxKSkKKyAgICAgICAgICAoc3BlYzIgYChpbWFnZSA6dHlwZSB4Ym0gOndpZHRoIDEgOmhlaWdo dCAxCisgICAgICAgICAgICAgICAgICAgICAgICA6ZGF0YSAsKGJvb2wtdmVjdG9yIDEpIDppZ25v cmVkICxjaXJjMikpKQorICAgICAoc2V0Y2RyIGNpcmMxIGNpcmMxKQorICAgICAoc2V0Y2RyIGNp cmMyIGNpcmMyKQorICAgICAoYW5kIChlcXVhbCAoaW1hZ2Utc2l6ZSBzcGVjMSB0KSAoY29ucyAx IDEpKQorICAgICAgICAgIChlcXVhbCAoaW1hZ2Utc2l6ZSBzcGVjMiB0KSAoY29ucyAxIDEpKSkp KSkKKworKHByb3ZpZGUgJ2ltYWdlLXRlc3RzKQorOzs7IGltYWdlLXRlc3RzLmVsIGVuZHMgaGVy ZS4KLS0gCjIuMjIuMAoK --000000000000e3a295058e3c38b5-- From unknown Sun Jun 22 04:02:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36403: 27.0.50; Trivial image.c bugs Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Jul 2019 06:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Pip Cet Cc: 36403@debbugs.gnu.org Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.156412422328596 (code B ref 36403); Fri, 26 Jul 2019 06:58:02 +0000 Received: (at 36403) by debbugs.gnu.org; 26 Jul 2019 06:57:03 +0000 Received: from localhost ([127.0.0.1]:40761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hquA2-0007RA-Jm for submit@debbugs.gnu.org; Fri, 26 Jul 2019 02:57:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hquA0-0007Qf-9E for 36403@debbugs.gnu.org; Fri, 26 Jul 2019 02:57:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59010) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hqu9t-0002ZC-DA; Fri, 26 Jul 2019 02:56:55 -0400 Received: from [176.228.60.248] (port=3221 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hqu9r-0004YW-Ha; Fri, 26 Jul 2019 02:56:52 -0400 Date: Fri, 26 Jul 2019 09:56:46 +0300 Message-Id: <83tvb9mggh.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Pip Cet on Mon, 22 Jul 2019 02:55:50 +0000) References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Pip Cet > Date: Mon, 22 Jul 2019 02:55:50 +0000 > Cc: 36403@debbugs.gnu.org > > On Fri, Jun 28, 2019 at 7:53 PM Eli Zaretskii wrote: > > > Attached patch has tests and fixes. > > > > Thanks. Let's wait for a few days to let others comment. > > Rebased patch attached. Thanks. Now that I applied this and looked into the results and the code, I have a few questions/comments. Sorry I didn't see this earlier. In your bug report, you say, among other things: > (insert-image `(image :dummy :type :type xbm :height 1 :width 1 :data > ,(bool-vector t))) > > produces an error. It should arguably behave the same as > > (insert-image `(image :dummy :dummy :type xbm :height 1 :width 1 :data > ,(bool-vector t))) Can you explain why these two are equivalent? > (equal_lists): Introduce. > (search_image_cache): Use `equal_lists'. I don't think I understand why we need this new function. Can you explain? Finally, 2 of the tests fail for me: $ make src/image-tests.log ELC src/image-tests.elc GEN src/image-tests.log Running 4 tests (2019-07-26 09:49:33+0300, selector `(not (tag :unstable))') Test image-test-:type-property-value backtrace: signal(error ("Window system frame should be used")) apply(signal (error ("Window system frame should be used"))) (setq value-13 (apply fn-11 args-12)) (unwind-protect (setq value-13 (apply fn-11 args-12)) (setq form-des (if (unwind-protect (setq value-13 (apply fn-11 args-12)) (setq form (let (form-description-15) (if (unwind-protect (setq value-13 (apply (let ((value-13 'ert-form-evaluation-aborted-14)) (let (form-descrip (let* ((fn-11 #'equal) (args-12 (condition-case err (let ((signal-ho (lambda nil (let* ((fn-11 #'equal) (args-12 (condition-case err (let ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name image-test-:type-property-value :docu ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable)) ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type ert-run-tests-batch((not (tag :unstable))) ert-run-tests-batch-and-exit((not (tag :unstable))) eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t) command-line-1((#("-L" 0 2 (charset cp862)) #(";." 0 2 (charset cp86 command-line() normal-top-level() Test image-test-:type-property-value condition: (error "Window system frame should be used") FAILED 1/4 image-test-:type-property-value (0.000000 sec) passed 2/4 image-test-circular-plist (0.000000 sec) Test image-test-circular-specs backtrace: image-size((image :type xbm :width 1 :height 1 :data #&1"\1" :ignore (equal (image-size spec1 t) (cons 1 1)) (and (equal (image-size spec1 t) (cons 1 1)) (equal (image-size spec (let* ((circ1 (cons :dummy nil)) (circ2 (cons :dummy nil)) (spec1 (l (setq value-16 (let* ((circ1 (cons :dummy nil)) (circ2 (cons :dummy (unwind-protect (setq value-16 (let* ((circ1 (cons :dummy nil)) (cir (if (unwind-protect (setq value-16 (let* ((circ1 (cons :dummy nil)) (let (form-description-17) (if (unwind-protect (setq value-16 (let* (let ((value-16 (gensym "ert-form-evaluation-aborted-"))) (let (form (lambda nil (let ((value-16 (gensym "ert-form-evaluation-aborted-")) ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name image-test-circular-specs :documentat ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable)) ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type ert-run-tests-batch((not (tag :unstable))) ert-run-tests-batch-and-exit((not (tag :unstable))) eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t) command-line-1((#("-L" 0 2 (charset cp862)) #(";." 0 2 (charset cp86 command-line() normal-top-level() Test image-test-circular-specs condition: (error "Window system frame should be used") FAILED 3/4 image-test-circular-specs (0.000000 sec) passed 4/4 image-test-duplicate-keywords (0.000000 sec) Ran 4 tests, 2 results as expected, 2 unexpected (2019-07-26 09:49:35+0300, 1.906250 sec) 2 unexpected results: FAILED image-test-:type-property-value FAILED image-test-circular-specs From unknown Sun Jun 22 04:02:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36403: 27.0.50; Trivial image.c bugs Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jul 2019 14:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 36403@debbugs.gnu.org Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.156432549217480 (code B ref 36403); Sun, 28 Jul 2019 14:52:02 +0000 Received: (at 36403) by debbugs.gnu.org; 28 Jul 2019 14:51:32 +0000 Received: from localhost ([127.0.0.1]:46964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrkWJ-0004Xs-Qh for submit@debbugs.gnu.org; Sun, 28 Jul 2019 10:51:32 -0400 Received: from mail-oi1-f181.google.com ([209.85.167.181]:41423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrkWI-0004Xd-38 for 36403@debbugs.gnu.org; Sun, 28 Jul 2019 10:51:30 -0400 Received: by mail-oi1-f181.google.com with SMTP id g7so43546481oia.8 for <36403@debbugs.gnu.org>; Sun, 28 Jul 2019 07:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AaVQutwkgaH+1iKgi78YlgThg96A7UDol8B1jjcTgmg=; b=TwxzjJVymypq7AgvvsnqRN6cxFo++MQX/Ep8jcVHdQthXW6HJTnamKkc5ldqS1OlcC GS3h7rGm1Unc9P1o2SpiMD1TAL5s9pP4EI2K6aLn0cVh2TQzEZtwDFefMLij0xgSPy/y qRIrxZspr+VAPNpNpxI3laXX52Gi0sr9CdGD8n37Dh/ooBMjC7tpBIUYQoaorMDo5hOw Qn8sxg9Yg1YwziIDgPEH1f0QXAIOkH7bwIicGZQ5Y2Io2cSGdQSq7YF8l69mbr2N51q7 GB8s7YV5ad+CI1dboSpFHx4QM4I/UTMiocsyuaVg/dxteSO9hN6RPQ7Wc3+/KTFGKHwf mrGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AaVQutwkgaH+1iKgi78YlgThg96A7UDol8B1jjcTgmg=; b=J/py5KYXOxQPwx/19xt8waIPPWPO8G82OwUbLlDRjOnc8dHYY+CqGA67rOrbQ+jH5u Ezv0EGy6T6wmHHNrBIT0VOSr1UXTGlYhV0pgEnqY5VQtBEu8eSD/JQ+MDVAzQeFDqSKd 9FZ0qqK0fQ6j+wxpPSbgICr8v+W3hYpIgqINMxdWzCGEraUHlz12Ad7rStqCFEAOdZcf WC9LfEUr9xKUfzOjlMnuRJ5Ud2kVPiCN7G1Zg4wj5S6t8LnY4lZBBzCKz+aBQ6j3YO5k vxjA1k/ofrm51GH4T4N7oq9vJhQi6/XOP8FXvl3hIFDwIQMSSb/OV89V84XCAMLsvsaM LPQA== X-Gm-Message-State: APjAAAUqhp3/RDj01XGhHItFsKzfXQSJxeXjX1yS9XbaPAvCjQuU3iA/ M1CzYQu1Rf5STmBFP3n6LYADMg+wRrkUJEqNLlDQww== X-Google-Smtp-Source: APXvYqyhliUley7FDuzBFjQo/HawfKMzmjiCyTjxYmfnMwsBI/aBYnMj7d5ZwQWqf/vfsjcSAWe3v1J/o4JtfQUYbqc= X-Received: by 2002:a05:6808:313:: with SMTP id i19mr50018878oie.30.1564325484167; Sun, 28 Jul 2019 07:51:24 -0700 (PDT) MIME-Version: 1.0 References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> <83tvb9mggh.fsf@gnu.org> In-Reply-To: <83tvb9mggh.fsf@gnu.org> From: Pip Cet Date: Sun, 28 Jul 2019 14:50:47 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Jul 26, 2019 at 6:56 AM Eli Zaretskii wrote: > > From: Pip Cet > > Date: Mon, 22 Jul 2019 02:55:50 +0000 > > Cc: 36403@debbugs.gnu.org > > > > On Fri, Jun 28, 2019 at 7:53 PM Eli Zaretskii wrote: > > > > Attached patch has tests and fixes. > > > > > > Thanks. Let's wait for a few days to let others comment. > > > > Rebased patch attached. > > Thanks. > > Now that I applied this and looked into the results and the code, I > have a few questions/comments. Sorry I didn't see this earlier. No problem at all, and thank you, as always, for your thoughtful comments! > In your bug report, you say, among other things: > > > (insert-image `(image :dummy :type :type xbm :height 1 :width 1 :data > > ,(bool-vector t))) > > > > produces an error. It should arguably behave the same as > > > > (insert-image `(image :dummy :dummy :type xbm :height 1 :width 1 :data > > ,(bool-vector t))) > > Can you explain why these two are equivalent? The ":dummy" property should be ignored, whether its value is ":dummy" or ":type"; previously, we used the first occurence of :type even if it was at an odd offset in the plist. > > (equal_lists): Introduce. > > (search_image_cache): Use `equal_lists'. > > I don't think I understand why we need this new function. Can you explain? IIRC, Fequal throwing a signal at this point caused a livelock, so we needed a stricter check. I'll look into it again to see whether there's a better alternative. Thanks again! From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 24 12:25:24 2019 Received: (at control) by debbugs.gnu.org; 24 Sep 2019 16:25:24 +0000 Received: from localhost ([127.0.0.1]:39956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCncw-0002Rv-OG for submit@debbugs.gnu.org; Tue, 24 Sep 2019 12:25:24 -0400 Received: from quimby.gnus.org ([80.91.231.51]:39712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCncs-0002Rf-Cg for control@debbugs.gnu.org; Tue, 24 Sep 2019 12:25:18 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iCncp-000162-NM for control@debbugs.gnu.org; Tue, 24 Sep 2019 18:25:17 +0200 Date: Tue, 24 Sep 2019 18:25:15 +0200 Message-Id: <877e5xzmok.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #36403 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 36403 + patch quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 36403 + patch quit From unknown Sun Jun 22 04:02:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36403: 27.0.50; Trivial image.c bugs Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Sep 2019 16:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Pip Cet Cc: Eli Zaretskii , 36403@debbugs.gnu.org Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.15693424229608 (code B ref 36403); Tue, 24 Sep 2019 16:28:01 +0000 Received: (at 36403) by debbugs.gnu.org; 24 Sep 2019 16:27:02 +0000 Received: from localhost ([127.0.0.1]:39961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCneX-0002Up-VC for submit@debbugs.gnu.org; Tue, 24 Sep 2019 12:27:02 -0400 Received: from quimby.gnus.org ([80.91.231.51]:39748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCneV-0002UZ-OU for 36403@debbugs.gnu.org; Tue, 24 Sep 2019 12:27:00 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iCneS-00016e-HB; Tue, 24 Sep 2019 18:26:58 +0200 From: Lars Ingebrigtsen References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> <83tvb9mggh.fsf@gnu.org> Date: Tue, 24 Sep 2019 18:26:55 +0200 In-Reply-To: (Pip Cet's message of "Sun, 28 Jul 2019 14:50:47 +0000") Message-ID: <8736glzmls.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Pip Cet writes: > IIRC, Fequal throwing a signal at this point caused a livelock, so we > needed a stricter check. I'll look into it again to see whether > there's a better alternative. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pip Cet writes: > IIRC, Fequal throwing a signal at this point caused a livelock, so we > needed a stricter check. I'll look into it again to see whether > there's a better alternative. This was eight weeks ago, and as far as I can tell, the patch (which looks sensible) wasn't applied. Has there been any further progress here? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 04:02:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36403: 27.0.50; Trivial image.c bugs Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Aug 2020 07:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Pip Cet Cc: Eli Zaretskii , 36403@debbugs.gnu.org Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.15964408529206 (code B ref 36403); Mon, 03 Aug 2020 07:48:01 +0000 Received: (at 36403) by debbugs.gnu.org; 3 Aug 2020 07:47:32 +0000 Received: from localhost ([127.0.0.1]:44074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2VBz-0002O8-RS for submit@debbugs.gnu.org; Mon, 03 Aug 2020 03:47:32 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2VBx-0002Il-Cc for 36403@debbugs.gnu.org; Mon, 03 Aug 2020 03:47:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hSK3AA4d4TrvW4JuX5hA5475S6cZmexGqgFIZFDbZRw=; b=NVXfJRctGCzdPdERYiUzeQU2rH CLM3MpQTCGPuq0RRPv4ksYD/UJt7eJbsghMKaPGono03F8Nqk97+8AFDSGLVeYpgwjJgSJFsQoPe/ ZFvLO3isNA2gkUjyXkRMji+e89f/RL/EaWXlSw/lQL2qAsBV5ZDcTMwcm5nPfU8iGPq8=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2VBo-0005ic-H9; Mon, 03 Aug 2020 09:47:23 +0200 From: Lars Ingebrigtsen References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> <83tvb9mggh.fsf@gnu.org> <8736glzmls.fsf@gnus.org> Date: Mon, 03 Aug 2020 09:47:18 +0200 In-Reply-To: <8736glzmls.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 24 Sep 2019 18:26:55 +0200") Message-ID: <87h7tkw4qh.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > Pip Cet writes: > >> IIRC, Fequal throwing a signal at this point caused a livelock, so we >> needed a stricter check. I'll look into it again to see whether >> there's a better a [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Pip Cet writes: > >> IIRC, Fequal throwing a signal at this point caused a livelock, so we >> needed a stricter check. I'll look into it again to see whether >> there's a better alternative. > > This was eight weeks ago, and as far as I can tell, the patch (which > looks sensible) wasn't applied. Has there been any further progress > here? And that was 44 weeks ago. :-) The patch still applies. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 04:02:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36403: 27.0.50; Trivial image.c bugs Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Aug 2020 16:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Pip Cet Cc: Eli Zaretskii , 36403@debbugs.gnu.org Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.159776811422373 (code B ref 36403); Tue, 18 Aug 2020 16:29:02 +0000 Received: (at 36403) by debbugs.gnu.org; 18 Aug 2020 16:28:34 +0000 Received: from localhost ([127.0.0.1]:36761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k84TS-0005on-Ff for submit@debbugs.gnu.org; Tue, 18 Aug 2020 12:28:34 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k84TO-0005oW-5O for 36403@debbugs.gnu.org; Tue, 18 Aug 2020 12:28:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HBhGdk4qEY8FNg6r+zkebBqCNtuGmLv+YSpwz9ehbLE=; b=F5D71tfUaSDnsqLWaaVTbpQNOS ijVgKoNspX2C5KKh+mLAtILOkAElgLspraoXLbJ9AEM/8kS0+w3IpQWzAF9OlxZquC4/6Zi9ECd/n tOsq1a/Dnq1gzmKkn2k50wkfoOu1S99zNDkC0jE7mc/6GwhynXHXw0bM0LASCxVlHPbY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k84TE-0000JT-Pw; Tue, 18 Aug 2020 18:28:23 +0200 From: Lars Ingebrigtsen References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> <83tvb9mggh.fsf@gnu.org> <8736glzmls.fsf@gnus.org> <87h7tkw4qh.fsf@gnus.org> X-Now-Playing: Cocteau Twins's _Victorialand_: "Throughout the Dark Months of April and May" Date: Tue, 18 Aug 2020 18:28:19 +0200 In-Reply-To: <87h7tkw4qh.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 03 Aug 2020 09:47:18 +0200") Message-ID: <87blj7j4v0.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > Lars Ingebrigtsen writes: > >> Pip Cet writes: >> >>> IIRC, Fequal throwing a signal at this point caused a livelock, so we >>> needed a stricter check. I'll look [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Lars Ingebrigtsen writes: > >> Pip Cet writes: >> >>> IIRC, Fequal throwing a signal at this point caused a livelock, so we >>> needed a stricter check. I'll look into it again to see whether >>> there's a better alternative. >> >> This was eight weeks ago, and as far as I can tell, the patch (which >> looks sensible) wasn't applied. Has there been any further progress >> here? > > And that was 44 weeks ago. :-) The patch still applies. I've now applied the patch, but I moved the test suite to test/manual -- they call `image-size', which requires a frame to be present... which isn't the case when running "make test", unfortunately. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 18 12:28:54 2020 Received: (at control) by debbugs.gnu.org; 18 Aug 2020 16:28:54 +0000 Received: from localhost ([127.0.0.1]:36764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k84TZ-0005p5-N9 for submit@debbugs.gnu.org; Tue, 18 Aug 2020 12:28:54 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k84TT-0005oc-2T for control@debbugs.gnu.org; Tue, 18 Aug 2020 12:28:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=83OYZkJ3ttI5aeP/eEyNvp3vtGzdCNQLkQN4fucDNF0=; b=vS9d9jFqzolw3siYYpf1sLsDl1 /WyS5NWnqKbH7vRZRIvEXqF+Nv5rGMWQeiOJwO5LXK44vthfL93sY1k1IMaGlIvpT+j9HpmtQcsnw HzJvwmflaqLzajfAFTUemZFhNjmwbznehyRpEnPCKLO42XI11ICLzGaV1XPYOBClyVzM=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k84TL-0000Jd-BY for control@debbugs.gnu.org; Tue, 18 Aug 2020 18:28:29 +0200 Date: Tue, 18 Aug 2020 18:28:26 +0200 Message-Id: <87a6yrj4ut.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #36403 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 36403 fixed close 36403 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 36403 fixed close 36403 28.1 quit From unknown Sun Jun 22 04:02:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36403: 27.0.50; Trivial image.c bugs Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Aug 2020 23:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Lars Ingebrigtsen Cc: 36403@debbugs.gnu.org, Pip Cet Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.159796462718485 (code B ref 36403); Thu, 20 Aug 2020 23:04:01 +0000 Received: (at 36403) by debbugs.gnu.org; 20 Aug 2020 23:03:47 +0000 Received: from localhost ([127.0.0.1]:44395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8tb0-0004o5-QU for submit@debbugs.gnu.org; Thu, 20 Aug 2020 19:03:47 -0400 Received: from mailout-l3b-97.contactoffice.com ([212.3.242.97]:49562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8taw-0004np-Ac for 36403@debbugs.gnu.org; Thu, 20 Aug 2020 19:03:45 -0400 Received: from smtpauth2.co-bxl (smtpauth2.co-bxl [10.2.0.24]) by mailout-l3b-97.contactoffice.com (Postfix) with ESMTP id BD47E76D; Fri, 21 Aug 2020 01:03:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1597964615; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To; l=1106; bh=vHa6v9LGFRrlq2VhGp2j6QqLZD9f/RDrrT4lyW73yGI=; b=H9UDmQOWU8NtLs9oL6bPWkLpsAlSv/4sL13/8VwH28tC4GxrMjk9uwEb0nnjenuH akTqsLG4MgTJI8IVQFU8MYMGpX12qWFnMBVnulOHSw+H5nju+i8HJYEn7t5IaK547w6 yTMW0qfALJiu6g5rrsD7mOhvoi5FRvTeso0/pGa7T1bfskkF6QqYCCMHhzV9FqY5mfM P66TaCz5VCKGRf9huDyCAGBuaPXIMji89fEGhgLFlmuLiYaMjQF50+u3Em4zGZuiTU8 w+csNhPDrpUdmrcz3xqm3CEMUZkULhlh05qUiHVeD2q65BOHYlml6bDbp6q3y0gDWbK Rey/oWPfag== Received: by smtp.mailfence.com with ESMTPA ; Fri, 21 Aug 2020 01:03:33 +0200 (CEST) Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 2E4DE2024B50F4; Fri, 21 Aug 2020 00:03:32 +0100 (BST) Date: Fri, 21 Aug 2020 01:03:34 +0200 (CEST) From: Alan Third Message-ID: <20200820230332.GB38852@breton.holly.idiocy.org> Mail-Followup-To: Alan Third , Lars Ingebrigtsen , Pip Cet , 36403@debbugs.gnu.org References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> <83tvb9mggh.fsf@gnu.org> <8736glzmls.fsf@gnus.org> <87h7tkw4qh.fsf@gnus.org> <87blj7j4v0.fsf@gnus.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87blj7j4v0.fsf@gnus.org> X-Spam-Flag: NO X-Spam-Status: No, hits=-2.9 required=4.7 symbols=ALL_TRUSTED, BAYES_00 device=10.2.0.20 X-ContactOffice-Account: com:241649512 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Tue, Aug 18, 2020 at 06:28:19PM +0200, Lars Ingebrigtsen wrote: > Lars Ingebrigtsen writes: > > > Lars Ingebrigtsen writes: > > > >> Pip Cet writes: > >> > >>> IIRC, Fequal throwing a signal at this point caused a livelock, so we > >>> needed a stricter check. I'll look into it again to see whether > >>> there's a better alternative. > >> > >> This was eight weeks ago, and as far as I can tell, the patch (which > >> looks sensible) wasn't applied. Has there been any further progress > >> here? > > > > And that was 44 weeks ago. :-) The patch still applies. > > I've now applied the patch, but I moved the test suite to test/manual -- > they call `image-size', which requires a frame to be present... which > isn't the case when running "make test", unfortunately. Hi, this patch appears to have broken something (in NS at least) and now interactively resizing an image no longer causes the image to be immediately redisplayed. I have to force a redisplay some other way before I see the resized image. -- Alan Third From unknown Sun Jun 22 04:02:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36403: 27.0.50; Trivial image.c bugs Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Aug 2020 23:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Alan Third Cc: 36403@debbugs.gnu.org, Pip Cet Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.159796526019404 (code B ref 36403); Thu, 20 Aug 2020 23:15:01 +0000 Received: (at 36403) by debbugs.gnu.org; 20 Aug 2020 23:14:20 +0000 Received: from localhost ([127.0.0.1]:44412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8tlD-00052u-RL for submit@debbugs.gnu.org; Thu, 20 Aug 2020 19:14:20 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8tlB-00052O-Oc for 36403@debbugs.gnu.org; Thu, 20 Aug 2020 19:14:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eJQ29A0rnTpm6Q9Zc0M7mlHBEUCWwXa4XaEOsJc1kzk=; b=i2Rvzu9KNgkcd7lN6lgJyKZu4s BGWaJN0xydj2V32VwOMnBP1FJ+UcKYLMLuH7d1EbtxGl8V73eoLawyh74sJRdL4h7OB+Lm7Zm4BeY lMLqMuMdjOaId+F8d9rSp0Y5f8neUzMC3p2l4vpdoJ2/StFQ+P/A1Zh7fR1b4ENU8AmQ=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8tku-00045t-A0; Fri, 21 Aug 2020 01:14:10 +0200 From: Lars Ingebrigtsen References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> <83tvb9mggh.fsf@gnu.org> <8736glzmls.fsf@gnus.org> <87h7tkw4qh.fsf@gnus.org> <87blj7j4v0.fsf@gnus.org> <20200820230332.GB38852@breton.holly.idiocy.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEUcGxogHhsmIh0v KiFEOib///9JOwZRAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+QIFBcMGX+9KgQAAAGmSURBVDjLxVPb keQgDJTwBCDBBgBiAzCIBPaY/GM6AWOP9zFXdV/LB2Wr6ZbUAoDfW/i/AL8AkF5K8b+BOHdHl5Tz a8OJeAdJngxvBLcIyWF6MgKgUxXxf7a9tlKIv/ZBACLKrDTibAzGJMwu7wBhJ61wADm0yhS0pqhb b6WKEA5BLMV2cWC/uQCKi2RVvdFWJILzNZNqAqzq3QJUtUl6ryr9XuVduzYVy2Td+RgfDTB7RLaV jIEoYZT0xaubSVktVorES3xVRQQOEOlwg03N+tAWXa0Wni2bxYiDEdCcyn24tc/j9JAyt4JZ8Tmz LavqXremXSRxXBnmGqZDllysgxTX6dkIbN6Eyjk5XOfZw9ve6tanUjrDUwqrr6GwFxs48gnBtoN1 rQ8dSqfU7eMem95NS3y0AiwoExi9JM724w0YsbXBZkMll3W24EowME7gJtpdb90S5ZC1V52fad6g sMcjp+oYgMi8XVhpWU4gGYke88DxTJimn07K4BHz8Qx42k0oK4YngHj1Ci/ANX7MfF3o59XmOZKf XuZB+/b8+AUArxiL8xeaUTbcszVHHwAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0wOC0yMFQyMzox MjoyNCswMDowMP60b0AAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMDgtMjBUMjM6MTI6MjQrMDA6 MDCP6df8AAAAAElFTkSuQmCC X-Now-Playing: Telefon Tel Aviv's _Dreams Are Not Enough_: "eyes glaring," Date: Fri, 21 Aug 2020 01:13:58 +0200 In-Reply-To: <20200820230332.GB38852@breton.holly.idiocy.org> (Alan Third's message of "Fri, 21 Aug 2020 01:03:34 +0200 (CEST)") Message-ID: <87v9hcj4g9.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alan Third writes: > Hi, this patch appears to have broken something (in NS at least) and > now interactively resizing an image no longer causes the image to be > immediately redisplayed. I have to force a redisplay som [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alan Third writes: > Hi, this patch appears to have broken something (in NS at least) and > now interactively resizing an image no longer causes the image to be > immediately redisplayed. I have to force a redisplay some other way > before I see the resized image. Yup. This patch fixes things for me (on Debian)... diff --git a/src/image.c b/src/image.c index 643b3d0a1f..ceb690ed0a 100644 --- a/src/image.c +++ b/src/image.c @@ -1633,7 +1633,7 @@ search_image_cache (struct frame *f, Lisp_Object spec, EMACS_UINT hash) for (img = c->buckets[i]; img; img = img->next) if (img->hash == hash - && !equal_lists (img->spec, spec) + && !NILP (Fequal (img->spec, spec)) && img->frame_foreground == FRAME_FOREGROUND_PIXEL (f) && img->frame_background == FRAME_BACKGROUND_PIXEL (f)) break; The equal_lists thing looks sensible, but I guess we do destructive alterations with +/-, possibly, to equal is the correct thing, not a list-of-eqs? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 04:02:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36403: 27.0.50; Trivial image.c bugs Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Aug 2020 23:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Alan Third Cc: 36403@debbugs.gnu.org, Pip Cet Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.159796546119730 (code B ref 36403); Thu, 20 Aug 2020 23:18:02 +0000 Received: (at 36403) by debbugs.gnu.org; 20 Aug 2020 23:17:41 +0000 Received: from localhost ([127.0.0.1]:44417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8toT-000589-AT for submit@debbugs.gnu.org; Thu, 20 Aug 2020 19:17:41 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8toR-00057w-UP for 36403@debbugs.gnu.org; Thu, 20 Aug 2020 19:17:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=50pVB7avjwqyTvrnb4hMi728ybnE05dgNFkuA087I28=; b=NgY/LMGpQiB8j0JNHjgBSC+A/R zkEcr860jV1J7IKd5SxHGpQVkshpEZ7PK2Ec2x0BPz+EtAmfC+Awbpp5pXxdkIfrS6qUVTarWc4ZD bGs0JfdaVjDh6Kvv01TeO8vRxsrP5za0w/hv6BBaZ7xwFm+zF+zKsDgQaccXdBYLD4Eo=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8toH-00046q-R2; Fri, 21 Aug 2020 01:17:33 +0200 From: Lars Ingebrigtsen References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> <83tvb9mggh.fsf@gnu.org> <8736glzmls.fsf@gnus.org> <87h7tkw4qh.fsf@gnus.org> <87blj7j4v0.fsf@gnus.org> <20200820230332.GB38852@breton.holly.idiocy.org> <87v9hcj4g9.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEUcGxogHhsmIh0v KiFEOib///9JOwZRAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+QIFBcMGX+9KgQAAAGmSURBVDjLxVPb keQgDJTwBCDBBgBiAzCIBPaY/GM6AWOP9zFXdV/LB2Wr6ZbUAoDfW/i/AL8AkF5K8b+BOHdHl5Tz a8OJeAdJngxvBLcIyWF6MgKgUxXxf7a9tlKIv/ZBACLKrDTibAzGJMwu7wBhJ61wADm0yhS0pqhb b6WKEA5BLMV2cWC/uQCKi2RVvdFWJILzNZNqAqzq3QJUtUl6ryr9XuVduzYVy2Td+RgfDTB7RLaV jIEoYZT0xaubSVktVorES3xVRQQOEOlwg03N+tAWXa0Wni2bxYiDEdCcyn24tc/j9JAyt4JZ8Tmz LavqXremXSRxXBnmGqZDllysgxTX6dkIbN6Eyjk5XOfZw9ve6tanUjrDUwqrr6GwFxs48gnBtoN1 rQ8dSqfU7eMem95NS3y0AiwoExi9JM724w0YsbXBZkMll3W24EowME7gJtpdb90S5ZC1V52fad6g sMcjp+oYgMi8XVhpWU4gGYke88DxTJimn07K4BHz8Qx42k0oK4YngHj1Ci/ANX7MfF3o59XmOZKf XuZB+/b8+AUArxiL8xeaUTbcszVHHwAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0wOC0yMFQyMzox MjoyNCswMDowMP60b0AAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMDgtMjBUMjM6MTI6MjQrMDA6 MDCP6df8AAAAAElFTkSuQmCC X-Now-Playing: Telefon Tel Aviv's _Dreams Are Not Enough_: "not seeing," Date: Fri, 21 Aug 2020 01:17:28 +0200 In-Reply-To: <87v9hcj4g9.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 21 Aug 2020 01:13:58 +0200") Message-ID: <87r1s0j4af.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > The equal_lists thing looks sensible, but I guess we do destructive > alterations with +/-, possibly, to equal is the correct thing, not a > list-of-eqs? That should be "so equal is the correct thing"... Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > The equal_lists thing looks sensible, but I guess we do destructive > alterations with +/-, possibly, to equal is the correct thing, not a > list-of-eqs? That should be "so equal is the correct thing"... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 04:02:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36403: 27.0.50; Trivial image.c bugs Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Aug 2020 23:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Alan Third Cc: 36403@debbugs.gnu.org, Pip Cet Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.159796636128916 (code B ref 36403); Thu, 20 Aug 2020 23:33:02 +0000 Received: (at 36403) by debbugs.gnu.org; 20 Aug 2020 23:32:41 +0000 Received: from localhost ([127.0.0.1]:44435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8u2z-0007W9-9e for submit@debbugs.gnu.org; Thu, 20 Aug 2020 19:32:41 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8u2w-0007QN-LI for 36403@debbugs.gnu.org; Thu, 20 Aug 2020 19:32:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ad/Ao3T+e9tXUeskoFV1ybUsa/kPH56vcRqWqSlLiAI=; b=TfwRJYY7HDO2dVhqrgZvV2z6hD 0Yh4aSl6V2pgcDi1+YZ897zMRiMPFA/ds4hEEKiNT9Q/GNogK3T2/Lrqy+nyNuIJEGehv/79KPOhI 6yTyR5LIeLZEDuHUGCvZYnnLEnnOmW1K6wqKUhS8HYqmsR7iAauxviJdDf3o5V0CJOlY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8u2m-0004Gv-J5; Fri, 21 Aug 2020 01:32:32 +0200 From: Lars Ingebrigtsen References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> <83tvb9mggh.fsf@gnu.org> <8736glzmls.fsf@gnus.org> <87h7tkw4qh.fsf@gnus.org> <87blj7j4v0.fsf@gnus.org> <20200820230332.GB38852@breton.holly.idiocy.org> <87v9hcj4g9.fsf@gnus.org> <87r1s0j4af.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEUcGxogHhsmIh0v KiFEOib///9JOwZRAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+QIFBcMGX+9KgQAAAGmSURBVDjLxVPb keQgDJTwBCDBBgBiAzCIBPaY/GM6AWOP9zFXdV/LB2Wr6ZbUAoDfW/i/AL8AkF5K8b+BOHdHl5Tz a8OJeAdJngxvBLcIyWF6MgKgUxXxf7a9tlKIv/ZBACLKrDTibAzGJMwu7wBhJ61wADm0yhS0pqhb b6WKEA5BLMV2cWC/uQCKi2RVvdFWJILzNZNqAqzq3QJUtUl6ryr9XuVduzYVy2Td+RgfDTB7RLaV jIEoYZT0xaubSVktVorES3xVRQQOEOlwg03N+tAWXa0Wni2bxYiDEdCcyn24tc/j9JAyt4JZ8Tmz LavqXremXSRxXBnmGqZDllysgxTX6dkIbN6Eyjk5XOfZw9ve6tanUjrDUwqrr6GwFxs48gnBtoN1 rQ8dSqfU7eMem95NS3y0AiwoExi9JM724w0YsbXBZkMll3W24EowME7gJtpdb90S5ZC1V52fad6g sMcjp+oYgMi8XVhpWU4gGYke88DxTJimn07K4BHz8Qx42k0oK4YngHj1Ci/ANX7MfF3o59XmOZKf XuZB+/b8+AUArxiL8xeaUTbcszVHHwAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0wOC0yMFQyMzox MjoyNCswMDowMP60b0AAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMDgtMjBUMjM6MTI6MjQrMDA6 MDCP6df8AAAAAElFTkSuQmCC X-Now-Playing: Telefon Tel Aviv's _Dreams Are Not Enough_: "still as stone in a watery fane." Date: Fri, 21 Aug 2020 01:32:27 +0200 In-Reply-To: <87r1s0j4af.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 21 Aug 2020 01:17:28 +0200") Message-ID: <87imdcj3lg.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: D'oh. Pip's patch here just had reverse logic -- removing the ! from before the equal_lists fixes the issue for me, so I've now pushed that fix. for (img = c->buckets[i]; img; img = img->next) if (img->hash == hash - && !NILP (Fequal (img->spec, spec)) + && !equal_lists (img->spec, spec) && img->frame_foreground == FRAME_FOREGROUND_PIXEL (f) [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) D'oh. Pip's patch here just had reverse logic -- removing the ! from before the equal_lists fixes the issue for me, so I've now pushed that fix. for (img = c->buckets[i]; img; img = img->next) if (img->hash == hash - && !NILP (Fequal (img->spec, spec)) + && !equal_lists (img->spec, spec) && img->frame_foreground == FRAME_FOREGROUND_PIXEL (f) && img->frame_background == FRAME_BACKGROUND_PIXEL (f)) I guess the !NILP (Fequal...) idiom tainted the rewrite... I've often wondered why we use !NILP instead of, like TRUEP or something. !NILP doesn't feel very natural. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 04:02:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36403: 27.0.50; Trivial image.c bugs Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Aug 2020 09:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Lars Ingebrigtsen Cc: Alan Third , 36403@debbugs.gnu.org Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.159800201515667 (code B ref 36403); Fri, 21 Aug 2020 09:27:01 +0000 Received: (at 36403) by debbugs.gnu.org; 21 Aug 2020 09:26:55 +0000 Received: from localhost ([127.0.0.1]:45037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k93K2-00044d-Pj for submit@debbugs.gnu.org; Fri, 21 Aug 2020 05:26:54 -0400 Received: from mail-ot1-f50.google.com ([209.85.210.50]:34411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k93K0-00044P-Tg for 36403@debbugs.gnu.org; Fri, 21 Aug 2020 05:26:53 -0400 Received: by mail-ot1-f50.google.com with SMTP id k12so1107425otr.1 for <36403@debbugs.gnu.org>; Fri, 21 Aug 2020 02:26:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PlzaRkrwLEF8Q6Hp9nta96d7iMZkCLYmXu4J7s8wa6c=; b=XDQFd0EuRKbZM2tLfPSWry8YP0ztjPS24ZJp6zcSnLWbTVPZvy0zpnNSbpFznporsA V599xN6AbdkwNdBIO/x/1zGDLuxSuVH/2Fdmqr5z5ZvCiFGRlkXm3LWVLMU4ibVQmG6c wejM6T7Bl6SNhztn/IUusQlxLGmXilecAB4BM+A+ep/k4wDNjZUFcvRMDAc4kgNoRsY5 Ewn/ova9aNH7Tg7WfOAuwqhNmkbDlUKslzhby6JvCs01CGPcFQGOJzuTgWEgfA78uY3K f7O3dlJ9WHWmaMU18R9u+lEpZhoihrGbYyFMs9MByIfIaeYckXFrG9n3r5kqWMDAl4XH 2wKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PlzaRkrwLEF8Q6Hp9nta96d7iMZkCLYmXu4J7s8wa6c=; b=kWVPseA4ejKolUcAujUo8XJMkMs9Or0pXDNuz3gJFGy8uPJfbSrrAHZqy4OVCGkvBC Ey5eTv0PDXYqQsAAe07EoIUS9TI4lV82pteGsNC2dPr1YkVGw8rlU/cPa2g7nnDRAf97 BWxFEyHS9SwzUI6eMEhMlgOor928oZj9gRIWQ6hb1szC3W/2enrcBwUAq5TS9yR9W9lX HVDhNMFHnw1FDAS0uT2SlR4riChTqbDy2mYoBLAFyu5P+HwC0OGb7X2tE/GjlIb6CGZP xomFtg5BMriREhleVzm69mc7mmP4k4dWIWNEXnmLMlauY4yzNcgtMJ06fCxgHP8w+xiD u0jw== X-Gm-Message-State: AOAM532JY83LHcrQ6H3Uw+OgneRqG1aGa8dDNoAsSENMPhqwBPSi0Ppe AoehfDVtYDmR3S1xMwTTyWmN+JalJluPSQfO1Ho= X-Google-Smtp-Source: ABdhPJzSXnxqeCY6+3Atcayy93ljbCi1hoYyuDFOEZE3rnpzcpE6IzetosFfs1YtqapWoAFQR2m/tr6XKQ3Jh7XPCTc= X-Received: by 2002:a05:6830:13d1:: with SMTP id e17mr1340474otq.292.1598002006921; Fri, 21 Aug 2020 02:26:46 -0700 (PDT) MIME-Version: 1.0 References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> <83tvb9mggh.fsf@gnu.org> <8736glzmls.fsf@gnus.org> <87h7tkw4qh.fsf@gnus.org> <87blj7j4v0.fsf@gnus.org> <20200820230332.GB38852@breton.holly.idiocy.org> <87v9hcj4g9.fsf@gnus.org> <87r1s0j4af.fsf@gnus.org> <87imdcj3lg.fsf@gnus.org> In-Reply-To: <87imdcj3lg.fsf@gnus.org> From: Pip Cet Date: Fri, 21 Aug 2020 09:26:10 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Aug 20, 2020 at 11:32 PM Lars Ingebrigtsen wrote: > for (img = c->buckets[i]; img; img = img->next) > if (img->hash == hash > - && !NILP (Fequal (img->spec, spec)) > + && !equal_lists (img->spec, spec) > && img->frame_foreground == FRAME_FOREGROUND_PIXEL (f) > && img->frame_background == FRAME_BACKGROUND_PIXEL (f)) > > I guess the !NILP (Fequal...) idiom tainted the rewrite... I can confirm it did. However, my stupidity is not a very good argument for changing Emacs, or all of it would need changing :-) > I've often wondered why we use !NILP instead of, like TRUEP or > something. !NILP doesn't feel very natural. Paul's suggestion was to use equal () instead of !NILP (Fequal (...)). I'm against that, because the F in Fequal kind of hints at the difficulties of using equal, of which there are many: in the current implementation, it can signal, quit, be asymmetric (signalling for (equal a b) whereas (equal b a) works), and is susceptible to equality bombs that take forever to compare. It cannot call Lisp, yet, but I wouldn't be surprised if that changes. It's really not a function you should use from C very often, and using it as a hash table predicate is often the wrong thing to do. Replacing !NILP is a better idea, but I'm struggling to come up with a good name for that. But even a bad name would be an improvement. From unknown Sun Jun 22 04:02:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36403: 27.0.50; Trivial image.c bugs Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Aug 2020 11:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Pip Cet Cc: Alan Third , 36403@debbugs.gnu.org Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.159800920012206 (code B ref 36403); Fri, 21 Aug 2020 11:27:01 +0000 Received: (at 36403) by debbugs.gnu.org; 21 Aug 2020 11:26:40 +0000 Received: from localhost ([127.0.0.1]:45153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k95Bv-0003An-Gk for submit@debbugs.gnu.org; Fri, 21 Aug 2020 07:26:39 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k95Bt-0003AZ-Bz for 36403@debbugs.gnu.org; Fri, 21 Aug 2020 07:26:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ob7SvlUlzppTE5ULRP6vXY5DSCedrj2GJgUk+lRgo1A=; b=XWAPbaYwFCH8a3Z7yPZDg2/g2m TF5od+snRScLkDgiiVSiPwbhjWCZ/rjce+cHo3Z8llyLMkbiJyKBMfbQ4C/oH/I43dlfs1dm6xHQB iP5sXfQ3Bil/TmfRQSckkshckJ9CnDaGinHqc/DlvKjuRjSmO2YucjN6XLY0XmPBoQ7E=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k95Bj-0002wG-CK; Fri, 21 Aug 2020 13:26:30 +0200 From: Lars Ingebrigtsen References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> <83tvb9mggh.fsf@gnu.org> <8736glzmls.fsf@gnus.org> <87h7tkw4qh.fsf@gnus.org> <87blj7j4v0.fsf@gnus.org> <20200820230332.GB38852@breton.holly.idiocy.org> <87v9hcj4g9.fsf@gnus.org> <87r1s0j4af.fsf@gnus.org> <87imdcj3lg.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEXt49Tws6X3YVj/ //9yIEcRAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+QIFQsDKup1aqwAAAE+SURBVCjPnZLBasMwDIbl 4oyuJwfiwnJfoX0KBZoedlIgDltOOaxj61P0tHM7KPQBktL6KScrTe6bwcaf/UeRfhngn0M5hyOU AHbYR+GS7pCMCx8GvVU4qFhU0qBSDlWv46OIHKwFWGy7tzKT73kuSOWIPbjXxpKABjh/lDNCwzAF db7oTUkBnlaT5khZQiF26o+HE1otMPcXrBC14dyh8C1xObpoGTJXkFkbVV0lgSXE68RubgIpzHUS vfQww0eyLh0gYkfuMMl5T6sAOT4TF2h3AeJrhcEsH0KbbWbYFPoJPzWzIkalslzA3nSo2DShOLPc BtgLLHwnVh7CWnifcdYghnwLTHt/a3+zCJ9KTIx3vj65dwkJD/bLseNGYIKJrfbNvZEEkcu7sXOR q9uh2ayox3ZbqWEYzv3l2fwCz29Ia1iemN0AAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMDgtMjFU MTE6MDM6NDErMDA6MDD2+vyfAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIwLTA4LTIxVDExOjAzOjQx KzAwOjAwh6dEIwAAAABJRU5ErkJggg== X-Now-Playing: Renaldo and the Loaf's _Songs for Swinging Larvae & Songs from the Surgery_: "Songs From The Surgery" Date: Fri, 21 Aug 2020 13:26:25 +0200 In-Reply-To: (Pip Cet's message of "Fri, 21 Aug 2020 09:26:10 +0000") Message-ID: <877dts8cke.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Pip Cet writes: > Paul's suggestion was to use equal () instead of !NILP (Fequal (...)). > I'm against that, because the F in Fequal kind of hints at the > difficulties of using equal, of which there are many: in the [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pip Cet writes: > Paul's suggestion was to use equal () instead of !NILP (Fequal (...)). > I'm against that, because the F in Fequal kind of hints at the > difficulties of using equal, of which there are many: in the current > implementation, it can signal, quit, be asymmetric (signalling for > (equal a b) whereas (equal b a) works), and is susceptible to equality > bombs that take forever to compare. Yeah, your equal_lists is better in all ways, I think. It should be much faster, too -- Fequal on a list checks whether the string members are equal, too, which is slow. So I think this will speed things up if you have a buffer that displays images where the data comes from a string (which can be huge) instead of a file. > Replacing !NILP is a better idea, but I'm struggling to come up with a > good name for that. But even a bad name would be an improvement. TRUEP is kinda obvious, isn't it? Although I guess some people would object on the grounds that only t is true, while all other non-nil values are only trueish. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 04 09:46:24 2022 Received: (at control) by debbugs.gnu.org; 4 Oct 2022 13:46:24 +0000 Received: from localhost ([127.0.0.1]:52946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofiFc-0004mO-6E for submit@debbugs.gnu.org; Tue, 04 Oct 2022 09:46:24 -0400 Received: from mail-ej1-f43.google.com ([209.85.218.43]:47065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofiFX-0004m7-4V for control@debbugs.gnu.org; Tue, 04 Oct 2022 09:46:22 -0400 Received: by mail-ej1-f43.google.com with SMTP id bj12so28941610ejb.13 for ; Tue, 04 Oct 2022 06:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date; bh=WytdMtZYMrs93IDLT+95Kn3MCbPLncW21A21wktAs7M=; b=TNbkrB1pSVNLXmaSDCHEQu4epLlMCNr+KPa0x8/lWeQzsNJ2n3oiUOBrGMZJjkA1EJ eRKAtErzJdY8TmSel/kGGWMGU9DnLEMPx1dwOXO9T4+oWaBID2JqDPqtVEujcRRDI1/U 53zGnQfIyLt7D43QXsjUgu3yisgbAwuNM4Sh7b/cefBgeUlcXRfDbUeLKxUUBFLL9RN3 87pQT7DDYXAB3sBGfrPuEGKkF7uu2G0HCnwSMLE4aoTc+GhKbF0Z8IqnBMq5+SoBiILa YdISCNBb5ywxeRfP5/zFYwvyX/cWukGOlwDChR9bRVDmUVSjVjMMX0q12gwkx1A1rq8H BaZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date; bh=WytdMtZYMrs93IDLT+95Kn3MCbPLncW21A21wktAs7M=; b=7lzZPjc3xPyoIZdPqa5FvVzMVNP+u2OsMXrpI/ko3dct4/6LTVl0X+cg3HQreAhsU4 FqweY2JEiyVK2h2tOnIcQTuCbKV+DVXUgqf2gyVQUAnKm0Rn7tT/m3LoPbQT/J2rCVM0 WP/CTPzg061x9STkmlZne8pE7c38qVClsQ4MJMBTI1GEz9RHqDMSBZB29RmVNOg9XrHW Z/8iNkz+vSdwx0we4zHEa74+HbwO3PlR1EnOoFtKGjMw9sXx/0uSKbGJIRpy7JrH+cav 2wGQZma6PLUZ7tQ4g9pkfNGfDEeUMLDcEXZdo57jCCfHB4v9ZxK4vJr2Vp9eYULEC+oP bfkA== X-Gm-Message-State: ACrzQf2UEWRo8W9o3TRGdSNZxBJ2N1aM9+gSwFnP+WjRjOo2ELhrILbb /kC2S9XIRX3q9TDXAK2NTWqff+1vOcaTyA== X-Google-Smtp-Source: AMsMyM5RzK3Sp8lM22XeFD8FXpqXPuPOY2GOhZHN3w1yPWRgUAbq3DeFiq5rkXep9LN5xNpkn2p0Bw== X-Received: by 2002:a17:906:ef8c:b0:77c:8d9a:9aed with SMTP id ze12-20020a170906ef8c00b0077c8d9a9aedmr20522404ejb.704.1664891172776; Tue, 04 Oct 2022 06:46:12 -0700 (PDT) Received: from localhost ([2a02:587:326a:a129:e754:c019:8715:df11]) by smtp.gmail.com with ESMTPSA id m10-20020a50998a000000b00456e6e64047sm1653485edb.94.2022.10.04.06.46.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 06:46:12 -0700 (PDT) From: "Basil L. Contovounesios" To: control@debbugs.gnu.org Subject: control message for bug #36403 Date: Tue, 04 Oct 2022 16:46:10 +0300 Message-ID: <87lepvya59.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) unarchive 36403 quit From unknown Sun Jun 22 04:02:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36403: 27.0.50; Trivial image.c bugs Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Oct 2022 13:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Lars Ingebrigtsen Cc: Alan Third , 36403@debbugs.gnu.org, Pip Cet Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.166489159019144 (code B ref 36403); Tue, 04 Oct 2022 13:54:02 +0000 Received: (at 36403) by debbugs.gnu.org; 4 Oct 2022 13:53:10 +0000 Received: from localhost ([127.0.0.1]:52962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofiM9-0004yg-SB for submit@debbugs.gnu.org; Tue, 04 Oct 2022 09:53:10 -0400 Received: from mail-ej1-f47.google.com ([209.85.218.47]:41795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofiM7-0004yF-IB for 36403@debbugs.gnu.org; Tue, 04 Oct 2022 09:53:08 -0400 Received: by mail-ej1-f47.google.com with SMTP id v22so1158618ejw.8 for <36403@debbugs.gnu.org>; Tue, 04 Oct 2022 06:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date; bh=k11sIsd7QvGmLOKvx00+evr4jYjKuwvESOcJuJ5g2bg=; b=V6Krttl9xcsAvENOI9LLmazxacbpIuGRVMp42si7ChpaQFTC+JwGvWit/BFXftIAJ1 dRg0p+yqkDinfHbaoquKA8lSX6enFK/RaORa9/Z5UDgmtI1h7/WcpxwqqvwerCIyR1FN R0uScdsjQO4b4a6yVL1DdPI+KYu8VVCyACXjd9fURxpUCoKesTn0h54zBclmCDEYTXky SG3awJmX5STdfMSOgpycWTJCqSu79NxizgBDHB1B0fz10TnKkUGlM+r78chFSTwfzT04 Zy97kNtIinUcj5OVo4HdgHAAxvfsqe39Qm3JufAWo1GhvhO7WYzGQMBH+TrZD1H+mBnk 0wFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=k11sIsd7QvGmLOKvx00+evr4jYjKuwvESOcJuJ5g2bg=; b=VoBtvvvNBBnKDc86jbr0XvFys0iKie87KH/j+qgm6HS9y1x5FxPGlukAMdr5DDrbbo 9yop++SELInOxxpequSsMrxR6OSqkO1ZR7Paix814kJ1dfYA+ruQ/JkDtdO6HvEJomAR hySU5fJ2E7SM/kLZaOSPKzGgPDAomJVE0zKZxaa20kEeRMzFVEkMlMmYMI/4HyslWFW9 UOe0PIQVvnnz2XdBJ8zti/zuDCgy8/itsoU2yB80vRrvvcpvn/RabMOhJqFcNTOxy1xB eG1rLGLbvhFFdZ3U4FoD+fQqMawXxD9JXDAPfO6GuBjg2qF3+g1NJCPC9GTHBXKkUUvO PDfg== X-Gm-Message-State: ACrzQf0VRECC0HfmOdH8OcoFRnKSPVirGoEjOB12AXvvWH3HUo5myel6 8AhqhKyybLLB2PeHDbsmQdNaNA== X-Google-Smtp-Source: AMsMyM7UTPcHht+EO2yJsJDZu2mQhldg1UFd5s33wXOXl+d0wHfv5uN6FqP9XA33g5+kq+MQShRn9w== X-Received: by 2002:a17:907:1607:b0:788:799e:dc97 with SMTP id hb7-20020a170907160700b00788799edc97mr14090447ejc.747.1664891581537; Tue, 04 Oct 2022 06:53:01 -0700 (PDT) Received: from localhost ([2a02:587:326a:a129:e754:c019:8715:df11]) by smtp.gmail.com with ESMTPSA id v25-20020aa7d9d9000000b00455262f83aasm1758453eds.32.2022.10.04.06.53.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 06:53:00 -0700 (PDT) From: "Basil L. Contovounesios" In-Reply-To: <877dts8cke.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 21 Aug 2020 13:26:25 +0200") References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> <83tvb9mggh.fsf@gnu.org> <8736glzmls.fsf@gnus.org> <87h7tkw4qh.fsf@gnus.org> <87blj7j4v0.fsf@gnus.org> <20200820230332.GB38852@breton.holly.idiocy.org> <87v9hcj4g9.fsf@gnus.org> <87r1s0j4af.fsf@gnus.org> <87imdcj3lg.fsf@gnus.org> <877dts8cke.fsf@gnus.org> Date: Tue, 04 Oct 2022 16:52:59 +0300 Message-ID: <87y1tvwv9g.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Lars Ingebrigtsen [2020-08-21 13:26 +0200] wrote: > Pip Cet writes: > >> Paul's suggestion was to use equal () instead of !NILP (Fequal (...)). >> I'm against that, because the F in Fequal kind of hints at the >> difficulties of using equal, of which there are many: in the current >> implementation, it can signal, quit, be asymmetric (signalling for >> (equal a b) whereas (equal b a) works), and is susceptible to equality >> bombs that take forever to compare. > > Yeah, your equal_lists is better in all ways, I think. It should be > much faster, too -- Fequal on a list checks whether the string members > are equal, too, which is slow. So I think this will speed things up if > you have a buffer that displays images where the data comes from a > string (which can be huge) instead of a file. We now have Fequal again: Restore Emacs 27 image cache semantics ac341cd629 2020-12-09 00:42:11 +0100 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=ac341cd629 Which means image-test-circular-specs signals: (circular-list (:dummy . #0)) So how important is it to support image specs with circular property values? Should the test be marked :expected-result :failed? Either way, WDYT of the attached minor cleanup? Thanks, -- Basil --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Touch-up-image-circular-tests.el.patch >From d22733866d5343b7a5a38ad8dc76312b1b0ed1f5 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Mon, 3 Oct 2022 23:34:07 +0300 Subject: [PATCH] Touch up image-circular-tests.el * test/manual/image-circular-tests.el (image-test-duplicate-keywords, image-test-circular-plist) (image-test-:type-property-value, image-test-circular-specs): Skip tests when there is no image support. Avoid wrapping entire test bodies in should or should-error; wrap only the relevant forms within the test body. Simplify with printed notation in place of function calls where applicable. Wrap long docstrings. (Bug#36403) --- test/manual/image-circular-tests.el | 38 ++++++++++++++++------------- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/test/manual/image-circular-tests.el b/test/manual/image-circular-tests.el index 1299970f82..df9031664b 100644 --- a/test/manual/image-circular-tests.el +++ b/test/manual/image-circular-tests.el @@ -29,6 +29,7 @@ (ert-deftest image-test-duplicate-keywords () "Test that duplicate keywords in an image spec lead to rejection." + (skip-unless (display-images-p)) (should-error (image-size `(image :type xbm :type xbm :data-width 1 :data-height 1 :data ,(bool-vector t)) @@ -36,33 +37,36 @@ image-test-duplicate-keywords (ert-deftest image-test-circular-plist () "Test that a circular image spec is rejected." - (should-error - (let ((l `(image :type xbm :data-width 1 :data-height 1 - :data ,(bool-vector t)))) - (setcdr (last l) '#1=(:invalid . #1#)) - (image-size l t)))) + (skip-unless (display-images-p)) + (let ((spec `(image :type xbm :data-width 1 :data-height 1 + :data ,(bool-vector t) + . ,'#1=(:invalid . #1#)))) + (should-error (image-size spec t)))) (ert-deftest image-test-:type-property-value () "Test that :type is allowed as a property value in an image spec." + (skip-unless (display-images-p)) (should (equal (image-size `(image :dummy :type :type xbm :data-width 1 :data-height 1 :data ,(bool-vector t)) t) - (cons 1 1)))) + '(1 . 1)))) (ert-deftest image-test-circular-specs () - "Test that circular image spec property values do not cause infinite recursion." - (should - (let* ((circ1 (cons :dummy nil)) - (circ2 (cons :dummy nil)) - (spec1 `(image :type xbm :data-width 1 :data-height 1 - :data ,(bool-vector 1) :ignored ,circ1)) - (spec2 `(image :type xbm :data-width 1 :data-height 1 + "Test with circular image spec property values. +In particular, test that they do not cause infinite recursion." + (skip-unless (display-images-p)) + ;; Two copies needed to warm up image cache. + (let* ((circ1 (list :dummy)) + (circ2 (list :dummy)) + (spec1 `(image :type xbm :data-width 1 :data-height 1 + :data ,(bool-vector 1) :ignored ,circ1)) + (spec2 `(image :type xbm :data-width 1 :data-height 1 :data ,(bool-vector 1) :ignored ,circ2))) - (setcdr circ1 circ1) - (setcdr circ2 circ2) - (and (equal (image-size spec1 t) (cons 1 1)) - (equal (image-size spec2 t) (cons 1 1)))))) + (setcdr circ1 circ1) + (setcdr circ2 circ2) + (should (equal (image-size spec1 t) '(1 . 1))) + (should (equal (image-size spec2 t) '(1 . 1))))) (provide 'image-circular-tests) ;;; image-circular-tests.el ends here. -- 2.35.1 --=-=-=-- From unknown Sun Jun 22 04:02:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36403: 27.0.50; Trivial image.c bugs Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Oct 2022 14:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: "Basil L. Contovounesios" Cc: Alan Third , 36403@debbugs.gnu.org, Pip Cet Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.166489240130672 (code B ref 36403); Tue, 04 Oct 2022 14:07:02 +0000 Received: (at 36403) by debbugs.gnu.org; 4 Oct 2022 14:06:41 +0000 Received: from localhost ([127.0.0.1]:54876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofiZF-0007yd-Dq for submit@debbugs.gnu.org; Tue, 04 Oct 2022 10:06:41 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofiZC-0007yP-UM for 36403@debbugs.gnu.org; Tue, 04 Oct 2022 10:06:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wr7uMuKmoeP1nwJhDvDM9sfNlRxJkUSzsKlnFhJZXbo=; b=Wykx4AF5rrc0eDDWX21un2kBsl pTIm5YXc4TBSuoftjtTncmWoufmApnwj39abXwEUpOx6TbReeXAOOp9WhteLiLNHxZ8P2NhzoIVrJ wYbwOk75yOl3z5byiYIgjHClvC9qe7oJeyMi1iaYY3vi7+a5V2oUS3j+HWKSoRDe2Qfs=; Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ofiZ3-0004TQ-3r; Tue, 04 Oct 2022 16:06:31 +0200 From: Lars Ingebrigtsen In-Reply-To: <87y1tvwv9g.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 04 Oct 2022 16:52:59 +0300") References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> <83tvb9mggh.fsf@gnu.org> <8736glzmls.fsf@gnus.org> <87h7tkw4qh.fsf@gnus.org> <87blj7j4v0.fsf@gnus.org> <20200820230332.GB38852@breton.holly.idiocy.org> <87v9hcj4g9.fsf@gnus.org> <87r1s0j4af.fsf@gnus.org> <87imdcj3lg.fsf@gnus.org> <877dts8cke.fsf@gnus.org> <87y1tvwv9g.fsf@tcd.ie> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEWdkXFgYltBNSxv gX6urpL////1g5C3AAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YKBA0qBkfLJ4cAAAGISURBVDjLdZPh kYQgDIXhoAACV4BQAcgWwI70X9O9BHTVc/PDGfKRl5BEpa5GbAn2zT+B/sEZXv8AioB4A1eprzn8 HdBufgJTqLIRhVpD7/09gaYTeF1AGCCAnYEJNbzs9h9o3M6qllCRrB/AKgOgACBW6QDNtgFMgFLN B+i9aZIIgCJFTdAkh6r8naBMYPrGUgBBlDYBrXcGmkYm+BE4cwCQDiajQlwrs1eWQXf8nmb10nUa fUcwcvRsM3RKWt4+0ZAaYHPZKEgsKUUKEmG5qt7IKi8DinGXQqEvPNLhxI7Ic/8AYxw2QULSBSDx mhh4BuUETGBpdt9BphX3JcsH1K6ckWP6Byx6PHLz/sR9tI03hR3k0Ftp1ogA4KctRL8dW/aRyuot b9ZRnkGobYKApoY17T1B3SNHFv4BR47sXMh63TuyV6UwCl6vZ6BOYP8NMDxXz0C6i2kTRyD/FcBB bvxRZW+JSHEnNJ1stlIRPXjvwMdH4GnsyQRjAHL5JCQgzZFeTaUv9gchl3huqTRFngAAACV0RVh0 ZGF0ZTpjcmVhdGUAMjAyMi0xMC0wNFQxMzo0MjowNiswMDowMGSjw44AAAAldEVYdGRhdGU6bW9k aWZ5ADIwMjItMTAtMDRUMTM6NDI6MDYrMDA6MDAV/nsyAAAAAElFTkSuQmCC X-Now-Playing: Latin Quarter's _Modern Times_: "Truth About John" Date: Tue, 04 Oct 2022 16:06:28 +0200 Message-ID: <87zgeb65uj.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "Basil L. Contovounesios" writes: > Which means image-test-circular-specs signals: > > (circular-list (:dummy . #0)) > > So how important is it to support image specs with circular property > values? Should the test be marked :expecte [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) "Basil L. Contovounesios" writes: > Which means image-test-circular-specs signals: > > (circular-list (:dummy . #0)) > > So how important is it to support image specs with circular property > values? Should the test be marked :expected-result :failed? Hm... don't know. > - (setcdr circ1 circ1) > - (setcdr circ2 circ2) > - (and (equal (image-size spec1 t) (cons 1 1)) > - (equal (image-size spec2 t) (cons 1 1)))))) > + (setcdr circ1 circ1) > + (setcdr circ2 circ2) > + (should (equal (image-size spec1 t) '(1 . 1))) > + (should (equal (image-size spec2 t) '(1 . 1))))) (cons 1 1) is not eq to (cons 1 1), but '(1 . 1) may or may not be eq to '(1 . 1) (depending on whether compiled or phase of the moon), which may be why that code is written that way? But in this case, I can't see how it would make a difference... From unknown Sun Jun 22 04:02:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36403: 27.0.50; Trivial image.c bugs Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Oct 2022 18:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Lars Ingebrigtsen Cc: Alan Third , 36403@debbugs.gnu.org, Pip Cet Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.166490673221616 (code B ref 36403); Tue, 04 Oct 2022 18:06:02 +0000 Received: (at 36403) by debbugs.gnu.org; 4 Oct 2022 18:05:32 +0000 Received: from localhost ([127.0.0.1]:55150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofmIN-0005cZ-Oz for submit@debbugs.gnu.org; Tue, 04 Oct 2022 14:05:32 -0400 Received: from mail-ej1-f54.google.com ([209.85.218.54]:38799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofmIH-0005cI-6p for 36403@debbugs.gnu.org; Tue, 04 Oct 2022 14:05:29 -0400 Received: by mail-ej1-f54.google.com with SMTP id nb11so30578106ejc.5 for <36403@debbugs.gnu.org>; Tue, 04 Oct 2022 11:05:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date; bh=I2bxcSAMyGG9wEfcWkfoGmuoIr1wKkOwZvm2wRg3+nI=; b=HnD9Cat0hHKm81XMqlhK0XJJ+X7WGq/z4wFSz2HE1xrLd4y/8qEuI8x0ItwVe6/oYq Vt3AL0I0w506ixzDNX/Zl7+Y8/pL6Sz7/RZTZTiatLr+mXj7i58NtgNLLg3LnW0SrgFl wi/u+KliDypSqiv3QS7UGWLN4D4H7Bduw+AVt1dysP/mVAM9wqWDKCgUI5Pf+tPG3bd8 kT96G3AqzIK7ktO2RkW39xhGfq94YDD+6wcutaqmbWwFW1x4lurTzp5/KkSeuzGYfxKc Kcb8Vz2nUIlitWKWCGZGdsW7oa/P/MS3YpP4TvODMZe0Eva52mFqx3duFMBnWdoTZ6ez IfZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=I2bxcSAMyGG9wEfcWkfoGmuoIr1wKkOwZvm2wRg3+nI=; b=tODhkMmFNcN5M5yw2csQ7rb0AkjKUOQuLq/kLvBEvfm6jpqLvZk0rg+u/DRC8TRq+K j+iRwv9UOnuyMC47a86H7ZvI0jlZV3LotlBBcM2thoNtKK+HXqy1+N/zOIP8+33723OK 6DxjB/ADJxBFfIfc7RtOOrycSFXNcKjRDJkA/sonm7mp97kL88SQWs32oAH3C93fzNNN QLHffQ/iE2Wsaxs49dcCS+F8T7Gyh0CdHnBmoCTzp0GLGdtn9TXQ++62IITgAJrHeqOo dFMuPAVwcN8W/EFYfrXxYcDDV90iUAAR2aVCERk0e3Tin05SNs6FYoPVl38TC3+j3xkq eJhA== X-Gm-Message-State: ACrzQf26+oSSk1g9sXqN1YwMcHo8LALyCs/KGpp/OIc5Pj69Laa+TSFT HMJBwTc8t/Be0xpW0sjEFkHfVw== X-Google-Smtp-Source: AMsMyM7LiRXkSTxaMwHX2wCkntdJkL1lO8AAXvgab4teN/3YwB11QhhgCRv+8UQjIYoQIi65nclQEw== X-Received: by 2002:a17:906:fe4a:b0:781:3b6:f8b0 with SMTP id wz10-20020a170906fe4a00b0078103b6f8b0mr21095957ejb.183.1664906719270; Tue, 04 Oct 2022 11:05:19 -0700 (PDT) Received: from localhost ([2a02:587:326a:a129:e754:c019:8715:df11]) by smtp.gmail.com with ESMTPSA id q13-20020a170906144d00b00781be3e7badsm7492427ejc.53.2022.10.04.11.05.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 11:05:18 -0700 (PDT) From: "Basil L. Contovounesios" In-Reply-To: <87zgeb65uj.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 04 Oct 2022 16:06:28 +0200") References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> <83tvb9mggh.fsf@gnu.org> <8736glzmls.fsf@gnus.org> <87h7tkw4qh.fsf@gnus.org> <87blj7j4v0.fsf@gnus.org> <20200820230332.GB38852@breton.holly.idiocy.org> <87v9hcj4g9.fsf@gnus.org> <87r1s0j4af.fsf@gnus.org> <87imdcj3lg.fsf@gnus.org> <877dts8cke.fsf@gnus.org> <87y1tvwv9g.fsf@tcd.ie> <87zgeb65uj.fsf@gnus.org> Date: Tue, 04 Oct 2022 21:05:17 +0300 Message-ID: <871qrnsbvm.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen [2022-10-04 16:06 +0200] wrote: > "Basil L. Contovounesios" writes: > >> - (setcdr circ1 circ1) >> - (setcdr circ2 circ2) >> - (and (equal (image-size spec1 t) (cons 1 1)) >> - (equal (image-size spec2 t) (cons 1 1)))))) >> + (setcdr circ1 circ1) >> + (setcdr circ2 circ2) >> + (should (equal (image-size spec1 t) '(1 . 1))) >> + (should (equal (image-size spec2 t) '(1 . 1))))) > > (cons 1 1) is not eq to (cons 1 1), but '(1 . 1) may or may not be eq to > '(1 . 1) (depending on whether compiled or phase of the moon), which may > be why that code is written that way? But in this case, I can't see how > it would make a difference... It doesn't matter whether the calls to image-size return the same object. What matters is that both calls succeed (that they return the correct result is also nice I guess, if that's what you're into ;). -- Basil From unknown Sun Jun 22 04:02:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36403: 27.0.50; Trivial image.c bugs Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Oct 2022 22:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Lars Ingebrigtsen Cc: Alan Third , 36403@debbugs.gnu.org, Pip Cet Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.166578567014604 (code B ref 36403); Fri, 14 Oct 2022 22:15:02 +0000 Received: (at 36403) by debbugs.gnu.org; 14 Oct 2022 22:14:30 +0000 Received: from localhost ([127.0.0.1]:38881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojSwn-0003nT-Kn for submit@debbugs.gnu.org; Fri, 14 Oct 2022 18:14:29 -0400 Received: from mail-ed1-f47.google.com ([209.85.208.47]:40593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojSwi-0003n8-GI for 36403@debbugs.gnu.org; Fri, 14 Oct 2022 18:14:28 -0400 Received: by mail-ed1-f47.google.com with SMTP id r14so8620382edc.7 for <36403@debbugs.gnu.org>; Fri, 14 Oct 2022 15:14:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=/vsYgQv3/PaSaFh0QaMOB3qypXcMaUtc0QwPZyaBSII=; b=LddS0iI24UCzRLOBLzI0e4FKg9KVG9qBxF0RAuAb0aB3CaGO7WphI54fJMiXVhBzLI YR7aJGV7yrEC6tMfIAv67ff5WDhONERplH/ytY5Zh7DuydOKJi5k03P2eqM+f/bDSVYI qutK+6Dmxa4UZToB4ZLUz7nLEpf1s+tBSV1b/lo7KgW1gDCd5/h8xrOHeDo8LTFaFB8g MPCTrvbR815aioZaLu6/uKd+uruMl+o6FXVfE+GxGD6hzgC1Go5mtVaz3dIUirviWR7u +BrAKGDL6K6GThQCoua+CjdXLT3pUKjelcUk7RKoaffFgY30e9WJ1nY5PfiMhgV8+6MX mvhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/vsYgQv3/PaSaFh0QaMOB3qypXcMaUtc0QwPZyaBSII=; b=fjCxtr3Arb/75xUxcCRcbWTHUXqM25ykI/1EuTQWizF6JdIPxG6tukYP89Wy9yG4+7 n+KMkAtNyiyK3fYtu9uqFN/PZcz1KDeW/N6nbANHSdDWirOoYNrO5XQKyFXychJgsx60 2VxTzjW/iV/n7O+DrkzkdFD/uVM5IhUIYoeWgfSgql2j5Jf63GeuYtvYtDBQY1aoI9pp +X9n6Lxjjqo+lhfB6b0BMIzJN3wQyA/J793xkf+hIyIbDCmrVRy9xOGlzv3fIzm4GiD3 iJwyBKLqC60mXAZ8ibJ65oUrUMKx24R7Ob9Gww21wTm4F/33bHUBzRAxYd8uSC08KYfM N+Lw== X-Gm-Message-State: ACrzQf1TZHX89/Z8yUzW88zDpecALzOnp7RcPaZLQilynfn04Wu6AZ19 6Z9O+J4kvSaTbzpOiRWCCqQ/AQ== X-Google-Smtp-Source: AMsMyM7ddzUXS0y4xuNwIHf7IxKX9ujYy5phFN/eGyePEG+p2UvZFWl1H/WxzaXvRdclEAxtEo25Ag== X-Received: by 2002:a50:ed85:0:b0:458:755b:d1c4 with SMTP id h5-20020a50ed85000000b00458755bd1c4mr5930679edr.413.1665785658518; Fri, 14 Oct 2022 15:14:18 -0700 (PDT) Received: from localhost ([2a02:587:321f:7e8a:d9:365a:ced1:b3d1]) by smtp.gmail.com with ESMTPSA id t14-20020a05640203ce00b00459e3a3f3ddsm2477413edw.79.2022.10.14.15.14.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Oct 2022 15:14:17 -0700 (PDT) From: "Basil L. Contovounesios" In-Reply-To: <87zgeb65uj.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 04 Oct 2022 16:06:28 +0200") References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> <83tvb9mggh.fsf@gnu.org> <8736glzmls.fsf@gnus.org> <87h7tkw4qh.fsf@gnus.org> <87blj7j4v0.fsf@gnus.org> <20200820230332.GB38852@breton.holly.idiocy.org> <87v9hcj4g9.fsf@gnus.org> <87r1s0j4af.fsf@gnus.org> <87imdcj3lg.fsf@gnus.org> <877dts8cke.fsf@gnus.org> <87y1tvwv9g.fsf@tcd.ie> <87zgeb65uj.fsf@gnus.org> Date: Sat, 15 Oct 2022 01:14:11 +0300 Message-ID: <87r0zauk7g.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen [2022-10-04 16:06 +0200] wrote: > "Basil L. Contovounesios" writes: > >> Which means image-test-circular-specs signals: >> >> (circular-list (:dummy . #0)) >> >> So how important is it to support image specs with circular property >> values? Should the test be marked :expected-result :failed? > > Hm... don't know. I've marked it as :expected-result :failed for now: Update image-circular-tests.el f5c6e628ed 2022-10-15 01:10:31 +0300 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=f5c6e628ed Thanks, -- Basil