From unknown Tue Aug 12 08:33:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36391: [PATCH] Improve an error message in bookmark.el Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jun 2019 10:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36391 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 36391@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.156154623519186 (code B ref -1); Wed, 26 Jun 2019 10:51:01 +0000 Received: (at submit) by debbugs.gnu.org; 26 Jun 2019 10:50:35 +0000 Received: from localhost ([127.0.0.1]:34344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg5Vb-0004zO-8Y for submit@debbugs.gnu.org; Wed, 26 Jun 2019 06:50:35 -0400 Received: from lists.gnu.org ([209.51.188.17]:55755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg5VY-0004zF-VT for submit@debbugs.gnu.org; Wed, 26 Jun 2019 06:50:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56029) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hg5VY-0000ai-29 for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 06:50:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hg5VR-0006hc-NC for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 06:50:30 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:36603) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hg5VN-0006Xf-N7 for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 06:50:23 -0400 Received: by mail-wr1-f43.google.com with SMTP id n4so2188142wrs.3 for ; Wed, 26 Jun 2019 03:50:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=YxjiRRHSZ2v0dscDHRPRF+E0F42/+dR0m2hlIO1Bf/M=; b=HhQK8d0PT29kzCuaQFJpcJNkbRJ695hr0hWgUzKToKuq64TY240X7dDZhzV1q0bRC+ o7fDMi2VniJNMSLRMEQmTIdn3JJvmQ5zYNhxfC53M77Bwm8BnLTcqN9m1VCVlMEYO3O4 XlC3DDPS2F36eK6VP5AFa5EtaerKldQ3tAEzj1/OtFmZtMOiFpbJxaM9uGwwJ46JAm1I lnlD/SasysCFV6qQrxSQc8reynySftT8WbpX9CB58VmEUHzc5AYNbpkSKyNMNYuhc1/w wICGm8mTN+hr1F0gKt6TP/0GSt0scui/uocDQQUs2xAsDpCkmI7URqJknycHTPED2dkv ABsw== X-Gm-Message-State: APjAAAVx/1qLgA5jPTTSOb3UIAdW9g5JIQVqwzRkOTOLhl8tC0Jb8QQN tr/mUl7LvNAcuy09CLiOo5bDHbsNiEAqZrawXeRRKS1P X-Google-Smtp-Source: APXvYqxtUC5u5ry444L3vPEedNZRL2wlyBGiJvCoFf/SPDdWrV+3BM/yMcusI7uoQMm4vuSBavijYwEhQqiCa6zHGTA= X-Received: by 2002:adf:dd91:: with SMTP id x17mr3329866wrl.291.1561546219945; Wed, 26 Jun 2019 03:50:19 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Wed, 26 Jun 2019 12:50:08 +0200 Message-ID: Content-Type: multipart/mixed; boundary="000000000000bda6d2058c37cfdf" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.43 X-Spam-Score: -0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) --000000000000bda6d2058c37cfdf Content-Type: text/plain; charset="UTF-8" The attached patch improves the error message when trying to run bookmark-load on an invalid file or buffer. Thanks, Stefan Kangas --000000000000bda6d2058c37cfdf Content-Type: application/octet-stream; name="0001-Improve-an-error-message-in-bookmark.el.patch" Content-Disposition: attachment; filename="0001-Improve-an-error-message-in-bookmark.el.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxd4ahb50 RnJvbSA5ZDk5YjQ3MzdkYzdjMTYzZmQ5Zjc2NzMzMTViY2Q0ZTkyYTQyMzlhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBXZWQsIDI2IEp1biAyMDE5IDEyOjMzOjQzICswMjAwClN1YmplY3Q6IFtQQVRDSF0g SW1wcm92ZSBhbiBlcnJvciBtZXNzYWdlIGluIGJvb2ttYXJrLmVsCgoqIGxpc3AvYm9va21hcmsu ZWwgKGJvb2ttYXJrLWFsaXN0LWZyb20tYnVmZmVyKTogSW1wcm92ZSBlcnJvcgptZXNzYWdlLgot LS0KIGxpc3AvYm9va21hcmsuZWwgfCA0ICsrKy0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlv bnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9saXNwL2Jvb2ttYXJrLmVsIGIvbGlz cC9ib29rbWFyay5lbAppbmRleCA1NTYzZWE2NDZjLi40MDFlN2UwNGExIDEwMDY0NAotLS0gYS9s aXNwL2Jvb2ttYXJrLmVsCisrKyBiL2xpc3AvYm9va21hcmsuZWwKQEAgLTY1NSw3ICs2NTUsOSBA QCBib29rbWFyay1hbGlzdC1mcm9tLWJ1ZmZlcgogICAgICAgICAgICAgKGZvcndhcmQtY2hhciAt MSkKICAgICAgICAgICAgIChyZWFkIChjdXJyZW50LWJ1ZmZlcikpKQogICAgICAgICA7OyBFbHNl IG5vIGhvcGUgb2YgZ2V0dGluZyBpbmZvcm1hdGlvbiBoZXJlLgotICAgICAgICAoZXJyb3IgIk5v dCBib29rbWFyayBmb3JtYXQiKSkpKSkKKyAgICAgICAgKGlmIGJ1ZmZlci1maWxlLW5hbWUKKyAg ICAgICAgICAgIChlcnJvciAiRmlsZSBub3QgaW4gYm9va21hcmsgZm9ybWF0OiAlcyIgYnVmZmVy LWZpbGUtbmFtZSkKKyAgICAgICAgICAoZXJyb3IgIkJ1ZmZlciBub3QgaW4gYm9va21hcmsgZm9y bWF0OiAlcyIgKGJ1ZmZlci1uYW1lKSkpKSkpKQogCiAKIChkZWZ1biBib29rbWFyay11cGdyYWRl LXZlcnNpb24tMC1hbGlzdCAob2xkLWxpc3QpCi0tIAoyLjIxLjAKCg== --000000000000bda6d2058c37cfdf-- From unknown Tue Aug 12 08:33:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36391: [PATCH] Improve an error message in bookmark.el Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jul 2019 14:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36391 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 36391@debbugs.gnu.org Received: via spool by 36391-submit@debbugs.gnu.org id=B36391.15624237749825 (code B ref 36391); Sat, 06 Jul 2019 14:37:02 +0000 Received: (at 36391) by debbugs.gnu.org; 6 Jul 2019 14:36:14 +0000 Received: from localhost ([127.0.0.1]:55711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjlnR-0002YP-Mk for submit@debbugs.gnu.org; Sat, 06 Jul 2019 10:36:13 -0400 Received: from quimby.gnus.org ([80.91.231.51]:53608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjlnP-0002YG-KM for 36391@debbugs.gnu.org; Sat, 06 Jul 2019 10:36:12 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hjlnM-0005LF-FB; Sat, 06 Jul 2019 16:36:10 +0200 From: Lars Ingebrigtsen References: Date: Sat, 06 Jul 2019 16:36:08 +0200 In-Reply-To: (Stefan Kangas's message of "Wed, 26 Jun 2019 12:50:08 +0200") Message-ID: <87h87zdycn.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > The attached patch improves the error message when trying to run > bookmark-load on an invalid file or buffer. Makes sense; I've applied it to the trunk. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > The attached patch improves the error message when trying to run > bookmark-load on an invalid file or buffer. Makes sense; I've applied it to the trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 06 10:36:19 2019 Received: (at control) by debbugs.gnu.org; 6 Jul 2019 14:36:19 +0000 Received: from localhost ([127.0.0.1]:55714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjlnW-0002Yh-Tr for submit@debbugs.gnu.org; Sat, 06 Jul 2019 10:36:19 -0400 Received: from quimby.gnus.org ([80.91.231.51]:53622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjlnU-0002YZ-Fs for control@debbugs.gnu.org; Sat, 06 Jul 2019 10:36:17 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hjlnR-0005LM-Sf for control@debbugs.gnu.org; Sat, 06 Jul 2019 16:36:15 +0200 Date: Sat, 06 Jul 2019 16:36:13 +0200 Message-Id: <87ftnjdyci.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #36391 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 36391 fixed close 36391 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 36391 fixed close 36391 27.1 quit