GNU bug report logs - #36371
'--with-commit' does not support tags

Previous Next

Full log

Message #8 received at 36371 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 36371 <at> debbugs.gnu.org
Subject: Re: bug#36371: guix build --with-git-reference=…
Date: Tue, 25 Jun 2019 14:38:44 +0200

Hi!

Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:

> bricewge on #guix informed me that there's no way to pass a git tag as
> source transformation option.  Indeed:
>
>  ‘--with-commit=PACKAGE=COMMIT’
>     This is similar to ‘--with-branch’, except that it builds   from
>     COMMIT rather than the tip of a branch.  COMMIT must be a   valid
> Git
>     commit SHA1 identifier.

Indeed:

--8<---------------cut here---------------start------------->8---
$ guix build guile-gcrypt --with-commit=guile-gcrypt=v1.0.0
updating checkout of 'https://notabug.org/cwebber/guile-gcrypt.git'...
guix build: error: cannot fetch commit v1.0.0 from https://notabug.org/cwebber/guile-gcrypt.git: unable to parse OID - contains invalid characters
--8<---------------cut here---------------end--------------->8---

Internally, that uses the ‘git-checkout’ record type defined in (guix
git).

What I would propose is to change ‘git-checkout-compiler’ so that it can
determine with a simple heuristic like that of (@@ (guix swh) commit-id?)
whether the string denotes a commit ID or a tag.

WDYT?

> - Why is the (extremely) git-specific ‘--with-commit=’ option not
> called ‘--with-git-commit=’?  Was it intended to be more generic than
> it is now?  Should the new option be ‘--with-reference=’ as well?
> That's pushing it a little far.  And three questions in one; I'm
> cheating.

Things are named this way for simplicity; the only exception is
‘--with-git-url’ because ‘--with-url’ would have been too vague.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.